summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-02-22elementary: tdf#138400 General Number Format iconsRizal Muttaqin
Change-Id: Ica0e26b766358cba97c76f8ba91c08514283d356 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130343 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-22Replace some fprintf with SAL_WARNStephan Bergmann
Change-Id: I3f31f223b6e906c6b40415a8d5c66c27e3c7cff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130338 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-22sort these alphabeticallyCaolán McNamara
Change-Id: I03f89dd78908d08534413c0fe6a753e3346b3738 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-22Remove a debug-style fprintfStephan Bergmann
...that had been added in 811de66d7fd8c93c43d8e4e2dc73720033ba939b "First attempt at getting access to the Java VM on Android", together with another fprintf(stderr, "Got lo_get_javavm = %p", lo_get_javavm); that had meanwhile been removed again in 5510127e89d6971a219ce3664e4631d6c6dda2b1 "Android code refactorig and hacking" Change-Id: I1a50563e2af1ea5a0ecbd2cc9d49d70c6e5bbbd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130337 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins
2022-02-22Better handling of msiRenwa Hiwa
LIBREOFFICE-SK4E5D8N Change-Id: I44f25a47ab6ffeb9d2b679874c8c96af1319eb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130335 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-22Add XWeak constructor and operator= to uno::WeakReferenceNoel Grandin
which is faster since we can skip the UNO_QUERY. Change-Id: Id95ad9f3568213e974bd13659d92d4ea94dbfbd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22CppunitTest_sc_tiledrendering: active LibreOfficeKit in the setUpXisco Fauli
Change-Id: I7099540ce2939a45d50193e74d08be19995bb23c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130286 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-22tdf#64914 small improvementsNoel Grandin
(1) do not read the config inside a hot loop (2) do not create a SvxShapeGroup only to remove it Change-Id: I8ff3840d0972d2f617a326a67d18260e44220f56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130331 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22tdf#147509: sc_jumbosheets: Add unittestXisco Fauli
Change-Id: I464d2ce3e79a9e79d034e4cce86d63355e0b5a81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130290 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-22merge poolio.cxx into itempool.cxxLuboš Luňák
It doesn't make sense to have few SfxItemPool functions in a separate source file, and without LTO those tiny functions do not get inlined, which is confusing when profiling. Change-Id: I0ba891ba51c7d8dd3eba3f4cae0f7819f9b033e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130327 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-22gtk3 a11y: Make a11y role mapping more explicitMichael Weghorn
Use switch-case instead of an array that uses the numerical value of the accessibility::AccessibleRole as an index. Change-Id: Id7fbc31c058d0db716d2b60a4a7eb7e7e954af95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130330 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-22gtk3 a11y: Just use ATK constants for rolesMichael Weghorn
The ATK role used here that was added to ATK latest is ATK_ROLE_FOOTNOTE, which was added in ATK 2.26. With a minimum ATK version of ATK 2.28.1 (s.a. Change-Id: Id7084366d2359deb60948b8969c1d3dcc68ddb47 "gtk3 a11y: Require atk >= 2.28.1, drop code for < 2.15.2"), all constants can simply be used as is, so drop the special handling that was there for older ATK versions which involved calling 'atk_role_register' that was deprecated in ATK 2.12 [1]: > Deprecated since: > Since 2.12. If your application/toolkit doesn’t find a suitable > role for a specific object defined at AtkRole, please submit a > bug in order to add a new role to the specification. [1] https://docs.gtk.org/atk/type_func.Role.register.html Change-Id: I93579e84576feb1bcae8cecf2dc8b264e8be3153 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130329 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-22gtk3 a11y: Require atk >= 2.28.1, drop code for < 2.15.2Michael Weghorn
README.md lists RHEL 7 or CentOS 7 as runtime baseline, which has ATK 2.28.1 [1]. Therefore, check for that version in configure.ac and drop some code for versions < 2.15.2. Requiring 2.28.1 as minimum ATK version will allow for further cleanup in follow-up commits. [1] https://centos.pkgs.org/7/centos-x86_64/atk-2.28.1-2.el7.x86_64.rpm.html Change-Id: Id7084366d2359deb60948b8969c1d3dcc68ddb47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130328 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-22tdf#147132: Flatten Basic function implementationsRamreiso Kashung
Some SbRtl_* functions have been flattened at basic/source/runtime/methods.cxx Change-Id: Id56485ddfaa972133c9b199d22b141d93df475f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130206 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2022-02-22eliminate a layer of conversion in createSymbol2DNoel Grandin
speeds up loading large charts Change-Id: I935971e21dd5384d8f3e04e0022fd81c2c1c8232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22sw: document SwNoTextNodeMiklos Vajna
Also make it a bit more clear that GetCharRect() and GetModelPositionForViewPoint() are the opposite of each other. Change-Id: I1ec2b57c047522e98c2fde0a4b698d5816884dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130304 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-22tdf#143148 Use pragma once instead of include guardsTushar Jham
Change-Id: If049cbcfc9b9a485c3be67e6111440662296b468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130293 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-02-22tdf#64914 slow opening large chartNoel Grandin
shaves 2% off the load time by avoid the cost of comphelper::getFromUnoTunnel Change-Id: I9d0438bd0ad3cf753d34fe181481f3a57193651c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22Adapt CustomTarget_postprocess/check_dynamic_objects to --enable-gtk4Stephan Bergmann
> instdir/program/libavmediagtk.so has suspicious NEEDED: libgtk-4.so.1 > instdir/program/libavmediagtk.so has suspicious NEEDED: libpangocairo-1.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libpango-1.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libharfbuzz.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgdk_pixbuf-2.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libcairo-gobject.so.2 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgraphene-1.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgio-2.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgmodule-2.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libglib-2.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libatk-1.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgobject-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgtk-4.so.1 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libpangocairo-1.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libpango-1.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgdk_pixbuf-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libcairo-gobject.so.2 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgraphene-1.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgio-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgmodule-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libglib-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libcairo.so.2 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libatk-1.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgobject-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libX11.so.6 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libXext.so.6 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libSM.so.6 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libICE.so.6 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libdbus-1.so.3 Change-Id: I686cdc5f21c9a730167e9efa120946f6d96eaed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130305 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-22Removed executable bits on data filesAndrea Gelmini
Change-Id: Ifcdae0106380de978c608f46e82155c6c9eed20b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130292 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-22Colibre: tdf#147575 Open <DB Object> iconsRizal Muttaqin
Change-Id: Iccf074831a0fcccf071dda6ec6900ae315eb0ba5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130285 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-02-21cid#1500693 Resource leakJulien Nabet
Change-Id: Ic560c2079be0b04ce382350390e03e0ec2d8abcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130303 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-21tdf#147089 - Round Integral Division (IDIV) literals to Integer valuesAndreas Heinisch
Change-Id: Ia243c6117a437d0c6efb33a4e76c5e9ee539fbdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130302 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-02-21Cleanup x509certificate_nssimpl.cxxHossein
* Remove unused headers * Remove 'using namespace' * Use enum values in the condition Change-Id: I45c20412db48ed1a3a4471db20193c2d9cde2f94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130214 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-21use 64bit for window sizes (tdf#147458)Luboš Luňák
Change-Id: Iaa240aeae8bacbff6bccd9bf0721a02414b6f47d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130288 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-21sw HTML export, XHTML mode: fix lost </li> when last list item is not numberedMiklos Vajna
This went wrong in 013a4f1f5c9ea5fb511568c53a7e76d1b365a65d (sw XHTML export: fix handling of list labels, 2021-05-13), where we started to assume that in case the last paragraph of a list is not numbered, then the entire list is not numbered. This lead to loosing the </li> for an <li> in case the list starts with a numbered paragraph, but ends with a non-numbered one. Fix the problem by (if necessary) looking back till the start of the list to see if any paragraph is numbered: that ensures that the <li> and </li> is always in sync. This fixes the new problem and keeps the old problem fixed at the same time. Change-Id: I7d347b37a40dcc727c2080bf8279e33c3ad147e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130287 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-21cid#1500477 silence Explicit null dereferencedCaolán McNamara
Change-Id: Ic57c49ce1c65ecca4e87be970e76bf16ba234711 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21cid#1500515 Dereference after null checkCaolán McNamara
Change-Id: I6483c3a036c5c56c8c6515b5b8f08720c8bd1a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130269 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21cid#1500612 Dereference after null checkCaolán McNamara
otherwise this doesn't make sense Change-Id: I321a86cf8f9f05639b686a4c15b2e8fca2e10955 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130271 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21Update git submodulesflywire
* Update helpcontent2 from branch 'master' to 2dabe39b5600714274285d364cd0600bc7662267 - Tweak ScriptForge GetDocument description to explicitly explain document must be open Change-Id: I9c2429de9114ed843215252803fa0118c113e41a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130162 Tested-by: Jenkins Reviewed-by: Alain Romedenne
2022-02-21cid#1500569 silence Explicit null dereferencedCaolán McNamara
likely silences it, an experiment Change-Id: I095d2dad74331a08ed649cea9bef08b63f9ef1de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130279 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21cid#1500621 silence Dereference after null checkCaolán McNamara
Change-Id: Ib8d5eff6e2489e66754b73bc3a59f152e344d35f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130278 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21upgrade to expat 2.4.6Caolán McNamara
Change-Id: Ibec5c6b2a321c48725e0888135c09d9b1835d0b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21CppunitTest_sd_uiimpress: Remove duplicated dispatchCommandXisco Fauli
SdUiImpressTest already inherits from unotest::MacrosTest Change-Id: If9683cf6ddb9c56913e19d9c7d1ebbf09864b742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130280 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-21Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 149fb7cb5fbb3f555c66b2c93d057776f63e9ce3 - update translations for master and force-fix errors using pocheck Change-Id: I84d3e51e5fc79ab4803b8df70e6522f9b34b8cc7
2022-02-21cid#1500584 Dereference before null checkCaolán McNamara
Change-Id: I7d5c0ba027e94d3f085eaacf158a31c525fa7eb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130277 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21cid#1500564 Dereference null return valueCaolán McNamara
Change-Id: Ia3e0521a013c3226f2fd5fdfef4e67dc1d5a0374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21cid#1500563 silence Explicit null dereferencedCaolán McNamara
probably silences it, an experiment Change-Id: I4bae3fb1d8907e6e02fa5e68a6fdb66e53e4f7b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130275 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21tdf#147164: vcl_pdfexport: Add unittestXisco Fauli
Change-Id: I254e9d7fa3795ee56080b9f065ab5112677fb7d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130244 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-21cid#1500559 silence Dereference before null checkCaolán McNamara
Change-Id: I515c2ba2b1a258dd897f28b12a08f1d1f48106d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130274 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21cid#1500396 silence Dereference after null checkCaolán McNamara
Change-Id: I284f256637a9e91a8cc5c431565a1ebe946a202c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130272 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21Avoid unnecessary empty -Djava.class.path=Stephan Bergmann
Change-Id: Idcfe7321077b60381c0273910b1faeb444ef1fd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130242 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-21speed up SvxShape::_setPropertyValueNoel Grandin
by using the Properties related code to create an SfxItemSet with the correct ranges, instead of creating an empty SfxItemSet and updating it. Shaves 2% off the load time of a large chart. Change-Id: Ia1f8527fa52ab5b8c70e13e1e2ab8c8f25739b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-21cid#1500465 Dereference after null checkCaolán McNamara
Change-Id: I3a9b1195c1694d6160c44da152b3502cdd501b3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21cid#1500458 Dereference after null checkCaolán McNamara
Change-Id: Ic9626b0817ee65fbc6d68592c592c3c2e39d42e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21cid#1500555 silence Untrusted loop boundCaolán McNamara
and others, we're not bothered that the contents of the string might have been constructed using byte swapping Change-Id: I0d0c2e0667bf270e2c15624c59312f3f203bb83c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21external/skia: Missing include (for std::max)Stephan Bergmann
Change-Id: If15570311857b3d5c7a44777f20df446a0d91ab6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-21Recheck modules sd* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I97c1a0e8c7f26807b12e6062581066d09ea13086 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130114 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-21libxml2: upgrade to release 2.9.13Michael Stahl
Fixes CVE-2022-23308 Change-Id: I1b3bf5cf58d7d1f39c224b0d898176c95107fbf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130241 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-21replace SfxPoolItem::LookupHashCode() with Lookup() (tdf#135215)Luboš Luňák
The LookupHashCode() way still loops over an array while calling virtual functions for a type that is actually known. Overriding instead a whole new Lookup() function that does the loop avoids the virtual calls, allowing compiler optimizations such as inlining, or class-specific optimizations like the hash code. So this still improves performance with ScPatternAttr a bit, for tdf#135215 it saves about 40% of load time, but this is scraping the bottom of the barrel, as this is still a linear search (the IsSortable() approach, if it worked, would be still 3x faster). Change-Id: I8fe5f70cabb77e2f6619d169beee8a3b4da46213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130228 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>