summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-04sw: prefix members of SwBlockCursor, SwAutoCompleteWord and TransWrpMiklos Vajna
Change-Id: I993ee72f9e162a72b1d4e89d98763fe0d2dee4d4 Reviewed-on: https://gerrit.libreoffice.org/68662 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-04Don't include shape/object name when exporting to tagged PDFKatarina Behrens
most of the time shapes have generated names such as 'Shape 42', those have ~no added value so let's not include them in Alt text Change-Id: I30314d5e901e11722e609dbf7ceddf74c5ed9707 Reviewed-on: https://gerrit.libreoffice.org/68520 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-04simplify UNO getTypes methodsNoel Grandin
Change-Id: Ia8b07edec54527fb4904536fabb03a18e8452550 Reviewed-on: https://gerrit.libreoffice.org/68659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Removed STR_SVT_ACC_LISTENTRY_SELCTED_STATEAndrea Gelmini
It passed "make check" on Linux. Just to spot it to devs. It seems to me it's not used anymore. Change-Id: I9549e4895d2e89a61d478ff26e142a4ddbd976df Reviewed-on: https://gerrit.libreoffice.org/68616 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Fix typoAndrea Gelmini
Change-Id: I343b4a34b98351a3573d99fb65a624ff57d88cad Reviewed-on: https://gerrit.libreoffice.org/68658 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-03Avoid unnecessary conversion to sal_uInt16Stephan Bergmann
(the negated value is ultimately passed to a short parameter of SvxLRSpaceItem::SetTextFirstLineOfstValue. This change has no acutal effect on the result, but silences Clang -fsanitize=implicit-signed-integer-truncation warnings. Change-Id: Ieefab13b9594fb6e19953c5f0ca22b36141ff986 Reviewed-on: https://gerrit.libreoffice.org/68648 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-03can rename CuiMacroEventListBox back to MacroEventListBox nowCaolán McNamara
Change-Id: I2f88488e7bb931238a31eb62f616c33c60c7ec2e Reviewed-on: https://gerrit.libreoffice.org/68650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-03weld SvxMacroAssignDlgCaolán McNamara
and SvxEventConfigPage, SvxMacroTabPage_, SvxMacroTabPage Change-Id: I98a2e71794f098015927dc7cd7ec4e258f56e703 Reviewed-on: https://gerrit.libreoffice.org/68649 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-03tdf#123821: Correct accidental overlap with IIDs used in CalcTor Lillqvist
These are used for functionality that hasn't really been tested yet, that I added right before moving on to other things last Spring, I guess, which is why I hadn't noticed. Change-Id: I1df26c5dff62269315b1a7eaaf574f7e38c452f6
2019-03-03Add XServiceInfo tests to ScAnnontationObjJens Carl
Change-Id: I866b057f768b29f14f7eaa75bc8db3591ddca836 Reviewed-on: https://gerrit.libreoffice.org/68635 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-03tdf#45904 Move XTextRange Java tests to C++Jens Carl
Move XTextRange Java tests to C++ for ScAnnotationObj (also fixes i109517). Change-Id: Id7e45d9f1159b45fb267cb28dc875b62eae12e24 Reviewed-on: https://gerrit.libreoffice.org/68634 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-03tdf#45904 Move XSimpleText Java tests to C++Jens Carl
Move XSimpleText Java tests to C++ for ScAnnotationObj (this also fixes i109517). Change-Id: Ieed0c94ed7a426c921c099a1edb520cbfd830656 Reviewed-on: https://gerrit.libreoffice.org/68632 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-03Simplify containers iterations in cppcanvas, cppu, cppuhelperArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I72bf7cdb632c04e2fc8d4f7ab85cb6571222aa07 Reviewed-on: https://gerrit.libreoffice.org/68636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-03More test cases for FOURIER formulaDennis Francis
This adds test cases for N(data length) for non powers of 2. This tests real and complex input cases. It also tests polar and non-polar output case. The reference(expected) numbers were obtained using fft() of Matlab R2018b. Finally the inverse transform is compared is compared with original inputs for correctness. Change-Id: Ibc13fb5ce900facd3fb0896e85a4e0d1694ad7f3 Reviewed-on: https://gerrit.libreoffice.org/68640 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-03-03FOURIER : use Bluestein's algorithm for N != 2^kDennis Francis
For inputs that are not an even power of 2, use Bluestein's algorithm[1] to match the output of fft()/ifft() in Octave/Matlab() in those cases. This algorithm is slower than radix-2 FFT algorithm but still has the asymptotic time complexity of O(N lg(N)). This patch also introduces considerable speedup in case of real valued inputs. DFT of a real valued input of length N can be computed using any DFT algorithm with a N/2 length complex valued input, provided we do some pre and post processing[2]. All implementations in this patch are written from scratch using the below theory references. [1] https://en.wikipedia.org/wiki/Chirp_Z-transform#Bluestein.27s_algorithm [2] Jones, K., 2010. Fast Solutions to Real-Data Discrete Fourier Transform. In The Regularized Fast Hartley Transform (pp. 15-25). Springer, Dordrecht. --------------------------- Below are some perf measurements for various input cases :- Timing numbers are only for the DFT computation part and does not include the time for writing data to the spreadsheet model. We don't use threading yet, so these are numbers for just one cpu-core. Exact Powers of 2 ================= Real Input size,Time (ms) 32768,2 65536,4 262144,21 1048576,185 Complex Input size, Time(ms) 32768,2 65536,5 262144,30 1048576,400 Even non-powers of 2 : 2^k - 2 ================================ Real Input size,Time (ms) 32766,8 65534,20 262142,105 1048574,1440 Complex Input size, Time(ms) 32766,15 65534,36 262142,313 1048574,3332 Odd non-powers of 2 : 2^k - 1 ================================ Real Input size,Time (ms) 32767,16 65535,39 262143,313 1048575,2729 Complex Input size, Time(ms) 32767,16 65535,38 262143,309 1048575,2703 Change-Id: Iccc31455e526ee5e6d18c20812dfa53defcf869f Reviewed-on: https://gerrit.libreoffice.org/68639 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-03-03HELPDELAY_SHORT is unused - get rid of related defines, tooMike Kaganski
It is unused since commit bd45c56a07e77662570f9dd5dc1710f8f9ca0e3b. Change-Id: I3d70b0cc112a6f4a8f57a65831cb0a46ac36514a Reviewed-on: https://gerrit.libreoffice.org/68641 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-03Make additional OTypeCollection::getTypes overload LIBO_INTERNAL_ONLYStephan Bergmann
(added recently with d559c28e9e65f3be415ec2e36ee90aa147e65b84 "expand out IMPL_XTYPEPROVIDER_START macro"), for extra compatibility safety. (At least MSVC exports non-inline versions of such CPPUHELPER_DLLPUBLIC inline functions from the cppuhelper DLL.) The original getTypes (added back now with <https://gerrit.libreoffice.org/#/c/68549/> "revert ABI change from 'expand out IMPL_XTYPEPROVIDER_START macro'") had been a non-const member function ever since at least b525a3115f54576017a576ff842dede5e2e3545d "initial import", presumably by accident. (Whether or not to return a reference is an orthogonal issue. With the newly added overload being LIBO_INTERNAL_ONLY, it is presumably fine to have it return a reference for now and see whether that causes any issues with lifetimes of temporary OTypeCollection instances.) Change-Id: If6abcf53b46b972204598774fed7cdd34d78440b Reviewed-on: https://gerrit.libreoffice.org/68637 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-03revert ABI change from "expand out IMPL_XTYPEPROVIDER_START macro"Noel Grandin
in commit d559c28e9e65f3be415ec2e36ee90aa147e65b84, instead add a separate const method Change-Id: If156dd07e77da2efe72c92198960311399151a9d Reviewed-on: https://gerrit.libreoffice.org/68549 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-03Sifr icon theme updateandreas kainz
Change-Id: I5c1baaf29d4649da983df6cff9c0f29e283f898e Reviewed-on: https://gerrit.libreoffice.org/68631 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-03yyinput() returns intStephan Bergmann
Change-Id: I2e1958bff9778bab65b5c972bc9e0721a86546f5 Reviewed-on: https://gerrit.libreoffice.org/68630 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-03Remove redundant bitwise and when converting from sal_uInt32 to sal_Int32Stephan Bergmann
...which has no effect on the result, but silences benign Clang -fsanitize=implicit-signed-integer-truncation warnings Change-Id: I0953914a35f2a8c4caa6f75d4918e3b3366d07e8 Reviewed-on: https://gerrit.libreoffice.org/68628 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-03Extend cast to whole expressionStephan Bergmann
...which has no effect on the result, but silences benign Clang -fsanitize=implicit-signed-integer-truncation warnings Change-Id: Ic2cf38466f12462d67ceb6268d5197e13cc6143a Reviewed-on: https://gerrit.libreoffice.org/68627 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-03Fix typoAndrea Gelmini
Change-Id: I405a69e54efef1cf86e9039659fd63573763d090 Reviewed-on: https://gerrit.libreoffice.org/68633 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-02OSQLNameEdit not needed as a buildable anymoreCaolán McNamara
Change-Id: I5a70db03ce8846ab56535b3f044d4519c4eeb4b1 Reviewed-on: https://gerrit.libreoffice.org/68626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-02drop newly unused OSQLNameComboBoxCaolán McNamara
Change-Id: I5de991355cc472d8ee1bc9f55713befca691e096 Reviewed-on: https://gerrit.libreoffice.org/68625 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-02weld OSaveAsDlgCaolán McNamara
Change-Id: I745cdca8b79308db27ccd4fd2c9d4b557e3f6fce Reviewed-on: https://gerrit.libreoffice.org/68624 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-02sync swxform ui files with swriter ui filesandreas kainz
Change-Id: Ie1e4a843e72351fabefba6f3a3c3fc9c35b40c46 Reviewed-on: https://gerrit.libreoffice.org/68606 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-02filter\ww8 export: don't spam RTL if ParaStyle definedJustin Luth
If the paragraph itself inherits BiDi from the environment, this just means that it gets the value of the paragraph style. If paraStyle is defined, then we don't need to spam the bidi property, since it ought to naturally inherit it. I can only see two possible problems. Either my logic is wrong, or else import might not always take the paragraph style into account (for determining the meaning of justify for example). I want to start spamming justify in the case where the BiDi is not specified but is inherited from the environment (page style or AppLanguage). Separating this into multiple patches will help for debugging in case of any regressive tendencies. related to tdf#98620. Change-Id: I36bc63e6659a4b491b5c6f2c99c72ba5bb715a07 Reviewed-on: https://gerrit.libreoffice.org/66921 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-03-02weld AddressBookSourceDialogCaolán McNamara
Change-Id: I3e83c41db04268b7370fdb7370f5b630419c6d4e Reviewed-on: https://gerrit.libreoffice.org/68622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-02Use comphelper::getProcessComponentContext()Tor Lillqvist
The context in the mxContext member does not seem to be usable for what we need it for here. Using what comphelper::getProcessComponentContext() returns works better. Let's hope it has no unintended side-effects. This likely makes the mxContext member unused, but I did not bother removing it yet, to keep this commit minimal. Change-Id: Ic048683b066af7952e2e84b03ea306e7daaba259 Reviewed-on: https://gerrit.libreoffice.org/68592 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-03-02Use sal_Int32 for the index as it comes in as a LONG at least from VBScriptTor Lillqvist
Change-Id: If39054148f72211eae3c897675708aab58f425b2 Reviewed-on: https://gerrit.libreoffice.org/68593 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-03-02Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - minor correction Change-Id: I900e7175a028599f320d80ff30822fcad55d9046 Reviewed-on: https://gerrit.libreoffice.org/68620 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-03-02Use implCopySequence to avoid overhead of non-const operator[]Mike Kaganski
Change-Id: I1e2385c6c7270f7bac9748a61fbf56e3e4246e1c Reviewed-on: https://gerrit.libreoffice.org/68621 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-02tdf#116084 DOCX track changes: fix w:del within w:insLászló Németh
Instead of showing the tracked deletion as tracked insertion, losing the original and actual text contents, now w:del within w:ins is imported as tracked deletion correctly. Change-Id: I40694a3a73ad4cd443254167462520c17b1bd484 Reviewed-on: https://gerrit.libreoffice.org/68478 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-02ofz#13431 fix buildCaolán McNamara
Change-Id: I29c271188dc96205e335dbf8d7b11a3711e6e634
2019-03-02weld SvxIconSelectorDialogCaolán McNamara
and use a ValueSet here instead of the odd toolbar use Change-Id: Ic2e78664ebde31751055d2c9fec66c7dabe8d05f Reviewed-on: https://gerrit.libreoffice.org/68598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-02weld SwInsertAbstractDlgCaolán McNamara
Change-Id: Ib3e9d0a7ff7e0fd3b0cf7bf492ca2bf59788fa2a Reviewed-on: https://gerrit.libreoffice.org/68594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-02tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScDataPilotItemsObj. Change-Id: Id8e83bb68408600f471148df7527467a371590fb Reviewed-on: https://gerrit.libreoffice.org/68611 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-02tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScDataPilotItemsObj. Change-Id: I66888c4515e84cf0e8f051378616c0ecbf60c0e8 Reviewed-on: https://gerrit.libreoffice.org/68610 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-02tdf#123705: avoid duplicate themeColorJulien Nabet
See http://bugs.documentfoundation.org/attachment.cgi?id=149585 + https://bugs.documentfoundation.org/show_bug.cgi?id=123705#c4 Change-Id: I3c6fb0a1ac46a62c75bb9daeaded1633889416eb Reviewed-on: https://gerrit.libreoffice.org/68398 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-02Fix typoAndrea Gelmini
Change-Id: Ib5409a3c9b22bf0caf950905a75559bdef8b057f Reviewed-on: https://gerrit.libreoffice.org/68612 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-02Sifr icon theme updateandreas kainz
Change-Id: If762921a9ff87831de6e62bb73850be26f752f1c Reviewed-on: https://gerrit.libreoffice.org/68605 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-02tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScDataPilotItemsObj. Change-Id: I6123692aee130f4c5bf326676ace2a6e7ac09405 Reviewed-on: https://gerrit.libreoffice.org/68609 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-02tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScDataPilotItemsObj. Change-Id: Ideb56b3f24d9b6045f68d7e5e84ee9858b6df7bf Reviewed-on: https://gerrit.libreoffice.org/68608 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-02Add XServiceInfo tests to ScDataPilotItemsObjJens Carl
Change-Id: Ie6e6e0edf9815744fd8ba97e0259b409db4d8c75 Reviewed-on: https://gerrit.libreoffice.org/68607 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-02tdf#122790 Improve background tab page for writer tablesJim Raykowski
This patch improves the new background tab page use for setting Writer table cell, row, and table backgrounds. Now cell, row, and table backgrounds fill tab page according to the fill style of each and can all be set in the same opening of a Table Properties dialog. This patch also makes the Reset reset background settings to initial settings of dialog opening. Change-Id: I567ef9229232f02d98b45a81309e920dca854bed Reviewed-on: https://gerrit.libreoffice.org/66844 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-03-01weld SwInsertDBColAutoPilotCaolán McNamara
Change-Id: I5e46a88de2ff11ecd38667338b84babee24a2a11 Reviewed-on: https://gerrit.libreoffice.org/68591 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-01weld SwChangeDBDlgCaolán McNamara
Change-Id: Ie0fc6a6346f9c777b7172a0b641a2783cf633c1d Reviewed-on: https://gerrit.libreoffice.org/68544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>