summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-18tdf#115554: Fix ownership in desktop-integration tarsMichael Weghorn
Use fakeroot to call tar when creating the tar.gz archives holding the desktop-integration parts to have root:root as owner of the files inside those. Change-Id: Idcdcb4dd398f330773671266dafb354711b0f093 Reviewed-on: https://gerrit.libreoffice.org/49827 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18tdf#115554: Create tar archives using 'fakeroot'Michael Weghorn
'tar' must be run as root or faked to be run as root, to make sure that file ownerships and permissions inside the created tar archives are as desired (root:root). Have fakeroot take care about creating an appropriate environment rather than using the custom "libgetuid", to no longer have to care about tar internals by ourselves. This fixes the problem that file ownerships are incorrect when tar version >= 1.24 is used for * tar archives holding all the generated deb/rpm packages (created in 'download.pm') * tar archives created by using the '--with-pacakage-format=archive' autogen option (created in 'simplepackage.pm') Change-Id: Id20ccce4d002ff95c75292eda8080ca299eee3a5 Reviewed-on: https://gerrit.libreoffice.org/49682 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18tdf#115554: Use 'fakeroot' to build Debian packagesMichael Weghorn
The command to create Debian packages must be run as root or faked to be run as root. The 'fakeroot' makes sure the command is run in an environment faking root privileges for file manipulation. This makes sure that file ownerships and permissions inside the created deb packages are correct. Using fakeroot instead of the custom "libgetuid" makes it unnecessary to care about internals of the underlying tools (like tar) and changes in those by ourselves. Change-Id: I2cbb203ab84f740377e535c1051c2b879779b164 Reviewed-on: https://gerrit.libreoffice.org/49597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18tdf#115602 keyboard navigation: Skip disabled toolbox itemsJim Raykowski
Change-Id: I793dd301a04435c79a97819497b9d34fa49e298b Reviewed-on: https://gerrit.libreoffice.org/49697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18[Pardus] tdf#108446 - Shape is not changed after saveMert Tümer
This patch is sponsored by ULAKBIM/PARDUS project. Signed-off-by: Mert Tümer <merttumer7@gmail.com> Change-Id: I7ee137b2332f799e4301cc3507df4a7b86af74b9 Reviewed-on: https://gerrit.libreoffice.org/47806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18rename non-unique id for better UI testingZdeněk Crhonek
Change-Id: Id271001411ae34269451008ca54ab5855aae7da5 Reviewed-on: https://gerrit.libreoffice.org/49305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Now we can remove this old checkOutput() for real.Kohei Yoshida
Change-Id: Ieff91dfd8195f1a5b8267753183e34e154a0c29a Reviewed-on: https://gerrit.libreoffice.org/49913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Use the variant of checkOutput that takes nested std::vector.Kohei Yoshida
That one is *the* future. We can't remove the old one just yet... Change-Id: I3c5b1bfee3d2cb8988b68ced5a38d52d641e5881 Reviewed-on: https://gerrit.libreoffice.org/49908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Add a test to make sure we import docs with empty rows correctly.Kohei Yoshida
The previous XSLT-based filter failed to import this correctly. Change-Id: I6218bd2b3e5c5ac1514f84b959be27df23a0c3f8 Reviewed-on: https://gerrit.libreoffice.org/49907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17tdf#114139 Don't export Plot Area shape property fot 3D chartsBartosz Kosiorek
For 2D charts Plot Area equivalent is Chart Wall. Unfortunately LibreOffice doesn't have Plot Area equivalent for 3D chart. It means that Plot Area couldn't be displayed and changed for 3D chars in LibreOffice. We cannot write Wall attributes into Plot Area for 3D charts, because Wall us used as background wall. Change-Id: I16d3b326571c1e411a094ec799e20c7aeeb2c1d4 Reviewed-on: https://gerrit.libreoffice.org/49428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
m_pAktColl -> m_pCurrentColl in ww8par Change-Id: I11299bab3c294345cd32d829003b2351192f9bf9 Note: Other occurrences of "Akt" will be done separately Reviewed-on: https://gerrit.libreoffice.org/49904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in ww8par2 Change-Id: I9ef8c2def230287abe405df894f85240a338c73d Note: Other occurrences of "Akt" in the affected files will be done separately Reviewed-on: https://gerrit.libreoffice.org/49906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in svdopath Change-Id: I4482d97fcd5891c7c8137432b6defa8d52f2ca0c Reviewed-on: https://gerrit.libreoffice.org/49900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in ww8 (leftovers in function names) Change-Id: I7ce1df76be01108d0e1f23522b09e20f75ae4ed3 Reviewed-on: https://gerrit.libreoffice.org/49903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in svparser Change-Id: I6c883a7690ca518ea773a08ab093d5db323122f5 Reviewed-on: https://gerrit.libreoffice.org/49901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in ascii filter Change-Id: I05637a65632b15b1ec0e0860bff15651dc25a8c4 Reviewed-on: https://gerrit.libreoffice.org/49899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in txtnode Change-Id: I5f8c615c0caf96d51077aba5b27ee68bbe6f3b72 Reviewed-on: https://gerrit.libreoffice.org/49902 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest for bugs #tdf114228 #tdf43078 #tdf105105Zdeněk Crhonek
Change-Id: I4fce7b1f492b6e32d48eb6f7d9c9edb6eba2c56d Reviewed-on: https://gerrit.libreoffice.org/49518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest - writer Format-Bullets and numberingZdeněk Crhonek
Change-Id: I5efeb41c13dbbaf8c5fffbb00a7503a89434c082 Reviewed-on: https://gerrit.libreoffice.org/49691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17ofz: infinite loopCaolán McNamara
Change-Id: Ie54c22c65ccd962862cade77e3502a264164c2b2 Reviewed-on: https://gerrit.libreoffice.org/49912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-17ofz: infinite loopCaolán McNamara
Change-Id: Icbc19a6761a9972d61db45b779dab56361bf6db8 Reviewed-on: https://gerrit.libreoffice.org/49915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-17uitest - writer Format CharacterZdeněk Crhonek
Change-Id: Ib4e78a19251ece9a24e3b87e5932b25c1002cd83 Reviewed-on: https://gerrit.libreoffice.org/48354 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest - writer; test form Bookmark dialogZdeněk Crhonek
Change-Id: I4c82c188b16604b808b25ec6710b59fa7310abf4 Reviewed-on: https://gerrit.libreoffice.org/47622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest for tdf#99386Zdeněk Crhonek
Change-Id: I1b9d03da4e5dff6149c98057976adc1cdcdb1770 Reviewed-on: https://gerrit.libreoffice.org/48802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17add uitest for bug tdf#115088Zdeněk Crhonek
Change-Id: Ic13f399cd489755ce97e026a9259c96c8aceb45e Reviewed-on: https://gerrit.libreoffice.org/48220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest - writer insert Page Footer; insert EnvelopeZdeněk Crhonek
Change-Id: Ifd931998607edbb526ec756f80b2bad13f541d63 Reviewed-on: https://gerrit.libreoffice.org/48086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest - writer Insert Horizontal LineZdeněk Crhonek
Change-Id: Ia44e18650b72ffe8d8d263f62dc6d5a31d1b0dc3 Reviewed-on: https://gerrit.libreoffice.org/47215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest - writer/ Special character dialogZdeněk Crhonek
Change-Id: I6de8570e5a2c1404cbf9c0a11f68373857a8836d Reviewed-on: https://gerrit.libreoffice.org/47035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17ofz#6427 use of uninitialized valuesCaolán McNamara
Change-Id: I357f1ef2ccf1c8f3f53effa6b38643523722202c Reviewed-on: https://gerrit.libreoffice.org/49910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-17tdf#115283: Avoid bashismTor Lillqvist
(We do require bash for other parts of the build, though, and have no plans to change that. But let's make the bug reporter happy here.) Change-Id: I4bcd3a86fb4e6f95d4eec8557faf359bf5549c03
2018-02-17Let's also check for the presence of the range names.Kohei Yoshida
Change-Id: Ic61370e495a8647a17eec484f8f32afe4dcc3b94 Reviewed-on: https://gerrit.libreoffice.org/49888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17loplugin:useuniqueptr in DbGridRowNoel Grandin
Change-Id: Ia3d7e2821213fb6e6ab5e13f707b5e07b26127a8 Reviewed-on: https://gerrit.libreoffice.org/49871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17iOS, add custom include for codesnippets.Sjan Iversen
Change-Id: I285838f6f3e8ec57a63239f71a403809154c47e2
2018-02-17iOS, readded perl script to generate codesnippetsjan Iversen
Change-Id: Ie9f3aa8057e9b50beedf47ff892188cf3b362194
2018-02-17tdf#115639: Align right/center with trailing spaces the same as MS PowerPointTamás Zolnai
* Add HoriAlignIgnoreTrailingWhitespace compatibility option. ** For MSO file formats it is set to true ** For ODP format it's set to false by default ** The flag is saved to ODP format as user data if the document comes from an MSO format. Change-Id: Ie22233d33a25e605de46120bfc2195038dffd63c Reviewed-on: https://gerrit.libreoffice.org/49889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-17loplugin:useuniqueptr in SdrUndoAttrObjNoel Grandin
Change-Id: I4174c1f1746dd501ce7428c3c2051dfed7042f7b Reviewed-on: https://gerrit.libreoffice.org/49870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17Revert "loplugin:changetoolsgen in sc" and reapply pluginNoel Grandin
because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit 95fab7cbf2f0576d0f728bed8898b7ff769d90e6. Change-Id: Icbdcc0f4227d88812be12e18ba6961088db80c3e Reviewed-on: https://gerrit.libreoffice.org/49840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17loplugin:useuniqueptr in FmEntryDataNoel Grandin
Change-Id: I6356807ad2b4e0e22908d59713de54842e1a0e00 Reviewed-on: https://gerrit.libreoffice.org/49878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17loplugin:useuniqueptr in FmXGridPeerNoel Grandin
Change-Id: Ie9a705852035eb99c9d0e5862c4d9f6bdb4c6a05 Reviewed-on: https://gerrit.libreoffice.org/49877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17loplugin:useuniqueptr in HyphenatorNoel Grandin
Change-Id: Icc45a38858004e1b8ea3a19df40f3cd71c469fdf Reviewed-on: https://gerrit.libreoffice.org/49876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17loplugin:useuniqueptr in ThesaurusNoel Grandin
Change-Id: I59a2cbeb08242ec1929b0c70f28e1d059dec70ca Reviewed-on: https://gerrit.libreoffice.org/49875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17loplugin:useuniqueptr in SpellCheckerNoel Grandin
Change-Id: I36a9fe01e228f3f2f5e441c369291da4c461f735 Reviewed-on: https://gerrit.libreoffice.org/49874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17loplugin:useuniqueptr in scaddinsNoel Grandin
Change-Id: I5c2c8301078d19824fb35966b158471ce6650c10 Reviewed-on: https://gerrit.libreoffice.org/49873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17loplugin:useuniqueptr in HWPFontNoel Grandin
Change-Id: Idd20e180fdd215028cf972e7ed97b37b7b9bed55 Reviewed-on: https://gerrit.libreoffice.org/49872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17Fix fontScale testSzymon Kłos
Change-Id: Idd16270cc6af0108442ba26db62ed933bbb0a63a Reviewed-on: https://gerrit.libreoffice.org/49881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-02-17Add a test case for global and sheet-local named expressions.Kohei Yoshida
Change-Id: I44247b55f3541214b515378744ee2c1982051e27 Reviewed-on: https://gerrit.libreoffice.org/49882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-16Consolidate the dreaded "Text - txt - csv (StarCalc)" filter nameEike Rathke
... into one define SC_TEXT_CSV_FILTER_NAME. This might prevent typos and doesn't look as ugly. Change-Id: If954852e5e6673331b29c4994f9d97c77b6564a6
2018-02-16tdf#115783 sd: fix lost char attributes during in-table copy&pasteMiklos Vajna
The SvxFontHeightItem (12pt) is originally a character-level property on the table cell (covering the whole cell text) but when the user sets the font height of the cell, sdr::properties::CellProperties::ItemSetChanged() will turn that into a paragraph-level property. This is fine, except that this way the property has unclear semantics when the user pastes single-paragraph content into an existing paragraph. (Keep the old paragraph properties? Use the new ones?) The current behavior is that sd::View::OnEndPasteOrDrop() calls into ContentAttribs::SetStyleSheet() at the end of the paste, which removes paragraph-level formatting (giving visibility to the from-style 18pt font height this way for the existing content), so both the old and the new paragraph formatting is lost. Improve the situation by copying these paragraph-level character properties back to character-level before paste at the paste position (so doc model is back to the state after load), that way font height and similar properties are not removed by the on-end-paste handler. Change-Id: I43d321dedcda6c0df9b009b9d99c3544f783473c Reviewed-on: https://gerrit.libreoffice.org/49868 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-16Add a test case for importing cell background colors...Kohei Yoshida
... from an Excel 2003 XML file via orcus. Change-Id: I58783acf80de7935e98673b982d8cfb0d4f085ce Reviewed-on: https://gerrit.libreoffice.org/49880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-16Resolves: tdf#114995 support CSV as Link to External DataEike Rathke
... with one CSV_all range for all data. Change-Id: Ibe7a8f5141394eb4592e83a69e620e4b1a6b5221