summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-27uitest: add the ModelessDialogVisible event to the execute_blocked_actionMarkus Mohrhard
Change-Id: I5496bf0bcce442c60d2ecd4207734d0e8b17935b Reviewed-on: https://gerrit.libreoffice.org/61026 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-27uitest: make it easier to log the received events for dialog creationMarkus Mohrhard
Change-Id: I1dc3041408c3f9fa9ce6023d7c668bc5baa65b4e Reviewed-on: https://gerrit.libreoffice.org/61025 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-27sw: new unit test for XAutoTextGroup and rdf::URIVasily Melenchuk
Change-Id: I989ff797ddcd4ce77ac9b87fde2a2f8f75dbbc6b Reviewed-on: https://gerrit.libreoffice.org/60961 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-27Fix prev blind fixStephan Bergmann
Change-Id: I58d534e7da346062c631791f9c016850602e40ad Reviewed-on: https://gerrit.libreoffice.org/61024 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-27Blind fix for error with old ClangStephan Bergmann
<https://ci.libreoffice.org//job/lo_ubsan/1050/consoleFull#-18477798892a810015-1db5-427c-9ce2-83b5f06a5284>: > In file included from /home/tdf/lode/jenkins/workspace/lo_ubsan/codemaker/source/codemaker/exceptiontree.cxx:28: > /home/tdf/lode/jenkins/workspace/lo_ubsan/include/unoidl/unoidl.hxx:507:9: error: constructor for 'unoidl::SingleInterfaceBasedServiceEntity::Constructor' must explicitly initialize the const member 'annotations' > Constructor(): defaultConstructor(true) {} > ^ > /home/tdf/lode/jenkins/workspace/lo_ubsan/include/unoidl/unoidl.hxx:524:44: note: 'annotations' declared here > std::vector< rtl::OUString > const annotations; ^ 1 error generated. Change-Id: I041a67599b48959bcca136bab646f6943d071bed
2018-09-27tdf#118065 Fix slow Impress custom animation sidebar updateBrian Fraser
Timer MainSequence::maTimer dropped from 500ms to 50ms. Reorder declarations of UI elements in CustomAnimationPane.hxx to be more intuitive and reflect order shown in UI. Change-Id: I2857dbbd6a4131c4ca6f9a054132f34056e95338 Reviewed-on: https://gerrit.libreoffice.org/61019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27tdf#120122 Fix key input being passed to doc view from floating sidebarJim Raykowski
...tab bar Change-Id: Iae327e0de3a129f28315a3fe2961a6ae572e4056 Reviewed-on: https://gerrit.libreoffice.org/61020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in SwReader::ReadNoel Grandin
Change-Id: Iff7936e440951e65653ef42ce5a2aebd22a03029 Reviewed-on: https://gerrit.libreoffice.org/61004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in SwObjPosOscillationControlNoel Grandin
Point is a small object, no need to store separately on the heap Change-Id: Id8fb1829b711831860ad1d7709fb4bf71ae8ff09 Reviewed-on: https://gerrit.libreoffice.org/61002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in ScTable::FillAutoNoel Grandin
Change-Id: Ia75a0dc9aa567b00517c066a65e4a0d1536fa9bd Reviewed-on: https://gerrit.libreoffice.org/60999 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in Chart2PositionMapNoel Grandin
Change-Id: I6db63c66da67fa9133333b4d0cda2b2978140e77 Reviewed-on: https://gerrit.libreoffice.org/60998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in ScAddInAsyncsNoel Grandin
Change-Id: I18086623378a6ffd9272b2255ea8060d301b6c43 Reviewed-on: https://gerrit.libreoffice.org/60997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:constfields in toolkitNoel Grandin
Change-Id: I26254acc84b1bfe71e4addbde51cb6a9ed52c981 Reviewed-on: https://gerrit.libreoffice.org/60990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:constfields in toolsNoel Grandin
Change-Id: I83499cfb49f7abdbf0629c60167d09a1352571ee Reviewed-on: https://gerrit.libreoffice.org/60987 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:constfields in ucbhelperNoel Grandin
Change-Id: Ic9d59b352dcb771191de963c0f6e90c74647c8b8 Reviewed-on: https://gerrit.libreoffice.org/60983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27editeng ConvertBorderWidthToWord ensure minimum widthJustin Luth
If the border in LO has a width, then make sure that the converted width is non-zero. The specific fix intended is for the "Horizontal Line" paragraph style (double, width =1) to export to .doc format and retain the bottom border. Change-Id: I65392b2312360d51c290030ceb415155e6139302 Reviewed-on: https://gerrit.libreoffice.org/61006 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-27tdf#119037 rtf (im/ex)port: new borderlinesJustin Luth
"new" borderlines (from 2012, 2014) defined in offapi/com/sun/star/table/BorderLineStyle.idl where no supported in export yet!!! Sad. const short FINE_DASHED = 14; (rtf) const short DOUBLE_THIN = 15; (rtf/doc/docx) const short DASH_DOT = 16; (rtf/docx) const short DASH_DOT_DOT = 17; (rtf/docx) Change-Id: I07fee08e17171db4baec489864fc47da107cee75 Reviewed-on: https://gerrit.libreoffice.org/60992 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-26make the UI element IDs locally unique in impress header footer dlgMarkus Mohrhard
Change-Id: I368405acc7dfbd210cfc0115e58e993846ab9497 Reviewed-on: https://gerrit.libreoffice.org/60985 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-26uitest: checking whether we have focus needs to be recursiveMarkus Mohrhard
Change-Id: Id18a56cdf5b23433178882a953fd85954c0ccc1c Reviewed-on: https://gerrit.libreoffice.org/61008 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2018-09-26fix positioning within cellprotectpageCaolán McNamara
Change-Id: I9ae7fd7f6ff7b999018cc0ba13147dd69dc7e9ae Reviewed-on: https://gerrit.libreoffice.org/61010 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-26tdf#119037 doc/x export: new borderlinesJustin Luth
"new" borderlines (from 2012, 2014) defined in offapi/com/sun/star/table/BorderLineStyle.idl were not supported in export yet!!! Sad. const short FINE_DASHED = 14; (rtf) const short DOUBLE_THIN = 15; (rtf/doc/docx) const short DASH_DOT = 16; (rtf/docx) const short DASH_DOT_DOT = 17; (rtf/docx) Change-Id: I085bb4c70e53241fb59a4a3c97d7741cef841412 Reviewed-on: https://gerrit.libreoffice.org/60991 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-09-26Fix BMP_REDLINE_FORMATED -> BMP_REDLINE_FORMATTEDAndrea Gelmini
It passed "make check" on Linux. Change-Id: Ic3e9a1c2d9ecd2fd8583592c8cf68a3916196984 Reviewed-on: https://gerrit.libreoffice.org/60858 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-26Fix typoAndrea Gelmini
Not so sure, but anyway, let's see what the gods say. Change-Id: I5abffb27f8d124c34b50a3591de1ffc8c64fa13a Reviewed-on: https://gerrit.libreoffice.org/60994 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-26Fix typoAndrea Gelmini
Change-Id: Ic0727720b1df3a26273e8dbe2a1a9f872f2a3e41 Reviewed-on: https://gerrit.libreoffice.org/61007 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-26sw AdjustCellWidth rewrite for clarityJustin Luth
This section has absolutely nothing to do with the previous idea of a "wish" width. It is dealing with actual, current cell width regardless of content. Change-Id: I53b615cb7ea61554ff3f83d253b97b0e1f38d547 Reviewed-on: https://gerrit.libreoffice.org/60904 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-26tdf#42949 Fix IWYU warnings in chart2/source/controller/chartapiwrapper/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I07bdc60ecc2d8ff9ad9c109f32b350eb09ac72e5 Reviewed-on: https://gerrit.libreoffice.org/60921 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-26Fix preset_maping -> preset_mappingAndrea Gelmini
It passed "make check" on Linux Change-Id: I37c9af2a0687e292475d43a37b85e222c187f711 Reviewed-on: https://gerrit.libreoffice.org/60690 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-26Fix ID_DELIMETER->ID_DELIMITERAndrea Gelmini
It passed "make check" on Linux Change-Id: Ic119935ca45f985b3cd088b16db4128ffaf2d1a2 Reviewed-on: https://gerrit.libreoffice.org/60642 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-26Fix _bToogleOn -> _bToggleOnAndrea Gelmini
It passed "make check" on Linux Change-Id: I2b26805bc3be7c8cb9ee8cd85fd8fcb35dd4fc58 Reviewed-on: https://gerrit.libreoffice.org/60632 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-26tdf#120065 and tdf#120108, Fix wrap elementary iconsRizal Muttaqin
Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b8 Reviewed-on: https://gerrit.libreoffice.org/60950 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-09-26loplugin:constfields in ucbNoel Grandin
Change-Id: I81a4b6241d6ff2e04903ddf2955463514d04ac0b Reviewed-on: https://gerrit.libreoffice.org/60986 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26loplugin:constfields in unoidlNoel Grandin
Change-Id: I8d13626322e419d5d21a8e364de446bb6804ffa6 Reviewed-on: https://gerrit.libreoffice.org/60982 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26tdf#119882, don't change the chart model from the chart viewMarkus Mohrhard
Change-Id: I1c909f6e1984bd4b09c3b67c19659dc276ac3229 Reviewed-on: https://gerrit.libreoffice.org/60984 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-26sw: use auto when initializing with a template cast ...Miklos Vajna
... to avoid duplicating the type name. Change-Id: I98379b35baeccf685bcadecf794e73e91024da0b Reviewed-on: https://gerrit.libreoffice.org/60979 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-26loplugin:useuniqueptr in SplineCalculaterNoel Grandin
Change-Id: Ie14e0aaff07fbbaab834158f4666b819a0ba2dbc Reviewed-on: https://gerrit.libreoffice.org/60967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26loplugin:useuniqueptr in LwpFormulaInfoNoel Grandin
Change-Id: Iac1f025f1311ef05fd48581d5bee9875163f4f2b Reviewed-on: https://gerrit.libreoffice.org/60972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26loplugin:useuniqueptr in VbaApplicationBase_ImplNoel Grandin
Change-Id: I4ce3cba4a6f5cfec677550a4263bb3e4cc795c49 Reviewed-on: https://gerrit.libreoffice.org/60974 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26loplugin:useuniqueptr in OfaLanguagesTabPageNoel Grandin
Change-Id: I9fcbac58f1b0a13b83dc24c8e2f256016b5f31b8 Reviewed-on: https://gerrit.libreoffice.org/60973 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26loplugin:useuniqueptr in LwpFormulaInfoNoel Grandin
Change-Id: I73fbad626ab1d37448ea12052a2fbafab5656fc7 Reviewed-on: https://gerrit.libreoffice.org/60971 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26loplugin:useuniqueptr in XFIndexNoel Grandin
but actually this object should be held by rtl::Reference Change-Id: Iabf068bd909201af5df6f987c6dcdb64679fefbd Reviewed-on: https://gerrit.libreoffice.org/60970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26loplugin:useuniqueptr in SvgDocumentNoel Grandin
Change-Id: I299e97c276b60be86491bfeee22d46774739ca44 Reviewed-on: https://gerrit.libreoffice.org/60969 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26loplugin:useuniqueptr in lcl_LookupTableHelperNoel Grandin
Change-Id: I8ee34ced61a23d7ade71b25f547c607cd4fe37bb Reviewed-on: https://gerrit.libreoffice.org/60968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add debug info for HID in new help To enable Help page debug, add '&Debug=1' to the page URL. This patch pass the HID in the URL of the help page and displays it in the debug div in the bottom of the page. It should help to locate missing pages for a given HID. Change-Id: I671feb2dc34baaef5230028ba918a407d4cfea76 Reviewed-on: https://gerrit.libreoffice.org/60843 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-25uno: extra exception for XAutoTextGroup:removeByNameVasily Melenchuk
According to idl, removeByName() should throw NoSuchElementException on invalid element, but it does not Change-Id: I4ae84cd8c5a0f46bedeb3df6da4dee076888295f Reviewed-on: https://gerrit.libreoffice.org/60978 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-25sw: new unit test for XTextFieldsSupplierVasily Melenchuk
Change-Id: I44c2fd97beeaa328774e241459b2a631b6a72030 Reviewed-on: https://gerrit.libreoffice.org/60794 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-25Queue notifications only oncePaul Trojahn
AccessibleTextHelper already queues notifications, so another queue in editeng isn't needed. Change-Id: I31c69a21e2379da99cba559208eb5475ddccddfe Reviewed-on: https://gerrit.libreoffice.org/60918 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25screenshots: add better diagnostics for failing CIThorsten Behrens
Output current UI file being processed, in case any random exception pops up. Change-Id: If6937f70718cc801494f424f7e09e9cb8c8758f0 (cherry picked from commit fb5d849cdeebe5299da399efc9d0ca36b6fc192b) Reviewed-on: https://gerrit.libreoffice.org/60964 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-25sw: new unit test for XNamedGraphSerge Krot
Change-Id: I222179c92cda3e0b2503544b7f120f35957265ac Reviewed-on: https://gerrit.libreoffice.org/60815 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-25sw: new unit test for XTextTableSerge Krot
Change-Id: Ide5e7dd75ddb30eb1db61406c6811c6846d603bd Reviewed-on: https://gerrit.libreoffice.org/60694 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-25loplugin:useuniqueptr in SvImpLBoxNoel Grandin
Change-Id: I59aa026217ed250fab68afc4aa0086d4d1300eac Reviewed-on: https://gerrit.libreoffice.org/60627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>