summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-24fix tb71 buildNoel Grandin
after commit 7916487cf4d9603cdbe4c7ffbe9bb3f28b51ce4e "convert ViewShellId to o3tl::strong_int" Change-Id: Ie7b8ac51a94c3b9e6d39e397aa3dd5cb42acc6d0 Reviewed-on: https://gerrit.libreoffice.org/35623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24when getting the naked VCL Window from UNO: hold the solar mutexBjoern Michaelsen
Change-Id: Ia3513d67e09cdc9748a24aeffce0ec59cab30cc9 Also: fix some obvious violations of the above. Reviewed-on: https://gerrit.libreoffice.org/35605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-24Various loplugin warnings (clang-cl)Stephan Bergmann
Change-Id: I7969250f330d2df02c4ea909115b3028fdc36223
2017-03-24git pre-commit hook: Also check swift filesSamuel Mehrbrodt
Change-Id: I60c7ccd06b104c6a6ae5e7985fe8c3215f7e97d4 Reviewed-on: https://gerrit.libreoffice.org/35624 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2017-03-24loplugin:unusedfieldsNoel Grandin
improve the plugin to find fields which are only assigned to in the constructor Change-Id: I95b5be238ebba83d950ca15093abdd1849740359 Reviewed-on: https://gerrit.libreoffice.org/35613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24vcl: clean up ANDROID ifdefs in pdfwriter_implMiklos Vajna
HAVE_FEATURE_NSS is already 0 on Android, so an "&& !defined(ANDROID)" is redundant. Change-Id: I275ed71d9ebdb56878d980a23c4480e41b28bd6b Reviewed-on: https://gerrit.libreoffice.org/35614 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-24Handle "POSIX" in parse_locale, 2nd attemptStephan Bergmann
...with the silly errors fixed past 61ecebe0d0febe8429d965355356a9f0f34b323b "Revert 'Handle 'POSIX' in parse_locale'" Change-Id: I0b8e4de0377b92b8cb96efa13e4b39316ffbf707
2017-03-24tdf#90856 Hide "Format Area" command for line objects in WriterGulsah Kose
Change-Id: Ib90aba380be7eeef3c7418ea85b553079794cf87 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
2017-03-24tdf#86119 Fix toggle behaviour of SID_NUMBER_TWODEC.Gulsah Kose
Change-Id: If17935cbb35c1a57fe9ea4cfaca58385ed437842 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
2017-03-24blind fix for screenshot buildNoel Grandin
after commit 88ec24a23a10af771879421360fe4330cbf174b0 "convert NAME constants to CreateNameFlags o3tl::typed_flags enum" Change-Id: I6025e2d2a1717e4741f0241ea65d4a49bb8da917
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24fix annotation iconandreas kainz
Change-Id: Ie65c6698b0f5478bfb6c9d58bfec1bc814e9cadf Reviewed-on: https://gerrit.libreoffice.org/35601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-03-24[pt_PT] Added 11 new words to autocorrect.Marco A.G.Pinto
Change-Id: Id14a6da3959006a541e26e6e84d6a4eb0b070651 Reviewed-on: https://gerrit.libreoffice.org/35187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-03-24Remove near-duplicated code.Kohei Yoshida
Change-Id: I46e743ae47c76c4e9c22d092f501636ebab92878 Reviewed-on: https://gerrit.libreoffice.org/35606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-24UNO objects should never hold a VclPtr they dont own on heap ...Bjoern Michaelsen
... so admit that the VclPtr that ChartController used to have is really owned by m_xViewWindow, and get fetch that (stack-scoped only) from there. Change-Id: Ib9e2cd20201ebe5019c3607a8c65cb1a9856812f Reviewed-on: https://gerrit.libreoffice.org/35603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23Lets not call 1/2 of everyone we know friend...Bjoern Michaelsen
...esp. when they dont even need it. Change-Id: If9d00da3110328d88e832f12b8717a93f91393aa Reviewed-on: https://gerrit.libreoffice.org/35602 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23loplugin:redundantcastStephan Bergmann
Change-Id: Icc700698711174246c5fc800105ac5b7c6102296
2017-03-23Change SvxMSDffManager::ImportOLE nOLEId parameter from long to sal_uInt32Stephan Bergmann
The only place this function is called (SvxMSDffManager::ImportGraphic, filter/source/msfilter/msdffimp.cxx) it is passed the sal_uInt32 return value from a call to DffPropSet::GetPropertyValue, so that seems a better type. (SvxMSDffManager::ImportOLE used long at least since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter"; DffPropSet::GetPropertyValue used UINT32 back then, changed to sal_uInt32 with e8c2c1daae9008d383288f94600b1d34d2059fb1 "removetooltypes01: #i112600# remove tooltypes from filter". Unclear if those had ever had more compatible types in the distant past.) Change-Id: Ia486d169cd2cc0e73042e72fd4476cc2ae0e8cc5
2017-03-23Lets not call 1/2 of everyone we know friend...Bjoern Michaelsen
...esp. when they tend try to own our private parts. Lets be honest here. Also remove pointless repeated private:s. Change-Id: Idaa7621fbe812ef25f13bba1882a16cca4de9d61 Reviewed-on: https://gerrit.libreoffice.org/35600 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23loplugin:redundantcastStephan Bergmann
Change-Id: I1bc2fbe98f24b173cfda4661f812575a2008c792
2017-03-23Lets not call 1/2 of everyone we know friend...Bjoern Michaelsen
...esp. when they tend try to own our private parts. Lets be honest here. Also remove pointless dynamic_casts. Change-Id: Ie6ef8a0c07a72aaa15e374e5ec6841520c0fafb1 Reviewed-on: https://gerrit.libreoffice.org/35599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23Remove unused #include <ctype.h>Stephan Bergmann
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-23ofz: when skipping actions, only skip forwardsCaolán McNamara
Change-Id: I1a80de4bf5c6c44ed10c1b720f85895ad8f4f8e5
2017-03-23add svm cppunit testCaolán McNamara
and rely on new safe multiple check of commit 4f0b226600fdad4e5aef9313fe8754c765cfee42 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Mar 21 11:23:09 2017 +0000 check for overflow in multiply rather than trying to detect them here in advance Change-Id: I7fb9a9960e428cf00f745b6156a588e2c990c03f Reviewed-on: https://gerrit.libreoffice.org/35595 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-23loplugin:redundantcast toNumericWithoutDecimalPlace returns sal_Int64 alreadyCaolán McNamara
Change-Id: Iccb11bb5067d6de06ff8786c0acd1af27ffaf8fd
2017-03-23Resolves: tdf#106461 use a row height of max of edit and listbox heightCaolán McNamara
not just take the listbox because edits can be taller and result in overlaps Change-Id: I6067b384484d933727220febda723bc9e8c5e90b
2017-03-23No need for a temporary OString hereStephan Bergmann
Change-Id: I94115baf51dcb52999d97ad1dc3302b109990b04
2017-03-23tdf#106693 vcl PDF export, norefxobj: handle compressed page streamMiklos Vajna
Since we want to avoid re-compressing the page stream create two form XObjects: one that resets the graphic state to the default (e.g. line width) and an other one that contains the original page stream as-is. With this PDF images where the page stream is compressed are handled correctly. Change-Id: Ib44dae2e167e4d5604a0a3a3cf91e09795137343
2017-03-23loplugin:loopvartoosmallStephan Bergmann
Change-Id: I21e54bf70108991b7ca7f96232e6d9411af23ff9
2017-03-23ofz: readjust LLVMFuzzerInitialize to get ppt SdDLL::Init outside leak detectCaolán McNamara
Change-Id: I01a6d19ef27c4678929e8e7554569c9219ea83f6
2017-03-23configure: remove hack to add quotes to $DEVENV againMichael Stahl
This was added because CPPUNITTRACE='"$(DEVENV)" /debugexe' is less convenient to write than CPPUNITTRACE='$(DEVENV) /debugexe'. However DavidO points out that CPPUNITTRACE=TRUE is even more convenient and sort of optimal already, and it turns out it's broken by the extra quotes, so remove the hack. Change-Id: Ic5d94f9a0774cd41821b68728404c205552d674e Reviewed-on: https://gerrit.libreoffice.org/35589 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-23Use rtl::toAsciiLowerCaseStephan Bergmann
Change-Id: I44e9f9382de2a7235b02ad94ff51b7f21295f2ae
2017-03-23Remove unused #include <cctype>Stephan Bergmann
Change-Id: I9c61e1b558104fa55d887a6c32e1ef2b03f1d1a0
2017-03-23Notebookbar: move shortcuts if multiple rows of tabsSzymon Kłos
Change-Id: I8b164a34eeff13d70712a84d5621d169b6528962 Reviewed-on: https://gerrit.libreoffice.org/35588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-23Related: rhbz#1334915 tdf#100158 hack using startcenter icon under waylandCaolán McNamara
cause I can get no traction with gnome#779143 to allow changing wayland app_ids for windows, so might as well bodge something to make us look less pathetic than the broken app icon Change-Id: I9810ba4908dd06a2fdbb2e58e7ad6ff4978ddd43
2017-03-23starmath: Fix memory leak at double sub/superscriptsTakeshi Abe
and avoid skipping following tokens too much. This also saves unnecessary stack operations. Change-Id: I4f30be73a615341b2b3de70f2c8f3dd5c2f85910 Reviewed-on: https://gerrit.libreoffice.org/35583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-23TODO: move to ScrollBar when binary incompatibility is no longer problematicCaolán McNamara
since... commit 72ebade6ba9e88a5a24db57266a53e8f52049214 Author: Ivo Hinkelmann <ihi@openoffice.org> Date: Thu Sep 13 15:33:31 2007 +0000 INTEGRATION: CWS aquavclcarbonfixes (1.20.70); FILE MERGED 2007/08/29 12:59:47 hdu 1.20.70.1: #i77549# extend native scrollbar NWF by adding PART_TRACK_*_AREA controls Change-Id: I124c4014556f3a10b986a2886202210ebfc9eb10 Reviewed-on: https://gerrit.libreoffice.org/35586 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-23tdf#106693 vcl PDF export, norefxobj: copy page streamMiklos Vajna
This gives correct result in very simple cases when the page stream is not compressed and it references no other objects from the original file. Change-Id: I11ed50180a256bdb5c587fd8927d21c925100a4d Reviewed-on: https://gerrit.libreoffice.org/35580 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-23convert ScMatrixMode to scoped enumNoel Grandin
and fix a bug in ScChangeActionContent::SetValueString where it was passing the grammar as the ScMatrixMode to the ScFormulaCell constructor. Change-Id: I7c1a174cdd8365dedc30cff0b26e3079bb8b84f3 Reviewed-on: https://gerrit.libreoffice.org/35552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23remove unused helpid in SfxShellNoel Grandin
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae "update unusedmethods plugin to deal with constructors" where I removed a unused SfxDockingWindow constructor. And in that case, the helpid was only being used to assign the window a UniqueId. Change-Id: I148e424424fcf08449440b83a8600071b39d7a07 Reviewed-on: https://gerrit.libreoffice.org/35554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23Revert "Handle "POSIX" in parse_locale"Stephan Bergmann
This reverts commit 646cbbfbc67b07d5f58166228bca1ac710175cd0 for now. Appears that it made CppunitTest_sal_osl fail at least on some macOS builds, for reasons not yet clear to me
2017-03-23xmlsecurity: ImplXMLSignatureListener is only used with XMLSignatureHelperMiklos Vajna
So no need to go via Link, can call those member functions directly. Change-Id: I36a5193965d23230ecc1ddca8675b3745933469d
2017-03-23convert UpdateFlags to scoped enumNoel Grandin
Change-Id: I73121e85a927bae3f042a2bbc0283a28067b891f Reviewed-on: https://gerrit.libreoffice.org/35553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23Handle "POSIX" in parse_localeStephan Bergmann
Change-Id: Ib3ce9efd2933170777689db152d35f586f5afe2d
2017-03-23Fix some usage of std::istream unformatted input in hwpfilter/source/hwpeq.cxxStephan Bergmann
(Though some deficiencies remain, e.g. when values are assumed to be valid characters and not eof().) Change-Id: Ia5ec681a68086e9843206a6b44a44f8ec3800b88
2017-03-23In Unix ImplGetLocale, read env vars instead of calling setlocaleStephan Bergmann
...to avoid the general problems with the latter (MT issues; changing global state) Change-Id: I21eb129b7e1422089b3449763f64f461371ffff1
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23convert SC_CELL_SHIFT_DISABLE to o3tl::typed_flags enumNoel Grandin
Change-Id: Iae4358828edc6bad26ef5c769a8ff42fe63ade7b Reviewed-on: https://gerrit.libreoffice.org/35556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23convert NAME constants to CreateNameFlags o3tl::typed_flags enumNoel Grandin
Change-Id: I6265c76067402808454184f1318feeb78a140617 Reviewed-on: https://gerrit.libreoffice.org/35555 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23convert INS_CONT constants to o3tl::typed_flags enumNoel Grandin
Change-Id: Ic59dad906c58ee765f36fac685c038c79bca9f3b Reviewed-on: https://gerrit.libreoffice.org/35557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>