summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-01-21sc: fix VBA Copy-Paste using same and separate documentTomaž Vajngerl
This fixes 2 issues with VBA copy-paste: - VBA command Range(..).Copy issue where the range wasn't selected when copying and the copied cells were from the previous selection. The Copy command now does the same selection as the Cut command. - VBA PasteSpecial issue where the wrong view was used to get the clip document. - VBA Workbooks.Add issue where the new workbook wasn't activated after it was created, which causes an issue when running tests, but not when running in LO application. The Add command does now the same as the Workbooks.Open command. All the issues are supported by new test cases. Change-Id: I36ec45c01f18f7f76e4f95a25a28402a6ee0e2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128720 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-21tdf#122995 Trigger Chart refresh directly in UpdateCharts for SWArmin Le Grand (Allotropia)
For OLE/Charts in SW we do not (yet) have a refresh mechanism or embedding of the primitive represetation, so this needs to be done locally here (simple solution). To have the Chart already invalidated at the next repaint, I needed to add a 'immediate' mode to InvalidateTable. Note: The text there claiming that the framework should do this is correct, but as long as the mechanism is incomplete (VC/VOC/OC in SW) direct refresh is needed. Change-Id: I3c845b3ec46fbb494e7bce163cfe105145421450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128572 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-01-21tdf#140020: Disable also menu File->SaveAll for docs with LockSaveVasily Melenchuk
If LockSave attribute is applied, docs with it are not affecting File->Save All menu item: these documents are not enabling this menu and also not saved during this process. Change-Id: I00bcd251fccfab3f13cb42c20ccb61b54ab49346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128650 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2022-01-21fix ChartDocumentWrapper::createInstanceNoel Grandin
which I broke in commit fe37aa64ff79abcd3aeedeb03d8d74798225a367 Date: Sat Jan 15 13:45:44 2022 +0200 use more concrete types in chart2, ChartView by copying behaviour from the wrong construction site. And then in commit c592574948b0a28bac965b508bc260aaa6c365d3 Date: Sun Jan 16 12:25:49 2022 +0200 use more concrete types in chart2, ChartView I spread the error further by using the incorrect behaviour I had introduced in the first commit in Chart2ModelContact::getChartView() Change-Id: I4b004b8893fa51b8968328b6a8b6ffde081f1269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-21comphelper: move JsonToPropertyValues() from desktop/Miklos Vajna
Because filter/ code will need this in a bit, and that can't depend on desktop/. Change-Id: I07f0f8ef30942a2d11388c6721c7f277e117bfba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128709 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-21tdf#140731: sw: move UItest to CppUnittestXisco Fauli
Change-Id: Ib72e03d2ca089ee86fa6d9dd4ae7d555be56ff4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128710 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-21use more concrete types in chart2, DiagramNoel Grandin
Change-Id: Ib78f327c8bf1b71c3bb038c029b10e6fe54edaa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-21Removed duplicated includesAndrea Gelmini
Change-Id: I9f8350f44952692a9efef297792a2326086d3d91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128704 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-21Mysql/MariaDB: Clean mysqlc_tables + remove usingJulien Nabet
So it allows to make the variable types far more explicit. It may help to differentiate the global mechanism from the specific mechanism Change-Id: I655824b97dbef5eab610d3b1535307b108245f53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128699 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-21Output full non-iso locale names, not just language_scriptEike Rathke
Change-Id: I3639dfff2da10afd711be37b6bfede44266c307f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128713 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-21Related: tdf#139974 Keep HYPHEN-MINUS with a number to the rightEike Rathke
Force line break 1234567890 -1234567890 instead of 1234567890- 1234567890 but still abcdef- abcdef Change-Id: I0b427b33b05eea12d13aad148c604385ffe000d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128691 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-20Mysql/MariaDB: allow View renamingJulien Nabet
Strange bug the renamed view appears like a table but when closing and reopening the file, the view is indeed there as a view (and not as a table) and renamed Change-Id: I0f26fca66ffb0785ece6223df623845c5e015c93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128707 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-01-20Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to b0d6bcb0c0703832e913fd0e42de43250b9bd1ac - Resolves: tdf#146733 - updating template manager help page - update position of "open" button - add icons for "open","edit","set default","move","delete","rename" - correction for "listview" icon - update labels for "import", "export", and "extension" icons - correction about editing built-in templates - move "move" and "export" entries to "individual templates" - correct descriptions for move, import and export, because they are no longer buttons, but part of a context or dropdown menu. - move "tip" about move and export. - move general "tip" about templates from bottom toward top - adjust <h2> to <h3> for "move", "import", "export", "extension" - update instructions in Example 2 Change-Id: I18a42999103b10d55cebafd51a9ed2c2e0efb87d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128345 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-20Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to b14288f63c5147754507f085642ddbe512f9e9a8 - tdf#135812 Add target HIDs for Manage Changes dialog Change-Id: Ic48fd22c1886cf1d671052149c5d500d62b20ba1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127948 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-20gtk4: gtk_file_filter_add_suffix now exists to fill this gapCaolán McNamara
Change-Id: Ia69b755f8a00621041de45974c4adf0d8c4b36f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128712 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20lok: avoid reundant progress bar messages.Michael Meeks
Change-Id: I9e04f428dbfafd98d1b08a549bb2758b9cc60eff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128674 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-01-20gtk4: implement SalGtkFilePicker::SetCurFilterCaolán McNamara
Change-Id: Ia147336c52422fb76600760526f3f020a052fd1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128700 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20Add missing test dependenciesStephan Bergmann
Change-Id: Icd74795dfe912cb180ff2e0d86996915d6d5b013 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-20gtk4: take SolarMutexGuard on key event handlerCaolán McNamara
Change-Id: Ifa195e02a2da1b530feb51f9473b41eb14e4e818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20use resolution independent positions for writer's screen-renderingCaolán McNamara
in favor of pushing it down to the text renderers and leave it to them to optimized as best they can the the rendering to make it look as well as possible. the separate ScrArray can then be dropped as a consequence Change-Id: Ic0849c091a36e1a90453771b1c91b8ff706b679e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128418 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20gtk4: hide frame for gtk4 to pretty things upCaolán McNamara
they were typically invisible in gtk3 and we mostly designed assuming that so it doesn't look great Change-Id: Iae44e3fd92b4c5ef7bea25174978477d75c03433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128690 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20tdf#139974: sc: Add UItestXisco Fauli
Change-Id: I2fe60ece55cd5f8298ed656fa043287eeaef1a53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128651 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-20sc: ubsan - initialize D&D pointers properly.Michael Meeks
Change-Id: I95c6a9b55ed25cc6d51f9f4544cb9fc016bbec64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128672 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-01-20WASM update README.wasm.mdJan-Marek Glogowski
Change-Id: Ic38a7a0637ab007f12a6046655cb7d36e24fae33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128655 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20Sorting component implementations needs LC_ALL=CJan-Marek Glogowski
Change-Id: Ifba53b95fdefed59123a2e682e787119b6c67857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128689 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20Fix typoAndrea Gelmini
Thanks a lot to Valter Mura: https://listarchives.libreoffice.org/global/l10n/2022/msg00005.html Change-Id: I37467e1b9ba7cba2553be5df0d8324da8fe6c13b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128303 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-20centralize these GetTextArray usesCaolán McNamara
no logic change intended Change-Id: Ide0a6afc30690d05647acf9bf1a0eccf72a9e60c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128570 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20Move credits link to configSamuel Mehrbrodt
as all other related URLs and replace with a hub link, see https://redmine.documentfoundation.org/issues/3569 Change-Id: Ic30f2a5980ae17b5dfff184ead391b21cff7ab7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128660 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-01-20use more concrete types in chart2, ChartModelNoel Grandin
Change-Id: Ic3020221111fea9c1026a91c72f7a2d1d5da42dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-20Related: tdf#139974 Try to find boundary for forced line breakEike Rathke
So we break at word or number boundary, e.g. 1234567890+ 1234567890 instead of 1234567890+123456 7890 (which in the sample case also keeps a formula expression functional). Change-Id: Ied01d76d8e30822d6e70c1bc2c1ca8609b0e3778 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128665 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-20ucb: webdav-curl: fix the debug logging moreMichael Stahl
Unfortunately didn't work in the cases where it needed to work. Change-Id: Ia132ba38fb6f0be4481dce48da2d713d47fa8bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128658 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-20Fix typosAndrea Gelmini
Change-Id: I95ee74b281eb243e5d251bd5a099029ddfcda1e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128662 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2022-01-20comphelper: fix UAF in SequenceOutputStreamService dtorMichael Stahl
Change-Id: I91f77ee9ab4d509ebee3d04f94a3c63986de0ef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128657 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-20Revert "can use the glyphcache for this GetTextArray call"Caolán McNamara
nothing wrong with this commit, but there's a an underlying bug in the direction I wanted to go here. This reverts commit 5fc43fe24c24c58e401707fa6fffe9250186b99c. Change-Id: Id670d9331cf41a0d2dcc2a74792c1aa7db4ec284 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128661 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20Fail on non-optional, but filtered component namesJan-Marek Glogowski
If any of the optional component lists contain a non-optional component implementation, fail the component file generation and show a diff of the offending component implementation name. Change-Id: Ieac876e613f6945362186d4586dd2aacc5669920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128645 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20use more concrete types in chart2, ChartModelNoel Grandin
Change-Id: Ie38d941f855978b04995162040d8871a2577255c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-20WASM re-activate and fix the Chart buildArmin Le Grand (Allotropia)
Change-Id: I13c50ac005e1e990bd185115b6e1717ce2c6bb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128654 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20WASM make test file loading workArmin Le Grand (Allotropia)
Change-Id: Ic34104534c3e0e73791cf867bfb2e1246dc79cf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128653 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20tdf#146294 Fix extended tooltips for Next/Previous buttonsRafael Lima
This patch also adds normal tooltips for the four navigation buttons. The corresponding help page will be updated in a subsequent patch. Change-Id: Ib7d77a643847e417cd66cf872739e39187555df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127950 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-20uitest: sc: make sure text is copied from the input windowXisco Fauli
Change-Id: I17f163486f253bc80f40f13c01fb61187d8276e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128649 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-20WASM --enable-wasm-strip now skips lots of LO codeArmin Le Grand (Allotropia)
... resulting in a stripped-down, Writer-only build to decrease the resulting WASM bytecode size. It removes the following code from the build: * All other major modules: Base, Calc, Chart, Draw, Impress and Math and related writerperfect filters * The premultiply tables * The (auto-)recovery functionality * All accessibility (but not the accessibility document checker) * The LanguageGuess component * EPUB support * The start center / BackingWindow * The TipOfTheDay functionality * The splash screen communication Currently crashs with anything different then soffice --writer. Closing the document also still crashes. FYI: many of these features are now behind ENABLE_WASM_STRIP_* defines, but they normally don't work on their own, globally! That's because we started with stripping the main components. Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20lok: avoid duplicate emission of statechanged: messages.Michael Meeks
We tend to get many of these per keystroke, with the same state. Change-Id: I9d759f54aee8d6dabcef094997e8f352dd608ec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128539 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-01-20ofz#43689 Direct-LeakCaolán McNamara
Change-Id: I09823f30817163b0467b6b96f56956987337b991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: I6b768b80d972c5379005efecfb803463ca648b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20cid#1497461 Logically dead codeCaolán McNamara
Change-Id: Ia8a7fe24e46d749f8837efb50145c66b0ecb5ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128642 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20tdf#141340 PDF export: fix hyperlinks on the wrong page with page num rangeMiklos Vajna
Regression from commit 01dbb38680aa39a4d3bc7afd05d44a4b2c9bc6ab (tdf#61274 sd PDF export: fix links ending up on wrong pages with hidden slides, 2020-03-10), the problem was that the sd/ code that mapped page numbers between the model and the PDF output only handled hidden slides, but not partial exports. Fix this by revisiting the decision to handle hidden slides in sd/, the filter/ code at the end does have enough information to correctly do this mapping at the end, and this way both tdf#61274 and tdf#141340 can work at the same time. Change-Id: I5679743ca67fab562e14c73e32f1a06ead8e7a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128643 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-20WASM open links in new browser tabsJan-Marek Glogowski
I quickly gave up trying to understand what exactly clashes between the Emscripten macros and OUString templates / initializers. Not sure it can actually be "fixed". Also disables the makeshared clang compilerplugin; currently there is no way to get rid of all the false positive hits when assigning the std::shared_ptr from a function instead of a constructor call. Change-Id: I8b13f179629ea63ff221584030556d2bedadc01b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128604 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ia19985b7c042e6ab9608220343e3b678890f7215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20tdf#128375: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I24b862d23d2e8dd9fbe930043457963f4cceec1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128636 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-20tdf#140019: Revert "Don't disable "Send doc via email" ..."Vasily Melenchuk
Locked export should also disable ability to send document. This reverts commit b9930d0d05db39a8466b18dccf626bc3d8ae5c4e. Change-Id: I3b7b423c0e17a59872065ec7ceadbaf1cda45ccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128550 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
generated by cgit (git 2.34.1) at 2025-02-09 00:20:27 +0000