summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-06loplugin:constparams in various(2)Noel Grandin
Change-Id: I533a7eb724b15e168a28dc92cd5962a39bc96e7c Reviewed-on: https://gerrit.libreoffice.org/44313 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-06convert various vcl system fields from unsigned long -> sal_uInt32Noel Grandin
Change-Id: Iaa08ecb3a9a17f384267f2b685a4b672277db1ca Reviewed-on: https://gerrit.libreoffice.org/44317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-06BitmapColor::GetLuminance doesn't need to use unsigned longNoel Grandin
Change-Id: Ic0f4c2c7576023a96266116a1237190586e4e816 Reviewed-on: https://gerrit.libreoffice.org/44316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-06loplugin:finalclasses in drawinglayerNoel Grandin
Change-Id: I8922fc85ab23453791e3ce0b639d4ffafd31e967 Reviewed-on: https://gerrit.libreoffice.org/44315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-06loplugin:finalclasses in editengNoel Grandin
Change-Id: I3cf074d101311e516ee1ce23ad032225780f3e25 Reviewed-on: https://gerrit.libreoffice.org/44314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-06TSCP: Store paragraph signature RDF in the paragraphAshod Nakashian
Change-Id: Ic44e3238bd1c35445bc23d0cc1de07aa2bf4512c Reviewed-on: https://gerrit.libreoffice.org/44243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-06tdf#107939 Fix case-insensitive filter in Field DialogVitaliy Anderson
Change-Id: I38e695b43ffa7b213e60993aed3ac1838548b33d Reviewed-on: https://gerrit.libreoffice.org/44307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-06ofz infinite loopCaolán McNamara
Change-Id: I9eab92f72618a062455e9e17d9a262f28d8bb740 Reviewed-on: https://gerrit.libreoffice.org/44332 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-05PPDCache: fix segfault due to access after deleteAshod Nakashian
Regression introduced in: commit afe4d2527ec72e7493a2b1431559652ef45bebab Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Oct 18 09:43:21 2017 +0200 use std::unique_ptr in PPDCache Removing a naked pointer before inserting a possibly existing one in a container is safe. This insured uniqueness (as the comment suggests). However with unique_ptr, removal before inserting deletes the pointer (when it exists), and the insertion now taints the container with a wild pointer. The fix is to skip adding if the pointer is already in the container and add only when missing. Change-Id: Ifc6b517451abb564949ccadfee10d98bf827540d Reviewed-on: https://gerrit.libreoffice.org/44333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-05tdf#113592 LibreLogo: add fallback localization to fix platform issuesLászló Németh
Update: python3 LibreLogo.py LibreLogo*.properties Change-Id: Ib631f53b47f1f00b14338534cc82d94f33c48233 Reviewed-on: https://gerrit.libreoffice.org/44203 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-11-05tdf#113037 create Watermark with correct ratioSzymon Kłos
Change-Id: I17ab8d98a618cff6e38dad344f4096dc520cce43 Reviewed-on: https://gerrit.libreoffice.org/44228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-05one slash is enoughDavid Tardon
Change-Id: I35fbca7592f3e17a071df567f691c62fe9232fc1
2017-11-05ofz#4068 Integer-overflowCaolán McNamara
Change-Id: Id61f4f82b66e7efa4d3ef062d2756acddcee43b8 Reviewed-on: https://gerrit.libreoffice.org/44327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-05ofz#4057 Integer-overflowCaolán McNamara
Change-Id: I6a7ef3ca4c26ce4965deeea27ae47a03169bcf12 Reviewed-on: https://gerrit.libreoffice.org/44320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-05ofz#4058 Integer-overflowCaolán McNamara
Change-Id: I76050f392f04cff54e52eb913ceb451bc5973a72 Reviewed-on: https://gerrit.libreoffice.org/44323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-05Correct German variables/functions names translation in Calc (financial)Johnny_M
This does the following: 1) Translates the variable fDia -> fSyd (see https://translations.documentfoundation.org/de/libo54_help/translate/#search=DIA&sfields=target&soptions=exact,case ) This was missed on previous translations. 2) Corrects earlier variables translation, where appropriate (the earlier translation was literal; now the translation corresponds to the specific terms used for these variables in Calc in English): fInterest -> fRate fValue -> fCost fRest -> fSalvage fTimeLength -> fLife As example, compare the arguments of the following function: German: https://help.libreoffice.org/Calc/Financial_Functions_Part_Two/de#RMZ English: https://help.libreoffice.org/Calc/Financial_Functions_Part_Two#PMT And: German: https://help.libreoffice.org/Calc/Financial_Functions_Part_One/de#GDA English: https://help.libreoffice.org/Calc/Financial_Functions_Part_One#DDB 3) Corrects earlier function and variable translation (the earlier translation was literal; now the translation corresponds to the specific term used for this in Calc in English): ScGetCompoundInterest() -> ScGetIpmt() fCompoundInterest -> fIpmt See for needed translation: https://translations.documentfoundation.org/de/libo54_help/translate/#search=ZINSZ&sfields=target&soptions=exact,case See for earlier translation: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=e96d2593138d9e8eb197e21fa3087b45eae676c0;ds=sidebyside 4) Correct earlier variable renaming: bFlag -> bPayInAdvance That variable corresponds to the "Type" parameter in, e.g.: https://help.libreoffice.org/Calc/Financial_Functions_Part_Three#FV See for earlier renaming: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=8340f6dcfb2f391feeddb1bc24931cd6f145669a;ds=sidebyside Note: The bFlag means something different for the VDB function (see https://help.libreoffice.org/Calc/Financial_Functions_Part_Three#VDB ). Therefore, the change for the VDB is: bFlag -> bType Change-Id: Id258d953be6ba3de113d762ee944786389702b55 Reviewed-on: https://gerrit.libreoffice.org/44285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-05Translate German function names in Calc (financial)Johnny_M
This follows up with translation of function names, similarly to how it was earlier done for variable names. Change-Id: Icf784ad96db41d341ae39d2854c7df2844b66a91 Reviewed-on: https://gerrit.libreoffice.org/44286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-05Fix typoAndrea Gelmini
Change-Id: Ic3db50be939b7f64268da912159f325e5f60e061 Reviewed-on: https://gerrit.libreoffice.org/44329 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-05Fix typosAndrea Gelmini
Change-Id: I6338ff36670b54ea69a959674239b4ba3029a5a3 Reviewed-on: https://gerrit.libreoffice.org/44328 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-05Replace lists by vectors in configmgr/unotoolsJulien Nabet
+ use for range loops Change-Id: I4cebcf0536dc6c3ddfdce9532e94c0c380ea3ab9 Reviewed-on: https://gerrit.libreoffice.org/44308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-05fix build of bundled libepubgen on ppc64leDavid Tardon
Change-Id: I559058ffe2192764a27d278eea0e4d4676bbd64d
2017-11-05TSCP: disable OK button if no category is present in text editTomaž Vajngerl
Change-Id: I638f04e904a642e4fd6700e625732e5a9a2e44de Reviewed-on: https://gerrit.libreoffice.org/44292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-05TSCP: refactor signature validation and simplifyAshod Nakashian
Change-Id: I20e2f2825c9bd19d76ab450ffa70aca72fbb8b9a Reviewed-on: https://gerrit.libreoffice.org/44146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-05Remove GetNextSubset and create GetSubsetMapJulien Nabet
To avoid to store an iterator and simplify loops Change-Id: I9b160714125176841961a56905d81dcb876c68b6 Reviewed-on: https://gerrit.libreoffice.org/44326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-05Replace remaining lists by vectors in svtoolsJulien Nabet
Change-Id: I3b85f4853d305fec2efe1fa351466c56d11473c9 Reviewed-on: https://gerrit.libreoffice.org/44303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-04tdf#113635 Add support for Clip Intersect and XORBartosz Kosiorek
Change-Id: Iff2bb06a209a6c089fec12b5f888ca4ef7c38c1b Reviewed-on: https://gerrit.libreoffice.org/44289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-11-04ofz short read considered as a successful full block readCaolán McNamara
i.e StgDataStrm::Read takes the bool of no error and multiplies it by the block size to report the length read. A short read isn't an error so full buffer is considered valid. To keep #i73846# working and get deterministic fuzzing results, zero out the trailing space of a successful but short read. Changing this to return the truthful number of bytes read makes #i73846# stop working. There's wonderful nonsense here calculating nPg2, determining nBytes to read derived from this, reading nBytes into the buffer and then considering it an error if nPg2 is not 1 after the presumably potentially fatal buffer overflow if nPg2 wasn't initially 1, but this doesn't seem possible in practice Change-Id: I2bac6066deb8a2902677e04696367ba2c351b325 Reviewed-on: https://gerrit.libreoffice.org/44310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-04Replace lists by vectors (canvas)Julien Nabet
Change-Id: I4695b1f1095a6324632f48727274bdfdcc63720b Reviewed-on: https://gerrit.libreoffice.org/44298 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-04Replace lists by vectors (stoc)Julien Nabet
Change-Id: Ifb5dc253186b7cc8f37d843e600addcc579c77e6 Reviewed-on: https://gerrit.libreoffice.org/44299 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-04Replace lists by vectors in SalGtkFilePicker (vcl)Julien Nabet
Change-Id: Iaf6115080c7b22e2e5b7cbc04314a48ad7fecdae Reviewed-on: https://gerrit.libreoffice.org/44312 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-04Replace lists by vectors in reportdesignJulien Nabet
Change-Id: I67472484d83ee75cbcc50a64b4637d3b45608499 Reviewed-on: https://gerrit.libreoffice.org/44309 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-04Related: tdf#113160 set parent of warning dialogs during loadCaolán McNamara
to the new window frame being constructed that (may) contain the progress bar, that way such modal dialogs affect the loading document window and not whatever window happens to be active Change-Id: I1c7d3185e47fa316eef003b80d18b31d341b79d6 Reviewed-on: https://gerrit.libreoffice.org/44269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-04ofz#4034 Integer-overflowCaolán McNamara
Change-Id: I99a4e24e2038387f749051bc268bc74ce808bd96 Reviewed-on: https://gerrit.libreoffice.org/44306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-04fix build with older boostDavid Tardon
Change-Id: Ie3f7a32bf8d5c9c118d35272c8e197b9c6ffcd80
2017-11-04Replace last list by vector in ucbJulien Nabet
Change-Id: Idde1489fd8203c503347d14965487dd20cc6573f Reviewed-on: https://gerrit.libreoffice.org/44300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-04Optimize loop of GetSubsetByUnicode a bit (svx)Julien Nabet
Change-Id: I568c08b5c319aefbe77a1abb720421a88555568d Reviewed-on: https://gerrit.libreoffice.org/44305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-04tdf#42346: DOCX export of cross-references to objectsTamás Zolnai
* Objects means tables, images, text frames and shapes * Implementation ** MSO uses simple bookmark references as cross-references to objects ** So generate bookmarks in export time if a caption is referenced ** In some cases we also need to split some of the runs ** Implemented all types of cross-references, except the chapter reference Change-Id: I3b17753123d94a04e4f28783ad5663831e7c6c84 Reviewed-on: https://gerrit.libreoffice.org/44294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-04ofz#4055 Integer-overflowCaolán McNamara
Change-Id: I15f0a48c1e0c4c03f99a74d4d9b58e064d108c72 Reviewed-on: https://gerrit.libreoffice.org/44304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-04Replace lists by vectors in animation parts (sd/animations)Julien Nabet
Change-Id: Ie5306041e5cde5617e460ae4d98861e8d26e389d Reviewed-on: https://gerrit.libreoffice.org/44297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-04Updated coreLászló Németh
Project: dictionaries 56684558fb8bdb05cf8bc3e4c183e78de630dd6d tdf#95024 update Hungarian spelling dictionary Change-Id: I9cd563ff6c1d9e5547216efeadb65cf018c56026 Reviewed-on: https://gerrit.libreoffice.org/44290 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-11-04Replace only list by vector in pyunoJulien Nabet
Change-Id: Ic770d1fb8e3735123786a73a7b57f71ad8005d5d Reviewed-on: https://gerrit.libreoffice.org/44301 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-04ofz#4048 Null-dereferenceCaolán McNamara
Change-Id: I52db987ac3f11e318e2adf1ee797054f49c31f98 Reviewed-on: https://gerrit.libreoffice.org/44293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-04Make Windows error reporting more robustMike Kaganski
https://msdn.microsoft.com/en-us/library/ms679351 describes that "it is unsafe to take an arbitrary system error code returned from an API and use FORMAT_MESSAGE_FROM_SYSTEM without FORMAT_MESSAGE_IGNORE_INSERTS" Previously in case when an error string would contain inserts, function returned error, so the error message wasn't shown (at least it didn't crash, thanks to nullptr as the function's last argument). As the function may fail, we now pre-nullify the buffer pointer to avoid dereferencing uninitialized pointer later (though at least for some Windows versions, the function nullifies the pointer in case of FORMAT_MESSAGE_ALLOCATE_BUFFER, but there's no explicit guarantee of this). Also release of allocated buffer is changed to recommended use of HeapFree. The code that doesn't make use of OUString is left directly calling FormatMessage, to avoid introducing new dependencies. Where it makes sense, we now use WindowsErrorString from <comphelper/windowserrorstring.hxx> Change-Id: I834c08eb6d92987e7d3d01e2c36ec55e42aea848 Reviewed-on: https://gerrit.libreoffice.org/44206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-04sfx2: Drop unused macro & declarationsTakeshi Abe
Change-Id: I249c3dc5158a4aaa161d360378e4c657ffcc8af4 Reviewed-on: https://gerrit.libreoffice.org/44296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-04clang-format: Increase column limit to 100Samuel Mehrbrodt
As discussed in IRC. This matches the values in TEMPLATE.SOURCECODE.HEADER Change-Id: I7e7bf5df0b011a54c8dddde5366e73e14068ef7d Reviewed-on: https://gerrit.libreoffice.org/44249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-04ofz#4041 AbrtCaolán McNamara
Change-Id: I8d9466bd4594dec819704141b03c280f52d824ef Reviewed-on: https://gerrit.libreoffice.org/44267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-04lok: temporary workaround: disable formula mode for onlineMarco Cecchetti
- Start empty spreadsheet, open it with two users (let's call them A & B). - Type "=" with user A. - Start moving around to different cells with user B. => Cell name of user B's selected cell is entered in user A's formula. This is due to the fact that ScModel::GetInputHandler() returns always the input handler which is handling the edited formula and not the input handler of the current view. That really messes up collaborative editing, so better to disable it, until we implement an alternative solution. Change-Id: I6e779cba3f377d12b7a4a19a6ee53c924fc9ba20 Reviewed-on: https://gerrit.libreoffice.org/43035 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-04loplugin:constparams in various(1)Noel Grandin
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b Reviewed-on: https://gerrit.libreoffice.org/44261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-04loplugin:constparams in filterNoel Grandin
Change-Id: I9fc76693da88d74b6fe7bbb920b8e731b82be298 Reviewed-on: https://gerrit.libreoffice.org/44260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-04loplugin:constparams in svxNoel Grandin
Change-Id: Ib6ae6b0c1ae1659955124bb5c710f2989a0feb3a Reviewed-on: https://gerrit.libreoffice.org/44250 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-06 10:34:36 +0000