summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-12-12tdf#104532 handle constraints for NEGBINOM.DIST correctly.Winfried Donkers
Also changed variable names for easier understanding of their meaning. Change-Id: Iab558d7d1d9533f2a0c42e3d5f4acecead2e818e Reviewed-on: https://gerrit.libreoffice.org/31807 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit ccbb0dd8788bf481f398782bf1519cd57c3b2bfb) Reviewed-on: https://gerrit.libreoffice.org/31908
2016-12-12tdf#104425 sw: split rows w/large min height (fix layout loop)Mike Kaganski
This solves the problem of rows with too big minimal height causing layout failure (the table just goes out of page, does not flow to next page). It does so with three steps: 1. Currently, a row with a minimum height that flows to next page repeats whole min height on that (and possibly following) pages. If this behaviour continued, then that would cause layout loop: the row min height would be too high for the page, so it would keep flowing to next pages (actually just go beyond the botom because of layout failure). To mitigate this, the patch changes the behaviour to measure total height of all frames of the row: the function lcl_calcHeightOfRowBeforeThisFrame calculates the total height of previous row frames for the same row, then in places where we need to get min height, this value is subtracted from row min total height. On following pages the min height of frames will get less each time. 2. When the row is split, the possibility to split depends on if the minimum height of the row fits into the vertical space left. The minimum height is found as maxinum of two values: minimal contents of the row (e.g., height of first line of text, or an object, or lower table cell), and the minimum height setting. As the minimum height setting should not prevent the cell to flow, (it only should ensure that total height is no less), we should not consider the setting when the split is performed (we should be able to keep on first page as little as required). To allow this, a new bool member introduced in SwRowFrame: m_bIsInSplit, with its setter and getter. When it is true, the routines that calculate min height ignore the min height setting. It is set in lcl_RecalcSplitLine around lcl_RecalcRow and SwRowFrame::Calc that decide if it's possible to keep part of row's content on first page, and update table's height to fit the rest of space. 3. It turns out, that if contents of the splitted cell has less height than the min height setting, then following happens. In SwTabFrame::Split, all rows below splitted one are moved to follow flow table; then table frame's Shrink method used to shrink the freed height. At this moment, still, the height of splitted row is too high, and total height of table is too high. Then, lcl_RecalcSplitLine is called, where row is first shrunk, and then lcl_RecalcRow and SwRowFrame::Calc try to move contents and resize the splitted row. They get the minimum height of content (we already don't consider the min height setting), but then "last row will fill the space in its upper" (see SwRowFrame::Format). Row returns its previous size, table does not resize, it doesn't fit to page, and split fails. To try to fix that, I call SwTabFrame::Shrink in lcl_RecalcSplitLine after lcl_ShrinkCellsAndAllContent before lcl_RecalcRow. Unit test included. Change-Id: I37a6b3589abf287dd5efc991a6336fc378410df9 Reviewed-on: https://gerrit.libreoffice.org/31774 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/31897 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-12-12tdf#101729 recover fnGetSize,fnLeftDist,fnRightDist,fnXIncMark Hung
Above field of struct SwRectFnCollection were removed because of loplugin:unusedfields. I can't find them refered in the source code but they do affect alignments. Partially recover d2df03574023b379ac09b1f71cae9e3ba3ac53e2 and e18b08363a939b35e7f5dc435e606d2c62bddebd. Cherry-picked from 611354a1c2e8281a80a1c3f5076a6c4593a4fe10 Change-Id: I38f2b7a31565773b749cfeb1f47574c390d38527 Reviewed-on: https://gerrit.libreoffice.org/31795 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/31912
2016-12-12Updated coreGabor Kelemen
Project: help 90b439d73faed542e01ae08e973ddb5b3dcc0bf2 tdf#103527 (related) Drop redundant Color settings page It has no substantial content so it could create only confusion Change-Id: I393c7f5b3094977ceb2a84876b0cd2d434d9f9af Reviewed-on: https://gerrit.libreoffice.org/31849 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br> (cherry picked from commit 957f72b1e3aeeb596eb9c82b4b623d09d1122e71) Reviewed-on: https://gerrit.libreoffice.org/31911 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-11don't overwrite the crashreport info that are written before uploadMarkus Mohrhard
There was a race condition that the OpenGL code was initialized before the old report has been uploaded. Therefore the OpenGL setting was overwritten by the new start and we were not getting the old value. Now we store any value that wants to be added before the dump.ini is ready in a temporary map and will write them as soon as we write all the common information. This problem was introduced by the dialog requesting permission to upload the crash report. Change-Id: I29391a1ff56bac6381218c5a4aefb58c2c03f024 Reviewed-on: https://gerrit.libreoffice.org/31846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 80049d110a742060acedb89eaad763e66d7f75a5) Reviewed-on: https://gerrit.libreoffice.org/31850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-11Resolves: rhbz#1362453 use the cairo scaling approach on both wayland and XCaolán McNamara
so have the same hidpi solution on both setups Change-Id: I669eba55830a28c1850f4679dfa824798bd3a383 Reviewed-on: https://gerrit.libreoffice.org/31540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 3a9609653697ac851ee1c55a41aa143d3bca335e) Reviewed-on: https://gerrit.libreoffice.org/31836 Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-11Remove superfluous jargon from user visible stringKhaled Hosny
No idea what “CTL” is supposed to convey here, they do not even look as well formed strings. Change-Id: I424072fb5efdecd9115649dd3abbd4e9d5dc032c Reviewed-on: https://gerrit.libreoffice.org/31837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 9fb706f9fe216f6157b9052bc42a0601d8ae52d5) Reviewed-on: https://gerrit.libreoffice.org/31847 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-10bump product version to 5.3.0.0.beta2+Christian Lohmaier
Change-Id: I6a3a9c63d6c82784a7c1c4177c6bca3ebb663f2f
2016-12-10update emoji autocorrect files from po-filesChristian Lohmaier
Change-Id: Ia884dc4f8978dd15b98d8891dcb500cf2f0d114c
2016-12-10Updated coreChristian Lohmaier
Project: translations 30f04e349b8ae4edb5511a71f0127201ac7929e1 update translations for 5.3.0 beta2 and force-fix errors using pocheck Change-Id: I50100798b84da2969535c4f558dd60463b30108e (cherry picked from commit ef59b48c9927301075cff0e2729b5d0a7ea214ed)
2016-12-10oss-fuzz: handle W_META_CREATEFONTINDIRECT like EMR_EXTCREATEFONTINDIRECTWCaolán McNamara
Change-Id: Iaa142d5d0ac0f00e89e8b7d7ffdef8137157cec9 (cherry picked from commit e718ac0ae415bba2988c96c36995755bbfd9df7f)
2016-12-10tdf#93430: Return the right offsets for runsTamás Zolnai
MultiLineEdit is a special control which can have more text portions with different text attributes. Change-Id: Iab51dba0d0344fad4358f4961c968c031b1660b6 Reviewed-on: https://gerrit.libreoffice.org/31813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8d52045853cecb716138d51b8b6ad0272a86af86) Reviewed-on: https://gerrit.libreoffice.org/31832 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-10tdf#104534: Retrieve list of patternsJulien Nabet
using same way as gradients, bitmap, etc. Change-Id: I49788d5af163aa6f06a12c87ee08e6599fc940c8 Reviewed-on: https://gerrit.libreoffice.org/31833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 1fce5b024e9f25c3fcef2537a22474ece0dc416f) Reviewed-on: https://gerrit.libreoffice.org/31834 Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-10rename to RegisterDefinedStyleNames() to clarify, tdf#104097 follow-upEike Rathke
Change-Id: Iecb64ab1e25913180bcb53a133f9dd6777ffb17b (cherry picked from commit 7b1c8fa23342f847c7bbc99627dbb3fec0a57205) Reviewed-on: https://gerrit.libreoffice.org/31825 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-12-10Resolves: tdf#104097 register reserved cell style names for auto stylesEike Rathke
SvXMLAutoStylePoolP_Impl re-starts with a clean XMLAutoStyleFamily::maReservedNameSet, so reserving the names in ScXMLExport::ExportStyles_() is not enough and needs to be redone in ScXMLExport::ExportAutoStyles_() In the bug scenario that lead to cell styles with duplicated names for different styles of which when reloading only the first was taken. Additionally, a style must be registered after SvXMLAutoStylePoolP::AddNamed() to prevent duplicated styles with different names. Change-Id: If3491eb89ab1741887d9a36ecf904a216fb1368e (cherry picked from commit b579c928a8642bc5f455438c1fef01e8df7e195f) Reviewed-on: https://gerrit.libreoffice.org/31812 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-09tdf#100337 Message boxes showup empty with white backgroundNoel Grandin
the bug here was that we had, on the stack, going into the scheduler THREE times. Two of those were idles. The original code would end up always picking the first idle from inside ImplSchedulerData::GetMostImportantTask and then ImplSchedulerData::Invoke would just return because we were still inside that Idle, and the second Idle would never get executed Since the second Idle was responsible for painting the dialog in the bug, sometimes the dialog would never get painted. Change-Id: Ia15b98a06e231c8e1c29450e05a76ad427e41e36 Reviewed-on: https://gerrit.libreoffice.org/31785 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 19a4eaab9a55a2ecb33b727bad6307c5a2badc23) Reviewed-on: https://gerrit.libreoffice.org/31798 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-09tdf#93430: Cannot get accessible text attributes for 'Not in dictionary' entryTamás Zolnai
Squashed from two commits: tdf#93430: Get run attributes of text objects .. which are not paragraphs. Note: For some reason in character attributes sequence we have a wrong Any value for "CharPosture" property. Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/31591 (cherry picked from commit 17773e1a8dd6e97f57db111819338c418f819cef) tdf#93430: Cannot get accessible text attributes for 'Not in dictionary' entry Reviewed-on: https://gerrit.libreoffice.org/31778 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit e0d8c3821b8fa1e7d00f7b4a7d007f9cb5c592a5) Change-Id: Ia45526c01cc381d3d6a1b56dbf4f03fdd38a0989 aa2b4fdb582025b763d43f0f24960e2ccee708e3 Reviewed-on: https://gerrit.libreoffice.org/31792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-09tdf#104445: PPTX import: Extra bullets are added to placeholder textTamás Zolnai
Reviewed-on: https://gerrit.libreoffice.org/31771 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit cb598029835477326b190bc99abd31a487cc5a91) Change-Id: I25ce98ed391f70292bed6238645b121b9cf50d5e Reviewed-on: https://gerrit.libreoffice.org/31788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-09oss-fuzz we don't want this stream to automatically resize on seeks past endCaolán McNamara
Change-Id: Ie42b2e173cd3ed9faaf17c3c978227613129fa84 (cherry picked from commit f212bd45a7c7d97fb16380cd9fa7c6abbfb71e05)
2016-12-09tdf#104495: prevent autotext to crash when drag&dropJulien Nabet
See bt https://bugs.documentfoundation.org/attachment.cgi?id=129407 For non regression, I retested tdf#91125 since the delete comes from https://cgit.freedesktop.org/libreoffice/core/commit/?id=06ecf7d2aebe64226142ee27c2512351960f8bb1 Change-Id: I7ce833ffce20f1f159242014ba8ffe0ce5b7b11c Reviewed-on: https://gerrit.libreoffice.org/31773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 8776c20c1c72110d0f205150913eb17cdf3f1aaa) Reviewed-on: https://gerrit.libreoffice.org/31784 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-12-09Related: rhbz#1397939 crash with null pSidebarControllerCaolán McNamara
Change-Id: I7627ff30564b2de61669c71dafd15e7b1778b5c6 (cherry picked from commit f5edbb4158e86bfea7267115395b64e60fd61dc7)
2016-12-09tdf#104105: fix Vcl lifecycle in CondFormat (reportdesign)Julien Nabet
Avoid this error: Window ( 7VclVBox()) with live children destroyed: N5rptui9ConditionE() * n by calling disposeAndClear on each element of m_aConditions m_aConditions is Conditions type Conditions type is ::std::vector< VclPtr<Condition> > See http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/inc/CondFormat.hxx#70 Change-Id: Ie99f8cdb5acd787892237787525d79f3231689db Reviewed-on: https://gerrit.libreoffice.org/31775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 73131fc3806ce2a7da61c93590e467e5b044c341) Reviewed-on: https://gerrit.libreoffice.org/31779 Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-08-Werror=return-local-addrStephan Bergmann
(the first case with OUString would technically be OK, but better change all three of them) regression introduced with 0e4ca9b0cfe015f7ab3b964d1b90de7c2cba42de "Clean up uses of Any::getValue() in ucb"; thanks to tml for finding it via --enable-fuzz-options Change-Id: I79e70cff8d8b96e1eb6b0bacda52be06eb0f108b (cherry picked from commit 912fda1d7b21e7f7c8983c449d5d50fdf000e5bc) Reviewed-on: https://gerrit.libreoffice.org/31766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-08tdf#103651 check isForwardEvents() for symbols in commentsMark Hung
Every time a comment is referred, the whole comment stream is parsed but only the referred comment is extracted. But the symbol is always processed so it is added to all the comments. Change-Id: I3264de2d011ff188ef64f6500ae426cde0106c16 Reviewed-on: https://gerrit.libreoffice.org/31584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 3caf89200c8fa7b38d6c340b666ca6cc8c2eb766) Reviewed-on: https://gerrit.libreoffice.org/31759
2016-12-08Updated coreGabor Kelemen
Project: help f97b2c24427e1965802eb799a9fd472e23664183 tdf#104146 Switch order of list items So that it actually makes sense. Change-Id: I2849bb34d769601c2d4167073e74e7236675f9f7 Reviewed-on: https://gerrit.libreoffice.org/31743 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br> (cherry picked from commit 973fc93ec46a30b6aa57e6f328022ee79958a121) Reviewed-on: https://gerrit.libreoffice.org/31765 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-08tdf#104446: there can only be 1 condition for SUMIFJulien Nabet
Change-Id: I10b1e3880e79794b7f748882606d5c4101811d75 Reviewed-on: https://gerrit.libreoffice.org/31739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Winfried Donkers <winfrieddonkers@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5e4649debc1d7b68fd93073cebd691d840c1fa6c) Reviewed-on: https://gerrit.libreoffice.org/31764 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-08tdf#104405 Clone Formatting ignores vertical text alignmentNoel Grandin
Reviewed-on: https://gerrit.libreoffice.org/31623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit d36aa2ba3132ce62a370b7260ca620642cbf7dbf) Change-Id: I56cce69ddb21f7f9336b8f59e181e91306e92019 Reviewed-on: https://gerrit.libreoffice.org/31746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-12-08Updated coreGabor Kelemen
Project: help 38da3d11894b068011fe16030da50ebfdf7887b8 tdf#104410 'Insert - Names' moved and renamed Now this menu item is 'Sheet - Named Ranges and Expressions' Change-Id: I82113ef2e969cd2409fe114a51789e030752cdc0 Reviewed-on: https://gerrit.libreoffice.org/31700 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit eb91fb0313b9e9f3b1276502aebf77ca8ff6c115) Reviewed-on: https://gerrit.libreoffice.org/31742 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-08Updated coreGabor Kelemen
Project: help aa120b6386f9e1bf6ae4d0026e115778bba1bbb3 tdf#93499 Better examples for similarity search No one shoud feel offended while reading our help. Change-Id: I14763604af35724e0d94d4de34da1c3a36fd727d Reviewed-on: https://gerrit.libreoffice.org/31740 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 88cdb657a8a2043f23e083f1a10bfc0f95d2d0ae) Reviewed-on: https://gerrit.libreoffice.org/31741
2016-12-07tdf#104434 tdf#104451 Revert "tdf#46738 Fix exporting .xlsx of coloured em"...Eike Rathke
This reverts commit 5239cefff56875c7bb45c046977f1724aace0cfb. That lead to including / looping through all formatted rows, which easily happens if an entire column is formatted. Also when printing it would print all formatted rows and printing a million empty coloured rows certainly is not desired, only one sheet of paper maybe. Which was the original intention of SC_VISATTR_STOP and as the name GetLastVisibleAttr() suggests the function is for visible attribution. (cherry picked from commit 00afb44987ccd10bce740aef53861ec53c75c95f) Change-Id: I58cefd6760706e6ac4d0db91ee8edceaed20c87e Reviewed-on: https://gerrit.libreoffice.org/31734 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-07update creditsChristian Lohmaier
Change-Id: I0d80228d2e33c03daacb0b3be4c5f3fc90324836 (cherry picked from commit 2b5305d3020435c57d75d19f332acea10049ef69)
2016-12-07xmlsecurity DigitalSignaturesDialog: show signature type on the UIMiklos Vajna
The code already knew if the signature was AdES-enabled or not, but that info wasn't available on the UI. The values are all names of standards, Andras says it's OK to have them non-translatable. (cherry picked from commit 81f7824a9839d3230b4e58424a64a393e8ee0223) Change-Id: I20baf0871fe2c84b04b7fc64014061e341744db8 Reviewed-on: https://gerrit.libreoffice.org/31724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-07stab at the sick "units in character width of the standard font", tdf#101363Eike Rathke
Which gave problems in the unit test on tinderbox build machines, apparently because they don't have not even the resulting fallback font installed. Specifically here digit '1' was slightly wider (123) than digit '0' (122), which the import accounts for but the export didn't, so widths were divided by 122 instead of 123 hence resulted in 24.23 instead of 24, for example. Change-Id: If8a04383632de674ae2a15a79608661e434aeb54 (cherry picked from commit 20b54a228b2844ad66d80d930d4a9eb39ce8c336) Reviewed-on: https://gerrit.libreoffice.org/31729 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-07tdf#104317 RTF import: avoid setting CustomShapeGeometry on a line shapeMiklos Vajna
Even Santa Claus knows it has no such property. (cherry picked from commit c2e070d9a8192e7aceed64a63c716c7317843747) Change-Id: I46e27868c62fabd10c6447956e40e55962ee284b Reviewed-on: https://gerrit.libreoffice.org/31723 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-07Make VclPtr move assignment operator actually moveStephan Bergmann
071e23fee07b92b8f07800cda3ca7e66afe818ae "add move operators for VclPtr" added (among other things) a move assignment operator that rather copied m_rInnerRef. But if b72c6feba87bd8707f39902a3066ba476188cb1d "manage VCL widgets using rtl::Reference" had not pointlessly introduced a user-declared copy constructor in the first place, all the copy/move special member functions would be implicitly declared (as VclPtr does not have a user-declared destructor). Change-Id: I1bec05a7a1b5b48a7b7d74e64a88f118454f8cb2 (cherry picked from commit deaeae4d9571d2a1d4c49fc51435139e7a051f3b) Reviewed-on: https://gerrit.libreoffice.org/31682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-07Revert "attempt to fix Linux-rpm_deb-x86_71-TDF tinderbox build, tdf#101363"Eike Rathke
This is a combination of 2 commits. Revert "try a volatile" This reverts commit 8a460cfa1b1ce01c7a479ce2e7f21a92a2c50de3. Turns out the cause is something completely different.. (cherry picked from commit ed4da005b076b5b1ea96dcc4b8caa994709ee733) Revert "attempt to fix Linux-rpm_deb-x86_71-TDF tinderbox build for 5-2, tdf#101363" This reverts commit 39aa5c2c653f36393416a6aadd6e599051bbfe7b. Turns out the cause is something completely different.. (cherry picked from commit 709053fc72db3eacfec0a7d8e47557b34bc6193e) Change-Id: I55f4ac6f48029676ec531a021d3b6939f670bde0 Reviewed-on: https://gerrit.libreoffice.org/31701 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-07Fixes tdf#104412 - DirectoryNameoutofPath no longer worksAlex McMurchy1917
In the macro tools library the subroutine GetFileNameWithoutExtension has a missing bracket in the last line. This confuses the following subroutine DirectoryNameoutofPath causing it to fail. This only came to light after the introduction of commit "tdf#80731 Closing parenthesis is now detected (Mid statement and functions)." which tightened up on syntax validation. This commit adds in the missing bracket to subroutine GetFileNameWithoutExtension in the macro tools library. Change-Id: I015c88a29a933cd42b7a7623a9ae70d090739c54 Reviewed-on: https://gerrit.libreoffice.org/31677 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 08befaceb65bf2f0f0e8ec976f7826be8f5dd7d7) Reviewed-on: https://gerrit.libreoffice.org/31695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2016-12-06Resolves: rhbz#1401778 gtk3+wayland switching windows from the menu woesCaolán McNamara
ignore 0 timestamps cause they're useless and get the current event time stamp during MenuBarReturnFocus to determine the timestamp of the menu command dispatch (cherry picked from commit adfcd16220444ef3ea318515c5a331210250e45f) Change-Id: Ia4b00aafc9ef47b41dcca2c160e943200db5c524
2016-12-06SafeModeDialog: Rename widget to match labelSamuel Mehrbrodt
Change-Id: I6bb02527fa77846343e55ff73497d1b46b5e1ba8 Reviewed-on: https://gerrit.libreoffice.org/31699 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 6ce819eefe8dab8ba38bda160e45ccc4220c40f3) Reviewed-on: https://gerrit.libreoffice.org/31704
2016-12-06SafeModeDialog: Add option to reset bundled extension registrationSamuel Mehrbrodt
Change-Id: Ic83ada7cc76142852643cefa60b4fc9286e0756a Reviewed-on: https://gerrit.libreoffice.org/31694 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 4a4c4d3768eab66c14e9e444e33bca0acb60981e) Reviewed-on: https://gerrit.libreoffice.org/31703
2016-12-06SafeModeDialog: Rename to match realitySamuel Mehrbrodt
This doesn't remove shared&bundled extensions, but resets the registration database from shared extensions. Change-Id: I9f198fc7b771fd3bd31547008fd8d006a6d1b5d5 Reviewed-on: https://gerrit.libreoffice.org/31693 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit a3597a3f370175d0c06887e6691cbfa045937ad4) Reviewed-on: https://gerrit.libreoffice.org/31702
2016-12-06SafeModeDialog: Could not activate checkboxes to remove extensionsSamuel Mehrbrodt
Because of missing event handler Change-Id: Id546a2b22a89321ca09ec29ba7787a1315753bcf Reviewed-on: https://gerrit.libreoffice.org/31692 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 801f578fe43965a7e97cef71081e9a79a6cab72c) Reviewed-on: https://gerrit.libreoffice.org/31697
2016-12-06Simplify codeSamuel Mehrbrodt
Change-Id: Ibb154ebdacb6f445371cb55d795420f92bed0a22 Reviewed-on: https://gerrit.libreoffice.org/31691 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 9da0627254ca31f768740a7b6012ca85d925fb30) Reviewed-on: https://gerrit.libreoffice.org/31698
2016-12-06Do not enable radio buttons of image flip on createMuhammet Kara
On the Image tab of the Image Properties dialog, The radio buttons under the horizontal flip option should come disabled when that option is not checked. Wrong order of "Enable" calls was causing them to be enabled on create, all the time. Change-Id: Ie361a8280e2a303d38025c5c684f5c07ba2e1ef9 Reviewed-on: https://gerrit.libreoffice.org/31652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2016-12-06try a volatileEike Rathke
Change-Id: Iadaeb1cdf8a73cac3308e82caa2e65db07ec0fc1 (cherry picked from commit 8a460cfa1b1ce01c7a479ce2e7f21a92a2c50de3) Reviewed-on: https://gerrit.libreoffice.org/31663 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-12-05attempt to fix Linux-rpm_deb-x86_71-TDF tinderbox build for 5-2, tdf#101363Eike Rathke
See http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=libreoffice-5-2&brief-log=1480964401.32227 (as long as it is there) Change-Id: If119a19e2f5dbe53298f0b30b5749997d99bf884 (cherry picked from commit 39aa5c2c653f36393416a6aadd6e599051bbfe7b) Reviewed-on: https://gerrit.libreoffice.org/31658 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-12-05fix display of DMG background on Mac OS X SierraChristian Lohmaier
Change-Id: Ib553e085337972f74857db0aad9bc885712d5ea3 Reviewed-on: https://gerrit.libreoffice.org/29788 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> (cherry picked from commit 78dabf58b6a1552c82e8dc6096833f7ce36a5414)
2016-12-05tdf#91475 Fix column width during .xlsx exportBartosz Kosiorek
With commit 16726a1b37df8bdcae02b3c7699df814977222bd the new import algorithm was introduced. Unfortunately it looks like that some specific column width are improved, but for other widths it is worse. More information is available at: https://bugs.documentfoundation.org/show_bug.cgi?id=91475#c29 In this commit I added unit tests which prooves proper working of old algorithm and I have switched to old algorithm. Unit test which was done: 1. After resave .xlsx file, the column width values did not change 2. After export .ods to .xlsx displayed column width did not change 3. After save .xlsx to .ods displayed column width did not change This commit resolve column width after exporting to .xlsx, and correctly preserve column width for LibreOffice. Change-Id: I26d074b203d08a4bf4e9e31e52dbfd7ca7d3beb1 Reviewed-on: https://gerrit.libreoffice.org/27943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit f2a75fecdfb5d92d27074312f29dc7dc4afb16ec) Reviewed-on: https://gerrit.libreoffice.org/31625
2016-12-05xmlsecurity mscrypto PDF verify: implement support for non-detached signaturesMiklos Vajna
This was the last unit test that was disabled on Windows due to missing implementation. (cherry picked from commit e58ed17e35989350afe3e9fd77b24515df782eac) Change-Id: Ia7d84f72bcdf79267c7de17cd8822ed02c378642 Reviewed-on: https://gerrit.libreoffice.org/31618 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-05tdf#80196 - rename palette to tonal.soc and adjusting namesV Stuart Foote
for 5.3.0 renamed from tonal_column.soc and removed abbreviations Change-Id: I72dbbab2688709e8266be93b40040c4c6c970d55 Reviewed-on: https://gerrit.libreoffice.org/31217 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 98419425080f58880f2d0d85749a4a55e8abb40b) Reviewed-on: https://gerrit.libreoffice.org/31510 Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>