summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-18The '<= 0' check can go nowStephan Bergmann
...after 0083b33650c2f584ceff6eeaf9ef6993bfe0ae9b "sal: -Werror,-Wsign-compare (32-bit)" cast the check against SAL_MAX_UINT32 to unsigned, anyway. (And the check for == 0 is already handled in the platform-generic part below.) Change-Id: I0d0354cb9368bffef5d3aa835f865524d106a6f3
2017-09-18Reflect recent download.lst changes to flatpak-manifest.inStephan Bergmann
Change-Id: I5df5e2384670a5ca10ad8ed30a2f6d76a0f7b906
2017-09-18add fodt fuzzerCaolán McNamara
Change-Id: I3e4de4b9dab96f0e4bc9ca90896c2c54ae66ca20 Reviewed-on: https://gerrit.libreoffice.org/42251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18tdf#106945 TSA Dialog: Disable delete buttonSabin Frandes
Change-Id: Idce5ccc36254d80aaf4b5d5f81cfe201e5c27a5f Reviewed-on: https://gerrit.libreoffice.org/42315 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-18vcl: [loplugin:reservedid]Michael Stahl
Change-Id: I47d4322f094456761e497b3ca5feb5a5dfc73704
2017-09-18hwpfilter: [loplugin:redundantcast]Michael Stahl
Change-Id: Ib8fbe3babc9eb2b0b1125de62b0b8012ac710889
2017-09-18unused nResMaxNumberOfSuggestions in PropertyHelper_SpellNoel Grandin
since commit a111044babf3ee929baf548b7ad29df0a419293b Date: Wed Jul 15 10:49:17 2015 +0200 loplugin:unusedmethods linguistic Change-Id: I329c53b739395e9332b767562a138b52ce2fe588
2017-09-18maPrimitiveColor in Shadow3DExtractingProcessor unusedNoel Grandin
since commit 9927e1ca23c8353c880a3ae0a196caabdf747c4b Date: Wed Aug 9 16:00:16 2006 +0000 #i39532# Change-Id: I1db3db2c4860d6ad71085cc3cfdeb202eec7e24a
2017-09-18unused m_xAccInfo in AccessibleEditableTextParaNoel Grandin
since commit c23ab5eaed57cc3fb5860e26c591c73c5b22687b Date: Tue Nov 26 14:25:22 2013 +0000 Integrate branch of IAccessible2 Change-Id: Id068fb0a49f5a1e79ca17fe66885cda558abe275
2017-09-18remove unused aLocale from SvxNumRuleNoel Grandin
and fix usage site, regression from commit 41956321ceefb5836feb2c119b66de7bb557740f Date: Sat Nov 24 18:54:09 2012 +0100 get rid of Svx...Locale...() double conversion nonsense Change-Id: Ic70abf5f52dce1db9cffd9c819e57f1a6c2a3df3
2017-09-18unused menu extension supplier stuffNoel Grandin
since commit 5298b1b32d90002be8d09fe82955550c18eae8bc Date: Mon Aug 8 11:48:55 2011 +0100 callcatcher: ditch some more methods Change-Id: I123081cbe7fe351ce6613a5e7491b11e133d1d29
2017-09-18msCommandName in ControllerItem is unusedNoel Grandin
ever since commit 1c5cae479bebd2d325182adc2c9821fd948fd1bd Date: Thu Apr 20 08:44:33 2017 +0200 loplugin:unusedmethods Change-Id: I7c02e8bf0ef377303dedf4e6690fd937f52a3605
2017-09-18msDescription in SvtRulerAccessible is unusedNoel Grandin
ever since commit 2b12a5b87b1de9ae95d9562ba21201890b1100c5 Date: Mon Feb 10 09:29:34 2014 +0000 the return of callcatcher Change-Id: I62021793e5ca90cba9d2e6998f5ac30da33764f7
2017-09-18aFocusRect in CheckBoxControl is unusedNoel Grandin
ever since commit ff09f8d6ef2c613037f039dbcafcad6b76243a48 Date: Thu Mar 27 13:40:07 2003 +0000 MWS_SRX644: migrate branch mws_srx644 -> HEAD Change-Id: I71905a95a86757be59abeee6140ef57516176a6a
2017-09-18headString in SvTreeListBox is unusedNoel Grandin
ever since being added in commit b755fb8c0f6b1282f62c12f378c0a5ecac64d490 Date: Mon Nov 25 16:15:58 2013 +0000 Integrate branch of IAccessible2 Change-Id: Iebb8d30d53cc08e7cc35d610f04db8ed6c853b70
2017-09-18loplugin:unusedfields in SvxPixelCtlNoel Grandin
aLineColor is unused since commit fa1807ad5457d10f8fa073c209a27547e8922c8c Date: Thu Aug 27 21:18:58 2015 +0300 tdf#93558 Hardcode black text on white background Change-Id: Idadfa926808568195256c7ea7ac92d71533fe9a9
2017-09-18loplugin:unusedfields in ResultSetColumnDataNoel Grandin
ever since introduction in commit 24f26145eb03b2fe8e0099309d7e6fa1a0061ef4 Date: Thu Jan 18 08:03:55 2001 +0000 "#82177# - Added support for additional column data ( case- sensitivity, ... )" Change-Id: I593f7e2a3be7b6445c7975ff385b6ba0d35183b9
2017-09-18clang plugins: this test fails on 32-bit LinuxMichael Stahl
... where sal_uIntPtr and sal_uInt32 are both "unsigned long"; disable test for now. Change-Id: I8357bf425ab5d9166cd45ba5fb81ec6c1fac957a error: 'error' diagnostics expected but not seen: File compilerplugins/clang/test/convertuintptr.cxx Line 15: cast from 'sal_uIntPtr' (aka 'unsigned {{.+}}') to 'sal_uInt32' (aka 'unsigned {{.+}}') [loplugin:convertuintptr] File compilerplugins/clang/test/convertuintptr.cxx Line 16: cast from 'sal_uIntPtr' (aka 'unsigned {{.+}}') to 'sal_uInt32' (aka 'unsigned {{.+}}') [loplugin:convertuintptr]
2017-09-18bridges: [loplugin:stringconstant]Michael Stahl
Change-Id: I07501ac3593cd5df713b74e04ea64d22365958b9
2017-09-18tdf#109118 Added new buttons into Mail Merge toolbarSerge Krot
New buttons are: - uno:ViewDataSourceBrowser - uno:AddressBookSource Change-Id: I03d475edc01885137cb792c0654e68861725e8ee Reviewed-on: https://gerrit.libreoffice.org/42334 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-18convert SvxDateFormat to scoped enumNoel Grandin
And simplify the code in sd/headerfooterdlg, no need for the complex encoding of date and time when we can just index into a static array. Change-Id: I677400bf1f956c81eba665b71dbda9183b63f55c Reviewed-on: https://gerrit.libreoffice.org/42346 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-18sal: -Werror,-Wsign-compare (32-bit)Michael Stahl
Change-Id: I204716eea112a1c99f6ac4df0d138c4c7d8b68e3
2017-09-18use pkg-config --modversion to check for ICU versionRene Engelhard
... since icu-config is removed at least in Debians icu 59.1 packages. icu-i18n exists since exactly 4.6 (which we require anyway) so we can remove that check, too Change-Id: I28bd1509dcc2c52e22f91fb26421fcd585323b24
2017-09-18Translate German comments and debug strings (leftovers in dirs w... and x...)Johnny_M
Translates leftovers found using a custom regex in directories beginning with "w" and "x". Additionally: - A few corrections of previous translations Change-Id: Ic30cf6792748a6bea8782a9a3711fa468b80bdaf Reviewed-on: https://gerrit.libreoffice.org/42378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-18svx: Assert that GetMarkedSdrObj() cannot be null hereTakeshi Abe
as such invalid ones have been removed already in advance. This could come togeher with c0e9968b4bbda9563213589bcb0472f8797bb553. Change-Id: I914031390d13dd4ad91d2ead61db7f2d53c78004 Reviewed-on: https://gerrit.libreoffice.org/42365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-18Adapt external/nss/asan.patch.1Stephan Bergmann
...to a52ca01f6ae27a86cae6e82b3c5ae6601f3ea398 "nss: no rpath/origin flag for Android (unused DT entry/DT_FLAGS warnings)" Change-Id: I60e4ba1af572aa702a355e26dec58142209f8655
2017-09-18Acknowledge that WinSalGraphicsImpl::drawPolyLine modifies pPtAryStephan Bergmann
Change-Id: Idde44857f8ace883cc759321c71e2ca7a4359334 Reviewed-on: https://gerrit.libreoffice.org/42406 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-18tdf#109310 ooxmlexport: write Xnote character styleJustin Luth
LibreOffice will just ignore the defined style on import (since that is statically defined by the footnote code). Microsoft Office, however, requires the character style be provided for the footnote number. It doesn't have any built-in formatting for footnotes. So, this patch is strictly for MSO's benefit. Change-Id: I6631dd0eb697589cfd3c13d7838fe14c31a71bbf Reviewed-on: https://gerrit.libreoffice.org/42035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-18related: tdf#111967 fix assertions about silly column positionsMichael Stahl
ImplLogicToPixel() is called with ~LONG_MIN value, which comes from SwView::StateTabWin() where we have: (rr) p aTabCols $12 = { nLeftMin = 1134, nLeft = 0, nRight = 4618, nRightMax = 9223372036854775807, bLastRowAllowedToChange = true, aData = std::__debug::vector of length 9, capacity 16 = {{ nPos = 387, nMin = 0, nMax = 9223372036854775807, bHidden = false }, { The problem is that the "aTabCols.GetRight() - rEntry.nMax" becomes negative, which is probably wrong, so enforce a minimum of 0. (regression from 4c60f722afdc0be5c129ce5f5ed6786d09d0051e, which removed a cast of the value to sal_uInt16, which also didn't look right to me, but perhaps wouldn't cause this assert?) Change-Id: Ia1aa2cd100ac25a8c34902cc992d54954fead284
2017-09-18sw dbmgr: fix indent of these statementsMiklos Vajna
Change-Id: I4eae19f5a724c44ec382053ace2f3fcd586fd6f3
2017-09-18sw: prefix members of SwFormatFlyCntMiklos Vajna
Change-Id: I41c611d4babe227ce298ed8d6ba3d9e05da5a82b Reviewed-on: https://gerrit.libreoffice.org/42404 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-18Put back some #include (needed for e.g. --disable-pch)Stephan Bergmann
...that had been removed too eagerly with 1f543b817a7e8bdef9482c4c61bc1672bf04e39f "osl/w32: don't use 8-bit string functions" Change-Id: I9d16cc5ff9b779457d8d70c7f206d5e684342c63
2017-09-18improve unusedfields lopluginNoel Grandin
(*) IsPassedByNonConst was completely wrong, not even sure why it worked before. (*) treat a field passed to operator>>= as being written to, but not read Change-Id: Id3a5f2f35222986fe5edba3f5a58215a1815d401
2017-09-18Use even more WIN32_LEAN_AND_MEANMike Kaganski
Change-Id: I538fe5b41156366e0e87b3a93e58a3947afd18f5 Reviewed-on: https://gerrit.libreoffice.org/42398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-18Removed duplicated includeAndrea Gelmini
Change-Id: I38e3ecdf892f5e5212e4332868e5811c347d6978 Reviewed-on: https://gerrit.libreoffice.org/42400 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-18Fix typoAndrea Gelmini
Change-Id: I0e9a89a3c611692e64b7faa0f460c3979c29bf91 Reviewed-on: https://gerrit.libreoffice.org/42348 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-18Related tdf#112425: fix another leak in MacSpellCheckerJulien Nabet
Apply the same changes in GetProposals than GetSpellFailure Change-Id: Id78966568833f29c21f44724974254218636597d Reviewed-on: https://gerrit.libreoffice.org/42397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-17detect corrupted job setupCaolán McNamara
Change-Id: I0d3b4850c3d4c015a0a7e5d36d87113a749c7e0f Reviewed-on: https://gerrit.libreoffice.org/42383 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-17protect against short fileCaolán McNamara
Change-Id: I20c6a6fb34485f42c2a828618e8918d8a441860a Reviewed-on: https://gerrit.libreoffice.org/42389 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-17Updated coreAndras Timar
Project: translations db1be6fc22a2376bd591f94b0268817e4beb1464 Updated Slovenian translation Change-Id: I9a5ce2c6cf300c520cb0ab8b33fb53fbc49da7dd
2017-09-17valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara
Conditional jump or move depends on uninitialised value(s) at 0x4C3535E: strstr (vg_replace_strmem.c:1623) by 0x4FCD9E59: SmFilterDetect::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&) (smdetect.cxx:102) by 0x41A1A774: filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (typedetection.cxx:1038) Change-Id: I2f98fd3f7799f34cb5bd9242379ce6440645034d Reviewed-on: https://gerrit.libreoffice.org/42381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-17ofz: string has to be at least 5 chars longCaolán McNamara
Change-Id: I98c50a59c03fc886d50362b9c5dd8c84f60e0b62 Reviewed-on: https://gerrit.libreoffice.org/42379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-17fix leak on exceptionsCaolán McNamara
Change-Id: I88201acb472dbdb2c3b49945b962c5f2689d3bae Reviewed-on: https://gerrit.libreoffice.org/42376 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-17ofz: fix leak on exceptionCaolán McNamara
#0 0x600ca0 in operator new(unsigned long) /src/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:82 #1 0x4802b4b in xmlscript::DocumentHandlerImpl::pushPrefix(rtl::OUString const&, rtl::OUString const&) /src/libreoffice/xmlscript/source/xml_helper/xml_impctx.cxx:259:32 #2 0x47ff026 in xmlscript::DocumentHandlerImpl::startElement(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) /src/libreoffice/xmlscript/source/xml_helper/xml_impctx.cxx:480:17 #3 0x7665a34 in xmlscript::XMLBasicImporterBase::startElement(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) /src/libreoffice/xmlscript/source/xmlflat_imexp/xmlbas_import.cxx:537:25 #4 0x4c2831f in XMLBasicImportContext::StartElement(com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) /src/libreoffice/xmloff/source/script/xmlbasici.cxx:84:21 #5 0x489c29b in SvXMLImport::startElement(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) /src/libreoffice/xmloff/source/core/xmlimp.cxx:728:15 #6 0x4892ab7 in SvXMLImportContext::startUnknownElement(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /src/libreoffice/xmloff/source/core/xmlictxt.cxx:124:14 #7 0x489ec2d in SvXMLImport::startUnknownElement(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /src/libreoffice/xmloff/source/core/xmlimp.cxx:889:15 #8 0x86871f3 in (anonymous namespace)::Entity::startElement((anonymous namespace)::Event*) /src/libreoffice/sax/source/fastparser/fastparser.cxx:445:27 #9 0x86823f1 in sax_fastparser::FastSaxParserImpl::consume((anonymous namespace)::EventList&) /src/libreoffice/sax/source/fastparser/fastparser.cxx:960:25 #10 0x86812f8 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) /src/libreoffice/sax/source/fastparser/fastparser.cxx:784:26 #11 0x489842e in SvXMLImport::parseStream(com::sun::star::xml::sax::InputSource const&) /src/libreoffice/xmloff/source/core/xmlimp.cxx:464:15 #12 0x837fb5d in filter::odfflatxml::OdfFlatXml::importer(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XDocumentHandler> const&, com::sun::star::uno::Sequence<rtl::OUString> const&) /src/libreoffice/filter/source/odfflatxml/OdfFlatXml.cxx:149:26 Change-Id: Ic4ba40dca088a333a1271e005a05bd3c6e7d70ac Reviewed-on: https://gerrit.libreoffice.org/42375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-17valgrind: leak in fdo42771-1.fodtCaolán McNamara
at 0x4C2E1FC: operator new(unsigned long) (vg_replace_malloc.c:334) by 0x148794C2: XMLParaContext::CreateChildContext(unsigned short, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) (txtparai.cxx:2167) by 0x14517821: SvXMLImport::startElement(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) (xmlimp.cxx:704) by 0x14511B09: SvXMLImportContext::startUnknownElement(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (xmlictxt.cxx:127) by 0x145114AE: SvXMLImportContext::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (xmlictxt.cxx:77) by 0x14518654: SvXMLImport::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (xmlimp.cxx:854) by 0x463D934A: (anonymous namespace)::Entity::startElement((anonymous namespace)::Event*) (fastparser.cxx:456) by 0x463DD799: sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) (fastparser.cxx:1205) by 0x463D7956: call_callbackStartElement (fastparser.cxx:306) by 0x13F667FF: xmlParseStartTag2 (parser.c:9793) by 0x13F6D77C: xmlParseTryOrFinish (parser.c:11591) by 0x13F6EF6A: xmlParseChunk (parser.c:12496) Change-Id: I89a6a9035e7016d6d96a78e62dba42fb2f148258 Reviewed-on: https://gerrit.libreoffice.org/42372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-17Replace some lists by vectors in dbaccessJulien Nabet
Change-Id: Ibf75bec826661fcff7d71e9e2f11884e498a299b Reviewed-on: https://gerrit.libreoffice.org/42382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-17make freetype patch apply againCaolán McNamara
Change-Id: I5732a78774ac1e5d50212ab219646bf52797f173 Reviewed-on: https://gerrit.libreoffice.org/42380 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-17replace some boilerplate with C11++Bjoern Michaelsen
- also get rid of old OSL_* in favor of SAL_WARN* Change-Id: I4292cb3292c37fe9905a40903d9094c6206ab7f6 Reviewed-on: https://gerrit.libreoffice.org/42374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-17fix android buildCaolán McNamara
Change-Id: Ibb536240a623559f9da45b450eae1ec58e951d6e Reviewed-on: https://gerrit.libreoffice.org/42373 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-17Prefer prefix operatorJulien Nabet
Change-Id: I44934f66b11fc537045df1d15fe98844ee7045ca Reviewed-on: https://gerrit.libreoffice.org/42370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-01-01 09:03:30 +0000