summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-12-13tdf#121180: close Options dialog when restart is confirmedMike Kaganski
Change-Id: Ieb6e62ca83921abed6b6432d70c6717dadfaaa34 Reviewed-on: https://gerrit.libreoffice.org/65090 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-13Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update DTD for <pycode> Change-Id: Icbda71715b4c23644699e9963983ab2db7c0074a Reviewed-on: https://gerrit.libreoffice.org/65103 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-12-13Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add info on python location in filesystem Change-Id: Iae5f0cc2d95f8f24d2ba7d5ee8e9013d87c851f6 Reviewed-on: https://gerrit.libreoffice.org/65096 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-12-13update groupedbar_compact for calcandreas kainz
Change-Id: Iebbf1eb2db64efa340287b0e0846fa8a121ddf19 Reviewed-on: https://gerrit.libreoffice.org/65081 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-13Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add support for python code scripts Introduced <pycode> section and "pycode" role for paragraphs with same behaviour as BASIC coounterparts. Used to list python scripts examples ans code fragments in help pages Change-Id: Ica76bcc65dcf422a1eb4b7f39a6d671b2e4e573c Reviewed-on: https://gerrit.libreoffice.org/65097 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-12-13Introduce --enable-android-editingStephan Bergmann
...to select the experimental ...Editing... Android build variant. (Ignored for non-Android builds, but using libo_FUZZ_ARG_ENABLE anyway, just in case.) Change-Id: I670925ff358039e38edc29db69f48a78d484f133 Reviewed-on: https://gerrit.libreoffice.org/65077 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13Un-revert the addition of more ABI checks for LibreOfficeKitClassTor Lillqvist
Change-Id: Idf2ebb552065fa600a4010e83a24a0f13651c029
2018-12-13tdf#121890 ODF custom shapes use left and top from viewBoxRegina Henschel
MS custom shapes use always zero for identifier left and top in the formulas of the shape geometry. But custom shapes in ODF use the left and top value from the svg:viewBox attribute, see table 11 in section 19.171 draw:formula; part 1 of the spec. Change-Id: Ief4b9d9b8797e165a494d049f32c5a46880044c2 Reviewed-on: https://gerrit.libreoffice.org/64704 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-12-13Revert adding the tanslateGet() and translateNGet() API to LibreOfficeKitTor Lillqvist
Will handle it another way instead that isn't so visible and annoying. This reverts commit 5f0dda8e9f2e35e1fdb5750089a70543478fa8a1. This reverts commit 4f1a341bc312673b8d92e4474cc39bc3ab69aa5b. Change-Id: If456d2792a5f2793ee6337898aaa4a55637f8522
2018-12-13Fix typoAndrea Gelmini
Change-Id: Ib380d6cbb1d858877cb14263cdc6beff6f0b97af Reviewed-on: https://gerrit.libreoffice.org/65068 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-13Introduce ScFunctionData::update() and getResult()Eike Rathke
... to further replace code where that is explicitly done. Change-Id: I2d4065ee2c111a073b65bfc0e42e3479fbd9cf6e Reviewed-on: https://gerrit.libreoffice.org/65039 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-13use unique_ptr in checkForUniqueItemNoel Grandin
fixing a memory leak in chart2 Change-Id: Idddb6a46b1bde5c1a11148c03bbdaac20ac78e13 Reviewed-on: https://gerrit.libreoffice.org/65031 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13vcl/win/gdi: get dither mapping value explicitlyDmitriy Shilin
Having a macro with a very short and nice API but assuming that some variables must be defined before using it leads to a huge misunderstanding. Change-Id: Idb16307ab4bdeff055ee2a9e237c1436cacd3591 Reviewed-on: https://gerrit.libreoffice.org/65069 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-13Add missing "!"Stephan Bergmann
Change-Id: Ic3e50e1a64b334bee86db7456a4821fa9427370b
2018-12-13Make it more obvious which enumerators the comments pertain toStephan Bergmann
i.e., the following one, not the preceding one; see the discussion at <https://gerrit.libreoffice.org/#/c/65022/> "tdf#104277 follow-up: use svtools::executeRestartDialog" Change-Id: I527d2f125d8d90ceb382119befc291e7f91bad66 Reviewed-on: https://gerrit.libreoffice.org/65071 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13Add more missing constructors from chart2/source/chartcore.componentTor Lillqvist
I think it would be better if native-code.py parsed the .component files it is interested in and just copied the constructor names from them to its output? Or are there many cases where it is a carefully manually selected subset of constructors from some .component file that should be put in the generated native-code.h, not all? But even in that case, if some constructor should not be linked in to a mobile app, that could be handled by adding some specific attribute in the .component file. Change-Id: Ib947279610f6755f112d3571512406c5d0cd620d
2018-12-13use unique_ptr in SfxWorkWindowNoel Grandin
Change-Id: Id7133fd21a0d0d2a3138ba5f27e7637c9ed65d78 Reviewed-on: https://gerrit.libreoffice.org/65024 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13Pass --en-/disable-werror into external/libexttextcatStephan Bergmann
(which otherwise always defaults to --enable-werror) Change-Id: If0e430e0d0994088a61843ea8f3759adbc993be6 Reviewed-on: https://gerrit.libreoffice.org/65075 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13We need CartesianCoordinateSystem2d for chartsTor Lillqvist
Change-Id: I3edccbe29129f6d60a4ac4627a0ab646e4e42458
2018-12-13Fix getRTTI for Android x86Stephan Bergmann
First, make sure existing compiler-generated RTTI from liblo-native-code.so is found (so that catching bridge-synthesized exceptions in native code works with libc++abi, which checks type equivalence by address instead of string comparsion), by using the dlsym(RTLD_DEFAULT,...) mechanism as in the ANDROID gcc3_linux_arm bridge case. And second, if that should fail, synthesize the type_info even if the included cxxabi.h doesn't provide the relevant type declarations, by using copies from the ABI specification, as also done on other platforms. Instead of always having getRTTI fail and raiseException throw a non-synthesized css::uno::RuntimeException("no rtti for type ..."). Which explains the mystery discussed in the commit message of 312eeeee42cb4a1e356943e17305555e41afc4ef "Switch Android armeabi-v7a to libc++/libc++abi/libunwind too", why the observed misbehavior on x86 was so different from that on armeabi-v7a. Change-Id: I9308654c5c2b88b4d27e0e8e9edda1849133a161 Reviewed-on: https://gerrit.libreoffice.org/65070 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13Resolves: tdf#120481 gradient subpage 12 pixels too shortCaolán McNamara
because the max preferred-size of the subpages is taken and applied as the size-request of the container parent. But the container parent as a 6px border, so the subpages end up hosted in a parent which allocates them 12px less than they hoped for. As they are instantiated in the parent to measure them, measure their parent instead and that calculates in the parent's border to end up with what they wanted Change-Id: Ib270b90f9c2fed7f8bd042cc66d0d10ad3c6f183 Reviewed-on: https://gerrit.libreoffice.org/65058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-13Pass --en-/disable-werror into external/libnumbertextStephan Bergmann
(which otherwise always defaults to --enable-werror) Change-Id: I928277cec62dd36da0b18eb622ee91c176c9ccc6 Reviewed-on: https://gerrit.libreoffice.org/65072 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13Library_xsec_xmlsec: one dll implementation macro is enoughMiklos Vajna
Change-Id: Ie6111c5e29d2fb6d2857c0c51d84b5b720713260 Reviewed-on: https://gerrit.libreoffice.org/65064 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-13loplugin:unusedfields improve write-only logicNoel Grandin
when dealing with modifications to container classes (e.g. std::vector) Change-Id: Ic30043631007355ee9a3d9e3f9b6488b435182d6 Reviewed-on: https://gerrit.libreoffice.org/65050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13tdf#11976 update groupedbar_compact writer NBandreas kainz
Change-Id: I5be7ae9a49122c73ce5a16e773665bcc4c9593be Reviewed-on: https://gerrit.libreoffice.org/65066 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-13sc: Use std::find() to simplify codeTakeshi Abe
Change-Id: I903a59591cd204556e873429280aac9cf8d5325a Reviewed-on: https://gerrit.libreoffice.org/65067 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13loplugin:unusedfields in variousNoel Grandin
Change-Id: I4021ba6090bd3f42b0eb5ea1ec9bbf05d1594b35 Reviewed-on: https://gerrit.libreoffice.org/65054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13loplugin:unusedfields in scNoel Grandin
Change-Id: I5c9e92f5aff6d8fcae7e6affe2977f5804133ea9 Reviewed-on: https://gerrit.libreoffice.org/65053 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13uitest for bug tdf#39650Zdeněk Crhonek
Change-Id: I1eb757939c31aafd9730715bd43a60513842e560 Reviewed-on: https://gerrit.libreoffice.org/65056 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-13loplugin:unusedfields in sdNoel Grandin
Change-Id: Ifbcaeb1fae1c181861ceceed79dc0c9fd6545751 Reviewed-on: https://gerrit.libreoffice.org/65052 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13loplugin:unusedfields in swNoel Grandin
Change-Id: I523146ae16ed87ef042b9d19217d70ae02e411d3 Reviewed-on: https://gerrit.libreoffice.org/65051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13uitest for bug tdf#44398Zdeněk Crhonek
Change-Id: I998784e9382866e1afdce4618a2f4acb25d3efa6 Reviewed-on: https://gerrit.libreoffice.org/65060 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-13loplugin:useuniqueptr in i18npoolNoel Grandin
Change-Id: I57c6ce2a8c48bc87404e596b8843efd67ea0872d Reviewed-on: https://gerrit.libreoffice.org/65033 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13loplugin:useuniqueptr in desktop::BackendImplNoel Grandin
Change-Id: I3efea7e47ad18a1dd39e81929aac319fe46357f0 Reviewed-on: https://gerrit.libreoffice.org/65032 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13uitest for bug tdf#39917Zdeněk Crhonek
Change-Id: I6b3c8a72cc36db802aace7aa54efc167d19c1bc9 Reviewed-on: https://gerrit.libreoffice.org/65062 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-13loplugin:mergeclasses merge LineLB into SvxLineBoxNoel Grandin
Change-Id: I76bab66b09ae809c069f586ccb1c4ce13fa30234 Reviewed-on: https://gerrit.libreoffice.org/65025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13loplugin:constantparamNoel Grandin
Change-Id: I389f98d06058ba65a8c2d4df2bf7d4e5102659ad Reviewed-on: https://gerrit.libreoffice.org/65017 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13Switch Android armeabi-v7a to libc++/libc++abi/libunwind tooStephan Bergmann
It had been left out in 4082a18406c18af7b4fcef7bd501c3679c3be56b "android: use unified headers and llvm-c++ STL (x86) with NDK 16" because "arm unfortunately crashes with llvm-c++, so keep with gnustl for now/fix that later". Making armeabi-v7a work with libc++ etc. required a number of changes, listed below, in this commit and in preceding ones. At least 32-bit x86 already worked with libc++ etc. prior to these changes in view mode, though it crashed in the experimental editing mode (enabled with strippedUIEditing in android/soruce/Makefile) as soon as one types in something, But it is not entirely clear to me why 32-bit x86 view mode didn't also fail similar to how I saw armeabi-v7a fail. (On 32-bit x86, these changes appear to neither improve nor worsen the current state, view mode still appears to work fine while editing still crashes upon typing anything. With these changes, editing mode on armeabi-v7a appears to work fine. But I tested armeabi-v7a only with a real device and 32-bit x86 only with an emulator, in case that might make a difference.) * Preceding <https://gerrit.libreoffice.org/#/c/64964/> "Move NSSLIBS to a more sensible place on the linker command line" plus this change's addition of -lunwind to the liblo-native-code.so linker command line make sure that liblo-native-code.so uses _Unwind_* functions from libunwind.a, instead of erroneously picking up the ones from libgcc.a that happen to be included in NSSLIB's nspr4 (-lgcc is automatically added to the end of the linker command line by the invoking compiler, that's how libgcc.a's _Unwind_* end up in NSSLIB's nspr4; it is neither clear to me why NSSLIB's nspr4, being a pure C library, uses _Unwind_* functions, nor why exception handling in liblo-native-code.so fails when using _Unwind_* functions from libgcc.a instead of from libunwind on armeabi-v7a, nor why that would work on 32-bit x86, but that's what I observed: ModuleManager::identify (framework/source/services/modulemanager.cxx) throws a css::lang::IllegalArgumentException, which calls __cxa_throw -> _Unwind_RaiseException, which ultimately lead to odd misbehavior and std::abort during stack unwinding when using _Unwind_RaiseException from libgcc.a instead of from libunwind). (There is no libunwind.* in android-ndk-r16b for 32-bit x86 at least, so is presumably using _Unwind_* functions from libgcc.a. It doesn't appear to make a difference if it indirectly uses those _Unwind_* functions from NSSLIB's nspr4, or directly from libgcc.a included in liblo-native-code.so if the $(if $(filter armeabi-v7a,$(ANDROID_APP_ABI)),-lunwind) had a ",-lgcc" else branch.) * Preceding <https://gerrit.libreoffice.org/#/c/64965/> "Export RTTI symbols from liblo-native-code.so, for binary UNO bridge" makes sure that excpetions thrown from the binary UNO bridge can be caught by compiled catch clauses. Not sure why the corresponding state of bridges/source/cpp_uno/gcc3_linux_intel shouldn't have run into the same issue. * Preceding <https://gerrit.libreoffice.org/#/c/64966/> "Adapt gcc3_linux_arm __cxa_exception to NDK 18 libc++abi" makes sure that our version of __cxa_exception matches the version from libc++abi. This is clearly not relevant for 32-bit x86. (The comment there android-ndk-r18b, but the additional member is already present in android-ndk-r16b/sources/cxx-stl/llvm-libc++abi/src/cxa_exception.hpp, too.) The remainder of this change just drops old armeabi-v7a--specific workarounds that are no longer needed/no longer work. Change-Id: Ief4c2d562c5032abe6c3b94ca3b3394be6fcd4d3 Reviewed-on: https://gerrit.libreoffice.org/64973 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13Adapt gcc3_linux_arm __cxa_exception to NDK 18 libc++abiStephan Bergmann
...which adds a member, and will be relevant when switching armeabi-v7a to libc++/libc++abi/libunwind (coming soon). Change-Id: I1f98f50ca299a583e73e0dbd6c8c94d973329f3a Reviewed-on: https://gerrit.libreoffice.org/64966 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13Export RTTI symbols from liblo-native-code.so, for binary UNO bridgeStephan Bergmann
This will become important when switching armeabi-v7a to libc++/libc++abi/libunwind (coming soon) which uses address instead of string comparison when checking for type equality, so that exceptions thrown from the binary UNO bridge will need to use the exact same RTTI objects as referenced from the compiled catch clauses. Change-Id: If8bcb39212b5f5e154aee215cb5f471fe2dc4a7b Reviewed-on: https://gerrit.libreoffice.org/64965 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13Move NSSLIBS to a more sensible place on the linker command lineStephan Bergmann
511ae02c6457e69cb6daab871acd9c3e7d64e2e3 "Android: Enable HAVE_FEATURE_NSS and package the NSS libraries with apk" had added them to WHOLELIBS probably just because that already had the $(addprefix -l,...), even though --whole-archive doesn't make any sense for shared libraries. Better place them later on the linker command line (after all our own archives and compiler support libraries), so that switching armeabi-v7a to libc++/libc++abi/libunwind (coming soon) will be able to override erroneously picking _Unwind_* symbols from NSSLIBS's nspr4 instead of libunwind. Change-Id: Ie0c0b7a55da3eabe1bb427232d698b2a4af63e78 Reviewed-on: https://gerrit.libreoffice.org/64964 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13Use declarations from cxxabi.h where availableStephan Bergmann
Change-Id: Ie92c9654c7ccc5cd4acde728b35311f251f740ac Reviewed-on: https://gerrit.libreoffice.org/64963 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-13tdf#107792 vcl/win/gdi: shrink WinSalGraphicsImpl::MakePen APIDmitriy Shilin
Change-Id: I7d5752214a0c2f4891dcc023c6d573a8459b65f4 Reviewed-on: https://gerrit.libreoffice.org/65037 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-13tdf#107792 vcl/win/gdi: reduce number of return pathsDmitriy Shilin
Change-Id: I3e7f00a10e76933424149a931042a0611ede5d47 Reviewed-on: https://gerrit.libreoffice.org/65036 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-13tdf#78611 mailmerge: new unit tests: numbering in headingsSerge Krot
Change-Id: I8672376dabcdc0011c59bb9ac5c32b8dbb88396d Reviewed-on: https://gerrit.libreoffice.org/65035 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-12tdf#117295 WIN no main loop shortcut for OLE dialogJan-Marek Glogowski
Normally we handle Idle events directly without posting events to the main event queue, as there seem to be no way to post them to the end of the queue and this starves system events. This prevents using this short-cut, as the default Windows event processing doesn't know of this special handling. Eventually this hack should be removed by simply always processing all pending events... Change-Id: If9ae81ca7e847743f9251343e106dbf566371584 Reviewed-on: https://gerrit.libreoffice.org/65040 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-12oox smartart, continuous block process: read space width from constraintMiklos Vajna
The information is needed by the linear layout, but it's provided by a child algorithm of type "space", with possibly multiple foreach atoms in-between. So start supporting a custom space factor by reading it from constraints, but still assume a fixed layout node name, as it's tricky to look that up. Change-Id: I2aa8db8823694618d8ca6707ddcd71715a65b831 Reviewed-on: https://gerrit.libreoffice.org/65049 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-12Reset WelfordRunner in ScDPAggData::Reset()Eike Rathke
Change-Id: I170b6bc5557f6d0d982751ace3dccc94c6778808 Reviewed-on: https://gerrit.libreoffice.org/65048 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-12Resolves: tdf#116098 avoid ctrl+shift+e as a default shortcutCaolán McNamara
Change-Id: Id5ec45290a0829d15a0d88a68d2ed891b9dae195 Reviewed-on: https://gerrit.libreoffice.org/65041 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-12expand normal tabs if overflow is activeCaolán McNamara
Change-Id: I4033fcb2c34c70eff554998752f93865ee1c9230 Reviewed-on: https://gerrit.libreoffice.org/65046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-07 02:10:49 +0000