summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-04-02tdf#146619 Remove unused #includes from C/C++ filesRafał Dobrakowski
'sc' module was cleaned. Change-Id: Ia491d741a4c1c5314f35ebb4baa82dd516948ae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165699 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-02convert TableModel to comphelper::WeakComponentImplHelperNoel Grandin
Change-Id: I548a33e93c14c40c6cd500e3306a8e4279e73f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165678 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02convert SvtRulerAccessible to comphelper::WeakComponentImplHelperNoel Grandin
Change-Id: Ibd37a38bf1fe6c2669af11b0c4eca957954f64bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165676 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02Update to latest Rhino 1.7.14Stephan Bergmann
...at the expense of losing, at least for now, the script editor for it (which had been hacked into the old upstream sources in a hard-to-maintain way). rhino-1.7.14.zip is taken from <https://github.com/mozilla/rhino/releases/download/Rhino1_7_14_Release/rhino-1.7.14.zip>. Building it would now use Gradle, but instead just hack together an invocation of javac and jar in external/rhino/ExternalProject_rhino.mk that effectively generates the same jar as the upstream-built jar available at <https://github.com/mozilla/rhino/releases/download/Rhino1_7_14_Release/rhino-1.7.14.jar>. All the various patches are no longer necessary: * external/rhino/rhino1_5R5.patch and external/rhino/OfficeScriptInfo.java were mostly for the hacked-in script editor, which has been abandoned at least for now (see above). * external/rhino/rhino1_5R5-find_swing.patch (originally from 0a7f9346503a557f583bced269655fa1996550af "ause109: #i106296# make build.xml aware of TARFILE_LOCATION") appears to be obsolete. * external/rhino/rhino1_5R5-updateToolTip.patch is covered by <https://github.com/mozilla/rhino/commit/ab20a73b16f68daf715c7ac4808c119bb15d698c> "Fix bug 414869: Rhino debugger fails to launch due to updates in mac os x leopard". * external/rhino/rhino-classpath.patch.1 from bb58293296f843654045d7b0eba6899d11533a4a "rhino: unbreak build on Fedora 34" was only relevant when building with Ant. Change-Id: I5fca5915d785716f7aaf313ff2469a20f55f707a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165190 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-02tdf#146619 Remove unused #includes from C/C++ filesRafał Dobrakowski
the 'xmlsecurity' module was cleaned Change-Id: If8fae797ed5586888022ecb09bab690d68ae7bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165593 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-02tdf#146619 Drop unused 'using namespace' in: i18npool/Gabor Kelemen
Change-Id: I3c4ca1083f8ef4053d1b4202bf9617b9373312bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165537 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-02tdf#146619 Remove unused #includes from C/C++ filesRafał Dobrakowski
the 'desktop' module was cleaned Change-Id: Ia7dcb77a42ca7f9be67e30d10cd54697bf93b6d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165663 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-02fix assert in loading forum-de3-11775.odsNoel Grandin
regression from commit a95bff116e1da140b9abe9742ceeb9a3caed43d5 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Mar 26 15:42:52 2024 +0200 convert OCellListSource to comphelper::WeakComponentImplHelper Change-Id: Ib8af6627c641c73d9e4e6aaa43d694084a2854ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165671 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02riscv64 bridge: replace some preprocessor directives to macros for debuggingSakura286
Change-Id: Ic53d4a462e12e8448b14e750c4ef2824385b8f28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165502 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-02use more concrete UNO types in sdNoel Grandin
Change-Id: Iea48c8750c940441c5687068317107a5932799e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165670 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02convert sd::Annotation to comphelper::WeakComponentImplHelperNoel Grandin
Change-Id: Icafd8d0e3cf1923fd287792cb03a5431907599e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165669 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02Related: tdf#157480 use SSL_CERT_FILE on macOS tooCaolán McNamara
for SSL use by pyuno emailmerge another alternative mechanism that could work is to generate one with something like: "security find-certificate -a -p > cert.pem" ref: https: //hynek.me/articles/apple-openssl-verification-surprises/ Change-Id: I8bff2ca5bbbb4f2c2333a67e0281dd4fa0b06405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-02Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to e36ba06ea7b75b61d93b7b9b9f50d90301010738 - update translations for master and force-fix errors using pocheck Change-Id: I65d403dd9ce3233ba067c1e76faa0b9f782fe816
2024-04-02Disable chart modification in readony view mode.Gökay Şatır
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: I271caa12eed69099d6f0acd9bdcff53efcc26972 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164970 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit dd232051d7ac43f1f15731916708a95403b78b62) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-02Conditional Formatting: Adding More Specified Dialoguescodewithvk
We have added additional single conditional dialogues to enhance the conditional formatting options for conditions such as duplicates, N elements, etc. Signed-off-by: codewithvk <vivek.javiya@collabora.com> Change-Id: I46d069f259d47739ad1bc859b19513f19d414eb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165290 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit abcb07e2baf2d59904b50e9c20f8a108ab9f17de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-02tdf#147021 Replace SAL_N_ELEMENTS with std::sizeRMZeroFour
As part of the efforts in #145538 to replace the SAL_N_ELEMENTS() macro with std::size() and std::ssize(), this commit performs the necessary changes for a few files in the filter/ module. PS-2: Replace an std::size call with sizeof, and one with std::ssize Change-Id: Icac6470cdff762f828651153d0abc5f40b8e5d7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165592 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-02svx: prefix members of XLineEndEntryMiklos Vajna
See tdf#94879 for motivation. Change-Id: I901e231f8112dea28bdccfb79b17470f1436c0db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165665 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-04-02tdf#146619 Drop unused 'using namespace' in: basic/Gabor Kelemen
Change-Id: I55bd0c89880dd97307dde5a5b670e63f3ea66355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165536 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-02tdf#146619 Drop unused 'using namespace' in: sfx2/Gabor Kelemen
Change-Id: I3748612644c9c4eb88d7fb6e2d512954de9c1002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165538 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-02simplify SotTempStream and lifetimeNoel Grandin
It is really just an SvStream instance, and the lifetime does not need reference counting Change-Id: Idb5ffd96f852aae0dc1a94cddc0a83fbcdf974ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02tdf#160399 speed up print previewNoel Grandin
shave about 2-5% off the cycles here Change-Id: I23adffa4715d3dd28a92d48603a236115fb7d680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02tdf#160399 speed up print previewNoel Grandin
takes time from 2.5s to 1s for me Store all of the PrintPageRanges in the ScPrintState save/restore data structure, means we don't recompute the data in that structure, so of which is quite expensive. Change-Id: If65c8ca1cce25ff228c483f173b19b456056dc57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02Fix UB after 8962141a12c966b2d891829925e6203bf8d51852Mike Kaganski
(tdf#160430: Fix glyph bounds calculation, and use basegfx::B2DRectangle, 2024-04-01). As reported by Stephan in https://gerrit.libreoffice.org/c/core/+/165553/6#message-fec1e45288c0e87d43c58f777ebe51b03c534d82: `CppunitTest_sw_rtfexport CPPUNIT_TEST_NAME=testMathEqarray::TestBody` now fails with vcl/source/gdi/sallayout.cxx:245:30: runtime error: inf is outside the range of representable values of type 'long' #0 in SalLayout::GetBoundRect(tools::Rectangle&) const at vcl/source/gdi/sallayout.cxx:245:30 #1 in OutputDevice::GetTextBoundRect(tools::Rectangle&, rtl::OUString const&, int, int, int, unsigned long, KernArraySpan, std::span<unsigned char const, 18446744073709551615ul>, SalLayoutGlyphs const*) const at vcl/source/outdev/text.cxx:1932:28 #2 in (anonymous namespace)::SmGetGlyphBoundRect(OutputDevice const&, rtl::OUString const&, tools::Rectangle&) at starmath/source/rect.cxx:80:32 #3 in SmRect::SmRect(OutputDevice const&, SmFormat const*, rtl::OUString const&, unsigned short) at starmath/source/rect.cxx:224:21 #4 in SmMathSymbolNode::AdaptToY(OutputDevice&, unsigned long) at starmath/source/node.cxx:2122:18 #5 in SmBraceNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:1340:17 #6 in SmBinHorNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:816:13 #7 in SmLineNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:610:20 #8 in SmTableNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:534:20 #9 in SmDocShell::ArrangeFormula() at starmath/source/document.cxx:280:13 #10 in SmDocShell::GetSize() at starmath/source/document.cxx:405:9 #11 in SmDocShell::Repaint() at starmath/source/document.cxx:566:21 #12 in SmDocShell::OnDocumentPrinterChanged(Printer*) at starmath/source/document.cxx:552:5 #13 in SmDocShell::SetText(rtl::OUString const&) at starmath/source/document.cxx:188:9 #14 in SmDocShell::readFormulaOoxml(oox::formulaimport::XmlStream&) at starmath/source/document.cxx:848:5 #15 in SmModel::readFormulaOoxml(oox::formulaimport::XmlStream&) at starmath/source/unomodel.cxx:1105:22 #16 in writerfilter::rtftok::RTFDocumentImpl::beforePopState(writerfilter::rtftok::RTFParserState&) at writerfilter/source/rtftok/rtfdocumentimpl.cxx:3010:30 #17 in writerfilter::rtftok::RTFDocumentImpl::popState() at writerfilter/source/rtftok/rtfdocumentimpl.cxx:3666:23 #18 in writerfilter::rtftok::RTFTokenizer::resolveParse() at writerfilter/source/rtftok/rtftokenizer.cxx:114:37 #19 in writerfilter::rtftok::RTFDocumentImpl::resolve(writerfilter::Stream&) at writerfilter/source/rtftok/rtfdocumentimpl.cxx:856:27 #20 in (anonymous namespace)::RtfFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/RtfFilter.cxx:163:20 #21 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sfx2/source/doc/objstor.cxx:2392:34 #22 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:760:23 #23 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1980:36 #24 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:720:28 #25 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1176:37 #26 in framework::LoadEnv::start() at framework/source/loadenv/loadenv.cxx:412:20 #27 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) at framework/source/loadenv/loadenv.cxx:308:5 #28 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:168:14 #29 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:591:16 #30 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx #31 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:71:62 #32 in UnoApiTest::loadWithParams(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at test/source/unoapi_test.cxx:126:19 #33 in UnoApiTest::load(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:108:5 #34 in SwModelTestBase::loadURL(rtl::OUString const&, char const*) at sw/qa/unit/swmodeltestbase.cxx:441:20 #35 in SwModelTestBase::loadAndReload(char const*) at sw/qa/unit/swmodeltestbase.cxx:466:5 #36 in (anonymous namespace)::testMathEqarray::TestBody() at sw/qa/extras/rtfexport/rtfexport.cxx:198:5 Change-Id: I857861f5bc51a1e43bfbf5e0c9dbce542d673ca7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165664 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-02Fix UBSan RTTI needsStephan Bergmann
...vcl_graphic_test now failed with > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_vcl_graphic_test.so > workdir/LinkTarget/CppunitTest/libtest_vcl_graphic_test.so: undefined symbol: _ZTI10ImpGraphic" Change-Id: I1d11a50ef9dbb0003f7bc66540829b43c1412a16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165653 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-02editeng: combine scaling parameters into ScalingParameters structTomaž Vajngerl
This makes dealing with scaling parameters much clearer and it improves readability. Change-Id: I327b6530ef5587972cc0075390704754a33563a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165632 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-02harfbuzz: upgrade to 8.4.0Xisco Fauli
Change-Id: Ie9b5e2fc85c3be588217a166f4230c87c3cb122e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165652 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-04-01lok preinit: don't re-synchronize extensions on each child start.Michael Meeks
We should sort out our extensions, if at all, at pre-init time. This should save ~4% of CPU in a week-long profile of a COOL server. From Desktop::Main's SynchronizeExtensionRepositories. Change-Id: I2760de26635723492dfa5a52005ee90623337bee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-01tdf#146619 Drop unused 'using namespace' in: desktop/Gabor Kelemen
Change-Id: I120471364834dfd0702b6ce15f79a8327cac26b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165534 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-01tdf#146619 Drop unused 'using namespace' in: lingucomponent/Gabor Kelemen
Change-Id: I98f6edf1da4915ff43312c187e92891371833fc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165533 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-01tdf#146619 Drop unused 'using namespace' in: linguistic/Gabor Kelemen
Change-Id: Ib4df4e592e6b485dc087eddb49f59fc24c710380 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165532 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-01libtommath: upgrade to 1.3.0Xisco Fauli
Change-Id: Ica9e2520c7c70a21721f7f389fd3cd8138bf550c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165609 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-04-01tdf#160444 check device's owner window is a nullptrPatrick Luby
Since commit 563f7077f1dbce31ff95ee8d2e8d17b629693db1, the device's owner window gets deleted before this object is deleted. Change-Id: I15dc8db60e5520c2f0e73a9a117f25af15845caf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165637 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-04-01tdf#151413: add UTF-8 data to the Link clipboard formatMike Kaganski
And introduce methods in TransferableDataHelper to handle that. Change-Id: I1d91f0f6b7e8523125f9cc1507dbd6737968f7d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165607 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-01Update git submodulesLászló Németh
* Update helpcontent2 from branch 'master' to c2349a58a8e43f44a796f8e21053f4ca6de6fb4c - tdf#106733 tdf#158885 add "Exclude from hyphenation, Compound characters... Document new and updated hyphenation options of LO 24.8: New options: – "Exclude from hyphenation" (Character->Position); – "Compound constituent characters at line end" (Paragraph->Text Flow). Updated (moved and negated) options (Paragraph->Text Flow): – "Hyphenate words in CAPS" and – "Hyphenate last word". Follow-up to core commit 3a332d9f1cacb3c6f81fcf6c08afa51d091ddff4 "tdf#158885 cui offapi sw xmloff: fix hyphenation at stem boundary", core commit 03c5a31a0f374a90fbc821718c14dc5f8a385adf "tdf#106733 sw cui: add CharNoHyphenation checkbox", core commit b5e275f47a54bd7fee39dad516a433fde5be872d "tdf#106733 sw: implement CharNoHyphenation" and core commit 73bd04a71e741788a2f2f3b26cc46ddb6a361372 "tdf#106733 xmloff: keep fo:hyphenate in character formatting". Change-Id: Ief37df057bec1ea286c7334a200fe6abcc8995d3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165565 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-04-01tdf#160436: fix glyph bounds calculation for vertical glyphsMike Kaganski
It is unclear if LogicalFontInstance::GetGlyphBoundRect can be called for both normal and rotated variants of the same glyph in the same font. If yes, then the normal and vertical variants must be cached separately, or possibly vertical variant can be not cached, but always calculated. This problem already existed before, so this change doesn't introduce a new issue. Change-Id: I9b50ef340c9e38db7bef890165519aadc96d3ffa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165581 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-01tdf#160430: Fix glyph bounds calculation, and use basegfx::B2DRectangleMike Kaganski
... instead of tools::Rectangle. Several problems were there: 1. First, a horizontal bounding rectangle was calculated, with due rounding; and then the result was rotated, and after that, rounded again. That made the resulting rotated rectangle coordinates very imprecise. 2. Also, ceil/floor was applied without normalization; and in case of rotated font, that meant, that sometimes the range could be not expanded to cover partially covered pixels, but instead collapsed. 3. The rotation to angles other than 90 degree multiples was done incorrectly, resulting in cut off parts of characters. 4. For 90 degrees, the imprecise result of sin/cos converted 0.0 into values like 3e-16, which then could be ceil'ed up to 1. Using B2DRectangle and its transform allows to simplify and fix the calculations easily, and avoids premature rounding. Render of rotated text of small size is more stable with this change. Change-Id: Idffd74b9937feb2418ab76a8d325fdaf4ff841b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165553 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-01tdf#146619 Drop unused 'using namespace' in: framework/Gabor Kelemen
Change-Id: I03d2d3d07d0d71800df624510b5e20bd5e0588e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165531 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-01tdf#146619 Drop unused 'using namespace' in: drawinglayer/Gabor Kelemen
Change-Id: I6d034b6c191885b25ad34f0d75ed870970b5fd77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165527 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-01gtk_label_set_label: assertion 'GTK_IS_LABEL (label)' failed (docking3deffects)Julien Nabet
Change-Id: I9c9cb39716ff99808db66404853252295fda6336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165601 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-04-01tdf#146619 Drop unused 'using namespace' in: accessibility/Gabor Kelemen
Change-Id: I92662f0577c0f90ec0dc5eba1b685fbb7ac3da39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165530 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-01tdf#146619 Drop unused 'using namespace' in: connectivity/Gabor Kelemen
Change-Id: Ie185575d699751b79e98c4fae0bc5405a165df9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165529 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-01tdf#146619 Drop unused 'using namespace' in: xmlscript/Gabor Kelemen
Change-Id: Ic9874b77bdbb1d30fb587c5c8bbd62e4811c71e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165528 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-01remove unused suppressionJulien Nabet
since fe4cd0cebdbf9412e26f8182e79f97bb844d94af Date: Thu Feb 22 14:09:12 2024 +0100 Set button label directly in ui file Change-Id: I53a39dffe79c5c5c4c4c8a0d95a333ba3af833bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165603 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-04-01NewDoc/AutoPilot is for Impress onlyJulien Nabet
Fix this log: warn:unotools.config:582397:582397:unotools/source/config/configitem.cxx:423: ignoring XHierarchicalNameAccess NewDoc/AutoPilot com.sun.star.container.NoSuchElementException message: "NewDoc/AutoPilot at /home/julien/lo/libreoffice/configmgr/source/access.cxx:442" context: configmgr::RootAccess Since 0e14912af0c449396f10c2ae4be3c7f2a3a98bc2 tdf#157788 Saving the "Show navigation panel" setting for a device Change-Id: I82bfdbbfcb40219b3182e07b4099067fddb09a61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165604 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-04-01vcl: get rid of NO_PENDING defineTomaž Vajngerl
Change-Id: I90c3a29da63222bba2d497a27d7deec0865a6104 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165211 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-01vcl: remove partial XPM image loadingTomaž Vajngerl
This removes the code that handles the IO_PENDING and the graphic "context" handling from XPM image format. Partial loading of images complicates the image filter life cycle a lot (many exceptions) and is not really needed so much today as this was needed in the past. In most cases we load the whole image in one pass anyway. Even loading from the network should be fast enough to not cause issues for the user. Most image filters don't even implement this like PNG and nobody noticed for many years that this is not supported. To handle IO_PENDING case it is probably better to load the bitstream into memory and then load the whole image after that in one pass. This can also be implemented all inside (Imp)Graphic in a very straight forward way. Change-Id: Icdc4f042b38936e3d9f11d7026fd8525a6f46943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165210 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-01tdf#160356 Add support for hidden named expressions in CalcRafael Lima
Since bug 154449 was fixed, Calc now supports hidden named ranges. However, named expressions were not considered in the original patch and it would be useful to support hidden named expressions as well. This patch adds suppport for hidden named expressions (import and export). Change-Id: I2580416dcd5db0fcb2aa9061085cdc9975fb03c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165239 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-01Fix abbr.Andrea Gelmini
Change-Id: Ia1f8f1527e76f2a721d42f6de11122f8c167bc96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165589 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-04-01lcms2: upgrade to 2.16Taichi Haradaguchi
* backport 0001-Added-missing-export.patch to fix the Windows build. * drop c++17.patch.1, which fixed uptream. Change-Id: Ib658ba3067c35ca5cd1ccb7b3f0f2f3bc9f82a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165350 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-03-31Fix typoAndrea Gelmini
Change-Id: I606c3eb804cba508638ac401b35a8bea4e961807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165588 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit (git 2.34.1) at 2024-12-26 23:18:18 +0000