summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-01-19oox smartart: composite algo: handle right constraint when left+width is givenMiklos Vajna
The bugdoc had this constraint: <dgm:constr type="l" for="ch" forName="text" refType="r" refFor="ch" refForName="img"/> While img has no "r", it has: <dgm:constr type="w" for="ch" forName="img" refType="w" refFor="ch" refForName="box" fact="0.2"/> <dgm:constr type="l" for="ch" forName="img" refType="h" refFor="ch" refForName="box" fact="0.1"/> Which is enough to fix the x position of the text to not overlap with img. Change-Id: I80db290bd1695884ffb7b1eabaffa09462e8883d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109642 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-19tdf#136704: sw_uiwriter2: Add unittestXisco Fauli
Change-Id: I15568e5f95a955856d4cd1c5b02b31ccf469cf2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109631 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-19ofz#29713 Direct-leakCaolán McNamara
Change-Id: I6acec28ac5ebfe5e266b8dc6ff355eb4dbd6fc6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19tdf#135377 keep the correct index selectedCaolán McNamara
Change-Id: I8737b64300e4bb3a3441c1ec43620b2acea31d2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19loplugin:unusedmethodsNoel
GtkPrintWrapper stuff is dead since commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6 drop never completed GtkSalPrinter Change-Id: Ia42e9bca020a9683ba247d466f743a0018e920f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-19tdf#124176 Use pragma once instead of include guardsprincesinghtomar
Change-Id: I44a269b5c01f044880b07aaa6d7e9ee369d98f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108506 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-01-19tdf#139368 new database dialog doesn't have focus on start-center launchCaolán McNamara
the original issue all the way back of commit 82abd23f3ee1900b7579e5a0afa23581d5836f01 tdf#93317 Modified Document Dialog misses focus on Gtk3 eventuallly solved with commit 1092cc0c75f6d2ab649dd31b1db9f0a9f0944355 Related: tdf#100337 revert x-crossplatform ToTop... is possibly all redundant in the contemporary situation. Try using gdk_x11_display_get_user_time for X where the problem arises and leave things along in the apparently working wayland case Change-Id: Ia31b88e2760574e1d580d4bff509b06c07e5f0f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109630 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19Fix unoinfo on macOSStephan Bergmann
...after 4b9190fc29aec0f005f08c0269bb9ff081f19fe3 "mac: don't put script files into Contents/MacOS or framework-bin directory" moved it from Contents/MacOS/ to Contents/Resources/ Change-Id: I90da34f73463baa516e81f6d06bd718f08e93af0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109627 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-19loplugin:colorcheck (macOS)Stephan Bergmann
as suggested by noelgrandin on IRC, "just add ColorTransparency as the first param, since that will maintain whatever the code is doing currently (whether it is actually correct is a different story)" Change-Id: I3fd7f10ffadc343f3f9a532120e2a7bbb33244d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109616 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2021-01-19Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 2bf658142b7e3c859d353e0d964aa1404fb0087e - Creates Help page for ScriptForge Timer service Change-Id: Id3d0832056edcbd828dd9eadaca4ed906088dc73 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109394 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-19add --disable-librelogo to disable LibreLogo at build timeMichael Stahl
Annoyingly the packinfo_*.txt don't support conditionals but we can work-around that with a little duplication. Change-Id: Id00a6831effcc63a917fc21d2cd201474fdb559d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109569 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-19nss: fix parallel build race in nsinstall.pyMichael Stahl
File "/home/tdf/lode/jenkins/workspace/android_aarch64/external/nss/nsinstall.py", line 112, in nsinstall os.makedirs(args[0]) File "/opt/rh/rh-python38/root/usr/lib64/python3.8/os.py", line 223, in makedirs mkdir(name, mode) FileExistsError: [Errno 17] File exists: '../../../../dist/public/dbm' ../../../coreconf/rules.mk:119: recipe for target '../../../../dist/public/dbm/d' failed Change-Id: I4273e6d3d5fa520353fff8738823ef281fe237ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109619 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-19silence "gsignal.c:2731: instance X has no handler with id Y" warningCaolán McNamara
Change-Id: Iafc0aa085338fb41758fa845252f584c2a8aea76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109620 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 451244a261d46ba918ad7e2fcfb1cdce708cfe6b - tdf#131206 clarify how to insert document fields This patch makes the change described in comment 9 and comment 11 in tdf#131206 Change-Id: Idfb2fd3f7d4f0e7ee8d22e4cb42d8cab043454c2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108339 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-19jsdialog: clear notifications when sentSzymon Kłos
Change-Id: I78b3904685b45d7c859bde07c78607671e215e98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109611 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-19Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 4473354ebc51aaba7346e1b6057737df9a220728 - add related topics and tip to Load Styles help page + add <relatedtopics> section and link to guide page for "Load Styles" + add tip about how to use "From File" to make templates Change-Id: I7e2ffcc7c57387e95ecf4d5b6f922664554e67c3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109580 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-19Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 9faffcbab37c682baf4a3826218f69b5bb6cb9ba - tdf#119753 (related: tdf#134432) update help pages for Highlight Color tdf#134432 changed the label of "Highlight Color" command to "Character Highlighting Color". This patch updates the help pages affected by that change. Also replaced some German Ids and removed some colspan/rowspan. tdf#119753 was about confusion in how to apply highlighing. Made following improvements in Apply Highlighting help page. ( shared/02/02160000.xhp ) * moved introduction into instructions, because it was repeating * changed position of <note> about changing colors. + added <h2> for How to Apply, then two <h3> for applying to a single selection or for multiple selections + add icon table for Apply Highlighting cursor + add instruction for multiple remove of highlighting * changed position of <tip> about shortcut for applying to word + add "triple-click" for sentence and "quadruple-click" for paragraph to tip about highlighting shortcut Change-Id: I1a64a4455ff35374572cc49094eff0324f032264 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109530 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-19tdf#124176 Use pragma once instead of include guards in basctlcsegura
pragma once instead of include guards in textwindowpeer.hxx Change-Id: Ie0be2626863dc6a570c2146cb86bb0f1c548e91a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108643 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-01-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 6ef16552f4f1cce36f57b5f20d182b70d8df038f - Be less conditional and more imperative in hlp text Change-Id: I45a7d8a5375e09cb0cdfb216d0154c210b0702bc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109439 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-19-Werror,-Wdeprecated-anon-enum-enum-conversionStephan Bergmann
same as f9c6a153c95c4acc6ba02e660c6ca51166b4c79a "-Werror,-Wdeprecated-anon-enum-enum-conversion" Change-Id: Ie69413a98269c215eaf2cbd938708f0d9fcf28d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109614 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-19Resolves: tdf#135617 grab focus to widget matching the line spacing stateCaolán McNamara
instead of leaving it at the first widget in the popup Change-Id: I0bc4c72f7972e339cd28cd6368a4784cdb11275f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19Related: tdf#135617 grab focus after shownCaolán McNamara
which allows the final gtk widget to be grabbed after its parent toplevel window has been shown Change-Id: I0d6229ae027073a50cc930b3affc131d7d78fc30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19tdf#139076 update Bullet icons with sexy .svg iconsandreas kainz
Change-Id: Iae8708b139a8215684486e3573cae1b3d8a02ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109532 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-01-19tdf#132846 Lines connector better layout for writerandreas kainz
Change-Id: I063eacf3f0d8b5322036eeaf845ce62b6d9d1645 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109592 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-01-19elementary: tdf#139056 update color to follow upstream brandRizal Muttaqin
Change-Id: If5946915ec3f26007220bab2143978cbeefa7b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109593 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-01-19tdf#135153 DOCX import: avoid line-of-text relation with to-para anchoringMiklos Vajna
Regression from commit 8f1a1092d47947847e1d888b0284e8364c663d1f (tdf#97371 DOCX import: fix text covered by shape, 2016-01-28), the problem was that once the import decides that a shape should have no to-char anchoring, it should not leave behind vertical relation types which make no sense for to-para anchoring. text::RelOrientation::TEXT_LINE is specific to to-char anchoring, so reset the relation back to the default text::RelOrientation::FRAME. This means we'll no longer show "from top" on the UI while the doc model contains "from bottom": and those have to be in sync, otherwise pressing "down" while the shape is selected will actually move it up. Change-Id: I660a7bb30133ea866cc4ba1620ae15fea243ef8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109570 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-19tdf#138890 : weld::LabelType::Warning font color in dark themesAnshu
Change-Id: Ia0315037b0edee921a6a24b23673ad04c7821388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108929 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-19Simplify getFirstLineBreakdante
Change-Id: I0fcacd3f3deb5867ed91a7037b74fa364ebc4c80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109302 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-19Use customized xml entities on xmleport.dante
This will be mainly used on matml export for unicode characters. It will be used mostly for mathml. Change-Id: I59b96d44facbd01fa517317a0ae54d64d29b0a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108562 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-19Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Change-Id: I8e81fd375bd819a62a543960a2368e3bf965c8c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109565 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-19Community splash screen without EditionHeiko Tietze
macOS installer shows also just Community now Change-Id: Ia71d3b3a376f8e5e2254f2863ea61f065fb2d86f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109558 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-19Resolves tdf#138051 - UI picker text blocks buttonsHeiko Tietze
All images have a height of 125px now Change-Id: I64bb9d51c7a5edb4f0cfd38ac48473f11755061d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109545 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-19"Update all" should do a full reformattingSamuel Mehrbrodt
Change-Id: I05b06e4b345c2125f4fd5272fc6a3354396a29ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109554 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-01-19Use custom HTML Mathml entities only when needed.dante
Change-Id: Id2120aec8738286d31d79638b46beac2f0e53780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-19use more GetOutputSizePixelNoel Grandin
Change-Id: I90ac482ad2a3f372998f70ee6e65e6349567cba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-19add OutputDevice::GetOutputRectPixel methodNoel Grandin
to simplify some and make an upcoming change less invasive Change-Id: I699b2be8fa35b2b72271eda4a0885f89a47b348a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109563 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-19vcl: remove "Impl" prefix for method names in ImpGraphicTomaž Vajngerl
Change-Id: I86b63815d30100395181e5a6e9d343d2b7228c13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109460 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-19vcl: remove or rename too long methods names in VectorGraphicDataTomaž Vajngerl
Change-Id: I8a64d27927b608afdc7996e0b0bbc59a58fde90f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108443 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-19vcl: remove VectorGraphicDataArray, use BinaryDataContainer insteadTomaž Vajngerl
This change removes the contructor taking VectorGraphicDataArray for constructing VectorGraphicData, and instead of this, use the BinaryDataContainer instead. This further removes duplication and copying of the binary source data for various vector graphics formats (most importantly PDF and SVG). Change-Id: I1b9abf1662e1f30965c9068d04cb0afb82b3edaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108442 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-19vcl: a way to create data for BinaryDataContainer without copyingTomaž Vajngerl
Construstor for BinaryDataContainer taking unique_ptr<sal_uInt8> represents a way how to create and fill the data for the container and make sure that the container is the only one that is managing the data after construction. Generally we don't want to give the access to the internal shared_ptr to the outside, so with the unique_ptr we make sure that there is no outside references present (which would be the case if the we would take shared_ptr as the constructor) and the unique_ptr is cleared (moved) after construction. Change-Id: I123114c8bee92e342740d94a784b2c16e2564528 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108441 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-19Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to d03a0311bc6f582ca311ea1814907b320163b72e - improve Format - Bullets and Numbering and List Style Format>Bullets and Numbering has a Numbering tab, while with List Styles, it is a Numbering Style tab. For Format>Bullets and Numbering * added <h2> with Numbering * added variable to include description * modified description to refer to "numbering" instead of "numbering style" Renamed "Numbering Styles" to "List Styles" Replaced German Ids Change-Id: Ia45c1f164e8016b4f554cab586335bcebc8d3ea3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109513 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-01-18uitest: sw: test load styles from templateXisco Fauli
Also add a new module for sidebar tests Change-Id: Iba823907f2a71d590152c17855355ed5a0a44326 Change-Id: I41a023468a90ca7d79822b6a1c78bf24ee971bc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109566 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-18tdf#139332 reduce height of expert config dialogCaolán McNamara
to about the height of help, options Change-Id: Icf2bebb2f2cc5aabea3e1f702d7095de8c31d726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-18sw: fix ASAN use-after-free in testTdf39721Michael Stahl
The problem is that the cursor is positioned somehow on an SwEndNode. Then lcl_CursorOk(pNew) is false and it gets deleted immediately. Change-Id: I1789280a5116da4e5b7739e311b18c5c54074b1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109541 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-18Revert "Try to fix Windows TB"Julien Nabet
Try to apply Stephan's suggestion in https://gerrit.libreoffice.org/c/core/+/109464: "Instead of explicitly specifying the std::min template argument, it would be better to cast the '300L' to the appropriate type. (And do not change the std::max at all, which should be working fine?) That way, if the type of Height() should ever change to a type larger than tools::Long, the std::min call wouldn't silently truncate the first argument." This reverts commit 648edf96cde392545749923dc0c748e0bb31b5f6. Change-Id: I1e3cb70750d979468556ced7e7942abcb17fca98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109544 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-18Mathml mo operator listdante
This is a preparation for further improvements on starmath. It is related with tdf#66279. Change-Id: Iae0229ccc61eeb2f7ae9ca07c457b8c30e873903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108676 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-18Revert "Revert "Move SwFntCache link from SwModify down to SwFormat""Bjoern Michaelsen
- SwFormat::SwClientNotify calls SwModfiy::SwClientNotify explicitly and used the sideeffect of cache invalidation - this is now fixed This reverts commit 2e29dc20b96f2d96f5b64e9ed5efb79e342b3f54. Change-Id: I5b3cf516cdfcdaffef7bb1eac20185ba713f33fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109478 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-01-18mac: don't put script files into Contents/MacOS or framework-bin directoryChristian Lohmaier
Signing them as executable code would require external attributes, and those in turn break packaging into hfs+ dmg when building on apfs with Big Sur. It is not a new thing - the old Code Signing in Depth technote https://developer.apple.com/library/archive/technotes/tn2206/_index.html already reads: "Store Python, Perl, shell, and other script files and other non-Mach-O executables in your app's Contents/Resources directory. While it's possible to sign such executables and store them in Contents/MacOS, this is not recommended. […] Put another way, a properly-signed app that has all of its files in the correct places will not contain any signatures stored as extended attributes." The patch does exactly that for LO and the shipped python framework and adds symlinks for the moved files. Same applies for the Language pack applescript and the tarball - those are also moved into Contents/Resources Change-Id: Iab21e77b73f941248ca89c6e80703fdf67a1057c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109537 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-18XTextDocument::refresh should do a full reformattingSamuel Mehrbrodt
Change-Id: Ia92e10e43cb8254b6dd35db03462b87d0fe93f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109538 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-01-18Related: tdf#66813 this dialog should be modalCaolán McNamara
if we truly want it to be modeless, then unset this bit and use the runAsync mechanism Change-Id: I7d1cae1975d6ac20ef34b7744981ee72b9f52c78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>