summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-12remove BigInt::operator tools::Long()Noel
which was introduced in commit adf0738d2dbfa742d0e9ef130954fb4638a8e90d Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Jan 3 14:25:15 2018 +0200 long->sal_Int32 in BigInt presumably to make the conversion easier. Instead just fix the call-sites to select a better conversion, BigInt only returns 32-bits of precision anyway. Change-Id: I2e4354bcfded01763fe3312a715ef37800297876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-12remove Fraction::operator tools::Long()Noel
which was added in commit 331e2e5ed3bf4e0b2c1fab3b7bca836170317827 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Sep 14 08:49:52 2017 +0200 long->sal_Int32 in Fraction presumably to make the change impact less code. Instead, update the call sites to reflect the actual bitwidth of the data we will be receiving. Change-Id: If2a678b1cf534f39cb8cb249757462be53658309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-12replace RES_GRF_REREAD_AND_INCACHE with sw::GrfRereadAndInCacheHintBjoern Michaelsen
Change-Id: I8b36fd0dde6f4e7f83cf73dc8b6aefb196babb8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105571 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-12Make SwClientNotifyCall protectedBjoern Michaelsen
Change-Id: I1da6cd45c5039f2b36ae6d8a64febc69eda9c6d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105569 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-11DOCX import: don't throw away cached value of SwHiddenTextField ...Miklos Vajna
... when we also have an SwUserField. The problem is that a DocVariable gets imported as an SwUserField, but then SwDocUpdateField::InsertFieldType() marks the field as dirty. This causes IsFieldsDirty() to return true, so then DocumentTimerManager::GetNextIdleJob() decides to recalc all fields. This leads to loosing the cached result of conditional fields. Change-Id: I4f5c032648f8fc2aff98e4f8c883492375c7752d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105596 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-11pdf: use a common call to parse a objectTomaž Vajngerl
Previously, only Lookup method called parsing correctly, taking into account that the object is in its own stream and has its own elements vector. Many other methods called parse with the wrong - document element vector. This changes the code so that a common method is called in all instances with the correct elements vector as the input parameter. Change-Id: I7092f7ce683f07065da15cfa548b06c019efeed4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105491 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-11-11pdf: use object stream to copy dict or array contentTomaž Vajngerl
Objects can be stored in a compressed stream inside a PDF stream, so we can't assume that we always copy from a document stream, but we need to check if we have an object stream available and use that for copying. Change-Id: I877a4d8e169919d26878cb9c98782c637479d77a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105490 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-11-11Fix 64-bit --disable-pch build on WindowsMike Kaganski
Change-Id: Ieeef0309faa77558fb30fceaed83ad97fb6e26ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105590 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11loplugin:stringview (extensions)Julien Nabet
Change-Id: If2984a0de77dcd4848f612f057b3e0a79ffef21a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105582 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-11-11tdf#138113: Base SQL syntax colouring issue with operators "/", "-"Julien Nabet
Change-Id: If268d7731642a6503418ca187b4fe85a889d1d2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105581 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-11-11Update git submodulesOlivier Hallot
* Update dictionaries from branch 'master' to d6160c5e006089c711f3fec6eb4e2ade60a4150c - Fix paths for pt_PT dict Change-Id: I388ec82040aec9ad6a6454e9cc770ba0dc1be011 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/105597 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-11-11Fix typoAndrea Gelmini
Change-Id: Ie75e42e278a32d3a4130ec65a1ed05265fbc6f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105599 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-11support getting Expander's labelCaolán McNamara
Change-Id: Ibd3fe335e645895eedb6330cfc98590ad3c31fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105578 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-11Update git submodulesJulien Nabet
* Update translations from branch 'master' to c5f9a42b10e393fe6b295117427e088ff3279187 - Typos for an_ES.po Change-Id: Idd4358fd6843cb34ec95ef726567416aeabe9598
2020-11-11Drop some unused function parametersStephan Bergmann
Change-Id: I41ad8001e78ea82bf4d893b5faaa28400ff6efcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105575 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-11loplugin:stringviewNoel
Add new methods "subView" to O(U)String to return substring views of the underlying data. Add a clang plugin to warn when replacing existing calls to copy() would be better to use subView(). Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11make sure mpAlphaVDev is drawn when drawing lines (tdf#137974)Luboš Luňák
4deadc3c78949c18bb886eb1f66caa8f3cd7a2df made OutputDevice::DrawLine() use SalGraphics::DrawPolyLine() in more cases, which revealed that the the function was bailing out after the call and not drawing also to mpAlphaVDev. Change-Id: I1145d3684835b536737311294edfc566d5eb9025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105553 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-11Resolves: tdf#34398 add tooltip to "user-defined" for table bordersSeth Chaiklin
Change-Id: Ib3f2bf32bf65753ae935e30bbc2749df08334e0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105455 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-11convert more long -> tools::LongNoel
found by grepping and changed by hand. Change-Id: I3c720859dba430fde3abc76c6c5cb58269efaf4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105512 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11lok: Add posibility to change chart fill gradientSzymon Kłos
Change-Id: I942d478cd870036710390d2c03413b6fc0454038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103619 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104808 Tested-by: Jenkins
2020-11-11Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 8539d61c5ecca6748e4734671a86783de5fdd4b2 - Resolves: tdf#130719 add "note" about loading and overwriting styles - drop existing "warning" under overwrite (because it simply repeats what the function is doing). + added sentence to overwrite explanation to mention that no warning message is given when overwriting. + Replaced "warning" with "note" that explains what styles actually get loaded. + update to <h2> Change-Id: I7a2af3627fbf53974f0e6b131660c6227a22e1f6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105361 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-11-11support changing Expander's labelCaolán McNamara
Change-Id: I9a7945f6bc1ed176dc4662571ebd876b61662e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105568 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-11DOCX: fix memory leak of cell formula exportLászló Németh
clean-up of commit cf596c43315bb96b5e7256a82256f1ccb8c9c4d0 (tdf#133163 DOCX: export formula cell). The problem was reported by Miklós Vajna. Change-Id: Ia636a6ffe8386e58e31e37c0d8afc283e6f2fc4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105558 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-11pdfium: eliminate remaining direct calls to FPDFPageObj_GetType()Miklos Vajna
And also introduce an enum class for the return type. Change-Id: I6577c7678889ac5bb8efbf0d0cfeb575aac06e27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105567 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-11tdf#124176 Use #pragma once in xmlsecurityTRaXIn
Change-Id: I1e27a17575963d084eb761f5a715f451db4bac62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105522 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-11-11Fix typosAndrea Gelmini
Change-Id: Ice850a7929c5b88ca0c4da52504aa959aacd1024 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105548 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Bjoern Kirchhoff <Bjoern.Kirchhoff@escriba.de>
2020-11-11Improved starmath colordante
Color.hxx has now documentation ( even if it is quite obvious if you know RGB standar ). Color.hxx has been reordered in more coherent order, but kept format. Some changes on Color.hxx dynamics. Color.hxx starmath colors list Now colors are managed by starmathdatabse. The path is open for simple addition of colors, there are no more infinite switches with color tokens here and there. To add a color, just put it in Color.hxx and register it in starmathdatabse.cxx. Do not forget to change array size in starmathdatabase.hxx. Now mathml supports RGB colors in #RRGGBB format ( import and export ). New colors have been added. Only the HTML Css1 are available via UI. New colors will be added. I intend to finish Css2 and dvipsnames ( latex colors ) on posterior patches. RGBA command has been unlocked for compatibility reasons. However will be displayed as RGB. Added color #RRGGBB. Improved qa color test on mathml to test RGB on mathml. TODO for someone on the UI team: - Add a color picker. - If it is a color with name: - It will add in the code "color " + starmathdatabase::Identify_Color_DVIPSNAMES( colorvalue ).pIdent +" " - If not: - It will add in the code "color " + starmathdatabase::Identify_Color_DVIPSNAMES( colorvalue ).pIdent +" "+ colorvalue.getRed() +" "+ colorvalue.getGreen() +" "+ colorvalue.getBlue() +" " - Note that those will habe eType with value TRGB or TRGBA. Change-Id: I47af37bd191b3099e8e6e08e7a5fb1a8a227bbf2 Change-Id: If971473ddcc34739439818dba9a62ca3494a4473 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11make tools::Long 64-bit on Windows platformNoel Grandin
This is only for the 64-bit windows platform. I don't see the point in messing with the 32-bit platforms, they are (a) become more and more rare (b) unlikely to even have enough available process memory to load extremely large calc spreadsheets The primary problem we are addressing here is bringing Windows-64bit up to same capability as Linux-64bit when it comes to handling very large spreadsheets, which is caused by things like tools::Rectangle using "long", which means that all the work done to make Libreoffice on 64-bit Linux capable of loading large spreadsheets is useless on Windows, where long is 32-bit. The operator<< for tools::Rectangle needs to be inside the tools namespace because of an interaction with the cppunit printing template stuff that I don't understand. SalPoint changed to use sal_Int32, since it needs to be the same definition as the Windows POINT structure. Change-Id: Iab6f1af88847b6c8d46995e8ceda3f82b6722ff7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104913 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11use fastparser in formsNoel Grandin
Change-Id: I7d09d64857e24267b4b4baddb563e28ceea92f2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11disable O(U)String::concat for internal codeNoel Grandin
in favour of the more widely used, and better optimised, operator+ Change-Id: I6a1b37e0f3d253af1f7a0892443f59b620efea63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11loplugin:xmlimport add more checksNoel Grandin
to find places where the slowparser -> fastparser conversion work is incomplete, fixing one bug in the process. Change-Id: Ifd0d801d71eee0aaf25287fbac1a4237a811e7c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105511 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11Correction to improve 'resize with cell'Regina Henschel
Error: A vertical flipped shape lost flip on loading. The error slipped in, when I have implemented the suggestions from Jan-Marek. The object is vertical flipped, to have no flip for calculating the full sized logical rectangle. Therefore the second call to method lcl_NeedsMirrorYCorrection gives wrong result 'false'. I need to remember the result of the first call. Change-Id: Ia411fe7108be9fdcbbf748ee9de9f443e55d6ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105570 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-11-11tdf#133630: sc: Add UItestXisco Fauli
Change-Id: I044a11bd5690b063bf3bb346bf0e324c1353d478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105561 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-10allow VclBuilder to set expander label attributesCaolán McNamara
Change-Id: I0b78db778d230509e6bbb59d965540a5f5d6f3de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10lock print dialog height so expanders don't expand the dialogCaolán McNamara
but instead can make use of the scrolledwindow Change-Id: I9a820e077dce8090e6c5d876874dc1babbbd6808 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105565 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10sync the vcl expander default with the gtk one to !m_bResizeTopLevelCaolán McNamara
Change-Id: Ia186514efa9e670ce2287201f16978fc1b0e9146 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105564 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10set resize-toplevel true for GtkExpandersCaolán McNamara
because that's what we currently do in practice Change-Id: Ib1154a4a7597dbabb20b1cb7b051995a72256e62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10uitest: chartArea.py: assert changes in chartXisco Fauli
Change-Id: I8825bed89c50dcb0a9858d04a1697cb12fdd81bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105556 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-10GtkExpander, like GtkCalendar needs to not let click through to vclCaolán McNamara
Change-Id: Ieccc019b423aa9271ce45a002672893c38f1986b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105562 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10Let's assume that sal_uInt16 is unlikely to be less than zeroMike Kaganski
Change-Id: I3e93d111bf22e54771ad4f2c7498a49d477dd3d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105533 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-10external/gpgmepp: Adapt to _AC_UNDECLARED_WARNING in autoconf 2.70betaStephan Bergmann
see the linked <https://lists.gnu.org/archive/html/autoconf/2020-11/msg00004.html> "Fallout from _AC_UNDECLARED_WARNING in autoconf 2.70beta" for details Change-Id: I02c0f41d8f9e2ec7f833423a55ccbfff19e5ceb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105555 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-10Remove obsolete AC_HEADER_STDC checkStephan Bergmann
Autoconf 2.70 beta autoupdate says: > configure.ac:6540: warning: The preprocessor macro `STDC_HEADERS' is obsolete. > Except in unusual embedded environments, you can safely include all > ISO C90 headers unconditionally. Change-Id: I3d7e96ccd1683f51d47250c013cb0b6ea11d70ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105554 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-10uitest: remove useless commentsXisco Fauli
Change-Id: I9990be302a2d28e6e46f8bb33cda605ba15533f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105552 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-10Improve some warning wordingStephan Bergmann
Change-Id: I37236b1bab66baf428d98f6ec644be704d7913c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105550 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-10Reinstate o3tl/cppunittraitshelper.hxx use for C++20Stephan Bergmann
...introduced with 5d8f0fad50f90195a11873c70ddab4644f5839ea "Adapt CPPUNIT_ASSERT to C++20 deleted ostream << for sal_Unicode (aka char16_t)" (see there for details) but erroneously removed with 877f40ac3f2add2b6dc37bae280d4d98dd102286 "tdf#42949 Fix new IWYU warnings in directories [h-r]*" Change-Id: Id22a4c0fdfe1471e2455ec3316f2c6c93cc00b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105549 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-10new loplugin:reducevarscopeNoel Grandin
Change-Id: Iefe922c2e0d605114d54673d63eccc5e4abd545d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102143 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-10remove pimpl from SvXMLAttributeListNoel Grandin
and add some asserts to catch bad index params Change-Id: I3551358282da2218a5a1a39eed63f8d358a6a118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-10This converts to/from mm100s, not twipsMike Kaganski
Change-Id: Ie13e38c78b5e9a65b0dc572628f4fcc93b2c2a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105530 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-10tdf#83958: sw: enable Track Changes toolbar automaticallyLászló Németh
Switch on the disabled Tracked Changes toolbar if the document hasn't modified, yet (i.e. on load), only if recording of changes is enabled or the document contains tracked changes. Note: the toolbar stays there, but there is no need for it to manage changes only with the menus Edit/View, keyboard shortcuts or the experimental sidebar, so it may worth to add a View option for this behaviour. Change-Id: Ia46b552b3669e147cdcbf0cc0be164883e9fb2cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105519 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-10mariadb-connector-c: fix makefile for GNU make 3.82Michael Stahl
Old make thinks that ; terminates the recipe, have to escape it. (other changes are just cosmetic) (regression from 8c9b8c5970a08c2ef0ccddb7a691f3731d39175a) Change-Id: Ib0119511977bbff077f037fbb5975df9f860ae58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105516 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
generated by cgit (git 2.34.1) at 2025-02-07 02:25:20 +0000