summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-06-22configure: Improve help-options handlingJan-Marek Glogowski
This patch includes: * A README.help.md as a general documentation for the different help types, the LO code and help-related build options. * Adds --disable-xmlhelp for removing the xmlhelp support from the build. Disable for iOS, Android and Emscripten. This was partly included in HAVE_FEATURE_DESKTOP before. * Rename WITH_HELP define to WITH_HELPPACKS, which reflects the actual usage AFAIK. * Depend --with-omindex on --with-help=online and don't override the --with-help setting. Error out on conflicting options. * Depend --with-helppack-integration on build help variants, which actually result in help packs. Kind of reverts commit 2c38ea6d16b910294220cefaf8ae6a0683e6405a ("Building without --with-help is not supposed to disable help functionality"). Change-Id: Ie4cb73905b3ed94e991d9f1bd75cfbd6de9da385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116222 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-22fix indentCaolán McNamara
Change-Id: I0a7e43906522462c6bbf9aaec89d296e5017a3a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 3c0fb9a710915c30adf5287a734a185696fa0b76 - Add note about Python support availability on some SF services Change-Id: I226b0b92fcc2b380fa6687cba87276b485009151 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117567 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-22configure: make OpenLDAP test independent from X11Jan-Marek Glogowski
I missed that PostgreSQL can be build on MacOSX with OpenLDAP support. Stephan had an incremental build failure because of it. But instead of opting-in using test_openldap=yes on MacOSX, like on Haiku, this drops the using_x11 dependency and defaults to "yes", like it was before. This was more of a convenience then reality anyway, and it makes really not much sense to disable OpenLDAP in case of --without-x. Change-Id: I959a3b30f1c369264174302f18267a4eb40a3a52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117046 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-22Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to 26fad1c72fdc6a72b455c44e57b5738ee6d1a61d - Provide a correct example within the help for Calc's FINDB function. Change-Id: Ibff7dd5bf47f26c431b1ce49e6ac5250f6192176 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117569 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-22crashtesting: assert on export of tdf105134-1.docx to odtCaolán McNamara
when interactively saving on creating preview for recently used Change-Id: I9d859cf404c34659653a14f8c2a94f867c704b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117616 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22svp: always release SolarMutex on yieldJan-Marek Glogowski
Always give other threads a chance to acquire the SolarMutex, if we yield. Change-Id: I77d93374ea606acd1f7820755197a27655418639 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117454 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-22cid#1486261 Dereference before null checkCaolán McNamara
since... commit 2e6e87decdb87221a7b832958e03195b1d8fc133 Date: Mon Jun 21 13:18:00 2021 +0200 replace dynamic_cast<SwLayoutFrame> with cheaper check Change-Id: I4623e3eca5a82fa37f52697c189310a835fc76e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22cid#1486260 Uncaught exceptionCaolán McNamara
Change-Id: I12613ed381e961fd36348eabd543b11a1960337d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117613 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22cid#1486241 'Constant' variable guards dead codeCaolán McNamara
Change-Id: Ia90e8ad537fccdf38ed0bf0e9f963033c69ec202 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22tdf#142932: fix crash when pasting cells with comments+"skip empty cells"Julien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173011 4 0x00007fc4b0cdbb3d in ScColContainer::operator[](unsigned long) (this=0x872e1e0, nIndex=64) at sc/inc/colcontainer.hxx:43 5 0x00007fc4b120d82b in ScTable::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScTable const&, sc::ColumnSpanSet&) (this=0x872e1e0, rCxt=..., rClipTab=..., rBroadcastSpans=...) at sc/source/core/data/table7.cxx:118 6 0x00007fc4b0e42939 in ScDocument::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScMarkData const&, sc::ColumnSpanSet&) (this=0x3bffa60, rCxt=..., rMark=..., rBroadcastSpans=...) at sc/source/core/data/document10.cxx:75 7 0x00007fc4b0e0b67b in ScDocument::CopyFromClip(ScRange const&, ScMarkData const&, InsertDeleteFlags, ScDocument*, ScDocument*, bool, bool, bool, bool, ScRangeList const*) (this=0x3bffa60, rDestRange=..., rMark=..., nInsFlag=7, pRefUndoDoc=0x0, pClipDoc=0x7d3bb40, bResetCut=true, bAsLink=false, bIncludeFiltered=false, bSkipAttrForEmpty=true, pDestRanges=0x7fff4a3da4b0) at sc/source/core/data/document.cxx:2916 8 0x00007fc4b2412dc3 in ScViewFunc::PasteFromClip(InsertDeleteFlags, ScDocument*, ScPasteFunc, bool, bool, bool, InsCellCmd, InsertDeleteFlags, bool) (this= 0x41a29e0, nFlags=7, pClipDoc=0x7d3bb40, nFunction=ScPasteFunc::NONE, bSkipEmpty=true, bTranspose=false, bAsLink=false, eMoveMode=INS_NONE, nUndoExtraFlags=InsertDeleteFlags::NONE, bAllowDialogs=true) at sc/source/ui/view/viewfun3.cxx:1312 Change-Id: Ic119cb5d414a35a9ba18b0564d7adf83154eb9d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-22no need to make copies of these map entriesNoel Grandin
Change-Id: Ie65cbacd2806a2c030b682f8cfd473676c4f95c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117605 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-22Adapt compilerplugins to llvm::sys::fs::OF_None renameStephan Bergmann
...from F_None, which happened with <https://github.com/llvm/llvm-project/commit/1f67a3cba9b09636c56e2109d8a35ae96dc15782> "[FileSystem] Split up the OpenFlags enumeration" towards LLVM 7, originally leaving the alternative F_None spelling in for compatibility, but which was finally removed now with <https://github.com/llvm/llvm-project/commit/3302af9d4c39642bebe64dd60a3aa162fefc44b2> "Support: Remove F_{None,Text,Append} compatibility synonyms, NFC". Change-Id: Iea1192b5ee351c13ea5d6701887f3aba62133c20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117609 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-22simplify and improve WildcardNoel Grandin
it is faster to just process OUString data, rather than perform expensive conversion to OString and back again. Change-Id: Ie007b872ee507ac5c6e8b55cc0a49ef3ac1f0139 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21gtk4: some initial dnd effortCaolán McNamara
Change-Id: I964afbf30c75b6d8e0c31ce7fcb536814acf05b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21gtk4: reenable some more working dialogsCaolán McNamara
Change-Id: I373b9260287b229f4f3092b4c27199c2a55ea23d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21gtk4: GtkPicture triggers some sort of unexplained vertical expandCaolán McNamara
an intermediate horizontal GtkBox works to stop the propogation Change-Id: I9fd51c3968c463c7b872b7a12bc3960602d0b025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21loplugin:finalclasses in sc/.../filter/incNoel Grandin
Change-Id: Ibaaff4cf3c7a60714f73c7f1b40a5e857060f26c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21loplugin:finalclasses in sc/incNoel Grandin
Change-Id: I818a5dda788fd15a718914fb05f23e5225dce1c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21create SfxHintId::SwLegacyModify idNoel Grandin
to avoid expensive dynamic_casts in writer Change-Id: Ic73ae7d4af985043f8533913b33939e3445ec7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 23b0b440515592c9b9ed2fe8e64783ea55375375 - tdf#140446 VBA constants for variable type see /core/oovbaapi/ooo/vba/VbVarType.idl and comment#3 in tdf#140446 Change-Id: Ib2a9743cfb1b636d1c016c8707872c291ef685f6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117598 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-21Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to ff452e27c1c7f420d8a0cf8a9d82d1d318225d46 - ScriptForge method signatures Change-Id: I5c29d5c08a8c5bd46ca45dc1d17449a0ae4789b8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116910 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-06-21related tdf#81705 doc export: eliminate duplicating OutlineNumberingJustin Luth
It just looks redundant. And all three formats handle it very different. RTF - never writes RES_PARATR_OUTLINELEVEL or RES_PARATR_NUMRULE in styles, only via this OutlineNumbering. DOCX does nothing. That's because there always seems to be a RES_PARATR_OUTLINELEVEL and RES_PARATR_NUMRULE. DOC does BOTH. It writes RES_PARATR_NUMRULE (and now also writes RES_PARATR_OUTLINELEVEL) and also writes them via OutlineNumbering. So OutlineNumbering seems to always have been partially redundant and now is fully redundant. Thus it can be treated like DOCX. Change-Id: Ib9fd32c440e0151b462d6499a60952f120887082 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113452 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-21replace dynamic_cast<SwCellFrame> with cheaper checkNoel Grandin
Change-Id: I672be703fb097c71303434127d832681843607e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117580 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21tdf#135316 remove OTempFileService pessimisationNoel Grandin
Closing the temp file when we read to the end, and then opening it again later actually is quite expensive, just leave it open. This takes my load time from 22s to 19s Also clean up the unit-test that failed, so that I can get a useful stack trace out of it when something fails, specifically (*) throw an exception when something goes wrong, instead of just writing a message to stdout (*) don't catch exceptions and write useless messages - just let the exception flow up to the JUnit handler, which will log a nice stacktrace with line numbers. Change-Id: If55c997f91eea4e703e92c632961d68b3453076d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21Delete copy ctors/assignments for DLLEXPORT classMike Kaganski
Their default definitions may create/destroy temporary OutputDevice objects, which requires that the class is defined at the site of instantiation of the implicit definition. The solution is to delete these unused methods. If they would happen to be needed, then move the default definitions to the correct place. This reverts commit 30a17b05fb8a860c1e53cb7cfc405b1cea0a9d15. Change-Id: I43f4e76763ff4409e9527f44cd2d8e227982257c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117574 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-21sw: add BIRT layout test documentMichael Stahl
This nested table is an example that was broken by commit 91b2239783dc716bd71ce7962bfd7e341dfe4175 - if loaded with a wide window, it goes into layout loop; if loaded with a tall window size where page 2 is visible, strangely it doesn't loop. Change-Id: I5e73cfcd928ff1a321667c1a75b0ba7f348d4b77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117587 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-21use FileDialogHelper to set file picker parentCaolán McNamara
Change-Id: I970b34fd3da12a1051343bdc26afad411121e672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21use FileDialogHelper to set file picker parentCaolán McNamara
Change-Id: Ibca7a7d275773b816d125c38f87e902de7a5db4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21give folderpicker an optional parentCaolán McNamara
so, like a file picker, it can make its parent modal while its operating. Otherwise its possible to interact with the parent dialog in undesirable ways, e.g. file, export as, export as epub, the folder picker of 'media directory' Change-Id: Ib61f8e630e176b6d81e80798fd0d282d16e8c086 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21bundle the FolderPicker instantiations behind a single callCaolán McNamara
in prep to add parent support Change-Id: I2aa4b9343f895ae866f600dd3260b7fdc4e1efec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21replace dynamic_cast<SwFlyFreeFrame> with cheaper checkNoel Grandin
Change-Id: Ia84984e47c60eb8407bbddaf9e3365d9f7f52311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117581 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21replace dynamic_cast<SwLayoutFrame> with cheaper checkNoel Grandin
Change-Id: I2102d27fe2b38e3787e39a2b7234991a57c30d99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117578 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21remove some unnecessary OUString::internNoel Grandin
Change-Id: Ia0f41dfc8a00c115ad544b8236d751e6b2dae5ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117577 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21gtk4: set file dialog explicitly modalCaolán McNamara
Change-Id: I88427abcde6c88b08c013a2502c0c25a84b970c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21tdf#116501 sw: layout: check for flys in SwTabFrame::ShouldBwdMoved()Michael Stahl
On loading, this hits loop control warn:legacy.osl:580715:580715:sw/source/core/layout/layact.cxx:543: LoopControl_1 in SwLayAction::InternalAction This is because there's a fly frame 404 anchored at the last text frame 353 on page 2 inside the nested table 347. ShouldBwdMoved() sees that there is space on the bottom of page 2 and hence the follow flow row joined, but then it immediately splits again in the same way as before due to the fly with WrapTextMode_NONE. But then the outer table's cell 273 (upper of 347) is invalidated again, hence the loop. Try to check for overlapping flys in SwTabFrame::ShouldBwdMoved() by reusing CalcFlyOffsets(), which is ... not quite ideal, but perhaps better than copy-pasting half of it to a new function. This should have less side effects than the previous fix, but a problem remains that clicking on the shape on bottom of page 2 causes the layout to go wonky, but that was also the case with previous fix. Note there's a check of SwLayouter::DoesRowContainMovedFwdFrame() there already, but that doesn't help because it will only detect when the fly itself was moved forward, but in this case the fly remains on the page. Also likely it wouldn't be a good idea to move a text frame forward if the only thing of it that fits on a page is an anchored fly (i.e. its follow has mnOffset=0) because that can be intentional. Change-Id: I0376f7dcb784c006990336233c97f5093aaccb77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117473 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-21Revert "tdf#116501 fix freezing at embedded text tables"Michael Stahl
This reverts commit 91b2239783dc716bd71ce7962bfd7e341dfe4175. This breaks documents that have many nested tables. For example Eclipse BIRT generates reports with tables nested 8 levels deep, they run into the counter in no time and, ironically, one goes into a layout loop because of this counter. Change-Id: I7451d01787903bbc60b305da3dc72f8259175e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117472 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-21tdf#135316 add small cache to rtl_bootstrap_args_openNoel Grandin
Filesystem access is quite expensive on Windows, so add a small cache for the filepath/name normalisation. This takes my load time from 19s to 18s Change-Id: I4410d066b8a4d2fd2eb746a5dd8f4ee763a8aa3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21tdf#142590 PPTX import: fix custom slide show use as defaultTibor Nagy
If the PPTX file contains a custom slideshow, which set by default and opening in Impress, this setting wasn't imported. See also commit 312334f8488a668e9b5302959b60292ce151e4fc "tdf#47365 PPTX export: support loop attribute" and commit a4b66458a7b8da2f5580014813e5dabe3fa670b6 "tdf#125071 PPTX: fix missing custom slide show export". Change-Id: I9c2b3773f6883ee795f119df5b8534fcdfa6618f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117172 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-21cid#1486007 establish that SwFootnoteFrame::Paste doesn't delete itselfCaolán McNamara
Change-Id: Ifbc1fc73be6824917dfe91811ecb5b58409f042e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117551 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21cid#1486243 'Constant' variable guards dead codeCaolán McNamara
Change-Id: I1bc2a7555f6d129526cabbebb8b88190e3ec3a4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21cid#1486241 'Constant' variable guards dead codeCaolán McNamara
Change-Id: Iec41990bbf076c0f8aaeda36ac56d3ac7ebc81d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117544 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21remove now unnecessary commentNoel Grandin
Change-Id: I0297f299c42a5ce5485cdcdebfbd1597969c907c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21tdf#142560 handle cached glpyh items in ImplGlyphFallbackLayoutMark Hung
Fallback layout beyond level1 isn't generated because pre-caculated glyph items does not contain glyph items that needs to fallback, i.e. when calling ImplLayoutArgs::PrepareFallback. Hence it produce no maFallbackRuns and maRuns. The patch changes ImplLayoutArgs::PrepareFallback so that it use pre-caculated glyph items in the next level to create maRuns to ensure the same fallback layouts are genrated as layouts generated without pre-caculated glyph items. Change-Id: I672f3be6c4915892792b3cb968ad4a325465ccc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117105 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-06-21tdf#137000: clean-up "XML shape export: fix upright"Szabolcs Toth
See commit ff5ca4e5fc6a9fb24b0eb6eb629210b024473f67 "tdf#137000 XLSX shape export: fix upright". Change-Id: Ie050da66f1eef4fc325b2acfd0a97d299c268153 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117135 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-21make SvFileStream::FlushData __actually__ flush to diskNoel Grandin
which I noticed while debugging another change where I need the flush to actually do something useful. Change-Id: I61621cbfe68a404c7fae851760154b398997fe61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117548 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21tdf#142607 XLSX export: keep formatted dates in standard filterBalazs Varga
Do not convert the formatted string filter criteria values to 'double' if they are numbers (dates). Also export the equal relation criteria into XML_filters tag instead of XML_customFilters. Previously the formatted dates replaced with numbers in standard filter criteria, first during the export, and after the import, in the standard filter dialog window. Note: fix and optimize also filtering by formatted dates by allowing CanOptimizeQueryStringToNumber() to create double values for them. This unifies the same dates with different date formatting. Follow-up to commit 1f755525189884e4b2824889a6b9dea8933402db "tdf#142402 sc UI: store formatted values in standard filter". Change-Id: If4c22e8b0142720ccfda038f89367061058693aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116566 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-21merge SwList and SwListImpl (tdf#135316 related)Noel Grandin
to reduce allocations when loading large documents Change-Id: I734aec4b22844e999d19f649e8e9cd5949a7cbfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21uitest: guard execute_blocking_actionXisco Fauli
so even if an assert fails, the dialog is closed afterwards for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I9a3adb52546238d960eeaaaf03b6bdbbd5718cf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117392 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-21tdf#142716 Update selection after any text is inserted.Gülşah Köse
When we don't update the selection after insertion of new text SvxUnoTextBase::createEnumeration knows old selection and losts last part of the text. Change-Id: I20f6530f34097ff213ff00cff617139887fd287a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117409 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-16 10:56:41 +0000