summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2025-01-22tdf#163228 Enable vertical text options for Mongolian scriptJonathan Clark
Previously, vertical text direction options were enabled if and only if CJK language support is enabled. This change extends the logic to also enable vertical text direction options if the CTL language is set to Mongolian Mongolian. Change-Id: I4e3738b4dea755c26c786cc233aff8786146e90b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180604 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2025-01-22tdf#153109 Use any_of to check for match in gciterator.cxxSimon Chenery
Change-Id: Ieadc725272dbab7a4e5e04abb4682879051e6d16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180247 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-01-22tdf#150880: Add support for WRAPROWS functionXisco Fauli
Change-Id: I44341835403c068a61cfb79185aeabe6daf32f70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180598 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-22vcl: don't initialize variable and then immediately clobber it in for loopChristopher Sherlock
As pointed out by Mike Kaganski in https://gerrit.libreoffice.org/c/core/+/177805 we are setting the loop counter to 0 and then immediately reinitializing it to 1 in the for loop. As this is not necessary, just declaring the variable initially without initializing it. Change-Id: Ia91cd6c46a62786dc14c459f1b44daecd758ec90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180567 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 52a90697abc6127f1c9210002cd42280025fa9f4 - Update and fix xapian search in online help pages + Adjust div's in grid after changes in default.css + Removed language dropdown + Add link to bookshelf on bottom + Removed index based on bookmarks-value + Removed scripts and css not used (prism, index-related) Change-Id: Ic1ebcfb35650ecb8a5beec81eec7ce31fa5a9d1d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180599 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2025-01-22Drop unused 'using namespace'Mike Kaganski
Change-Id: Ieae92ec95fee8d506fde9b21ac6551e83bd2750c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180594 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-22docthemes: Load document themes def. files into ColorSetsTomaž Vajngerl
This is then used in Theme dialog to show which themes are available. Also add the existing hardcoded themes as theme def. files. Change-Id: I230bc84ae70f22b558aa31053339d602d04885bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180541 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-22tdf#160196 add /AF entry to catalog, enable assoc. files in PDF/A-3Tomaž Vajngerl
PDF 2.0 introduced "associated files" entry. Add the association for the attached files to the /Catalog (/AF entry) and make sure the /AFRelationship is set to /Source. Also enable this for PDF/A-3 (where this was apparently added), as this is required. Change-Id: I5d0048daeb6e78534cef8ceb467f6dd2627a53ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180566 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-01-22QuickLook Preview/Thumbnail need to have the hardened runtime enabledChristian Lohmaier
otherwise the packages fail Apple's notarization Change-Id: I39877bb2b79d3e53103c44980730aaeaef8b9647 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180589 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-01-22cool#10630 lok doc sign: reduce the default size of the signature lineMiklos Vajna
This is obviously somewhat subjective, but the default shape size in officecfg/registry/schema/org/openoffice/Office/Impress.xcs, DefaultObjectSize is 8x5cm, and I find myself always reduring the inserted signature line when I test it on a few sample PDF files where others left some space for a signature. Improve this by going with the half of the default in case of signature lines, so people typically need to only move the inserted shape, not resize it. The need to only move it is especially helpful as our resize would not keep aspect ratio by default and only few users will know they need to hold ctrl-shift while resizing to do proportional resize. Change-Id: Ieaad56601be8277b39a5403e3c3f2e6ed1fd1c97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180587 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-22language-subtag-registry: upgrade to 2025-01-21Xisco Fauli
How the file was created: mkdir data cd data wget https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry cd .. tar cvjf language-subtag-registry-2025-01-21.tar.bz2 data/language-subtag-registry Change-Id: Ia1da48d2e0705413c47368263d57b4df04992991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180578 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-22Drop unneeded additional checkMike Kaganski
The two inner blocks inside the outer 'bWidth || bHeight' condition check the same bWidth and bHeight, so will execute exactly the same way without that outer check. Change-Id: If6b4c94ab47f2495c0a69473907c541ac9ffe524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180581 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-22Introduce ScConditionalFormatList::Clone and use it to simplifyMike Kaganski
Potentialy could also return a unique_ptr, would need to change the methods where the result is passed. Change-Id: I9cbd876e446094b93e2d6f72b16aefe58327e7d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180572 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-22tdf#164785: make sure to not modify CF list in undo/redoMike Kaganski
Commit 21830c58f27977ca4a1dbacd2f41583c9f3ae775 added a call to CopyToDocument to CF undo/redo. But that could modify the CF list (calling its DeleteArea method, and tab's CopyConditionalFormat). This change prevents that by using document's AddCondFormatData instead of CopyToDocument. Change-Id: Ic59a6724b5cc70ef16ec1ef3b3e2674cb3cc83f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180570 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-22tdf#150881: Add support for WRAPCOLS functionXisco Fauli
Change-Id: Ie152a83dcb7bf16f7a92ab55fd801270658a2e9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180365 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-22a11y: Update links to IA2 text/obj attr specMichael Weghorn
These are maintained in the IAccessible2 git repo instead of the LinuxFoundation wiki now, see https://github.com/LinuxA11y/IAccessible2/issues/24 . Change-Id: I39213a61ed3d0c4f24ffda98ebbd004c0479bffd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180575 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-22tdf#164795 a11y: Report first line indent via IAccessible2Michael Weghorn
Translate the UNO "ParaFirstLineIndent" attribute to the corresponding IAccessible "text-indent" object attribute that is mentioned in the IAccessible2 object attributes spec [1] which references the CSS spec [2] that says: > This property specifies the indentation of the first line > of text in a block container. Use a value in millimetres as the IAccessible2 object attr spec [1] says: > This value should be specified in mm, e.g. 4mm. With this in place, querying object attributes of the Writer paragraph that has a first line indent of 1 cm in attachment 198672 from tdf#164795 now gives this in NVDA's Python console: >>> focus.IAccessibleObject.attributes 'text-align:left;text-indent:10mm;' (Reporting of "text-align:left;" was already implemented before, "text-indent:10mm;" is newly implemented by this commit.) In order for NVDA to actually speak the first line indent when requesting announcement for text attributes (via NVDA+F), handling of the "text-indent" attribute will have to be implemented in NVDA as well. [1] https://github.com/LinuxA11y/IAccessible2/blob/master/spec/objectattributes.md [2] https://www.w3.org/TR/CSS2/text.html#propdef-text-indent Change-Id: Id6db1ec832a21f63b6e2d7e99386ddc2453ed24f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180574 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-22More flexible query dialogHeiko Tietze
Modifies and reverts a52bc9b5d6f86b6919931db21d83834d6c14e955 and 8b84691d5e2c02429c53fe9a8dc2f20e39a9d35c Prerequiste for tdf#164586 Change-Id: If35a94ce25c634a6d583aeb8188d2f9ed75bc0fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180547 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-22Also use Any <<= ColorStephan Bergmann
...following up on b3d5a3d7a79715464cc221f5b0e5489b3c2b250e "tdf#75280: Convert sal_uIntPtr use to operator >>= Color." Change-Id: Ib1a4c311e083ce900ce527477fec355f62503571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180573 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2025-01-22fix GDI and Quartz backendsNoel Grandin
regression from commit 828a0dcdf6fd1600baaf3103583633006a90d9f9 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Jan 16 08:23:19 2025 +0200 ScanlineDirection is unnecessary Change-Id: I5bc9dc8fc1ad74fb75a2656a97f5c994e9be5bc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-22LOK: added .uno:UndoCount and .uno:RedoCountAttila Szűcs
Added new commands for doc_getCommandValues to get actual undo and redo count. They get undo/redo count directly from SfxUndoManager. Change-Id: I2f7b7fc487eada7c5b1b161dfd4086c54094d747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180553 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-22tdf#160196 add support for PDF/UA-2 and NS for struct. elem.Tomaž Vajngerl
This adds support for PDF/UA-2 which is used when using PDF 2.0 (and PDF/UA-1 when using PDF 1.x). PDF/UA-2 requires that the PDF 2.0 introduced namespaces are set for the structure elements, so this also adds support for the namespaces with always setting the PDF 2.0 namespace for all the structured elements (we don't use others anyway). Change-Id: Ifbd8f8126d9bcc0d4dcd06a5f56bacdb0804adbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180565 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-01-22add loading libmswordlo.so to lok_preload_hookCaolán McNamara
similar to libscfiltlo.so in calc's lok_preload_hook so the module is loaded before any chroot might leave the original libs unavailable to find. Change-Id: I94e88dcd488ba15dc7781078796930e10f32b45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-22tdf#75280: Convert sal_uIntPtr use to operator >>= Color.Marc Mondesir
Replace casts to sal_uIntPtr, then to other types with operator >>= Color. Change-Id: Ib30370da83f3f653f8c5816e4d88cc5381ae648b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177303 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-01-22extend XmlWalker testTomaž Vajngerl
Change-Id: Id46605dac8e9033a776e84e6533768ebcf339bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180551 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-01-22tdf#130857 qt weld: Support ScrolledWindow page sizeMichael Weghorn
IIUC, the "page size" (other than the "page increment") refers to the size of the widget shown in the scroll area. Therefore, get/set the width/height of the QScrollArea's widget when getting/setting the page size. As the QScrollArea::widgetResizable doc [1] says: > Regardless of this property, you can programmatically resize the > widget using widget()->resize(), and the scroll area will automatically > adjust itself to the new size. [1] https://doc.qt.io/qt-6/qscrollarea.html#widgetResizable-prop Change-Id: Ibe90c0228bdc3a2c1ba311a9c9c88fa83d1389b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180564 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-22tdf#130857 qt weld: Support custom MenuButton popoverMichael Weghorn
Like GtkMenuButton [1], weld::MenuButton doesn't only support showing a menu, but also a custom popover/widget. This widget can be set via weld::MenuButton::set_popover. Implement that for QtInstanceMenuButton and adjust the logic to use either that popover (if set) or a menu set for the underlying QToolButton. Manually trigger either showing the popover or the menu in a slot connected to the QToolButton::clicked signal. One dialog using menu buttons with custom popovers is the one that can be triggered in Writer via "Format" -> "Theme", then clicking the "Add" button in that dialog. (That dialog isn't supported by QtInstanceBuilder yet, however, just seen that while experimenting.) Change-Id: I9a5924a5ed8c5b8b39050849fe609188559c479c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180561 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-22tdf#164785: restore saving/reapplying of CF keys in cellsMike Kaganski
Commit c492de66a077f3a2a960209b0b8b278b3901f361 (tdf#160149: save and restore the whole set of tab's conditional formats, 2024-03-17) had replaced copying of the affected cell ranges (including respective CF) with copying of the whole CF list. That allowed to replace the list as a whole, and be sure that it is in the same state as before the undone operation (not merged in any way because of re-application of CF). But the previous code made sure to set the CF keys in affected cells. New code didn't do that, and so, the changes to the cell attributes with CF keys were not cleared on undo. Applying new CF to another cell range created the same key that was already referenced in those old cells, so they behaved as if they belong to the new CF range. This change keeps the "save/restore whole CF list" idea, so tdf#160149 is kept fixed. But additionally, it restores saving/reapplying of cell attributes (but not other data) in the areas affected by CF. Change-Id: I4ff844ca1345322e231df605fb019b9613a6b123 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180555 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-21tdf#162786, tdf#161947: Add support for setuptools and pipXisco Fauli
For that, just unzip the wheel files to the Lib directory Change-Id: I3998e427aeadb840b626ebbb6ce91938de47d2b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180271 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-01-21tdf#163227 Add Mongolian {mn-Mong-MN} locale dataJonathan Clark
Adds provisional locale for Mongolian script, derived from mn-Cyrl-MN. This locale data will likely need refinement. In particular, traditional Mongolian date formats are not implemented due to insufficient data. Change-Id: I56a9e4cac1b26b4588c5a7327c56991ec91f033d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180552 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2025-01-21tdf#164403 CairoSDPR: Solve Cairo's 24.8 coordinate problemArmin Le Grand (Collabora)
Thus Cairo is offering a full-fledged double precision API but internally uses a 24.8 fixed-float format (see https://gitlab. freedesktop.org/cairo/cairo/-/issues/252, thanks Caolan for finding that). This seems to be the case for linux and windows implementations. Due to the API being on double precision this is an implementation detail, but it has to be taken into account when using cairo. It is not officially documented what is a shame - it should be somewhere in the readmes/ documentation at a prominent place. 24.8 means coordinates are limited to +/- 2^23 (usually minus one) and [0/256 .. 255/256] places after comma. This is unfortunately not limited to the view coordinates - that would be acceptable, discrete/pixel areas of that size should be fine, BUT used with transformations. Thus when having any coordinates beyond that limit - and with double precision and transformations we have that here - cairo just 'cuts' the coordinates to it's min/max 24.8 format. This is not acceptable for e.g. a cad system, and even leads to problems in something like an office suite as we see. It implies that using cairo in a safe way means to basically use linear algebra yourself in your app and use cairo only without transformations and with discrete view coordinates (pixels). AND to know about that limitation in the 1st place ... Well, cairo works well and that problem happens until now in one place in writer below page 490. Let's be pragmatic. Key is to *detect* the situation. Always doing own transformations is possible, but not nice: I *could* always transform the polygon to screen coordinates, but that will kill the PolyPolygon buffering mechanism (in chart we have PolyPolygons with 80.000 entries :-); These are held in cairo_path_t form at the original PolyPolygon to not need to transform them every time, but let Cairo do that. The idea is that when Cairo impl may use HW on the system to do that (HW can do that nowadays) while rendering the PolyPolygon from the object model would have to be converted just once to Cairo form and used multiple times... Cairo *should* be fair, document this and allow you to test/ ask if this limit exists in the version you are using, but it does not. Thus I suppose to detect that situation as 'cheap' as possible and react to it - e.g. in writer when below page 490. But not only - it might be possibe to construct draw/impress pages (free definable) that also reach that limit. With detecting as cheap as possible I mean: Naturally you would start to test your geometry to be painted if it is overlapping or outside that range defined by 24.8, but that would already involve transforming all geometry by world and view transformations. I think it should be okay to just take the target area (starting at 0,0 and having a size in pixels) and transforming that back to logical world coordinates. Then this needs to be checked only if view transformation changes, not object transformation. Usually view transformation is setup and all/many objects are painted to it using object transformations. Detection should then only be needed when view transform changes. Thus I added a test (see checkCoordinateLimitWorkaroundNeededForUsedCairo()). This is esecuted once per office runtime. If it detects that the problem is there it sets a flag. Depending on this the view coordinates are then transformed to logic coordinates and checked if these are completely inside the coordinate area that ciaro *can* correctly handle. This has to be done once per CariroSDPR since (currently) ViewTransformation is not changed (has to be adapted if this should happen one day). Based on that the single helpers on the renderer have to be adapted: Simplest is just to render using ViewCoordinates - and do transform object geometry using basegfx/our own stuff that does that correctly (with ease :-). Done that, checked, works AFAICT. What a bad surprise, but I can work around it... Change-Id: Ic33d6ccfe9854af396d0ac9f14c76eb25bb9e4e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180529 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2025-01-21Drop unnecessary DBG_ASSERTMichael Weghorn
With the if( mvTabList.empty() ) return; above, this is unnecessary, while there was probably more potential do have inconsistencies before commit 39c7e09ca5cb9b6dab143483bd6cb72fcad8307e Date: Wed Apr 25 12:37:18 2018 +0200 loplugin:useuniqueptr in SvTabListBox Change-Id: I775fef9b9c04c32eaa7dbdb4ff68e5e8d0e5dd90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180538 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-21vcl: Pass vector to SvTabListBox::SetTabsMichael Weghorn
... instead of passing an array and the number of elements as two separate params. Change-Id: If4d4e6db0f2db62ff155a29867baab495e326274 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180537 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-21sd: de-duplicate masters on save to pptx follow-upJaume Pujantell
After commit 2d9c808d1952c18daa007b41e70fc7e63f6c5712 "sd: de-duplicate slide masters on save to pptx", there was some loss of data on save since when saving only the layouts for de-duplicated masters, not enough of the shape tree was being saved. Ideally we may want a clever algorithm that best separates the shape tree between master and layout, but just saving all the shape tree on the layout files when de-duplicating masters also works. Change-Id: I8b932708ef9212a4d5034713066299065083da8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179861 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 3c8c537b3cfc4cf812e8728f6e6e46c0596ba7f6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180546 Tested-by: Jenkins Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
2025-01-21tdf#105083 Support status of numbering and bullet listOliver Specht
Shows the status of bullet/numbering in the current text selection in the toolbar buttons ToggleUnorder/OrderedList. Change-Id: I458896293c502da8142ad9cb43b5ea62a9f3b558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180238 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-01-21tdf#160621 Variable field dialog size of value fieldOliver Specht
The size of the value field is now set to 6 rows. Change-Id: I298a0dfc5c61c18a170b2e8f7a700dab17b5ee66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180173 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-01-21sd: de-duplicate slide masters on save to pptxJaume Pujantell
pptx files have layouts separated from masters, so multiple layouts can reference the same master. On import that master is duplicated for each layout. So we want that if it is saved without modification, the created file contains the same number of masters and layouts as the original pptx file. The commit d590f094ccd28ca449eff91692c2178058d5c621 "tdf#155512: sd: filter: eppt: add "SlideLayout" property to Slide Master" tried to do this but saved too many layouts, which appeared as extra masters on reload. The commit bff76421e234df7246a7f49c71a11432f86e09d1 "tdf#157740 FILESAVE PPTX: fix explosion of the number of master slides" fixed the issue of extra layouts but removed the de-duplication of masters. This commit avoids saving duplicated masters while keeping the correct saving of layouts. testTdf157740_slideMasters now checks for the correct number of masters and layouts. Change-Id: I199c55abe59d39c64e1e3e1fbd620e88f4f7290d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178669 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 2d9c808d1952c18daa007b41e70fc7e63f6c5712) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180539 Tested-by: Jenkins Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
2025-01-21tdf#117946 Mouse zoom support added to slide sorterOliver Specht
Change-Id: I3d532f14f25d31a90971ace262ddf88df3c33eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180020 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2025-01-21tdf#50743 tdf#37507 Improve scrolling while selectingOliver Specht
If the mouse leaves the document window scrolling of selections happens now in smaller steps so the user is able to stop at the intended position easier. Change-Id: Ifd21c92936021f8e2213d34446672e2a8eab568f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178724 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-01-21vscode-ide: use windows-style paths and Git Bash in wsl-as-helper caseChristian Lohmaier
This way automatic creation of a terminal for the build-tasks uses git-bash and also the paths to the executable can be found. Change-Id: I4871dc13e467927be3d82f1129fb39aa8d6925d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180512 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2025-01-21wsl-as-helper: avoid misdetecting builddir!=srcdir with long pathsChristian Lohmaier
when the user runs wsl.exe ./autogen.sh in a long path, the build initially works OK, it will realize that the build is performed in the source directory. However if another run of wsl.exe ./autogen.sh is triggered by running make (i.e. when configure.ac or some of the other files gets changed), it was run with the shortened version of the path as the value for SRCDIR, and comparing that with the pathname of the current directory (which most likely was browsed to by using the long form) resulted in a misdetection of the builddir != srcdir case, and autogen.sh did try to create the necessary symlinks and <module>/Makefile and external/*/Makefile files as if building in a separate build directory. Especially the self-referencing symlink in the include dir then caused some parts of the build (skia) to fail. To avoid this problem, explicitly convert the path to its long-form. This alone is not enough however to prevent the same issue occuring when the user changed to the srcdir using the shortened form, then the conversion would fail the same way (and while it is unlikely that the user uses that path manually, launching a terminal via the vscode-integration for example would also use the shortened form). So also cd to the long form of BUILDDIR when running the automatically triggered autogen.sh Change-Id: I02c1ee7d302daa6062b6a049d924f40a49217e5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180511 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2025-01-21tdf#161001 sw floattable: require in-header/footer for non-follow-text-flowMiklos Vajna
Open the bugdoc, the in-body floating table has an inner floating table which is rendered above the outer table, not inside it. This went wrong in commit f74a6ef94ac957e4c146fc9923d30ce6bd31b5ce (tdf#159453 sw floattable: fix unexpected overlap of in-header fly and body text, 2024-02-13), where the use-case was an in-header floating table interacting with body text. The more general case is in-body floating tables interacting with in-body text, so fix the problem by restricting the custom IsFollowingTextFlow=false property for in-header floating tables. Change-Id: I902f232e3c840ff0279d8ed6c2329ba48a03b4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180534 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-21fix ubsan in UITest_manual_testsNoel Grandin
after commit 72bbb0dd4a368dab2b1bd99917cd07d23a92a3f0 Author: Pranam Lashkari <lpranam@collabora.com> Date: Mon Dec 30 02:20:22 2024 +0530 sc: make data validy error dialog async (invalid value error) Change-Id: I885e470c6585df038f12bf5834fba005f5a072da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-21tighten up WinSalBitmap::Create* methodsNoel Grandin
One of the paths cannot be hit, so remove it. Add asserts in other places to catch conditions that should not happen. Change-Id: I401a0ffea2587d8bbcb313edef06e766d65c3eee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180533 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-01-21cid#1465236 Uncaught exceptionCaolán McNamara
and drop coverity workarounds Change-Id: If9ffc607999285b2f5b63e85c51b0289fb05750f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-21cid#1641353 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I9037272d4f6ff2e2008d6e13e8021551e5cab1af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180530 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-21ScriptForge (ContextMenu) new RemoveAllItems() methodJean-Pierre Ledure
The contextmenu service handles the context menus stored in a document. So far, it provided only the AddItem() method to add new items at the bottom of the menu. The new method allows to forget the preconfigured menu and to replace it completely. Example: associate next Sub with the on-right-click event of sheet 'Sheet1' => The custom menu appears when right-clicking in column C, otherwise normal behaviour Sub OnRightClick1(Optional XRange) ' Xrange is a com.sun.star.table.XCellRange Dim calc, menu, bColumn Set calc = CreateScriptService("Calc", ThisComponent) Set menu = calc.ContextMenus("cell") menu.RemoveAllItems() bColumn = ( Len(calc.Intersect("Sheet1.$C:$C", _ XRange.AbsoluteName)) > 0 ) If bColumn Then menu.AddItem("A", Script := "vnd.sun.star.script:...&location=document") ... End If menu.Activate(bColumn) End Sub The function is available both for Basic and Python user scripts. The user documentation will have to be reviewed. Change-Id: I84ee8724bf99c37397a19d729133cc4686a63980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180520 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2025-01-21tdf#145614 Convert #define to constexprAkshay Kumar Dubey
Change-Id: I0bdbb662b807c6ffc9030c4c695e5022949e172f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180254 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-01-21tdf#87605 Add new words to technical dictionaryShardul Vikram Singh
Change-Id: I88e178a31a1539ef5632c2425b0f7fdd73d344fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180478 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2025-01-21avoid some casting in WinSalBitmapNoel Grandin
Change-Id: I0f18baf52131f229edb5be4bab723e954ba36cab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180532 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-15 16:21:39 +0000