summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-04-24loplugin:useuniqueptr in TETextPortionListNoel Grandin
Change-Id: Ia4ba670cc524a0103dbab0880931279bafd0925e Reviewed-on: https://gerrit.libreoffice.org/53347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-24loplugin:useuniqueptr in PrintDialogNoel Grandin
Change-Id: Ia40e48b2e57624bb59bc0dcc0927bf673581081d Reviewed-on: https://gerrit.libreoffice.org/53346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-24loplugin:useuniqueptr in ToolBoxNoel Grandin
Change-Id: Id2cbc7d70de2e0ddf0503448575fe2c2ca0120a0 Reviewed-on: https://gerrit.libreoffice.org/53345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-24loplugin:useuniqueptr in EditNoel Grandin
Change-Id: Ia73a8d5be15dde1bc04a7acfdbc5712d7a77b59d Reviewed-on: https://gerrit.libreoffice.org/53342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-24Revert "work around clang-cl ABI bug PR25641"Stephan Bergmann
This reverts commit 81ce629c9e8a4fc26ded9d49157e3f3263991e03, now that <https://bugs.llvm.org/show_bug.cgi?id=25641> "clang-cl: vtordisp thunks not emitted for functions with class template specializations in their signatures" is fixed.
2018-04-23fix duplicate strings in notebookbar *again*Christian Lohmaier
added a jenkins step for that now since it gets annoying now... Change-Id: I9565ef62671afa996aea8c626e3d93c0783ce321
2018-04-23Updated coreSophia Schröder
Project: help 3db795172c8031ac1a88967f28858812a2d35089 Improve formatting in help text. Change-Id: I873128ed6353caf37f063a87361bd0a6f7c79f96 Reviewed-on: https://gerrit.libreoffice.org/53321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-23set SfxTabPage parent dialog explicitlyCaolán McNamara
Change-Id: If7813f9f5e35694312b055cc92868638bc3773d5 Reviewed-on: https://gerrit.libreoffice.org/53326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23type mismatch at 1st parameter ('vcl::Window *const' vs 'const vcl::Window *')Caolán McNamara
Change-Id: I4e72c5c66b3826f00ad65da81f253c32ca9cdcbb Reviewed-on: https://gerrit.libreoffice.org/53334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23crashtesting: assert on export of fdo72030-2.key, fix typoCaolán McNamara
Change-Id: Id7ef38be46f7d2ff1de1f3124d4fa82258b086a2 Reviewed-on: https://gerrit.libreoffice.org/53339 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23Fix thinkoKhaled Hosny
This should be the end of the run we are currently shaping, not not the end of the whole text. Change-Id: Ie9e5f009eadccc50dd04d81c5a6bffaf8ae14524 Reviewed-on: https://gerrit.libreoffice.org/53338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-04-23Be congruent, use CamelCase; also fix another (de<>en) typoEike Rathke
Change-Id: If70915c596adeb1fe67ba1f3eb703a37ff684631
2018-04-23vcl: avoid swap in when Graphic::GetSizePixel() is calledMiklos Vajna
It's easier to fix this centrally in vcl, rather than not calling GetSizePixel() in each and every import filter. Change-Id: Ie0a788b8a5b886ebc2fedf0dc052deb4149b9364 Reviewed-on: https://gerrit.libreoffice.org/53333 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-23tdf#108894 Drop Office version numbers in filter namesAdolfo Jayme Barrientos
These are prone to be out of date. Besides, to be extra precise we would otherwise need to mention Office 365 as well there, and that’s overkill. What every Office version since 2007 has had in common is that their formats are called “OOXML”, so just mention that and be done with it. Change-Id: I0393990e6fd67d039666b3954cc9fc4951a7fe08
2018-04-23move GetConfigId from TabPage to SfxTabPageCaolán McNamara
Change-Id: Id2c687c2270cb1c2419cc6664200292b2740d0a4 Reviewed-on: https://gerrit.libreoffice.org/53325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23Removed duplicated includeAndrea Gelmini
Change-Id: I1b4cf0dcb18c1eeccb1155c4d4f1462050993aab Reviewed-on: https://gerrit.libreoffice.org/53277 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-23sw HTML import: lazy-read inline imagesMiklos Vajna
Also prefer Graphic::GetPrefSize() over Graphic::GetSizePixel(), since the previous does not swap in the image. Change-Id: I100da14716448e72b687ce8ad1800326f0b3735e Reviewed-on: https://gerrit.libreoffice.org/53322 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-23Adapt --enable-qt5Stephan Bergmann
...to c0af8057188c0e95831f9e6d1ef96a424da6f9b2 "weld SfxPrintOptionsDialog" Change-Id: Id407eaf49c2a39d77489a724db6e58a6ff29455b
2018-04-23Missing declarationStephan Bergmann
Change-Id: I059f5ada671327566b34ad69157a17f1fe3f0304
2018-04-23Updated coreAdolfo Jayme Barrientos
Project: help 41c6294398f9a3a8ba7c3c66abd4cc14dbbcecd1 Helponline: Tweak pagination symbols for improved clarity Change-Id: I5308fb5f7039db592038f674b390f92779376d6d
2018-04-23[API CHANGE] MediaProperties don't accept GraphicObject URL anymoreTomaž Vajngerl
This changes the description for URL property as it doesn't support GraphicObject URL (vnd.sun.star.GraphicObject) anymore so not a direct API change, but it is a significant functional change. Change-Id: Ie440d2140274243733a18ebc18089d2daa820c74 Reviewed-on: https://gerrit.libreoffice.org/53243 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-23NB Implementation: Tabbedbar global layoutandreas kainz
Change-Id: Ic3c4bdda30bf217a0c71907234bbf7ad2a3f8d59 Reviewed-on: https://gerrit.libreoffice.org/53309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-23Updated coreOlivier Hallot
Project: help b6dd08ef07f38d81928b595f3af43c2b8dd151e1 Fix bookmark weird placement Change-Id: Ia7b087ddc78f84097310e5644b91385737e9e692 Reviewed-on: https://gerrit.libreoffice.org/53302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-23Updated coreOlivier Hallot
Project: help cc09d26f79acdb4c488fbc54fd51325f1b9dfbb7 Fix in conditional format help page external link Change-Id: Id70b5549c02abaa650c9d8ba8c9a23872b7f2f33 Reviewed-on: https://gerrit.libreoffice.org/53301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-23Updated coreOlivier Hallot
Project: help 20f5204fb81945fc6c282f7322cd16290de1efd4 Fix example for ROUNDSIG Change-Id: I35699a995e8c6b751337d90e471f258f0c55bb16 Reviewed-on: https://gerrit.libreoffice.org/53300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-23Updated coreSophia Schröder
Project: help f7ed5d8cb7bc6bfd25206e157fcf6b4372f38329 Improve wording and formatting of help text Change-Id: Ic06c6eebc08729b3131db1c213a661c2306d69a9 Reviewed-on: https://gerrit.libreoffice.org/53287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-23accessibility : remove useless guards and simplify.Arnaud Versini
Change-Id: I9e0d5967f71b2bd822c64690f8e02a0c95c8b88f Reviewed-on: https://gerrit.libreoffice.org/52581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23weld SfxPrintOptionsDialogCaolán McNamara
and SwMMResultPrintDialog Change-Id: Icded6a26a3a151293bea0c9173334cf634283e89 Reviewed-on: https://gerrit.libreoffice.org/53299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23sw: prefix members of ReaderMiklos Vajna
Change-Id: Ia4210410047ce3b37113cfe0d4dff5bb7122baf2 Reviewed-on: https://gerrit.libreoffice.org/53307 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-23tdf#113959 Use simple SvxResId calls hereGabor Kelemen
Change-Id: I533f07abcb8f2020592ab51562fd2e22ec11720c Reviewed-on: https://gerrit.libreoffice.org/53255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-23WIP: Split --with-help=html packages into non-locale and per-localeStephan Bergmann
...in preparation of packaging the per-locale data properly. non-locale: GeneratedPackage_html_media Package_html_dynamic Package_html_static per-locale: GeneratedPackage_html_lang_generated Package_html_lang This is the core part of a change that spans core and helpcontent2. Change-Id: I0e014649129f9ec498e5307c64807efa95eee0de
2018-04-23Updated coreStephan Bergmann
Project: help c0508a0752d460bca8e7f5917edc074d9bc66f93 WIP: Split --with-help=html packages into non-locale and per-locale ...in preparation of packaging the per-locale data properly. non-locale: GeneratedPackage_html_media Package_html_dynamic Package_html_static per-locale: GeneratedPackage_html_lang_generated Package_html_lang This is the helpcontent2 part of a change that spans core and helpcontent2. Change-Id: Iabe24a710d46d23246699d102ab96686cfe85ab4 Reviewed-on: https://gerrit.libreoffice.org/53317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-23fix memory management in BitmapConvolutionMatrixFilterNoel Grandin
was deleting a stack allocated buffer. Also (*) drop the BitmapConvolutionMatrixFilter default constructor, the current code does not permit mpMatrix to be nullptr (*) declare the mpMatrix field as a reference to a fixed length array, to be more precise (*) pass the array in the constructor so that call sites will be properly type- and length-checked. Change-Id: I650d56cdfac0dae4ea77df7c0c03e19d658c00c8 Reviewed-on: https://gerrit.libreoffice.org/53312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23Translate German commentJohnny_M
Change-Id: I490cd001c60b28a4f04eba6195e887f4e1061d5c Reviewed-on: https://gerrit.libreoffice.org/53251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-23Updated coreAndras Timar
Project: translations 6e357f3555df07d206b2967816182d2f9b645b80 Updated Slovenian translation Change-Id: Ie327fd767821046b119f05efb55fd42239ba6bea
2018-04-23Fix typo in variableAndrea Gelmini
Change-Id: I9ff961e9d6558478e72098a74048a5957299a953 Reviewed-on: https://gerrit.libreoffice.org/52547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-23better focus in/out impl that doesn't depend on being a ControlCaolán McNamara
Change-Id: I3ed1732895efa44b8ff60c410356ecb684f06ba3 Reviewed-on: https://gerrit.libreoffice.org/53297 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23call ImplCallEventListenersApplicationDataChanged in addition to AllWindowsCaolán McNamara
so non-window entities can get to hear about them Change-Id: I00016a432d8e76e39dbf6340b014acdf4498d091 Reviewed-on: https://gerrit.libreoffice.org/53298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23Revert "loplugin:expressionalwayszero"Tor Lillqvist
Issue was fixed by Stephan by making the plugin less eager to complain. This reverts commit c250b6a5c6edbca08d5f083ff33fbfc5a49b3b4a.
2018-04-23loplugin:expressionalwayszeroTor Lillqvist
So comment out the use of those expressions, and to avoid ununsed variables, also comment out the definitions of those const variables. Change-Id: I870c7d9599f944d3d55758492c059bcf15628a4a Reviewed-on: https://gerrit.libreoffice.org/53305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-04-23loplugin:redundantfcastStephan Bergmann
(Presumably <https://gerrit.libreoffice.org/#/c/53201/> "vcl: ImplSolarize() to BitmapSolarizeFilter" passed Gerrit/Jenkins because the Linux Clang plugin build was done in C++11, not C++17 mode.) Change-Id: I8a7afee18ed2f83921eb82b74252d0ebf76c25d5
2018-04-23Don't warn about multiplication by zero in loplugin:expressionalwayszeroStephan Bergmann
That specific warning (added with 862dc17e437f0972223e18555110dc875d2ffa44 "loplugin:expressionalwayszero improvements", together with other improvements) already looked somewhat unhelpful to me in 4cb78942f25e9ea2e9a8445825438cd67b1c00f9 "loplugin:expressionalwayszero (clang-cl)", but now started to generate > [CXX] vcl/source/bitmap/BitmapSobelGreyFilter.cxx > /data/sbergman/lo-clang2/core/vcl/source/bitmap/BitmapSobelGreyFilter.cxx:92:34: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > nSum1 += nMask121 * nGrey12; > ^~~~~~~~~~~~~~~~~~ > /data/sbergman/lo-clang2/core/vcl/source/bitmap/BitmapSobelGreyFilter.cxx:99:34: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > nSum2 += nMask212 * nGrey21; > ^~~~~~~~~~~~~~~~~~ > /data/sbergman/lo-clang2/core/vcl/source/bitmap/BitmapSobelGreyFilter.cxx:101:34: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > nSum1 += nMask221 * nGrey22; > ^~~~~~~~~~~~~~~~~~ > /data/sbergman/lo-clang2/core/vcl/source/bitmap/BitmapSobelGreyFilter.cxx:102:34: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > nSum2 += nMask222 * nGrey22; > ^~~~~~~~~~~~~~~~~~ > /data/sbergman/lo-clang2/core/vcl/source/bitmap/BitmapSobelGreyFilter.cxx:105:34: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > nSum2 += nMask232 * nGrey23; > ^~~~~~~~~~~~~~~~~~ > /data/sbergman/lo-clang2/core/vcl/source/bitmap/BitmapSobelGreyFilter.cxx:110:34: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > nSum1 += nMask321 * nGrey32; > ^~~~~~~~~~~~~~~~~~ > 6 errors generated. (where all those nMask* are zero constants; and which even passed Gerrit/Jenkins as loplugin:expressionalwayszero is only active for Clang >= 3.9). Lets just remove that specific check again. Change-Id: Ia8710f83b16d6e6949439d3941e17b8a0959aa8b
2018-04-23WIP: Include --with-help=html in installation setsStephan Bergmann
As a first step, include all the instdir/help/* content that comes from helpcontent2 (there's also some *.xsl files there coming from xmlhelp?) in the ooo base module: instdir/help/default.css fuse.js help.html help.js help2.js hid2file.js index.html media/ normalize.css paginathing.js en-US/ <any other locale>/ The locale-independent parts could remain in the ooo base module or could be split out into some help module (esp. the media/ tree may grow large?). The per-locale sub-dirs will definitely need to be split into locale-specific modules in a next step. Change-Id: I3e7b1b0e9c965372a23a51ed8ddc809e395fd891 Reviewed-on: https://gerrit.libreoffice.org/53213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-23loplugin:singlevalfields improve unaryoperatorNoel Grandin
when we see a unaryoperator, unless it's one of a small set, we can know (mostly) that the field will not be written. there is still a small risk of false+ with code taking references via conditional expressions. Change-Id: I96fa808067576a50e5eaf425338e225b4e0bdd4e Reviewed-on: https://gerrit.libreoffice.org/53263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23loplugin:useuniqueptr in MenuButtonNoel Grandin
Change-Id: I4e7a2ca5f8bb645e99414b1c99dc6261310c89bb Reviewed-on: https://gerrit.libreoffice.org/53237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23loplugin:useuniqueptr in MoreButtonNoel Grandin
and remove unused mpItemList field in ImplMoreButtonData Change-Id: I1eee6958d0f064cec22028399de5fb28e8647617 Reviewed-on: https://gerrit.libreoffice.org/53236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23loplugin:useuniqueptr in CachedContentResultSet::CCRS_CacheNoel Grandin
Change-Id: Idb2dd770ef39119f2a6ee6989bb983c3c77a1d68 Reviewed-on: https://gerrit.libreoffice.org/53235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23loplugin:useuiqueptr in SortedEntryList and EventListNoel Grandin
Change-Id: I15e6e29347dfce68e5631337bf2d3754bffdf864 Reviewed-on: https://gerrit.libreoffice.org/53234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23loplugin:useuniqueptr in SplitWindowNoel Grandin
Change-Id: I04b45f02ce0dc98d11fb78982b8364fdd8333f9c Reviewed-on: https://gerrit.libreoffice.org/53233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23loplugin:useuniqueptr in MenuNoel Grandin
Change-Id: I4de2081597ffc55a95fe5b482c37461811f323e6 Reviewed-on: https://gerrit.libreoffice.org/53232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-29 15:30:57 +0000