summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-01-05Related: tdf#152781 Stab the 0xE40A {es} vs Latin America quirkEike Rathke
First, the LANGUAGE_SPANISH_LATIN_AMERICA 0xE40A is not a MS system LCID, it is Spanish 0x00a with sublanguage 0x39 => user defined (in the range 0x20 to 0x3f). Meanwhile MS reserved 0x580A for {es-419}, so obsolete the legacy 0xE40A definition and replace with 0x580A when encountered. Second, due to the legacy plain {es} mapping being present, an encountered 'es' (from our bundled dictionary extension) got mapped to 0xE40A instead of 0xA and thus was added to the character language listbox (that otherwise suppresses LCIDs without sublanguage), resulting in a "Spanish {es}" entry. Besides, it's currently not clear how to actually proceed with such dictionary situation when, for example, both 'es-ES' and 'es' dictionaries are present and the 'es' dictionary apparently is meant as base and contains entries the 'es-ES' does not or 'es-ES' overrides entries. It might be it's handled half-way in linguistics, but maybe not even that, I didn't investigate. Change-Id: Id859731ba5efa65d4a6de429b7f52027aa69327c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145093 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-01-05Related: tdf#152703 Prevent possible hang when live resizing a windowPatrick Luby
Application::Reschedule() can potentially display a modal dialog which will cause a hang so temporarily disable live resize by clampiing the window's minimum and maximum sizes to the current frame size which in Application::Reschedule(). Also, eliminate flickering during live resizing of a window when using Skia/Metal. When in live resize, the SkiaSalGraphicsImpl class does not detect that the window size has changed until after the flush has been called so call checkSurface() to recreate the SkSurface if needed before flushing. Flushing had to be moved during [self windowDidResize:] to eliminate flicker. Flushing in [self displayIfNeeded] does not eliminate flicker so apparently [self windowDidResize:] is called earlier. Change-Id: Id3de838d2e17fee85cb583b6c4e862b571d47142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145053 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-05tdf#152710 xmloff: ignore exception in XMLChangedRegionImportContextMichael Stahl
The xOldCursor must be restored in all cases. Also XMLParaContext triggers an exception which ends up aborting the import. Change-Id: I8f4785e0e9bde4c8c484954a4d66f3b82d6ca28c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145094 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-05tdf#152710 sw: call and fix DeleteSection() insteadMichael Stahl
Turns out there's a function to delete a complete nodes array section - and it has the same problem? Why does it move indexes only from startnode + 1? Let's try to fix it to be more consistent. Change-Id: Iedacc10e29c1646c4ccc85e53a479b0351f5cfcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145078 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-05tdf#152710 sw: invalidate SwUnoCursors properly in DeleteRangeImpl()Michael Stahl
This crashes with: list.cxx:44: corrupt document structure, bailing out of infinite loop ndtxt.cxx:5437: void SwTextNode::TriggerNodeUpdate(const sw::LegacyModifyHint&): Assertion `dynamic_cast<SwTextFormatColl const*>(static_cast<const SwFormatChg*>(pOldValue)->pChangedFormat)' failed. Because the redline from 7 to 9 is deleted, but then some cursor ends up on node 10 which is invalid as it is an end node. [ 6] 0x60666a0 StartNode , [ 7] 0x61195e0 StartNode , [ 8] 0x61197a8 TextNode "tainment", [ 9] 0x6119670 EndNode , [ 10] 0x6066730 EndNode , The first problem is that DeleteRangeImpl() uses the point node as the target position for PaMCorrAbs(), but in this case the point node will be deleted. PaMCorrAbs() has a check to invalidate SwUnoCursors that would be moved out of their parent sections, but due to the first problem it can't check it, and the second problem is that lcl_FindUnoCursorSection() doesn't work on redline sections, as those have node type SwNormalStartNode. After fixing the invalidation, subsequent access to the SwXTextCursor throws exceptions and importing the file fails. (regression from commit 477e489e71b4a96ff10d9f2d2b802d91dec3e319) Thanks to Dave Gilbert for identifying the problematic DeleteRange() call. Change-Id: I48a373cc122073b82bc47513fdae684f45b0efb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145077 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-05Fix typosAndrea Gelmini
Change-Id: I49ca0e4e05420a4992acc348a3dc6e3533f4d30e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144618 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-05Removed executable bits from source filesAndrea Gelmini
Change-Id: Ib9fbfc8d52bfddc6af65bf62af3c49767868e032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144952 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-05Fix typoAndrea Gelmini
Change-Id: I963f340e0da9a0e7bc50bd1ee8c73f28c8edb6de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145101 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-05Fix typoAndrea Gelmini
Change-Id: I6a15118c9e0b686c7157a162990b7776362865f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145100 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-05sw: UpdateFieldContents: fix typosMiklos Vajna
- The function name itself had a typo, spotted at <https://gerrit.libreoffice.org/c/core/+/145036/2#message-d8cb4de7de483866e0c86c8919cdf47f84b6037e>. - Also, if the # of provided fields and # of fields we find in the document don't match, we can give up, so no need to continue, the same condition would fail again, anyway. Change-Id: Ifbf7f60c86f469697056975752efc9d130287099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145083 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-05flatten some code in vclNoel Grandin
Change-Id: I29638408d60bfa02609ed58839829ed51d319e98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-05tdf#56973 - Copy/paste (single) sheet is checked but not enabledAndreas Heinisch
Enable the "copy" radio button in the move/copy sheet dialog, if there is just a single sheet in a spreadsheet document. Otherwise, users get the impression that a single sheet cannot be copied because the "copy" radio button is selected but not enabled, i.e., greyed out. Change-Id: Icf98973585491b0c8c9a74aad3900f6cc2895d11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145064 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-01-05ScriptForge - (SFDocuments) new FormDocument serviceJean-Pierre Ledure
The SF_FormDocument service is focused on : - The orchestration of Base form documents (aka Base Forms, but this is confusing) and the identification of and the access to their controls. - Form documents are always contained in a Base document. A form document may be opened either: - via code or user interface from the Base file welcome page - via code only, without having its Base container opened first In any mode, a form document can be opened only in 1 single copy. The FormDocument service is triggered either by base.OpenFormDocument(...) database.OpenFormDocument(...) ' Base file may be closed ui.GetDocument(...) Specific methods: CloseDocument() Forms() GetDatabase() PrintOut() Next methods are inherited from the Document superclass: Activate() CreateMenu(), RemoveMenu() ExportAsPdf() RunCommand() SaveCopyAs() SetPrinter() As a consequence, next methods remain available but should be declared as deprecated in the help: base.CloseFormDocument() base.Forms() base.PrintOut() base.SetPrinter() Above changes have several more minor impacts : - beside IsCalc, IsWriter, ... , a new IsFormDocument property - the UI service identifies open form documents - a new service means a new entry to register in the Services catalog - management of form events has been reviewed - the connection between Base, FormDocument, Form and Database services is reinforced - menus were available on components, now also on sub-components The new service is available for both Basic and Python user scripts. It requires in the help - a new sf_formdocument page - a review of the sf_base, sf_database, sf_form, sf_ui pages Change-Id: Ib06d1c4565ca093af2f068fa5b8082082641752e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145080 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-01-05sw XHTML export: avoid sdnum and sdval attributes on table cellsMiklos Vajna
These are not valid in XHTML, as the reqif validator points it out: ERROR at 239: [XSD] cvc-complex-type.3.2.2: Attribute 'sdval' is not allowed to appear in element 'td'. ERROR at 239: [XSD] cvc-complex-type.3.2.2: Attribute 'sdnum' is not allowed to appear in element 'td'. The actual cell contents is already there, so just omit this unwanted metadata in the XHTML case. Change-Id: I68804dd2ce45b0579287aeccbb550b174859f7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145081 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-05tdf#65535 sw spellDialog.py: fix lo-upsan build betterLászló Németh
Follow-up to commit d2614337e8291b9b6d114fda5ae914f6940c353a "tdf#65535 sw spellDialog.py: add same latency to fix lo-upsan build". Change-Id: Ibb7e5e4afe1cab99fc24342afb94458f612ec3f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145073 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-05tdf#131203 DOCX import: fix lost table when w:tblGrid is missingLászló Németh
Load tables in case of incomplete text table definition, i.e. missing w:tblGrid and its w:gridCol elements, like MSO does. Note: Apache POI, and maybe old MSO versions generated such DOCX documents. divide_by_zero() was thrown from 975884fbbc3f80a634258ee562037688a42027a9 "ofz#7110 ensure join is called on std::exceptions as well as uno::Exception". See also commit 9279b0bb5397d0520b727ab0d271f328807c8749 "writerfilter: avoid divide by zero" and commit 116cadb5d2582532c69677a2f8499e8e9b7b9b80 "tdf#59274 DOCX import: fix tables with incomplete grid". Change-Id: I991807da13e22e551f81c3fb60580be7a9c0fb50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145069 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-05Fix typoAndrea Gelmini
Change-Id: Icde32c862bb498af0908399b388973db4d7f8b02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145074 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-05sw update of refmarks: fix handling of ignored refmarksMiklos Vajna
As pointed out at <https://gerrit.libreoffice.org/c/core/+/145036/1#message-165c0282ace92160592c896c6867095d3558ee96>, it's not correct that UpdateFieldConents() uses a single index into both the provided fields/refmarks array and into the document's all refmarks array. We need a new index that counts the input fields/refmarks we got and which is not incremented for ignored refmarks. Extend the testcase to have 2 paragraphs in the document: the first paragraph has a refmark that is to be ignored and the second para has a refmark that is interesting to us. This makes the test fail. Then fix up UpdateFieldConents() to properly count how we iterate through all refmarks and the provided refmarks in parallel. Change-Id: I1fabf5b29beeabe9e8a126f1662ca8830e5c4e20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145068 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-05Revert all the recent loplugin:unocast changesStephan Bergmann
...as obsoleted by ef533553559fe09b4afab651fc692885d1acf4ed "Rudimentary support for dynamic_cast on UNO proxy objects". This reverts all of: 4cfcc9ac37b90ce64c8402a41eb4638adb185b5c "loplugin:unocast (framework::Desktop)" 03efbf72f4ddf7a84aa8aabef348331bd4b75e8a "loplugin:unocast (vclcanvas::TextLayout)" 80099fdd51a69eaa6c36ca88ef772810e4a777fa "loplugin:unocast (SalGtkXWindow)" cc147f576d8687fb79c77d47d41dc4ba1678a469 "loplugin:unocast (sdext::presenter::CachablePresenterView)" 40db42be1d8fd0f9c6c8c5ba3767ddb9ee2034c2 "loplugin:unocast (vclcanvas::CanvasFont)" 2d1e7995eae29e2826449eb5179f5fae181794a5 "loplugin:unocast (CairoColorSpace)" 4c0bbe4bd97636207cf71a6aa120c67698891da9 "loplugin:unocast (canvas::ParametricPolyPolygon)" 89803666621c07d1b1ac9d3bd883f0ca192a91a0 "loplugin:unocast (vclcanas::CanvasBitmap)" d5e0c2c8db71878d21c2a7255af08cf5f9a6dd04 "loplugin:unocast (sfx2::DigitalSignatures)" c0c4519e0d5b555f59bbc04cc616454edfd1f4ce "loplugin:unocast (VCLXAccessibleComponent)" feb8b833a6245d42400f42a0bc789dc84594ee6f "loplugin:unocast (VCLXDialog)" 1fa58cc6cc9c3849753342a5d9a6ddfa461b5e66 "loplugin:unocast (VCLXMultiPage)" f481f036deb1b1b46f3038074c4659f3a91b9c6c "loplugin:unocast (DocumentSettingsSerializer)" 73df933f5fa5932f94e5a1b338a3eda00a9ce354 "loplugin:unocast (css::embed::EmbeddedUpdate)" 420165ab0ef03c0467f9d17f504de2d2fc78f0e6 "loplugin:unocast (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)" 9abe8ee067e6c00f19d8a13346d53c4641c27166 "loplugin:unocast (MutableTreeNode)" 9f3022ceb036f23b4b0994c3e2fbd1001bff225a "loplugin:unocast (VCLXTabPage)" 1be70dda02c12a60778b7607cff2520ae1aa611e "loplugin:unocast (vcl::unotools::VclCanvasBitmap)" d6a70bb641b96e8e5616448c2378131ed62658b4 "loplugin:unocast (basegfx::unotools::UnoPolyPolygon)" 5a14f009e6782c077463c8cbb8e9cea3d7950107 "loplugin:unocast (xmlsecurity::Certificate)" 99009c9535dfa3e0d838989ccc7d84bfa2320ff4 "loplugin:unocast (sd::Annotation)" 0c7585c5fa78887e5459885ed744e8044fd76137 "loplugin:unocast (sd::TextApiObject)" 24e14afd1bfcaed6c200ab081973fba7e47267ca "loplugin:unocast (SignatureVerifierImpl)" 1a7ad0c10d286ce9ae2700ceb2fd50eed1fb43a4 "loplugin:unocast (pcr::PropertyEventTranslation)" a97e2d2702d9a6f37775ccee2c08c4f3b2479c4b "loplugin:unocast (RangePageBreaks)" 19dfdf86ad1f5b08041d8b7a9f196caf881231ab "iloplugin:unocast (pcr::OFormattedNumericControl)" f9785ea595fd8e911f6370e836fa579225b9e571 "loplugin:unocast (frm::OInterfaceContainer)" 5e5f40a4a92a31b0932c690219d002fcf18598cf "loplugin:unocast (ScVbaShapes)" 27b35b2c215b4832d4378ec3a7ecbba926552d06 "loplugin:unocast (ScVbaShapeRange)" cb3108f860065928552a86cf8acc4b3a95718ecf "cid#1517812 Dereference null return value" feba0ddb1521d1142560fe54b7d7696ee910237f "loplugin:unocast (weld::TransportAsXWindow)" 4d6c23216559eb48f9943bb49d6e475a6d64ba15 "loplugin:unocast (oox::ForumlaImExportBase)" 4844c096a8ab6a9a620c410a0949d4499f12a504 "loplugin:unocast (cairocanvas::SurfaceProvider)" 9a0b523e0a84d403b9092176ccec4b3e3efe42d0 "loplugin:unocast (cairocanvas::CanvasBitmap)" 8a5648d8e59b4b007dbbf3824777c19a21efc61e "loplugin:unocast (cairocanvas::TextLayout)" 28c27a0623bc78a0590858f97d03b620985bc84c "loplugin:unocast (cairocanvas::CanvasFont)" 53bc223cb3288e32a417696ee61c29e5f01f209d "loplugin:unocast (cairocanvas::RepaintTarget)" 5f70b0b9f6bc4ab145ddbd9155590ed4a3b1b9ec "loplugin:unocast (SvXMLImport)" 068187a898cdd2e26e9b16c348ecc1ed2dee3f29 "loplugin:unocast (VCLXWindow)" 88b4f966202717cd4ad38a30a8eda22c3e69ed35 "loplugin:unocast (sfx2::sidebar::SidebarController)" f1b7a69b280aefe2f1b3b0f32193494fd765f2bd "loplugin:unocast (SvxLineStyleToolBoxControl)" ba76f0ba7e8de4d2953739c952004b7d9af47197 "loplugin:unocast (i18npool::Calendar_gregorian)" 840154daf934d8df52ead1cb7acd798c4d30f007 "loplugin:unocast (framework::AddonsToolBarWrapper)" b0e9c4c5f063cefa9557810e3349bdb9c7493091 "loplugin:unocast (GrammarCheckingIterator)" 8ee6cfc9655ce9de4617cea1a0d9cb9d7a4fbfac "loplugin:unocast (ucb::ucp::ext::Content)" 5b8cd77c112bc8c0e92b8fec215c3c8e802bbc0a "loplugin:unocast (basic::SfxScriptLibraryContainer)" 9e73ff9fce12e102bb3c3cea8d8bb96c88f2c9ad "loplugin:unocast (sdext::presenter::PresenterNotesView)" a98acca8fbc38d3fd5600ae5056a8e42b6d8a40d "loplugin:unocast (SelectionChangeHandler)" c0b59ad6e35b0cb0dea0821e95f95569739078c1 "Consistently use comphelper::getSomethingImpl<I>(aIdentifier, this)" 276e3ccbdd3259ec3daf8a1a98fa7f406b14e21c "loplugin:unocast (vclcanvas::RepaintTarget)" Change-Id: I37c73e3422a5154bf6cb647640d2d3f23db8bc34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-05move getPixel into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara
Change-Id: I5401cc87ec228d52d98fc65840f875cfb55e30c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-05move drawPixel into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara
Change-Id: I0638403ab54039793e851583937b09674f05c36d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145051 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-05move drawLine into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara
Change-Id: I6c667b4aa64c49ad18b7e9a2cd6cc43228369bd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145050 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-05move hasFastDrawTransformedBitmap into CairoCommon and reuseCaolán McNamara
Change-Id: I5c70f657fe885da54caf9514bdddf868e9cf8c1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145029 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-05move drawAlphaRect into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara
Change-Id: Ic9155117dd8586db5738cd7a620818af8bb28f81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145028 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-05move drawGradient into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara
Change-Id: I249afbc4cf6318fd9ed42fef0a2aa71d1a76d9ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145024 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-05Related: tdf#150687 check autocorr DocumentList.xml at build timeCaolán McNamara
to ensure no noopt entries exist Change-Id: I9fb95e211d6030e1f551558fd5a0a3ca700c8fc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145030 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-05external/icu: Fix intermittent cross build failureMichael Weghorn
The ICU build for Android sometimes failed as follows: > ICU for C/C++ 72.1 is ready to be built. > === Important Notes: === > Data Packaging: static > This means: ICU data will be stored in a static library. > To locate data: ICU will use the linked data library. If linked with the stub library located in stubdata/, the application can use udata_setCommonData() or set a data path to override. > Building ICU: Use a GNU make such as /usr/bin/gmake to build ICU. > checking the version of "/usr/bin/gmake"... gmake[2]: Entering directory '/home/michi/development/git/libreoffice-WORKTREE-for-android-x86/workdir/UnpackedTarball/icu/source' > 4.3 (we wanted at least 3.80) > gmake[2]: Leaving directory '/home/michi/development/git/libreoffice-WORKTREE-for-android-x86/workdir/UnpackedTarball/icu/source' > ok > ## Note: you have disabled ICU's tools. This ICU cannot build its own data or tests. > ## Expect build failures in the 'data', 'test', and other directories. > icudefs.mk:328: @cross_mixed_buildroot@/config/icucross.mk: No such file or directory > make[2]: *** No rule to make target '@cross_mixed_buildroot@/config/icucross.mk'. Stop. > make[1]: *** [/home/michi/development/git/libreoffice-WORKTREE-for-android-x86/external/icu/ExternalProject_icu.mk:68: /home/michi/development/git/libreoffice-WORKTREE-for-android-x86/workdir/ExternalProject/icu/build] Error 1 > make: *** [Makefile:289: build] Error 2 config.log showed that instead of the `cross_mixed_buildroot` and `cross_unix_buildroot` configure variables introduced instead of `cross_buildroot` in commit 7f16cabf00daa30e9284d2fb2494bd341352c25e Date: Thu Oct 1 11:20:50 2020 +0200 icu: fix Windows Cygwin cross build , only the latter was set. While that commit also added a call to autoconf to update `configure` from the patched `configure.ac`, autoconf would leave the old version in place if the timestamp of `configure` was newer than that of `configure.ac` after unpacking the tarball. Call autoconf with the `-f` param to force the update. Do the same for another autoconf invocation that was added in commit 6c94958e56fcbacb8e1f689550a60034b074857c Date: Fri Jul 17 22:25:01 2020 +0200 icu: fix Windows Arm64 build Change-Id: I5685ebce13e2950a4dc8f1dec75c4aed18d584f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145043 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-01-05tdf#152840 add ST_ThemeColor values to ClrScheme::getColorRegina Henschel
... and Color::getSchemeColorIndex(). Without the fix it was not in all cases detected, that a theme color was used, so the FillColorTheme or the CharColorTheme property had got value '-1'. In case of WordArt in docx import, the color could not be determined and the text was black. Change-Id: I81cdb22d6b3c30bf9923b9069ba2e384ac5b3a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145021 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-01-05sw lok: expose field type & command of fieldmark under cursorMiklos Vajna
It was possible to get the properties of all fieldmarks, but you could not get the properties of the fieldmark under the current cursor. Getting the properties of the current fieldmark is useful for Zotero: if we already have a citation and want to insert one more, then we should turn the current citation into a citation cluster. Fix the problem by adding API similar to what commit 24219cc1e9829f82a533667aef0f51b6a7df6fc2 (sw lok, .uno:TextFormFields: expose field code of fieldmarks, 2022-11-25), did: but here we return properties of the innermost fieldmark, not all fieldmarks. Also introduce a ITiledRenderable::supportsCommandValues(), this way next time a command value getter is added in sw/sc/sd, no need to touch desktop/ anymore. Change-Id: I7f1a7064307034a18527ab5e985d2eac56807cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145062 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-05Upgrade external/boost to latest Boost 1.81.0Stephan Bergmann
<https://dev-www.libreoffice.org/src/boost_1_81_0.tar.xz> has been generated (on Fedora 37) with > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.bz2 > $ printf '71feeed900fbccca04a3b4f2f84a7c217186f28a940ed8b7ed4725986baf99fa boost_1_81_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_81_0.html> > boost_1_81_0.tar.bz2: OK > $ external/boost/repack_tarball.sh boost_1_81_0.tar.bz2 > Unpacking boost_1_81_0.tar.bz2 ... > Removing unnecessary files ... > Creating boost_1_81_0.tar.xz ... > Cleaning up ... > 1deb0a5a9e33a6626fcaa1d2efd4c0e74ca2b0eea87c1559e3917f3066b633d6 boost_1_81_0.tar.xz > Done. * external/boost/windows-no-utf8-locales.patch.0, introduced with f046fed2782f0d4244aff719ba70a56399a2583a "Don't ever attempt to initialise a std::locale with a UTF-8 locale on Windows", was presumably obsoleted by <https://github.com/boostorg/locale/commit/f45adfc9b963feacc827c3754e2549dd0cffaecb> "Use UTF-16 <-> UTF-8 codecvt on Windows". * external/boost/libc++.patch.0 was obsoleted by <https://github.com/boostorg/config/commit/f0af4a9184457939b89110795ae2d293582c5f66> "The std lib unary/binary_function base classes are deprecated/removed from libcpp15." * external/boost/0001-Change-mpl-integral_c-to-boost-integral_constant-to-.patch.2 was obsoleted by <https://github.com/boostorg/numeric_conversion/commit/50a1eae942effb0a9b90724323ef8f2a67e7984a> "Change mpl::integral_c to boost::integral_constant to avoid Clang 16 errors when constructing out of range enums (refs #24, boostorg/mpl#69)". * external/boost/0001-Avoid-boost-phoenix-placeholders-uarg1.10-ODR-violat.patch.2 is needed to e.g. avoid > ./.libs/libetonyek_internal.a(libetonyek_internal_la-KEY1DivElement.o):(.bss+0x3e): multiple definition of `boost::phoenix::placeholders::uarg1'; ./.libs/libetonyek_internal.a(libetonyek_internal_la-IWORKFormula.o):(.bss+0x3e): first defined here etc. while building ExternalProject_libetonyek, caused by <https://github.com/boostorg/phoenix/commit/8b6a9c26c115bc2cefea300b5c0abf7edf6dd9b7> "std::tuple support (Resolving #103) (#104)". Change-Id: I48773166d0c50f2850d8bb37fa6215d9e5c0d51d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145044 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-01-05sw doc model xml dump: extract part of SwTextAttr::dumpAsXml() ...Miklos Vajna
... into SwFormatCharFormat(). This allows searching for a style name like Emphasis and search for all uses, even if you're not confident wrt the name due to style name collisions. This also means that the impl details of SwFormatCharFormat now leak less into SwTextAttr. Change-Id: Ifb208d04c938b7070ec94ebe727309bab96266dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145046 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-05sw: add the ColorSet from SdrPage into ColorSets in ThemePanelTomaž Vajngerl
Change-Id: I7c4ef103b2be65a8adbad5d4f00304ee22be668f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143997 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-05Related: tdf#152781 Add also non-on-the-fly IDs to language listEike Rathke
Generating names more than once is unnecessary. This may happen for defined mappings that have no explicitly predefined language list entry. Change-Id: I278e6d77181b661a90d0fb133cb3ca30c2a9b721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-01-04Related: tdf#152781 s/lang-tag of/generated/ in SAL_WARNEike Rathke
Only cosmetical to clarify, if possible a complete UI name is generated, not just the language tag as before. Change-Id: Id38e397793807762c2698948c325e6eeda989cc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145048 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-01-04Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 555355c795f9333735ae897b2eaace4b2ca88534 - Refactor help page Change-Id: I21f37ec313acf91a6e20ae9f1dd828556150a635 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145019 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-01-04Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to fa2f89b91f8f06c44c50b800762ee47006402ddd - tdf#152296 Content Controls Help Pages reviewed - Added content control user guide - Merged control properties pages - New menu commands - Entry in Contents tree Change-Id: If4b550317c1d4cae3a06d8363058a7f3214621a9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144992 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-01-04tdf#149588 pptx import: transparency at SolidFillAttila Szűcs
When copied color (RGB) property from text content to shape, copy alpha component as well. (If text color have alpha component) Change-Id: Ib86c48ab7b2d3c5f9491a2211b05e90b2c2ea10f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145031 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-04Fix typoAndrea Gelmini
Change-Id: Ic5e25545aecc6630da18d4b61217dab11f48470e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145047 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-04move implDrawGradient into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara
Change-Id: I341e0b1e3cccd18193c3f9798b875a709fe4871f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-04move supportsOperation to CairoCommonCaolán McNamara
Change-Id: I754080c322ec76ec8e218f8c97b1649eaf922c74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-04move supportsOperation to X11CairoSalGraphicsImplCaolán McNamara
Change-Id: Ic5a8652857d0104310d1aead8a55d0f053852c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-04sync drawPolyLine impls early returnsCaolán McNamara
Change-Id: I9b7c49d0e4286245979043e1cb21f8b577676f87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144972 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-04always use X11CairoSalGraphicsImplCaolán McNamara
Change-Id: I7971e17eb7eb9778fcc2d3e7c98028c6cd438004 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-04Remove "tr" autocorr entries that correct to itselfJulien Nabet
Change-Id: I969026e5847852a59e429ce5b0bbf491452302c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144921 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Muhammet Kara <kara@libreoffice.org> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-04tdf#152703 Force relayout during live resizing of windowPatrick Luby
During a live resize, macOS floods the application with windowDidResize: notifications so sending a paint event does not trigger redrawing with the new size. Instead, force relayout by dispatching all pending internal events and firing any pending timers. Also, force a repaint of the window after live resizing ends by reposting this notification so that [self windowDidResize:] will be called at least once after live resizing ends. Change-Id: I9d93108c989418bab6d80c7f6afaccc1daaa746e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145042 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-04enable SAL_ENABLE_USE_CAIRO_FOR_POLYGONS pathCaolán McNamara
Change-Id: Id2c8f94986aea0dd7e50b7b3aeaae7770b3e5bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144970 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-04drop SAL_DISABLE_USE_CAIRO_FOR_FATLINESCaolán McNamara
Change-Id: Ic55a117ff1f2b971f2f075d706fd1b182f16ace5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144969 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-04make applyColor staticCaolán McNamara
Change-Id: I69cdc922488351d8bd7c0facf9c7209f56f24291 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145027 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-04use sal_uInt8 for maMatFlagNoel Grandin
which is way more cache-dense than double Change-Id: I04503eb3a4054cce5312a7a0048c9b6679a8fd16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145018 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-04flatten some vcl codeNoel Grandin
Change-Id: I3747c9ccc97ac59a2e41c1fe4427d1a2f458352a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145017 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-06 16:44:50 +0000