summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-11tdf#108299: Limit the size of bitmap created for clipboard...Dennis Francis
to screen size. This is to avoid hang in ScTransferObj::GetData() for BMP/PNG flavors due to unhandled structured exception when opengl is used and user copies full rows in the spreadsheet. Change-Id: Ie2c2205e3f33ef402d31287a6874df87d218bcb3 Reviewed-on: https://gerrit.libreoffice.org/42013 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-11disallow .ui translatable entries without context at checkinCaolán McNamara
Change-Id: Iece6ae3c4eabad4cd113f469495d2c42833a7b92 Reviewed-on: https://gerrit.libreoffice.org/42157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-11tdf#97648 vml import: fix horizontalLine percentageJustin Luth
o:hrpct (horizontal line width as a percentage) was overwriting valid widths with an invalid string since 2012. For some reason, commit 96c7ab19b77c2f90acd4c34552474b0f616f48a7 thought it would be a good idea to set the width as a percent string, even though the code doesn't seem to handle percent strings. (like "100%"). The logic was that since 100% width is saved as nWidth=0 by Microsoft, so it doesn't make a difference. Well, it does make a difference for every other percentage, since nWidth IS provided for those. That width value is the only thing LO can currently handle - it does nothing with the maWidthPercent for these horizontal lines. Saving hrpct to maWidthPercent seems like the proper variable for this data, but once again, this doesn't in fact change much in LO. It certainly doesn't affect the width of the line. Since this patch only affects o:hr shapes, this is a pretty safe change, for the benefit of all <100% o:hrpct's. An "assert false" and "make check" only showed docs containing 100%, width=0 samples. I added a unit test for several other lengths. I also hacked that test to provide a width value for the 100% line - even though that is not natural - just so it can be seen in LO. Change-Id: I9d6ddbbaa99ec8df32abb1047a80522322a1f631 Reviewed-on: https://gerrit.libreoffice.org/42088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-11connectivity DatabaseMetaData: pull out OComponent from OCalc/WriterMiklos Vajna
Only getURL() and getTables() is custom, the rest can be shared. Change-Id: I9d282a30f722bce0c05b37c7d005c84193e01b7c Reviewed-on: https://gerrit.libreoffice.org/42152 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-11tdf#112304 Revert "Watermark: not visible if page background was set"Szymon Kłos
This reverts commit 39c08074a286855dd014ce1c30b8f7ef95b10242. Fixed by: I69517efb7d82acd719d6a27a09ba61554dbf1ec9 Change-Id: Icd45b3f55292670ff7338a367eba212453a0687e Reviewed-on: https://gerrit.libreoffice.org/42155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-11gtk3: flicker-free opengl transitionsCaolán McNamara
leave the GtkGLArea opengl context alone except for the final render into it, create a new context for the slide transitions to play with set up a pair of framebuffers, a scratch one to let the transitions render into, the other to take a snapshot when the transition is finished with it and then tell GtkGLArea we're ready to render it and when the callback comes around copy the snapshot into it. Change-Id: I3515614baf7eea0ff53c46edbaf9cf66f926eef2 Reviewed-on: https://gerrit.libreoffice.org/42144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-11long->sal_Int32 in various Get/SetVersionNoel Grandin
sal_Int32 appears to be the widest type we need here Change-Id: I1859936dbe7b6a95840c638c8ca5d4148849e12d Reviewed-on: https://gerrit.libreoffice.org/42154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-11Missing @since tagsStephan Bergmann
Change-Id: Ic19041193264627baefd487ddd1d3c05088c027e
2017-09-11More clang::*Type vs. llvm::*Type ambiguitiesStephan Bergmann
Change-Id: I21133976793ab018c633dda077029666308526db
2017-09-11clang::Type vs. llvm::Type ambiguityStephan Bergmann
Change-Id: Idba5c15f31b25b86e2bd7b9be348a17c184fec0d
2017-09-11its really the contents we want to redrawCaolán McNamara
doesn't matter in practice though, but change it anyway Change-Id: I9df8304f01c80a899bdd7219fc4ce459bda7de08 Reviewed-on: https://gerrit.libreoffice.org/42065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-11hidpi+gtk3: move setting the opengl slide viewportCaolán McNamara
to when the window size is set, and adjust to gtk3 hidpi scaling factor Change-Id: Id9bd0defd0b6ae640ac57f88133d954202d4bcc3 Reviewed-on: https://gerrit.libreoffice.org/42143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-11clang-tidy modernize-use-emplace in d*Noel Grandin
Change-Id: I79ac90faf24b4c741545e411dbaea7826c2df531 Reviewed-on: https://gerrit.libreoffice.org/42150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-11clang-tidy modernize-use-emplace in editeng..frameworkNoel Grandin
Change-Id: I7739c4f77c856d34f8484754244df13d8fef840e Reviewed-on: https://gerrit.libreoffice.org/42151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-11tdf#46037: Replace ConfigurationHelper with new configuration APIIvan Safonov
Remove all occurences of ConfigurationHelper in /framework/source/services/autorecovery.cxx. com.sun.star.configuration.ConfigurationAccess used only to receive configuration updates. In the second version of the patch corrected the indentation and fdo replaced with tdf in the patch title. comphelper::ConfigurationChanges::create returns shared_ptr, using unique_ptr can result in bugs. Also rebase this patch. Change-Id: I27d34dd4d4b59e2e9cc701d4726bcd7f5fb45b3c Reviewed-on: https://gerrit.libreoffice.org/41477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-11include/oox/export/utils.hxx: make functions constexprMike Kaganski
Change-Id: I7606b54fb7cef831c3f9a8580260aa880c7f4db4 Reviewed-on: https://gerrit.libreoffice.org/42149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-11clang-tidy modernize-use-emplace in c*Noel Grandin
Change-Id: I419d1f67ba301050d05981db2a3d6178878684a9 Reviewed-on: https://gerrit.libreoffice.org/42110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-11cppcheck: knownConditionTrueFalse 'bClip' is always trueJochen Nitschke
always true since initial import in year 2000 Change-Id: I66596f50580d2db29b5aee0617164a56e8635806 Reviewed-on: https://gerrit.libreoffice.org/42146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-11Fix typoAndrea Gelmini
Change-Id: Idbc04f7cdda586fd1505070a38f24f98ad69c0d4 Reviewed-on: https://gerrit.libreoffice.org/42147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-09-10cppcheck: knownConditionTrueFalse 'bTestMerge' is always trueJochen Nitschke
true since introduced in commit 11b5e05a827851e287315345bf563fda7e24d151 Date: Tue Nov 14 14:57:04 2006 +0000 INTEGRATION: CWS aw024 (1.26.134); FILE MERGED Change-Id: I86fd4d203c2c59209b9190faf82e27065d251cd7 Reviewed-on: https://gerrit.libreoffice.org/42141 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-09-10cppcheck: knownConditionTrueFalse 'bRet' is always falseJochen Nitschke
regression of commit 528632660b72b105345945c13c5b68060d94a91b Date: Thu Feb 9 08:52:13 2017 +0200 convert ErrCode to strong typedef Change-Id: I5ce2b7d38c8d71ec40cc8de7c13e8aec637476b7 Reviewed-on: https://gerrit.libreoffice.org/42139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-10cppcheck: oppositeInnerCondition in htmlatr (sw)Julien Nabet
Change-Id: Iee259bfd53177925217836d4e416bf97c8f53893 Reviewed-on: https://gerrit.libreoffice.org/42136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-10tdf#112254: fix memory leak in optaboutconfig (cui)Julien Nabet
Store UserData objects in a member defined as vector of unique_ptr so we're sure UserData objects will be destroyed when out of the scope Change-Id: Ib5494ad563272adcf64035300f3213688437fcfc Reviewed-on: https://gerrit.libreoffice.org/42123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-10iOS, avmedia library depend on autogen flag.jan Iversen
Disabled linking of avmedia if not present. Change-Id: Id64192ec8172d4388b3624b5f832a90f7af1179c
2017-09-10cppcheck: identicalConditionAfterEarlyExitJochen Nitschke
Change-Id: I0c9b2e8e92ae1b439b6df548daecff07714ea1d4 Reviewed-on: https://gerrit.libreoffice.org/42135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-10cppcheck: knownConditionTrueFalse 'bValid' is always trueJochen Nitschke
Change-Id: I3f73641286020a06a605867726d54376c47a06dc Reviewed-on: https://gerrit.libreoffice.org/42134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-10cppcheck: unsignedLessThanZeroJulien Nabet
Change-Id: Ia3880fc200e885ba99ff1fc054b424f486b01d67 Reviewed-on: https://gerrit.libreoffice.org/42132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-10OSL_ASSERT->assert in putG4Bits (vcl)Julien Nabet
Change-Id: Iac93447146ba7d9b3ae7de4eca6fa272b1cc1187 Reviewed-on: https://gerrit.libreoffice.org/42133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-10iOS, make common iOS GCC file.jan Iversen
Combine common parts for iOS files into one Change-Id: Ibbc6cbb69d0521a5b35ac1817c74bff1dccaddf5
2017-09-10tdf#112306: containsSemiMixedTypes is true for blanks-onlyMike Kaganski
Also export containsNonDate Change-Id: I16283a272d51e6c305f8c381c359168c1e3848a8 Reviewed-on: https://gerrit.libreoffice.org/42130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-10Fix double free since 030273e2e28ef9c4d2118ca3851c64498dfe000aTakeshi Abe
Change-Id: I426b0a6cdc11d3dc8660a440b3e5be9cb198d710 Reviewed-on: https://gerrit.libreoffice.org/42129 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-10gpg4libre: use SHA512 digests for GPG signing unconditionallyThorsten Behrens
Change-Id: I2ee6b0ba440a50b4627b3732c52afe08ba02d664 Reviewed-on: https://gerrit.libreoffice.org/42087 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-10gpg4libre: add sha512 supportThorsten Behrens
Change-Id: Ia5ef54e47e8528a33aba83ae2e317fac5cffb428 Reviewed-on: https://gerrit.libreoffice.org/42086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-10liblangtag: pass through debug options to CFLAGSThorsten Behrens
Change-Id: I08ecf01de2a7f32117dc4a3cac3cd782c0c8f83f Reviewed-on: https://gerrit.libreoffice.org/42126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-09tdf#108406 offline help-images helpimg are no longer selectable as iconsetAndreas Brandner
Change-Id: I6733ed2a04c01c288de2cd6af938a6c6ff1b4481 Reviewed-on: https://gerrit.libreoffice.org/42117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-09iOS, update gbuild platformjan Iversen
IOS => iOS added iOS_ARM64 added iOS_X86_64 and iOS_I386 for simulator Change-Id: Ia788765aab4ef51a7cc7c67d5faff1197e90696c
2017-09-09iOS, configure.ac for arm/arm64/simulatorjan Iversen
--host=arm-apple-darvin will set env. to compile code for iPhoneOS 32 bit --host=arm64-apple-darvin will set env. to compile code for iPhoneOS 64 bit --enable-ios-simulator --host=arm-apple-darvin will set env. to compile code for iPhoneSimulator 32 bit host_cpu will be i386 --enable-ios-simulator --host=arm64-apple-darvin will set env. to compile code for iPhoneSimulator 64 bit host_cpu will be x86_64 Change-Id: Ifc51816b2fe727dd05577f021419e35f7ff8eec9
2017-09-09tdf#111894: fix leak memory with PaletteManager with SvxColorListBoxJulien Nabet
m_xColorWindow is made with m_xPaletteManager so reset this last one before disposeAndClear first one By tracing constructor/destructor of PaletteManager, it seems there's no need to call m_xColorWindow.disposeAndClear() in SetSlotId. Change-Id: Ib3c236f8fd7fd12aaa86389f5c4c26fe58ba833e Reviewed-on: https://gerrit.libreoffice.org/42121 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-09tdf#112074 ww8import: replace m_nOrgDxaLeft with GetMinLeft()Justin Luth
Followup to commit 176a723876b0138debb20f824103b2ab0c910401. In those comments (https://gerrit.libreoffice.org/#/c/41664) I said I'd leave the existing use of m_nOrgDxaLeft even though reading through the code suggested GetMinLeft() might be better. Well, round-tripping shows that MSWord properly reads the indent, but LO doesn't - unless using GetMinLeft(). So now I have my proof document and I can make the desired change with confidence. Change-Id: Icbe12b50c4f2dcf3a0d78f87685f1dfba53a375b Reviewed-on: https://gerrit.libreoffice.org/42113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-09-09Fix typosAndrea Gelmini
Change-Id: I9c61f6218977716a94cca9fee228a3f609278529 Reviewed-on: https://gerrit.libreoffice.org/42124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-09Fix typoAndrea Gelmini
Change-Id: I7fe64a0dccdd52550558463b834e31c652ef51ec Reviewed-on: https://gerrit.libreoffice.org/42106 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-09tdf#112133: Polish the visual appearance of the Customize dialogMuhammet Kara
* Vertically align the dual list controls at top and bottom * Vertically center align small controls' captions (search, category) * Vertically top align captions of large controls (description) * Horizontally align captions at the keyboard tab For labels: * Drop all colons * Remove the bold font style at the keyboard tab * Provide mnemonics for all captions with focusable controls (add, remove, insert, modify, reset... but not description) * Take care of unique mnemonics (alt+C = category & cancel) Functional * Disable the description when nothing is to show there (no offline help installed), and inform the user via tooltips Change-Id: I5862f97ec8e5e866f5e56bcdaf386a793f6040d1 Reviewed-on: https://gerrit.libreoffice.org/42099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-09tdf#67770: Config for remembering the last active deckKatarina Behrens
Change-Id: I88751dda9d4aa284b044ca27fd3d6727f34fbcaf Reviewed-on: https://gerrit.libreoffice.org/41876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-09Drop unused ooXMLFileFormat* config keysGabor Kelemen
These are unused since 2013, see: https://cgit.freedesktop.org/libreoffice/core/commit/?id=041d2b88a473cc7ba9b68113f7642dd8417369e4 https://cgit.freedesktop.org/libreoffice/core/commit/?id=abd3338486a515380d50c4ee5f4ab242fb5fd4bd Change-Id: I0265b476797f0be6703fbf710f0baf983c47d489 Reviewed-on: https://gerrit.libreoffice.org/41216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-09tdf#112278: Pivot table: filtering of non-string fields is not exported to XLSTamás Zolnai
It is needed to use the right string representation of field value. During export this representation is available directly, next to the actual value. During import we can use the number format attached to the corresponding pivot field. Change-Id: Ie8f731f6c72d7f55f43c318e52d63dc4e993d9c0 Reviewed-on: https://gerrit.libreoffice.org/42069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-09tdf#108572 remove connections only for current shellSzymon Kłos
Also remove connections to temp files. Change-Id: Ie5c09eb365d1246e053dc52884c72687ac226f3c Reviewed-on: https://gerrit.libreoffice.org/42095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-09Updated coreOlivier Hallot
Project: help 6005c5c31ca8e9f9107c5c0e35858d27e4a55490 Add better support for <bascode> in helponline Insert a div around a code snippet and categorize for schema.org Change-Id: I7d4c9e15fccbf7e48af3c2faca9ed61ae5279c79 Reviewed-on: https://gerrit.libreoffice.org/42105 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-09Avoid underflow of unsigned integer which leads a false error messageTamás Zolnai
Change-Id: Ica65a96efe44fb46e25c224298aaff4cd7a40fa6 Reviewed-on: https://gerrit.libreoffice.org/42120 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-09tdf#112289 OSX fpicker: don't default to trueJan-Marek Glogowski
When LO requests a value for the currently unimplemented GPG encryption checkbox, the Aqua file picker defaults to a "uno::Any <<= true", which triggers the GPG key dialog. This simply returns an empty uno::Any for values of unknown controls, which is handled fine. If something else relies on the current default value, it must to be properly implemented. Change-Id: I3637ca833d59e19416e25f3096bc90a756aa8840
2017-09-08tdf#108722 vcl: fix bugs in TextEngine with TEXTATTR_PROTECTEDMichael Stahl
1. If the cursor is at the end of the paragraph, attributes ending at that position are skipped in TextEngine::FindCharAttrib(). 2. If a TEXTATTR_PROTECTED is found, TextView::KeyInput() retains the selection that was extended to cover the attribute after deleting the text, because it compares to the initial selection. Why delete/backspace keys only work with the "gtk" vcl-plug but not "gtk3", "gen" or "kde4" is a mystery to me. Change-Id: Id7a6f298332f5a99454c793dd2dd6d424a975ad4
generated by cgit (git 2.34.1) at 2025-01-01 20:43:39 +0000