summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-28avoid unnecessary OString to OUString conversionNoel Grandin
speeds up loading some writer files Change-Id: Ia6dddf3a9e8990b8cd3f600c86c758573c7ea2ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-28speedup dynamic_cast to SwTextFrameNoel Grandin
which is a hotspot in loading some documents Change-Id: I7f1c48305cd40bcd9bee4baf219228f10cc297b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-28tdf#135683 speed up layout of large writer tablesNoel Grandin
by making dynamic_cast to some SwTable* types faster Change-Id: I5c5b2525ecfcdf3c0f648f32b4ccc21ba5ac40fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-28vcl: move TextLayoutCache to own module headerChris Sherlock
Add a unit test for TextLayoutClass - it basically tests that script runs work as intended. Change-Id: Ie65acf06f13c89c182d93b20fc9a28866db2330c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115470 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-28tdf#74702 vcl: remove GetOutDevType() from ImplNewFont()Chris Sherlock
Change-Id: I59a14b0c392098761f9304708f4859f7e2381c14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115469 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-28ofz#26357 Infinite loopCaolán McNamara
Change-Id: I914d5c8e53e226567f48b084b1cdb55721a58359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121182 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-28clang-tidy:readability-redundant-member-initNoel Grandin
Change-Id: I48e6fb31df732805423b89ed91b6e4363a69b668 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121150 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-28Fix typosAndrea Gelmini
Change-Id: Ie4e2ef5a884b51250863d3384d5e703232f31258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121179 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-27Remove duplicated includeAndrea Gelmini
Change-Id: I139b584c374cf950d2808777f0a78dbfe99269ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121178 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-27Related: ofz#27296 OOM std::map->std::vectorCaolán McNamara
dbgutil massif peak of 3.1G -> 2.7G GB 3.117^ # | :::::::::::::::::::::::# | ::::: # | :@::::: #: | :::@::::: #: | :::::@::::: #: | :::::::@::::: #:: | :::::::::@::::: #:@ | ::::::::::@::::: #:@: | :::::::::::::@::::: #:@: | :::::::::::::::@::::: #:@:: | :::::::::::::::::@::::: #:@:: | ::::::::::::::::::@::::: #:@:: | ::::::::::::::::::::@::::: #:@::@ | @:::::::::::::::::::::@::::: #:@::@ | @::@:::::::::::::::::::::@::::: #:@::@: | ::@::@:::::::::::::::::::::@::::: #:@::@: | @:::@::@:::::::::::::::::::::@::::: #:@::@: | ::@:::@::@:::::::::::::::::::::@::::: #:@::@:: | ::::@:::@::@:::::::::::::::::::::@::::: #:@::@:: 0 +----------------------------------------------------------------------->Gi 0 116.7 ---> GB 2.718^ : | @######: | @@@# ::: | @@@@# :::: | @@@@@@@# ::::: | @@@ @@@@# :::::: | :@@@@ @@@@# ::::::: | @::@@@@ @@@@# :::::::@: | @@@::@@@@ @@@@# :::::::@:: | @@@@::@@@@ @@@@# :::::::@::: | @@@@@@::@@@@ @@@@# :::::::@:::: | ::@@@@@@::@@@@ @@@@# :::::::@:::::: | @::@@@@@@::@@@@ @@@@# :::::::@:::::@: | @@@::@@@@@@::@@@@ @@@@# :::::::@:::::@:: | @@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::: | @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@:::: | @@@@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::: | @ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@ | :@@@ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@: | @@:@ @ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@:: 0 +----------------------------------------------------------------------->Gi 0 34.29 Change-Id: Id56615e554d07a76a6a87476a40cc6190c0555da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27we are going to remove the entire row anywayCaolán McNamara
so don't iterate over the cells explicitly dropping them Change-Id: If0de504ac9711d1e6a757cdd15574f15585ca928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121180 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27clang-tidy:readability-redundant-member-initNoel Grandin
Change-Id: Ibeff6e5cbc20ab86b1e9cb96292acb340849ede3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121149 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-27Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 04f49b69b26dc5d9cb2939f86b7c10653b7c36e6 - tdf#116576 Fix the description of the PHI function Change-Id: Ia15cadc19186519767044b1d75a5e033f0096ebf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121058 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-27Related tdf#119931 - Fix accessibility warningsHeiko Tietze
Change-Id: I69787778f11217a55daa1489c142561db5efce19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27these checkboxes are being used as labels for the menubuttonCaolán McNamara
so describe that a11y relationship Change-Id: Ia48d928222159399e1f0a3cdd977447b6c861294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121176 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27change the extra config colors to match the application onesCaolán McNamara
these extra ones are dynamically appended to the static set of the colorconfigwin.ui so adapt them to the changes of commit 2f706b1e91396cbe044c20fab79772dfc081a340 Date: Fri Aug 27 11:46:57 2021 +0200 Improve accessibility for application color settings Change-Id: I5a458ea509dfffc147b533d38458465df18869e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121174 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27these GtkMenuButtons need label propertiesCaolán McNamara
Change-Id: If8dc1112115aa6c2f3074d826a26ff1c87568173 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7a0c6f819af67ad51e9d6377119e6ea0d2b50e3f - tdf#118538 Add multivariate regression help page Change-Id: I1f9b2584475e540a70a1643023fe61243ad2c543 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120969 Tested-by: Jenkins Reviewed-by: Steve Fanning <stevemfanning@yahoo.co.uk> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-08-27Rename AsyncColorPicker -> AsynchronousColorPickerSzymon Kłos
Change-Id: If26865ea063df3052e6ba61642fe36f5a1a47929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120735 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-27tdf#128106 sw: copy bookmarks at start if whole node is copiedMichael Stahl
The CrossRefHeadingBookmarks are always at index 0 so copy them if the selection also starts at index 0. This happens in SwDoc::SplitDoc() for the 2nd etc. chapter. Change-Id: I4765d497e65d3c8257f7eab59b8ba2088688967e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121147 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-27tdf#128106 sw: copy bookmarks in SwDoc::SplitDoc()Michael Stahl
Change-Id: Id35b8771b456b162ca653423d02788275a79443f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121146 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-27ScriptForge - (SF_DialogControl) add management of table controls in dialogsJean-Pierre Ledure
With the method SetTableData(), feed a tablecontrol with a sortable and selectable array of data. Columns and rows may receive a header. Column widths are adjusted manually by the user or with the same method. Alignments can be set as well by script. oControl.SetTableData(DataArray, Widths, Alignments) DataArray: the set of data to display in the table control, including optional column/row headers Is a 2D array in Basic, is a tuple of tuples inPython Widths: the column's relative widths as a 1D array, each element corresponding with a column. If the array is shorter than the number of columns, the last value is kept for the next columns. Example: Widths := Array(1, 2) means that the first column is half as wide as all the other columns. When the argument is absent, the columns are evenly spreaded over the control. Alignments: the column's horizontal alignment as a string with length = number of columns. Possible characters are: L(EFT), C(ENTER), R(IGHT) or space (default behaviour) Default: LEFT for strings, RIGHT for numbers Impact on existing properties: ListIndex, Value New properties: XGridColumnModel, XGridDataModel All properties and methods are available from user scripts written either in Basic or in Python. Change-Id: I70582cd0ba48ee3b9b9a292d8a47dbc1229b1fe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121148 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-08-27loplugin:external (macOS)Stephan Bergmann
Change-Id: Iedf17f6e075fb06b767359ad5ffbd3cebbea3188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-27loplugin:nullptr (macOS)Stephan Bergmann
Change-Id: I5fc54c9005fbada4184c520d447276be2df16f0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121142 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-27-Werror,-Wdeprecated-anon-enum-enum-conversionStephan Bergmann
...similar to 5b8f505cd11517362b2c4a29c87d802a286a677d "Avoid -Werror,-Wdeprecated-anon-enum-enum-conversion" Change-Id: Ia9e8994cdb74ecdb078f347c864a89ad40321609 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121143 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-27Fix this FIXMEMike Kaganski
Change-Id: I4449d3c87adbcb94c721799aa6de1d615eb7041f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121070 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-27Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 8e447138612f8e266c8a997813f9f673efa4ebb1 - Create help page about how to Remove Duplicates in Calc This patch creates a new "guide" page on how to remove Duplicate values in Calc. This is a question I see being frequently asked in forums and I could not find any entry in the Help that explained how this can be done. Change-Id: I6e115739752fdc1f5aa35cf45f041655b3e614be Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121067 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-27Improve accessibility for application color settingsHeiko Tietze
* Lengthy grid replaced by some frames * Order of sections updated to show less important on bottom * Accessibility suppressions removed and solved Change-Id: I150603d141961cf579c1853ea3e67499da81c596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121137 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-08-27tdf#137363 DOCX filter: don't loose <w:ilvl w:val="..."> of paragraph stylesMiklos Vajna
This adds doc model, UNO API and DOCX import/export for this feature. The rest is not yet implemented (i.e. no layout, UI, etc.) An alternative would be to grab-bag the list level of paragraph styles, putting it to the doc model directly has the benefit that this is a step in the right direction. Change-Id: Idf7157e8a4177b4c2286d3cfb3d5acf2df845076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121141 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-27tdf#112450 correct points and size for polyline in VML importRegina Henschel
The points in file source might have units. Decode was missing. maWidth and maHeight are used in ShapeBase::convertAndInsert(), and moCoordSize is used in PolyLineShape::implConvertAndInsert(). So ShapeContext needs to provide both in case of importing a polyline. That was missing. Word writes the size into the coordsize attribute of the v:polyline element. But from VML specification it need not exist, but bounding rectangle of points has to be used. That is added too. Unclosed polyline cannot be filled in LO and ODF, a fill is only possible for a closed polygon. LO defines a sequence of points as being closed, if first point == last point. The import is adapted to that behavior. Word allows an unclosed polyline to have filling. That cannot be represented with a simple PolyPolygonShape but would need a CustomShape. Because the user cannot yet edit points in a CustomShape but can do that in a PolyPolygonShape, the v:polyline element is not converted to a CustomShape on import and not to DML on export. LO would first need an UI for editing points of a CustomShape. Change-Id: I23d08fda2005f8b36488e1d9ba32e565d8a0f803 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121042 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-08-27vcl: remove unnecessary OutputDevice::GetGCStackDepth()Chris Sherlock
Change-Id: I067299d028a0f25314a4312462ee8e7d0e1f92bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115464 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-27vcl: move OutputDevice fill functions to fill.cxxChris Sherlock
Add unit test for SetFillColor(), IsFillColor() and GetFillColor(). Change-Id: I64b3b15d6c6a0062af716ecc02d0414ae8a9f134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115461 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-27tdf#116315: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I29aa953d8541d45b003703ba91c143fc9760ceac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121135 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-27Use PSAPI functionality directlyStephan Bergmann
Dynamically trying to obtain the two PSAPI functions was apparently originally done because "This version can fail because PSAPI.DLL is not always part of NT 4 despite MSDN Libary 6.0a say so", according to the comment added with 961512bd9ae008fdd8ab5cdf1ba6b5d25ffb0429 "#94875# Added additional method (for NT4) to determine the module containing an address". (That comment was removed again in 515d2579d305a6127c6c194319a58eac62437e33 "Replace legacy dynamically- loaded functions with statically linked ones", which curiously left the dynamic loading of PSAPI.DLL in place there, though.) <https://docs.microsoft.com/en-us/windows/win32/api/psapi/nf-psapi-enumprocessmodules> states that the PSAPI functionality is available in "Kernel32.dll on Windows 7 and Windows Server 2008 R2; Psapi.dll (if PSAPI_VERSION=1) on Windows 7 and Windows Server 2008 R2; Psapi.dll on Windows Server 2008, Windows Vista, Windows Server 2003 and Windows XP". I do not find any mention of PSAPI_VERSION across our code base, so assume that PSAPI_VERSION=1 would be some legacy mode that we do not use, so with our baseline of Windows 7 (cf. README.md), relying on the PSAPI functionality being available without adding anything specific to gb_Library_use_system_win32_libs,sal should presumably be OK. Change-Id: I55ab29be2a3ee3984c6987e953819cb2e92e4aa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121136 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-27tdf#59820 - Search for the longest substring in a multiline stringAndreas Heinisch
In order to determine the optimal column width of imported ASCII files in the simple text mode, search for the longest substring in a multiline string which is determined by a line break. Change-Id: I2c606dd97549455009b9f8fad2b8ec4386b7b7db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120772 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-08-27tdf#143904 fix direct character formatting copied into paragraph levelBalazs Santha
Currently, Writer copied the direct character formattings, and applied them on paragraph level, when inserting a new row in a table. This bug is a regression from 498d2b82187ec3ff58f076e0d15741e64c0505ba . Explanation, why this regression happened: MSO Word uses a paragraph mark symbol (i.e the control character than can be configured to be shown), which is imported in Writer as a 0-length hint. To fasten up the import of DOCX tables, the core applies the formattings from this 0-length attribute on paragraph level, directly before inserting a new row. All in all, to solve this bug, we needed to make sure, that we only copy the formattings, if it is from a 0-length hint. Change-Id: Iba52e9318cc588feda559339e42897568d009806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120624 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-27Resolves tdf#142115 - Make color of NotesPane customizableHeiko Tietze
* Color follows not Writer's section color and General's object boundary color for the separator line * Section color adjusted to Gray 1 for Dark scheme Change-Id: I5748c1ac3c0a4997edfffac786e3d247641fc637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121122 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-08-27Resolves: tdf#143159 reserve space for 6 characters/digitsCaolán McNamara
Change-Id: I44bcdf55a9b1d34e046b93e6a15f4019a925844d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121119 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27ofz: Integer-overflowCaolán McNamara
Change-Id: I4142f48db0f756872ea75e1c39cda6195bdddf43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27ofz#37660: searching in wrong parent for tableCaolán McNamara
Change-Id: Ifa1b70fa0ccc706cec52b318cdfba59f5da2b4d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27tdf#143940: the style index might be -1Xisco Fauli
Similar to 52aebe6986bcec07071adb3f94d6c09fea147044 < tdf#138466 Crash when creating different scenarios > ExportColumns calls GetStyleNameIndex which might return -1 so check the index is different than -1 as it's already done when calling ScFormatRangeStyles::GetStyleNameByIndex Also move fix for tdf#138466 down the stack to be consistent Debug builds will still assert, see coverity#1438402 Since 5e777f23fd0118f6649f0d9e30eb77a72f1099e4 < loplugin:useuniqueptr in ScColumnRowStylesBase > where the nIndex < 0 check in ScColumnRowStylesBase::GetStyleNameByIndex was removed Change-Id: I084bfa04c39f37cb325c3b3df76801b3abdea994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-27tdf#101083 speed up SVG rendering with pattern fillNoel Grandin
By pushing the work down to the vcl layer, which has much more efficient ways of dump lots of copies of a single image Change-Id: Ie83fa56828df91a23b4b29934360ad80d1793c3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117162 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-27vcl: SvmConverter is only used in vcl filtersChris Sherlock
Change-Id: If198b143d520937193b63985b4c21da0e29308bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120834 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-27sw: remove some unused includesMiklos Vajna
See tdf#42949 for motivation. Change-Id: I7082c51ce73b69f27154fe7308df913a38973100 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121129 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-27Take the PDF graphic rendering DPI into account when exportingTomaž Vajngerl
Change-Id: I1d3465fc7357e6991161d5a96bcd70c53c55f244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121087 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-27backendtest: Test Drawing Bitmap other than 24bpphomeboy445
This test draws bitmap formats other than 24bpp - namely 32bpp and 8bpp greyscale. Change-Id: I1b21214429be08fc7cf1eb086c2ad8946780f481 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119371 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-26Add info on icon sizes for themingOlivier Hallot
Information collected from telegram chat by Rizal Mutttaqin, andreas k, samuel_m, quikee. Change-Id: I0d61f6b899b261478b6d40386ac5604aa1a3cfdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121088 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-26remove unused suppressionCaolán McNamara
Change-Id: Icd46ff6b6ff1ccf6be8248482d9f5fbbce073445 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26tdf#143169 - Remove additional row header widthAndreas Heinisch
If the table control has row headings, add the extra row width only at the beginning of each row and not at the end. Otherwise the renderer of the table control adds an additional column with the width of the row header of the table. Change-Id: I0acb67f21d0ad756ed53c56690d3f2deb50de8e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121038 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-26tdf#139660 one of the group needs to be activeCaolán McNamara
in this case using ToolButtons instead of ToggleToolButtons will work ok Change-Id: I806a8fc409ae346dd6734be13d69c4b171e54c08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121121 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>