summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-10-20ensure solarmutex is locked when closing splashscreen (tdf#137177)Luboš Luňák
AFAICT all drawing is done with solarmutex held, at least Skia asserts that and this case is the only problem I've found. Here the solarmutex is not held because of c5cf78e1529970c04e1999e1 that unlocks it for DeInit(), but that call leads to closing the splashscreen. Change-Id: I453f71cc53fe229e539a862927a58fd4161c40d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104423 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-20clean up handling of the UI Skia optionsLuboš Luňák
Disable the sub-option when the main option is disabled. Enable it for the proper VCL backends ("win" and "gen"). Change-Id: I38c2f605c10eb0f3cfae3f05cd4bada4877cdc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104426 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-20remove ui for 'forceskia' AKA 'ignore skia denylist' (tdf#137159)Luboš Luňák
I originally copy&pasted this from the OpenGL code, but now that I think of it, having an easy checkbox to make LO use drivers that LO decides are faulty is a bad idea. There's still the expert configuration if somebody insists (and if they're not expert enough to find the expert setting then they better not mess with it), but this is asking for unnecessary trouble. This also solves the problem that the UI option is misleading. As the description in Common.xcs says, "This one forces the use of Skia even if the denylist would block the driver.", so the option is independent of the 'enable skia' option, but the UI didn't make it appear so. Change-Id: I74bf3574f16899405272dbb3aec54580a5e3f0bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104425 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-20tdf#128212: sd_layout_tests: Add unittestXisco Fauli
Change-Id: I099969143a25db1a580be5057e136cf05721f270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104560 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-20CppunitTest_svx_unit: directly use asserts hereXisco Fauli
if it failed, it wouldn't be clear why Change-Id: Ib96674a2d243bea946abff429a267c3ce4fc64f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104559 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-20tdf#137608 allow insert break to use a page number > 9999Caolán McNamara
writer is using sal_uInt16 for the page number. If we wanted anything bigger then the max possible sal_uInt16 then we would need to make real changes to writer to change the type. Leaving the type as sal_uInt16 but allowing 65535 then makes it real easy to use the ui to force writer to loop over to page 0 and I can predict the moaning about that. So I propose instead of an arbitrary max of 10000-1 to have an arbitrary max of 65535-10000 for 55535 instead. Change-Id: Id4c244e144f718c8917786cb9846625e4845b65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20Allow to opt in for --enable-gtk3 plus --without-system-cairoStephan Bergmann
This check had been introduced with 5ad60c5d69042a73d7a1632d3c04e15783817db4 "more configure, and scp2 pieces for gtk3 integration", but without stating any reason. In a comment at <https://gerrit.libreoffice.org/c/core/+/104549/1# message-4b5fcbdabf9c7e40782df682d68efb6282b37c6e> "Allow to opt in for --enable-gtk3 plus --without-system-cairo", mmeeks now states: "My recollection is of horrors with the internal cairo being linked before the system one, and being older - such that various gtk3 themes / bits of functionality which would now link to an older (or even newer ;-) internal cairo randomly stop working / crash / burn / etc." However, at least my Linux build appears to work fine with (among others) --enable-gtk3 --enable-gtk3-kde5 --without-system-cairo And that combination proved useful to me when I wanted to run SAL_USE_VCLPLUGIN=gtk3 LO against a libcairo built with ASan the other day. So, while keeping the default of implicit --with-system-cairo if any of --enable-gtk3 or --enable-gtk3-kde5 is (implicitly) set, lets allow to nevertheless explicitly opt in to that combination---with a prominent warning. Change-Id: Ie5231085966a4f3e35b080ca162d8b846cc1ad34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104549 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-10-20add MenuToggleButton for split toggle/menu buttonCaolán McNamara
which is uniquely used in the start center Change-Id: I098e79ce34a9d99f8fb2eccb3dd04fa27e38427b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20fix orientation in vcl::Font<->awt::FontDescriptor conversionNoel
one is in degrees, the other deci-degrees Change-Id: I85270c15f483e959819fcb54d37435388975f766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20cid#1468269 Uninitialized scalar fieldCaolán McNamara
Change-Id: I4457019570571c810265bf721cdefb0bdd65dd7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104551 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20Beautification of code and fix for on-/offline helpHeiko Tietze
Change-Id: I0c731f2c472ceb435f529956011a7fd5a00a27ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104358 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-20tdf#137468: Use the colour space of the main displayLeo Wang
Change-Id: I301dcadcc469c1810e3b64e6fee6b982bebaf040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104477 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-10-20tdf#137468: Restrict window depth to 24 bit RGBLeo Wang
Change-Id: I65c168155092d89d0302043b4052fed2def18c63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104476 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-10-20Do not check for GNU patch utility on FreeBSD.Gleb Popov
While FreeBSD patch is indeed not a GNU one, it is sufficient to build LO. Change-Id: I55783f5bc7b4e2886e31936a317f52916d9a1e5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104519 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-10-20use tools::Long in editengNoel
Change-Id: Ib7014c353489461ad9489d9f3fefd59a32f8f877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104524 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20add GetDropTarget to CustomWidgetControllerCaolán McNamara
Change-Id: I85f2ed6439eb94048ae1fe42448b1906fd060eb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20tdf#133045 sw: add shape alignment to the top page borderSzabolcs Toth
Allow relative alignment to the top page border (the area over PAGE_PRINT_AREA) by adding constant PAGE_PRINT_AREA_TOP to com::sun::star::text::RelOrientation. Fix DOCX shape import of <wp:positionV relativeFrom="topMargin">. Follow-up of commit 6788133b3bdf02097d66a99047aa7bcba3a99a66 (tdf#135720 sw: fix PAGE_PRINT_AREA_BOTTOM alignment with footer) and commit 79107d3f8d10aa0f38641775c5eb47dcfd4fd37e (sw from-bottom relative orientation: add UNO API). Co-authored-by: Balázs Regényi Change-Id: I3a3f7324c0ef8d448526982d3e2f09b67f5fd4d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104113 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-20tdf#137417 oox smartart: avoid considering rules in vertical linear layoutsMiklos Vajna
Regression from commit 0024c48b4822062995effed7db4f1281196384bb (oox smartart: consider rules when scaling in linear layout, 2020-07-31), the problem is that I only tested horizontal layouts and this is not working for vertical layouts. Just disable the vertical case for now, to avoid unwanted side effects. Change-Id: I31a894157996a2371b8d0ec482ee91dc4d5b053e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104541 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-20sw: DOCX export: don't export numPr to style from outline numruleMichael Stahl
8e9e705de29a1a3d9b964c9350aa2a3a17cce6f9 disabled this for paragraphs but it appears to be unnecessary for styles as well, since w:outlineLvl will be produced, and Word displays bullets active in the UI if numPr exists. Change-Id: I60f7cf6359b27a4d69450752fbc4de6595d98761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104539 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-20tdf#137594 prevent converting unallocated columns.Mark Hung
Check col against GetAllocatedColumnsCount() instead of MaxCol(). This prevents allocating a new column just for converting an empty cell. Change-Id: I5c8dcfffc2661ab9c4fd9c2c53ed389e57351517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20tdf#133931 Qt5 set the themed AlternatingRowColorJan-Marek Glogowski
Change-Id: I6a4a0f90239686ff1c94e1a550540223324184e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104540 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-20remove unnecessary `if (!true) return;` statement from Desktop::Init()Platon Pronko
Seems that this specific piece of code was introduced in commit bc66bf4608557d757555aef1f46abf8a15c3538b by Noel Grandin, where `if (true)` wrapper was removed and `if (!true) return;` seems to have been left over. But the original `if (true)` statement was introduced in commit 4d258787559426e1e2a0279888eb669622889899 by Michael Meeks, where `if ( m_aBootstrapError == BE_OK )` before starting IPC thread was replaced with `if (true)`. I asked on IRC and they were not sure for the reason of this change, so I will add Michael Meeks as a reviewer of this patch, just in case. Change-Id: I1ffb781464fa2fde152eb21bc61e4b244e8812d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104530 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2020-10-20use tools::Long in swNoel
Change-Id: I44be72b3a9b14823ec37a3c799cffb4fb4d6e1de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20use tools::Long in scNoel
Change-Id: I8f37a8d1174ed816df971b8cee036d4e88d4a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20fix font orientation conversion in VCLUnoHelperNoel Grandin
css::awt::FontDescriptor uses degrees, while vcl::Font uses deci-degrees Change-Id: I72265ea6385bc61db99ee9a6bb392dab2cb1ab3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20Unbreak nss build for the native arm64 on an Apple Silicon MacTor Lillqvist
I had managed to break it with 92b99bddb63b1bf4a639fc969727ac35b3ed1ac8 that made it possible to build for (Rosettafied) x86_64 on an Apple Silicon Mac. Change-Id: I337f2a8e777394e586f659fadd819cf7dfc0a332 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104546 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2020-10-20xmlsecurity: handle MDP permission during PDF verifyMiklos Vajna
Change-Id: I626fca7c03079fb0374c577dcfe024e7db6ed5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104529 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-20sw reqif-xhtml export, embedded objects: handle non-package Ole10Native streamMiklos Vajna
Commit 1392fd6a7eaf9f507639096984c2a0108f254795 (sw reqif-xhtml export, embedded objects: handle Ole10Native stream, 2020-04-30) added support for handling an OLE1 stream which contains something other than OLE2 data. However, that assumed a fixed class name ("Package") and a matching class id. Fix this, similar to how the import side was fixed with commit 247b247dadc8f0133a8eb94f1423a29315cf998a (sw reqif-xhtml import, embedded objects: handle non-package Ole10Native stream, 2020-10-16). Change-Id: If2ec9434c802e23e395cf2a6eaf63ad5b1db9c1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104531 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-19clang-cl: Adapt Windows-specific code to extended loplugin:cstylecastStephan Bergmann
...after 1ebeacb20ad0165e399629fcfd7795ad0da3edf8 "Extend loplugin:cstylecast to certain function-style casts" Change-Id: I99bd383f5b3bee861d442d2e1be6ecd356b78315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104523 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-19use tools::Long in vclNoel
Change-Id: Ice1055021e8568634e9a66ba89d3bb4ef4e731df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19use tools::Long in svtoolsNoel
Change-Id: I2b26da23e625e643dc2bb5393abff3671c457884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19UNOTOOLS : remove unused include since 54cbe9458033f50d9f608b1462d65e8514cbb636Arnaud Versini
Change-Id: I48ffb5454727518217dcfa60a34ece6f459341f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104521 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2020-10-19tdf#137495 add "tooltip" to "Fax" label in Options - Writer - PrintSeth Chaiklin
Change-Id: I3c9b97956d4d0920f74bf5be967cabaefbc6dcf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104494 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-10-19tdf#137585 Chart ODF: fix export of DataLabelPlacement::CUSTOMTünde Tóth
Saving .ods, the DataLabelPlacement::CUSTOM converted to the default "avoid-overlap" instead of the requested "outside". Follow-up of commit 20da1a5dd37c7edac620566c992d5a53b23a5f12 (tdf#134978 Chart OOXML Import: fix pie chart label custom position) Change-Id: Ib15c7f24e0a650c84e6afce08b84e7eece8dafea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104430 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-19use tools::Long in svlNoel
Change-Id: Ic63d3c0ebd1e58d7bab5b0fd6313cabddc16eb98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19tdf#116675 vcl tree list: toggle by label click (e.g. in AutoFilter)Attila Szűcs
Checkboxes in a tree list could be toggled only by clicking on them, but not on the associated labels, despite UX guidelines and interoperability requirements especially for AutoFilter usage in the spreadsheet. Note: Implemented only for generic VCL plugin. Testing on Linux: SAL_USE_VCLPLUGIN=gen instdir/program/soffice Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ibc3d42271a1be53a54e11dedf4ab3ab506d680cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104414 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-19tdf#136073 combine glow and softedge sidebar sectionandreas kainz
Change-Id: I19381009f5b286b051ae0cb90a794ed51a413a7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103835 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-10-19tdf#134121 pie chart: add leader linesTünde Tóth
to data labels with custom position. See commit 769433ad93040bc81f06672c8a2c01e2b76fece3 (tdf#90749 chart: add leader lines to custom data label positions) Change-Id: If5d912cc04993e59bd5ab93b644ea49ba8642b49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104410 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-19add tools::Long typedef and use it in toolsNoel
first step to switching long to a 64-bit type on 64-bit windows Change-Id: I640d807426dfe713c7a8984ef560575f8288dbeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19tdf#136983 partial revert NFC ww8 cleanup: remove unused variablesJustin Luth
This is a partial revert of LO 6.2 commit 2ec0cf500222aef55d02df80154b47fbb92970c9 I can't think of any excuse for how I possibly missed that xDocProps was being defined/used outside of this clause. Just plain stupid and blind. The good news is that the create and modified date still seem to be getting saved somehow/somewhere. So it isn't the disaster that it looks like it could have been. Change-Id: I72ef56fa50b9e92e4ce687b132b1919cfae6c1f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103565 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-10-19tdf#127047 fix printing very large font sizes to pdfNoel Grandin
The clamping of font sizes was done in #i47675 and #i95867 to deal with issues in the Windows font libraries which are presumably no longer a problem. Change-Id: I124a3ff746953ce4d7d934506e76e6d0cba48307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19Simplify single-wchar_t LPCWSTR argument to ExtTextOutWStephan Bergmann
Change-Id: I5c66408297ab03da29494d00ce222b3ef1e0ef13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104515 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-19tdf#90104 XLSX export: fix commas in data validation listTibor Nagy
Comma was exported as list separator instead of decimal separator, messing up the data validation list by breaking integer and fractional parts of a number to two integer numbers, for example the 2-item list 1,5, 2,5 to the bad 4-item list 1, 5, 2, 5. Note: for testing with numbers, it needs to set decimal separator to comma in locale settings. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I6133c402b47aab8ed9f02b412762404fc520badc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104240 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-19fix possible SIGSEGVNoel
after commit 8f54136caa786523fd224f6c98fc8e7c45cd805d use std::unique_ptr for SalLayout Change-Id: If1a0af9924a185694489b7f31f9e71495f2cb77b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104513 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19sw: prefix members of SwFlowFrame, SwXLinkTargetSupplier, ...Miklos Vajna
... SwXOutlineTarget and SwXTextDocument See tdf#94879 for motivation. Change-Id: Ic8f8f5f544dd93e6d9c6764ec53e58c5975598a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104512 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-19fix typoNoel
after commit 648d9892e8a85606c060e050e31251357dcff44b remove thread-unsafe static buffer Change-Id: Ida9065664bf9237b3631e3b864a510d765365b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104511 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19ofz#26480 validate WW8PLCFpcd is sorted like WW8PLCF doesCaolán McNamara
Change-Id: I11393c730986585aeea229ebeec6417e4a0578d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104510 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-19Add FreeBSD to the list of OSes that have OpenSSL in its base.Gleb Popov
Change-Id: I9ebbaf78c06e23f1fc44d9b97547c0a5c990cd11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104482 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-19tdf#137154 pie chart: improve Outside position of data labelsTünde Tóth
Some pie chart data labels were too close to the pie with Outside placement. Change-Id: I0eecdfc32601bdfa8bb3115183f9ca723a9f945b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103683 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-19Resolves: tdf#137495 add colon for "Fax" in Writer Print Options dialogSeth Chaiklin
Change-Id: I710669d8ed205aae30a63134c73b20fb6b2a52eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104340 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>