summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-10-22tdf#161625 Use SolarMutex instead of std::mutex in ExtMgrDialogMichael Weghorn
Instead of using a custom (non-recursive) std::mutex in the extension manager dialog, hold the (recursive) SolarMutex instead. As the backtrace in attachment 197155 in tdf#161625 (s.a. below) shows, a recursive mutex is needed: dp_gui::ExtMgrDialog::TimeOutHdl (frame 17) locks the mutex, then dp_gui::ExtMgrDialog::startProgress (frame 6) wants to lock it again, causing a deadlock. (Switching ExtMgrDialog::m_aMutex to be a std::recursive_mutex could be an alternative, but follow the common pattern of holding the SolarMutex while doing UI stuff instead.) Somewhat similar commit: commit 406a7e9d452201f3fd53abc770da6eb9589fff92 Date: Wed Jul 10 12:46:50 2024 +0200 fix locking in UpdateRequiredDialog Backtrace of deadlock: #0 0x00007f883f6adc70 in ?? () from /usr/lib/libc.so.6 #1 0x00007f883f6b4b01 in pthread_mutex_lock () from /usr/lib/libc.so.6 #2 0x00007f87f3ea068e in __gthread_mutex_lock (__mutex=0x5782aab26e48) at /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/14.2.1/../../../../include/c++/14.2.1/x86_64-pc-linux-gnu/bits/gthr-default.h:762 #3 std::mutex::lock (this=0x5782aab26e48) at /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/14.2.1/../../../../include/c++/14.2.1/bits/std_mutex.h:113 #4 std::unique_lock<std::mutex>::lock (this=<optimized out>) at /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/14.2.1/../../../../include/c++/14.2.1/bits/unique_lock.h:147 #5 std::unique_lock<std::mutex>::unique_lock (__m=..., this=<optimized out>) at /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/14.2.1/../../../../include/c++/14.2.1/bits/unique_lock.h:73 #6 dp_gui::ExtMgrDialog::startProgress (this=0x5782aab26de0, _bLockInterface=0x80) at /home/user/libreofficetwo/desktop/source/deployment/gui/dp_gui_dialog2.cxx:779 #7 0x00007f883b4080a1 in Link<void*, void>::Call (this=0x7f86b0000c08, data=0x80) at include/tools/link.hxx:111 #8 ImplHandleUserEvent (pSVEvent=pSVEvent@entry=0x7f86b0000c00) at /home/user/libreofficetwo/vcl/source/window/winproc.cxx:2285 #9 0x00007f883b40616a in ImplWindowFrameProc (_pWindow=0x5782a76df9f0, nEvent=SalEvent::UserEvent, pEvent=0x7f86b0000c00) at /home/user/libreofficetwo/vcl/source/window/winproc.cxx:2849 #10 0x00007f883b6c711e in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const (this=<optimized out>) at /home/user/libreofficetwo/vcl/source/app/salusereventlist.cxx:119 #11 SalUserEventList::DispatchUserEvents (this=0x5782a62edb08, bHandleAllCurrentEvents=false) at /home/user/libreofficetwo/vcl/source/app/salusereventlist.cxx:120 #12 0x00007f8833fb7827 in QtInstance::ImplYield (this=this@entry=0x5782a62edad0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:447 #13 0x00007f8833fb9e11 in QtInstance::DoYield (this=0x5782a62edad0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:469 #14 0x00007f883b70fc72 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:385 #15 Application::Yield () at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:473 #16 0x00007f883b486415 in ProgressBar::SetValue (this=<optimized out>, nNewPercent=<optimized out>) at /home/user/libreofficetwo/vcl/source/control/prgsbar.cxx:199 #17 0x00007f87f3ea14ca in dp_gui::ExtMgrDialog::TimeOutHdl (this=0x5782aab26de0) at /home/user/libreofficetwo/desktop/source/deployment/gui/dp_gui_dialog2.cxx:976 #18 0x00007f883b6ff8c7 in Scheduler::CallbackTaskScheduling () at /home/user/libreofficetwo/vcl/source/app/scheduler.cxx:509 #19 0x00007f8833fd4013 in SalTimer::CallCallback (this=0x5782a77b83d0) at vcl/inc/saltimer.hxx:53 #20 QtTimer::timeoutActivated (this=0x5782a77b83c0) at vcl/qt6/../qt5/QtTimer.cxx:51 #21 0x00007f88341a3397 in ?? () from /usr/lib/libQt6Core.so.6 #22 0x00007f88341ab5e5 in QTimer::timerEvent(QTimerEvent*) () from /usr/lib/libQt6Core.so.6 #23 0x00007f883418d859 in QObject::event(QEvent*) () from /usr/lib/libQt6Core.so.6 #24 0x00007f8832efc8cc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQt6Widgets.so.6 #25 0x00007f8834145aa8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/libQt6Core.so.6 #26 0x00007f88342c7658 in QTimerInfoList::activateTimers() () from /usr/lib/libQt6Core.so.6 #27 0x00007f88343a9f99 in ?? () from /usr/lib/libQt6Core.so.6 #28 0x00007f8837877299 in ?? () from /usr/lib/libglib-2.0.so.0 #29 0x00007f88378d9ec7 in ?? () from /usr/lib/libglib-2.0.so.0 #30 0x00007f8837876795 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 #31 0x00007f88343a82bd in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt6Core.so.6 #32 0x00007f8833fb789d in QtInstance::ImplYield (this=this@entry=0x5782a62edad0, bWait=<optimized out>, bHandleAllCurrentEvents=<optimized out>) at vcl/qt6/../qt5/QtInstance.cxx:458 #33 0x00007f8833fb9e11 in QtInstance::DoYield (this=0x5782a62edad0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:469 #34 0x00007f883b70fc72 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:385 #35 Application::Yield () at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:473 #36 0x00007f883b70fb90 in Application::Execute () at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:360 #37 0x00007f883f8e1770 in desktop::Desktop::Main (this=0x7ffc2a5b0d28) at /home/user/libreofficetwo/desktop/source/app/app.cxx:1691 #38 0x00007f883b717e1e in ImplSVMain () at /home/user/libreofficetwo/vcl/source/app/svmain.cxx:228 #39 0x00007f883f90ef8a in soffice_main () at /home/user/libreofficetwo/desktop/source/app/sofficemain.cxx:121 #40 0x000057829d6f683b in sal_main () at /home/user/libreofficetwo/desktop/source/app/main.c:51 #41 main (argc=<optimized out>, argv=<optimized out>) at /home/user/libreofficetwo/desktop/source/app/main.c:49 Change-Id: I96d746eb1493aaf5b56d50664c9d1817699f21bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175298 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-22tdf#130857 qt weld: Declare support for "Word count" dialogMichael Weghorn
Add .ui file of Writer's "Tools" -> "Word Count" dialog to the list of files supported by QtInstanceBuilder. This means that native Qt widgets are used for that dialog now by the qt5/qt6 VCL plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set. Change-Id: Id25d0de657dfa9acbc0d71cc3a851b2eb17c6059 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175367 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-22tdf#130857 qt weld: Evaluate grid positionsMichael Weghorn
Implement handling for the "left-attach" and "top-attach" packing properties of "GtkGrid" children, which describe the column and row of these children within the grid. Introduce a new static helper method QtBuilder::applyGridPackingProperties that implements the handling for QWidget children for now. (Support for QLayout items within a grid will have to be added later in order to supported cases where e.g. a "GtkBox" is located inside of a "GtkGrid" in a .ui file.) In order to move the item to the proper position within the grid, first locate it to determine it's current row and column index, remove the item from the layout, and re-insert it at the new position. While this might not be the most efficient way of doing this, it is fairly easy to implement, without having to change the overall approach that QtBuilder, VclBuilder and the WidgetBuilder base currently process .ui files. This is sufficient for Writer's "Word Count" dialog, for which support will be declared in an upcoming commit. Change-Id: Ia296373c408e6cd84ffcc29b9d9a03d3c2441816 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175366 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-22tdf#130857 qt weld: Create QGridLayout for "GtkGrid"Michael Weghorn
Create a QGridLayout [1] when encountering a "GtkGrid" object in a .ui file. This will be needed e.g. by Writer's "Tools" -> "Word Count" dialog. With this commit in place, adding "modules/swriter/ui/wordcount.ui" to the list of supported .ui files in QtInstanceBuilder::IsUIFileSupported would already result in each of the labels in the dialog showing up, but each one as a single row rather than they being properly arranged in rows and columns. (That will be handled in an upcoming commit.) [1] https://doc.qt.io/qt-6/qgridlayout.html Change-Id: Ib9a9de4aa2820ac7e6771acf884072768508fe59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175365 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-22Simplify a bitMike Kaganski
Change-Id: I224602738ce41529cc5eca681f09db31241a5cac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175385 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-21don't need to const_cast away constness for SdPageCaolán McNamara
Change-Id: I44fd36841319eeb3deda7becaf04ec3188586788 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175368 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21Optimize JsonToPropertyValues a bitMike Kaganski
1. Make it take string view: helps to avoid extra string allocation e.g. in desktop::jsonToPropertyValuesVector, and will help more, when C++26 stringstream ctor taking string view is available. 2. Factor out a function taking boost::property_tree::ptree, making implementation simpler for [][]com.sun.star.beans.PropertyValue and []com.sun.star.beans.PropertyValue, without writing a child node to a JSON string, and parsing it again. Change-Id: I16ac2641633ea67a7c9c054c9df09a790500e6fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175361 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-21tdf#163486 PVS: deprecated functionXisco Fauli
https://stackoverflow.com/questions/20711740/gtk2-g-thread-init-deprecated V1109 The 'g_thread_init' function is deprecated. Consider switching to an equivalent newer function. Change-Id: Idb3cdf277d9be0bcf73b4329d3504f6355a8001c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175339 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-21tdf#163543: check GetDocShell()Xisco Fauli
Similar to commit c5f4fe10589acff4d253cc3d32acaf67c7456bd7 Author: Caolán McNamara <caolan.mcnamara@collabora.com> Date: Thu Oct 3 15:14:05 2024 +0100 check for null DocShell before deref Change-Id: I910fb934a36b0e68fd8bda59516c21aa9d27d09a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175338 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21improve style searching in SvXMLStylesContextNoel Grandin
We can searching without needing a std::map by sorting the style list. Which also allows to do prefix searching. Which we can use to dramatically reduce the number of styles we need to loop through in SdXMLStylesContext::ImpSetGraphicStyles. a similar mega-master-page scenario as reported in tdf#158773 13.5 - 9.1s Needed to adjust some unit tests because the order of iteration through styles is now different, which affects some file output. Change-Id: Ia7240fe520b70839d2519eba1fb70819a3c3bf81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175281 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-21starmath: prefix members of SmSymbolDialogXisco Fauli
Change-Id: I36430aa29665fea575633be6ab9e05aeede0c70a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175333 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21tdf#163486 sw: PVS: identical sub-expressionsXisco Fauli
Since commit 47889e229cd51dd8a019d41dace6572e84771d18 Author: Thomas Lange <tl@openoffice.org> Date: Mon Sep 28 10:46:54 2009 +0000 158766 avoid duplicating symbols in the catalog V501 There are identical sub-expressions to the left and to the right of the '==' operator: aSymSetName == aSymSetName Change-Id: If204238eb0fca958e075ebb2ff4f3ad13a55630f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175332 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21tdf#163484 Treeview not maximized in the StyleListNoel Grandin
regression from commit 7f42f031ed1b9f374f3fcba9c814dc5862492026 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Oct 10 09:39:14 2024 +0200 tdf#100894 speed up style tree creation Change-Id: I953c2765090cfa56c7926c4cc10534f6ce60237b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175330 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-21tdf#163486 sw: PVS: identical sub-expressionsXisco Fauli
Since commit 22dac22fe256b28b78c8e0783f2625aee0f75ace Author: Winfried Donkers <winfrieddonkers@libreoffice.org> Date: Thu Mar 27 13:33:15 2014 +0100 fdo#73147 add Excel2010 functions NETWORKDAYS.INTL and WORKDAY.INTL and later changed in commit 80f28e377db0ca04da57eed77d42f44cbdea363d Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri May 29 11:36:45 2020 +0200 loplugin:simplifybool in oox..sd V501 There are identical sub-expressions 'nRef >= nMax' to the left and to the right of the '||' operator. Change-Id: I78a36012dad89afa9980fcfd62772873817d871b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175327 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-21tdf#145161: Change image compression dialog stringAditya Sahu
Since image compression does not always reduce image resolution, change the misleading label from "reduce image compression" to "change image compression". Change-Id: I9d2ab6c1d6409cdad32d4bf801a33f26cbba2f5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175260 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-10-21drop StyleSheetCreatedNoel Grandin
the only place that references it, effectively ignores it. I cant find anything that really uses it, as far back in the git history as commit 59bb5ba445352f88e3ac2d00a5dc3f9bb872326a Author: Vladimir Glazounov <vg@openoffice.org> Date: Wed Apr 11 18:36:28 2007 +0000 INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED when it was introduced. Removing this removes a bunch of expensive broadcast operations. a similar mega-master-page scenario as reported in tdf#158773 20s -> 17s Change-Id: I84ee269aa0ea96e9f77601b01d4795edd3294044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175175 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-21only set parent style name if necessaryNoel Grandin
a similar mega-master-page scenario as reported in tdf#158773 17s - 13.5s Change-Id: Ic20fc0a269ce59094732b1ea5292b24a18777a2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175180 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21set master slide name at creation timeNoel Grandin
which avoids some expensive broadcasting when the name is changed a similar mega-master-page scenario as reported in tdf#158773 48s -> 20s Change-Id: Ifcfd96077a9e83868ac96671ce9f208ae3ca418f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175126 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21tdf#163486: PVS: identical sub-expressionsXisco Fauli
Since commit b7d2a9c824aca1a4dfd1b857a3620e73ade6bc0d Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Oct 27 17:55:59 2023 +0200 tdf#135586 sw a11y: Use BLOCK_QUOTE role for "Block Quotation" para V501 There are identical sub-expressions 'xParaContext->getAccessibleRole() == AccessibleRole::PARAGRAPH' to the left and to the right of the '||' operator. Change-Id: I2c0c843c492aeffb2b1506821796d39804d01343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175329 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-21tdf#163486: PVS: Two similar code fragments were foundXisco Fauli
Since commit 44569a657c4282757443ae06efc6441e571a0409 Author: Release Engineers <releng@openoffice.org> Date: Thu Jul 2 19:17:43 2009 +0000 CWS-TOOLING: integrate CWS bubblechart V778 Two similar code fragments were found. Perhaps, this is a typo and 'xValuesX' variable should be used instead of 'xValuesY'. Change-Id: I8a3515e2c3de97f82547786a8428f47c503335ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175321 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-21sfx2: check mpViewShell in another placeXisco Fauli
After commit 3cc367f426506e3165dda06feeb20e0a9b4c6194 Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Fri Oct 18 16:40:05 2024 +0200 tdf#163486: PVS: check mpViewShell Kudos to M. Kaganski Change-Id: Id1cfed6f199394720336581c87d11125cd147734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175328 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21tdf#163486 sw: PVS: identical sub-expressionsMichael Stahl
Copypasta in commit c799de145f7e289f31e3669646e5bd12814e6c5e, we want to compare the rows where the 2 objects are anchored. Change-Id: Ifdf267b8d70d6410ce50a507783d284ac128c1aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175326 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-10-21lok: enable additional transition uno commandsJaviya Vivekkumar Dineshbhai
Change-Id: I424f08cf6b7ffba54ff3e20b9a8a49c20c7dcd40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175295 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-21tdf#163486: PVS: Two similar code fragments were foundXisco Fauli
commit 14a73d8de3f04e3087a8c2872cd1c53096f605ba Author: Ivo Hinkelmann <ihi@openoffice.org> Date: Wed Jul 16 12:35:11 2008 +0000 INTEGRATION: CWS tl55 (1.13.50); FILE MERGED V778 Two similar code fragments were found. Perhaps, this is a typo and 'm_xGCIterator' variable should be used instead of 'm_xLngSvcMgr'. Change-Id: Ic8df89aa951761903d955c4b571bd0b70829ad3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175300 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-21tdf#163486: PVS: duplicated itemsXisco Fauli
Since commit f1ec5dcfca45e9623d3da05503353df63e8dba4f Author: Rohit Deshmukh <rohit.deshmukh@synerzip.com> Date: Mon Jan 6 11:26:46 2014 +0530 fdo#69616: Fix for VML part missing for group. V766 An item with the same key 'u"ooxml-rect"' has already been added. Change-Id: Iaf14b61d596102c18033a763f8a357d242760f69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175325 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-21Resolves tdf#163515 - Basic Macro Organizer: After renaming aJim Raykowski
document macro library the original library also remains Change-Id: Ife89e1e164d288702d30e6b79f5e703ab9467e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175182 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-10-21tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 80, 86 Change-Id: I4f857ebdd950af1f52bea59a07b8846efcf89ae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175280 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21tdf#151941: Show Alt_Shift_P as shortcut key for Page StyleAditya Sahu
In Writer the Tools>Customize>Keyboard list did not show attribution for Alt_Shift_P which is the binding for Page Style dialog. The reason for this was that .xcu node for the shortcut was part of Global node. Change the Accelerators.xcu file to Modules node particularly, under TextDocument com.sun.star.text.TextDocument. Change-Id: I997c4e6dd292c46fe067a59f0309681d6c346a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175249 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-10-21tdf#163551 fix filter comments by author bugMohit Marathe
This patch fixes the bug in which you have to reset the date filter for filter by author to work i.e. when switching the filter from one author to another Change-Id: Ib5d3bebf587c0e940d4984dd78f9d4a94f5cbb06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175189 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-10-21tdf#163486: PVS: Two similar code fragments were foundXisco Fauli
Since commit 4c2701d4cc8b27eed56172b4188b61efb8783c55 Author: Vladimir Glazounov <vg@openoffice.org> Date: Tue May 22 17:53:11 2007 +0000 INTEGRATION: CWS chart2mst3 (1.1.4); FILE ADDED V778 Two similar code fragments were found. Perhaps, this is a typo and 'xValuesX' variable should be used instead of 'xValuesY'. Change-Id: I24a904ee2e0fa81eb50756545d4b1127b93579fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175322 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21tdf#163486: PVS: unused nested loopXisco Fauli
Since commit 75f0c33a051cb7a0f7665010c4bb8ff015211a3b Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Tue Jul 5 04:21:41 2011 +0200 change from manual loop to ScMarkData::iterator in calc/source/core The 'i' counter is not used inside a nested loop. Consider inspecting usage of 'k' counter. Change-Id: Ia7d1aeae86fda108f97c03f6e5ea7724d6542578 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175290 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21In MSVC, non-static constexpr objects are initialized at run-timeMike Kaganski
Similar to commit c785399884650fd0a1a4ffc3008fbb665e47a9d3 (In MSVC, non-static constexpr objects are initialized at run-time, 2024-09-04). Change-Id: Id1c9ca961efdcbfd897a03e4f85869a6f4e5260b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175297 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-21cid#1608255 silence Overflowed constantCaolán McNamara
Change-Id: I3b518782a82bd1f066a36c87d1a52e5e44e4abda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175259 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 194, 200 V1037 Two or more case-branches perform the same actions. Check lines: 796, 800 V1037 Two or more case-branches perform the same actions. Check lines: 804, 810 Change-Id: Icef65820f99405ca78d31dc9e1afc0a9d5c6b355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175279 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21Support FixedCellHeight in SdrAutoFitTextPrimitive2DArmin Le Grand (allotropia)
That was missing with the result that for some cases the painted text (where it was missing) differed from the text in EditEngine mode (was set there). Change-Id: I23ddf8e90be2335c56e5a485308c753dfe72a878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175127 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-10-21svx: prefix members of Viewport3DMiklos Vajna
See tdf#94879 for motivation. Change-Id: Ice9c1353d3411146f11d4ca34eb6369403cd4094 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175294 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-10-21Document LIBO_TEST_DEFAULT_DESKTOP environment variableMike Kaganski
As defined by commit 69586e8381037417d106d8474d9f73638c5b9c55 (UI tests: use a dedicated desktop on Windows, 2024-07-17). Change-Id: Icd4ad6dfa95301fc1f6e699349278d3a0198fd08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175296 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b1d8f7ad81193f3a7ef7b5358edafcbf82cf604c - tdf#134503 precisions on Option Explicit statement Change-Id: Ic9f0efe82bf42e4e6abf492a2933cddef317cf2b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175304 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-10-21fix(lok): Expose the import options dialogSkyler Grey
In a very similar way to the character encoding dialog, handled in Ibd36e695e733e07053bb6e22a510ac988be3ded2, we need to see this dialog before the document opens. I've used the same trick, where I've made the dialog into a JSDialog and registered an early listener, but I haven't asynced it as it's never useful to have more than 1 person using it at once. Change-Id: I1a61660523ae2d4812890b62d16f0e6cef133e67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174269 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 335bb5b39c03b7ef7d7426259b41d479ff9ea7f0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174951 Tested-by: Jenkins
2024-10-21fix(lok): Expose the character encoding dialogSkyler Grey
The character encoding dialog appears when importing a dialog with an ambiguous character encoding. At the point when it appears, the document isn't loaded, so we have to handle it in a similar way to the text import dialog or password prompt dialog, allowing it to function early. It's also required to make the dialog into a jsdialog, as tunneled dialogs do not work this early in the document loading process. I have not asynced the dialog here because there's no point. I did write code where I set up a dialog factory to do this similar to how other modules (sw, sc, sd, etc.) handle dialogs and make them async. Unfortunately, this dialog is not useful with multiple users, since as it's used on opening a document. It may, in the future, be useful to someone to make a patch that asyncs the other writerperfect dialog (epub export) so I have uploaded and abandoned my dialog factory patch as Id8ec474510f3c8637639ad59331156c6e75dafb4. Documents that require this dialog, whether async or not, cause crashes when someone opens the document before the first person has finished responding to this dialog. I still consider this behavior better than crashing whenever we attempt to show this dialog at all. Change-Id: Ibd36e695e733e07053bb6e22a510ac988be3ded2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174044 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 283f771b92a14c06871c931b01174622b855abe5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174950 Tested-by: Jenkins
2024-10-21Make tools::Time ctor taking sal_Int64 privateMike Kaganski
This ctor is meant to set the value of nTime directly; and that value is not nanoseconds, but an encoded value, using SEC_/MIN_/HOUR_MASK. But in some places, this ctor was misused for setting of nanoseconds, which would only accidentally work for values less than one second. All places that initialized tools::Time with 0, now use EMPTY. This makes the ctor private; and for the very few cases where really the encoded value of nTime is stored / restored, fromEncodedTime is introduced. Change-Id: I1f1994bd9aab1b51a41b1de637619049fe820da4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175283 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-21cid#1633189 silence Unchecked return valueCaolán McNamara
and cid#1633190 Unchecked return value cid#1633191 Unchecked return value Change-Id: I4589ed1fe48067f493a1db04a468b7a8ed6ae178 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21a little more natural to unconditional iterate after useCaolán McNamara
Change-Id: Iac0adfdc9344b5c25736dbec151bae20d14b20fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175119 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-21vcl: move bitmap filter headers into vcl/bitmap global header directoryChris Sherlock
Use #pragma once instead of header guards Change-Id: Iba43f2103628ed184933cf2611991e7aef9f0173 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173369 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-10-21tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 865, 868 Change-Id: Icc108072231fd37a73f0a35eac15bb1960e50202 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175266 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-21use frozen::make_unordered_set to skip the number of elementsTomaž Vajngerl
Change-Id: I715ab2bfc586f8854313b270580faa8e003f1c5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175190 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-10-21qt a11y: Map BLOCK_QUOTE role to new Qt equivalentMichael Weghorn
For Qt >= 6.9, map the BLOCK_QUOTE role to QAccessible::BlockQuote, newly introduced upstream in qtbase commit [1]: commit 0b5874bc96f4d1a8cba4fe14ee0b3499cc04c8cd Author: Michael Weghorn <m.weghorn@posteo.de> AuthorDate: Thu Sep 12 17:21:37 2024 +0200 Commit: Volker Hilsheimer <volker.hilsheimer@qt.io> CommitDate: Fri Oct 18 21:03:09 2024 +0000 a11y: Add new BlockQuote role With this in place, paragraphs to which the "Block Quotation" paragraph style has been assigned, are now shown with the "block quote" role in Accerciser when using the qt6 VCL plugin with a current qtbase dev build. [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=0b5874bc96f4d1a8cba4fe14ee0b3499cc04c8cd Change-Id: I3b9822e4a5ce6eed3ab4820a208f794bcf398e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173272 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-21Optimize a bitMike Kaganski
Change-Id: Ief89a827c05ae1197142de46a2d9365f87455158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175282 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-21tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 156, 164 V1037 Two or more case-branches perform the same actions. Check lines: 898, 908 Change-Id: Iec6ceda7c4506317860950857e516991d8a507a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175238 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 84, 90 Change-Id: I3e11f666cc3db56ca4d406831841b8f5660097a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175268 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-04-28 21:56:34 +0000