summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-08-14chart2: add "InsertMenuDataTable" action to menuTomaž Vajngerl
Change-Id: Ib60a2b061966eb61834480b63dc0653410a43a14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138248 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-14Fix typoAndrea Gelmini
Change-Id: Idb6ca21868789ea6e224e50e33198d684ef95638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138240 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-14ofz#49949 TimeoutCaolán McNamara
Change-Id: I44ebfc50579cbcf6482fbb445c08b31961750467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-14ofz#49750 TimeoutCaolán McNamara
skip slow path on fuzzing Change-Id: Idc27574ed7607011491248e726c1ba4bce9d483b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138253 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-14chart2: allow to select the data table, fix object CIDTomaž Vajngerl
Change-Id: I0a8d3643fcaefe8105e935b929947174bd9bdc96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138247 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-14chart2: add UI to the data tableTomaž Vajngerl
This adds a new object type "Data Table", with all the object identifiers and converters of properties. The data table is now shown in the drop-down of chart elements. A properties dialog was added, which allows to change properties of a data table. This contains the area, line and font tab pages and a new tab page specific for data tables, to change if the horiz. or vert. borders, key or the outline should be show. Change-Id: I9b4cd58cffbcc952daaa2c0c8f8a5a17e38ac293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138246 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-14chart2: remove unneeded class prefix in ObjectHierarchy.cxxTomaž Vajngerl
Change-Id: Iee007f7ff4d9665ee089712e7ba98090a8090609 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138245 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-14check SetOutputSizePixel for failureCaolán McNamara
Change-Id: If57dbbd7f04f0ee5286cf24a00480271bd4d9f76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-14ofz#50202 Direct-leakCaolán McNamara
detect and flag as error failure to sucessfully create a cairo surface Change-Id: I6981ec3058e37f4f4f196f6136f1d81865623c52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-14chart2: call clear instead of creating a new empty mapTomaž Vajngerl
Change-Id: I8b21909e92b558240e84cffd9432e0d9e270284e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138244 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-14chart2: remove unneeded class prefix in ObjectHierarchy.hxxTomaž Vajngerl
Change-Id: I1c851933e9b25dcd9a0dc29758baad8f3be7cb2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138243 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-14rename SwPaM::GetContentNode to GetPointContentNode/GetMarkContentNodeNoel Grandin
Using a parameter to select point/mark makes the code much harder to read Change-Id: Ic24098a6045ff2262d4c808228ded7bf8206fe8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-14rename SwPaM::GetNode to GetPointNode/GetContentNodeNoel Grandin
Using a parameter to select point/mark makes the code much harder to read Change-Id: I4ac8b904ac423e2b99253b7e4b6adc72c8afe1a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-14use more SwPosition::GetNode instead of nNodeNoel Grandin
as part of the process of hiding the internals of SwPosition. This just changes the places we are passing nNode to the constructor of SwNodeIndex Change-Id: I3dffba5df6c044a69da27b6a1254592695b976af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138200 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-14improve lcl_HighestLevelNoel Grandin
only need to check for max when we are incrementing the level Change-Id: Ic8ae07783b6085c7566239d949cf351a11d0875f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-14tdf#77964 doc import: 0x1 placeholder is for AS_CHARJustin Luth
It looks like MS always provides an sprm that confirms this, but Kingsoft was saving without that sprm. Something similar ought to be done for ImportOLE, but it doesn't have a ready option for specifying that, so I just left it because I don't care about OLE. Change-Id: I0ae304a08b381c8c29f3db24f791f25f5e33b0c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138234 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-08-13pass SwNode instead of SwNodeIndex to InsertTableNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: I58e20facfb8987a31e354542a9a5e7824daa0b26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13fix UBSAN downcast...does not point to an object of type 'ScUndoManager'Noel Grandin
after commit 640a6488a32e8f682788feb6cab01acfffca7fa7 Date: Thu Jul 28 19:06:59 2022 +0200 sc: allow undo of typing in 2 views independent from each other /sc/source/ui/view/tabvwshb.cxx:815:35: runtime error: downcast of address 0x6030007d3c20 which does not point to an object of type 'ScUndoManager' 0x6030007d3c20: note: object is of type 'EditUndoManager' 00 00 00 00 30 0a 0d 67 ed 7f 00 00 d0 d6 11 00 f0 60 00 00 40 7b b7 00 c0 60 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'EditUndoManager' /sc/source/ui/view/tabvwshb.cxx:815:35 SfxItemSet&) /workdir/SdiTarget/sc/sdi/scslots.hxx:1456:1 SfxItemSet&, SfxSlot const*) /sfx2/source/control/dispatch.cxx:1658:9 /sfx2/source/control/bindings.cxx:260:22 /sfx2/source/control/bindings.cxx:1275:17 /sfx2/source/control/bindings.cxx:1220:5 /sfx2/sour Change-Id: I4a505132184800a26725d602d3e27d1094e3ff65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13clang-tidy modernize-pass-by-value in variousNoel Grandin
Change-Id: Ie091b22bd77d4e1fbff46545bc86c12f1dbafcfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13pass SwNode instead of SwNodeIndex to CopyFlyInFlyImplNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: Ib2ac69352ca7e37117ad449fa7cb9f7cd69dd333 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138232 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13pass SwNode instead of SwNodeIndex to GetSectionLevelNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: I08f28a918c0d165ef4d143b8121d0aad5771dec0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13unique_ptr->optional in DocxAttributeOutputNoel Grandin
Change-Id: Idd7432689700ad13765c50c22c30ae230647b24a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138159 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13pass SwNode instead of SwNodeIndex to MakeEmptySectionNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: Ic24e646571eec0ff764d307e20e784d39d8411e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13Fix typoAndrea Gelmini
Change-Id: Ifa97ec24b479c11531e5e73f05da055df74ada60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138186 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-13Fix typoAndrea Gelmini
Change-Id: I66a7297e94c152920ac6c00a5a1aa61344a75fe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138185 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-13pass SwNode instead of SwNodeIndex to CopyNodeNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: Icaecb1c2eee09baf3f1630937bca9a96556eb023 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138225 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13pass SwNode instead of SwNodeIndex to SwNode constructorsNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: I0b2dd3e24c82c1551a7275ffc78991823354858a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13unique_ptr->optional in SwUndoInsTableNoel Grandin
Change-Id: I30920fb2353b5d8616361c995f0947abc3d34370 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138160 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13cid#1507934 Big parameter passed by valueCaolán McNamara
and cid#1507935 Big parameter passed by value Change-Id: I11c2868960a22ca09c82aba9ee343535ac2c5ae8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-13tdf#145614 Convert #define to constexprehsan
Change-Id: If783e2fbb65cae8e9c79ad9718f344dedf9dfe4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135074 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-08-13pass SwNode instead of SwNodeIndex to SwNodes::InsertTextSectionNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: Iddf8af8c7c9242bd3d9a48a59059b1cc8321be16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13sw: fix crash in InitBookmarks() with forum-mso-en-8410.docxMichael Stahl
Error: attempt to dereference a past-the-end iterator. Probably this only crashes in the assert(iter->pNode...) as the rest of the function already checks that "iter == end". (regression from commit 46e04a712e97f9095ef4da7f0e52f50cf2bfbb32) Change-Id: If652a15d1cdebb21fbce028fceeaee8dce8f7f6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-13complete the FIXME for the font substitutionCaolán McNamara
Change-Id: I9527bce0276f2aa77331f5bb16b21fc6c4402944 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-13pass SwNode to DelFlyInRange instead of SwNodeIndexNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: I84fd5fbb800c822868840710e1b9fda3de2abaf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138173 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13pass SwNode instead of SwNodeIndex to SwNodes::SplitTableNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: I23b23f23f2aeb559861f1328a2d795de5c54a013 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13pass SwNode instead of SwNodeIndex to SwNodes::MergeTableNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: Ia3b2563c23aaaf86f58b56bcdd60ded3c9d8404f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138219 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13no need to allocate these on the heapNoel Grandin
Change-Id: I692428cc8821f3dea53b4d6b52ced965b17f2ec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138218 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13bridges/jni : remove useless using and use css instead of com::sun::starArnaud VERSINI
Change-Id: I1b73d68b007ba0dfa54f99ff8f8fea55e94a1ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137651 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13flatten SwNodes a littleNoel Grandin
SwOutlineNodes does not need to be allocated separately. Change-Id: I134d3293b9b9c489c327b8c283b324875705541f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138215 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13pass SwNode instead of SwNodeIndex to SwUndoInsert::SwUndoInsertNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: I00501617d8e602f51fbe6c79ba92654292e30f0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13unique_ptr->optional in UndoTransliterate_DataNoel Grandin
Change-Id: Ibb694d7257124a8fe4c22da45c854df3be56526e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138213 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13unique_ptr->optional in SwSubFont::DoOnCapitalsNoel Grandin
Change-Id: I936d6e7d6bc40b81af10930642ca2a180f27c908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138161 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13loplugin:unusedmethodsNoel Grandin
tweak the python script to code with some clang weirdnes Change-Id: I88fc9f901748ff44af2b67704cc437b770ef0737 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138196 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-13warning: empty <p> tagCaolán McNamara
Change-Id: I6fb9dd331fe6ff9e35477a122a84ab0a6d3d8426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-12unique_ptr->optional in SwXTextPortionNoel Grandin
Change-Id: I6b55ed9fb907473ff2e44bfa0bd5ccced750ca60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138158 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-12can store this SwNodeRange on the stackNoel Grandin
Change-Id: Ic3e985fc67dcfef7f9fd59c185e1223258123896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138194 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-12can store this SwAttrSet on the stackNoel Grandin
Change-Id: I9e091c0fbbf75b899962db9d71138dc306c4b90a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138175 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-12only store one node pointer/index in SwHyphArgsNoel Grandin
rather than two that have to be kept in sync Change-Id: Ic6443a6af80f63cc40570665d6680f9a49cdb8ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138174 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-12tdf#149548 Revert "tdf#119840 loop backwards in ...Michael Stahl
... DocumentRedlineManager::SplitRedline" This reverts commit 4701d17bfe785f00958ad58a63dc0ece4c5c3281. Somehow this reintroduces the crash. Change-Id: If6866cc59a1032f283aa8374d303b028f2cba486 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138094 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-12Fix typoAndrea Gelmini
Change-Id: I354805dc54769cfa4564b0c1fd3be15f6c060b1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138188 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins