summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-04-22loplugin:salboolStephan Bergmann
Change-Id: I14a902c644c467d8e02474e5d0ba8d3dced2860f
2016-04-22loplugin:salboolStephan Bergmann
Change-Id: I4298f1da63d29133412962a9e4552a7ed473ad28
2016-04-22loplugin:salboolStephan Bergmann
Change-Id: I3a96fd12e6fa3a64bd1888373dfce0f8f621aad4
2016-04-22Related tdf#88502 a better implementation than the one in...Giuseppe Castagno
...commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1. This commit reverts previous implementation in commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1 and makes use of a dedicated interaction wrapper instead. See comphelper::SimpleFileAccessInteraction for details. Change-Id: Ia037ea14267afaf66d8f9aa2324649264a7cb4bf Reviewed-on: https://gerrit.libreoffice.org/24275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-22Add an interaction handler wrapper for simple file access.Giuseppe Castagno
This wrapper is to be used when you want to avoid the error messages displayed when accessing a file (the messages activated by ucphelper::cancelCommandExecution), especially when accessing a Web/DAV connection to enable https certificate validation and optionally enabling the authentication dialog that may be needed in these operations. Change-Id: I19f3072b91b6c4f453a54b56a3d9883b3383dfa5 Reviewed-on: https://gerrit.libreoffice.org/24274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-22remove unused BiffStringFlagsJochen Nitschke
users are gone since bb5fa5773461e14de153266ccfa36e5f454ff9b8 Change-Id: I8a73fdbec0df467bcaa3dc26fae5c965fd5bc612 Reviewed-on: https://gerrit.libreoffice.org/24266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-22Fix typosAndrea Gelmini
Change-Id: Iea11112a1bf1ff934de0e355b9e81979aa1966a3 Reviewed-on: https://gerrit.libreoffice.org/24286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-22Try to fix tdf#93967 by using VclPtr to keep the window aliveArnaud Versini
Change-Id: Ibc03ae15b22eba672475ace602858ad60e95418d Reviewed-on: https://gerrit.libreoffice.org/24283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-22starmath: Simplify SmParser::DoTable()Takeshi Abe
yet doing the same. Change-Id: I2ebdcb96179830eb02af8ed12dd27c69a78ed276 Reviewed-on: https://gerrit.libreoffice.org/24240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-22starmath: Drop member variable set but not usedTakeshi Abe
Its usage was gone with 9adcd261054a0e99ae032be5e7428e28a6663975. Change-Id: Ibd322531365c2e0ccad85d553781611dfe96d54e Reviewed-on: https://gerrit.libreoffice.org/24277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-22starmath: Make coUserDefinedCharContFlags more readableTakeshi Abe
No bits changed because: ((KParseTokens::ANY_LETTER_OR_NUMBER | KParseTokens::IGNORE_LEADING_WS | KParseTokens::ASC_DOT) & ~KParseTokens::IGNORE_LEADING_WS) == KParseTokens::ANY_LETTER_OR_NUMBER | KParseTokens::ASC_DOT Change-Id: I1e00d0cdb07a1450f98655ec3cc8483e4d348b74 Reviewed-on: https://gerrit.libreoffice.org/24122 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-21Fix typosAndrea Gelmini
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-21lok: getPartHash should be at the end, it is a new API call.Jan Holesovsky
Also add it to the init.cxx so that it is actually used. Change-Id: I255411158d0822718116ac05aad1ee925a9a7a9a
2016-04-21unit test 'C' locale shall map to 'en-US'Eike Rathke
Change-Id: Id4772b087add703537b588c961283466436f10c1
2016-04-21handle 'C' locale in simpleExtract()Eike Rathke
... so liblangtag isn't called and we explicitly have it known from there on as well. Also, don't set mbInitializedLocale=true in the LanguageTag ctor with Locale anymore as we don't know there if a semantically correct Locale was passed (which technically the 'C' locale is not). Instead, set it centrally in LanguageTag::registerImpl() where conversion to maBcp47 string takes place. Change-Id: I71551bd4b59d896c0674286edee816e05081ecd4
2016-04-21Resolves: tdf#99360 can't select filter criteria with mouseCaolán McNamara
regression since commit 6610ad9aee0c8299880cd1da6cd6a756860ccad9 Author: Jaskaran <jvsg1303@gmail.com> Date: Wed Mar 2 07:51:40 2016 +0530 original body of this method were protected by "if (IsActive())" before conversion, adding that back into the new version makes things apparently work again Change-Id: Id7e89c7724ed804d0330645c4e05dee113ce2079
2016-04-21loplugin:salbool: sal_Bool[] -> bool[]Stephan Bergmann
Change-Id: I3c5bf7a53c9ae173f8fce885ecf022f092aa43a9
2016-04-21Use Sequence ctor taking initializer_listStephan Bergmann
needed adapting loplugin:implicitboolconversion to not warn about Sequence<sal_Bool> arBool({true, false, true}); Change-Id: I971918aab7c958ef8f1e4e0548a84314e95f8325
2016-04-21Resolves: tdf#99425 crash when closing dialog editorCaolán McNamara
with undocked "Object Catalog" toolbar Change-Id: I70d51cec699333c5cfc1461d61734c1bbb5323da
2016-04-21loplugin:rangedforcopyStephan Bergmann
Change-Id: I227aa955417385da7cd43cc3641342e66e62ed96
2016-04-21lokit: add getPartHashHenry Castro
In the tiled rendering case, the slides, no matter if it is inserted or deleted, the part names always return sequential names i.e. Slide 1, Slide 2, ..., Slide N. However the client side needs to know what slides had been deleted or inserted, so it is necessary to send the hash codes. Change-Id: I0e9caeec660c3e42dd9f751bdce7690f9ad365a1 Reviewed-on: https://gerrit.libreoffice.org/24267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-21bump product version to 5.2.0.0.alpha1+Christian Lohmaier
Change-Id: I92ac49c3d59b6b1517edd9884e85e67e017cfd63
2016-04-21typoStephan Bergmann
Change-Id: I67721e86073bd2f67bee3ffbbb81fd5d143997d8
2016-04-21update emoji autocorrect files from po-filesChristian Lohmaier
Change-Id: Ie1209b68ab4d420934e8cdbc7ad7be5f0190f20c
2016-04-21Updated coreChristian Lohmaier
Project: translations 0732bbfc5365529452255fc0263416c0455b127b update translations for 5.2.0 alpha1 and force-fix errors using pocheck Change-Id: I75bca3b0cc0333302eac4d11c98ad26dfdc35fd6
2016-04-21fix windows buildNoel Grandin
after my commit e1af7f0c438bc242e4562aa0286c99787b5ad544 "clang-tidy modernize-loop-convert in c*" Change-Id: Icbc8c30186b0ea33933365951718dfad3fd7c4e2
2016-04-21Make the OSL_ENSURE message match realityTor Lillqvist
Change-Id: Id006ebb6138d8cb1ec6f2242527e550674ab523a
2016-04-21Better fix for 13758a3d154e8e450fdfe8bcdeb6b3a03996c53aStephan Bergmann
"SourceManager::isMacroArgExpansion has only one param in older Clang", which caused false positives like warning about sal_False in CPPUNIT_ASSERT_EQUAL(guard.p->m1, sal_False); in cppu/qa/cppumaker/test_cppumaker.cxx Change-Id: I1c5a67527aef381e336d71cb8fefbb87961bbf96
2016-04-21also exclude the "specific English" table from mapping to LanguageTagEike Rathke
... otherwise entering a tag for such combination would result in a different locale instead of an on-the-fly assignment. Change-Id: I0c1b2005298cb39f98cf816d4765ce21a5cbc9bc
2016-04-21clang-tidy modernize-loop-convert in c*Noel Grandin
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-21clang-tidy modernize-loop-convert in b*Noel Grandin
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
2016-04-21clang-tidy modernize-loop-convert in a*Noel Grandin
Change-Id: If8eada464c6dc7350e50fc90eb27aa47bd90e198
2016-04-21move stylepolice plugin into store/Noel Grandin
seems std::regex is not too well supported yet, at least in libstdc++-4.8 Change-Id: Ib9feb33d2f197d40fc67dc93468aa2f7dae05bac
2016-04-21Remove redundant checksStephan Bergmann
(that started to cause loplugin:salbool after 13758a3d154e8e450fdfe8bcdeb6b3a03996c53a "SourceManager::isMacroArgExpansion has only one param in older Clang") Change-Id: Ibbdf4552d81385cf952e2d47d1fe23daf78824b5
2016-04-21aColumns is only used as a setStephan Bergmann
(cf. 40d6b81b9ee0a878d0dadb40941c50aa394a7501 "Replace map to sal_Bool with map to bool") Change-Id: I04bdd6c33793e277182fa80d187f212ab23c252e
2016-04-21tableNames_t is only used as a setStephan Bergmann
(cf. fde48126df56ede640499f24ac67f6754b84efbf "Replace map to sal_Bool with map to bool") Change-Id: I0bb24a78d15eb876565e64ce7ca0f4bb04dce2e2
2016-04-21comphelper::UStringMixLess defaults to bCaseSensitive = trueStephan Bergmann
...which then behaves the same as the default std::less<OUString> Change-Id: If18ef434a752bc77012e665d3621bc319f2897e8
2016-04-21Related: tdf#65642 RTF filter: import \pgnlcrmMiklos Vajna
This as a side effect also implements support for DOCX <w:pgNumType w:fmt="lowerRoman" .../>. Change-Id: Ifb524b25236a8bc774690266a4fa205154204109 Reviewed-on: https://gerrit.libreoffice.org/24273 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-21SourceManager::isMacroArgExpansion has only one param in older ClangStephan Bergmann
Change-Id: I5aa4f7cca70b8196263613b92c018323152411a1
2016-04-21XListBox: Add more hints about return valuesSamuel Mehrbrodt
Change-Id: I74385b762ed70ec9d8303f1cb94f76b9edac7cc5 Reviewed-on: https://gerrit.libreoffice.org/24261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20Revert partly some of my previous patchesJulien Nabet
to avoid invalidation of end iterators Change-Id: I0970b6d753ee1dd1f4805d0d27b8eb4f8210581b Reviewed-on: https://gerrit.libreoffice.org/24265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-20explicitly map 'C' locale and other known definitions to LanguageTagEike Rathke
Starting up a dbgutil build with LC_ALL=C gave i18nlangtag/source/languagetag/languagetag.cxx:1362: LanguageTagImpl::convertLocaleToLang: with bAllowOnTheFlyID invalid 'C' i18nlangtag/source/languagetag/languagetag.cxx:1533: LanguageTag::getLanguageFromLangtag: pLangT==NULL for 'C' i18nlangtag/source/languagetag/languagetag.cxx:1593: LanguageTag::getRegionFromLangtag: pRegionT==NULL for 'C' Nothing harmful in this case as the default fallback is 'en-US', but it also indicated that other known non-standard "locales" such as "sr-latin" or "german" were not resolved to the defined values. Likely such weird values are not in use anymore, but.. Change-Id: Ib3469354ceb236552540da5fd11d8f9e9c5ab1fd
2016-04-20tdf#99396 SdrTableObj::EndTextEdit: restore cell format undo itemsMiklos Vajna
As seen by the user: after finishing the text edit of an Impress table cell, the text changes are still on the undo stack, but the table ones (like background color or vertical alignment) get lost. This happens as SdrUndoManager::SetEndTextEditHdl() removes all undo items from the stack which are created after the start of the text edit, and creates a single item, but that doesn't include the table changes, just the text ones. Fix the problem by creating a copy of the CellUndo objects when it text edit mode, and pushing them to the undo stack in SdrTableObj::EndTextEdit(), which already writes the undo stack and runs after the undo manager cleared the text edit items from the undo stack. Change-Id: I7d2768c86b5b262e98be1d09d7fa08d581430bb5 Reviewed-on: https://gerrit.libreoffice.org/24264 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-20loplugin:salbool: Warn about uses of sal_False/TrueStephan Bergmann
...that can generally be rewritten as false/true, and sometimes could hide errors, see e.g. <5be5f00fe16b0e255b31fbaba5f119773d1cd071> "So this is apparently about right-to-left levels, not a boolean flag". Change-Id: Ib39a936a632c2aab206f24c346252e31dcbb98f3
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I96cef821fc1d87963b8928af5dfc8ba97557da74
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I2f5c4c341c4c38e1603748fb7c1f50e42547d005
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I5896c6b8bf2aa9c7c66ca5f7c50cee1b0738ea0a
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I38560113652ac39104b942a4cb80b1e03944513c
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I5f38167cc2fd0104ad388c63f766bda6acae96e2