Age | Commit message (Collapse) | Author |
|
Change-Id: Ia0f52455804aadb8b8dff68a2665a409c9173b2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177182
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
|
|
Change-Id: I34fcfda19bc9ff35b49faf8892ab14c0f9808943
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177184
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
|
|
Change-Id: I32c8a4c8dd56ef781f40db1d3ca66823dd9b995f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177185
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
|
|
Change-Id: I051f33ac28bdc1e3922d2d390ff3234204b80688
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177186
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
|
|
This updates the test with comments and adds options at test start
to make the test more robust (without those it can fail depending on
the execution order of other tests)
Change-Id: Ia7ea7e8810cc63b754d2d7f1ff1757839026ed3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178760
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
|
|
Change-Id: Id2573d678b0059c1929d1a896cbfdf863676f945
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179142
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I70f5607d8d5ccdadf1f5c69c846c93821f7681df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179141
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ib4411323cb5b1e1a44c56e890b6c0c1266d93eb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179140
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
and
cid#1636859 Explicit null dereferenced
Change-Id: I6e618bebd0f61a1e796b367343bb98e7a01d29b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179139
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I03909c8ed7e9f2bf410412b02790aee0fbca6d58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179138
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I03aa87d1a265761ac2f781e33b6136a4c38cbb31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179137
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ic1d291a68009749ce1464de60a78baf3047ddcc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179092
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ifc60a01f0e5e1f6cdab3680e69202f98471c2a7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179089
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
This dialog can e.g. be triggered via "Tools"
-> "Options" -> "Appearance", then clicking the
"New" button.
Change-Id: I59b2195274ef1ff7f56057dc439b03bb0610d106
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179111
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Declare support for the name dialog that e.g. gets used
in "Tools" -> "Options" -> "Appearance" when clicking the
"New" button.
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
Change-Id: Idaa3190d45efba87a74ef80a2999f3c6be7fa90d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179110
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Call QWidget::adjustSize [1].
[1] https://doc.qt.io/qt-6/qwidget.html#adjustSize
Change-Id: Ic191d65b9c7a3aee5e0e9c945773d7732719d4e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179099
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
When encountering a "GtkPopover" object in a .ui
file, create a QWidget with window flags Qt::Popup
and set a layout, as weld::Popover is a weld::Container
subclass.
Add new QtInstancePopover that QtInstanceBuilder::weld_popover
creates.
For now, methods in that class simply trigger an assert;
actual logic still needs to be implemented.
Change-Id: I9a0dfefd9fb79d24fe40dd5efe13ef0c3ab9b7fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179098
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I082430e653f5634ecdcc101b370f531b2c0e25cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179097
Tested-by: Jenkins
Reviewed-by: Michael Weghorn (away) <m.weghorn@posteo.de>
|
|
Change-Id: I698e98ac16d8e1f2cd1e01a50570bd9012c94952
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179095
Reviewed-by: Michael Weghorn (away) <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Change-Id: Iff9ac377a5cfa259c5911632ad16d2b1e3269868
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178986
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I93f40aef003aa52b4eef173f8f481c99fe4c0489
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178985
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ie2816ab4f4ad5f4d703d4f6669ae16a9fa60933e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178984
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Add a ctor to /opt/lo/bin/clang-format -i include/vcl/abstdlgimpl.hxx
to construct the dialog in-place, to simplify factory methods.
And move two abstract dialog impls where all others are in cui
Change-Id: Ia3f3a5d6c1aaa5a9aca9c11990f833842e4536e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178983
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
0: return pWindow ? pWindow->GetFrameWeld() : nullptr;
2: SfxNewFileDialog aNewFileDlg(GetView()->GetFrameWeld(), SfxNewFileDialogMode::LoadTemplate);
Reproducible by adding "LoadStyles" to the menu in writer, then print
preview and then use that "LoadStyles" entry.
Also dispatch "SID_TEMPLATE_LOAD", as used by "Load Styles from Template"
entry in the dropdown from the "Styles Action" toolbar of the style
panel, with an explicit frame it is associated with.
Change-Id: I3d536b897fbf6be9e20e4238e6a761df56ac9701
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179084
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Instead of checking individually whether the mouse pos is
over the SpinField's up or down button or the `mpEdit`,
just check the SpinField's whole rectangle.
The mouse event pos is relative to the SpinField, so
use (0, 0) for the top left position of the SpinField's
rect used in the check.
This is not only simpler, but also fixes the case
of the UNO control when the "Spin Button" options is disabled
in which case there are no buttons and `mpEdit` is null, so
`bMouseHovered` would always be false and adjusting the spin field
value for that control using the mouse wheel wouldn't even work when
mouse-hovered after the initial check was introduced in
commit 869b88488ac443cc64943254064da20b0f361c56
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 13 16:37:45 2024 +0200
tdf#160824 vcl: Require mouse over spinfield to mouse-wheel through values
Change-Id: I3a2ee3af8af872e4a330a4d5e9f5cd6a2de89754
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179085
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
* Update translations from branch 'master'
to 7bb37bc63384aa1654041c19cceac7463266f9fc
- update translations for master
and force-fix errors using pocheck
Change-Id: I17e0a401077dd9cfc491eba7be3fb76032ebf87c
|
|
Cleanup up this method, making it more organised in how it iterates over
spans,
and adding asserts to verify assumptions.
The asserts uncovered that we are sometimes fed bad data, so now we deal
with
that (and not sanitising the input is possibly why the original code was
a little weird).
Also, now that we are returning correct data, our caller does not need
to correct the return value
Change-Id: I094931bb2e93a3273b7a928fc7e83eed75e3db51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179040
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I31e7c5f48680d5196db6f44e8e3cfd31d5a5fda9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178987
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
PDFEncryptorR6 implements PDF 2.0 encryption (ver. 5 rev. 6) using
AESv3 (256 bit key length). The PDFEncryptorR6 is enabled when the
PDF output is PDF 2.0 (other versions have been deprecated, so it
is the only one available in PDF 2.0).
Change-Id: I27f270197910405b5c2378a3873d2495f52f3206
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176885
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178759
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
|
|
The access permission are needed independent to the kind of PDF
encryption so they should be in a common place so they can be
reused. PDFEncryptionProperties is the best place to create the
value anyway.
Change-Id: Ic6e6c3d9a8cb314523c0305eba9e64f3734d52b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176884
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178758
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Icee61b29fa1f233c6c28e47c57343820a1f723c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178953
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Do it in a similar way as the GtkInstanceScrolledWindow
implementation.
Change-Id: I92d5b1d55ed390e012e59525dd9fc9e9ffc72cfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178977
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Change-Id: I0ee4cececc40f21a6ef4eeb034c44727578d309c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178976
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
* Don't always append, but evaluate the insert position
(with special value -1 to append).
* If an iterator is passed for `pRet`, set its model
index to the new item's model index.
Change-Id: I2db8718f4b572d4ae3dcfa7183033f04174b72a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178975
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
This is basically the the Qt port of the existing
GtkInstanceWidget::set_busy_cursor.
Gets called e.g. from RemoteFilesDialog::OpenURL
(via the weld::WaitObject ctor/dtor).
Change-Id: I0b61ae33ad47190c8f2258745ab483152dde1331
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178974
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
The QToolButton::menu methods to retrieve the menu doesn't
exist in the QAbstractButton base class, so let
QtInstanceMenuButton take a QToolButton pointer.
Implement the menu item related methods in line
with the corresponding QtInstanceMenu methods.
Change-Id: I4d97f528fe112ba3b94069ce0173a5b63a415ffe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178973
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Make the existing local helper function `extractPopupMenu`
used by VclBuilder a static method in the BuilderBase base
class for reuse by QtBuilder.
Use it in QtBuilder::makeObject to evaluate
the "popup" property for a "GtkMenuButton"
object, get the corresponding QMenu and set
it for the button.
The code currently assumes that the corresponding
menu is aleady known, i.e. was defined earlier in
the .ui file than the menu button it belongs to.
VclBuilder doesn't rely on that, so a handling
similar to there could be implemented as and when
needed.
Change-Id: I95446fb7a369f2cfee0d8d51432933582bbfd570
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178972
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
There's no need to explicitly call VclPtr::get
to get the Menu* from the VclPtr<Menu>, so drop it,
also to make the code reusable for QtBuilder, where
the template type `MenuPtr` is just `QMenu*`, so there's
no `get` method to call.
Change-Id: I45eb23791a8b6cd099b79e276bdb18c3b8199923
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178971
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
For some reason unclear to me, glade 3.40 would automatically
remove the "pixbuf-column" and "text-column" properties for the
"iconview" GtkIconView.
Looking at the doc [1], this seems suspicious.
(Actually removing the properties would event result in
a crash when opening the dialog via "File" -> "Open Remote"
in Writer.)
Therefore, restore those 2 properties manually again after resaving
with the newer glade version.
[1] https://docs.gtk.org/gtk3/property.IconView.pixbuf-column.html
Change-Id: Ifd8251384be93fb2ca372351ccb6b40bff682953
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178970
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
VclBuilder also doesn't seem to have any particular handling
for that, just like for "GtkCellRendererText", so return
early instead of asserting further down that this case isn't handled
yet.
Change-Id: Idf2a490fb944ac2596f64b96c6e3693fad894935
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178969
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Implement basic logic related to menus:
* Creating menus and simple menu items in QtBuilder.
* Setting and retrieving misc properties for menu items
in QtInstanceMenu.
Use the QObject::objectName property [1] to hold
the ID for menus and menu items.
Introduce a PROPERTY_ACTION_NAME to hold the
action name/command name for menu items. This property
gets set for the corresponding QAction objects.
[1] https://doc.qt.io/qt-6/qobject.html#objectName-prop
Change-Id: Ic866377e42202bde6d1f8bd215829ff99a4b682a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178968
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Introduce QtInstanceMenu as the native Qt implementation
for weld::Menu.
This mostly adds the basic structure.
For all methods except QtInstanceMenu::clear,
the actual logic still needs to be implemented.
Change-Id: I983f2cd3976eee50f55b2ac702578833dbad3d39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178964
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Add new QtInstanceMenuButton class as the native Qt
weld::MenuButton implementation.
The actual logic of the class methods still needs to
be implemented, they all just trigger an assert when
called right now.
Create a QToolButton for "GtkMenuButton" objects in .ui files.
Let QtInstanceBuilder::weld_menu_button create an instance
of that new class and pass the button in the ctor.
Change-Id: Ie5ba0bad8e351554323e8f4ec1281b2c5ae8fbc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178963
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
and more comments.
Because I want better coverage before I go changing
ScTable::GetRowForHeight
And because it makes obvious the flaws in this method.
Change-Id: Ic7ec7bdcbab2547387efaaf2c1ad8b7cd05d1b3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178922
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I7196ad523b3084124a3b03fb2e4998d42fd91779
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176883
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178757
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
+ add test
Change-Id: Iba54dab6738c9707b37e434bab23ae286675436d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176882
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178756
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Also test the algorithm against the known values from an example,
to be sure we are calculating the values correctly. For this we
need a couple of decryption algorithms, but those do mostly just
the reverse of the encryption.
Change-Id: I5499ed0b57671f44e48fe68961e07cde22be6b39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176881
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178755
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
* Update helpcontent2 from branch 'master'
to e4f4fd964633268c3e52cb2b4cc32a11000ad148
- Fix bad characters
Change-Id: I3b8a1f8188d2b88fb8409df4a1e602102c4a3381
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178960
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I9ba49ff8df463519631e698ce5916f0126c5d7b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178934
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to 6ecda866708ab53144cffd8ab3be134b949f3394
- Fix grammar
Change-Id: I0843f2bf289d7950feaf6fdccf3e0f5e62a368f0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178965
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
|