summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-10-21xmlsecurity: export description in PDF signatureMiklos Vajna
Extract appendUnicodeTextString() from the PDF writer impl, and reuse it in xmlsecurity, to share code. Change-Id: Icdc2f89132cd29e07280001e30bad97e0a644654 Reviewed-on: https://gerrit.libreoffice.org/30110 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-21Add vim modeline to new filesKhaled Hosny
Change-Id: I01cbd3b0698d458d8ba7267f2c70271db14f559f
2016-10-21vcl: remove redundant publicThorsten Behrens
Change-Id: I8c05e884719dd434ac7fd929186da2a0e9f44e6c
2016-10-21coverity#1374089: Unchecked return valueThorsten Behrens
Change-Id: Ied4e80db512000471b5aa215beeef1277121fe12
2016-10-20Convert ScConsData into using std::vectorMaarten Bosmans
This simplifies the ScReferenceList handling significantly. Change-Id: I2204a4d56c98fdf7dcd593901dcf5cc0f7c52a62 Reviewed-on: https://gerrit.libreoffice.org/29530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-20Incapsulate WinSalVirtualDevice betterMike Kaganski
Change-Id: I8de745e2318c69ccec2ffabb69df598a4bf60480 Reviewed-on: https://gerrit.libreoffice.org/30071 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-20Typo in commented-out codeKhaled Hosny
Change-Id: I9f276a6de54dd3542249b47986d2ca6b3f27413d
2016-10-20Vertical Mongolian and Phags-pa seem to work fineKhaled Hosny
The fonts are designed so that they are rotating 90° is all needed, so we don’t to rotate them back, unlike CJK. Change-Id: I0afa4b066257718a5a52eb2e93a18ce839aec2f0
2016-10-20sc: check SID_EDIT_POSTIT parametersHenry Castro
Avoid crash when execute .uno:EditAnnotation with missing arguments Change-Id: Iaee8694b7481933f3672a3847264a49a6503b82e Reviewed-on: https://gerrit.libreoffice.org/30116 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-10-20loplugin:expandablemethodds in sw(part3)Noel Grandin
Change-Id: I7db01985a35407e4169709ede5324656c6629047 Reviewed-on: https://gerrit.libreoffice.org/30095 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20loplugin:expandablemethodds in sw(part2)Noel Grandin
Change-Id: Idc2118899a8063099b66c0f5db40d8402db063d1 Reviewed-on: https://gerrit.libreoffice.org/30083 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20tdf#103274 (11): Add default XCommandEnvironment referenceGiuseppe Castagno
Change-Id: I8145e167ef58d83666c2f18adf869a30c859ee8f Reviewed-on: https://gerrit.libreoffice.org/30036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-20unit test for tdf#97968, Cut&Paste grouped references adjustmentEike Rathke
Change-Id: Id644012454d992c01ebcce6fe35d1dcdd1bc4d53
2016-10-20xmlsecurity: show PDF signature right after adding itMiklos Vajna
Also: - handle PDF in DocumentSignatureManager::write(), so the PDF file is not truncated when closing the document signatures dialog, and - handle PDF in DigitalSignaturesDialog::canAddRemove() Change-Id: I77c1fcdcbdcb079ce934f37546129d9d280e5d2e
2016-10-20Revert "Some clean-up"Stephan Bergmann
This reverts commit 0b04e8f80ea1b0ae0603d79b2c80d669f16375d3, shuffling the code around started to cause some builds to complain with -Werror=maybe-uninitialized in places where they did not before. Needs a better fix.
2016-10-20Reuse the HarfBuzz buffer as much as possibleKhaled Hosny
Less allocations in case we have many sub runs. Change-Id: I50d4a57702c030c185fc7edef576c64d739a6194
2016-10-20Use HarfBuzz shape plan for a bit more controlKhaled Hosny
This way we control exactly what shapers we use in what order, and as an extra we can now tell which shaper HarfBuzz ends up using. Change-Id: Idd303b2a557e16ac86ada0c2006d3e2a052ac489
2016-10-20vcl: add PDFWriter::Sign() Android stubMiklos Vajna
Change-Id: Ib8bc5e700a54135317359a130ceb2c06ff7af103
2016-10-20Some clean-upStephan Bergmann
Change-Id: Ifd36b0f364dd1d5d38095d32409f8587b0662ace
2016-10-20sw: Avoid inheritance from std::vectorTakeshi Abe
Change-Id: I4ee09871ec0fa5c67a8d4c4c448229ec2deda4c2 Reviewed-on: https://gerrit.libreoffice.org/30075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-20typo: imgage -> imageAndras Timar
Change-Id: I5f650293719ad790eb5b4f5d5d448399356f386e
2016-10-20No need for an explicit specializtion of convertFastPropertyValue<bool>Stephan Bergmann
Change-Id: I7b5799ed67b8d5da6cb3e6c4e7c76f05a2ec3853
2016-10-20bump product version to 5.3.0.0.alpha1+Christian Lohmaier
Change-Id: I7dc5e6925962d948f8d61cd0c951331e78fcb08e
2016-10-20Revert "prep WinResTarget for WNT in testdir"Giuseppe Castagno
Still random failures in Gerrit Windows builds. This reverts commit f5c54089b50718abf7c35aa81b150c509809d5c4. Change-Id: Iec48d2388691577ccd675b9a73941cedceebd527 Reviewed-on: https://gerrit.libreoffice.org/30103 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-20clarify hash lengths a bit moreCaolán McNamara
Change-Id: I66cea4b9efb82d29e6c052ac11a6f2eaca823ce0
2016-10-20hash len is 20 for xls cryptoapi configurationCaolán McNamara
Change-Id: I6e06b8578959b8147043179db57e875b1d98d57d
2016-10-20be more c++yCaolán McNamara
Change-Id: I673b00e111a734bc626ba3d3f6ecf9692f1ce7db
2016-10-20tdf#103261 allow postponed text except in .docJustin Luth
fixes regression from tdf#89317, commit b39feae4f12b07a0fdb2c8c2a48d5aae613cd7c9. Change-Id: I0590579997e2c29de171aac91ba4459e0c776cc0 Reviewed-on: https://gerrit.libreoffice.org/29984 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-10-20loplugin:expandablemethodds in sw(part1)Noel Grandin
Change-Id: Ic3a558e6b646b6b6bc4cb7e09a00695553023534 Reviewed-on: https://gerrit.libreoffice.org/30073 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20tdf#95387 UI: "Custom Animation" probably should be called just "Animation"giacco
modifided strings.src modified: sd/source/ui/app/strings.src Change-Id: I1f31f13d7e88f91510d10c5b9afe31df191dafdc Reviewed-on: https://gerrit.libreoffice.org/30052 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-20xmlsecurity: add initial PDF sign UIMiklos Vajna
An unsigned PDF can be signed now, but the stream still gets truncated on closing the dialog. Change-Id: I12dd50bf577cd23b3355f6c6d03e71a9c0dbcfab
2016-10-20Various loplugin warnings (clang-cl)Stephan Bergmann
Change-Id: I9e3720c86f96abc864a52c0469032132808080a4
2016-10-20Missing include (Windows --disble-pch)Stephan Bergmann
Change-Id: I4cd8bdcd93d1c92aa4983e36566ca8aa7ddec5e3
2016-10-20external/harfbuzz: Silence clang-cl -Werror,-Wmicrosoft-enum-valueStephan Bergmann
The code in harfbuzz' src/hb_common.h apparently goes to some length to ensure that any value of type hb_tag_t (aka unit32_t) can be transported as a value of the hb_script_t enum type. However, under MSVC any C (or non-fixed C++) enum type has an underlying type of int, so _HB_SCRIPT_MAX_VALUE of value 0xFFFFFFFF will cause a -Wmicrosoft-enum-value under clang-cl. To not complicate things further, acknowledge that converting between hb_tag_t (an unsigned integer type with 32 value bits) and hb_script_t (a two's-complement signed integer type with 32 value bits) is well-defined under MSVC and drop _HB_SCRIPT_MAX_VALUE (which appears to be an otherwise unused implementation detail) there. Change-Id: Ic03dff64a9dd24683c45347fa78699708c269972
2016-10-20Blind fix for "error: chosen constructor is explicit in copy-initialization"Stephan Bergmann
...on linux_clang_dbgutil_64 build Change-Id: I00022749ce12df459ce22333593daa2eb6503fd7
2016-10-20loplugin:staticmethodsStephan Bergmann
Change-Id: I439747c98fcdadb59e68756e8b3ae2e305c960cb
2016-10-20Check for enable safe mode earlierSamuel Mehrbrodt
Change-Id: I50e48472bb840c70e9a7c11dd84f33c64d6e1422
2016-10-20Handle link click directly in FixedHyperlinkSamuel Mehrbrodt
Change-Id: I5b5f0648b6e6432b0928351a17d285df8c9da811
2016-10-20fix fallback in ScVbaFormat::getLockedJochen Nitschke
>>= specialisation for rhs Any is good at hiding stuff: old code equals to > util::CellProtection cellProtection; > aCellProtection = mxPropertySet->getPropertyValue(sCellProt); > aCellProtection = uno::makeAny( cellProtection.IsLocked ); and would always return Any(false) Change-Id: Iccbf35f32dd92fbfcf495f11cc993109be2e5e4e Reviewed-on: https://gerrit.libreoffice.org/29972 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20Open menu: Simplify inserting menu entriesSamuel Mehrbrodt
Change-Id: Ia75f2fe349580003b16735fccf429392d0cf8363 Reviewed-on: https://gerrit.libreoffice.org/30082 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-20Toolbar Open menu: Insert separator between clear list and open entriesSamuel Mehrbrodt
Change-Id: I037c5d09ecb70480f4559697e291c40567fea615 Reviewed-on: https://gerrit.libreoffice.org/30081 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-20Add "Open as Template" to toolbar open menuSamuel Mehrbrodt
Change-Id: Ia8bea19f8f9377f27ab425c335e2a65bd2abcb2b Reviewed-on: https://gerrit.libreoffice.org/30078 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-20Use Application::IsSafeModeEnabled()Samuel Mehrbrodt
Change-Id: I8ca8ceae76b6479a848a618ed141ce29a9c2d84e Reviewed-on: https://gerrit.libreoffice.org/30077 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-20revert part of "simplify some use of typeid"Noel Grandin
commit 553ee72041d6f66e26156eb1ad0d9e3c13457f7a is wrong in that typeid has different semantics to dynamic_cast i.e. is-exactly vs. is-exactly- or-subtype checked the other cases to make sure that non of them have any subclasses Change-Id: Id045e6d5e80aa1f7ba29a3475514eb0ae5320806
2016-10-20Add some more source files for breakpointing convenienceTor Lillqvist
Change-Id: Ic9b44918a27bf185c534b3705f15a2dac29bc642
2016-10-20Any can't be nested ...Jochen Nitschke
... don't check for it Change-Id: I0400ef365fdfcd8e1f516958225ae99289798f21 Reviewed-on: https://gerrit.libreoffice.org/30049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-20Extract vcl::PDFWriter::Sign() from vcl and xmlsecurityMiklos Vajna
The use case is different in vcl and xmlsecurity: vcl creates a new PDF (possibly with a signature), while xmlsecurity signs an existing PDF, but this part can be shared between the two. So far in vcl only the nss part is moved, not touching mscrypto yet. Change-Id: Ie776f622c1a4a3a18e79e78f68722a2fa219a83b Reviewed-on: https://gerrit.libreoffice.org/30063 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-20fix bug in expandablemethods pluginNoel Grandin
where using a std::map instead of a std::set meant that it sometimes miscounted the number of callsites Change-Id: I1e2ebcf44fe006827e66620ae4c9bbc813835414
2016-10-20LOK: hold the solar mutex consistently for document method calls.Michael Meeks
(cherry picked from commit eb69d8cb5eb6192de89ca8310a53ae7a434a73d1) Change-Id: I200dff44b457a1632d99619981e237de73a2a8df Reviewed-on: https://gerrit.libreoffice.org/30070 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-20CppunitTest_desktop_lib: fix valgrind errorsMiklos Vajna
With this, 'make -sr CppunitTest_desktop_lib CPPUNIT_TEST_NAME="DesktopLOKTest::testPaintPartTile DesktopLOKTest::testWriterCommentInsertCursor" VALGRIND=memcheck' finishes with 'ERROR SUMMARY: 0 errors from 0 contexts'. The problem is that in sw/sc/sd code it's enough to make sure that the on-stack ViewCallback instances are destroyed after the loaded component, but in desktop/ code also the emit-callbacks-on-idle code is under test, so we need to make sure first the LOK document wrapper is destroyed, and only after that the ViewCallback instances are destroyed. Change-Id: Ie8361233461d00fd252da929fb912a1a0b835c30 Reviewed-on: https://gerrit.libreoffice.org/30072 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>