summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-03-12fdo#75977: Clear sheet deleted flags for affected references when undoing.Kohei Yoshida
This will allow formula cells to restore deleted references when they get recalculated. With this change, SetDirty() that previosly took no argument has been renamed to SetAllFormulasDirty(), and it now takes one argument that stores context information. Change-Id: If0de5dc1737a2722b6d61a87644b10a4f921edc5
2014-03-12fdo#75977: Write test for this.Kohei Yoshida
Change-Id: I96bd008759a2a06ffeea46f2b25b847bc895e9eb
2014-03-12writerfilter: assert that substream doesn't leave extra contextsMichael Stahl
... on the stacks, to prevent problems like rhbz#988516. Change-Id: I76392586e5276e4b73941064875c0224834684b5
2014-03-12sw: the test_segfault_while_save.docx requires svl component...Michael Stahl
... to create a com.sun.star.util.NumberFormatsSupplier; without that importing a header is interrupted by exception without calling endParagraphGroup(). Change-Id: Ib5023329c9f944336582c05b1fa836bbce7813af
2014-03-12fdo#75872: ODF import: fix up graphics defaults stroke/fill colorsMichael Stahl
These have changed a few times, notably in LO 4.0 with commit 895890563cb0cc5fa872bdfd06918a46cdda172d and AOO 4.0 with commit c0eb5e7772c848806db8ab461f77f9549c1d8b2b; unfortunately historic OOo and current AOO do not write the values into ODF files, whereas LO 4.x does (probably by accident, since 45d3577bc5726eee44f491fd30a7f11dc428431a by design). Try to set the defaults depending on the generator; since the defaults are not specified by ODF they are implementation defined anyway so this should be OK. Change-Id: I1270d6e0cdeea5cb493724a0998f661a0cf644f1
2014-03-13Avoid possible resource leaks by boost::scoped_arrayTakeshi Abe
Change-Id: Ibc90eba9f336b649a968f584f2b36139c847d348
2014-03-12CppunitTest_sw_rtfexport: enable on MACOSXMiklos Vajna
Change-Id: Id125f7b2293f7813391ca583f60bcbf53f455afc Reviewed-on: https://gerrit.libreoffice.org/8562 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-03-12Remove dead code from SdrObjEditViewAlex Henrie
Change-Id: I0a15b3567718d08edb4405146f6172c3939e06c1 Reviewed-on: https://gerrit.libreoffice.org/8552 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-12fdo#75982: Better hot keys for pivot table fields.Kohei Yoshida
R for Row, C for Column, P for Page, and D for Data fields. Change-Id: I4e29fcdf77a17498d9325a09f0b21154cab04f83
2014-03-12fdo#75110 SwEditShell::DeleteSel fix start of selection when bSelAll == trueMiklos Vajna
Change-Id: I3e8ce585b29619061b18ab1ab8f0cf6c7d421074
2014-03-12Let's not leak here.Kohei Yoshida
Change-Id: I12a50d0028164c37d06ff846bfbeff56a4591d12
2014-03-12Resolves: fdo#50855 Nimbus Sans L missing stylesCaolán McNamara
Change-Id: Ie8cdcf4ad0ffe52024fd5cfe33073abfc6aadca8
2014-03-12coverity#1158232 Fix ownership of NamedDBs::insert argumentStephan Bergmann
f70d03436b7b501e0ed1d745935a204b9b97b855 "coverity#1158232 have a stab at silencing warning with function markup" claimed that NamedDBs::insert always takes ownerhip of its argument, but boost::ptr_set::insert(std::auto_ptr<U> x) simply calls insert(x.release()), so only takes ownership when it returns true. ScDBDocFunc::AddDBRange (sc/source/ui/docshell/dbdocfun.cxx) relies on this behavior, deleting the argument when insert failed. ScDBDocFunc::RenameDBRange (sc/source/ui/docshell/dbdocfun.cxx) relied on this behavior, deleting the argument when insert failed, until f55cc330dec0dec60c755e2ce28a840c7fca1956 "Fixed the fallout of the changes in ScDBCollection" removed the delete (presumably in error?). I put it back in now. All other uses of NamedDBs::insert ignored the return value (witnessed with SAL_WARN_UNUSED_RESULT). Some are insert-if-not-found cases, where I added asserts now (Sc10Import::LoadDataBaseCollection, sc/source/filter/starcalc/scflt.cxx, is not entirely clear to me, so I added a TODO), while others would have potentially leaked the argument, in which cases I fixed the code. Change-Id: Iad40fbeb625c8ce6b0a61cbf16298d71cdc7de80
2014-03-12Remove unused HelpCloseListenerStephan Bergmann
Change-Id: I9040a1262b31f8d0f19594b6efcf12b2c38be7be
2014-03-12No need for Invocation_Impl::setMaterial to be virtualStephan Bergmann
Change-Id: I5f78d97bcd55c0db71d7c5e3383678586c2cf392
2014-03-12loplugin:literaltoboolconversionStephan Bergmann
Change-Id: I513aeeabbb4d6fc48b6a95e034c311a454dd5ca7
2014-03-12No need for isKindOf to be SAL_CALLStephan Bergmann
Change-Id: Ia58af7d32904de01fdb5291203938c748cae94c6
2014-03-12Mark overriding OwnServiceImpl class template member functions as SAL_OVERRIDEStephan Bergmann
Change-Id: I767c60733b39de02935de8be8dd9d3e351a38cab
2014-03-12Mark overriding CanvasCustomSpriteBase class template mem funs as SAL_OVERRIDEStephan Bergmann
Change-Id: I6c64d1b1caae27a1e1eac3a743aec078bc652d96
2014-03-12Mark overriding BufferedGraphicDeviceBase class templ mem funs as SAL_OVERRIDEStephan Bergmann
Change-Id: I707fea8100c686ab8232eaf6e4d9a348abdb5236
2014-03-12Mark overriding GraphicDeviceBase class template member funs as SAL_OVERRIDEStephan Bergmann
Change-Id: Idfac26bb0f436799c3431062238e46b1a50d9f14
2014-03-12Mark overriding DisambiguationHelper class template mem funs as SAL_OVERRIDEStephan Bergmann
...which reveals that some uses are not derived from XEventListener, so re- introduce BaseMutexHelper as an alternative (which originally got superseded by DisambiguationHelper in 09b546cf9c1d0d9f78066e70a0348c7678cdcb14 "Fix overloaded-virtual warning in canvas"). Change-Id: I1418370733b72526ec481b70fa69f03e7c28b7ce
2014-03-12Mark overriding SpriteCanvasBase class template member funs as SAL_OVERRIDEStephan Bergmann
Change-Id: Ie01ae7e29f22fbb2f627a9c671f48bb1c19c5f56
2014-03-12Mark overriding IntegerBitmapBase class template member funs as SAL_OVERRIDEStephan Bergmann
Change-Id: I484ef5c4b31122605287b8e1a5f33108f7b22ea2
2014-03-12Mark overriding BitmapCanvasBase class template member funs as SAL_OVERRIDEStephan Bergmann
...which reveals that SpriteCanvasBase is not derived from XBitmapCanvas, so split up BitmapCanvasBase (just XBitmap) and BitmapCanvasBase2 (plus XBitmapCanvas) and make IntegerBitmapBase directly abstract over those two as arguments. Change-Id: Ieae87fe466bb9f1a861c8a95162ef25235ae5799
2014-03-12bnc#865381 DOCX import: fix w:trHeight for cells with btLr text directionMiklos Vajna
Also extend testcase: I made sure that the new version fails without this fix and without the fix from 48b5b7641d0df960558082e8948da8598f801264 as well. Change-Id: If33aa6d33cdc287620c12b84ad3f50279568bc8d
2014-03-12bnc#865381 DOCX import: fix btLr cell direction when having vertical mergeMiklos Vajna
Change-Id: I527955671e1100f05da717bffe002131baaf0291
2014-03-12Resolves: fdo#75982 set mnemonics targets for hidden labelsCaolán McNamara
the key piece though is that labels that have mnemonic targets are always candidates for getting mnemonics generated for them Change-Id: Ie4bcbc18e94467936f40875c749cd22793021d0c
2014-03-12Spelling fix: suportedTor Lillqvist
Change-Id: I3b67edd5ba4541a65cb0916abea6db1362c32afd
2014-03-12fdo#71622 compress svg files in ODFAndras Timar
Change-Id: I7d3bcff12a8f24d4d63851f578f9703bfaa25278
2014-03-12test for ignoring large twips values (cp#1000043)Luboš Luňák
Change-Id: I366539b83c7a93a81fd72f3f2355b09c59f7ae58
2014-03-12ignore large twips values like MSO does (cp#1000043)Luboš Luňák
Change-Id: Ib304245b6ae64c15cfb6c999580f73e5e228c440
2014-03-12std::strlen requires cstring include to buildLuboš Luňák
Or, even simpler, don't bother with the needless namespacing. Change-Id: I4bbb115c1c2c89881a0bf88ccd54b0f5cb8b3518
2014-03-12convert gallery apply progress dialog to .uiCaolán McNamara
Change-Id: I1fd2f2f1faa51346eb68445688fb5e1ef85b7124
2014-03-12Updated coreCaolán McNamara
Project: help e1e716143a6d6a38fdfa88f9cb72cb258f2be30e
2014-03-12sw: document that parseDump() uses the F12-generated layout dumpMiklos Vajna
Change-Id: I9613cda8f08ce6a92235b00a053aca4541bba81d
2014-03-12convert gallery files page to .uiCaolán McNamara
Change-Id: Ifd5c9b16f8f9a42e13f1139076f7616dd3e0f8d0
2014-03-12Updated coreCaolán McNamara
Project: help e06c21fee256f13bbb41592da7d1f4a81df6b533
2014-03-12coverity#708189 Uninitialized scalar fieldCaolán McNamara
Change-Id: I558cda577595d6807d85bb41ac93500d02d461a6
2014-03-12coverity#707937 Uninitialized pointer fieldCaolán McNamara
Change-Id: I25b92686b08137a5292de620d4e348019c21a739
2014-03-12coverity#707936 Uninitialized pointer fieldCaolán McNamara
Change-Id: I0ae177349408fd49832056fbc4c300e8e77b2417
2014-03-12coverity#704794 Unchecked dynamic_castCaolán McNamara
Change-Id: Idbfdfe687ac94f1e1135c8a877a7b133056a875f
2014-03-12coverity#1027775 Dereference null return valueCaolán McNamara
Change-Id: I27dc7645969e6311bc6c0a3d593924ea41dfdf5d
2014-03-12coverity#705469 Dereference null return valueCaolán McNamara
Change-Id: I8880f0f441456fe1951145551ef6dfa0e9d65b66
2014-03-12coverity#705463 Dereference null return valueCaolán McNamara
Change-Id: Icf620e065e3b15a8d900a6da00fe979cc45c1f07
2014-03-12coverity#705462 Dereference null return valueCaolán McNamara
Change-Id: Ic859f10a4fb70371f7616b4c17bb4c5040fd5051
2014-03-12coverity#705461 Dereference null return valueCaolán McNamara
Change-Id: Icc9dac3f198432f0b548cbe9c559658ee26ba1cc
2014-03-12coverity#705795 Dereference before null checkCaolán McNamara
Change-Id: I9cf31d5d4a260f0b33539479599610a91875e2e1
2014-03-12coverity#705794 Dereference before null checkCaolán McNamara
Change-Id: I63735efaecfad348e04a55a41c5c446cb88db067
2014-03-12fix coverity#704768Caolán McNamara
Change-Id: I6b3403ad1b1f18a4cf32a933bb721f9c6cab44f7