summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2025-01-10Update git submodulesShantanu Oak
* Update dictionaries from branch 'master' to 5b8116e5e8a1ce761f929f8dad1a91ff6ceb5ccc - Add Sanskrit Change-Id: Iffca4fe252cc06c79e75189ef267f6307dc63867 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180046 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-01-10Update git submodulesShantanu Oak
* Update dictionaries from branch 'master' to 5e4bb811f8d7cbea58a3085291b43edf2f76d8be - Add Kannada Change-Id: I3eac267803aef6fc21722ca8226f844fb7016260 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180045 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-01-10tdf#164627 docx export: consolidate getWordCompatibilityMode()Justin Luth
Solves TODO: this is duplicated, better store it as DocxExport member? It is generally useful to be able to query what compatibility mode the DOCX will be exported as, so calculate the value once and cache it. I re-arranged things a bit, and I think it is clearer now what is happening here. Change-Id: I5cd619e1696ecef956a54957fb57f49803e7bc67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179981 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2025-01-09tdf#161411 - UI: Add Better wording for ASCII-only charactersBalazs Varga
Based on the suggestions at: https://bugs.documentfoundation.org/show_bug.cgi?id=161411#c8 Change-Id: I5d2d17e36551687d929f9529dd8e6a7d2f78ff6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180006 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2025-01-09tdf#161412 - UI: fix warning in PDF password dialog didn't disappearBalazs Varga
Warning about "Only Basic Latin characters can be entered" should only be highlighted until we are entering non-ASCII characters into the password textbox. Change-Id: I87c26a3b0b1777e0e76fe12422027aa2f377ad35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179891 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-09Update git submodulesShantanu Oak
* Update dictionaries from branch 'master' to 7951da9434fc16d2d69e2cc0653236619eb03bd8 - Add Assamese Change-Id: I6f222c3b90acd1aba1e3c7669e00d879dd875981 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179983 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-01-09Update git submodulesShantanu Oak
* Update dictionaries from branch 'master' to 73267e0018dceb7d4001dd35f0ed46c9f9ea245e - Add Tamil Change-Id: I409eb7a7af6e9440bf3412702931c9cf7d188b5d Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179982 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-01-09vcl: flatten BlendFrameCache.cxxChristopher Sherlock
Change-Id: Iff5dc958c90afc82cd719176c1566413faea677e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179173 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-09vcl: flatten BlendFrameCache.cxxChristopher Sherlock
Change-Id: Ibf0ddd053c2e787c113a468ee75b03bb77610626 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179171 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-09loplugin:stringconstant (in -DDEBUGPASTE-only code)Stephan Bergmann
Change-Id: I01f417f589393062afba2ffe0bbd07e7cf2e5344 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180018 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2025-01-09Update git submodulesXisco Fauli
* Update dictionaries from branch 'master' to 7eec558f0737384d5aa357ee32e9a8a6a74ac4de - Upgrade Mongolian dictionary to 2025.01.05 Downloaded from https://github.com/bataak/dict-mn/archive/refs/tags/2025.01.05.zip Change-Id: Ica44af35f96c8adf1d17987c7a3ad1d3b16e1e28 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180021 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-09tdf#162286 Add a category to store favorite functions in FWAhmedHamed
Change-Id: Iec0d169570ba3d29501a4917d8858a9e9438f608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171828 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-09Python: upgrade to 3.11.11 (master only)Xisco Fauli
Downloaded from https://www.python.org/ftp/python/3.11.11/Python-3.11.11.tar.xz * Add external/python3/replace-powershell-with-wget.patch.1 to avoid FindPythonForBuild: Invoke-WebRequest : The request was aborted: Could not create SSL/TLS secure channel. At line:1 char:1 + Invoke-WebRequest https://aka.ms/nugetclidl -OutFile 'C:\cygwin64\home\tdf\jenki ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~ + CategoryInfo : InvalidOperation: (System.Net.HttpWebRequest:Htt pWebRequest) [Invoke-WebRequest], WebException + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe ll.Commands.InvokeWebRequestCommand 'py' is not recognized as an internal or external command, operable program or batch file. when downloading nuget.exe from https://aka.ms/nugetclidl using powershell. By default powershell uses TLS 1.0 and the site security requires TLS 1.2, so it fails with 'The request was aborted: Could not create SSL/TLS secure channel.' Kudos to Caolán for helping with a compiling issue. See https://lists.freedesktop.org/archives/libreoffice/2024-December/092830.html Change-Id: If66a88dd8f8c7774c49f8c33e9e40d2d5418e7c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178681 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-09tdf#152515 vcl: Implement Win32 vert CJK printing for all fontsJonathan Clark
Previously, vertical CJK printing was implemented on Windows by substituting the font with an @-prefixed alternate. This was a naming convention once used by Microsoft to indicate that a font is a specially-prepared vertical variant containing pre-rotated CJK glyphs. However, modern fonts don't ship these variants and cannot be printed correctly if this approach is used. This change deletes the @-prefix substitution. Instead, a secondary HFONT is used for printing upright characters, as determined by the shaper. This implementation should work with all fonts, and the printed output should now match the screen better. Change-Id: I3c474980f90ade8475073926364ab59dd9310ca0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180014 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2025-01-09tdf#164183 Add hyperlink entries to context menu of tablesOliver Specht
Table objects in Draw/Impress now have Open/Edit/Copy/Remove hyperlink entries in context menu of text in table objects. Change-Id: Id3a5346eb3227871a06d2ea7fdb3ed38c07654c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177849 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Second functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Ib3a97f9acb7778c90aa1c172ca82cf450a1e792f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179249 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Hour functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Ib372b4dfde77961e7982bd0d8f1f8598be7da726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179252 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Month functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Ifc27af0f091c75c02d3816b83b3717fc435ad31b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179250 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Day functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Ic22d420f0f5596ea3a4ff9cd7e540e6c51a559ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179254 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Year functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Iffffe3988afdc91068e85beaafc5ff1580210ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179253 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-09cool#10782 vcl lok: avoid changing the current view during YieldMiklos Vajna
Commit 520cc546e2940bdfbc45eab1e569bb06bab17a9c (cool#10782 sfx2 lok: fix bad view id on PDF export, 2024-12-20) provided a specific fix for one case where spinning the main loop can result in callbacks being emitted on the wrong view. Hunting down all the SfxViewShell::Current() calls and auditing them if they are problematic in practice is a large task, so it's desirable to handle this problem in a more generic way. Fix the problem by pushing/popping the current LOK view in Application::Reschedule(), which is what e.g. the framework/ status bar code uses during PDF export. This keeps the original problem fixed but is more generic. This requires storing function pointers in comphelper/, since normally vcl/ code can't call SfxLokHelper, since sfx2/ already depends on vcl/. The fix can be tested by reverting the original fix: git show 520cc546e2940bdfbc45eab1e569bb06bab17a9c -- sfx2|git apply -R and then running the testcase: make -C sw -sr CppunitTest_sw_tiledrendering CPPUNIT_TEST_NAME=testPDFExportViewSwitch which now passes even if the sfx2-level fix is not there. Keep that specific fix, though: the less time we assume SfxViewShell::Current() returns the correct view, the better. Change-Id: Ic1811ff1e67f73fa5066af775d31589136b8502a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179993 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-09Fix typoAndrea Gelmini
Change-Id: I8c3c0b8f1bf41e64b89d6e2819f81dc861766c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179969 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-09Fix typoAndrea Gelmini
Change-Id: I0acd3e6df2654682f3dcf8554bfcd7ec0f717b33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179968 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-09tdf#130857 qt weld: Move button prop logic to helper methodMichael Weghorn
Move existing logic to set push button properties from QtBuilder::setProperties to a separate helper method QtBuilder::setButtonProperties and call it right after creating the QPushButton. This simplifies QtBuilder::setProperties and gets rid of one qobject_cast there. Change-Id: If7c8ae2cc6e53923f0efd196916f847535596e93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179966 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-09tdf#130857 qt weld: Set combobox entry iconsMichael Weghorn
Handle the `pImageSurface` and `pIconName` params that can be used to set icons for combobox entries. This gets used e.g. in the spell check dialog (that's not supported by QtInstanceBuilder yet). Change-Id: I88a39826280aedbd7a8054366c30d263090cdd96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179965 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-09tdf#130857 qt weld: Handle "GtkComboBox" objectsMichael Weghorn
Handle it the same as "GtkComboBoxText" and create a QComboBox widget for it. This gets used e.g. in the spellcheck dialog that's not supported by QtInstanceBuilder yet. Change-Id: I959ecd2736a171eb44849df4405f1b4a42b5c69c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179964 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-09tdf#130857 qt weld: Implement QtInstanceDrawingArea::set_cursorMichael Weghorn
See also QtFrame::SetPointer. Change-Id: I446abcd28e0066b936724228472d466a405ce1b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179963 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-09check if non-file uris could be interpreted as a file system pathnameCaolán McNamara
Change-Id: If283bec44ad1d648c68a5d0f028855e09c09017e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179868 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-09tdf#163083: try to release lock to avoid deadlockMike Kaganski
The minidump in the bug (https://bugs.documentfoundation.org/attachment.cgi?id=198431) shows these three stacks: 1. VCL main thread: ntdll.dll!NtWaitForAlertByThreadId() ntdll.dll!RtlpAcquireSRWLockExclusiveContended() ntdll.dll!RtlAcquireSRWLockExclusive() msvcp140.dll!mtx_do_lock(_Mtx_internal_imp_t * mtx, const xtime * target) Line 103 [Inline Frame] vclplug_winlo.dll!std::_Mutex_base::lock() Line 50 [Inline Frame] vclplug_winlo.dll!std::unique_lock<std::mutex>::{ctor}(std::mutex &) Line 133 vclplug_winlo.dll!CWinClipboard::getContents() Line 125 sclo.dll!ScTabViewShell::GetClipData(vcl::Window * pWin) Line 542 [Inline Frame] vbaobjlo.dll!ooo::vba::excel::implnPasteSpecial(const com::sun::star::uno::Reference<com::sun::star::frame::XModel> &) Line 235 vbaobjlo.dll!ScVbaRange::PasteSpecial(const com::sun::star::uno::Any & Paste, const com::sun::star::uno::Any & Operation, const com::sun::star::uno::Any & SkipBlanks, const com::sun::star::uno::Any & Transpose) Line 2942 mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214 mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430 reflectionlo.dll!stoc_corefl::`anonymous namespace'::IdlInterfaceMethodImpl::invoke(const com::sun::star::uno::Any & rObj, com::sun::star::uno::Sequence<com::sun::star::uno::Any> & rArgs) Line 593 mergedlo.dll!SbUnoObject::Notify(SfxBroadcaster & rBC, const SfxHint & rHint) Line 2246 mergedlo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 36 mergedlo.dll!SbxVariable::Broadcast(SfxHintId nHintId) Line 155 mergedlo.dll!SbxValue::SbxValue(const SbxValue & r) Line 68 mergedlo.dll!SbxVariable::SbxVariable(const SbxVariable & r) Line 49 mergedlo.dll!SbxMethod::SbxMethod(const SbxMethod & r) Line 847 mergedlo.dll!SbiRuntime::FindElement(SbxObject * pObj, unsigned long nOp1, unsigned long nOp2, ErrCode nNotFound, bool bLocal, bool bStatic) Line 3703 mergedlo.dll!SbiRuntime::StepELEM(unsigned long nOp1, unsigned long nOp2) Line 4189 mergedlo.dll!SbiRuntime::Step() Line 811 [Inline Frame] mergedlo.dll!`anonymous-namespace'::RunInitGuard::run() Line 1017 mergedlo.dll!SbModule::Run(SbMethod * pMeth) Line 1177 mergedlo.dll!SbModule::Notify(SfxBroadcaster & rBC, const SfxHint & rHint) Line 776 mergedlo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 36 mergedlo.dll!SbMethod::Broadcast(SfxHintId nHintId) Line 2121 mergedlo.dll!SbxValue::Get(SbxValues & rRes) Line 290 mergedlo.dll!SbMethod::Call(SbxValue * pRet, SbxVariable * pCaller) Line 2078 mergedlo.dll!basprov::BasicScriptImpl::invoke(const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aParams, com::sun::star::uno::Sequence<short> & aOutParamIndex, com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aOutParam) Line 264 mergedlo.dll!SfxObjectShell::CallXScript(const com::sun::star::uno::Reference<com::sun::star::uno::XInterface> & _rxScriptContext, const rtl::OUString & _rScriptURL, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aParams, com::sun::star::uno::Any & aRet, com::sun::star::uno::Sequence<short> & aOutParamIndex, com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aOutParam, bool bRaiseError, const com::sun::star::uno::Any * pCaller) Line 1545 mergedlo.dll!SfxApplication::OfaExec_Impl::__l120::<lambda_2>::operator()(long nDialogResult) Line 1768 [Inline Frame] mergedlo.dll!std::_Func_class<void,long>::operator()(long <_Args_0>) Line 869 mergedlo.dll!Dialog::EndDialog(__int64 nResult) Line 1212 [Inline Frame] mergedlo.dll!Link<weld::Button &,void>::Call(weld::Button &) Line 111 [Inline Frame] mergedlo.dll!weld::Button::signal_clicked() Line 1508 [Inline Frame] mergedlo.dll!SalInstanceButton::ClickHdl(Button *) Line 2941 mergedlo.dll!SalInstanceButton::LinkStubClickHdl(void * instance, Button * data) Line 2929 [Inline Frame] mergedlo.dll!std::_Func_class<void>::operator()() Line 869 [Inline Frame] mergedlo.dll!Control::ImplCallEventListenersAndHandler(VclEventId) Line 311 mergedlo.dll!Button::Click() Line 130 mergedlo.dll!PushButton::Tracking(const TrackingEvent & rTEvt) Line 1324 mergedlo.dll!vcl::Window::EndTracking(TrackingEventFlags nFlags) Line 341 mergedlo.dll!ImplHandleMouseEvent(const VclPtr<vcl::Window> & xWindow, NotifyEventType nSVEvent, bool bMouseLeave, __int64 nX, __int64 nY, unsigned __int64 nMsgTime, unsigned short nCode, MouseEventModifiers nMode) Line 715 mergedlo.dll!ImplHandleSalMouseButtonUp(vcl::Window * pWindow, const SalMouseEvent * pEvent) Line 2353 mergedlo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2702 mergedlo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 312 vclplug_winlo.dll!ImplHandleMouseMsg(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 3318 vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5876 vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 6231 user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int) user32.dll!DispatchMessageWorker() vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 476 vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 552 vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581 mergedlo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 387 mergedlo.dll!Application::Execute() Line 360 mergedlo.dll!desktop::Desktop::Main() Line 1652 mergedlo.dll!ImplSVMain() Line 229 [Inline Frame] mergedlo.dll!SVMain() Line 247 mergedlo.dll!soffice_main() Line 99 [Inline Frame] soffice.bin!sal_main() Line 51 soffice.bin!main(int argc, char * * argv) Line 49 [Inline Frame] soffice.bin!invoke_main() Line 78 soffice.bin!__scrt_common_main_seh() Line 288 kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() 2. Clipboard thread: ntdll.dll!NtWaitForAlertByThreadId() ntdll.dll!RtlpWaitOnCriticalSection() ntdll.dll!RtlpEnterCriticalSectionContended() ntdll.dll!RtlEnterCriticalSection() sal3.dll!osl_acquireMutex(_oslMutexImpl * Mutex) Line 65 [Inline Frame] vclplug_winlo.dll!osl::Mutex::acquire() Line 63 vclplug_winlo.dll!SalYieldMutex::doAcquire(unsigned long nLockCount) Line 148 [Inline Frame] mergedlo.dll!comphelper::SolarMutex::acquire(unsigned long) Line 86 [Inline Frame] mergedlo.dll!osl::Guard<comphelper::SolarMutex>::{ctor}(comphelper::SolarMutex & t) Line 144 [Inline Frame] mergedlo.dll!SolarMutexGuard::{ctor}() Line 1340 mergedlo.dll!TransferableHelper::getTransferDataFlavors() Line 477 vclplug_winlo.dll!CFormatRegistrar::RegisterFormats(const com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> & aXTransferable, CFormatEtcContainer & aFormatEtcContainer) Line 145 [Inline Frame] vclplug_winlo.dll!CXTDataObject::InitializeFormatEtcContainer() Line 648 vclplug_winlo.dll!CXTDataObject::EnumFormatEtc(unsigned long dwDirection, IEnumFORMATETC * * ppenumFormatetc) Line 549 ole32.dll!SetClipboardFormats(HWND__ * hClipWnd, IDataObject * pDataObj) Line 4482 ole32.dll!OleSetClipboardInternal(IDataObject * pDataObject, IDataObject * pSourceDataObject, void * * ppDataObjectMTAAddress, const wchar_t * pszCallerPackageFullName, unsigned long pid) Line 3750 ole32.dll!OleSetClipboard(IDataObject * pDataObject) Line 3602 [Inline Frame] vclplug_winlo.dll!CMtaOleClipboard::onSetClipboard::__l2::<lambda_1>::operator()() Line 464 [Inline Frame] vclplug_winlo.dll!sal::systools::RetryIfFailed(unsigned int) Line 31 [Inline Frame] vclplug_winlo.dll!CMtaOleClipboard::onSetClipboard(IDataObject *) Line 463 vclplug_winlo.dll!CMtaOleClipboard::mtaOleReqWndProc(HWND__ * hWnd, unsigned int uMsg, unsigned __int64 wParam, __int64 lParam) Line 541 user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int) user32.dll!DispatchMessageWorker() [Inline Frame] vclplug_winlo.dll!CMtaOleClipboard::run() Line 668 vclplug_winlo.dll!CMtaOleClipboard::oleThreadProc(void * pParam) Line 685 ucrtbase.dll!thread_start<unsigned int (__cdecl*)(void *),1>() kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() 3. Clipboard content changed notification thread: win32u.dll!NtUserMsgWaitForMultipleObjectsEx() combase.dll!CCliModalLoop::BlockFn(void * * ahEvent, unsigned long cEvents, unsigned long * lpdwSignaled) Line 2105 combase.dll!ModalLoop(CSyncClientCall * pClientCall) Line 171 combase.dll!ClassicSTAThreadDispatchCrossApartmentCall(tagRPCOLEMESSAGE * pMessage, OXIDEntry * pOXIDEntry, CSyncClientCall * pClientCall) Line 324 [Inline Frame] combase.dll!CSyncClientCall::SwitchAptAndDispatchCall(tagRPCOLEMESSAGE * pMessage) Line 5704 combase.dll!CSyncClientCall::SendReceive2(tagRPCOLEMESSAGE * pMessage, unsigned long * pstatus) Line 5310 [Inline Frame] combase.dll!SyncClientCallRetryContext::SendReceiveWithRetry(tagRPCOLEMESSAGE *) Line 1493 [Inline Frame] combase.dll!CSyncClientCall::SendReceiveInRetryContext(SyncClientCallRetryContext *) Line 581 combase.dll!ClassicSTAThreadSendReceive(CSyncClientCall * pClientCall, tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus) Line 563 combase.dll!CSyncClientCall::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 797 [Inline Frame] combase.dll!CClientChannel::SendReceive(tagRPCOLEMESSAGE *) Line 674 combase.dll!NdrExtpProxySendReceive(void * pThis, _MIDL_STUB_MESSAGE * pStubMsg) Line 1899 rpcrt4.dll!NdrpClientCall3() combase.dll!ObjectStublessClient(void * ParamAddress, __int64 * FloatRegisters, long Method) Line 366 combase.dll!ObjectStubless() Line 176 [Inline Frame] combase.dll!RemoteReleaseRifRefHelper(IRemUnknown *) Line 8720 combase.dll!RemoteReleaseRifRef(CStdMarshal * pMarshal, OXIDEntry * pOXIDEntry, unsigned short cRifRef, tagREMINTERFACEREF * pRifRef) Line 8627 combase.dll!CStdMarshal::DisconnectCliIPIDs(unsigned long) Line 5357 combase.dll!CStdMarshal::DisconnectWorker_ReleasesLock(unsigned long dwType, bool logEventIsActive, CObjectContext * explicitServerContext, bool performCallback, CIDObject * pIDDelayRelease, const void *) Line 4676 combase.dll!CStdMarshal::Disconnect(unsigned long dwType, const void * callerAddressForDiagnostics) Line 4441 combase.dll!CStdIdentity::~CStdIdentity() Line 388 combase.dll!CStdIdentity::`scalar deleting destructor'(unsigned int) [Inline Frame] combase.dll!CStdIdentity::CInternalUnk::ReleaseWithCallerAddress(const void *) Line 945 combase.dll!CStdIdentity::CInternalUnk::Release() Line 851 [Inline Frame] vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release(IDataObject * ptr) Line 229 [Inline Frame] vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::{dtor}() Line 158 [Inline Frame] vclplug_winlo.dll!CAPNDataObject::{dtor}() Line 97 vclplug_winlo.dll!CAPNDataObject::`scalar deleting destructor'(unsigned int) vclplug_winlo.dll!CAPNDataObject::Release() Line 140 [Inline Frame] vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release(IDataObject * ptr) Line 229 [Inline Frame] vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::{dtor}() Line 158 vclplug_winlo.dll!CDOTransferable::`scalar deleting destructor'(unsigned int) [Inline Frame] vclplug_winlo.dll!com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::{dtor}() Line 114 vclplug_winlo.dll!CWinClipboard::handleClipboardContentChanged() Line 330 vclplug_winlo.dll!CWinClipboard::onClipboardContentChanged() Line 412 vclplug_winlo.dll!CMtaOleClipboard::clipboardChangedNotifierThreadProc(void * pParam) Line 699 ucrtbase.dll!thread_start<unsigned int (__cdecl*)(void *),1>() kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() Thread #3 has locked m_aMutex in CWinClipboard::handleClipboardContentChanged, and tries to destroy CDOTransferable in the reference dtor. That delegates to another thread (not entirely clear which, but could be either thread #1 or #2); at this point, thread #1 is in CWinClipboard::getContents waiting for the same m_aMutex, and thread #2 is in TransferableHelper::getTransferDataFlavors, waiting for the solar mutex (locked by VCL main thread in basprov::BasicScriptImpl::invoke). This change releases m_aMutex in CWinClipboard::handleClipboardContentChanged as soon as it in not needed anymore. This aligns with comment several lines above, telling that transferables must be destroyed only outside of the mutex lock. Change-Id: I9faf254930a8913d1621f5ed504aeb369b37adfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179984 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-09tdf#164617 Fix Focus Impress templateLaurent Balland
Change styles of objects of first slide to automatic styles. It preserves styles when affecting Master Page. Change-Id: I3c54284477d6a4cd84369204a556f123b36b0ba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179970 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2025-01-09tdf#164617 Fix Ligths Impress templateLaurent Balland
Change styles of objects of first slide to automatic styles. It preserves styles when affecting Master Page. Change-Id: I43b8d8354c7c7c63f1b6f460e20c6376a76dcc02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179971 Reviewed-by: Laurent Balland <laurent.balland@mailo.fr> Tested-by: Jenkins
2025-01-08Fix rudimentary Emscripten Qt6 copy -> paste supportStephan Bergmann
...following up on 5a4ca3ce934ca3f34669bc66b8941544aef1bc89 "Rudimentary Emscripten copy -> paste support" (which had addressed both Qt5 and Qt6, in general) Change-Id: I45dbea5cf852c126cdf0509f9cdef7218d2a8eda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179962 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-01-08xmlsecurity: fix --without-system-nss buildMichael Stahl
signing2.cxx:71: error: undefined reference to 'NSS_OptionSet' (regression from commit f0efcb917049547ad0496c004830ff0153602071) Change-Id: Idad3f7d5d1a2cb642ac3485a750cdc7631fbf4df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179954 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2025-01-08Simplify a bitMike Kaganski
WinLaunchChild takes the same kind of argv as execv, terminated by a null pointer; so no need to pass argc. Change-Id: I280c8da0c613a7d0d1a208831a87f0e4648719f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179952 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-08Use o3tl::toW instead of c-style castMike Kaganski
Change-Id: Id027978cbe6188fecafe71f6566dd8501ffdabe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179950 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-08poppler: upgrade to release 25.01Michael Stahl
Fixes CVE-2024-56378 - remove disable-nss-and-gpgmepp.patch.1 and instead build CryptoSignBackend.cc which appears to have working ifdefs now - run the update_pch script - add clang-std-rotate.patch.1 because jenkins failed Change-Id: I7fcdd10766287e83dc666041644f129378584d91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179903 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2025-01-08Revert "Revert "Revert "stronger typing for SwClient::GetRegisteredIn"" and ↵Stephan Bergmann
fix SwIterator cast" This reverts commit d8e29e2697e90da6acf5858fd74d6054ed9e5aa3. Reason for revert: It causes CppunitTest_sw_rtfexport2 to fail with > /sw/inc/calbck.hxx:428:18: runtime error: downcast of address 0x6060004d0fd8 which does not point to an object of type 'sw::ClientBase<SwModify>' > 0x6060004d0fc0: note: object is base class subobject at offset 24 within object of type 'SwFormatHeader' > 00 00 00 00 90 c6 d3 ea 6e 7f 00 00 01 00 00 00 66 00 48 01 a0 11 00 00 88 be be be 10 c7 d3 ea > ^ ~~~~~~~~~~~ > vptr for 'sw::ClientBase<SwFrameFormat>' base class of 'SwFormatHeader' > #0 0x7f6edd5beb5e in SwIterator<sw::ClientBase<SwModify>, SwModify, (sw::IteratorMode)0>::First() /sw/inc/calbck.hxx:428:18 > #1 0x7f6edd5b6d69 in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:237:35 > #2 0x7f6edd5b7c45 in sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:259:15 > #3 0x7f6edd5b49c6 in SwModify::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:229:5 > #4 0x7f6edd605e7b in SwFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/format.cxx:309:19 > #5 0x7f6ee039738b in SwFrameFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/atrfrm.cxx:2849:15 > #6 0x7f6edd5b8189 in sw::ClientNotifyAttrChg(SwModify&, SwAttrSet const&, SwAttrSet&, SwAttrSet&) /sw/source/core/attr/calbck.cxx:268:13 > #7 0x7f6edd610879 in SwFormat::SetFormatAttr(SfxItemSet const&) /sw/source/core/attr/format.cxx:604:13 > #8 0x7f6ee6495964 in FillHdFt(SwFrameFormat*, SfxItemSet const&) /sw/source/uibase/utlui/uitool.cxx:239:14 > #9 0x7f6ee64914e7 in ItemSetToPageDesc(SfxItemSet const&, SwPageDesc&) /sw/source/uibase/utlui/uitool.cxx:340:13 > #10 0x7f6ee43fe5b4 in SwDocStyleSheet::SetItemSet(SfxItemSet const&, bool, bool) /sw/source/uibase/app/docstyle.cxx:1894:13 > #11 0x7f6ee304306c in SwXPageStyle::SetPropertyValues_Impl(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) /sw/source/core/unocore/unostyle.cxx:3157:33 > #12 0x7f6ee304d9b9 in SwXPageStyle::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) /sw/source/core/unocore/unostyle.cxx:3453:5 > #13 0x7f6e9b369897 in writerfilter::dmapper::DomainMapper_Impl::PushPageHeaderFooter(writerfilter::dmapper::PagePartType, writerfilter::dmapper::PageType) /sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx:3910:25 > #14 0x7f6e9b445050 in writerfilter::dmapper::DomainMapper_Impl::substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream> > const&) /sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx:10046:13 > #15 0x7f6e9b101b9d in writerfilter::dmapper::DomainMapper::lcl_substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream> > const&) /sw/source/writerfilter/dmapper/DomainMapper.cxx:4746:14 > #16 0x7f6e9b877f73 in writerfilter::LoggedStream::substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream> > const&) /sw/source/writerfilter/dmapper/LoggedResources.cxx:272:5 > #17 0x7f6e9ad35daf in writerfilter::rtftok::RTFDocumentImpl::resolveSubstream(unsigned long, unsigned int, rtl::OUString const&) /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:381:14 > #18 0x7f6e9ad33bc1 in writerfilter::rtftok::RTFDocumentImpl::resolveSubstream(unsigned long, unsigned int) /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:356:5 > #19 0x7f6e9ad48f49 in writerfilter::rtftok::RTFDocumentImpl::sectBreak(bool) /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:705:9 > #20 0x7f6e9adcd3b7 in writerfilter::rtftok::RTFDocumentImpl::popState() /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:3695:13 > #21 0x7f6e9afd2595 in writerfilter::rtftok::RTFTokenizer::resolveParse() /sw/source/writerfilter/rtftok/rtftokenizer.cxx:2011:37 > #22 0x7f6e9ad4ef4f in writerfilter::rtftok::RTFDocumentImpl::resolve(writerfilter::Stream&) /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:844:27 > #23 0x7f6e9bd39f91 in (anonymous namespace)::RtfFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sw/source/writerfilter/filter/RtfFilter.cxx:164:20 > #24 0x7f6ef659a6a4 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) /sfx2/source/doc/objstor.cxx:2719:34 > #25 0x7f6ef654cf40 in SfxObjectShell::DoLoad(SfxMedium*) /sfx2/source/doc/objstor.cxx:767:23 > #26 0x7f6ef67df024 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1991:36 > #27 0x7f6ef703d0f0 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) /sfx2/source/view/frmload.cxx:725:28 > #28 0x7f6ec073ee16 in framework::LoadEnv::impl_loadContent() /framework/source/loadenv/loadenv.cxx:1180:37 > #29 0x7f6ec0735cb2 in framework::LoadEnv::start() /framework/source/loadenv/loadenv.cxx:415:20 > #30 0x7f6ec072e172 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) /framework/source/loadenv/loadenv.cxx:311:5 > #31 0x7f6ec0729554 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/loadenv/loadenv.cxx:167:14 > #32 0x7f6ec07fe176 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx:592:16 > #33 0x7f6ec07fe396 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx > #34 0x7f6ed3d9c8c9 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:72:62 > #35 0x7f6ef13e8d62 in UnoApiTest::loadWithParams(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /test/source/unoapi_test.cxx:126:19 > #36 0x7f6ef13e7e98 in UnoApiTest::loadFromURL(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:108:5 > #37 0x7f6efe61e0c7 in SwModelTestBase::loadURL(rtl::OUString const&, char const*) /sw/qa/unit/swmodeltestbase.cxx:384:5 > #38 0x7f6efe632c07 in SwModelTestBase::createSwDoc(char const*, char const*) /sw/qa/unit/swmodeltestbase.cxx:433:9 > #39 0x7f6efe0c635f in (anonymous namespace)::testAllGapsWord::TestBody() /sw/qa/extras/rtfexport/rtfexport2.cxx:771:5 (<https://ci.libreoffice.org/job/lo_ubsan/3418/>) Change-Id: I70bd88050887c8b6c747707f2ea3b89802c7b468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-01-08Revert "convert RES_ATTRSET_CHG to SfxHint"Stephan Bergmann
This reverts commit 404fbec25740406e3b926844f3bd0f324dc38b8c. Reason for revert: It's follow-up fix bbb53997c3a6890567ee991aed8502b397dcb7a6 "fix ubsan failure" had to be reverted (because it conflicted with a revert of cc56bf56e170492e414a975ad8c07c41ed72e1a4 "convert RES_OBJECTDYING to SfxHint", which in turn is known broken and thus needed to be reverted for now), so revert this known-broken commit for now as well. Change-Id: I4e65c7113e1e5bfdb9841c98bee3712a1beb12ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179941 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-01-08Revert "convert RES_OBJECTDYING to SfxHint"Stephan Bergmann
This reverts commit cc56bf56e170492e414a975ad8c07c41ed72e1a4. Reason for revert: It causes CppunitTest_sw_uwriter CPPUNIT_TEST_NAME=SwDocTest::test64kPageDescs to fail with > /sw/source/core/attr/format.cxx:273:29: runtime error: downcast of address 0x6140000e1840 which does not point to an object of type 'SwFormat' > 0x6140000e1840: note: object is of type 'SwModify' > 00 00 00 00 b0 e1 74 97 df 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwModify' > #0 0x7fdf8a31ca65 in SwFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/format.cxx:273:29 > #1 0x7fdf8d066efe in SwFrameFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/atrfrm.cxx:2766:19 > #2 0x7fdf8a2d51f2 in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:231:18 > #3 0x7fdf8a2d2c5a in SwModify::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:222:5 > #4 0x7fdf8a2d07bd in SwModify::~SwModify() /sw/source/core/attr/calbck.cxx:145:15 > #5 0x7fdf89b267c5 in sw::BroadcastingModify::~BroadcastingModify() /sw/inc/calbck.hxx:242:59 > #6 0x7fdf8a319f52 in SwFormat::~SwFormat() /sw/source/core/attr/format.cxx:208:1 > #7 0x7fdf8d064426 in SwFrameFormat::~SwFrameFormat() /sw/source/core/layout/atrfrm.cxx:2705:1 > #8 0x7fdf8d0644d8 in SwFrameFormat::~SwFrameFormat() /sw/source/core/layout/atrfrm.cxx:2677:1 > #9 0x7fdf8b42be68 in std::default_delete<SwFrameFormat>::operator()(SwFrameFormat*) const /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unique_ptr.h:95:2 > #10 0x7fdf8b454cc4 in std::__uniq_ptr_impl<SwFrameFormat, std::default_delete<SwFrameFormat> >::reset(SwFrameFormat*) /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unique_ptr.h:203:4 > #11 0x7fdf8b38aa7e in std::unique_ptr<SwFrameFormat, std::default_delete<SwFrameFormat> >::reset(SwFrameFormat*) /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unique_ptr.h:501:7 > #12 0x7fdf8b3434a6 in SwDoc::~SwDoc() /sw/source/core/doc/docnew.cxx:625:23 > #13 0x7fdf8abc1dd5 in SwDoc::release() /sw/source/core/doc/doc.cxx:136:9 > #14 0x7fdf8c2cbc16 in rtl::Reference<SwDoc>::clear() /include/rtl/ref.hxx:193:19 > #15 0x7fdf9102a534 in SwDocShell::RemoveLink() /sw/source/uibase/app/docshini.cxx:445:16 > #16 0x7fdf910295bd in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:373:5 > #17 0x7fdf9102a728 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:363:1 > #18 0x7fdfda648fca in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:230:9 > #19 0x7fdf89b2801f in rtl::Reference<SwDocShell>::clear() /include/rtl/ref.hxx:193:19 > #20 0x7fdf89ac3f0c in SwDocTest::tearDown() /sw/qa/core/uwriter.cxx:1977:17 (<https://ci.libreoffice.org/job/lo_ubsan/3425/>) Change-Id: Ib4866bcfc71e2e3358a8f860cc19efa3f6349885 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179925 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-01-08Revert "fix ubsan failure"Stephan Bergmann
This reverts commit bbb53997c3a6890567ee991aed8502b397dcb7a6. Reason for revert: It conflicts with a revert of cc56bf56e170492e414a975ad8c07c41ed72e1a4 "convert RES_OBJECTDYING to SfxHint", which in turn is known broken and thus needs to be reverted for now (see comment at <https://gerrit.libreoffice.org/c/core/+/179781/6#message-65721cd380de7681cd9ade644da755e6549e23f7> "convert RES_OBJECTDYING to SfxHint") Change-Id: I8212d8ca609b45a4d9399e492727b364fa0a7b50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179940 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-01-08libpng: upgrade to 1.6.45Xisco Fauli
All three patches are upstreamed. Downloaded from https://kumisystems.dl.sourceforge.net/project/libpng/libpng16/1.6.45/libpng-1.6.45.tar.xz?viasf=1 Change-Id: I61d336704b96e2a25d92b4512507cc168648ddec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179930 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-08Simplify using designated initializersMike Kaganski
Change-Id: I73d666a0aa4a41e8e73cb701161be1da6fd59d0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179942 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-08Close handles properlyMike Kaganski
Change-Id: If8620229d41ae9b6c0a1714967a8bb6d51d3ba0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179939 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-08In dark mode, configuration of master page is checked for auto color.Gökay Şatır
This works for standart pages. But notes pages don't have a style property in their master pages. This commit, when libreofficeKit is active, uses corresponding standart page's master page properties for notes pages. Used only for background colors. Change-Id: Ib1115a4fbc87ecd94f9bb44b43268b9578734950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179929 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-08python3: update python3_EXTENSION_MODULESXisco Fauli
Change-Id: Ia636690f0dd9497e62ac9fd7a1ed4d00e71cc299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179896 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-01-08Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 703c344328b4751e2c6a6477323798848c5594d7 - tdf#164549 PDF/UA requires tagged PDF + Improve "How to get" Change-Id: Iaa8591f5ff65ddb687436c1e3b18191620c36bff Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179915 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2025-01-08sdext: adapt xpdfwrapper to poppler 24.12Michael Stahl
Change-Id: Ia47edf2ac821e3ef5c40f7582253f894eac74060 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179902 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2025-01-08sw: stop including .cxx files in Writer testsMiklos Vajna
The remaining 2 classes are not used in multiple .cxx files, so just move them closer to their only user. Change-Id: I7c7b295e21ea97acf33d7f4a60a61b25788ab5c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179926 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-08tdf#130857 qt weld: Introduce QtInstanceToolbarMichael Weghorn
Introduce QtInstanceToolbar as the native Qt implementation for weld::Toolbar that uses a QToolBar widget. This mostly adds the basic structure and lets Qt{,Instance}Builder create an instance of the class when encountering a "GtkToolbar" object in a .ui file. The actual logic for the QtInstanceToolbar methods still needs to be implemented. Calling them currently triggers an assert. Change-Id: I2734e5b931d5cb9608ec4d01222634a8ffada299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179883 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-08Update git submodulesShantanu Oak
* Update dictionaries from branch 'master' to 259e906688a224e25ce12c48efb5ca7037a84760 - added Marathi hyphenation and thesaurus Change-Id: Ic6e08de69edf376612d5d4fd275baa04e68a0a5d Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179872 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Marco Pinto <marcoagpinto@sapo.pt>