summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-06-10Fix webdav lock refresh returning 0 instead of true when successfulJulian Kalinowski
With commit 58b84caca87c893ac04f0b1399aeadc839a2f075, the NeonSession.LOCK returns "theRetVal" from ne_lock_refresh when successful. But when there is no error, theRetVal will be NE_OK, which is 0, so the method returns false instead of true. This results in lock refresh being stopped after the first refresh, so WebDAV servers will unlock the file after the lock timeouts. Users will see error messages regarding lock timeouts and lost updates are possible. Fix this by adding a return statement when theRetVal == NE_OK. Change-Id: Ie43131fca96e1cfbe932444906b742958a719b26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96023 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-10tdf#133858 opening spreadsheet with large array formula takes 10 minsNoel Grandin
the spreadsheet has lots of SUM(IF over a whole column. Which results in us allocating a matrix with 1 million rows, which is rather slow to process. So reduce the matrix to the data that is actually there. We can only do this for some opcodes, because other opcodes act differently when referencing empty space, so for now I only perform this optimisation for the opcode in use in this spreadsheet. This takes the load time from 5m to 3s on my machine. Change-Id: I41fe9afcb0fbdf2a928a19c44a0f291a1247a41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-10loplugin:buriedassign in swNoel Grandin
limited this only fixing assignments inside "if" statements, since other things are harder to change Change-Id: If3188a3e3d5fcd94123211c97fee097ece5e2797 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-10Update git submoduleszdposter
* Update dictionaries from branch 'master' to de00c9bd1dd88e8361b606996b0773d30bee772c - upgrade Slovak spellchecking Change-Id: Id3bc65f957187d2c2ba98ba76a1ed4e9fab72c97 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/95999 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-10sd signature line: localize signature graphicMiklos Vajna
Now the svg template is free from user-visible strings. Change-Id: Ibdbb73bbd1a1088a66dc25a5669df567b338b375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96021 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10tdf#132845 discard pending page change if user clicks in documentCaolán McNamara
Change-Id: Icce91c9afac143190dc5c7d823d745dc2434c1a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96013 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10tdf#132725 sw: SwUndoDelete: don't group if flys are be deletedMichael Stahl
The fly would not be deleted by CanGrouping() but would be deleted later in RedoImpl() via the IsAtStartOfSection() check so just force a new Undo action in this case. (regression from 91b2325808a75174f284c48c8b8afc118fad74e4 and 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I68f9f6b7fd0306bc0853a370b1030463a0024edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96002 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-10Improve a SAL_WARN messageStephan Bergmann
Change-Id: I31f809e5f6fec109bd0fb58e8290323500d44f13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-10CppunitTest_sc_uicalc: minimize test documentXisco Fauli
See https://gerrit.libreoffice.org/c/core/+/90265 Change-Id: I014b424d760e0236cbeaa39ea1b03b57809a22bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96000 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10tdf#42949 Fix IWYU warnings in shell/Gabor Kelemen
Except for MAC/WIN specific parts (i.e. most of it) Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia14fb27c047e0e69f81386212aa25344f1297e05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95663 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-10uitest: Add support for Calc / Format cell / background color selectorShiko
- Add wrapper for the color-win set - Add the factory function in the correct class - Add a demo for cell background color and recent color selector - Extend the ability of ComboBoxUIObject to be able to select with text Change-Id: Ie84ba7fff2f84c3fec7f5adbb5b1cdc6c80729f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95667 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-06-10fix reseting WeakReference when moving a ref to another ref.Tomaž Vajngerl
In ViewIteratorImpl::Reverse we std::move a reference, to a local variable, however the reference was not reset correctly, which caused a crash. The issue is that a mpWeakConnection in WeakReference always needs to be non-null as shown in reset(reference_type* pReference) method. In the move constructor of WeakReference, we just std::move the reference like: mpWeakConnection = std::move(rWeakRef.mpWeakConnection); This means rWeakRef.mpWeakConnection will be reset to null, which is not what is expected, so what is missing is to instantiate rWeakRef.mpWeakConnection by calling reset(nullptr) or using the added reset() method. This also adds a test for LOKit PDF search as this is the case where the crash has been reproduced. It happens because of a call to: ... std::move(maPosition.mxObject); in the method ViewIteratorImpl::Reverse() Change-Id: I43692554ba4f6231d00091269b7c902ab5cbc11f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95995 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-10Adapt to new Clang trunk -Wuninitialized-const-referenceStephan Bergmann
> error: 'error' diagnostics seen but not expected: > File compilerplugins/clang/test/unusedfields.cxx Line 143: variable 'x' is uninitialized when passed as a const reference argument here and > error: 'error' diagnostics seen but not expected: > File compilerplugins/clang/test/writeonlyvars.cxx Line 93: variable 'm_bar10' is uninitialized when passed as a const reference argument here since <https://github.com/llvm/llvm-project/commit/ 170b6869b563dd3393d99f3e03d389b9058d5f24> " [Clang] Add a new warning to warn when passing uninitialized variables as const reference parameters to a function" Change-Id: I27136e387f7a14fd24a3639187b668d6ed283070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95994 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-10blacklist old intel driver 0.16.2 for Vulkan (tdf#132681)Luboš Luňák
Change-Id: I3d2e0f6a1f43fe44a8396b53806e2f2c59c46d6c
2020-06-10PPTX import: handle adjust values from both the shape and its placeholderMiklos Vajna
The direct problem is a crash in CustomShapeProperties::pushToPropSet(), the code just hoped that the input file doesn't have more adjust values than the # of adjust values we allocate based on the preset type. Fix the crash, but there is a deeper problem here... The shape can inherit custom shape properties from a placeholder, then later it can have its own custom shape properties. When it comes to adjust values specifically, we used to just append own adjust values to the end of the list. This way we got the double of expected adjust values. And later rendering took the N expected adjust values from the start of the 2N element list, so we used the adjust values of the placeholder, not of the actual shape. Fix this by clearing the custom shape geometry once we know we have our own preset geometry. Change-Id: I09f669bf59c33b552b906733d323eba7af5548e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95993 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10Use xmlFreeDoc since pXhpFile is a xmlDocPtr (l10ntools/treemerge)Julien Nabet
Change-Id: I32fb8824aa91464d2198c76ba9357c82ec87a0ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-10sd signature line: set graphic of signature shapeMiklos Vajna
All placeholders are replaced, but the template is still English-only. Change-Id: Ia361447ff0a69fa0f80db4af07274d1a764a3d64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95991 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10detect inconsistent SUMIFS() ranges when range reducing (tdf#132431)Luboš Luňák
03b352b9599514e4e244e1907510713cf1331284 introduced reducing of the SUMIFS range to the cells that actually contain data, but tdf#132431 introduces incorrect ranges that lead to negative indexes, and correctness checking of ranges comes only after the use of these indexes. Change-Id: Ia13db83d222310d470a0a8ecef51dbdd7992d479 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95898 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-10tdf#132137 Rename Default Style in Calc.Srijan Bhatia
Change-Id: I0f7c5ffc64b2387fbb63bb5724594480d3135f58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95484 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-10tdf#91250 Chart DOCX Import: Fix decimal place formatting issueBalazs Varga
Use UNLIMITED_PRECISION in case of GENERAL number format of CATEGORY axis labels in embedded charts, just like Calc does. Change-Id: I30cb50955c67824bd1aa88fb139618ce0f0974fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95802 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#133632 Chart DOCX Import: fix percentage number formatBalazs Varga
Set the LinkNumberFormatToSource to false only if we have an inner data table and the labels are shown as values. Regression from commit: e0da00d655ecca5986eea3812a8a670c6adbc40f (tdf#132174 Chart DOCX import: fix label number format) Change-Id: I879c5d81709995bfa49c18e0c84aaf6dc3dea41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95493 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#133065 tdf#133602 DOCX export: fix OLE wrap regressionAttila Bakos
caused by commit 2150fdc7d0f63288ac56c33cb898589512057642 (tdf#131539 DOCX export: fix position of OLE objects). The wrap setting of the anchored OLE object were not preserved. Note: It needs also z-order export for background mode. Co-authored-by: Tibor Nagy Change-Id: I7f8c48019157dda00bcc97a490c5f582eccf1b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94220 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10ignore WB_DIALOGCONTROL state of parent if we're a floating windowCaolán McNamara
for tab key cycling When WB_DIALOGCONTROL is set the control has sub controls in it and pressing tab cycles through those widgets, and back to the start. If a WB_DIALOGCONTROL control is inside a WB_DIALOGCONTROL control the toplevel container is the one that processes the tab. But we don't want a floating popup window, like ScCheckListMenuControl, which has its own toplevel floating window, to pass the tab key to its parent ScGridWindow for that to process, we want it to stop at the ScCheckListMenuControl level so it will cycle back to ScCheckListMenuControl's first child after passing the last one, not into some other child of ScGridWindow. ScGridWindow is unusual as a document window to have WB_DIALOGCONTROL set for its own reasons: i.e. "WB_DIALOGCONTROL needed for UNO-Controls" so this problem does't arise in other applications Change-Id: Ib1f02ca4b0bf5bf3b2ed00b5838f8df2e3eb5b7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95957 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10tdf#132597 sw: fix inconsistent handling of ExcludeFlyAtStartEndMichael Stahl
IsDestroyFrameAnchoredAtChar() checks the position but the only caller, SwUndoInserts::UndoImpl(), really wants to exclude the entire nodes, see IsCreateUndoForNewFly(). (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I763ad3b7d82af03f6910dcf34315f793d090c62e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95952 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-10tdf#130802 SwTextBoxHelper::syncFlyFrameAttr: fix draggingAttila Bakos
Dragging the selected shapes resulted broken text boxes: the text showed outside of the shapes. This is fixed in the case of paragraph, character and page anchoring. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Iaea65ee26bad60c09ada4875636416d4a7c7e80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95136 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#133641 sw: fix crash double-clicking CH_TXT_ATR_FORMELEMENTMichael Stahl
Only search for separator if there is one. (regression from 1c94842e053a20a739a181d38a35c324df3e62a7) Change-Id: I6697faa7cb83cab48084f9710f8c5018b9e738e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95905 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-10tdf#133457 DOCX import: fix frame position regressionTibor Nagy
caused by commit f5636817e7677a3081263df9004940a7d5ac54af (tdf#112287 DOCX frame import: fix default vAnchor). Co-authored-by: Attila Bakos (NISZ) Change-Id: I6fe16ff274d6a2fa4a335c7790ecd0f01641a6fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95035 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#130805 SwTextBoxHelper::create: fix frame position in shapeAttila Bakos
Text frame added by menu option "Add Text Box" of a shape was misplaced if there were more paragraphs after the shape anchor position. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I8a47aff57d3a60f7dbd2a1b75296e2664a1f745f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94822 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#133268 Update Calc's conditional format iconsRizal Muttaqin
Change-Id: I7057d813c125bd075ebdd9d6bd5879cd1d8b9980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95966 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-10Revert "enable backtraces for unit tests on macos"Noel Grandin
This reverts commit 756c027198adc5212d46d72e0628c90698652af5. Reason for revert: It never did work (was a test), and it cannot work because cores are all stored in /cores under mac, which means we cannot tell which cores belongs to which unit tests, or even if it belongs to the current build on jenkins Change-Id: I866173a41077dbb40d61fb81953d7a92f7d0789e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95888 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-10Give the legend checkbox a labelMuhammet Kara
Change-Id: I95e8910e96335a03ebad6dd46255a902df2c47a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95860 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-10tdf#133643: sw: Add unittestXisco Fauli
Change-Id: I1b4dbea5e858efa8f22bb568dc5fa95d71f1b792 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95962 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-10xmloff: create XMLAutoTextEventExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Ibb3bc2afba00ff962e3ed4f14a5e5a3c735a1a29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95963 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-10Use equal number of leading and trailing context lines in patchTor Lillqvist
Change-Id: Id9fbf34a4ad17aa4edcabaa232b8a4e98dfcb847 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95849 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-10tdf#131070 DOCX import: fix indentation of direct numberingLászló Németh
Indentation came from direct numbering has precedence over table style. Also paragraph style based right indentation affects DOCX list items with not paragraph style based numbering, unlike Writer. Keep all indentation values using direct paragraph formatting. Change-Id: Ia66645269a4fcd06f0be4f02c775007c83d22a0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95954 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10lokit: fix autofilter window position...Dennis Francis
when client zoom is not 100%. The fix and the reasoning is same as that in lokit: fix validation dropdown's wrong position 3405f7f1b19738cad57b58259105ec87c1108466 Conflicts: sc/source/ui/view/gridwin.cxx Change-Id: I04837721d82b1e178cf5aa1130bbdaf77d13edae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93240 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 86019fc76473cde457ecf1634bcff9df60ad7cbf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95965 Tested-by: Jenkins
2020-06-10tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMichael Warner
Change-Id: Id747848b222f69af3293a2095a62542f1e1116d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95215 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-06-10tdf#133819 support for tristate checkboxesRizal Muttaqin
Change-Id: Ie98700652d76db10e8f8b587016ddae9253ddaac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95956 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-10Enable cross-compilation of xmlsec on macOS (without pkg-config)Tor Lillqvist
Change-Id: If08dde33dbf19afc9ce82bfa42412a642187a56f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95848 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-09sd signature line: select certificate after drawing the shape's rectangleMiklos Vajna
Also move the shape-type-specific setup to FuConstructRectangle::SetAttributes() where the rest of the shape types are handled. Change-Id: I9ecf94957ec82ba187f2767b01d96fb14de2b657 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95958 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-09Resolves: tdf#132540 theme the unwanted popover into invisibilityCaolán McNamara
Change-Id: If18c5c1de40a4f93d062265d41a2bff72555d6c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95964 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09sd doc model xml dump: show grab-bag of shapeMiklos Vajna
Which is contained directly for some reason, not inside mpProperties. Change-Id: I0f7d2d5afbeae2d399710d5ce271f3ad4ab9866d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95913 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-09tdf#133822 mirror GtkSalObjectWidgetClip location for RTLCaolán McNamara
Change-Id: I4ab4a0fb8fc343ee9a4c66c58e20583482958f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95951 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09tdf#133462 cursor missing in SQL textboxCaolán McNamara
(and spell checking, calc page format header/footer dialog, etc) since... commit c2f8929ed76085bc81f390f90e06bd6781206537 Date: Wed May 29 23:33:25 2019 -0400 vcl: sfx2: LOK: Support per-view popup windows I feel this is a mismerge where the point of commit b9c10ee923308f336a694bbc0212396ed5317b6a Date: Wed Apr 3 12:02:13 2019 +0100 weld ClassificationDialog to allow cursor drawing to a non-Window OutputDevice got clobbered Change-Id: If693fd0ee83afc6e7f0ddce7b43b8cb6e3327116 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09tdf#129856 invalidate old internal border if we scrollCaolán McNamara
and will redraw a new one Change-Id: I2438af94e54f31c617cc183c61fbaaef31b5601f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95911 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09notebookbar: simplify custom widgetsSzymon Kłos
Change-Id: I0176a9852a0f405fba7b6308e28abf2ca0ae280e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95900 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-06-09CppunitTest_sw_layoutwriter: disable unstable testShapeAllowOverlap on WindowsMiklos Vajna
Seen failing e.g. at <https://ci.libreoffice.org/job/gerrit_windows/66586/console>, but interestingly never on Linux. Change-Id: Iba701f642432c8d5785d3c4c40e4914633ff0e5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95908 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-09tdf#132596: sw: Add UItestXisco Fauli
Change-Id: I899de72a02a7501917b13346d304338bb4548ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95902 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-09tdf#133169: sw: Add UItestXisco Fauli
Change-Id: I6d86e8f8ef1b1ffe32e45c7ead75387f6fcee2fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95901 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-09tdf#128502: Try to support multiple documents in LibreOfficeKit-using processTor Lillqvist
The LibreOfficeKit-specific code typically has assumed that all the "views" (SfxViewShell instances) are for the same document, because all LibreOfficeKit-based application processes (including the "kit" processes in Online and the iOS app) so far have only had one document open at a time. It is now possible to pass several document file names on the command line to gtktiledviewer and that is an easy way to demonstrate how badly it still works even with this patch. Introduce a unique numeric document id that is increased in the LibLODocument_Impl constructor. Add APIs to access that. When iterating over views, try to skip views that are not of the document visible in the "current" view, if we know what the "current" view is. Also add a couple of FIXMEs at places where it is a bit unclear (to me) whether it is correct to iterate over all views, or whether only views for the "current" document are what we would want. Change-Id: Id5ebb92a115723cdeb23907163d5b5f282016252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95353 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-30 13:23:02 +0000