summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-23tdf#83830: Remove experimental status from Page DeckSusobhan Ghosh
Change-Id: I4214d92947734bab954a07118cdee96950a97814 Reviewed-on: https://gerrit.libreoffice.org/26591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-23sw: fix STL asserts in lcl_MoveAllLowerObjs *again*Michael Stahl
Comment added in cf91483690291272f48ff95c1aebd165da8ae4f0 evidently insufficient. (regression from b415494bf0468b74318b61f114e2ff4ae68c00ee) Change-Id: I9a017aefc3a77b0760fcdc3b8e43ff7c6ac516ac
2016-06-23sfx2: exception on storage commit is an error (related: tdf#91807)Michael Stahl
For no good or obvious reason, SfxMedium::StorageCommit_Impl() swallows embed::UseBackupException if there is a pTempFile, which (as the comment claims) is "always now". This results in the temp file actually being copied to the user-visible file and the SaveAs "succeeding", when it clearly did not. Also move the exception throwing to the end of ZipOutputStream::finish() to avoid more memory leaks. Change-Id: I448cc43291754ef20adfa6b65916282fcc365a11
2016-06-23tdf#100562 Add constraints for function DBWinfried Donkers
Constraints in http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part2.html#DB were not all checked. Change-Id: Ife9ff7ce73d239efd0a67625990493db770f0c20 Reviewed-on: https://gerrit.libreoffice.org/26606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-23add COUPPCD test caseZdeněk Crhonek
Change-Id: I5e0e02657516e702b00e2010fc9a8c61fd9eff68 Reviewed-on: https://gerrit.libreoffice.org/26577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-23add COUPDAYS, COUPNCD, COUPNUM test caseZdeněk Crhonek
Change-Id: Id0df7161f8ae687a7cca17d7a25f83a5d9417397 Reviewed-on: https://gerrit.libreoffice.org/26581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-23add COUPDAYS test caseZdeněk Crhonek
Change-Id: I0a322f555aa27d0ebff490f38d63ff8034f29668 Reviewed-on: https://gerrit.libreoffice.org/26580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-23add AND test caseZdeněk Crhonek
Change-Id: I305749ac4192a656c692aff6dcdec45e0d914f23 Reviewed-on: https://gerrit.libreoffice.org/26575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-23Resolves: rhbz#1349501 gtk3: smooth scrolling events can be disabled...Caolán McNamara
by the user with GDK_CORE_DEVICE_EVENTS=1, and so manage to disable their wheel scrolling Change-Id: I7df63f738983c90dea75b9f43a36133910446aba
2016-06-23integrate libzmfAleksas Pantechovskis
Change-Id: I0c7ea5b56ea4ed4839ff38798c0b915aaca81774 Reviewed-on: https://gerrit.libreoffice.org/26574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-06-23vcl: add initial PDF import-as-graphic filterMiklos Vajna
This allows Insert -> Image e.g. in Writer to read a PDF file, and insert the metafile equivalent of the first page into the document. Currently the original PDF document is lost on import (unlike when inserting an SVG file). Change-Id: Ib0472c5d9bd9a1da054353fa3a3a638a1052721e Reviewed-on: https://gerrit.libreoffice.org/26586 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-23tdf#76349 writer: treat single-column break as page breakJustin Luth
Writerfilter imports docx-defined column breaks that exist without being in a column. Word treats these as if they were a page break. Writer basically just preserved and ignored them. I limited the fix to only consider SVX_BREAK_COLUMN_BEFORE since writerfilter is only given “column break” and treats it as column_before. Change-Id: I0d974441d53243c4426048dd7cb60b3897b803f6 Reviewed-on: https://gerrit.libreoffice.org/26181 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-23Clean up uses of Any::getValue() in svlStephan Bergmann
Change-Id: I2005ce59d6211181ed039eaff60ffd31084e1d40
2016-06-23tdf#100222: Inform user that a restart is needed after toggling OpenCL useTor Lillqvist
Change-Id: Ic33cb02440276bc0601c86f2c9eab7d74a6b9874
2016-06-23Resolves: tdf#100460 queryContentCells doesn't count annotations...Caolán McNamara
since commit c06dbbe7594c2a0b5a5b19f8e183d9c421e6e094 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Thu Feb 23 23:36:49 2012 +0100 remove mpNote from ScBaseCell Change-Id: I281a207e26aec8886b1f46b9279e1135b61586da
2016-06-23Improve OpenCL logging and warningsTor Lillqvist
Explicitly catch and report the 'Unhandled' and 'OpenCLError' exceptions, too, in DynamicKernel::create, instead of relying on a catch(...). (Actually not sure why we need three separate classes of OpenCL handling exceptions.) We have the code to show the file and line where something exceptional (or actually not so exceptional) happens with OpenCL, so make use of that then. It is a perfectly normal thing to throw (and catch) at least the UnhandledToken and Unhandled exceptions (when compiling a formula and noticing that we don't want to use OpenCL for it after all), so it does not make sense SAL_WARN about them. Just SAL_INFO is fine. Change-Id: I56770f47622cb4bc40f2216c5e78d3da3c7c9adf
2016-06-23Related: tdf#100460 GetNotesInRange doesn't count last cell in rangeCaolán McNamara
e.g. open document from tdf#100460 and select select A20:A21 and right click and there is a hide comment entry. Shrink the selection to just A20 (which has the comment in it) and the right click menu has no hide comment entry in it. std::for_each(it, itEnd means it < itEnd but here we want the rows indicated by nStartRow <= nEndRow so we need to increment itEnd by one to get the right range Change-Id: I48e8c0748f520671e09f04b16961bf9729960317
2016-06-23Improve readability of OUString concatanation in LocalizationMgrMuhammet Kara
It is more readable and more efficient as a bonus. See: https://goo.gl/jsVAwy: Change-Id: I56ba7aa1477361a686ffb50955525b73cce24197 Reviewed-on: https://gerrit.libreoffice.org/26585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23map MenuToggleButton to GtkToggleButton with a custom menu propertyCaolán McNamara
we don't have non-menu ToggleButtons yet, so thats not done here. since we first started with GtkPushButton:menu_attrib to indicate menubuttons gtk has grown menu buttons, but they don't have the idea of a gtktogglemenu button, so this attribute still has a role to play I guess Change-Id: Iebfe5ccf996e22784cf9aaf2bcf367eed79ae686
2016-06-23tdf#83830: Page Styles PanelSusobhan Ghosh
Added new helper class to svx for numbering Change-Id: Ie7db4059568024e9bed460fcf7c9215bd2ef788f Reviewed-on: https://gerrit.libreoffice.org/26020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-23loplugin singlevalfields, need to check default constructor code tooNoel Grandin
Change-Id: Idcc8de6f1d403a57c59e84774bd7a97e2f3fc224
2016-06-23loplugin:unusedvariablecheckStephan Bergmann
Change-Id: Ia9c5ea707990d03dd4042c2e0a791976cc1b5f74
2016-06-23-Werror=unused-functionStephan Bergmann
Change-Id: Ib579e8896a751383d31c1dbf7e6ebf5c0774a976
2016-06-23-Werror=unused-but-set-variableStephan Bergmann
Change-Id: I0b3586bb3acca4075b26790a8dfe3f97d6921feb
2016-06-23Makefile: move check-if-root earlierMichael Stahl
Somebody who might invoke make as root might also invoke make with -j, so don't start building in that case. Change-Id: I0c87aba948cd78a23ad4c49f880700f65684424c
2016-06-23new loplugin: singlevalfieldsNoel Grandin
look for fields that only have a single constant value assigned to them Change-Id: Iafcd37fdb8a8119bbc00f92981a1a01badf9c5a2
2016-06-23loplugin:implicitboolconversionStephan Bergmann
Change-Id: I21aeb9504be38e4a6b55892730131a878234ced3
2016-06-23remove some more (void) style function definitions/declarationsNoel Grandin
found with git grep -nP '^\s*void\s*\)' Change-Id: I1206031cf957cb6f957cae64ec5cae1280bda694 Reviewed-on: https://gerrit.libreoffice.org/26590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23tdf#67302 Resolving tablesSupplier name clash for postgresqlPrashant
Change-Id: Ic9bedc678699e136c09a51575f1d27131c5ffd29 Reviewed-on: https://gerrit.libreoffice.org/25069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-23tdf#96607 'Save as' doesn't update global auto-recovery stateanwilli5
The auto-recovery service maintains a list of structures (one for each open document) containing information needed to carry out the auto-save functionality. One such piece of information is the location of the backup file, stored in a struct member named 'OldTempURL'. At every auto-save interval, this list is iterated through and a function (implts_saveOneDoc) is called during each iteration to save the current state of the associated document. The algorithm works as follows: 1. A new backup file URL is chosen so as not to conflict with any already existing backup files in the backup directory. This URL is based on the file name and incorporates a number (starting at 0) that is incremented until a name is chosen that doesn't conflict. 2. The document is saved to this new backup file URL 3. The previous backup file (indicated by its structure's 'OldTempURL') is deleted 4. The new backup file URL is stored (in its structure's 'OldTempURL') for the next time the file needs to be saved. Assuming you start with a new Writer doc and then make some changes, when it is time to auto-save, the backup file name 'untitled_0.odt' (excluding path) will be selected, the latest state of the open file will be written to that backup file, and the full URL for the backup file will be saved into the struct 'OldTempURL' member. The next time changes are made and an auto-save occurs, this algorithm will result in the name 'untitled_1.odt' being selected, the file contents saved into this new file, 'untitled_0.odt' being deleted, and the full URL for the new backup file being saved in 'OldTempURL'. The third time through results in 'untitled_0.odt' being selected (since this file doesn't exist on disk), and subsequent iterations of auto-saving cause the backup file name to alternate between the two aforementioned. The problem occurs during a 'Save as' operation. When this happens, the backup file is deleted (which is fine - it was just saved, and the next auto-save will back it up) but 'OldTempURL' is not properly reset (see below for more info.) During the next auto-save, 'untitled_0.odt' will be selected for the new backup file name (since no file exists by this name), and one of two things will happen (based on how many auto-saves have occurred): 1. 'OldTempURL' points to 'untitled_1.odt', and the algorithm above continues to work correctly (at least in that it continues to backup file contents.) 2. 'OldTempURL' points to 'untitled_0.odt', the name chosen for the new backup file. In this case, the document contents will be saved to this file (step 2) but then the file will be deleted (step 3). 'OldTempURL' will maintain this URL from then on out, causing this case to be hit for all future auto-save intervals. So, 50% of the time (30 minutes out of every hour) auto-save will stop backing up file contents on a 'Save as'. The function that handles the 'Save as' case (implts_markDocumentAsSaved) clears 'OldTempURL' and sets other relavent struct members for a local variable copy of the global struct, but doesn't copy them back. :( These changes are effectively lost when the function returns. There are several other cases where this appears to be happening as well, but more work is needed to determine whether this is actually the case: - implts_prepareSessionShutdown - implts_saveDocs, handling the 'dangerousDocs' and in a few other places - implts_openDocs - implts_resetHandleStates Also, there is some JUnitTest code for auto-save, but it is currently disabled (and fails to run successfully.) It'd be great to get these working again, or to just write python equivalents. Implementing this would like take me a while, though, so for now I just tested manually to ensure that this fixes the issue. When I have some more time I'd like to work more on this, but I wanted to send this patch in for now to address bug #96607. This may also address bug #99890, since some of the struct members that don't make it into the global state relate to the file name. I haven't explicitly tested this case, though. Change-Id: Ic702d6f78e60c7cf828a1564ccca118dd45d152b Reviewed-on: https://gerrit.libreoffice.org/25948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-23tdf#100153 modify noSmoking shapeZhengqiang Wang
*modify customshapeproperties.cxx fix compile error : make oox dbglevel=2 The define of dumpCode() has been removed by c714b43b0137ad253f51e1c65417c9874b8509e5 *modify presetShapeDefinitions.xml fix noSmoking shape *modfiy oox-drawingml-cs-presets this file is generated by presetShapeDefinitions.xml Change-Id: I383d6b6961b546585035afd8c1a4398385a11914 Reviewed-on: https://gerrit.libreoffice.org/25801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-23tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu
Change-Id: Id3b9abd557f2b8dfc942589362452cbdb0232da9 Reviewed-on: https://gerrit.libreoffice.org/26546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-23tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu
Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683 Reviewed-on: https://gerrit.libreoffice.org/26537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-23tdf#97872 File association in Windows registryskswales
Fix for double backslashes in paths to programs in shell/open etc. registry entries for all non-native file types such as .doc that are mapped by installer to use scalc.exe/swriter.exe etc. Change-Id: Ice8033d4fee079c0fb6d8f84e00ebd784e85d135 Reviewed-on: https://gerrit.libreoffice.org/25849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-23package: fix exception handling in DeflateThread (related tdf#91807)Michael Stahl
In the bugdoc of tdf#91807 there are at least 49 corrupt zip streams that raise exceptions in the DeflateThreads. Because the maximum allowed number of threads happens to be 48, this results in an infinite loop in ZipOutputStream::reduceScheduledThreadsToGivenNumberOrLess(). (regression from 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14) In case an exception is thrown, don't re-throw it immediately, which might cause trouble such as leaking all of the ZipOutputEntry instances in m_aEntries. Change-Id: Ia74ab8e46fa1349c049d05dbec3454bfbe7d61d9
2016-06-23vcl: avoid vcl_filters_test crash with ASAN 32-bitMichael Stahl
ASAN usually aborts on operator new[] allocation failure but with allocator_may_return_null=1 in ASAN_OPTIONS it returns null instead; it doesn't throw std::bad_alloc though. Change-Id: I28d67a787e90604c12ad06fd97d265664bd62ef2
2016-06-23Remove unused SfxObjectShell::libreOfficeKitCallback()Miklos Vajna
All clients have been converted to use SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: I793dad5194769f331037b12a1b1afba96ddea4ba Reviewed-on: https://gerrit.libreoffice.org/26584 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-23Simplify dynamic_cast followed by a static_cast.Jan Holesovsky
Change-Id: Ia8b1145d43828a40611e5f59651d9dc6ff7d5360
2016-06-23Introduce FillAutoStyle() method to reduce copy'n'paste.Jan Holesovsky
Change-Id: Ibdb6ae15790cc117d3d8c41c57924f9b22e85cba
2016-06-23support for ms binary format validation in sd module export testsVasily Melenchuk
Change-Id: Ie03b0485bbe8ecaa452f19fbcbfe3bf5829aff68 Reviewed-on: https://gerrit.libreoffice.org/26515 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-23VclPtr: svtools error message dialog doesn't disposeCaolán McNamara
Change-Id: I83640cc60d5e0239d228c749c32f896df5e2d9f2
2016-06-23compilerplugins: move oncevar into storeMiklos Vajna
As suggested by Stephan and agreed by Noel -- as its warnings are not useful in all cases. Change-Id: I3c6034ae9d3c74aeb089a67dc48c1f91a3ea3a21
2016-06-23Revert "desktop: fix loplugin:oncevar"Miklos Vajna
This reverts commit 8dc2873081bff3fe7107d472a91a24af8b67a87d. Instead of working around the warning, the plugin will be disabled, as its warnings are not useful in all cases.
2016-06-23GSoC tdf#87697 START CENTER: Indicate selected thumbnailviewAkshay Deep
Added new "Active" state to PushButton class Active state used in MenuToggleButton class. Active => Pressed + Flyover When hovered in Active state, Active => Flyover only Change-Id: Iece1550b6d742a7ab3c9f4c7516ec855e1a1b6ef Reviewed-on: https://gerrit.libreoffice.org/26470 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-23tdf#46279 Show restart message after extension installationirem
Change-Id: I91feab63b77055b8f73d0fb481a76586b249160c Reviewed-on: https://gerrit.libreoffice.org/24595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23uitest: improve the message of the ui test runnerMarkus Mohrhard
Change-Id: I5026590506b4ddf3db95fb14fe6b0890255a5a25
2016-06-23Updated coreAdolfo Jayme Barrientos
Project: help c23a2a94aae6b2f1290145323460848eff867305 Replace ASCII approximation of trademark symbol with real character Change-Id: I70c466baaaa8e2fbcba8c4c36fd4df6f14cda22b
2016-06-23support for ms binary format validation in chart2 module export testsVasily Melenchuk
Validation is done with Microsoft Office Binary File Format Validator if it is enabled. However binary files are failing validation, so validation is disbled in corresponding tests. Change-Id: I9f6ff5c3dd9e3e3c0bb37ce895e60e38a0b43e9a Reviewed-on: https://gerrit.libreoffice.org/26510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-23starmath: Add a test case for parsing -Takeshi Abe
Change-Id: I0fc0b7e2abbadee2f13d477c5ddd2290f37487a0 Reviewed-on: https://gerrit.libreoffice.org/26563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>