summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-30tdf#124176: Use pragma once instead of include guardsbugrakurt
Change-Id: Ia353a95df0e78e9da2b6fb95c2bc3a6e83c72fcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87738 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-30loplugin:unusedfieldsNoel Grandin
Change-Id: Ifb9c91b3e8d6c2dd3a639a239fa41e7d5c7a4ee6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87735 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-30tdf#129659 DOCX check global footnote contextJan-Marek Glogowski
Since tdf#121441 we parse custom footnotes to get at least the DOCX footnote text, even if we can't represent the formating. This might push additional contexts to the parser stack. Therefore it's now not sufficient to check the current context for a footnote, but one has to check the global parser for a footnote context. The actual bug is the unsupported footnote page break, which was not correctly ignored and added a paragraph context to the stack, resulting in the async substream input and output stack size. Change-Id: I143254e7df37a619cb4efb542b58d3eff3afffa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87114 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-01-30again finally(?) fix Skia Windows widget drawing (tdf#130051)Luboš Luňák
I was correct to see in 202146901b6fbab92 that the black bitmap was in premultiplied alpha, but what I missed what that some controls keep the alpha set at zero (and only some work properly). So go back to the algorithm of synthetizing alpha from the red channel, compute it properly (before it was using alpha channel by mistake), and treat the data properly as premultiplied. This hopefully finally makes all Windows control widgets work. Change-Id: If2716eb8ecf623fcc57ee1db5904edfaee679aa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87734 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-30tdf#45589 sw: create and paint text portions for bookmarksMichael Stahl
Add a new SwBookmarkPortion, derived from SwControlCharPortion. There is no character for the bookmark in the text so the portion has length of 0, which makes things quite a bit more tricky. Formatting: * SwBookmarkPortion is created last in WhichFirstPortion(). * In an empty paragraph the SwTextFrame::FormatEmpty() must be disabled. * If there's a bookmark at the end of a paragraph, SwTextFormatter::CalcAscent() must use the font of the previous character, not the paragraph font, because that could grow the line if it's higher. * The SwMultiPortion complicates matters, because it uses a nested SwTextFormatInfo and thus we need some extra steps to prevent duplicate SwBookmarkPortions; this is particluarly a problem for rotated text portions. - SwTextFormatter::BuildPortions() must advance the outer SwTextFormatInfo's bookmark position because BuildMultiPortion() has already created the SwBookmarkPortion. - If a SwBookmarkPortion is at the start of a SwMultiPortion, it will be created before the SwMultiPortion but must be painted inside the SwMultiPortion because its font is going to be initialised as inside the SwMultiPortion (e.g. it will be rotated) so its position must also be adapted to be inside, and only SwTextPainter::PaintMultiPortion() does the setup for that; add a hack to move it in SwTextFormatter::BuildMultiPortion(). Painting: * Using the original font seems rather difficult, hard to predict what some character is going to look like, and how it scales if the size is increased; use OpenSymbol instead. Unfortunately OpenSymbol doesn't have a good glyph that could be used for both the end of a bookmark and start of another bookmark at the same position. * SwLinePortion::PrePaint() wants to avoid moving the portion half-outside the frame but often it looks better that way (previously it was misaligned, now it's half-outside). * Not sure if it makes sense to draw a field shading in SwTextPaintInfo::DrawViewOpt() too; let's try it out, but dependent on the same IsViewMetaChars() setting as the bookmark character itself, not on the field shading setting. Change-Id: I1ab94afb417221e278dbb3afd6c978a05fc78497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87364 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30sw: fix rotation bugs in SwLinePortion::PrePaint()Michael Stahl
The sign was flipped for the 90° case, resulting in painting too far up the page, ever since this was added in 293ed704cf15107049578c2e6e5ed00dcac2d4fb. In SwControlCharPortion::Paint() rotation wasn't handled at all. Change-Id: I83a7eef8b2f6126e070d8c48f75378b6cf6d50e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87707 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30sw: reformat bit of SwLinePortion::PrePaint()Michael Stahl
Change-Id: Id088e3f73e6bda3c6b11d421a52c59c67446f8a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87706 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30sw: these SAL_WARN_IF should be assert()Michael Stahl
Change-Id: Ifddea3cd34f419d9b8b87a3f913be590ad4d5ce7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87705 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#45589 sw: split text portions at bookmarksMichael Stahl
Always create the portion, not just when the IsViewMetaChars is active. This has the advantage that nothing has to be invalidated when toggling, and the disadvantage that kerning at bookmark positions will never happen. Change-Id: I78943f337eef5c64cff33f6df6ff1a10acb1b8bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87363 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#45589 sw: add bookmarks to SwScriptInfoMichael Stahl
Add a list of bookmark positions in the text frame to SwScriptInfo. Initialising this turned out to be more complicated than expected. Change-Id: I1738186b057b0eece80177097a03826365107589 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87202 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#45589 sw: invalidate on bookmark insertion/deletionMichael Stahl
Invalidate the text frames when a bookmark is inserted or deleted; also when MarkManager::repositionMark() changes the positions. The other calls of SetMarkPos()/SetOtherMarkPos() look like they're all from code that corrects positions after text insertions or deletions so no additional invalidate should be necessary there. It turns out that one WW8 document in sw_filters_test wants to insert a bookmark on a SwGrfNode; check for that in makeMark(). Change-Id: I293e6da9042bea5992cb27091b9cff77e5c7961d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87157 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#129237 just add content checks for Input fieldsJan-Marek Glogowski
There seems to be fields with content values, which don't use it as the presentation value. So this reverts the content handling code back to the original one and just checks the content value from Input fields in addition to the SetExpression fields. Change-Id: I2abd227883035c559b1fc3f7aacf10769b0e79a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87093 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-01-30tdf#124176: Use pragma once instead of include guardsbugrakurt
Change-Id: I15f9cbce2344cebbe73a915758ce1631f46d7da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87721 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-30Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' to 35281f4c9178f373609a61f0a44e268b179c5749 - tdf#127566: don't change divcopyable border width in onclick handler Instead, define border width in respective CSS, to make it consistent in both clicked and non-clicked states, and avoid "jumping" on click. Change-Id: Ic8ab8d0fd586059e21de6aa866fef95226774acf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87718 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-30DOCX export: implement support for user fieldsMiklos Vajna
Updating the field doesn't work yet, that'll need additional markup in settings.xml. Change-Id: I562ae62cebcbd5ca474bd0f7a181773f8e515f5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87720 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-30tdf#48436 Chart: add CustomLabelPosition UNO API propertyBalazs Varga
and CUSTOM DataLabelPlacement to support custom data label positions, and its initial implementation: only UI support with OOXML import (tdf#130030), yet. Change-Id: I01d986071d78ae3e2a5f43d5711e9f60b8410c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86859 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-30tdf#42949 Fix IWYU warnings in avmedia/Gabor Kelemen
Except for MAC and WIN specific parts Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I1066aa31f45a8c81ddaa7d52d7c81aa09741c8d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87312 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-30slider.hxx has no need to include field.hxx anymoreCaolán McNamara
Change-Id: Ib612df11eda9afe5b8e5610b3caf520bf8668e6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-30mpLinkedField is never setCaolán McNamara
Change-Id: Ib774c57e9137979fc3f70d4798f1b875b99e4ea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-30Revert "SwAutoCompleteClient: SwClient no more"Stephan Bergmann
This reverts commit fa26db1c053a8510ada15fcbaa7e36ae0f6920a5 for now, as it breaks UBSan builds during e.g. JunitTest_sw_unoapi_1 (<https://ci.libreoffice.org/job/lo_ubsan/1518/>): > /sw/source/core/doc/acmplwrd.cxx:138:9: runtime error: member access within address 0x607001517be0 which does not point to an object of type 'SwAutoCompleteClient' > 0x607001517be0: note: object is of type 'SvtListener' > af 07 80 42 d0 8e 97 f4 84 2b 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 04 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SvtListener' > #0 0x2b85787e94b6 in SwAutoCompleteClient::Notify(SfxHint const&) /sw/source/core/doc/acmplwrd.cxx:138:9 > #1 0x2b84f3d5d886 in SvtBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/broadcast.cxx:128:25 > #2 0x2b84f3d5c07a in SvtBroadcaster::~SvtBroadcaster() /svl/source/notify/broadcast.cxx:96:5 > #3 0x2b857812fdc4 in sw::BroadcasterMixin::~BroadcasterMixin() /sw/inc/calbck.hxx:84:24 > #4 0x2b857af251c4 in SwPageDesc::~SwPageDesc() /sw/source/core/layout/pagedesc.cxx:127:1 > #5 0x2b857af25234 in SwPageDesc::~SwPageDesc() /sw/source/core/layout/pagedesc.cxx:126:1 > #6 0x2b8578f2c550 in SwDoc::~SwDoc() /sw/source/core/doc/docnew.cxx:466:9 > #7 0x2b857892a9c3 in SwDoc::release() /sw/source/core/doc/doc.cxx:117:9 > #8 0x2b8579d1efae in rtl::Reference<SwDoc>::clear() /include/rtl/ref.hxx:159:19 > #9 0x2b857e12fd44 in SwDocShell::RemoveLink() /sw/source/uibase/app/docshini.cxx:438:16 > #10 0x2b857e12eac7 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:366:5 > #11 0x2b857e12ff2b in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:356:1 > #12 0x2b857e130104 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:356:1 > #13 0x2b84edcb1a4a in SvRefBase::ReleaseRef() /include/tools/ref.hxx:163:29 > #14 0x2b84edcb1020 in tools::SvRef<SfxObjectShell>::~SvRef() /include/tools/ref.hxx:56:36 Change-Id: Iaf1cb698bf898efc66a3abaa1c8bfd3116b389b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87715 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-30vcl: fix UB in vcl::Cursor::ImplDoShow()Miklos Vajna
pWindow->mpWindowImpl can be nullptr here, see online.git's unit-load-torture test: vcl/source/window/cursor.cxx:204:54: runtime error: member access within null pointer of type 'WindowImpl' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior vcl/source/window/cursor.cxx:204:54 in (And one more similar case in Window::ImplGrabFocus().) Change-Id: Idd145082b58c10139be53e9b997efedeb0cec364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87709 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-30new (but unused) refassign lopluginNoel Grandin
which I wrote to check if there were any other cases where assigning to a ref local var looks dodgy, after my fixes in 0b113d6ebbaf923e11ba576bed2691bb68e95ae6, but I didn't find anything, so just leave this one in store Change-Id: Ib820924c5e8aa85206730afeb06972ef48231ec5
2020-01-30tdf#129625 Calc Navigator: Gray out content types with no contentJim Raykowski
Change-Id: I298894bbb338b97fe6891e33b23f16302acaec37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87714 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29tdf#124176: Use pragma once instead of header guardPelin Kuran
Change-Id: If7c8b03238889a084070d9e96133b5cccecbe807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87660 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-29tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorCanberk TURAN
Changed to one-line return Change-Id: I2ce55ff3c7f218823418ed623b03e6a4fcbc0d2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87515 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-29make our clang plugin visible in -ftime-trace outputLuboš Luňák
Change-Id: Id9363d8db729883d0f72eb9fcbf6d8bf5b396414 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87662 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-29cid#1458019 silence Out-of-bounds writeCaolán McNamara
and cid#1458017 silence Out-of-bounds write Change-Id: I5411322bca523e5dc55b8df2e7d9261981f504da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29cid#1458020 Untrusted loop boundCaolán McNamara
cid#1458018 Untrusted loop bound cid#1242844 Untrusted loop bound Change-Id: I9062240290708f4b51b0ce42a30897b50d1a2677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87702 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29gtk: resizing video elements has no effect once the video has played onceCaolán McNamara
Change-Id: Ice8e688a7909bcfffc477479110a69e4770996d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87695 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29cid#1401342 silence Uncaught exceptionCaolán McNamara
Change-Id: Ie8ac9ccd289a6d1d2a359521c5e2b5b97b1aeff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87699 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29push/pop mapmode to avoid 'incorrect MapMode?' warningCaolán McNamara
since... commit 644ebf7823c85973e2724cbfcf403cb63b054bfe Date: Tue Jan 28 20:40:15 2020 +0000 weld SmElementsDockingWindow Change-Id: I072f8b9d31be93722930d30b183766b7795f7a26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29desktop: document what doc_iniUnoCommands() doesMiklos Vajna
Change-Id: I961e563d92c6fdb783942de4b295d5d8b1bf2db3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87701 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2020-01-29gtk: make sidebar media panel "play video" workCaolán McNamara
blank impress, insert video, use sidebar media panel to play video, without this chage the video playes in a toplevel window because the size is 0x0 so the widget doesn't get created in the first place Change-Id: I7200423a693fb475dede357071ef10030c5bb790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29tdf#130132, tdf#129393: Add unittestXisco Fauli
Change-Id: Ia613dca3dc8bb1aa2e45e73149932be6ac61f8cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87691 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-29There should be no need for o3tl::make_unsigned hereStephan Bergmann
...to avoid hypothetical warnings when comparing an unsigned value to a signed constant Change-Id: Ife9f0be863443ea06fcd6dd49aba651f49659f02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87690 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-29CID 1458016 - fix uninitialised members in AccessibilityIssueTomaž Vajngerl
Change-Id: I826ed2da7743c99606209862075a0ca4f8e9eb62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87685 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-29tdf#129993 broken tables opening LWP fileNoel Grandin
regression from commit e2080e70fe8b085f18e868e46340454720fa94ca new compilerplugin returnbyref The parts that fix this specific bug are in lwprowlayout.cxx and lwprowlayout.cxx, but fix the other parts I messed up but not understanding the semantics of assigning to reference variables. Change-Id: I064cdd108c5b05da6092da0297dc7bcf487c7702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29make a simple compiler plugin usable in sharedvisitorLuboš Luňák
Change-Id: I9af231277facc661784e44f6ad3eb1a340c76f97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87663 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-29lok: preserve mouse event logic position and use in calcTomaž Vajngerl
When clicking in online Calc any of the charts, shapes (and other objects), sometimes the cell underneath is selected instead. The problem is that the object is not correctly recognised to be hit. From lok we get the mouse event position in logic coordinates, which we usually can just use in writer and impress. In calc however we need the coordinates in pixels, so we transform them before sending the mouse event to calc. Still calc also uses common SdrObjects (chart, shapes,...), which operate in logic coordinates. So in case of SdrObject we need to convert the coordniates back from pixel to logic again, which causes problems because conversion doesn't have access to the displaying conditions on an stateless online client. OTOH we already had the correct logic coordinates, and we can just send them along. This is what this change does. It adds an optional maLogicPosition to MouseEvent, which is filled with logic position if those is known. Change-Id: I26f6466085baf613850b5861e368f22cad7c1d26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87681 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-29Adapt to "[ADT] Make StringRef's std::string conversion operator explicit"Stephan Bergmann
...<https://github.com/llvm/llvm-project/commit/ 777180a32b61070a10dd330b4f038bf24e916af1>. This is just a quick fix to get copmilerplugins buiding again with latest LLVM/Clang trunk. Ideally, we should get rid of as many of those (potentially expensive) conversions from llvm::StringRef to std::string as possible. Change-Id: I18e185e0022a06fd8e3b983a3c4f80e1f3b96746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87682 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-29bInterim is always trueCaolán McNamara
Change-Id: Id9f72fdb94a766ef58a44b3653a36f22335b5718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29bInterim is always setCaolán McNamara
Change-Id: I2a84351d98523a2dda7db96a4099837d0e8a8ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87664 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29weld SmElementsDockingWindowCaolán McNamara
Change-Id: Ieeaa1f1e0deb708ec6d3daf261384c61d2ade22b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87659 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29Revert "ofz#20267 Indirect-leak"Caolán McNamara
This reverts commit ae01adf0747496e8c36f8f30fc2c1a4a6ef8275e. Reason for revert: intermittent failures Change-Id: I2212154e2c6ca210a2ff19cf73c0578c146dd46d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87679 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29Add wrongly formatted files to blacklistStephan Bergmann
Change-Id: I5453f58db919faa8799e6fe46201818df17f43f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87673 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-29tdf#130237 OOXML chart export: fix incomplete 3D area chartBalazs Varga
by exporting its z-axis properties into <serAx> element. Data series of 3D area charts were “transparent” or incomplete opening with MSO, because we exported z-axis as a category axis. Change-Id: If7d8c15aa738cc44c736cd37d2be30d0eb15538f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87506 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-29tdf#42949 Fix IWYU warnings in sw/source/ui/vba/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iafc34cffc3257d785d61f60fc37dc95e5250435c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87308 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-29The next release is 7.0Samuel Mehrbrodt
Change-Id: Id6300035b5aba13cdd3d11035f2e85559e9f1597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87674 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-01-29tdf#128959 DOCX import: fix missing text lines in tablesLászló Németh
Orphan/widow line break settings aren't always ignored by Writer table layout code, in this case, in vertically merged cells, resulting missing paragraph lines. As a workaround for interoperability, disable orphan/widow control in cell paragraphs during the DOCX import to get correct layout in Writer, too. Change-Id: I48fdb0a3bb421fd4df2c729e307a7ef483e3e772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87637 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-29Sort solenv/clang-format/blacklistStephan Bergmann
(lexicographically, by Unicode code point values; to make it easier to add further entries) Change-Id: Ie9c426e74b79cab241695d1ecd58c78704820649 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87672 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>