summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-31sfx2: Kill useless mutex guardTakeshi Abe
Change-Id: Idcbb1eff983bb82d29b8e53f09c0b7e73a8aab39 Reviewed-on: https://gerrit.libreoffice.org/44046 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31loplugin:constantparam in scNoel Grandin
Change-Id: I2a55811f1741341c30f84ea3d010cc12eb6f2df9 Reviewed-on: https://gerrit.libreoffice.org/44086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31convert XclStrFlags to scoped enumNoel Grandin
Change-Id: I1127e8231820d093cddc87762dc5d3735c3fce7b Reviewed-on: https://gerrit.libreoffice.org/44055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31loplugin:constantparam in svl,svtoolsNoel Grandin
Change-Id: I0d7c1dff2646e483c866f547224c60838b221c4b Reviewed-on: https://gerrit.libreoffice.org/44083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31ReleaseYieldMutex is always called with trueNoel Grandin
so drop param and rename to ReleaseYieldMutexAll Change-Id: Ic4fcee24d46405659e54363c87f21d88696b0ce1 Reviewed-on: https://gerrit.libreoffice.org/44057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31tdf#82065 strict docx import: add support for LN_CT_Ind_startJustin Luth
Change-Id: Iaddd9e852388f5bb076c4bc6f8eee8a256581033 Reviewed-on: https://gerrit.libreoffice.org/43985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-10-31Refactor SwBaseLink member variablesJan-Marek Glogowski
Change-Id: I5752ff69c4978278d597360a34657e380d71ee4c Reviewed-on: https://gerrit.libreoffice.org/43907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-31Rename class from ScAreaLink to ScAreaLinkObjJens Carl
Rename class for sc_arealink so it aligns with the rest of sc unit tests objects. Change-Id: If8b8497d841e0c3215a55171a1aa036718f8b387 Reviewed-on: https://gerrit.libreoffice.org/44038 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-31Drop bDelayed from SwNodes::MakeGrfNodeJan-Marek Glogowski
There is no caller, which sets bDelayed. The comment "// create object delayed, only from a SW/G-reader" doesn't help me much either. But in case of a linked image, it seems appropriate to just drop the empty image and use the delayed SwGrfNode constructor. At least a linked PDF and PNG still work. Change-Id: Idff5599ac0ff04c3efcb141c731c0ee1cfa747de Reviewed-on: https://gerrit.libreoffice.org/43908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-30tdf#103317 Add 7 new Impress templates and restore 2Yousuf Philips
* Restore pencil * Restore LushGreen, but updated version Change-Id: Ic80d3c57028432f1b3ee88813622aa34ffd72dd9 Reviewed-on: https://gerrit.libreoffice.org/43973 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-10-30Update mdds to 1.3.0.Kohei Yoshida
Change-Id: I0d3278c4247049db828d85fd1b269476a8e53223 Reviewed-on: https://gerrit.libreoffice.org/44068 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-10-30Fix typoAndrea Gelmini
Change-Id: I51351518d4df9fbe44f70cbcea92b360f1acc94a Reviewed-on: https://gerrit.libreoffice.org/44060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-30Fix typoAndrea Gelmini
Change-Id: I84e5d836bf43a07e9ba88f73a498930b6ad38d72 Reviewed-on: https://gerrit.libreoffice.org/44063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-30Fix typosAndrea Gelmini
Change-Id: I46901a54c204d5d2848316e80cbf7b867b4a712b Reviewed-on: https://gerrit.libreoffice.org/44065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-30add numbering provider to servicesCaolán McNamara
Change-Id: I3ab0f854689bd6a8fe862bbc06d488dd2157d297
2017-10-30Werror=misleading-indentationCaolán McNamara
Change-Id: Iaf7953671a4b04ac8068ed9df499b311600f742e
2017-10-30Constify some VCL interface functionsJan-Marek Glogowski
This drops the bPaintEnd optimization for vertical and horizontal lines on Windows, where Polyline and LineTo exclude painting the last pixel of the line. Instead we just always set the last pixel. It also merges the various "SetPixel" call sites into a common drawPixelImpl function. Change-Id: I01cc3c01c908ba74f7978fa90eaaf8d88f923ae3 Reviewed-on: https://gerrit.libreoffice.org/43939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-30TSCP: classification edit box doesn't need to be that highAshod Nakashian
Change-Id: Ib6c0dc1b4363377b03934a9b1a296a013183a714 Reviewed-on: https://gerrit.libreoffice.org/44014 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-30tdf#113520 sw split sections in tables: avoid empty page after content delMiklos Vajna
The problem was that since split sections are allowed in nested tables, deleting enough content so that the full content of a page is removed results in an empty page, having only a 0 height table. I.e. the split section gets removed properly, the inner table (and its row and column) as well, but the outer table is still there, though it is marked to have 0 height. This results in a situation that the previous page doesn't have free space (the in-table section tries to take as much space as it can), but on the other hand we try (and fail) to move the 0 height table on the current page to the previous one, as it doesn't have free space. At the end the "empty" page still has an invisible table frame, so it is not removed. Fix the problem by allowing the move of a 0 height follow table frame from the current page to the previous one, even it has no empty space. Change-Id: I2a5fac88b8b7dc2b91d041b58a4ad1b328f56a6b Reviewed-on: https://gerrit.libreoffice.org/44059 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-30tdf#91781 Collect form commands into new Form menuYousuf Philips
Change-Id: Idf5304a7fd5f8e82fc76b7f0eb6fc1482be0fb85 Reviewed-on: https://gerrit.libreoffice.org/44028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-10-30tdf#101349 Default table stylesheiko tietze
Change-Id: Ia86c66ce1954172f62e7484908cbe7aaf8b13311 Reviewed-on: https://gerrit.libreoffice.org/43986 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-10-30tdf#96505 Get rid of cargo cult long integer literalsudareechk
Removing unnecessary 1L occurrences Change-Id: I85d4949eacde0dfc0ff7a513f4bf42324e6d34c1 Reviewed-on: https://gerrit.libreoffice.org/42840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-30'r' means C++ reference, but this mormal local OUString variable is not thatTor Lillqvist
Change-Id: I56d21c3dc09f972a415bbd74dc635b231373d9f3
2017-10-30clang-tidy modernize-use-equals-default in comphelperJochen Nitschke
Change-Id: I24a3ecd2ea9fe7e08c92b95aac57a58b922616b2 Reviewed-on: https://gerrit.libreoffice.org/44054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30new loplugin: constmethodNoel Grandin
parked in store/ for now, because, as I worked my way up the layers of modules, the higher I got, the more false+ I got when trying to only make changes that preserved logical-constness. Change-Id: I4acd2c4416775f7c6a3d91eb0bce048630ccaff5
2017-10-30ofz#3901 Integer-overflowCaolán McNamara
Change-Id: Iebb9c82aea61a255b1a5ef4d9f1b66bc0fb17c59 Reviewed-on: https://gerrit.libreoffice.org/44053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-30loplugin:constantparam in toolsNoel Grandin
Change-Id: I639fd4f8990b495f8d572a280837afb7054f4837 Reviewed-on: https://gerrit.libreoffice.org/44047 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30loplugin:constmethod in vcl and stocNoel Grandin
Change-Id: I7c02eecc16ca7cf89d9f7021116b0226885dbf06 Reviewed-on: https://gerrit.libreoffice.org/44044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30loplugin:constmethod in idl,helpcompilerNoel Grandin
Change-Id: I9b328fc0a3ebdd15a646ee6dab800ffbadb1aaef Reviewed-on: https://gerrit.libreoffice.org/44050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30RotateFlyFrame: Isolate SwFrame members maFrame and maPrtArmin Le Grand
To gain more control over changes of the Writer layout, isolated mentioned members and replaced all calls with inline methods for read access. Moved to own class to also identify 'private' accesses reliably. Added access dedicated classes for write access, the only allowed way to do changes. Adapted all usages and made test builds on logerrit and locally Change-Id: Ib0b7f852f5176744e860e2aad12dd13c9a906d68 RotateFlyFrame: Migrated from SwFrame::FrameWA to setFrame Change-Id: I01f7b828fe2134411cc76639e880da46b415d767 RotateFlyFrame: Migrated from SwFrame::PrintWA to setPrint Change-Id: Ieea3b467f296a190de5b5f47721bef148bebf60b RotateFlyFrame: Adapted to get/setSwFrame and get/setSwPrint Change-Id: I6cce40ec49dd5bd32d94fe06b9d2dabd368448be RotateFlyFrame: Adapted to get methods and WriteAccess helpers Change-Id: Ife3c1b2391ad7beae8c7f31f796b1454709ddd26 RotateFlyFrame: Moved change executers to cxx Moved SwFrameRect::FrameWriteAccess::~FrameWriteAccess() and SwFrameRect::PrintWriteAccess::~PrintWriteAccess() to implementation side and added compare op's for SwRcet to write only if needed Change-Id: I85d0e61009116f4b17d1ce0337e3f0d2cc031159 RotateFlyFrame: Moved change executers to cxx Moved SwFrameRect::FrameWriteAccess::~FrameWriteAccess() and SwFrameRect::PrintWriteAccess::~PrintWriteAccess() to implementation side and added compare op's for SwRcet to write only if needed Change-Id: I85d0e61009116f4b17d1ce0337e3f0d2cc031159
2017-10-30Adapted to get methods and WriteAccess helpersArmin Le Grand
Change-Id: Ife3c1b2391ad7beae8c7f31f796b1454709ddd26
2017-10-30Adapted to get/setSwFrame and get/setSwPrintArmin Le Grand
Change-Id: I6cce40ec49dd5bd32d94fe06b9d2dabd368448be
2017-10-30Migrated from SwFrame::PrintWA to setPrintArmin Le Grand
Change-Id: Ieea3b467f296a190de5b5f47721bef148bebf60b
2017-10-30Migrated from SwFrame::FrameWA to setFrameArmin Le Grand
Change-Id: I01f7b828fe2134411cc76639e880da46b415d767
2017-10-30Isolated SwFrame members maFrane and maPrtArmin Le Grand
To gain more control over changes of the Writer layout, isolated mentioned members and replaced all calls with inline methods for read and/or write access. Moved to own class to also identify 'private' accesses reliably. Change-Id: Ib0b7f852f5176744e860e2aad12dd13c9a906d68
2017-10-30loplugin:constantparam in svxNoel Grandin
Change-Id: Ifaad1083b1561b2bd908e798e06fbff8bbabbe60 Reviewed-on: https://gerrit.libreoffice.org/44048 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+Furkan Ahmet Kara
Change-Id: If0ed3929f8faab187327b90e63014720e287e501 Reviewed-on: https://gerrit.libreoffice.org/43681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-30tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+Furkan Tokac
Change-Id: I32aab185cd0572353f4d94cfe4b16af25a665ef4 Reviewed-on: https://gerrit.libreoffice.org/43684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-30ErrorCode can be a simple intCaolán McNamara
Change-Id: Ia0e9cc193be6f49a5a58c2f5ea5c7a5897e8400e Reviewed-on: https://gerrit.libreoffice.org/44035 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-30de-sal_uLong met filterCaolán McNamara
Change-Id: Ia9c0051f42801e8017469c77bf3d89672a748115 Reviewed-on: https://gerrit.libreoffice.org/44034 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-30ofz#3896 Integer-overflowCaolán McNamara
Change-Id: Ib7d3c8bd1a5db9f6b35e928743a701a9a95403ca Reviewed-on: https://gerrit.libreoffice.org/44031 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-30git-hooks: don't complain about large .ui filesMichael Stahl
Looks legit. Change-Id: I73562d0a8d863868ae717cee97b6497a93df4ee4
2017-10-30sw: prefix members of SwUndoMoveMiklos Vajna
Change-Id: I2938845f3f454c085c3b159b17fb591869eaeac8 Reviewed-on: https://gerrit.libreoffice.org/44045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-30Revert "tdf#113197 Add MaskPrimitive (clip) to EMF/WMF if needed"Thorsten Behrens
This reverts commit bdb9cc1702d4e125db8c379f3b535bbd9f845b95. Breaks Mac unit tests in sw_ooxmlexport4
2017-10-30Remove obsolete headerJens Carl
Change-Id: I77ef4bd4a253d4f0722c131f49675e12c3396178 Reviewed-on: https://gerrit.libreoffice.org/44042 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30Fix xsheetfilterable CppUnit assertJens Carl
Change to Logical NOT operator to make clang loplugin:simplifybool happy. Change-Id: I95af212ea6fa33be2775824322bd64f04d2ac695 Reviewed-on: https://gerrit.libreoffice.org/44039 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30loplugin:constantparam in vclNoel Grandin
Change-Id: Ic32e4098dcdae5ca5d7fe2749badedabda86a90d Reviewed-on: https://gerrit.libreoffice.org/44043 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30iOS, make list of allowed file extensionsjan Iversen
Info.plist import/export file extensions handled by LibreOfficeKit, looped through and created var "KnownDocumentTypes" Change-Id: I479126a8070490e259c81d32f7dbfe437670fb28
2017-10-30related: tdf#103884 remove gltf/collada featureThorsten Behrens
Change-Id: Icd26ad96c0337844ef1463dabfbe791caa00dd2d Reviewed-on: https://gerrit.libreoffice.org/43972 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-30Replace list by vector for m_aSubsets (vcl)Julien Nabet
+ use for range loops for those related to m_aSubsets Change-Id: I2fa3e3c46394381f5d0bb042481c1884bfe52da9 Reviewed-on: https://gerrit.libreoffice.org/44033 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>