summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-09Pick up cell border colors when importing via orcus.Kohei Yoshida
Change-Id: Iee2d79930d0c917518b180fdd63fe30c6860b9b1 Reviewed-on: https://gerrit.libreoffice.org/49466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-09Resolves: tdf#105837 use angle quotation marks (Guillemets) for [de-CH]Eike Rathke
Source: https://en.wikipedia.org/wiki/Quotation_mark#German https://de.wikipedia.org/wiki/Anf%C3%BChrungszeichen#Schweiz,_Liechtenstein,_Frankreich Change-Id: I9aa13eb610b39d1443acb0d2993a3e6f3e68a12e
2018-02-09fix "replace Bitmap usage with VirtualDevice in ColorSliderControl"Noel Grandin
commit 7116b9cc2f3ee28b4444540d0c14183b9bd17968 Change-Id: I40d7f88fa76c620abd8838a0dd525e67eeeb747b
2018-02-09tdf#115504 Add tabstop to Sidebar Navigator deck content treesJim Raykowski
Change-Id: Ie006e01ea6179b94cca77354437678ff90e1bbd6 Reviewed-on: https://gerrit.libreoffice.org/49400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-09promote to unsigned intCaolán McNamara
Change-Id: I84fa219708199cd8293e6887860ba44dd897a2e8
2018-02-09move largest bounds check to startCaolán McNamara
Change-Id: I03fe80f9568759b829fac4e9bcfd496efebe6a26
2018-02-09bounds checkCaolán McNamara
Change-Id: I6d32a6b6f1dd91db42a3f154700ea55603f0e4dd
2018-02-09extend to cover the last byte neededCaolán McNamara
Change-Id: I5177d42b47a4bca614878dce4a69ab16b5cfe163
2018-02-09simplify returnsCaolán McNamara
Change-Id: I1a67cb2f1c686032438852fec1267a59fbd04d7f
2018-02-09use safeint on calculationsCaolán McNamara
Change-Id: Ic063786ba41aa9a985f505e62b43d3d543a0d48f
2018-02-09check ntables offsetCaolán McNamara
Change-Id: Id75f5f4b578fd176c17e5763569f1403260c6594
2018-02-09check tableoffset against sizeCaolán McNamara
Change-Id: Ia79be052dd3f6b6ed38fb326558924c853af5fff
2018-02-09check cmap offsetCaolán McNamara
Change-Id: I5aae26c38f3645020f0e1d6d7b6877c2727af1b4
2018-02-09check more table sizesCaolán McNamara
Change-Id: I004a6d322f60d916cc4635b362ce948e8a10d7c7
2018-02-09fix mem leakCaolán McNamara
Change-Id: I0d329357ac282d4652b0f7ebc401cbd51963461b
2018-02-09use ptr diff rather than intCaolán McNamara
Change-Id: Ia174fd94c57cc3c899c10e1c0dc5968965a50427
2018-02-09mailconfig UI: prefilled username: only clear when disabled.Justin Luth
logic error - the username was being cleared on initial page load, and was toggling on and off every time the radio button was tapped. Change-Id: I8c2334665cd18fe8cdd0ea6739e90b088a105256 Reviewed-on: https://gerrit.libreoffice.org/49467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-02-09tdf#88802 disable arrow if database or table or field not selectedekuiitr
Change-Id: I5a29b58f6e8981ee3de73ccaa83ed04e4ee71dc6 Reviewed-on: https://gerrit.libreoffice.org/49314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-09support multiple columns in column data transformationsMarkus Mohrhard
Change-Id: Ic911fb7d5f99f692c960ef5267e37b263e798672 Reviewed-on: https://gerrit.libreoffice.org/49457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-09add a method to get columns and rows from DataTableViewMarkus Mohrhard
Change-Id: Iaf3cd96f6a8397a69896e02831b5ce016ca262ef Reviewed-on: https://gerrit.libreoffice.org/49456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-09add method to get selected range for header barMarkus Mohrhard
Change-Id: I71f5a1e5240ffbc34d3c6ce86f81b20213c26b6d Reviewed-on: https://gerrit.libreoffice.org/49455 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-09sw android: fix -Werror,-Wsign-compare, take twoMiklos Vajna
This time not breaking other platforms. Thanks to Stephan Bergmann for suggesting this alternative way. Change-Id: I2535e57de1aafd17960a1d1054fc58a47933bb58 Reviewed-on: https://gerrit.libreoffice.org/49441 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-09Workaround for broken GCCMuhammet Kara
There appears to be broken GCC out there, at least some "gcc (Debian 6.3.0-18) 6.3.0 20170516", even with -std=gnu++17, reportedly does not treat the in-class declaration of MAX_WIDTH as a definition, and needs this old-style out-of-class definition, too. See also bc2ae79f81c8aa081d6340348c70c0440f6e895e Change-Id: Iaeb85e244d5963c01a86806f481c9d667b1f26a1 Reviewed-on: https://gerrit.libreoffice.org/49431 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-09/org...Writer/Insert/Caption/CaptionOrderNumberingFirst should be localizedStephan Bergmann
...as f6281ec4112479b5bdd750be351f4437ecf8a65a "#i110273# caption order changed for locale hu" added a special value for xml:lang="hu", but failed to take into account that the property is not localized. Until now, every installation that had the hu localization installed (but regardless of whether or not it was actually using it) would always have reported the special hu value (true), while any other installation would always have reported the default value (nil, mapped to false in the else branch at the end of SwInsertConfig::Load, sw/source/uibase/config/modcfg.cxx). Unless the value was overwritten in registrymodifications.xcu (by changing the Options dialog "LibreOffice Writer - AutoCaption - Caption Order" setting). In which case the hu localization will now start to use its default again (true), while all other localizations will continue to use whatever value had been stored (without an xml:lang attribute) in registrymodifications.xcu. This is a bit unfortunate for the hu-localization case. It should probably be mentioned in the release notes. (Strictly speaking, changing a property from non-localized to localized, as is done here as well as in e.g. ffd8369b909c86653ef30593fddf67c9f5308583 "rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName props" is an incompatible change which 3rd-party code can observe through the css.configuration UNO API. But chances are extremely low that this will have any impact, as access to any property's value is normally done in a way that makes it transparent whether or not the property is localizied.) Change-Id: Ia840e28e10d0fa388bff6eaf8aadf0e8e6b25a19 Reviewed-on: https://gerrit.libreoffice.org/49414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-09/org.openoffice.Office.Writer/Layout/Other/TabStop should be localizedStephan Bergmann
...as b1b3251478926251d4d1c3e9ef864171548d85b5 "INTEGRATION: CWS os103: #i81308# default tab stop in local zh-CN changed to 0.74 cm" added a special value for xml:lang="zh-CN", but failed to take into account that the property is not localized. Until now, every installation that had the zh-CN localization installed (but regardless of whether or not it was actually using it) would always have reported the special zh-CN value (740), while any other installation would always have reported the default value (1250). Unless the value was overwritten in registrymodifications.xcu (which, it turns out, it always was, see 35140501779622194337e630b274e74abeedca4d "Add missing no-modify mode for SwMasterUsrPref::Set* functions"; but could also have been done explicitly by the user by changing the Options dialog "LibreOffice Writer - General - Settings - Tab stops" setting). In which case the zh-CN localization will now use its default value (740), while all other localizations will use whatever value had been stored (without an xml:lang attribute) in registrymodifications.xcu. This is unfortunate (as the zh-CN localization may lose any value explicitly set by the user, while non-zh-CN localizations may continue to use a wrong default value, if the zh-CN localization is or ever had been installed). It should probably be mentioned in the release notes. (Strictly speaking, changing a property from non-localized to localized, as is done here as well as in e.g. ffd8369b909c86653ef30593fddf67c9f5308583 "rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName props" is an incompatible change which 3rd-party code can observe through the css.configuration UNO API. But chances are extremely low that this will have any impact, as access to any property's value is normally done in a way that makes it transparent whether or not the property is localizied.) Change-Id: I6f49ecd9ac145dfe6825e727e72fffea515490ea Reviewed-on: https://gerrit.libreoffice.org/49433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-09Remove dead Executable_genlangStephan Bergmann
...originally introduce with 999c68f12f1d95b16a97294949a0e6ba6d3ba259 "genLang project (awareness)", but apparently never took off. Change-Id: I6f61271a75d96750dea63de596b7745c2f589b83 Reviewed-on: https://gerrit.libreoffice.org/49389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-09add setter methods to tools::RectangleNoel Grandin
intended to replace the existing methods that return mutable ref And add the clang rewriter I will use to do most of the work. Change-Id: If00be13da5c16c07671cedbcfea21528bac33c8a Reviewed-on: https://gerrit.libreoffice.org/49430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-09always check whether pChartListenerCollection is not a nullptrMarkus Mohrhard
Change-Id: Ibe3ade28884b4e1264cd5a5a68a8e428ee3d9a48 Reviewed-on: https://gerrit.libreoffice.org/49454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-09tdf#115394 correct transition in case of 0sSzymon Kłos
Change-Id: I23d18acef0bd5db4a4ad6fc67d409e7ed5c93949 Reviewed-on: https://gerrit.libreoffice.org/49462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-02-09tdf#108210: Allow to ignore a lock file if there's no filesystem lockMike Kaganski
Two cases are handled: when a file is being opened, and when it was opened read-only already, and one tries to reopen it in edit mode. The option to ignore locking and open the file anyway is only offered when there is no filesystem lock present on the file. Change-Id: I377d3cae4c949ae64d449634acea8fb3f68a5700 Reviewed-on: https://gerrit.libreoffice.org/49448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-09Fix exception message: add colon between function name and the word "expected"Tor Lillqvist
Change-Id: I80eadaa097afdbe4394aceca9f40b9753792f30b
2018-02-09Decrease fragility in odd use cases with no current documentTor Lillqvist
Change-Id: I9966166561d4c6e577f3f7e8e04572f97a0b295e Reviewed-on: https://gerrit.libreoffice.org/49450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-09Resolves: tdf#115493 use matrix as result of jump command, tdf#58874 relatedEike Rathke
{=SUM(IF(EXACT(OFFSET(A7,0,0):OFFSET(A7,2,0),A$1),OFFSET(A7,0,1):OFFSET(A7,2,1),0))} shall be the same as {=SUM(IF(EXACT(A7:A9,A$1),B7:B9,0))} Change-Id: Id503ef41140d1e9c4aeabbec08d1199dd6dd8593
2018-02-09tdf#115470 - Name of the "Cycle Case" is too longheiko tietze
Long text moved into a tooltip Change-Id: I981970c6e1fa16397264ea852fcd9bc480a41980 Reviewed-on: https://gerrit.libreoffice.org/49413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-02-09Sync the fix with Muffin upstream changesMaxim Monastirsky
See: https://github.com/linuxmint/muffin/commit/f3fce7898ba8aa82c4c82a50af2bb44c0ff79ddf Change-Id: Ic569bb7139fcb12e9549fa136c269f1a7ed10cb3 Reviewed-on: https://gerrit.libreoffice.org/49453 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-02-08tdf#115430 BindDispatch_Impl needs a disposal methodMaxim Monastirsky
The dtor will never be called otherwise, because the dispatcher is holding a reference to us, so removeStatusListener is needed first. Regression of a5dbe5a8a9e98f2d79f2c535182fc557b561ed0f ("use rtl::Reference in svl,sfx2") Change-Id: I52da6152f0ddb0030d7354f7201e969d5a1f11cf Reviewed-on: https://gerrit.libreoffice.org/49423 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-02-08tdf#108224: rename insert author menu entryGabriele Ponzo
The Insert Author menu entry does not insert the author field but the "DocInformation:Created" field. Change-Id: I6dadbf17d5cd3cd2c7b652c1b1c28996c1148a8c Reviewed-on: https://gerrit.libreoffice.org/49281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-08ofz#6112 wrong start off sets for korean KSC5601 tableCaolán McNamara
Change-Id: If986352478f34f54015f1969c97c26e2ef05c06c Reviewed-on: https://gerrit.libreoffice.org/49444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-08infinite regressCaolán McNamara
Change-Id: I7f716d2273115284769d580165fbfa21c1db541b Reviewed-on: https://gerrit.libreoffice.org/49422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-08replace Bitmap usage with VirtualDevice in ColorSliderControlNoel Grandin
So we can move more Bitmap*Access stuff inside vcl/. Change-Id: I3520f61483f84ac30ffd9059ed4112c9c074f195 Reviewed-on: https://gerrit.libreoffice.org/49405 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-08tdf#115319 use loext namespace for reference-languageLászló Németh
attribute of alternative reference fields with Hungarian articles Change-Id: I19578bc0d5cb5633cf2619e9aea81da946a13f3e Reviewed-on: https://gerrit.libreoffice.org/49437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-02-08Remove unused macrosKhaled Hosny
TYPEFLAG_PS_OPENTYPE is set but never used, and dropping it means we no longer need TYPEFLAG_COPYRIGHT_MASK either. Change-Id: Iefb45b32f53a806f2477ce54b7062b5846a6a806 Reviewed-on: https://gerrit.libreoffice.org/49427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-02-08Use a more direct link to the relevant partKhaled Hosny
Change-Id: I0659643041a4ec79d0753ed5f3711e57f51688d8 Reviewed-on: https://gerrit.libreoffice.org/49425 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-02-08Removed unused code for reading kern tableKhaled Hosny
Change-Id: I66b17dbee0a04e61b99e23933a7fed4be30f3a93 Reviewed-on: https://gerrit.libreoffice.org/49426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-02-08Updated coreIlmari Lauhakangas
Project: help b6bc8c1cfecc55bebff8dc64fddb63e3edc109b5 tdf#115255 and auto-expand contents per subitem JavaScript stuff moved from online_transform.xsl to help.js. Simplified bookmarks markup. Span elements with class "input" and length more than 3 characters can be copied to clipboard by mouse click. Bubli's feature request for auto-expanding contents per subitem is also implemented. Logic for adding headings to index list was reimplemented. Change-Id: I87b6f189a040a73a1ab9dda1ec9cd790b06da202 Reviewed-on: https://gerrit.libreoffice.org/49421 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-08Modernize a bit svtoolsJulien Nabet
by using for-range loops + use empty() instead of comparing begin and end iterator Change-Id: I41c3ae0c9032d6349afb113d457cb78862ae9dcf Reviewed-on: https://gerrit.libreoffice.org/49416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-08Disable NET_WM_PING for all debug buildsSamuel Mehrbrodt
To allow debugging under Gnome 3 Change-Id: I75e3a3fe797c4973072b46f9ee58270fd0e366c5 Reviewed-on: https://gerrit.libreoffice.org/49417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-08svx: fix crash caused by SdrEdgeObj::Notify() not noticing dying objectMichael Stahl
This can be reproduced by exporting tdf97737-2.odt to DOCX. Change-Id: I710f8961568aeb5a64fb39eff7c1e3540cbf4976
2018-02-08tdf#86739 Option to set image anchor type in image insert dialogSamuel Mehrbrodt
This adds the selectbox to (hopefully) all filepickers: - LO native - GTK/GTK3 - KDE4 - KDE5 - Windows - macOS Change-Id: I01bd42b1ca18e0f691b879647a6cb1b62177d3ce Reviewed-on: https://gerrit.libreoffice.org/49311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-08tdf#112990: Hack-around: Do not crash on mac with opengl enabledXisco Fauli
Change-Id: Id8d1ffe593fa42b7e37e26e8d66ffad87d6685c1 Reviewed-on: https://gerrit.libreoffice.org/49251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>