summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-27A GtkButton is already sufficient to get mouse eventsCaolán McNamara
Change-Id: Ia61a7906198bf6b6a4ce188d7de9a627c8540af4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99450 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-27tdf#124430 Writer Editing: Fix textbox aligningBakos Attila
Before, when align function was used the textboxes (shape+frame) went apart, now the textframe follows the shape. Co-dev: Attila Bánhegyi (NISZ) Change-Id: I4d69a2f7f4e5ef50d17bb0871c501d6e0026d0e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99048 Reviewed-by: Attila Bakos <bakos.attilakaroly@nisz.hu> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org>
2020-07-27tdf#133967 sw_redlinehide: fix redline deletion of table containing redlinesMichael Stahl
A delete redline is created from node 371 to node 1625; there are existing redlines in the range, so AppendRedline() splits the new redline into pieces between and on the existing redlines. Even worse, because some of the existing redlines are in a table, InsertWithValidRanges() then splits the pieces that overlap the table into even smaller pieces, such that there are now the table structural nodes that were in the initial new delete redline's range but are now covered by none of the pieces. This means that multiple merged text frames are created, with non-merged frames between them, and thus the functions UpdateFramesForAddDeleteRedline() and UpdateFramesForRemoveDeleteRedline() [for Undo] have to deal with this unexpected complication. (regression from sw_redlinehide) Change-Id: Ibf71c1deb2bc3fa2af16035954d5ef71b6827be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99411 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-27sw_redlinehide: fix "delete of insert redline"Michael Stahl
Don't delete frames on start node in SwUndoDelete::UndoImpl; happens on SwUiWriterTest::testTdf83260(). (regression from ad0351b84926075297fb74abbe9b31a0455782af) Change-Id: I271d8bcbe4ab266e9e922e144450f05a24d183cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99410 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-27sw: fix AppendRedline() creating empty redlines for OutsideMichael Stahl
This happens on tdf#133967 bugdoc with the Delete/Delete case first, in line 1445 - the start positions are equal, so the new redline is empty => DocumentRedlineManager.cxx:92: redline table corrupted: empty redline Similar bugs exist for Delete/Insert case in line 1725 and Format/? case in line 1892, the latter even checks a nonsensical condition *pEnd != *pRStt that is always true for Outside case. It's like that since inital CVS import. Change-Id: I7ade25380a5a43b14e87db37da8fc84267e89dd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99389 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-27Make Bookmarks dialog asyncSzymon Kłos
Change-Id: I820019f6906fef57743886fb1ba9c98217955370 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99041 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99350 Tested-by: Jenkins
2020-07-27sw: prefix members of SwContourCache, SwHTMLTableLayoutCell, ...Miklos Vajna
... SwHTMLTableLayoutConstraints and SwStyleManager See tdf#94879 for motivation. Change-Id: I950012885edd77a0aa44a5aee1ef1ceb358bdf03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99466 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-27extensions/WinUserInfo: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I16e7da267af4d6e45522b502515cebe52352b2f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99460 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-27tdf#135077 Qt5 revert broken fix for tdf#132172Jan-Marek Glogowski
So I tested a lot of stuff, but missed the missing focus for new dialog windows :-( This is IMHO a far worse problem, then the popup, so just revert the fix. This reverts commit 06fb3e7b7f1079c276ad2f048cd94299b4bd7006. Change-Id: I391ad91ded90e4518ab024572d3f182769b0bcda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99451 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-07-27allow to .uno:Save a PDF doc - divert to SaveAs to the doc. fileTomaž Vajngerl
To save PDF annotations, we need to allow a .uno:Save if the document was opened from a PDF file. When we get a .uno:Save command, we need to divert that to SaveAs into the same file as the current document was opened with. Change-Id: I0c511c4e5501de03ea8b0efb5aaf37cd09936e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99463 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-26basegfx: remove completly useless namespace opening and closingArnaud Versini
Change-Id: I6959e9eabd6623435cc534c55869a844b0f207d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99459 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-26fpicker/win32: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ic7d6c94e8709184fc8f195bd019402e361e9b810 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-26tdf#134769: sc_subsequent_export_test: Add unittestXisco Fauli
Change-Id: Ief7138716bb15a1b7a87fa9baee2cfaf7bbfc9c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99447 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-26tdf#135106 Direct Formatting should be empty by defaultShivam Kumar Singh
Change-Id: Ic7dfb2e681c5128288b2f39054bc642ab6028fed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99420 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-26Revert "tdf#132787: Don't duplicate hicolor icon theme as gnome"Christian Lohmaier
This reverts commit a26a5bb71c32c1cf8c5ad4d2ef79f3ece5065a02. Reason for revert: apparently compilation with installation sets wasn't tested at all/the change is incomplete and breaks because of missing files. Change-Id: Ied6973659bd0c25f613d615a4cae699b04ae2a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99398 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-07-26sw: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ibd5c19d78c1440b489d850fdacbaa74d0c3d1654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99458 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-26sd: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I92d19e8f01f759568756af85f2d76c226948ef68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-26sc/vba: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I6f8d7c3c0075cf5c1843b8bc79d93f467c4aec7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99456 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-26sc: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Id4bf552c6a2580742bf46ccf6cdd2e09b0dbdebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-26tdf#118148 Add extended tips to optuserpage.uiOlivier Hallot
Pick from text/shared/optionen/01010100.xhp and add missing ET's Change-Id: I8f188e2b2f64b570db90dca6b98240f6e9a86793 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99341 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-26Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 09c3906689f2a33490dceb57b47caaa4d22b2060 - Create help page for submenu Spacing Change-Id: I0858a71de5dbbb6e2d1033add3d69d00ad46372f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99383 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-26rename ensureEventWidget to ensureMouseEventWidgetCaolán McNamara
Change-Id: Ibe2d8722dc61c56e762cabb1cecccac8706fb4cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-26starmath: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. And adjust the sfx2 model factory code to cope with UNO constructor functions. Change-Id: I7e57fb3136ad0b3caadd511ea63cf98d3c03ab3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99446 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-26package/xstor: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: If1512d63fd1089f6f8486e32106c68f495a1f3df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to bd1204235cbbbe6339593531b1266f25e1c5111a - tdf#132643 Translate German section IDs Change-Id: I2f2236c92529a439e2c113d3360759746cce8429 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99439 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to e06237458eab93557115b5c5f8e2682fc404d8c8 - tdf#132643 Translate German section IDs Change-Id: I9b1dabdae0617e74a07506a8be445566228cae5f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99438 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 4967b699ba7ee07820de5e5802c9f8185ae3e0b4 - tdf#132643 Translate German section IDs Change-Id: I2d4a6e0a672db21ce316180b02938a118283183a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99437 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 2435b31a5fc9e70a52f5fb573c8847e30139661a - tdf#132643 Translate German section IDs Change-Id: If08df34f7d0d480e31a544470ba3b49702d741e7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99436 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 0cc60d86dc0905e834d67d16ba85b6032f54ace9 - tdf#132643 Translate German section IDs Change-Id: Ie3d894567df57e5557ac7b2dc010ea307aeaeed5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99435 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to e77ae87e8ecbaf52cefe92ffca9cc43e49f75405 - tdf#132643 Translate German section IDs Change-Id: I25a9f8a33be3998c1927275a69a68480d40f16f7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99434 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 64db9db641899c405109b7d10eb5e602f91ec128 - tdf#132643 Translate German section IDs Change-Id: Id31bebc3de230e89376f7d1ba002baee37d36e46 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99432 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to caf41978c40d7c031765083b4e8493584affdaa8 - tdf#132643 Translate German section IDs Change-Id: I027412f1a9cdd47e0bd774660c381dd44dbb2c9f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99431 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to e47a1a6a1510b9def289daa9deaf550fd98e1a52 - tdf#132643 Translate German section IDs Change-Id: I82296c358189107866f5da0e6457fb467017a34f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99433 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to f61b97e69b487c32c3d3f1abdf76eb12323d7a26 - tdf#132643 Translate German section IDs Change-Id: I3d6d7a1a2390c042da70ea09a4e475ad7e27b620 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99430 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25tdf#130559: don't fail creation of preview when BackingComp can't add...Mike Kaganski
an event listener. This crashes when loading a document with print preview set as active view. Regression after commit 128ecffe53394c1f045521c2efb42ea03a319f4b. Change-Id: I5dc421f7c08dd70d51772fac5432f33cd9a1491a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99442 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-25filter/xsltdialog: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. I have changed this from single-instance to multi-instance to avoid loplugin:staticvar and because I can't see a good reason for a dialog to be single-instance Change-Id: Ic7c917fd4923dce11466069e9531bf44989a1ae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99421 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25Use comphelper::IsContextFlagActive for flags from comphelper::NewFlagContextMike Kaganski
Change-Id: Ib4a812dd115299d4251d863d0ee275d7acba1c5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99443 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-25move getUIRootDir to AllSettingsCaolán McNamara
Change-Id: I3b7774a043a2c99531e1c76b531df4358699bba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-25don't need prefix here anymoreNoel Grandin
Change-Id: Ie3b6681cb4ae8c1138766db7b19cc473367bfbd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99422 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25reportdesign/ui: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I622baf4f956cf55ef279b6b659bb477b46d392a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25reportdesign/core: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I0b8197ca63afebef617b75ccc146af645c357902 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99426 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25cid#1465510 Dereference null return valueCaolán McNamara
and cid#1465511 Dereference null return value Change-Id: Ie297ef070ecf712e989704b8c07907e2f6453cd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-25tdf#130559: don't export preview view data to ODSMike Kaganski
... because trying to activate this view on load will throw and crash Unlike in Writer (SwPagePreview), Calc's ScPreviewShell overrides WriteUserDataSequence to export the view data. This was implemented in commit 1f51730f3c5b05c3afaa35431c925482e8152783. That does not give any clue why is this necessary, so I don't want to revert it. So to pass the flag to XViewDataSupplier::getViewData, this patch sets the flag in current context using comphelper::NewFlagContext. This allows to only skip providing the data conditionally. Change-Id: I95d70b30b0b8762d2b5c703c3e572064d0b2ef75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99441 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-25cid#1465512 Wrong operator usedCaolán McNamara
Change-Id: Ieda705abc6d49bfa4c611445f0df92a649b77117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-25cid#1465509 Uninitialized pointer fieldCaolán McNamara
Change-Id: I0c5db5c3252a2d544a2f22327db6f89b1a26af39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-25filter/config: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I4423d3acd0a3c77bb7e553511e296f682f87b3e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25inline some use-once constantsNoel Grandin
Change-Id: I1be21b14b550d5ff586b2306f990882e2e649468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25loplugin:constantparamNoel Grandin
Change-Id: Ic0079cf1d5d2463963b1be08a59cb93db6f12870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25tdf#87605 Add some new termsDaeHyun Sung
1. reorder the technical terms(Ascending order) 2. add DBMSs ex.Cassandra, CouchBase, HBase, etc 3. add Credit Cards ex. JCB, UnionPay, etc 4. add Manufactures ex. LG, Kyocera, HTC, Huawei, ZTE, Meizu, etc 5. add Linus distributions ex. Lubuntu, Gentoo, etc 6. add Internet Service companies ex.Naver, Baidu, Tencent, Alibaba,etc 7. fixed card brand name ex. `MasterCard` to `mastercard` Change-Id: I4fee6dbdf0ef286b64b8a1e461eba060fb53b091 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93279 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-07-25loplugin:unusedmethodsNoel Grandin
Change-Id: I3a35c988b1c55b16958172ed5ef4e2d5cb410e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99413 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>