summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-12-28vcl: BreakLines() -> BreakLine() and BreakLinesSimple() -> BreakLineSimple()Chris Sherlock
Change-Id: I8cb778a09566c1b7d6c2ba4ac5766a5675e62465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158465 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-28vcl: test BreakLinesWithIterator with hyphensChris Sherlock
Change-Id: Ied5e688b9eec19c2f1b3d1289cc4a6605703c3e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157904 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-28vcl: add test for an invalid index in OutputDevice::GetTextBreak()Chris Sherlock
Change-Id: I0b534e42e041972ad2f92e789fc757e949a33d4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158394 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 58b85d5d8886f116064102e38d98e494643fb55d - tdf#155876 UI cmds Calc-Sheet menu (38) + Data menu for Calc, Pivot tables. + refactoring Change-Id: Ie9a39198d84b180558b8d84681cf2f455b3e2e6f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161373 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-27tdf#158803 Remove unused imports from desktopBogdan B
Used pyflakes to find unused imports from desktop module. Then, removed those unused imports. Change-Id: Iccc0661ed586a717f4e5c69c238cbf70d6de0b79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158820 Tested-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-12-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 414d3e7a7b14469df61c49ea030563c2b4093264 - tdf#155876 UI cmds Calc-Sheet menu (37) + Data menu for Calc, DD ranges. + refactoring Change-Id: I467b4c0b654874ca8356908a0c6fb75175f579bf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161369 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-27tdf#144124 Detect if ownership has been lostPatrick Luby
The shortcut assumes that lost ownership notifications from the system clipboard will happen elsewhere. They do under normal conditions, but do not when some clipboard managers are running. So, explicitly check ownership to catch such cases. Change-Id: If54ca8c9908650c23c348e08231820ee7c2483e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161337 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-27tdf#158803 Fix issues detected by pyflakesChenxiong Qi
Change-Id: Iaa329dff61db894e7d5fecd840e785a53a48b26f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160889 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-12-27Use emplace_back instead of push_back (Formula)Julien Nabet
Change-Id: I6596e9d002016e5b501900fe9da26b5910cf7653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-27Use rtl::Reference to avoid static_casts, and simplifyMike Kaganski
Change-Id: I6975d34f0fb65f49be8988d1389f0bebe8ad6bc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161368 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3f51688cec199b0535a7ed7262dd2266499abc66 - Housekeeping Help page on Calc financial functions Change-Id: I6e6e6c3088211e0f1ba625949c27ef82fd749008 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161367 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-27tdf#158862: check if document is initializedMike Kaganski
Change-Id: I5b380c0629a756a5d7f0f06fb95fab996360b821 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161366 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 2a670f53d8c90aca037007b931c7237658d3f3f6 - tdf#155876 UI cmds Calc-Sheet menu (36) + Data menu for Calc, Filters. + refactoring Change-Id: I5bb6d7a8b9b5a60c81d680786b6de372d7815807 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161336 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to aa9cf7cb03cc8c9cef9ba5d38189f44286c06b7b - tdf#155876 UI cmds Calc-Sheet menu (35) + Data menu for Calc, Sort. + refactoring Change-Id: I1cbaac58f3bb194b7ed206e68e5ff8f10579ae9e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161335 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-26Remove executable bits on data fileAndrea Gelmini
Change-Id: Id6d8ccc82f892b098d96e28a7222c58e08e22b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161086 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-26Fix typoAndrea Gelmini
Change-Id: I325079efc51bbefb7612403e4800ca5320b49cec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161334 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-26Use emplace_back instead of push_back (extensions part2)Julien Nabet
Change-Id: Ib86f85e6162639d229443cb3026c355c6a659932 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161306 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-26Use emplace_back instead of push_back (sd)Julien Nabet
Change-Id: I5641a98f26a19efabb3a5eee25e48282d44faca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161332 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-26Use emplace_back instead of push_back (scaddins)Julien Nabet
Change-Id: I08b22351a3e75d5accbb3e59890f5e04b8fbb6d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161333 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-26tdf#135478 Reduce sensitivity of horizontal scrollwheelPatrick Luby
Problem: at least on macOS, swipe events are very precise. So, when swiping at a slight angle off of vertical, swipe events will include a small amount of horizontal movement. Since horizontal swipe units are measured in cell widths, these small amounts of horizontal movement results in shifting many columns to the right or left while swiping almost vertically. So my hacky fix is to reduce the amount of horizontal swipe events to roughly match the "visual distance" of vertical swipe events. The reduction factor is arbitrary but is set to roughly the ratio of default cell width divided by default cell height. This hacky fix isn't a perfect fix, but hopefully it reduces the amount of unexpected horizontal shifting while swiping vertically to a tolerable amount for most users. Note: the potential downside of doing this is that some users might find horizontal swiping to be slower than they are used to. If that becomes an issue for enough users, the reduction factor may need to be lowered to find a good balance point. Lastly, fix the unbalanced rounding of delta X and Y values due to using floor() for macOS native swipe and scroll wheel events. Change-Id: I8c0c9a3aa688e411c47ebb5e7500f3a50f6f673b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161278 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-26Simplify aPropVector construction in framework/statusbarmanagerJulien Nabet
Change-Id: I14dfe9f156109c9c098e27fcf88ca9a273e7722c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161308 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-26tdf#151679 Do not push FLAVOR_LINK to macOS general pasteboardPatrick Luby
When copying text from a Writer document and the FLAVOR_LINK flavor is pasted, Writer will edit the copied text in order to create a bookmark for DDE. The problem is that many macOS clipboard managers fetch *all* available flavors that are available in the macOS general pasteboard instead of just one flavor and this triggers the FLAVOR_LINK flavor's unusual editing behavor in Writer every time the user copies Writer text. Users have reported in tdf#1515679 that on macOS, Microsoft Writer, Excel, and PowerPoint do not recognize this flavor like is done on Windows so, in theory, we can just filter out this flavor when adding flavors to the macOS general pasteboard. With this change, the FLAVOR_LINK flavor will still be visible when copying and pasting within a single LibreOffice instance as well as when dragging from LibreOffice to other applications. Change-Id: Ia391398286fa8795ac65b4702a15caf59fb3ae70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161305 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-26Make GetpApp() the pNotifier's default valueMike Kaganski
It fixes asserts in various places where a message box wants to show in Lok case Change-Id: If3c18e92c131de640281f3365567d66b4e14e1ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161299 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-26cid#1545970 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Ifbec5f91dd11a495fcf01ad95fcdcc867e882f70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161293 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-26cid#1559882 Uninitialized scalar fieldCaolán McNamara
and cid#1559872 Uninitialized scalar field Change-Id: Iaea583d63cd1f0a1b68c60adb57c8c1db9a26a9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161292 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-26cid#1559938 Dereference null return valueCaolán McNamara
Change-Id: I9e4fd4a3c2cf56bb50e765cf64401ac7aa80847c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-26cid#1559937 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1559939 COPY_INSTEAD_OF_MOVE Change-Id: Ic5e581aff9e12c8c6277355b0a8bc99a155dc63e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-25tdf#158023 Add \ before parentheses if they are in the <t> tag.Irgaliev Amin
MSO allows you to write unpair opening or closing parentheses in the t tag. The patch adds a backslash before parentheses, which allows you to correctly recognize and correctly save such formulas when exporting. Also add a test to check whether the parentheses are wrapped correctly. Change-Id: Ib1a941858f0843742b56b8089f3c14983ba1222c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158794 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2023-12-25android-viewer translated using WeblateWeblate
Dutch currently translated at 100.0% (118 of 118 strings) Change-Id: I59c75900254b4124ff7dc8397a943908404e0a5c android-viewer translated using Weblate Italian currently translated at 35.5% (42 of 118 strings) Change-Id: I73561c67beafbeeee4896d7b2301d1b3970eb030 android-viewer translated using Weblate Asturian currently translated at 100.0% (118 of 118 strings) Change-Id: I83e753b66c856b4fa39cba5bf1de1e44616b1cba android-viewer translated using Weblate Basque currently translated at 100.0% (118 of 118 strings) Change-Id: I6e956873841380aabd1351dbbd07f3466ba28275 android-viewer translated using Weblate French currently translated at 100.0% (118 of 118 strings) Change-Id: I1af1d53bd1daaab3bd0404d8fe75b92e5923b9e2 android-viewer translated using Weblate Punjabi currently translated at 95.7% (113 of 118 strings) Change-Id: I7582795194c21cc6c954884bd4612e9cefc01308 android-viewer translated using Weblate Galician currently translated at 100.0% (118 of 118 strings) Change-Id: Ica6acf55e43ec98648b021b9f38871aedf2581fa android-viewer translated using Weblate Turkish currently translated at 100.0% (118 of 118 strings) Change-Id: If8639fcaf3b5b0447c0b00f5fe85ed55d0bb7cad android-viewer translated using Weblate German currently translated at 100.0% (118 of 118 strings) Change-Id: I0c5795094434899569e18ae6d87c4bed2e10ea01 Co-authored-by: A S Alam <amanpreet.alam@gmail.com> Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Co-authored-by: Aitor Salaberria <trslbrr@gmail.com> Co-authored-by: Ayhan YALÇINSOY <ayhanyalcinsoy@gmail.com> Co-authored-by: Christian Kühl <kuehl.christian@googlemail.com> Co-authored-by: Elisabetta Manuele <calembour@hotmail.it> Co-authored-by: Xosé <xosecalvo@gmail.com> Co-authored-by: kees538 <kees538@gmail.com> Co-authored-by: sophie <gautier.sophie@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eu/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fr/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/gl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/nl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pa/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tr/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161274 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2023-12-25ScriptForge - Upgrade to version 24.8Jean-Pierre Ledure
Copyright years are also reviewed to include 2024. Change-Id: I1f30443922a6dc3b35c6f05616a5c4e56de1e396 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161277 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-12-25tdf#158855: Make sure to not add extra paragraph after a table in a sectionMike Kaganski
Simplify the condition for last paragraph removal in lcl_utext, and clean up the complications piled after commit 2e8aad6d45c53d554ccaf26de998ede708cfc289 (fdo#39056 fdo#75431 Section Properties if section starts with table, 2014-04-24). This makes sure that the trailing extra paragraph gets properly removed, even when there was a dummy paragraph added for a table in section. Because of the removed check, import used to avoid the removal of the extra paragraph immediately following a table (when the table needed to be the last element in the section); hence, in DomainMapper_Impl::appendTextSectionAfter, a last section's table was followed by two paragraphs (one that is expected to stay after the created section, and one before that, that was not removed after the table). xCursor had ininitally both paragraphs in the selection after the forward goto* calls; and then, gotoLeft excluded only the last paragraph from the selection. After the change, in such a case, there is only one paragraph in the end: the one that should stay after the created section. But calling gotoLeft then would have to put the end of selection to a text node inside the table; since the selection that starts before the table can't end inside the table, the call resulted in the whole table excluded from the selection. This requires to add a paragraph here, to allow the previous behavior of cursor; and then the last paragraph in section is destroyed. The code makes sure that the trailing paragraph kept after the creation of the section has all the properties applied to the old last paragraph. testFdo53985 used to check for total 9 paragraphs in the document; while 3 of those were introduced exactly by the bug fixed here; they are absent in Word. The test is fixed; its logic is unchanged, and it still correctly tests that a round-trip doesn't increase number of paragraphs. Change-Id: Ibf6349ba7906dac185c759eb3b58c1849ee5064a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161275 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-25tdf#99116 modify menu highlight text color in high contrast mode on winYli875
In high contrast mode, persona color won't overwrite the menu highlight text color. This commit fixes this aspect when using the High Contrast theme on Windows, mentioned in tdf#99116 comment 20: > expanded top menu hover colour is correct but the white text does not invert to black (although this is not specific to the Start Center) Change-Id: I1575226d966d60af93b5d64934c965f61b8f2d69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160058 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-24Eliminate warning when changing timer's priorityPatrick Luby
Task::SetPriority() expects the timer to be stopped while changing the timer's priority. Change-Id: Ib025cc1451bf6fa959284d202d29dbb1489beb0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161272 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-24Remove listeners of SvtAccessibilityOptionsGabor Kelemen
This class no longer notifies listeners since 2019 commit 3135d820d0172ef5695a4b97cec505e6ad03d67a so presumably the listeners can be dropped as well. The sd part tried to execute SID commands which seem to be removed since 2004 commit f77ad7f15f53526714518bb3562ba7de4ba0d45e Change-Id: I81d234aabe10b53278c89ffd846240507854d0c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161237 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-24tdf#158837 hyphenation crash in: int rtl::str::indexOfStr_WithLengthNoel Grandin
the code was already dodgy, passing in an invalid nPos, which triggers an assert. However, it appears that previously that dodginess was ignored, until commit 5ebccaa07589383653dbd65e58204a82dd3cde09 author Noel Grandin Sat Apr 10 17:27:08 2021 +0200 use std lib for O[U]String indexOfStr which turned it into a crash. Add a check to avoid the crash, no idea what the right fix would look like. Change-Id: I826b9af0b2d9c7c297214ce2d54c664fb573edd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161271 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-24Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 18e470796f402ef404a12231c9834acbdaefbd0f - Fix grammar Change-Id: Icffc8d455aca78164ab20c1bf8bf95999433fcaf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161223 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-24Silence new GCC 14 trunk -Werror=alloc-sizeStephan Bergmann
> sal/rtl/byteseq.cxx: In function ‘void rtl_byte_sequence_reference2One(sal_Sequence**)’: > sal/rtl/byteseq.cxx:63:20: error: allocation of insufficient size ‘8’ for type ‘sal_Sequence’ {aka ‘_sal_Sequence’} with size ‘12’ [-Werror=alloc-size] > 63 | pNew = static_cast<sal_Sequence *>(malloc( SAL_SEQUENCE_HEADER_SIZE )); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I9d4081ed2938fffdf282c852250a3eed5f0d9e25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161269 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-24tdf#158807 Call UpdatePaletteForNewColor with rReplaceColor parameterPatrick Luby
Change-Id: Id9d55600c69e84f7d7ffdd9cfbf4e1b3985b79c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161260 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-24-Werror=calloc-transposed-argsStephan Bergmann
Change-Id: I7b8b020bdbcd5b4db4cb478cc5fe1225f19ae0cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161268 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-24cid#1545470 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545468 COPY_INSTEAD_OF_MOVE cid#1545446 COPY_INSTEAD_OF_MOVE cid#1545435 COPY_INSTEAD_OF_MOVE cid#1545419 COPY_INSTEAD_OF_MOVE cid#1545415 COPY_INSTEAD_OF_MOVE cid#1545410 COPY_INSTEAD_OF_MOVE cid#1545390 COPY_INSTEAD_OF_MOVE cid#1545384 COPY_INSTEAD_OF_MOVE cid#1545374 COPY_INSTEAD_OF_MOVE cid#1545371 COPY_INSTEAD_OF_MOVE cid#1545368 COPY_INSTEAD_OF_MOVE cid#1545366 COPY_INSTEAD_OF_MOVE cid#1545335 COPY_INSTEAD_OF_MOVE cid#1545331 COPY_INSTEAD_OF_MOVE cid#1545327 COPY_INSTEAD_OF_MOVE cid#1545308 COPY_INSTEAD_OF_MOVE cid#1545280 COPY_INSTEAD_OF_MOVE cid#1545199 COPY_INSTEAD_OF_MOVE Change-Id: If05a13125b05ccd93d34d0eced566e7b3b58aaef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-24Drop some wrapper methods from SvtAccessibilityOptionsGabor Kelemen
just use the wrapped officecfg methods instead of: GetIsAllowAnimatedGraphics GetIsAllowAnimatedText GetIsAutomaticFontColor IsSelectionInReadonly Change-Id: I74de75fc9ff2f9a36ef376255e937bb373055587 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161236 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-12-24tdf#146619 Recheck include/ with find-unneeded-includes --noexcludeGabor Kelemen
to see if some exclusions became obsolete Change-Id: Id88351f5448511b35994c58c6cb749784da3b45e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156993 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-12-24Remove unused headers found by bin/find-unusedheaders.shGabor Kelemen
Change-Id: I859138dee575ef7fd76db28b619c673782914782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161235 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-12-24Rewrite bin/find-unusedheaders.pyGabor Kelemen
This script was broken, not only in the implementation (it gives too many false positives in a suspiciously short, <1s time) but in its approach as well: only considering stuff that is compiled under Linux inherently leaves out other platform specific or experimental stuff. Rewrite it using another approach: grep for mentions of each header in the modules or global ones in include/ everywhere. Runtime of this script is about 15 minutes, seems to give only a few relevant hits. Change-Id: Ifb92f41f11ca9a2bf14eec617a469003becb78fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161234 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-12-24vcl/README.vars: SAL_FORCEDPI works for all Linux vcl pluginsMichael Weghorn
Running any of the Linux VCL plugins with SAL_FORCEDPI=192 resulted in a scaled UI for all of them in a quick test, so update the README accordingly. Change-Id: I57b2b716c84556be6b66ed51f9c5198bacf10030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161264 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-24qt: Rename SAL_VCL_{QT5 -> QT}_NO_NATIVEMichael Weghorn
Similar to Change-Id: I01b427648ef14f918cc692b30c80a7427455324f Author: Michael Weghorn <m.weghorn@posteo.de> Date: Sun Dec 24 00:13:25 2023 +0100 qt: Rename SAL_VCL_QT5_NO_NATIVE and use for all Qt-based VCLs , drop the version name in the env var to evaluate to decide whether to use fontconfig or not, since there's no reason this should only apply for qt5-based VCLs and not qt6-based ones. (Other than for the above-mentioned commit, the env variable would already be evaluated for all Qt-based VCL plugins, not just the qt5 one.) Change-Id: I2e239bf78916c37133f3992f49bb5dfa385c5801 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161263 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-24qt: Rename SAL_VCL_QT5_NO_NATIVE and use for all Qt-based VCLsMichael Weghorn
Instead of evaluating a `SAL_VCL_QT5_NO_NATIVE` environment variable to determine whether to disable drawing of widgets using the `QStyle`, evaluate `SAL_VCL_QT_NO_NATIVE` (i.e. without a Qt version number in the name), and do this for all Qt-based VCL plugins (qt5, qt6, kf5, kf6), not only qt5. I don't see a reason why this should be qt5-specific. Change-Id: I01b427648ef14f918cc692b30c80a7427455324f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161262 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-24OInterfaceIteratorHelper3 always copies maData contents in ctorCaolán McNamara
while I think the idea is that the copy on write should only be done by OInterfaceContainerHelper3, i.e. that ownership really transfers to OInterfaceIteratorHelper3 and OInterfaceContainerHelper3 makes a new one if that turns out to be necessary Change-Id: I6e97e3b303f133edbbb35ac23f39cf5348ad49fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161257 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-24zxcvbn-c: disable warningsThorsten Behrens
Change-Id: I348dc5f92f41fc3e8c1aee8743d5e1cf86fa3bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161259 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-24xmlsecurity: fix AES-GCM code differentlyThorsten Behrens
With PCH, the earlier workaround with NSS_PKCS11_2_0_COMPAT breaks - so lets fix this with conditionals, its only two places. Follow-up commit to 9276d5338ef04209b007bbc705e4c023cf181456 Change-Id: I7d3292304d83d784ee9dce5cdc62b4a028ff333a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161204 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>