summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-06-16tdf#103064 Improve comment style usage detectionMaxim Monastirsky
With this patch the "Applied Styles" filter should list also styles used in comments. Change-Id: Ifcb716cb66a0d271ca3d7ce477e6299015310ff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153163 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-16tdf#103064 sw: enable the UI commandsMaxim Monastirsky
Change-Id: Ic3e5ab9df5386a1cad0801f7044e6148620aa3b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152643 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-16ofz#59854 Null-dereference WRITECaolán McNamara
Change-Id: Iedbf21248b7d75474ea325905569d192360380f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-16Fix typoAndrea Gelmini
Change-Id: I774554c7945d5560e229d6c94e9efbafd77deeca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153106 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-16speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: I652f02f6f1f354e2dab4f0ca866e8499cd3c50f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-16sw layout xml dump: extract SwTextFrame::dumpAsXml() from SwFrameMiklos Vajna
Ideally SwFrame should not really know anything about text frames. Change-Id: I2734e76ced3001de1fc1176d6315f8c69c02d8b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153152 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-16tdf#103064 sw: use the comment style by default instead of DFMaxim Monastirsky
As part of that, language changes in the document's body are no longer applied to comments, as that would be a DF. Instead, the default language of comments is controlled via the style (see tdf#153805 for the use case). Change-Id: Icfa9a7334b52fe74292e82fa8daa01a15197e384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153158 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-16tdf#103064 sw,editeng: enable UNO API and ODF import/exportMaxim Monastirsky
Change-Id: Icf30e1f30fe6bf6a7d96d14b975954613cd68b70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153157 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-16tdf#103064 sw,editeng: make para styles work inside commentsMaxim Monastirsky
- Style objects for comments are stored in a dedicated stylesheet pool, and constantly updated from the "real" styles using modification broadcasts. In theory, it should be possible to use same objects for both Writer core and EditEngine, as they use separate item ranges. But unfortunately SwDocStyleSheetPool isn't really a styles container, but just a wrapper around Writer's core styles, with a single mxStyleSheet member that is filled each time with data from different styles (while EditEngine expects different styles to be represented by different objects). - EditEngine switched to allow duplicate listeners for styles - one per paragraph. The use case is 2 paragraphs of the same style, and then one of them is switched to another style. In that case we still need to keep listening to the former style for the other paragraph. There is probably some opportunity for optimization, but it should be good enough for now. - Copying formatted text from document's body doesn't preserve style assignment for now. The editeng RTF import should be tweaked to not insert styles into our "special" stylesheet pool (or somehow forward them to Writer's core style handling) before we can enable this part. Change-Id: Ib67c5388f9cd078c73ec0d453017f815843161ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153156 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-16sc: filter: oox: do not insert rule too earlyHenry Castro
The </cfRule> tag is a good place to do a post check the conditional format sanity. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Id6e99c81011040ec47034e993490fae5c71d7e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149719 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151977 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153159 Tested-by: Jenkins
2023-06-15tdf#155736 Modified IsInTOC() to handle IsInHeaderFooter() case.Satya
This fixes a problem of page numbers missing in the footer. The importer might start processing the footer before the TOC has finished - m_bStartTOC might be true. In this case we are not actually IsInTOC,and m_bStartTOC should be ignored and make use of IsInHeaderFooter() and m_bStartTOCHeaderFooter to confirm if the footer/header itself has TOC. Change-Id: Ieede9f8e2120556630ba57b9c748935788f3cc9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153052 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Justin Luth <jluth@mail.com>
2023-06-15sc: qa: add databar unit testHenry Castro
<x14:dataBar maxLength="100" minLength="0" border="1" axisPosition="automatic" direction="context" negativeBarBorderColorSameAsPositive="0"> <x14:cfvo type="num"> <xm:f>0</xm:f> </x14:cfvo> <x14:cfvo type="num"> <xm:f>1</xm:f> </x14:cfvo> <x14:fillColor rgb="FF63C384"/> <x14:borderColor rgb="FF63C384"/> <x14:negativeFillColor indexed="2"/> <x14:negativeBorderColor indexed="2"/> <x14:axisColor indexed="64"/> </x14:dataBar> Change-Id: Ib57dac07027e2c3c01ee556a3df791f49637be54 Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149070 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153120 Tested-by: Jenkins
2023-06-15tdf#103064 sw: improved notifications on style modificationMaxim Monastirsky
- More useful notification on undo - Added notifications for theme change and UNO API. Change-Id: I554dceff92f4f8a6dd5c39c6965b7de706ab6678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153110 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-15tdf#103064 editeng: fix handling of char highlightingMaxim Monastirsky
Transparency should be set to false if a color is present, but not with COL_TRANSPARENT. Compare with what is done for shape text in VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D. Change-Id: I5e4c8e53b53a363813ced50358c5ee795cdb61dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153107 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-15tdf#133507 sw: hunt for documents with ULSpacing at section endJustin Luth
When a paragraph style has "contextualspacing" with Spacing Above paragraph, and option "Don't add space between paragraphs of the same style, the spacing should apply after a section end. Contextual spacing was officially added to 1.3 spec in 7.0-ish timeframe: "The space between the paragraphs is zero, if all of the following conditions hold: ... The paragraphs belong to the same content area. ... Contextual spacing was actually added in LO 3.6, and it applies as expected when transitioning from one section to another. The missing case was when transitioning from a section back to the main body text. This was an implementation error. So the question is whether we add yet another compatibility flag to handle the old way of doing things, or just fix it. I'm leaning towards no compat flag because -it is a recent official addition to ODF -it is an implementation error -it currently is inconsistent - works on section start, but not end -rarely used: it is primarily an interoperability feature -rarely encountered: sections aren't really needed in LO. -no existing unit tests matched the condition. -interoperability isn't affected - section end == document end. This patch is hunting to prove some of the above points. -shouldn't hit any DOC/DOCX/RTF files. -only expect to find ODT files related to this bug report. So, I don't think a compat flag is warranted in this case. It is easy enough for a human to "fix" the document by removing the undesired "spacing before/after" settings. make CppunitTest_sw_odfexport2 \ CPPUNIT_TEST_NAME=tdf133507_contextualSpacingSection Change-Id: Ia041741bbada8c2f4cd97aa6b7cd98d4d7ffb275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153033 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-15speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: Ief35b1e3e08ed44c1b9161485a69ef504e1a1c89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-15Related tdf#148263: on Writer, no need to repeat "Delete" for columnsJulien Nabet
To reproduce the regression, just do this: - launch Writer - create a by default 2x2 table - select a cell - right click and take a look at sub-entries of Delete entry Change-Id: I05bf4824e0786f1b4ea73b24389d38858e01818e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153122 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-15tdf#103064 sw: add a comment styleMaxim Monastirsky
Change-Id: I96acdf3200836efe1d66e19dd85000fca9e7a6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153109 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-15tdf#103064 editeng: invalidate spelling results on style changeMaxim Monastirsky
Because a style might define a different langauge. This is similar to what we do for DF in SetAttribs/SetParaAttribs. See also alternative approach in SwLangHelper::SetLanguageStatus or SwAnnotationWin::SetLanguage. Change-Id: I38caa716ec95958580f4ce0ede70eff5d1024e13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153108 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-15wrap OSQLParser::s_xLocaleData in vcl::DeleteOnDeinitNoel Grandin
since my adaption of i18npool to use OUStringLiteral, this data structure might get torn down after the i18npool data is has pointers to. Change-Id: If83d232d5bfb003ed4dbfb70d47f707a73d2bcc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-15speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Here we trigger a problem - EditDLL has static data that tends to get torn down __after__ the i18npool shared library has been removed from memory, which means it tries to access OUStringLiteral objects that no longer exists. So use vcl::DeleteOnExit to explicitly clear that on application shutdown. Change-Id: Ie4bfcef7eb4656316ea825474ac42f85844d1dcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-15remove some misleading typedefsNoel Grandin
Change-Id: I8016c42c3ff8d1cf03c276ebbb68ae7872cd43fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-15tdf#155685 sw: ExtendedSelectAll with tables, group the Undo objectsMichael Stahl
Change-Id: I2fba70968c97cd9704212cd799b333d2d158a042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153115 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-15tdf#155685 sw: fix another ExtendedSelectAll Redo crash w table at endMichael Stahl
This can be reproduced with a table containing in the last cell a paragraph followed by a table, then ExtendedSelectAll in the cell and delete. On Redo of the SwUndoDelete: warn:legacy.osl:326138:326138:sw/source/core/frmedt/tblsel.cxx:1775: MakeSelUnions with pStart or pEnd not in CellFrame In function: const_reference std::vector<SwTableBox *>::operator[](size_type) const [_Tp = SwTableBox *, _Allocator = std::allocator<SwTableBox *>] Error: attempt to subscript container with out-of-bounds index 0, but container only holds 0 elements. The problem is that DelTable() calls PaMCorrAbs() with a target that is outside of the outer table, so the SwEditShell::DeleteSel() rPam has one end in the last table cell and other end outside the table. Change-Id: Ia2764a4c99ba12102957153e005284a44be04fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153114 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-15gdb: BigPtrArrayPrinter, add the suffix, so 0->0ulJulien Nabet
On pc Debian testing with GNU gdb (Debian 13.2-1) 13.2, I got this trying to debug tdf#131173 Thread 1 "soffice.bin" hit Breakpoint 1, SwUndoTableMerge::UndoImpl (this=0x5599a0d302b0, rContext=...) at sw/source/core/undo/untbl.cxx:1878 1878 SwStartNode* pSttNd = rDoc.GetNodes().MakeTextSection( aIdx.GetNode(), (gdb) p rDoc.GetNodes() $1 = (SwNodes &) @0x5599a0477000: {<BigPtrArray> = BigPtrArray of length 18Python Exception <class 'gdb.error'>: No type named std::_Head_base<0, BlockInfo**, false>. , m_vIndices = 0x5599a04a4478, m_rMyDoc = @0x5599a0479590, m_pEndOfPostIts = 0x5599a04739b0, m_pEndOfInserts = 0x5599a042da70, m_pEndOfAutotext = 0x5599a04764b0, m_pEndOfRedlines = 0x5599a04765e0, m_pEndOfContent = std::unique_ptr<SwNode> = {get() = 0x5599a0478d20}, m_aOutlineNodes = {<o3tl::sorted_vector<SwNode*, CompareSwOutlineNodes, o3tl::find_unique, true>> = {m_vector = std::__debug::vector of length 0, capacity 0}, static npos = 18446744073709551615}, m_bInNodesDel = false, m_bInDelUpdOutline = false} with the patch, I got: (gdb) p rDoc.GetNodes() $1 = (SwNodes &) @0x55c379492b10: {<BigPtrArray> = BigPtrArray of length 18 = { [ 0] 0x55c37948c9a0 StartNode , [ 1] 0x55c3794859a0 EndNode , [ 2] 0x55c379492bb0 StartNode , [ 3] 0x55c37948a6c0 EndNode , [ 4] 0x55c3794925a0 StartNode , [ 5] 0x55c37948ff10 EndNode , [ 6] 0x55c379492630 StartNode , [ 7] 0x55c379490040 EndNode , [ 8] 0x55c3794926c0 StartNode , [ 9] 0x55c3795bd170 TableNode , [ 10] 0x55c379606280 StartNode , [ 11] 0x55c379616ee8 TextNode "", [ 12] 0x55c37960cd70 EndNode , [ 13] 0x55c379612780 EndNode , [ 14] 0x55c3794b6628 TextNode "", [ 15] 0x55c37962d848 TextNode "", [ 16] 0x55c379616778 TextNode "", [ 17] 0x55c37948fd20 EndNode }, m_vIndices = 0x55c3794bda68, m_rMyDoc = @0x55c379492f80, m_pEndOfPostIts = 0x55c3794859a0, m_pEndOfInserts = 0x55c37948a6c0, m_pEndOfAutotext = 0x55c37948ff10, m_pEndOfRedlines = 0x55c379490040, m_pEndOfContent = std::unique_ptr<SwNode> = {get() = 0x55c37948fd20}, m_aOutlineNodes = {<o3tl::sorted_vector<SwNode*, CompareSwOutlineNodes, o3tl::find_unique, true>> = { m_vector = std::__debug::vector of length 0, capacity 0}, static npos = 18446744073709551615}, m_bInNodesDel = false, m_bInDelUpdOutline = false} Change-Id: I492b49dd1a554dc95abb0ed97fa99541c8dbd7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153111 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-15Use sal_Int32 instead of overzealous use of autoKhaled Hosny
Change-Id: Ia307f398260343fe388965673da42d9404195224 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153117 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-15sw layout xml dump: show page frame of anchored objectsMiklos Vajna
It's useful to see if this is updated already or not when the object moves between pages. Change-Id: Iccad297585c04d77a95eb6cd31b65919470a97e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153102 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-06-15ODF export: simplify restart handling to skip list id where possibleMike Kaganski
This continues to minimize cases where random ids are written, helping to make the output more deterministic; it builds upon commits 8f48f91009caa86d896f247059874242ed18bf39 (ODT export: omit unreferenced <text:list xml:id="...">, 2022-03-10), and 82bbf63582bdf28e7918e58ebf6657a9144bc9f3 (tdf#155823: Improve the check if the list id is not required, 2023-06-14). The previous code used to write 'text:continue-list' when the list is restarted. It is unnecessary when there is no other condition requiring such a reference (like style change, or interleaving lists); so relax the conditions allowing to put simple 'text:continue-numbering="true"'. This also allows to simplify a bit the code around 'ShouldSkipListId'. Change-Id: Idf8be455953d08fd578266bda22f3a55d7b9ee23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153104 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-15libjpeg-turbo is used for import but also export jpeg filterJulien Nabet
Change-Id: I257db8f1c59ff16d70751fe875594faa8e07e902 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153002 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-15tdf#155161: Add testKhaled Hosny
The test document embeds Cantarell font because we don’t bundle any fonts with CFF2 table (or CFF table for that matter). Change-Id: Icdbab58ea3999baa75bc85fad60172218d9f6058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153054 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-15Don’t add empty Fonts dictionary to Type 3 font resourcesKhaled Hosny
If the Type 3 font does not use any other fonts, skip writing Fonts to its Resources dictionary. Change-Id: I1d0489debeb9f0e24022316551eb234b279381c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153100 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-15speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: Iae879408d6761098d0e73526a65863d8f3cdb9ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-15tdf#155833: apply transform to image even if target is equal to viewboxXisco Fauli
Change-Id: Ie820528384d096c6a332e2abd0095f68c7f64a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153103 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-15nss: upgrade to release 3.90Taichi Haradaguchi
Change-Id: Ic446f33abd5355886b8c8c181a088c07ea4605c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153096 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-15tdf#155699 - MRU: show pinned documents at the beginning of the listAndreas Heinisch
Change-Id: Id08678708ee74a4a278baa1e67930044f25e5d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152690 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-06-15sw floattable: fix handling of upper margin of anchor for fly intersectMiklos Vajna
The bugdoc has 2 paragraphs and a shape between them. Word has a small amount of space between the shape and the 2nd paragraph, Writer has a large amount of space between the shape and the 2nd paragraph. It seems what happens is that Writer puts both the text node's own upper spacing and the previous text node's lower spacing into the upper spacing of the text frame, so the check added in commit d07fc485d46f431405a3f6a002f951a08c559677 (tdf#116486 Consider upper margin in paragraph positioning with flys, 2018-04-10) is not entirely correct, as it deal with both upper and lower margins, but its intention was just the upper margins. Fix the problem by (indirectly) using GetUpperSpaceAmountConsideredForPrevFrame(), which allows doing the intersection for the original text node upper spacing but not for the text node lower spacing. This keeps the original bugdoc working, but fixes the unexpected vertical space for the new bugdoc. This is part of the effort so that the original bnc#816603 bugdoc's DOCX version moves an overlapping floating table from page 4 back to page 3, like Word does. testTdf122878 is modified to just make sure no overlap happens, manual testing of the bugdoc shows that our layout still matches Word. Change-Id: I4622fb77dc8a52493766e50688ec92065eac65bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153101 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-06-15ooo#41037 Reject URLs containing unencoded NUL charactersStephan Bergmann
Change-Id: I45bbd342734f190ce918b610441ca911a47830b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153062 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-06-15sd: fix crash deleting 2 slides during paintTileLuigi Iucci
pPageView was null in SdXImpressDocument::paintTile while trying to paint form controls, which is a corner case in most cases then we skip painting in order to avoid a crash Change-Id: I6c166035220c058fac276f2b7746a8ebc9651f81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152379 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-15tdf#155728 - A11y sidebar: fix Update issue list after fixing an issueBalazs Varga
in case of SdrObjects. Change-Id: I45608d423c0da0f1a983dcfad43562c3d7c9ee67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152953 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-06-15UITest_manual_tests: use oneprocess modeMiklos Vajna
Execution time goes from: real 0m42,203s to real 0m31,854s Also the same for UITest_pasteSpecial: 2m4,180s -> 1m39,375s Also the same for UITest_protect: 0m13,758s -> 0m12,817s Change-Id: I5fb00ca0c854e4078f7cae12dee507aa61da3770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153090 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-15Fix typoAndrea Gelmini
Change-Id: Ieadd5121185e9c3a5258336e3bfece23c1efdc73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153067 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-15sc: filter: oox: insert a new entry ScDataBarFormat if Id attribute...Henry Castro
does not exist: <x14:cfRule type="dataBar" priority="1" id="{006000A4-0067-40D4-A5EF-00D900B80077}"> <x14:dataBar maxLength="100" minLength="0" border="1" axisPosition="automatic" direction="context" negativeBarBorderColorSameAsPositive="0"> <x14:cfvo type="num"> <xm:f>0</xm:f> </x14:cfvo> <x14:cfvo type="num"> <xm:f>1</xm:f> </x14:cfvo> <x14:fillColor rgb="FF63C384"/> <x14:borderColor rgb="FF63C384"/> <x14:negativeFillColor indexed="2"/> <x14:negativeBorderColor indexed="2"/> <x14:axisColor indexed="64"/> </x14:dataBar> </x14:cfRule> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ie2c1ba2c85d9eead963f4d9b1684d72b64fe815d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149069 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153092 Tested-by: Jenkins
2023-06-14Add editengine view separation in tiled renderingParis Oplopoios
Editengine now gets the background color from the current view instead from a global variable Change-Id: I98a0fccf4d0c83f4dabf8e534a9228b8a5e271d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> (cherry picked from commit 7baa475342b67c10537e11da37b8862648679b02) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153073 Tested-by: Jenkins
2023-06-14tdf155825 result same size in synchronize gradientsRegina Henschel
While synchronizing color and transparency gradients two new sequences are generated. In case the last offsets where different, the remaining stops where not copied to the new sequence and thus they had different sizes which triggered an assert in oox/source/export/drawingml.cxx. Change-Id: I446f8cfafb23735f06ad4e05eee8c922141b864d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153063 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-14sc: filter: oox: update databar format before cloneHenry Castro
The ScDataBarFormatData should update from import (finalizeImport) before cloning, otherwise it loose data. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I4af8b79e93eed8091bf01244bacac1d12e591c45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149068 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153068 Tested-by: Jenkins
2023-06-14tdf#155735: Add support for saturate typeXisco Fauli
Add getModifierName to BColorModifier class so when can assert which modifier is being used Change-Id: I2bc2a36470a449df4dc84a8440f232149c1f8278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153048 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-14cid#1532384 Out-of-bounds readCaolán McNamara
sizeof returns num of bytes, not num of elements Change-Id: I9dea109e5f322d93ee10680f120b15554efa92e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-14Related: tdf#150494 add placeholder text to the REST protocol fieldMike Kaganski
Change-Id: I8aab941d9dd03e54a3a39ccb643a5a628d6c5be7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153061 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-14online: speed up scrolling large excel documentNoel Grandin
the expensive part is the GetTiledRenderingArea(), so lets only do that once, instead of twice Change-Id: I2d18bce1ff116d6d711f0908502963c9743dea8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-14speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: I95214d09938036935a45e8b8e9752596246dd2e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153058 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-22 10:23:16 +0000