Age | Commit message (Collapse) | Author |
|
Change-Id: Id73eb4c941ac9bcf75c518cefba795de587edbd9
Reviewed-on: https://gerrit.libreoffice.org/80957
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
... so do the same when exporting to prevent surprises with iOS
and OSX viewers or maybe other tools.
This made it necessary to adapt
ScExportTest::testExtendedLCIDXLSX() that checks calendar and date
relevant exported format strings.
Change-Id: I243d536e2a42562ec46375923facfa222ecbb29b
Reviewed-on: https://gerrit.libreoffice.org/80920
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
ever since it was introduced in
commit d09dd8986436f17717443823ef18bd8552fdf408
Date: Wed Sep 15 13:55:34 2010 +0200
dba34a: export/import min-/max-/default-/value for date/time as
XML-Schema conformant strings
looks like classic over-engineering
Change-Id: Ia4e4b65cfe92f522dee238a54a37db01f691750e
Reviewed-on: https://gerrit.libreoffice.org/80951
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibadc2aa79a52082db16eff44c89ab30938838dd8
Reviewed-on: https://gerrit.libreoffice.org/80935
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I022f64188e49553bd7bef38cdd51620dfa0b90cd
Reviewed-on: https://gerrit.libreoffice.org/80883
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Since that variable holds the relevant includes, using
'gb_LinkTarget_set_include' makes sure that those
flags end up in the correct section, e.g. when generating
IDE integration using 'gbuild-to-ide'.
E.g. for the 'qtcreator-ide-integraton' make target, this
makes sure that they end up in the 'INCLUDES' section in
'sd/sd.pro' and not the 'DEFINES' section, which previously
led to an "error: macro name must be an identifier" being
shown when editing files underneath 'sd/' in Qt Creator with
the Clang Code Model plugin enabled, s.a. commit
4aa60490622cc10f8d3a31489c62a5622d240c83
("gbuild: treat $({QT,KF}5_CFLAGS) as cxxflags, not defines").
Corresponding entry in my config_host.mk.in on Debian
bullseye/testing:
export DBUS_GLIB_CFLAGS=$(gb_SPACE)-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
Change-Id: I9af9a58fdc05ce6648221c00a20859be777843f9
Reviewed-on: https://gerrit.libreoffice.org/80944
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Valgrind'ing CppunitTest_sc_filters_test failed with
> Conditional jump or move depends on uninitialised value(s)
> at 0x21175CE0: XclRange::GetColCount() const (/sc/source/filter/inc/xladdress.hxx:73)
> by 0x2117048D: ImportExcel::ReadDimensions() (/sc/source/filter/excel/impop.cxx:248)
> by 0x21188E78: ImportExcel8::Read() (/sc/source/filter/excel/read.cxx:1108)
> by 0x21123C3F: ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, ScDocument*, EXCIMPFORMAT) (/sc/source/filter/excel/excel.cxx:137)
[...]
when loading sc/qa/unit/data/xls/pass/CVE-2006-3086-1.xls.
As there appears to be no error-handling concept in ImportExcel::ReadDimensions,
at least zero-initialize the relevant variables.
Change-Id: I11dbd2a1032ecc723f65a563ef022d7eb3c970ff
Reviewed-on: https://gerrit.libreoffice.org/80948
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Flathub arm builds (but not other arches) had often (but not always) failed when
processing sc/qa/unit/data/qpro/pass/ofz14090-1.wb2 in
CppunitTest_sc_filters_test (e.g.,
<https://flathub.org/builds/#/builders/1/builds/724>:
> Test name: ScFiltersTest::testCVEs
> equality assertion failed
> - Expected: 1
> - Actual : 0
> - file:///run/build/libreoffice/sc/qa/unit/data/qpro/pass/ofz14090-1.wb2
) Valgrind revealed that this was due to using unintialized memory when the
various maIn.Read... in QProToSc::Convert failed, starting with the use of
uninitialized nFmla[i] after
maIn.ReadUChar( nFmla[i] );
At least make things deterministic by setting the relevant variables to zero.
(Another approach could be returning early with some ConvErr status.)
Change-Id: I4c06aa8da5f777170cdc7bbe3ca1d61b23d3f326
Reviewed-on: https://gerrit.libreoffice.org/80947
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
The code to create these "linked files" added by:
commit 6f2f7e3091504e8e58d9be603ed3739f6f2cd68e
Author: Mathias Bauer <mba@openoffice.org>
Date: Fri Jul 6 14:03:59 2001 +0000
#89377#: new StorageMode for creating unpacked files
use of creating them then introduced in:
commit 53fe2691a3fb65110e7f5aee2919f7d8d559ff02
Author: Mathias Bauer <mba@openoffice.org>
Date: Fri Jul 6 13:55:57 2001 +0000
#88062#: some optimizations
that use then commented out in:
commit 762dd2b15bfd201b2271b460efa72a5b68d6fb2a
Author: Kurt Zenker <kz@openoffice.org>
Date: Mon Oct 4 19:53:11 2004 +0000
and the unused code to create them removed in:
commit 8a91528a3e03fe6e2923c33327b687ecf57adb0b
Author: Stephan Bergmann <sbergman@redhat.com>
Date: Thu May 7 10:37:27 2015 +0200
StorageMode::CreateUnpacked is never used
It seems to me that there is no need to keep support for reading them as they
seem to have been temporary files rather than something still existant
Change-Id: I783cae63dc078a7e843729d3ca13f45c18168f4c
Reviewed-on: https://gerrit.libreoffice.org/80943
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5aafb53bb9885b8b0b43161f1afc79852b1d89a3
Reviewed-on: https://gerrit.libreoffice.org/80767
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6c8f11e1e2b4192933541e754a078c4d0ff58206
Reviewed-on: https://gerrit.libreoffice.org/80938
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0276d79cd713357d36d504e8501cd1b979e86c9c
Reviewed-on: https://gerrit.libreoffice.org/80766
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
notably the csv control is always LTR even in RTL mode, but the surrounding
ScrollingWindow follows the environment direction, except the horizontal
scrolling widget itself must LTR scroll.
Change-Id: I72ee2b9dade73a11bcc4391e755fdb02886a884d
Reviewed-on: https://gerrit.libreoffice.org/80765
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Width request set to 350
Change-Id: Ib974417282c76b4cede1b4773159b1fa748ddbfb
Reviewed-on: https://gerrit.libreoffice.org/80887
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Commit 5926b22b5dc33490d23d594b129eb8a70b94ffb0
("The SystemEnvData passed into the canvas factories appears to
be unused") removed previous arg at index 1, so adapt here, too.
This makes the presenter console shown again (tdf#128166).
A visible result of FullScreenPane::CreateCanvas passing wrong
args was that an Impress presentation shown in presentation mode
in dual screen using the qt5/kf5 VCL plugin wouldn't terminate
properly and crash Impress on close.
Change-Id: I3933864d4bb007cfdefb0a20378ff3d75ea6cd85
Reviewed-on: https://gerrit.libreoffice.org/80933
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I96114470d6151392e42e6938d92d4175022dbbe2
Reviewed-on: https://gerrit.libreoffice.org/80931
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I7752c281b1b6dd0d26bd7d6c4a6896c663f4cbc3
Reviewed-on: https://gerrit.libreoffice.org/80921
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Replace them with default initialization or calloc
Change-Id: I747f53c2ced2d0473fd5a5ede4f8520a0633dcc1
Reviewed-on: https://gerrit.libreoffice.org/80805
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...that had been missing because the plugin didn't implement postRun, so it
didn't report anything when run as part of the shared plugin. (But did report
the expected warnings when run as a standalone plugin during
CompilerTest_compilerplugins_clang.)
Most fixes are straightforward. A noteworthy one is PreparedStatement::setBytes
in connectivity/source/drivers/postgresql/pq_preparedstatement.cxx: The old
preallocation of a 20 character OStringBuffer might have prevented
buf.append( reinterpret_cast<char *>(escapedString), len -1 );
from potentially throwing std::bad_alloc, which would have caused escapedString
to be leaked. Even though that 20-character preallocation was likely just
random junk and not meant to address the potential leak, lets address it now.
Change-Id: Ib506332d061684a22a74e5e39e591539fd2c4900
Reviewed-on: https://gerrit.libreoffice.org/80925
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Which is now exactly the same as PROP_FOLLOW_TEXT_FLOW, so no need to
set it separately.
Change-Id: I32e1e2bdfb8ac46eb6a07f5187f780275d334b2f
Reviewed-on: https://gerrit.libreoffice.org/80926
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Icc19b6e3493f1d9e49584c3e2ac99509fae4e02e
Reviewed-on: https://gerrit.libreoffice.org/80923
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
if in cpu-threaded mode so that we can avoid the unnecessary
locked SvNumberFormatter::GetType() calls (Mapping between NF index
and NF-type does not change while formula-group-threading
is running).
Change-Id: I648bc08c885da845f0b09cd57013cc1c23e01a61
Reviewed-on: https://gerrit.libreoffice.org/80848
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
|
|
and compile it with -arch:SSE2 if Windows.
This code however gets called only if cpuid::hasSSE2()
is true, so this does not cause problems with machines
without SSE2 support.
Change-Id: Ice23ac71d4c577b8811b08c74a3ca500a94fdc09
Reviewed-on: https://gerrit.libreoffice.org/80847
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Idf10bb214d6d82370512eeb39ba7786dd9bceb38
Reviewed-on: https://gerrit.libreoffice.org/80846
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
and reuse them for interpret'ing all cells under the
respective threads. This gives a sizeable win in the execution
time especially for long formula-groups.
Change-Id: Ib340950f21e863b5b821d20c092214d8bc5012aa
Reviewed-on: https://gerrit.libreoffice.org/80845
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
...ever since 8f55fe4c6c73f110b1c72903c209399ff2527ea5 "INTEGRATION: CWS help2"
dropped p->application and "/" from strBuff.
Change-Id: I48aa9271daac4caf23d932741a5c75cb00ad7ee9
Reviewed-on: https://gerrit.libreoffice.org/80924
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It started out as a wrapper around character literals, but has by now become a
wrapper around arbitrary single characters. Besides updating the documentation,
this change is a mechanical
for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done
Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f
Reviewed-on: https://gerrit.libreoffice.org/80892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Followup for LO 5.4 commit 6f2ad89b33d972f9642bb53eeb91f41df3b6b0e6
which set Calibri/11pt as default. That is true if there is
no style.xml file, or more specifically if there is no
DocDefaults rPrDefault node. But if that node exists, then
the age-old defaults are still valid.
Earlier in LO 4.3, the default templates changed to use
Liberation fonts by default. But in the same vein as using Calibri
(and depending on LO to fallback to Carlito), set Word's default
Times New Roman font and depend on LO to fallback to Liberation.
That will make it better for MSWord users who share the document
and who have less likelihood of knowing about Liberation/Carlito.
Note that 10pt fontsize was already added to m_pDefaultCharProps
earlier, so that part was already reset long ago.
Change-Id: I3ba8a529fe95b05fbe2889cf1ebdbabb25963e8b
Reviewed-on: https://gerrit.libreoffice.org/80854
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
Change-Id: I8eb9a77c7e6b9242f18ac5f0634091c88bf40ec0
Reviewed-on: https://gerrit.libreoffice.org/80695
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
* Update translations from branch 'master'
- Updated Slovenian translation
Change-Id: I7a5c6bd9fc6ac769251aca007b01ad24e11dfd61
|
|
Change-Id: I71e8377bf44c2db5ef291d2990528ec16aaf3b44
Reviewed-on: https://gerrit.libreoffice.org/80909
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: Ide54e4755624d515aeeacf62591dc59aea667dcf
Reviewed-on: https://gerrit.libreoffice.org/80879
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I81052f7634c7873d893d67deb79ed7bfa6dcbc44
Reviewed-on: https://gerrit.libreoffice.org/80888
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I5864e5d3132b309d5500c02a8493062abcb25aab
Reviewed-on: https://gerrit.libreoffice.org/80886
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I55fdf178bbd185d8852da13757aca627d93526bb
Reviewed-on: https://gerrit.libreoffice.org/80911
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
because this is the default value of table cells.
Change-Id: I4f45f32f24474f4d9c6bbc91fcd62cb66f008e5d
Reviewed-on: https://gerrit.libreoffice.org/80601
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
As of now, "PRINTER" doesn't support bCreateSingleFile=false any more,
s. https://gerrit.libreoffice.org/#/c/80884/ which already updates
the README.
Change-Id: Ifcff238c3f497afd84279a485f324f0978c4e884
Reviewed-on: https://gerrit.libreoffice.org/80885
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
The combination "PRINTER+false" is not supported, i.e. it's
currently not supported to generate individual print jobs for
a subset of data records instead of one job per mail merge run.
The possibility to do so had been added by commit
138d29aa09417eba4d15ade4c9f4dab2620b6326
("support fast MM printing in non-single-file mode only for CUPS"),
but was removed again by commit dea0abc58c558d3c62e806d06035b1a30420264e
("tdf#93236 Revert "support fast MM printing in...") and
commit b6a698b093f78dc90836d502db3d0276f335fbfe
("tdf#95251 MM just allow print as single document"), so
update the README accordingly.
Change-Id: I83afc1949915434c95bdcb58e1d09dc2c900c500
Reviewed-on: https://gerrit.libreoffice.org/80884
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I4eaf798b1b43fe8a78d1697d9ebc207ff8ace492
|
|
This extends the filter comparison from commit c3a1c83ff5af
("tdf#42316 preserve macro signature of templates").
The original patch just stripped "_template" from the source
filter to find equal document types, which just enables the
"template => document" case. This patch also strips the
"_template" from the target filter, which fixes the "document
or template => template" cases.
This also extends the signing save tests:
* OTT 1.2 => OTT 1.2 - preserve
* ODT 1.2 => OTT 1.2 - preserve
* OTT 1.0 => OTT 1.0 - preserve
* ODT 1.0 => OTT 1.0 - preserve
* OTT 1.0 => OTT 1.2 - drop
Change-Id: Ie297258a4d9f9aa4beb25786c6ba240b6f16f49b
Reviewed-on: https://gerrit.libreoffice.org/80654
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Ieb44fb356966df0eb92141a5f22f1df13683f6fc
Reviewed-on: https://gerrit.libreoffice.org/80694
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
Change-Id: Iad8d37c5d0f9fa10bad426ce2b1fb7e760b2e1fd
Reviewed-on: https://gerrit.libreoffice.org/80865
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Now change tracking protection from Writer or from ODT files
is exported to DOCX.
In Writer it's always possible to disable change tracking
protection without password in File->Properties->Security page->
Record Changes after confirmation.
Now Writer uses the same confirmation to remove change
tracking protection imported from DOCX, for example clicking
on Record Track Changes. Disabled protection removes the
export of the grab-bagged change tracking protection, too,
to avoid of creating bad DOCX with enabled change tracking
protection and disabled Record change tracking.
See also commit d416250f4f1766e2d596ea3feef6a94b7adf29f4
"tdf#106843 DOCX: forbid disabling protected Record Changes"
Change-Id: Ida4d72c57dbe5450ea22028bbed69d413f5a786d
Reviewed-on: https://gerrit.libreoffice.org/80784
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
and extend O*StringView to have a constructor that takes a pointer and a
length
Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8
Reviewed-on: https://gerrit.libreoffice.org/80872
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I75644c526e401ce0bc9a46a66d3d31e90bafb1d6
Reviewed-on: https://gerrit.libreoffice.org/80874
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
w:framePr of page header doesn't mean real frame conversion,
so don't store and lose redlines after it.
Regression from commit e8bae67b3dbcc90ace8264b6b1aefaf0ce459aba
"tdf#125894: DOCX: import tracked changes in frames".
Change-Id: I46cd153cccef4824deca1f64341f2ea6672cdc42
Reviewed-on: https://gerrit.libreoffice.org/80871
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
We want debug builds there, but the debugging symbols for debugger
themselves are not actually needed (Linux builds use the debug symbols
for printing backtraces when a unittest crashes, but Win/Mac do not).
This should save generating the needless debug info (CPU and I/O).
Change-Id: I3fc8bdb66e4822838216359b23b8a2dd5f2a0f42
Reviewed-on: https://gerrit.libreoffice.org/80732
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
They always start with 'make clean' (at least according to the logs),
so they are always one-time builds where creating dependencies
is not needed.
Change-Id: If402fbaa21bd213e3f781985479dd49c266ca511
Reviewed-on: https://gerrit.libreoffice.org/80730
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I6687d462de7e21e770220cc1e804a28231b9e38d
Reviewed-on: https://gerrit.libreoffice.org/80866
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Ifa4589fb50affc4c5ffb52288db8533c98ec6dd9
Reviewed-on: https://gerrit.libreoffice.org/80587
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
|