summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I71bfb6628bb746498ff47d6d9aba50e150757144
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I76cc14b7de4ad2aeda9145a0dd01a6bdfafca0a6
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I39285a4eb7f205cc89cd2aa4e48ccbfc9ccfd83e
2015-02-07loplugin:deletedspecial to help add SAL_DELETED_FUNCTION annotationsStephan Bergmann
...to special member function declarations that were left undefined. Helps compilers do a better job at identifiying unused class members. This plugin uses heuristics and whitelists do identify applicable declarations, but is not appropriate for "unattended" use so is placed into store/. The following commits contain the results of running this plugin, per module: * Declarations of undefined special member functions are mmarked SAL_DELETED_FUNCTION (aka "= delete", which is deemed superior to deriving the class from boost::noncopyable, cf. Howard Hinnant's reply to <http://stackoverflow.com/questions/7823990/what-are-the-advantages-of-boostnoncopyable>. * Any redundant "explicit" or SAL_DLLPRIVATE markers are removed from the deleted definitions. * Some redundant declarations of undefined default ctors are simply removed; smelled like clueless cargo-cult to have them declared at all. * Some declarations of undefined operator == etc. are left in (and marked SAL_DELETED_FUNCTION) for now, to be on the safe side, though they are likely clueless cargo-cult, too. * Most "static-only" classes are replaced with namespaces (and some where that would be non-trivial due to private members are marked TODO for later). * Newly identified unused class members are removed. Change-Id: Ibeaae4fd579d7a0971a2c2a654a2263acd13414a
2015-02-07tdf#88836: UI: in-form navigation bar icons goneZolnai Tamás
Regression from: 6419c745e5e9802da264250d5e131fb9a3b6e4de Revert it and use IsEmpty() instead of operator!(). Change-Id: Icc4f5dbba848a1d4ef807e598f0aa3b940459c82
2015-02-07filter: try to fix GCC 4.6 buildMichael Stahl
Change-Id: I3fa777b2f2d155bbd8bebf58211446eb1fa458f6
2015-02-07Fixup --without-x buildRiccardo Magliocchetti
Accept gl linkage in hope of future offscreen mesa support. Avoid linking with GLX though. Change-Id: I4e666f60e74fe34075a8da9eeba95807cf8fe38c Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/13452 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-02-07fdo#43368 Remove MapiLogon/Logoff calls so simplemail works with WLMAron Budea
Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: shell/source/win32/simplemail/senddoc.cxx Change-Id: I31cac063ffb4afbfde068558ebcf5f66ea34d1a8
2015-02-06fdo#87675: Disable 'edit' when next style is same as current one.Heena Gupta
Change-Id: Ifd149890460c44dc3eececc06a36f1b76d46929b Reviewed-on: https://gerrit.libreoffice.org/13811 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-06fdo#87675-"Edit" Button for next style in edit paragraph styleHeena Gupta
Change-Id: I1a4888b869df7f242244bed2fef36996450eec23 Reviewed-on: https://gerrit.libreoffice.org/13639 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-02-06Resolves: tdf#83461 do not override MatColsRows if already setEike Rathke
ScMatrixFormulaCellToken::SetMatColsRows() via ScFormulaCell::SetMatColsRows() is used during document import and preselected cell area input of an array formula. Do not override existing values with subsequent result matrix dimensions. Change-Id: I9e844b5064ea276f3cbcb680eb1127c344328e00
2015-02-06Simplify CSS1Expression::GetColor for CSS1_RGB caseMatteo Casalin
Relies on toInt32 features: * Skip control characters at the beginning of the token * Stop conversion at first non-digit character Also avoid conversion of negative values to 255, due to downcast to unsigned 16-bits value Change-Id: I2029e35dd779220bd3fb74d5173b1482b571f76c Reviewed-on: https://gerrit.libreoffice.org/13730 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-06fdo#39440: remove redundant checks and breaksJuan Picca
Change-Id: I7706aca6b3850b9d9c8d6d9a78e0034889c6f89c
2015-02-06Tidy up HC icons.Andrew
Remove and fix stray Hicontrast (HC) icons. - Remove old HC icons from Human, Oxygen & Tango themes. (They should only exist in specific HC theme). - Move few icons misplaced in Galaxy to correct HC theme. - Fix HC filename: lch_autopilotmenu > lc_autopilotmenu. Change-Id: I12b9729888ff7927f9c8f31d1d66d178ef39150b Signed-off-by: Andrew <dent.ace@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/14352 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-02-06Extract SwNumRuleTbl::dumpAsXml() from docnodeMiklos Vajna
Change-Id: I39cbff3fbd21c6d0640a0fa1298c5df720525405
2015-02-06tdf#76291 unit test for html export href encodingVasily Melenchuk
Change-Id: I273af8b570adfcb7bfb784495bc31d2f4f1ee00b Reviewed-on: https://gerrit.libreoffice.org/14333 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-06Make OUStringLiteral more usefulStephan Bergmann
...don't dare make it non-explicit, yet. Along the way, introduce SAL_CONSTEXPR. Change-Id: Ia3179d0d5e001fd7aa92237c97437e9b74366ee1
2015-02-06fix windows buildCaolán McNamara
Change-Id: I62a038d99107b30da302acee7b68e802fe5d9622
2015-02-06fix mac buildCaolán McNamara
Change-Id: Ic98ada6d0bca124194cea24a1ed30d30a1c0a85e
2015-02-06coverity#1267635 Logically dead codeCaolán McNamara
Change-Id: If2f26bd6414622889fc15d3806851e497882558c
2015-02-06coverity#1267636 Logically dead codeCaolán McNamara
Change-Id: I3bd06dee1a5536552f79d9eddf5c7059723cba2e
2015-02-06coverity#1267644 Logically dead codeCaolán McNamara
Change-Id: Ida19552cd9163507bea36a189811fdf8c152cae6
2015-02-06coverity#1267642 Logically dead codeCaolán McNamara
reviewed the 120+ callers and confirmed it is never NULL Change-Id: I5c029dc35b265d9e11a0a222170dad4d6a55ed2f
2015-02-06shared_ptr<T>(new T(args)) -> make_shared<T>(args)Caolán McNamara
and boost:make_shared->std::make_shared Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-02-06O[U]StringBuffer::appendUninitialized unit testsStephan Bergmann
Change-Id: I55f0a5bd01a3e250764e1eb34d674b535b85b56f
2015-02-06sal: add back the append / insert assertions that were...Michael Stahl
...removed in 2c03d6fb053319e61ed600a3c22c4fd39da84e4d. Change-Id: I09194c55ac574bbc0f3065360b329fab8f0ba10c
2015-02-06static const to avoid re-init all the time + c++11.Jan Holesovsky
Change-Id: I24ac6405f03e2d55f832d1ffe0c71e575883c5c8
2015-02-06bnc#637947 improve DrawingML export of custom shapesAndras Timar
Change-Id: Iaa880528cf3c899ce66e4349c6d989dfbe5cbeb6 Reviewed-on: https://gerrit.libreoffice.org/14346 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-06Remove bogus assertsStephan Bergmann
...regression introduced with b0ef5cf258f3a84054c052f0a09a208dbc17fdf3 "sal: add some argument checking assertions for strings and buffers" not being aware of 186990395d72a803dd4a9f087fe4e05f49e69ad2 "Clean up Mac _imp_getProcessLocale: Introduces OUStringBuffer::appendUninitialized." Change-Id: I828d98eb52f57f4e39e71ded39ef034e1788f4d1
2015-02-06tdf#87309: SVG - use black as default currentColor if no color was specifiedChr. Rossmanith
improves import of attachment https://bugs.documentfoundation.org/attachment.cgi?id=110836 from issue 62284 Change-Id: Icb056774746ce270138a54e9dfe9ca6987a64769 Reviewed-on: https://gerrit.libreoffice.org/14242 Reviewed-by: Katarina Behrens <bubli@bubli.org> Tested-by: Katarina Behrens <bubli@bubli.org>
2015-02-06Report errors from clRelease*() APIsTor Lillqvist
Change-Id: Id30afe5bf954e26515bf8cca6f1ee8bc018fb835
2015-02-06Unmap the host buffer only after done accessing itTor Lillqvist
Most likely 64c479e9da02f724e1870649c99fac92f5f27cd3 accidentally made the code unmap the host buffer before it is accessed, but the code continued to work by accident in many (most?) cases. Either because in the case of OpenCL devices that share memory with the CPU, the host buffer *is* the OpenCL buffer, so even if the host buffer is "unmapped", it still exists. In the case of GPU device with separate memory, using the host buffer after unmapping corresponds simply to a case of use after free of a heap-allocated buffer, which often happens to work. Found by code reading. Change-Id: I9e2b4574077a267938702c0f81c4b1cba9c9a183
2015-02-06Improve OpenCL error messagesTor Lillqvist
Add the name of the function that failed to the OpenCLError class. Log OpenCL failure in a couple of more places (where OpenCLError is not thrown). Print OpenCL errors symbolically instead of numerically where applicable. Change-Id: I60f910e9ea7b75af7ec506553d7a73ad99ba4366
2015-02-06Move OpenCLError::strerror() from sc to opencl, and rename to errorString()Tor Lillqvist
There is nothing Calc-specific in this function, and surely it will be good to output OpenCL errors symbolically also in the opencl module. Change-Id: Ibe7d0d036f24dd87e06b8290224e1033dda0f3d1
2015-02-06The ISNAN ifdefs can go awayTor Lillqvist
ISNAN was defined unconditionally since long, and even the original authors of this stuff started removing those conditionals last summer. for F in `git grep -l ISNAN sc`; do unifdef -DISNAN -B -o $F $F; done Change-Id: I61df4066d0ecc23b6ce26bac8f3fbdfaf4aceac4
2015-02-06propagate user-set CFLAGS to buildDavid Tardon
Change-Id: I6c9d8ff064f059e4a756593ff5c45b9670cacb29
2015-02-05try to avoid overflows in some compare functionsMichael Stahl
Change-Id: I6144d7d6527dc401b7f1b577d1a227361e39e7bb
2015-02-05sal: add some argument checking assertions for strings and buffersMichael Stahl
Also remove some now redundant asserts from headers. Some of these actually trigger on unit tests so are commented out. Change-Id: I07c6b2b2bd175361691a141f22eec584e3ab8f0b
2015-02-05Resolves tdf#89129: crash when defining a specific relationshipJulien Nabet
Returns early if comparison matches so you can reduce iterator scope and avoid last test for logging. /usr/include/c++/4.9/debug/safe_iterator.h:168:error: attempt to copy- construct an iterator from a singular iterator. Objects involved in the operation: iterator "this" @ 0x0x7fffffff3a30 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = past-the-end; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } iterator "other" @ 0x0x7fffffff3a90 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = singular; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } 4 0x00002aaab193d6e9 in boost::void_ptr_iterator<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem>::base (this=0x7fffffff3a90) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:121 5 0x00002aaab193d269 in boost::operator==<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem> (l=..., r=...) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:179 6 0x00002aaab193c2ca in ButtonDialog::RemoveButton (this=0x7fffffff3d90, nId=1) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/btndlg.cxx:340 7 0x00002aaad8ed109b in dbaui::ORelationTableView::lookForUiActivities (this=0x317ef30) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/relationdesign/RelationTableView.cxx:342 Change-Id: Ied45c222c94d2a362075a3b1550b6092aad77c62 Reviewed-on: https://gerrit.libreoffice.org/14325 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05Related tdf#87356: import data bar [non-]gradient from OOXMLKatarina Behrens
Strange, I somehow believed this already works not only for ODF but also for OOXML. Wasn't the case Change-Id: I5e06fd7bccbe2e59b13f9f56188374193b10a009
2015-02-05Revert "ODF export: don't write invalid "group-name" attribute"Lionel Elie Mamane
This reverts commit 2d4b87f0c1bfd97185a89c18d5b7680d11a958d6. The reverted commit leads to the following regressions: - Basic dialogs (which were not targeted, but impacted, by the reverted commit) with several RadioButtons sharing a group-name (as they will have a tendency to do) cannot be loaded anymore, since the implementation assumes (and checks) that names are unique. - Even in forms, where a RadioButton had both a form:name and a form:group-name attribute, the form:name attribute wins and thus RadioButtons that has the same group-name but different form:name (as they will tend to do) will not anymore be mutually exclusive, which defeats their point. Additionally, since it did not change the UI parts (property editor window), the user was still presented with two different editable properties "Name" and "Group Name", where "Group Name" was empty... Change-Id: I1bff532a5a7336cf2eb0579bcd4e2d16be6480fe
2015-02-05Revert "xmloff: dead code gives MSVC fits"Lionel Elie Mamane
This reverts commit 29e1b2f1ca6e2dcbf9a04c63a3ac1d554cfdcb52 in preparation for reverting 2d4b87f0c1bfd97185a89c18d5b7680d11a958d6
2015-02-05constifyLionel Elie Mamane
Change-Id: Id319c001b399a3105d6c9f87a58168f956ad46c3
2015-02-05proper indentationLionel Elie Mamane
Change-Id: Ifc7577f46625562183ed3ee2273f28b9dcfc13df
2015-02-05destructors are not allowed to throwLionel Elie Mamane
so move potentially throwing call to a manually called finish() additionally don't make it leak something that is not a RuntimeException, the caller does not expect it. Change-Id: I8b19585ae197f5ac8625dc85d4c4860a1c11b262
2015-02-05tdf#89070 Table filter dialog: properly initialise OTableTreeListBoxLionel Elie Mamane
regression from .ui conversion: commit 5c72a213c7c4b588d0c1e0884ff2c46c22425faf Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jan 21 14:41:16 2014 +0000 convert table filter page to .ui Change-Id: I7bfb7698e2a5303b492766fba564c7b9033bcc52 Change-Id: Ic7d41d64d4c15eabf7b7f83a17482c473154434a
2015-02-05BOOST_STATIC_ASSERT->static_assert and drop some includesCaolán McNamara
Change-Id: I74955a05bf13f7b33650d11c5cf4b1388382da2a
2015-02-05push this windows build along a bit furtherCaolán McNamara
Change-Id: Id22ba872865bd8136c65c73152097805e696a695
generated by cgit (git 2.34.1) at 2025-02-13 13:16:30 +0000