summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-06-09clang-tidy readability-non-const-parameterNoel Grandin
Change-Id: I7b2680898dbfc49185fb949349d81f4ac615a470 Reviewed-on: https://gerrit.libreoffice.org/38593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-09use comphelper::InitPropertySequence in more placesNoel Grandin
Change-Id: I72d7b13a23ce306b752b39187a0e9fbb7028643a Reviewed-on: https://gerrit.libreoffice.org/38606 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-09Add unit test for SUMIFS in array contextEike Rathke
Change-Id: I5318ab8bb4d896f3c936ec8d04eba3908b59861a
2017-06-09UnoControls: replace double checked locking patternsJochen Nitschke
with thread safe local statics Change-Id: I6ba88ffc3b3489bfe4dce17c4297312dd9765f2e Reviewed-on: https://gerrit.libreoffice.org/38594 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-09missing STR_SAVEACOPY_SRC resourceCaolán McNamara
since initial commit 7061e8403a3afddae253ad0a016e5613616030bb Date: Wed Apr 3 21:05:12 2013 +0200 fdo#60780, refactor Save a Copy and fix Change-Id: Iff4f1008b8f8682e6f9751141ed65720362563ad Reviewed-on: https://gerrit.libreoffice.org/38601 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-09tdf#39468 translate german comments in sw/* (except source/filter)Bernhard Widl
Change-Id: I51126f690b5b66d171e19b82fa4ff24ff5930203 Reviewed-on: https://gerrit.libreoffice.org/38598 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-09Add --script-cat parameter to dump scripts content.Michael Meeks
Also factor out over-long print method into its own helper. Change-Id: Ica98dc9c999d5655e78662774e0140d70369d0b7 Reviewed-on: https://gerrit.libreoffice.org/38579 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-09VML: EMU to Points conversionSzymon Kłos
Change-Id: Icd2dbd6e894975615268dc4aa52d1d53bf9c0bca Reviewed-on: https://gerrit.libreoffice.org/38581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-09Avoid overflow in subtractionStephan Bergmann
Change-Id: Ib92239fd9b347efbeeeef9661a1a9180445e7739
2017-06-09missing STR_TBL_FORMULA resourceCaolán McNamara
since commit c3a98155ed28bd77eff4de3d80ccbcde1e68c828 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Oct 11 16:33:17 2016 +0100 de-src writer formula toolbar Change-Id: I7ab31f19d36102978ac2535da03ed15c14ce5f47 Reviewed-on: https://gerrit.libreoffice.org/38573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-09Avoid UBSan warning about negative double -> sal_uInt32 conversionStephan Bergmann
Since ea890b1d4bcd6dd59db9f52dce1609c020804e24 "tdf#108408: support unit specifications for ST_HpsMeasure", the OOXMLUniversalMeasureValue ctor is converting textual data to mnValue via intermediary double instead of sal_Int32, so textual data representing negative values now triggers UBSan warnings (e.g., "writerfilter/source/ooxml/OOXMLPropertySet.cxx:630:43: runtime error: -70 is outside the range of representable values of type 'unsigned int'" during CppunitTest_chart2_export; it appears that, while HpsMeasure may be documented to only cover positive values, TwipsMeasure may be negative). But OOXMLUniversalMeasureValue::mnValue is apparently only used in OOXMLUniversalMeasureValue::getInt, to return an int value, so just change its type. Change-Id: I44eabb78f09100c05cc9d1e79a739648f34ea743
2017-06-09external: drop mingw bits from ExternalPackage_xmlsecMiklos Vajna
Change-Id: Icd0526c0bf0183b80bc4c098e3307574b8b8bb8b Reviewed-on: https://gerrit.libreoffice.org/38592 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-09tdf#108408: support unit specifications for ST_HpsMeasureMike Kaganski
w:ST_HpsMeasure is defined in ECMA-376 5th ed. Part 1, 17.18.42 as This simple type specifies that its contents contain either: * A positive whole number, whose contents consist of a measurement in half-points (equivalent to 1/144th of an inch), or * A positive decimal number immediately followed by a unit identifier. ... This simple type is a union of the following types: * The ST_PositiveUniversalMeasure simple type (§22.9.2.12). * The ST_UnsignedDecimalNumber simple type (§22.9.2.16). This patch generalizes OOXMLUniversalMeasureValue to handle standard- defined units, and introduces two typedefed specifications: OOXMLTwipsMeasureValue (which is used where UniversalMeasure was previously used), and new OOXMLHpsMeasureValue. Unit test included. Change-Id: Iccc6d46f717cb618381baf89dfd3e4bbb844b4af Reviewed-on: https://gerrit.libreoffice.org/38562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-09tdf#82173 writerfilter: apply char properties to footnoteJustin Luth
The char property values as defined in w:rPr were not connected to the in-text footnote or endnote. Change-Id: I7729c534879e59ff5c9500dd1b16f9f1476abd76 Reviewed-on: https://gerrit.libreoffice.org/38372 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2017-06-09Too many aRes..., rename aResArray to vConditionsEike Rathke
Change-Id: Ic514a4fe34b2f9658bae61ecb4cc5c3c8361669b
2017-06-08tdf#107700 Translate some less common font style namesGabor Kelemen
These are used in at least on of the free fonts we bundle. Also translate a stray German comment :) Change-Id: I3f4d83001bcfc3a8b3d490e56d9e538a8d892f0c Reviewed-on: https://gerrit.libreoffice.org/38476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-08tdf#107087: Select bitmap fill from preset listKatarina Behrens
Also remove member variable that is used just once Change-Id: I369299aed75a3b44048aa09ba86b79e552cf6d14 Reviewed-on: https://gerrit.libreoffice.org/38551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-08Typo: F9 should be mapped with KEY_F9Julien Nabet
Like this since mapping added: https://cgit.freedesktop.org/libreoffice/core/commit/?id=75fbed472cd689c8cc0b89e13a97969d77a0ea7c (2012-03-05) Change-Id: I8243080257c7a116207293426c2a8b840324859b Reviewed-on: https://gerrit.libreoffice.org/38582 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-08tdf#39468 Translate German comments/terms in sw/source/filter/html/swhtml.cxxJens Carl
Eighth set of translation. Change-Id: I3073ba38fac7d05d4cff4ddc43c08463ed8f76da Reviewed-on: https://gerrit.libreoffice.org/38560 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-08With reference lists there can be more than 255 queriesEike Rathke
Change-Id: Ia5dc32fbcd8ad738d5ec0f20cc233b58fcadc882
2017-06-08Add '~' reference union/list operator to range finder delimitersEike Rathke
... so formula expressions using it actually get the ranges highlighted. Change-Id: Ibb0d2b49101e62b1f219a14d1669a501a450aaf4
2017-06-08Remove a TODO and explainEike Rathke
Change-Id: Ic648fd2b0a1424aa5ae5d924b29dfd2cb8dddbf9
2017-06-08EditEngine: Added ODF_TEXT_FLAT copy/paste for sdVarun Dhall
Change-Id: I23777477d31f30ee18ee8926a8f3170505f74264 Reviewed-on: https://gerrit.libreoffice.org/38535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-08EditEngine: Added ODF_TEXT_FLAT paste for scVarun Dhall
Change-Id: I40acd32229faa9a4ec9941592a4a952b7d05ef01 Reviewed-on: https://gerrit.libreoffice.org/38464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-08Take FormulaTokenArrayPlainIterator into use in one more placeTor Lillqvist
Change-Id: If81494b9279d3c1f2c3887097f1b0036c18cab78
2017-06-08Take FormulaTokenArrayPlainIterator into use in one more fileTor Lillqvist
Change-Id: I94b8054cc978c04ae994380ea0c564a4b16de26d
2017-06-08Take FormulaTokenArrayPlainIterator into use in one more placeTor Lillqvist
Change-Id: I70e3bd1129da76e11b5f71b1b56d79898eb3d5be
2017-06-08Take FormulaTokenArrayPlainIterator into use in one more fileTor Lillqvist
Change-Id: Ib7f9b3961a3885be8c39ec5a20e7f383ecc9cc37
2017-06-08Forgot FormulaTokenArrayPlainIterator::GetNextName()Tor Lillqvist
Change-Id: I3a485518be1372c9c56137c35cefdbc8d0362fe4
2017-06-08Keep WID ranges sorted, and join adjacent onesStephan Bergmann
...to stop CppunitTest_sd_dialogs_test failing with > cppunittester: /data/sbergman/lo-san/core/svl/source/items/itemset.cxx:678: void SfxItemSet::MergeRange(sal_uInt16, sal_uInt16): Assertion `!pRange[2] || (pRange[2] - pRange[1]) > 1' failed. (and whyever that only started to hit now) Change-Id: Iadb5538b8b10182ddf5dbe02d34d7c73c7d62a14
2017-06-08DbgCheckItemSet is goneStephan Bergmann
...since 87c9465262680dec09efb869800859aa65ab1d19 "Bin unused function DbgCheckItemSet" Change-Id: I109598dc5e087697d77b96a0ba2fb178d47b3aa6
2017-06-08Redundant nColSize,nRowSize, use nDimensionCols,nDimensionRows, tdf#58874 prepEike Rathke
We guarantee that all references are of same size. Change-Id: I61888a257691f902cb958741f6b63779d9744e10
2017-06-08tdf#81475 Add separator before clone formatting buttonYousuf Philips
Also add some useful hidden commands for easy access for users to enable Change-Id: I28806047f2fac51995d88b7c204d54479471aa29 Reviewed-on: https://gerrit.libreoffice.org/38552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-06-08Cater for UNO (signed) vs. BASIC (unsigned) byte mismatchStephan Bergmann
See <https://listarchives.libreoffice.org/global/users/msg51243.html> "[libreoffice-users] type byte in Basic", where > Sub Main > dim oOutputStream as variant > oOutputStream = createUnoService("com.sun.star.io.SequenceOutputStream") > dim nA as byte > nA = 195 > oOutputStream.writeBytes(array(nA)) > oOutputStream.flush > dim back(0) as byte > back = oOutputStream.getWrittenBytes > MsgBox(back(0)) > End Sub failed with "Inadmissible value or data type. Overflow." instead of showing "-61". Change-Id: I0445476c67510d5f8669a6e711e92332c01ec06c
2017-06-08tdf#105566: Account for 'signature used to be ok but isn't anymore'Katarina Behrens
because the user has modified the document Change-Id: Ib32ea2ff41f41a81c9a382585f6afbec12fe6a35 Reviewed-on: https://gerrit.libreoffice.org/38284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-08First cut at moving unzipping into new thread:Mohammed Abdul Azeem
XBufferedThreadedStream class buffers data in a new thread, which will be available to be read from parent thread. Change-Id: I62d367fa1dec23da39aba24b5c765b57707956bb Reviewed-on: https://gerrit.libreoffice.org/38135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-08Fixing loose ends for multithread Sync in package/:Mohammed Abdul Azeem
Mutexes in different classes operate exclusively, which might cause sync problem when multithreads are involved. This patch shares the mutex across all classes that share the underlying stream. Change-Id: I57e549fb7c375f93955bf54886b91b1892db1e27 Reviewed-on: https://gerrit.libreoffice.org/38563 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-08tdf#106366 Show infobar for all read-only documentsSamuel Mehrbrodt
Except those who were set open r/o with the File->Properties checkbox Change-Id: Id44daac364cae73636b6f1c051521928743b88f4 Reviewed-on: https://gerrit.libreoffice.org/36258 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-08oox: replace PUT_PROP macro with comphelper::makePropertyValue() callsMiklos Vajna
This way it's not necessary to state the size of the array in advance, which is kind of redundant. It's also easy to forget to adjust it when adding new elements. Change-Id: I5fe24fd24954afb69ead014941b8f8b90bcaeac3
2017-06-08uitest: disable failing part of manual_tests/calc.pyMiklos Vajna
Fails here on Linux dbgutil like this: ====================================================================== ERROR: test_validation (calc.ManualCalcTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "uitest/manual_tests/calc.py", line 133, in test_validation self.ui_test.execute_blocking_action(enter_text, "ok", args=("B6", "2.18")) File "uitest/uitest/test.py", line 191, in execute_blocking_action raise DialogNotExecutedException("did not execute a dialog for a blocking action") uitest.test.DialogNotExecutedException: Dialog not executed for: did not execute a dialog for a blocking action Change-Id: I2004eb52ce0846ada7ed38dc19d71258d2272ad5
2017-06-08nPoolId already points to STR_POOLCOLL_TOX_AUTHORITIES1 at this pointCaolán McNamara
#define STR_POOLCOLL_TOX_AUTHORITIESH (RC_POOLCOLL_REGISTER_BEGIN+ 29) #define STR_POOLCOLL_TOX_AUTHORITIES1 (RC_POOLCOLL_REGISTER_BEGIN+ 30) in the context of switch( m_eType ) ... case TOX_AUTHORITIES : nPoolId = STR_POOLCOLL_TOX_AUTHORITIESH; break; SetTemplate( 0, SwResId( nPoolId++ )); already results in a nPoolId of STR_POOLCOLL_TOX_AUTHORITIES1 when we enter this loop, so don't need to special case TOX_AUTHORITIES Change-Id: Ic41596a85c48d080cd38003663b729583f08ff98 Reviewed-on: https://gerrit.libreoffice.org/38561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-08Fix build after f1454b474d9248d7ef2cb84f396a974184e5167eStephan Bergmann
..."tdf#45904 Move java XCellSeries test to c++". For one, the XCellSeries tests needed to be removed from qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv, now that those tests are done in C++. (Plus some clean-up in qadevOOo/tests/java/mod/_sc/ScTableSheetObj.java and sc/qa/unoapi/knownissues.xcl that was missing from f1454b474d9248d7ef2cb84f396a974184e5167e.) But for another, qadevOOo/objdsc/sc/com.sun.star.comp.office.ScCellCursorObj.csv and qadevOOo/objdsc/sc/com.sun.star.comp.office.ScCellRangeObj.csv still list XCellSeries tests (which apparently have not been superseded with C++ tests), so partially revert f1454b474d9248d7ef2cb84f396a974184e5167e to get back qadevOOo/tests/java/ifc/sheet/_XCellSeries.java needed by those tests. Change-Id: I09f756fb804dafee3064947abcfb796db4797b32
2017-06-08Improve error reportingStephan Bergmann
Change-Id: I28459b157411b4ab5b10a25e017a0a7208e09aed
2017-06-08clang-tidy performance-type-promotion-in-math-fnNoel Grandin
Change-Id: I71405f1dbf0a1524e4e367ae5e05edaf6a8e98b8 Reviewed-on: https://gerrit.libreoffice.org/38559 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-08tdf#99074: export Web view to DOCXAron Budea
...so document saved in Web view shows in Web Layout in Word. Change-Id: If39d566be02966fe5d22f74aee46e6d5452a9451 Reviewed-on: https://gerrit.libreoffice.org/38469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-08Watermark: VML export/import font sizeSzymon Kłos
Change-Id: I11409dfc621018a761c70a640938e18ae679d3f5 Reviewed-on: https://gerrit.libreoffice.org/38254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-08-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Ia9bf97f10771dad5ecf1c3a9638384a80b65b181
2017-06-08framework: replace double checked locking patternsJochen Nitschke
with thread safe local statics. Change-Id: I660f6a899d1821bab627ed4972c4fc0d40610de2 Reviewed-on: https://gerrit.libreoffice.org/38541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-08Avoid -fsanitize=signed-integer-overflowStephan Bergmann
...in recently introduced basic/qa/basic_coverage/test_string_overflow_safe.vb in CppunitTest_basic_macros Change-Id: Ib33272afa26e90729617cb86ae979c0b35b45f62
2017-06-08remove some unnecessary use of OUStringBufferNoel Grandin
Change-Id: Ia4e02589d2fe79a27b83200a0e7a528a2c806519 Reviewed-on: https://gerrit.libreoffice.org/38508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-29 03:43:32 +0000