summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-28Be consistent with namespaces and parameter order for UNO Api helpersJens Carl
Have this file the same namespaces as the new introduced helpers in include/test/helper/shape.hxx and also change the order of the parameter be the same to avoid confusion. Change-Id: I5614e9a79dff3ee9aca96ff2e50ddfafa83de539 Reviewed-on: https://gerrit.libreoffice.org/69870 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-28check that jpeg export of 8bit non-grayscale worksLuboš Luňák
This checks what I fixed in 1893024c54ab173ec6262d77a05cad285c17a617 (related to tdf#116888). Change-Id: I721017fd037d62ba75cbc962fdd9316e02085624 Reviewed-on: https://gerrit.libreoffice.org/69819 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-28make OpenGLSalBitmap deallocate user data properlyLuboš Luňák
In OpenGLSalBitmap::AcquireBuffer(), if ReadTexture() failed, then the data from AllocateUserData() didn't get deallocated and a next call to OpenGLSalBitmap::AcquireBuffer() skipped the whole block because it assumed the data was valid. Triggered while fixing tdf#116888. Change-Id: Ibfe5c42d6b18748ca649d6b4242ef268c1b13a71 Reviewed-on: https://gerrit.libreoffice.org/69746 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-28make ReadTexture() also handle 8-bit non-grayscale images (tdf#116888)Luboš Luňák
The missing case caused BitmapReadAccess to work with random data (together with a follow-up bug that didn't deallocate data properly after ReadTexture() failed). Change-Id: I4546ee4ca85d6a0b01cc41636c257008c9f19587 Reviewed-on: https://gerrit.libreoffice.org/69745 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-28tdf#124148 add configurable margin for the listbox pop-up listTomaž Vajngerl
This is needed to increase the area of lisbox entries in the pop-up list so it is easier to select with touch. Change-Id: Iedb910508de26c903dc3f50f645f567d4c988940 Reviewed-on: https://gerrit.libreoffice.org/69889 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-28tdf#120338: The paragraph formatting changes are not undone, part 1Henry Castro
Rejecting paragraph formatting is not implemented yet. "Reject All" command is affected because the changes were not removed Change-Id: Ic4af1def97025643ecbc5cf0752cd06d9b94c74a Reviewed-on: https://gerrit.libreoffice.org/69865 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-03-28use unique_ptr for SwFieldTypesNoel Grandin
Change-Id: Iddfc94618e70d3ca8414d526e58746720610c552 Reviewed-on: https://gerrit.libreoffice.org/69861 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28loplugin:useuniqueptr in sc dialog constructorsNoel Grandin
Change-Id: I9fef0d3d567d9a0143c7a796725a44348b96bb23 Reviewed-on: https://gerrit.libreoffice.org/69880 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28tdf#121456 sw: DOCX: fix loading of empty TOC titleSerge Krot
Change-Id: Ib241edd07e4c6781d80db274f73146bda310d8c0 Reviewed-on: https://gerrit.libreoffice.org/69827 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-28loplugin:useuniqueptr in ImpEditEngine::WriteItemListAsRTFNoel Grandin
Change-Id: I50188d81743f1daaf96412b3cd70c150c8d72502 Reviewed-on: https://gerrit.libreoffice.org/69879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28use unique_ptr in SwTable::InsTableNoel Grandin
Change-Id: I02ad6fb65e39ed14fd1aff2df876a9704c0d8f3b Reviewed-on: https://gerrit.libreoffice.org/69882 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28tdf#124385: toolkit: do not fail if ResourceListener is not definedVasily Melenchuk
If current control (for example TabPageContainer) is missing resource listener property we should not fail script with exception. Just behave as with empty ResourceListener. Change-Id: I260feec775a5d197bebc9414b652dd6f89e35035 Reviewed-on: https://gerrit.libreoffice.org/69740 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-28simplify reset(nullptr) -> reset()Noel Grandin
Change-Id: Iec5e93d9c59dde44571376e46fb98ea854e16b6c Reviewed-on: https://gerrit.libreoffice.org/69784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28Implement sidebar increase/decrease indent buttons on ImpressGülşah Köse
Change-Id: Ie7c115e041a6dee7b5e5d938ad3fbf37cf9bc89b Reviewed-on: https://gerrit.libreoffice.org/69840 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28return unique_ptr from CreateNewStorageImplNoel Grandin
Change-Id: I32fa9b9bf4067792a3ad968ba5f2ef9b311ef48a Reviewed-on: https://gerrit.libreoffice.org/69858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28return unique_ptr in OXMLHelperNoel Grandin
Change-Id: Iad6e51ef1b7b8d4ab1227b89f77a3d72d3424bcd Reviewed-on: https://gerrit.libreoffice.org/69857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28CppunitTest_sw_layoutwriter: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: Ieba1f00b64b39d396faf8e663e1c7a73974709f9 Reviewed-on: https://gerrit.libreoffice.org/69867 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28tdf#113539 Slow opening of ODT file containing a large tableNoel Grandin
I suspect that somebody has already fixed the bulk of this, since on my machine, the opening time started as: 0m5.363s After changing from std::set to o3tl::sorted_set in SwAccessibleTableData_Impl, it dropped to: 0m4.372s And then tweaking SfxSplitWindow::InsertWindow_Imp lowered it to: 0m4.030s which seems perfectly acceptable to me. Change-Id: I0c6123e99ab560742bd3dc97bb76666b48a3b1b6 Reviewed-on: https://gerrit.libreoffice.org/69862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28use unique_ptr for SwTOXTypesNoel Grandin
Change-Id: I66e6ce7f2d5f2b9ba8bbf6046a87f2d208a9a768 Reviewed-on: https://gerrit.libreoffice.org/69860 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28return unique_ptr from CreateTableStyleNoel Grandin
Change-Id: I31b12fa3f80dc450fff27128efb2fbebc711b249 Reviewed-on: https://gerrit.libreoffice.org/69859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28return unique_ptr from CreateTokenMatrixMapNoel Grandin
Change-Id: I7a779bf1b2e5438e7e5d9f75c765049d4e2b9dac Reviewed-on: https://gerrit.libreoffice.org/69856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28return unique_ptr from SdrPage::CreateObjectSpecificViewContactNoel Grandin
Change-Id: I3297128efd44f4df86886d6f0349420d6ce18571 Reviewed-on: https://gerrit.libreoffice.org/69855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28return by unique_ptr from SwFieldType::CopyNoel Grandin
Change-Id: I145b55c9cd62a5853c0dd26cc9b805b9f3a0e436 Reviewed-on: https://gerrit.libreoffice.org/69854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28return by unique_ptr from InsertTableContentsNoel Grandin
Change-Id: I85e82834688a7e4f73f28a589e1d9ac49f39fc51 Reviewed-on: https://gerrit.libreoffice.org/69853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28return unique_ptr from MakeNumRuleNoel Grandin
Change-Id: Ic606aa8f349946661b4a5fb017d1a1fd4ba993ae Reviewed-on: https://gerrit.libreoffice.org/69852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28return unique_ptr from FillAutoFormatOfIndexNoel Grandin
Change-Id: If41981a2136ab1a9d06a1b7a3b044ade302ba1d4 Reviewed-on: https://gerrit.libreoffice.org/69795 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28return by unique_ptr from createDefaultWidgetNoel Grandin
Change-Id: I2b2c944ed090173aba36395457a84985f0cf6665 Reviewed-on: https://gerrit.libreoffice.org/69794 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28Sifr icon theme update lc_andreas kainz
Change-Id: I0a065c1f97eef8829eb4ec7a237c7496e8f8f4f5 Reviewed-on: https://gerrit.libreoffice.org/69868 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-28Fix typoAndrea Gelmini
Change-Id: I6ba022b55af8f54f8a2e01ac354a345d1fcbf075 Reviewed-on: https://gerrit.libreoffice.org/69876 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-28tdf#45904 Move XShapeGrouper Java tests to C++Jens Carl
Move XShapeGrouper Java tests to C++ for ScDrawPageObj. Change-Id: I4a1ed4f14f759fa4214141f0d552e35ccae28035 Reviewed-on: https://gerrit.libreoffice.org/69873 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-28tdf#45904 Move XServiceInfo Java tests to C++Jens Carl
Move XServiceInfo Java tests to C++ for ScDrawPageObj. Change-Id: Icc2c97296f549763068475be18c00a23b7cd73dc Reviewed-on: https://gerrit.libreoffice.org/69872 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-28tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScDrawPageObj. Change-Id: I3a51c77f524311416ac054005c0632e5127efb79 Reviewed-on: https://gerrit.libreoffice.org/69871 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-27tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScDrawPageObj. Change-Id: I8b0c80b9213130870ce5445bcf52705df367cb0e Reviewed-on: https://gerrit.libreoffice.org/69864 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-27sd menubar update impress and drawandreas kainz
Change-Id: I37d71a7eca1c75dd6f1eb3fe0428fd176c44f1d2 Reviewed-on: https://gerrit.libreoffice.org/69493 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-27move LineListBox beside last consumerCaolán McNamara
Change-Id: Ie683784a9f4ecfb0015bf7ae79769238719a6376 Reviewed-on: https://gerrit.libreoffice.org/69841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-27license: add xmlsec-mscrypto and xmlsec-mscngAndras Timar
xmlsec-mscrypto is for LibreOffice <= 6.1 xmlsec-mscng is for LibreOffice >= 6.2 But who knows where this this patch will be backported. Let's include both. Change-Id: I4c35a7e63c7024022e0215f9dad486afae0896f9
2019-03-27Sifr icon theme updateandreas kainz
Change-Id: Icd461c651a09d8b41c2500a76fbddc9cb13c2af7 Reviewed-on: https://gerrit.libreoffice.org/69863 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-03-27return unique_ptr from CreateOutputEditEngineNoel Grandin
Change-Id: I403f0da5ea1ccdf508d156a9fa828e9f91813385 Reviewed-on: https://gerrit.libreoffice.org/69804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-27Helper to create various drawing::XShapeJens Carl
This ports SOfficeFactory::createShape() from file qadevOOo/runner/util/SOfficeFactory. Change-Id: I2c7eb0304ac1d439211d3851b2debdb4843130e3 Reviewed-on: https://gerrit.libreoffice.org/69772 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-27Nested list L must be a child of parent's LBodyKatarina Behrens
Implement this as https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G13.2259746 describes. The example implementation in Annex H8.2 https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G21.1021285 where nested L is a sibling of its parent LI contradicts the specification and is prolly wrong Change-Id: I2bd4a6692ac0cbe02ff6f1746656f104de3fe1f2 Reviewed-on: https://gerrit.libreoffice.org/69506 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-27tdf#60242 remember horizontal/vertical choice in split cells dialogMartin van Zijl
Change-Id: I25f6b7c8ff6aa678b597bbede0dd1492468f2f62 Reviewed-on: https://gerrit.libreoffice.org/65606 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-27Remove stale testcodeThorsten Behrens
Change-Id: I64a0b9cd4a727349016aa307d5c4835158a93109 Reviewed-on: https://gerrit.libreoffice.org/69822 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-27Remove unused macros that caused compiler warnings and simplifyTor Lillqvist
Change-Id: Ica146899a5557732babf4e07b20b9e3d32426c6e Reviewed-on: https://gerrit.libreoffice.org/69824 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-03-27tdf#123505 svx: fix invalidation loop caused by special form control geometryMiklos Vajna
Regression from commit d464d505fbf6e53a38afdd3661d320fac8c760d6 (Refactor calc non-linear ViewToDevice transform, 2018-10-12), the problem was that the opengl menu was never painted from the starved idle handler as a paint-invalidation loop starved the main loop. ScGridWindow::Paint() called vcl::Window::ImplPosSizeWindow() for the form control of the bugdoc, which triggered an invalidation -> paint -> start again. Checking what adjustControlGeometry_throw() did, the result of the transformed points are quite close to each other, but not equivalent: debug:18521:18521: adjustControlGeometry_throw: aTopLeft before transformation is (1773,426) debug:18521:18521: adjustControlGeometry_throw: aTopLeft after transformation is (64.935,16.0382) debug:18521:18521: adjustControlGeometry_throw: aPaintRectPixel is 952x586@(64,16) If we round, rather than truncate, then the size of the control is always the same, so no actual resize and invalidation happens during paint. Change-Id: Id55fd227e3ae7fc57d5253bc28f42b9b4315450e Reviewed-on: https://gerrit.libreoffice.org/69821 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-27Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Fix typo Change-Id: I064146b36884740fc90b889ea92758a10782b5dd Reviewed-on: https://gerrit.libreoffice.org/69823 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-27sifr is CC_BY_SA 3.0, can be included in MPL subsetAndras Timar
Change-Id: I5d6cfd5b9b4049ee16ffa038bac2db20968b02b3 Reviewed-on: https://gerrit.libreoffice.org/69812 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27license: update 'Artwork' sectionAndras Timar
Change-Id: I9528ea941f4c837b31e8bc8d05d3a5d963567033 Removed: KDE Krystal theme Added: Breeze, Colibre, Elementary, Karasa Jaga, Sifr Reviewed-on: https://gerrit.libreoffice.org/69811 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27tdf#124293 add RedactDoc to writer, calc menubar in toolsandreas kainz
Change-Id: I8276506aaeaaee2bef5dad832d488450688081ee Reviewed-on: https://gerrit.libreoffice.org/69810 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-27Sifr icon theme update lc_andreas kainz
Change-Id: I4da2244b32e02acf3c0f911a2c16d4fad243e5c5 Reviewed-on: https://gerrit.libreoffice.org/69809 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>