summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-04-13sfx2: fix crash in InterceptLOKStateChangeEvent()Miklos Vajna
Notice how e.g. the TransformPosX case already performed the same null pointer check. Crashreport backtrace: > program/libmergedlo.so > InterceptLOKStateChangeEvent > sfx2/source/control/unoctitm.cxx:1143 > program/libmergedlo.so > SfxStateCache::SetState_Impl(SfxItemState, SfxPoolItem const*, bool) > sfx2/source/control/statcach.cxx:432 > program/libmergedlo.so > SfxBindings::Update_Impl(SfxStateCache&) > /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/stl_vector.h:919 (discriminator 2) > program/libmergedlo.so > SfxBindings::NextJob_Impl(Timer const*) > /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173 Change-Id: I141d4f9ec50d0ce7a0eeaba69752c31390a1f9ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166027 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-13Simplify a bit, and use more o3tl::convertMike Kaganski
Change-Id: I30f619b81d831db9c1e212a1588d5696b9ad3dd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166048 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-13tdf#160567 Replace duplicate style A4 with A0Laurent Balland
Style A4 was defined twice and A0 was missing. Rename second A4 with A0 and change size to 48pt Change-Id: I529b4fab5223269908867531873d36d3e878e7e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166045 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-13Related: tdf#160056 elide ref counting for initial tokensCaolán McNamara
The initial tokens provided to interpreting will be restored to their original ref count when interpreting is complete. So we could elide expensive ref counting for them for the duration of the the threaded group calculation. Possibly "temp" tokens that are created just during interpreting could additionally use thread-unsafe ref counts presuming they only appear in a thread specific context. Change-Id: I1f5b0198e83027781be15812680079f28b6a4e27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165259 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-13Mark obsolete Impress/Draw config keys as deprecatedGabor Kelemen
Practically unused since 2007 commit 56ca5814a1843a31d23b249f1960a31532c6b5bd Change-Id: Idd7cf4f239efed16a151fc4c755c249947d927f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165859 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-13Drop unused SdOptionsContents classGabor Kelemen
seems to be practically out of use since 2007 commit 56ca5814a1843a31d23b249f1960a31532c6b5bd part of patch series '#i80528# Removal of draft paint modes' Change-Id: I770bab8b1973bec099ffdaa3243f1c0d2995ee52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165858 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-13Remove duplicated includeAndrea Gelmini
Change-Id: Ie70543c67549498d51eeb53d262b52f8ef1ec700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166043 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-04-13Fix typoAndrea Gelmini
Change-Id: If0fbaae23b98d3bdd178473db8fdb8ab2263ef67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166042 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-04-13pivot: Export Pivot Table "formats" element(s)Tomaž Vajngerl
This change adds the "formats" element tree export for a pivot table. The source are the formats (sc::PivotTableFormats) added to the pivot table - in the ScDPSaveData class. This are currently set on import but in the future hopefully those are also set through the UI. Change-Id: I5ed8f7e8d7ac248b0222a884fb97555ef6bb8427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166035 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-13Don't use lround when assigning to a doubleMike Kaganski
Change-Id: Ifdfd351cf1f2848b754ec7a4c6f6cb9a56f478d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165939 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-13Add VclPtr operators to natstepfilterMike Kaganski
And fix a vector-related filter Change-Id: Icd3f5bd5a04a1385dff3f3413792a7aad544a506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166029 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-13Use o3tl::convert in ooxMike Kaganski
Change-Id: I1cbc299e7e64eae48f0f6c896a8160bbe6e19c97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165938 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-13Related: tdf#160056 call FormulaCompiler::IsOpCodeJumpCommand just onceCaolán McNamara
rearrange to reuse previous calculation Change-Id: Ibda0388e020dac995e5667af09767b0314720935 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166039 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-13Related: tdf#160056 don't call GetParamCount twiceCaolán McNamara
GetParamCount: 290ms -> 175ms Change-Id: Ic3a26b1e8035744dcab2da69a8ebd3b29dd2160a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166031 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-12At least capture (English-only) cURL error when something goes wrongStephan Bergmann
...so that svx/source/dialog/crashreportdlg.cxx can at least present that, instead of confusingly being silent about the error Change-Id: I5e8af5f8df4cbcad84f8b60c2de4c55621b28890 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166037 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-12ofz#68004 Unknown ReadCaolán McNamara
Change-Id: Id3e50e3a8522523d2b665e394d8f4a65b7f4df5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166034 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-12Embind: support .implement()-based JS UNO objectsStephan Bergmann
Change-Id: I3a8bf5986b91b886547cfe57e49275f7c79ddc11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166020 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-12tdf#147021 Replace SAL_N_ELEMENTS with std::sizeAshwani5009
As part of the efforts in #145538 to replace the SAL_N_ELEMENTS() macro with std::size() and std::ssize(), this commit performs the necessary changes for a few files in the i18npool module. Change-Id: Ic64be31b74cd74faf17497a47d6a15158b85184c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166013 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-04-12sc: fix -Werror,-Wunused-but-set-variableMiklos Vajna
Pointed out by clang-15: sc/source/core/data/PivotTableFormatOutput.cxx:256:12: error: variable 'nEntryIndex' set but not used [-Werror,-Wunused-but-set-variable] size_t nEntryIndex = 0; ^ Change-Id: I3abf7fe6d4ed330cd713472ce4102eeef6aea4dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166022 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-12tdf#146266 Move WeakBag test to gbuild systemRMZeroFour
As part of the efforts in tdf#146266 to move parts of the codebase from the older makefile.mk build system to the newer gbuild system, this commit migrates the WeakBag test, and cleans it up a little. The test can now be invoked using this command: $ make CppunitTest_comphelper_weakbag Change-Id: I4ac3771fa23e28abd38a2dab84cacd1ae57fb70f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165591 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2024-04-12Add the strings "dialog" after "Macro Selector" in extended tipsTaichi Haradaguchi
because the Macro Selector is the dialog name. Change-Id: I3e766016279f85c47eca8a6abf8b5dde4cc6a538 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165487 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-04-12fold OnDemandNativeNumberWrapper ctor and init togetherCaolán McNamara
Change-Id: I79e2cb4c81a2bbac4da16ece778e4ad3acc59eb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-12crashtesting: assert seen on importing forum-mso-en4-62805.xlsxCaolán McNamara
Change-Id: I1d1ab4539775c8c2fce591ca32fc15c3c0dd6060 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166024 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-12crashtesting: assert on exporting fdo48097-1.doc to docxCaolán McNamara
noticeable since: commit ad4b72a0eacf6bb6887236ea3a3807b1264de822 Date: Thu Mar 21 12:10:40 2024 +0100 tdf#160301 import DOCVARIABLE fields as user fields but not really caused by it Change-Id: I44910756df3938829589f230716363beaf0f4f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166023 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-12tdf#116091: Replaced 'AutoFormat' Button in Convert Text to Table dialogSujatro Bhadra
Change-Id: If8eee099e79e65d5a6ca1b06d1cfb2a71bbe52f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165099 Tested-by: Jenkins Reviewed-by: Sujatro Bhadra <sujatrobhadra@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-04-12Remove duplicated includeAndrea Gelmini
Change-Id: I423fed50156a225d14c0afeebd7b72936c052b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166008 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-04-12Resolves: tdf#160256 Add "[Multiple]" and "[Undetermined]" to language listEike Rathke
Such that they are added to the top of the list after "[None]" and only if "[None]" was requested. {mul} and {und} ISO codes. Change-Id: I024311fe7d638124932a1d38759305e8efec5962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166012 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-04-12sw: workaround crash in IsAllHiddenRow()Michael Stahl
Not sure why but somehow still crashes in the code added in commit ab7893544dc6be6dc192dffefd57cd5ddd421c35 https://crashreport.libreoffice.org/stats/crash_details/912e7417-5e04-4279-bbaf-380234f4cd33 Change-Id: I23b7ecdd83009cfe6584866ed72102d8f2179f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166010 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-04-12tdf#159660: Add support for screen mode in feBlendXisco Fauli
Change-Id: Iefe655a370cca930319290baa2a25d791371f55c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165958 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-04-12Related: tdf#127293 Fix regex search mode in XLOOKUP wildcards modeBalazs Varga
If relevant Option in Calc was set for regex, xlookup still used the wildcard search mode. Change-Id: I318c3f368b6f59644c43ec518542910be72a5e0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166015 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-04-12Fix typoAndrea Gelmini
Change-Id: I6e5c31a0d3577c40acd62b4c9dd6d4c084865c0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166016 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-04-12pivot: PivotTableFormatOutput to resolve and set PT cell formatTomaž Vajngerl
This adds the PivotTableFormatOutput, which main responsibility is to resolve the reference for which the pivot table format is set to. It first prepares the format data into such a structure that it is easier to match with the pivot table fields and data. Then the pivot table data is filled during the output, where we remember the cell positions of the pivot table output. The last step is to resolve the pivot table format references with the filled data, where the cell formats are applied to the output. PivotTableFormatsImportExport was added to test the correctnes of the functionality. Change-Id: Ie67ea15b3aa74739f15937800d03d256b8f68277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165992 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-12Resolves tdf#157403 sidebar SdNavigator does not show new slide/pageJim Raykowski
after file reload Change-Id: I8ba7ffac3c098cf388a67e3454c5986b5a8b1f3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165767 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-04-12lok: calc: not possible to select the cell adjacent to the edited oneMarco Cecchetti
In the LOK case using the paper size for the printer case (wysiwyg) can make the cell background and visible area larger than needed which makes selecting the adjacent right cell impossible in some cases. Change-Id: I20edd62645692f30e432b1064bb9c85b3396dc32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164702 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit a6bc0272607590d1692db385be7f6fbfeb1a8fb4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164999 Tested-by: Jenkins
2024-04-12pivot: remove duplication in ScDPSaveDimension::GetMemberByNameTomaž Vajngerl
Change-Id: I036e83307615a8c1f875ffc66a54027e1ec31a92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165991 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-12pivot: ScDPSource prefix membersTomaž Vajngerl
Change-Id: I7551078b798e910c0255a9211c7b22aca624b62b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165990 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-12pivot: use ScPatternAttr not styles for pivot table cell formatTomaž Vajngerl
Get the ItemSet from the Dxf instead of creating a style from it, then create a new ScPatterAttr, which is then transported to the pivot table and used there. Change-Id: I2ed886d0dd986b587e37330a39d6cd465b3bcf12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165686 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-12pivot: also set format on a data field within row/column outputTomaž Vajngerl
Change-Id: I83cd4edd8fd64698170e1e8ac83f5017af80042f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165685 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-12pivot: split ScDPOutput::Output to multiple methodsTomaž Vajngerl
Change-Id: Idad1c4652a9d506d0584570e55855b0a9406959a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165684 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-11tdf#160176 svx: Reset help text when form control has noneMichael Weghorn
In `FmFormPage::RequestHelp`, also call `Help::ShowQuickHelp`/`Help::ShowBalloon` when the help text is empty, as that is the way to unset the help text/remove the tooltip again, see `ImplShowHelpWindow` in `vcl/source/app/help.cxx`: For the case of non-native tooltips (e.g. the gen VCL plugin on Linux), the `bRemoveHelp = true` code path is relevant. For qt5/qt6/kf5/kf6 which use native tooltips, the call to pParent->ImplGetFrame()->ShowTooltip(rHelpText, rHelpArea) further up sets the `QtFrame`'s `m_aTooltipText` member to an empty string, which prevents showing the outdated help text for the `QEvent::ToolTip` event in `QtWidget::handleEvent`. Change-Id: Iceb2424d9c72ae46333a718c677629122e517f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166006 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-11related tdf#160176 qt: Create dummy Qt widget in main threadMichael Weghorn
Always run `QtGraphics_Controls::getNativeControlRegion` in the main thread, as it may create a dummy `QLineEdit` (see the `ControlType::MultilineEditbox` and `ControlType::Editbox` cases) and creating Qt widgets is only allowed in the main thread. Without the following scenario runs into an assert with a current Qt 6 dev debug build when using the qt6 VCL plugin: 1) open sample document attachment 193089 from tdf#160176 2) enable Form Design Toolbar 3) switch to Design mode 4) select label next to "Labelfield2" label 5) right-click, "Control Properties" 6) type anything for the help text and tab to the next UI element Backtrace: ASSERT failure in QWidget: "Widgets must be created in the GUI thread.", file /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp, line 956 Thread 45 "browserlistbox" received signal SIGABRT, Aborted. [Switching to Thread 0x7fff8d08d6c0 (LWP 203558)] __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt #0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 #1 0x00007ffff78a81cf in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 #2 0x00007ffff785a472 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 #3 0x00007ffff78444b2 in __GI_abort () at ./stdlib/abort.c:79 #4 0x00007fffe32f8540 in qAbort() () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:49 #5 0x00007fffe330c393 in qt_message_fatal<QString&>(QtMsgType, QMessageLogContext const&, QString&) (context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2056 #6 0x00007fffe3305344 in qt_message(QtMsgType, const QMessageLogContext &, const char *, typedef __va_list_tag __va_list_tag *) (msgType=QtFatalMsg, context=..., msg=0x7fffe3981990 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7fff8d086178) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:374 #7 0x00007fffe330740f in QMessageLogger::fatal(char const*, ...) const (this=0x7fff8d0863c0, msg=0x7fffe3981990 "ASSERT failure in %s: \"%s\", file %s, line %d") at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:874 #8 0x00007fffe32f8613 in qt_assert_x(char const*, char const*, char const*, int) (where=0x7fffe1becdf3 "QWidget", what=0x7fffe1becdc8 "Widgets must be created in the GUI thread.", file=0x7fffe1becca0 "/home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp", line=956) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:114 #9 0x00007fffe144118c in QWidgetPrivate::init(QWidget*, QFlags<Qt::WindowType>) (this=0x7fff780054d0, parentWidget=0x0, f=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:956 #10 0x00007fffe1440ca1 in QWidget::QWidget(QWidgetPrivate&, QWidget*, QFlags<Qt::WindowType>) (this=0x7fff8d086d00, dd=..., parent=0x0, f=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:872 #11 0x00007fffe16a7d22 in QLineEdit::QLineEdit(QString const&, QWidget*) (this=0x7fff8d086d00, contents=..., parent=0x0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qlineedit.cpp:253 #12 0x00007fffe16a7c98 in QLineEdit::QLineEdit(QWidget*) (this=0x7fff8d086d00, parent=0x0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qlineedit.cpp:239 #13 0x00007fffe404aebc in QtGraphics_Controls::getNativeControlRegion(ControlType, ControlPart, tools::Rectangle const&, ControlState, ImplControlValue const&, rtl::OUString const&, tools::Rectangle&, tools::Rectangle&) (this=0x55555cbb13e0, type=ControlType::Editbox, part=ControlPart::Entire, controlRegion=..., controlState=(ControlState::ENABLED | ControlState::ROLLOVER), val=..., nativeBoundingRegion=..., nativeContentRegion=...) at vcl/qt6/../qt5/QtGraphics_Controls.cxx:784 #14 0x00007fffee72945e in SalGraphics::GetNativeControlRegion(ControlType, ControlPart, tools::Rectangle const&, ControlState, ImplControlValue const&, tools::Rectangle&, tools::Rectangle&, OutputDevice const&) (this=0x55555eb28920, nType=ControlType::Editbox, nPart=ControlPart::Entire, rControlRegion=..., nState=(ControlState::ENABLED | ControlState::ROLLOVER), aValue=..., rNativeBoundingRegion=..., rNativeContentRegion=..., rOutDev=...) at /home/michi/development/git/libreoffice/vcl/source/gdi/salgdilayout.cxx:834 #15 0x00007fffee3a7195 in OutputDevice::GetNativeControlRegion(ControlType, ControlPart, tools::Rectangle const&, ControlState, ImplControlValue const&, tools::Rectangle&, tools::Rectangle&) const (this=0x5555607cd870, nType=ControlType::Editbox, nPart=ControlPart::Entire, rControlRegion=..., nState=(ControlState::ENABLED | ControlState::ROLLOVER), aValue=..., rNativeBoundingRegion=..., rNativeContentRegion=...) at /home/michi/development/git/libreoffice/vcl/source/outdev/nativecontrols.cxx:313 #16 0x00007fffede63b9d in ImplSmallBorderWindowView::DrawWindow(OutputDevice&, Point const*) (this=0x5555607c7c10, rRenderContext=...) at /home/michi/development/git/libreoffice/vcl/source/window/brdwin.cxx:699 #17 0x00007fffede69900 in ImplBorderWindow::Paint(OutputDevice&, tools::Rectangle const&) (this=0x5555607c7ca0, rRenderContext=...) at /home/michi/development/git/libreoffice/vcl/source/window/brdwin.cxx:1628 #18 0x00007fffede3e241 in PaintHelper::DoPaint(vcl::Region const*) (this=0x7fff8d088188, pRegion=0x7fff78006480) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:313 #19 0x00007fffede3feff in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x5555607c7ca0, pRegion=0x7fff78006480, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:617 #20 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d0883c8) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #21 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55556002ead0, pRegion=0x7fff78005ec0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #22 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088608) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #23 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555edac0e0, pRegion=0x7fff78005dc0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #24 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088848) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #25 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555edab480, pRegion=0x7fff78005d80, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #26 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088a88) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #27 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555edaa900, pRegion=0x7fff78004c40, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #28 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088cc8) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #29 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555ed29400, pRegion=0x7fff78004c00, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #30 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088f08) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #31 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555eccc910, pRegion=0x7fff78005d40, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #32 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089148) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #33 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555eda7a70, pRegion=0x7fff78004ac0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 --Type <RET> for more, q to quit, c to continue without paging-- #34 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089388) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #35 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555eda2210, pRegion=0x7fff78001230, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #36 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d0895c8) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #37 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555ecd5d20, pRegion=0x7fff78002510, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #38 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089808) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #39 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555ecdae90, pRegion=0x7fff78001ae0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #40 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089a48) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #41 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555bb5ddb0, pRegion=0x55555eb4e340, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #42 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089c88) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #43 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555ed5c6e0, pRegion=0x7fff78001310, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #44 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089ec8) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552 #45 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555eb3aa10, pRegion=0x0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623 #46 0x00007fffede41a32 in vcl::Window::PaintImmediately() (this=0x5555607c7ca0) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:1340 #47 0x00007fffede415a0 in vcl::Window::PaintImmediately() (this=0x5555607c49b0) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:1280 #48 0x00007fffee17f7ac in Edit::ImplInvalidateOrRepaint() (this=0x5555607c49b0) at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:451 #49 0x00007fffee182a52 in Edit::ImplAlignAndPaint() (this=0x5555607c49b0) at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:1170 #50 0x00007fffee183ef0 in Edit::ImplInsertText(rtl::OUString const&, Selection const*, bool) (this=0x5555607c49b0, rStr="ee", pNewSel=0x7fff8d08a6b8, bIsUserInput=false) at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:885 #51 0x00007fffee1841ca in Edit::ImplSetText(rtl::OUString const&, Selection const*) (this=0x5555607c49b0, rText="ee", pNewSelection=0x7fff8d08a6b8) at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:918 #52 0x00007fffee18cfd4 in Edit::SetText(rtl::OUString const&) (this=0x5555607c49b0, rStr="ee") at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:2560 #53 0x00007fffee8d974a in SalInstanceEntry::set_text(rtl::OUString const&) (this=0x5555607c4200, rText="ee") at /home/michi/development/git/libreoffice/vcl/source/app/salvtables.cxx:3383 #54 0x00007fff7ef6054a in pcr::OEditControl::setValue(com::sun::star::uno::Any const&) (this=0x5555607c7660, _rValue=uno::Any("string": "ee")) at /home/michi/development/git/libreoffice/extensions/source/propctrlr/standardcontrol.cxx:200 #55 0x00007fff7ed96819 in pcr::OBrowserListBox::impl_setControlAsPropertyValue(pcr::ListBoxLine const&, com::sun::star::uno::Any const&) (_rLine=..., _rPropertyValue=uno::Any("string": "ee")) at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:551 #56 0x00007fff7ed96485 in pcr::OBrowserListBox::SetPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&, bool) (this=0x55555eda22b0, _rEntryName="HelpText", _rValue=uno::Any("string": "ee"), _bUnknownValue=false) at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:403 #57 0x00007fff7ef432e8 in pcr::OPropertyEditor::SetPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&, bool) (this=0x55555ecdb3e0, rEntryName="HelpText", _rValue=uno::Any("string": "ee"), _bUnknownValue=false) at /home/michi/development/git/libreoffice/extensions/source/propctrlr/propertyeditor.cxx:277 #58 0x00007fff7ef01d4f in pcr::OPropertyBrowserController::Commit(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x55555c5f1b40, rName="HelpText", _rValue=uno::Any("string": "ee")) at /home/michi/development/git/libreoffice/extensions/source/propctrlr/propcontroller.cxx:1337 #59 0x00007fff7ed954ae in pcr::OBrowserListBox::valueChanged(com::sun::star::uno::Reference<com::sun::star::inspection::XPropertyControl> const&) (this=0x55555eda22b0, _rxControl=uno::Reference to (pcr::OEditControl *) 0x5555607c76b0) at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:637 #60 0x00007fff7ed95268 in pcr::PropertyControlContext_Impl::impl_processEvent_throw(comphelper::AnyEvent const&) (this=0x55555ed29270, _rEvent=...) at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:291 #61 0x00007fff7ed950b9 in pcr::PropertyControlContext_Impl::processEvent(comphelper::AnyEvent const&) (this=0x55555ed29270, _rEvent=...) at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:272 #62 0x00007ffff6118a2e in comphelper::AsyncEventNotifierBase::execute() (this=0x5555568d6620) at /home/michi/development/git/libreoffice/comphelper/source/misc/asyncnotification.cxx:139 #63 0x00007ffff6119165 in comphelper::AsyncEventNotifier::execute() (this=0x5555568d6620) at /home/michi/development/git/libreoffice/comphelper/source/misc/asyncnotification.cxx:156 #64 0x00007ffff7d0f6ec in salhelper::Thread::run() (this=0x5555568d6630) at /home/michi/development/git/libreoffice/salhelper/source/thread.cxx:39 #65 0x00007ffff7d0ff2e in threadFunc(void*) (param=0x5555568d6640) at include/osl/thread.hxx:189 #66 0x00007ffff7fa4b2d in osl_thread_start_Impl(void*) (pData=0x55555ecc3e40) at /home/michi/development/git/libreoffice/sal/osl/unx/thread.cxx:237 #67 0x00007ffff78a645c in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:444 #68 0x00007ffff7926bbc in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 Change-Id: I9e0b0d973997e3f4f50a9a31e9692325664fd262 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165995 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-11a11y: Assign a11y role for WindowType::PROGRESSBARMichael Weghorn
`WindowType::PROGRESSBAR` was recently added in commit 460a7103664ac8dc60e260c56e5113d689b8072f Author: Hubert Figuière <hub@collabora.com> Date: Fri Mar 22 09:59:54 2024 -0400 vcl: Implement JSLevelBar This fixes the JSDialog layout of the sheet protection dialog. This was introduced for 24.02 to provide password strength indication of the sheet password. Defined a new WindowType of PROGRESSBAR. The type property in JSDialog JSON will be "progressbar". Map it to the corresponding a11y role, `accessibility::AccessibleRole::PROGRESS_BAR`, so it's reported as such on the a11y level. The role can e.g. be seen in Accerciser for the password strength indicator (progress bar) in the dialog to set a document password (shown when checking the "Save with password" checkbox in the Save dialog in Writer). Before: In [2]: acc.role Out[2]: <enum ATSPI_ROLE_PANEL of type Atspi.Role> With this commit in place: In [8]: acc.role Out[8]: <enum ATSPI_ROLE_PROGRESS_BAR of type Atspi.Role> Change-Id: Idfd7798641e30632a9ffd2ea07a79d42d159a51f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165989 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-11vcl a11y: Reformat switch-case in Window::getDefaultAccessibleRoleMichael Weghorn
Use more standard formatting for this switch-case in `Window::getDefaultAccessibleRole` (mostly done by clang-format). It helps at least myself see more easily what a11y role a window type is mapped to as the assignment and break are on separate, further indented lines now. Change-Id: Ic6c7588f2212055812cd32d34eccbaf27fa41eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165988 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-11IASS: Correct Buffering of last SlideArmin Le Grand (allotropia)
There is a mechanism to pre-fetch the next slide, but at the last slide that just gets not reset/refreshed. Thus the last slide *is* the buffered slide. When making changes and refreshing the SlideShow display for the last slide this pe-fetched one is just used, so the slide content gets not re-created and thus not updated. I added needed code to do that now when reacing the last slide to make that work. Change-Id: Ie57e6917e0996d5fce46021aeb933064c47dd90f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166011 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-04-11Update git submodulesLászló Németh
* Update helpcontent2 from branch 'master' to 58350a811a8001f72b13f6ca3def5f32ea904e72 - tdf#132599 add "Hyphenation across" options Document new options of LO 24.8 to control hyphenation in last line of a column, page or spread. Follow-up to core commit 6e8819f29b6051a0e551d77512830539913ec277 "tdf#132599 cui offapi sw xmloff: add hyphenation-keep-type", core commit 9574a62add8e4901405e12117e75c86c2d2c2f21 "tdf#132599 cui offapi sw xmloff: implement hyphenate-keep" and core commit c8ee0e8f581b8a6e41b1a6b8aa4d40b442c1d463 "tdf160518 DOCX: import hyphenation-keep to fix layout". Change-Id: I1d7d6ef1b154f7c6dd55e99584d1d27ce46899ac Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166009 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-04-11pivot: un-abbreviate vars. in ScDPOutput::OutputTomaž Vajngerl
Change-Id: If480afbdcb2a350907a1cac734ebf76424825371 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165683 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-11pivot: forward pivot table format data into the pivot table modelTomaž Vajngerl
The purpuse of this is to lay out the foundation for the support of pivot table formatting. This adds the code to forward the formatting information from the OOXML import into the pivot table model and uses it in a use case to set the row and column labels in the pivot table output (DPOutput). In the follow up commits the support will be extended to support more use cases with tests. Change-Id: Idf23884b32167bdbad69bc67358ccf7f14566db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164710 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-11pivot: Import Pivot Table "formats" element(s)Tomaž Vajngerl
This reads the "formats" element that is a subelement of OOXML "pivotTableDefinition" element and is used to define the custom cell format of a pivot table output. Change-Id: Ice0d489d78860ef04388c59810d9f97c5cdb983e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164708 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-11Move variables into their usage scopeMike Kaganski
Change-Id: I9b04a3b62fed65139a4b48629e9b442ba163a3d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165931 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-11tdf#160616 - Fix SUMPRODUCT calculation is broken in some casesBalazs Varga
Double refs with operators only trimmable in case of one root paramater. Follow up of: ba0ec4a5d2b025b675410cd18890d1cca3bc5a2f Change-Id: If61fb39696d9539ffc9d32a6ecad79bfa1bf92e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165957 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
generated by cgit (git 2.34.1) at 2025-01-13 11:57:45 +0000