summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-19loplugin:unusedmethodsNoel Grandin
Change-Id: I2b7a055a44c63bfc072b82580811898e177fbb8e Reviewed-on: https://gerrit.libreoffice.org/57628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19tdf#98477 convert to, from, by of AnimScaleContext.Mark Hung
To, from, by of AimScaleContext used to use return value of oox::draingml::GetPointPercent(), which is in 1000th of a percent, but slideshow need ratio to work. Make a conversion here, also fix the obvious error in oox::draingml::GetPointPercent() that y coordinate is always converted incorrectly. Change-Id: I061d2ce89341a4e88f3ffada03954734fafad985 Reviewed-on: https://gerrit.libreoffice.org/57434 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-18Do not force all string results to be recalculated if no style setEike Rathke
Results are forced to recalculate for cells with General format in case they need to inherit a format that then can be set. However, a General format will never lead to some other format being set for any string results and almost all string result cells will have General format because the string is already what is being displayed. So for formula cells with a string result available do not allow to use ScFormulaCell::SetNeedNumberFormat() forcing the need to recalculate. This popped up during intercepting for tdf#118735 when the formula cell containing a WEBSERVICE() call is set dirty, through CompileXMLHandler::operator()(...) if (pCell->NeedsNumberFormat()) pCell->SetDirtyVar(); Which again, as WEBSERVICE() has to be recalculated to populate the link manager, made it necessary to add that to ScRecalcMode::ONLOAD_LENIENT (which it should already had been before (when that was ONLOAD), but no harm in this case). Change-Id: I0dc2cdfe35c56d9843f0edd24a6d14e3de79f7ef Reviewed-on: https://gerrit.libreoffice.org/57700 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-18Allow the comphelper threadpool to be reset after construction.Michael Meeks
Otherwise some pre-init components can start it, and threads get stranded in the forkit process causing grief. Change-Id: Ib1846f8b329b4c6b84645999dafba1252c5129c7 Reviewed-on: https://gerrit.libreoffice.org/57631 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-18tdf#118579 ignore body in body instead of flagging as an errorCaolán McNamara
Change-Id: Ie6626a320a5264aea004f7c57244643798703de8 Reviewed-on: https://gerrit.libreoffice.org/57652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Resolves: tdf#118802 map GTK_RESPONSE_DELETE_EVENT to RET_CANCELCaolán McNamara
Change-Id: I8285f329e4672c90f47d96ccffe60c21c565dde7 Reviewed-on: https://gerrit.libreoffice.org/57655 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Related: tdf#118735 WEBSERVICE preserve the hybrid string result, if possibleEike Rathke
Possible only for constant literal URI arguments, as otherwise we wouldn't know whether the hybrid string result actually matches the call, and possible only for the very first recalc as the hybrid string result will be replaced by the calculated result. However, executing an initial recalc is necessary to add the (then determined and maybe calculated) URI to the link manager after having loaded a document. Change-Id: I67738c13ecce54b43ebb52ea8a8282aebee5f03a Reviewed-on: https://gerrit.libreoffice.org/57696 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-18tdf#118528 sw layout: only direct formatting for EmulateTableKeepJustin Luth
Emulating MSWord's way of keeping a table with the next paragraph has caused a few complaints, but never anything that seemed to clearly indicate a real problem - usually just badly designed documents. But a common theme has been the keep attribute coming through styles. Since our export-emulation writes directly to the paragraph properties, lets make the emulation dependent on direct formatting to avoid some of these complaints. Change-Id: I008fc7b6a7083292463c20972ad209761ec97601 Reviewed-on: https://gerrit.libreoffice.org/57613 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-18Resolves: tdf#118562 set correct help button placementCaolán McNamara
Change-Id: Ia7e5a5ba549c5824b43b36e6b3350b4b5f6c9118 Reviewed-on: https://gerrit.libreoffice.org/57657 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-18uitest Calc - key F4Zdeněk Crhonek
Change-Id: I3c16c41a797b219811d37bbae97f7b176bb5782e Reviewed-on: https://gerrit.libreoffice.org/57650 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-18Related: rhbz#1602589 copy_paste_error: 'global_image_list'Caolán McNamara
Change-Id: I4151819d5c628a85f487f7d9a8358e92553aaf03 Reviewed-on: https://gerrit.libreoffice.org/57639 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18sw HTML export: force PNG output harder in reqif modeMiklos Vajna
Need to disable one more flag to avoid GIF for transparent images. Also start asserting reqif-xhtml output with an XML parser. Change-Id: I1395812a5ddfd56cee4acacf6dea46c6e413b736 Reviewed-on: https://gerrit.libreoffice.org/57630 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-18lokdialog: no invalidation when in init showPranav Kant
This improves LOK dialog opening time considerably. libreofficekit/tilebench results: Before: profile run: initialization - 346.5185(ms) load document - 2162.5881(ms) open dialog - 7077.8980(ms) wait for dialog - 52.7742(ms) render dialog - 256.9597(ms) post close dialog - 523.7811(ms) destroy document - 58.3723(ms) Total: 10.4789(s) After: profile run: initialization - 336.5867(ms) load document - 2155.5481(ms) open dialog - 1151.4130(ms) wait for dialog - 51.5332(ms) render dialog - 260.3197(ms) post close dialog - 519.8729(ms) destroy document - 56.7322(ms) Total: 4.5320(s) Change-Id: I6345aca33c5881aba33c8a5f74765b99fe098711 Reviewed-on: https://gerrit.libreoffice.org/57561 Tested-by: Jenkins Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-07-18Related: rhbz#1602589 null_check 'guiRow'Caolán McNamara
Change-Id: I0c93e6a721646363e5b71ec0e9db6199e7cce006 Reviewed-on: https://gerrit.libreoffice.org/57641 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18tdf#104277 - Added restart buttons to OpenCL restart dialogNickson Thanda
Change-Id: Icf31d0516deb7844c8be1003219cbacae1cdc5ec Reviewed-on: https://gerrit.libreoffice.org/57537 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-18tdf#112261 - Recent characters are now fixed widthNickson Thanda
Change-Id: I4a36e4e2e76fc2935c57b00b5f47d33c15b557d1 Reviewed-on: https://gerrit.libreoffice.org/57558 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-18Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I73ea0f836852dc40c81f167d409ca0294100676e Reviewed-on: https://gerrit.libreoffice.org/57610 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-18Access2Base - tdf#118680 Fix VARCHAR_IGNORECASE errorJean-Pierre Ledure
Precision property of com.sun.star.sdbcx.Column service is set to the maximum length for VARCHAR database fields while it remains at 0 for VARCHAR_IGNORECASE fields. Access2Base reported erroneously an overflow error.
2018-07-18Related: rhbz#1602589 dead_error_line: Execution cannot reach this statementCaolán McNamara
Change-Id: If0e4ea982ede92d564aafb247c789cc6cc3013ca Reviewed-on: https://gerrit.libreoffice.org/57638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Resolves: tdf#118520 insert sheet list not horizontally expandedCaolán McNamara
Change-Id: I0004602631fb82ed13d925a1911ea4ada544462d Reviewed-on: https://gerrit.libreoffice.org/57632 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' - Related: rhbz#1602589 unreachable code Change-Id: I420ed94f178dcdb7bbaba6078b7b3c6730053a34 Reviewed-on: https://gerrit.libreoffice.org/57647 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Related: rhbz#1602589 copy_paste_error: 'getKeyTimes'Caolán McNamara
Change-Id: I2b48d8c75af42429ce41a8f809fc3ac82cb354de Reviewed-on: https://gerrit.libreoffice.org/57636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18tdf#118355 Repl Default / Text Body in Style menuOlivier Hallot
Replace Default Paragraph Style by Text Body, as justified in bug report. Change-Id: Idca1bf437af7d3df838b65bf9991f08e18260c85 Reviewed-on: https://gerrit.libreoffice.org/56709 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-18tdf#118354 Do not dereference non-exsisting ObjectArmin Le Grand
Change-Id: Ie7323302f3b29dfc19b26e2185321c2e609cab2b Reviewed-on: https://gerrit.libreoffice.org/57629 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-18crashtesting: infinite recurse on moz330387-6.svgCaolán McNamara
Change-Id: I3c39d49504a4651b92f41c07e4cef8887366dc2b Reviewed-on: https://gerrit.libreoffice.org/57626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18tdf#118806 sd: specify the motion path origin for pptx.Mark Hung
Motion path animation created by Impress always take the position of the shape as the origin, so set origin=layout. Change-Id: I8b4b579f3a2fc282b41a68c4c8d7573d01ad1aa9 Reviewed-on: https://gerrit.libreoffice.org/57583 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-18tdf#118768 fix pptx export of put on the brake animation.Mark Hung
1. Convert to, by, from based on attribute name for Animate. 2. Export auto reverse (autoRev) attribute. Change-Id: I11ae9997de29a5b0992889eed2eb58d48d81fbb5 Reviewed-on: https://gerrit.libreoffice.org/57554 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-18sw HTML export: fix writing transparent imagesMiklos Vajna
It is possible ImpGraphic::ImplSetPrepared() should handle this directly, though. Change-Id: I1a020a45eaded140493d7207f8e0e0dfe551cc88 Reviewed-on: https://gerrit.libreoffice.org/57623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-18Fix typosAndrea Gelmini
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-18tdf#118521 unit test for DOCX import: fix paragraph margin from styleLászló Németh
Change-Id: Ifa9d3803ab6440544a027bf35367e3c25faf1fd3 Reviewed-on: https://gerrit.libreoffice.org/57620 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-07-18only ellipize menubutton label when requesting narrower sizeCaolán McNamara
Change-Id: I32f4856756910ec1db8d37854b6e57dbec5aae76 Reviewed-on: https://gerrit.libreoffice.org/57617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Resolves: tdf#118604 only use popover workaround for popovers, not menusCaolán McNamara
Change-Id: I7982a3836fbf699979beaa70e34bfa38aea80462 Reviewed-on: https://gerrit.libreoffice.org/57615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Related: tdf#117016 DoubleRefToVars: always put in orderEike Rathke
... as all callers expect, whatever dynamic range creating process may have created it. Change-Id: I47b2e174d5bf4d5c23f10685526b48eee07dd6a4 Reviewed-on: https://gerrit.libreoffice.org/57567 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-18tdf#118139 Set Default StyleSheet only when availableArmin Le Grand
Change-Id: Id8643895add3181c41737249326bb49e1a2c2493 Reviewed-on: https://gerrit.libreoffice.org/57582 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-18sw: Change m_KashidaInvalid to std::unordered_setTakeshi Abe
... for clarifying what is supposed to do, and doing it more efficiently. Actually this assumes that m_KashidaInvalid has no duplicate entries, which I think is humble and sane. Change-Id: I010d3d9788378b369b5b52a37a3824c8e415c2aa Reviewed-on: https://gerrit.libreoffice.org/57611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-18configure: diagnose and report cygpath convert failureVasily Melenchuk
If Windows machine has short filenames disabled, it is not reported during configure run, but leads to unexpected and difficult to understand failures later. Checking of cygpath call conversion result should help to diagnose this problem earlier. Change-Id: Ia93ae612f4bc624bc3e71c6733838fd14b075f64 Reviewed-on: https://gerrit.libreoffice.org/57608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-18Removed duplicated includeAndrea Gelmini
Change-Id: I671c16a16b32622559b2809c3df717706653a78a Reviewed-on: https://gerrit.libreoffice.org/57594 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-18Removed executable permission on pptx fileAndrea Gelmini
Change-Id: Ia58efd31de16ab00cfe763c674b7870c1270dcfd Reviewed-on: https://gerrit.libreoffice.org/57236 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-18Removed executable permission on doc fileAndrea Gelmini
Change-Id: Ie70c103ddc2d7e939db69591e84cadc238fd19c3 Reviewed-on: https://gerrit.libreoffice.org/57596 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-18Removed duplicated includeAndrea Gelmini
Change-Id: I5e3b08470db04db80238543a385fddd15708ba05 Reviewed-on: https://gerrit.libreoffice.org/57595 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-18Fix typosAndrea Gelmini
Change-Id: I563ea72a1e3870f5c362527f018c6b63607b4011 Reviewed-on: https://gerrit.libreoffice.org/57597 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-18No parent-child relationship between Qt5WidgetsKatarina Behrens
QWidget destructor always deletes all its children, which is fatal in case not-yet-deleted frame (e.g. because it's in lazy delete queue) points to one of those children There's parent-child relationships between the frames though, so perhaps no need to have it double. For native modality this seems enough Change-Id: I556ace8d7949bcdfb208170cc08181ac1f2622e8 Reviewed-on: https://gerrit.libreoffice.org/57560 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-18Elementary icons: sync with colibre iconsandreas kainz
Change-Id: Ie9f8c28d663b70ff01760e3f2c82b0a80eab5449 Reviewed-on: https://gerrit.libreoffice.org/57464 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-18Resolves: tdf#118302 drag n drop to same tab should cancel dndCaolán McNamara
dropComplete is used to do this, follow the mac pattern here to propogate this in the drag and drop from self to self case. Maybe this also affects tdf#105320 ? Change-Id: I2b8f8b0e0486f6ee45a65918fae2537750a75f2d Reviewed-on: https://gerrit.libreoffice.org/57589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18tdf#118651 OOXML ActiveX textbox: fix multiline supportBalazs Varga
of textfield component in DOCX/PPTX by handling properties AX_FLAGS_MULTILINE and AX_FLAGS_WORDWRAP during the import and export. Both of them need to be enabled to get multiline textfield in MSO, but LibreOffice has got only one multiline property. With this fix, LibreOffice imports only really multiline textfields as multiline, and it doesn't export multiline textfields as single line anymore. Change-Id: I9b567c3fcdc5d01a5838a3ec2517579f8d788954 Reviewed-on: https://gerrit.libreoffice.org/57552 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-07-18pdfium: update to 3471Miklos Vajna
Allows dropping 4 API patches + the one that allows building against system ICU. Change-Id: Ib5c63ba7daf51b320c07b24486f7398bf71bcfbf Reviewed-on: https://gerrit.libreoffice.org/57588 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-18tdf#118521 DOCX import: fix paragraph margin from paragraph styleLászló Németh
when the other (top or bottom) margin was set by direct formatting. Change-Id: Ic4038397329374fb2d6cf974751310f7dd8e8b31 Reviewed-on: https://gerrit.libreoffice.org/57585 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-07-18tdf#79878 perf loading docx file, use XMultiPropertySetNoel Grandin
because the property setting code in sw/ is surprisingly expensive Change-Id: Id9caa735f77539484993a8f16082cff588a9763a Reviewed-on: https://gerrit.libreoffice.org/57569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-18loplugin:mergeclasses merge IFormulaToken into FormulaTokenNoel Grandin
Change-Id: I5dbf870ff27f1039e24f4350787cf5bfc5f4ccaf Reviewed-on: https://gerrit.libreoffice.org/57487 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-18related tdf#63561 docx: styles inherit tabstops tooJustin Luth
Add import and export support for style-parent tabstop inheritance. This patch is dependent on GetPropertyFromStyleSheet commit 39171b82b245a7589b9258337a18d6dd281f8ed2 Change-Id: I0245d0e08f140b6cb473c96cffa6f5a4ceff8944 Reviewed-on: https://gerrit.libreoffice.org/57278 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
generated by cgit (git 2.34.1) at 2024-12-27 07:25:39 +0000