summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-08ofz#4106 Integer-overflowCaolán McNamara
Change-Id: I91109f652bc032811ade350b77d30424b5764ad8 Reviewed-on: https://gerrit.libreoffice.org/44449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08ScImportStarCalc10 appears uncallableCaolán McNamara
I can't see a mention of "StarCalc 1.0" anywhere in our code which might appear here as a filtername last mention of something like it is... commit cf8f6fe1f9d65eedbc6f4d65ce0fa88831830966 Author: Michael Stahl <mstahl@redhat.com> Date: Tue Feb 5 15:49:26 2013 +0100 officecfg: remove references to binfilter formats Change-Id: Ia6f9ab89489e33ca3680c150fd896035b8dee491 Reviewed-on: https://gerrit.libreoffice.org/44426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-08ofz#4113 Null-dereference READCaolán McNamara
Change-Id: If586bd265e323b5c2a308c2e853456c2778e8cb0 Reviewed-on: https://gerrit.libreoffice.org/44448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08Fix loplugin:flatten's skipping of if/then/else/if chainsStephan Bergmann
(but which finds no new hits) Change-Id: I5d5f351402797b662a08ec8dca301bd174e22a50 Reviewed-on: https://gerrit.libreoffice.org/44433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-08Remove sgf and sgv graphic types from sorted filter listSamuel Mehrbrodt
After removal of the importer with d952c0b42a452c875bd9d78870fa9d925af9220e Change-Id: I1a5a99edba4c9bf4c22726255a7c156a7ddd6508 Reviewed-on: https://gerrit.libreoffice.org/44445 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-08Remove sgv and sgf graphic types from supported graphicsSamuel Mehrbrodt
After removal of the importer with d952c0b42a452c875bd9d78870fa9d925af9220e Change-Id: Ib6d20d00417807038051f187e4ba76e70576082e Reviewed-on: https://gerrit.libreoffice.org/44444 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-08SwXFlatParagraph: check some positions before blindly using themMichael Stahl
Change-Id: Ic33b7a4b87120bd01b56737ded0411651306098d
2017-11-08sw: document SwRectFnCollection instancesMiklos Vajna
GCC would allow these to be non-comments according to <https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html#Designated-Inits>, but still have them as comments for the sake of other compilers. Change-Id: I4e615a41062edcc563b109753af8c2c457ee4503 Reviewed-on: https://gerrit.libreoffice.org/44443 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-08Remove obsolete "lo_warn_unused" workaroundStephan Bergmann
Per README.md, Clang 3.4 is the baseline for --enable-compiler-plugins, which is the sole consumer of the "lo_warn_unused" attribute, but Clang 3.4 already supports HAVE_GCC_ATTRIBUTE_WARN_UNUSED. Change-Id: I9654028e24852335e463c73bcb5ece5e5b54d53c
2017-11-08ofz speed up fuzzers a tadCaolán McNamara
Change-Id: I4ed35408e3640d2b141218599cd895c09da1e2b0 Reviewed-on: https://gerrit.libreoffice.org/44427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08tdf#100922 Refactor Custom Properties pageSzymon Kłos
This commit solves problems with big number of entries. Window is loaded quickly and is responsive even with over a thousand custom properties. Change-Id: I4745c69aaff95661ca930e303ab65591e374a24d Reviewed-on: https://gerrit.libreoffice.org/44429 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-08Updated coreGabor Kelemen
Project: help 7124828a1dd1673fb5bb336e22de7c35cc1f6e30 Display extended help on the Comment icon of Track Changes toolbar Change-Id: Iba16420bd5c9571a47158359510d8f2dc21ed539 Reviewed-on: https://gerrit.libreoffice.org/44439 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-08Updated coreGabor Kelemen
Project: help 74289f5c5ffbdf2465cf02b4d1b3462586f978de Display extended help on the Accept/Reject icons of Track Changes toolbar Change-Id: Ibca18b76f3ff31e490298d4dc49e4f03d35a2c18 Reviewed-on: https://gerrit.libreoffice.org/44438 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-08Updated coreGabor Kelemen
Project: help e3dd69c6ef93f546baa7ee3d6ea942377824f176 Display extended help on the Manage icon of Track Changes toolbar Change-Id: I9c7bfad34cb4898b549e134c53c73b2d87f00b20 Reviewed-on: https://gerrit.libreoffice.org/44437 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-08Updated coreGabor Kelemen
Project: help 54aa6a20dade54079a3051910afb3e6c2d11a41d Display extended help on the Record icon of Track Changes toolbar Change-Id: I64001b95c4db0e782b3456212ef5ebfd757bb2b6 Reviewed-on: https://gerrit.libreoffice.org/44436 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-08Updated coreGabor Kelemen
Project: help b43fe3c9ec7be8a5cb2679a1091c123bf46a0380 Display extended help on the Show icon of Track Changes toolbar Change-Id: I4d6f02057bd127150718742b19a50635f6b9bd82 Reviewed-on: https://gerrit.libreoffice.org/44435 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-08upload libxml2 2.9.7David Tardon
Change-Id: I3f72ec938c87e0c0d30a91b32d96fedf5379207f Reviewed-on: https://gerrit.libreoffice.org/44423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-11-08upload libxslt 1.1.32David Tardon
Change-Id: Idee2f18dccdf309027142137683ac86735f575cc Reviewed-on: https://gerrit.libreoffice.org/44422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-11-08upload libstaroffice 0.0.5David Tardon
Change-Id: I43fcd4b7daf6fb2a035bcd34ac7a46624155e8ba Reviewed-on: https://gerrit.libreoffice.org/44420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-11-08tdf#108916: uno:LanguageStatus shouldn't appear in the customize dialogMuhammet Kara
Change-Id: Ifa10f8c2510cada1835d052977690ace1d95bfd2 Reviewed-on: https://gerrit.libreoffice.org/44394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-11-08Updated coreGabor Kelemen
Project: help 143df3bd10246dd67135f097ef080d429df8b927 Display extended help on the Spelling icon of Standard toolbar Change-Id: I58cbd06ddf9ef81d5a1b82abc4c3dbbe55569e85 Reviewed-on: https://gerrit.libreoffice.org/44434 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-08TSCP: Fix crash when no header/footer is present yetTomaž Vajngerl
Change-Id: I681920347e01ccbc1e18348d00c1e29dac5a8e64 Reviewed-on: https://gerrit.libreoffice.org/44441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-08Suppress loplugin:unnecessaryoverride...Stephan Bergmann
...when a class derives from multiple (non-virtual) instances of one base class, and the override disambiguates which of those instances' member to call. That was the case with SwXTextDocument::queryAdapter (sw/source/uibase/uno/unotxdoc.cxx), where SwXTextDocument derives from cppu::OWeakObject through both SwXTextDocumentBaseClass and SfxBaseModel, but calling queryAdapter through a pointer to SwXTextDocumentBaseClass apparently needs to call OWeakObject::queryAdapter on the second, SfxBaseModel-inherited OWeakObject base instance, or else CppunitTest_sw_macros_test fails. Who knows what other instances of similar non-unnecessary overrides have been removed with the help of broken loplugin:unnecessaryoverride, for which there were no tests that started to fail... Turns out .clang-format lacked "ReflowComments: false" to not break the special "// expected-error {{...}}" etc. comments in compilerplugins/clang/test/. Also, use a better location to report loplugin:unnecessaryoverride, to keep clang-format and loplugin:unnecessaryoverride from fighting over how to split lines and where to put the comment in compilerplugins/clang/test/unnecessaryoverride.cxx. Change-Id: I3b24df24369db12f8ec1080d6c9f7b70ff561a16 Reviewed-on: https://gerrit.libreoffice.org/44418 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-08Replace list by vector for ScMyToFixupOLEs (sc)Julien Nabet
Change-Id: I053e989f2c27ad09986e86df0a18d9ae6e05c160 Reviewed-on: https://gerrit.libreoffice.org/44440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-08sw lok: add Accept/Reject All tracked changes, tdf#101977Henry Castro
Change-Id: I04d747343e24cb498a621c965d034d0791411d83 Reviewed-on: https://gerrit.libreoffice.org/44311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-11-08Elementary update icon themeandreas kainz
Change-Id: Ib5ca83bb59e347f912a7876876a69b63662222fb Reviewed-on: https://gerrit.libreoffice.org/44428 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2017-11-07Why was this left out of unittest-failed-MACOSX.shStephan Bergmann
Change-Id: If32981329e79745d5497c3f63bfd227dc75f2ab3
2017-11-07ofz 1-2-3 mem leakCaolán McNamara
Change-Id: I72b633b27578815fb0951e2bfac755fce51203f1 Reviewed-on: https://gerrit.libreoffice.org/44400 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-07Resolves: rhbz#1505379 gtk3+X: open comboboxes block sessionCaolán McNamara
if there's none of our windows under the mouse when clicked then close the popup window. There's similar code for gtk2, but using deprecated apis, do this again but with the recommended apis Change-Id: I9d844d098d09d0109dcbbc06390562e83edda397 Reviewed-on: https://gerrit.libreoffice.org/44402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-07Fix harfbuzz font lifecycle in CommonSalLayoutJan-Marek Glogowski
The harfbuzz font is attached to the system font face and therefore inherits its lifecycle. This means it can be used in multiple CommonSalLayout objects, so the user data parameter of hb_face_create_for_tables can't be the layout, but must be the font. This moves the special Qt5Font handling into it's own function, so accessing the switching parameter mbUseQt5 is not needed. Regression from commit b66a7cbd8491fe436126e11975c360f47ae346ed. Change-Id: Ic34cc5b60e401562c73b239a58176a59fe4bf9be Reviewed-on: https://gerrit.libreoffice.org/44398 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-07Augment LibreOffice.natvisMike Kaganski
Change-Id: Id9c3e270db2ff8e36d18efe3221b8f1c01a2fcc1 Reviewed-on: https://gerrit.libreoffice.org/44419 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-07add 1-2-3 fuzzerCaolán McNamara
Change-Id: I74ab2c0d36b619fa3b7ed6d52129264930ea9553 Reviewed-on: https://gerrit.libreoffice.org/44368 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-07Remove obsolete commentStephan Bergmann
...that should have been removed in 2446d2b2fb8b091eaae015fd5bb26bd8e0f596f7 "Avoid expensive calls to containsPreprocessingConditionalInclusion" Change-Id: I2ffe0ec7b6f1ec0b418979f2864bd5de79ab2c9a
2017-11-07ofz#4066 Bad-castCaolán McNamara
and a cluster of others around here. This pRedl has been deleted at this point. This doesn't matter for most users, seeing as !LibreOfficeKit::isActive() is the usual case so the deleted pRedl isn't fully accesssed. Because the deleted pRedl won't be found in GetRedlineTable when deleted, rework this a little to avoid the problem. Change-Id: I5c2f405cdae0b0c804ee7452629a14206516962d Reviewed-on: https://gerrit.libreoffice.org/44390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-07correct labeling of open/save remote in menuYousuf Philips
Change-Id: Idbc58a2e49d4761477eb45fb3a08a641d9bda055 Reviewed-on: https://gerrit.libreoffice.org/44208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-07Access2Base - Insert Window argument in CommandBars collectionJean-Pierre Ledure
Window argument forces the determination of the window in which toolbars are searched for. This argument is not part of the standard MSAccess API => Unpublished
2017-11-07LimitRangeToAvailableSheets: check ValidTab() firstEike Rathke
That already includes BCA_LISTEN_ALWAYS which only needs to be checked if the ordinary tab check failed in case the definition changed. Change-Id: Ic31daf67f600b48b76406f07ba039462c5944170
2017-11-07tdf#31231: properly check for SvXMLImportFlags::ALLMike Kaganski
A regression from commit dc28e90d200a839d4017d548217ee5ce8a23f84 Change-Id: I8982522d16d8335b1bb3522076030a023c0c297f Reviewed-on: https://gerrit.libreoffice.org/44396 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-07fix !HAVE_FEATURE_PDFIUM buildCaolán McNamara
Change-Id: Ied661aafbaf9d85b01ef57e83bbacd9f9a828f2b
2017-11-07tdf#113686 sw: handle sections when counting height of first content lineMiklos Vajna
When moving back a row that has a single text frame, it should not matter if that text frame is in a section frame or not. The problem was that the bugdoc has a split (outer) table, the follow's ShouldBwdMoved() returned false, as SwTabFrame::CalcHeightOfFirstContentLine() returned USHRT_MAX, as it had no idea how to calc the height of a text frame in a section frame. Fix this by looking "through" the section frame, and handling "text frame" and "text frame in section frame" the same way. Change-Id: Ic3605a1e2d28bfaa69bf18f31cfbf1e6e681c04f Reviewed-on: https://gerrit.libreoffice.org/44393 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-07QT5 initial keyboard supportJan-Marek Glogowski
No idea, if we can / should map those vendor specific keys, like Gtk+ does. This also prefixes the non-virtual functions with "handle". Change-Id: Id8c42651e07d33728ff6deced06a82de29aa3fad
2017-11-07QT5 queue paint update on showJan-Marek Glogowski
Something like gtk_widget_set_redraw_on_allocate. On resize of dialogs, we still get artefacts, but at least you see something without forcing an event. And since there isn't any Qt5 theming yet, we let VCL paint the menus with a border. Change-Id: Ia2ff6b199ee25e481e3fb29a921b0d3d490f1535
2017-11-07tdf#112770 Filter input on the correct windowJan-Marek Glogowski
This filters the input event on the correct window in SalX11Display::Dispatch. I'm not sure there is a point of skipping the filter for input events, which are not on our windows, as we already filter all non-key input events. Has been like that in the initial import, but whi knows what input methods do with different events... After reviewing the original "Unify SalUserEvent handling" commit e310c00709ed4fe0788aeff5142e3581d8b4d319, I found two more places, which now have handled user events wrong and fixed them. Change-Id: I50a60f6dacc3f795e659b6fbfd107548d07a3341 Reviewed-on: https://gerrit.libreoffice.org/44371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-11-07Updated coreGabor Kelemen
Project: help 8ee909099c5cfa878f9c36adee031dcea84a5a4d Terminology change: Non-printing Characters -> Formatting Marks This change happened in the toolbar/menu in commit 37ad8daabf596e039b4ca62e06e91d5a83128b7c Change-Id: Icde87814ecc559b461ec9233186137161eda3a30 Reviewed-on: https://gerrit.libreoffice.org/44383 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-07Avoid expensive calls to containsPreprocessingConditionalInclusionStephan Bergmann
Change-Id: I42981a23f75298591b2c3b073aea66426220f3e2
2017-11-07sfx2: SfxInPlaceClientList is just a std::vectorTakeshi Abe
Change-Id: I6b676d17d9592a0ca998cdafb25b1aa12e11b6d6 Reviewed-on: https://gerrit.libreoffice.org/44384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-07loplugin:constparams in sdNoel Grandin
Change-Id: Id4b68ca0509111396ed354f4cda43d663083cad0 Reviewed-on: https://gerrit.libreoffice.org/44388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-07Clean away temporarily added using declarationsStephan Bergmann
Change-Id: I26734c13515394162d88351a1cbe2b20abdac865
2017-11-07Memoize ignoreLocation resultsStephan Bergmann
...which, according to callgrind, reduces instruction fetch count spent on compiling sw/source/core/layout/paintfrm.cxx (randomly selected because it is rather large) by 5% from 41,992,064,226 to 39,861,989,855 (function main() in clang-6.0). This is best done by forwarding ignoreLocation calls from Plugin to the PluginHandler signleton, but due to the tight mutual coupling between plugin.hxx and pluginhandler.hxx that unfortunately required some reorganization (and two outstanding TODO clean-ups of temporarily introduced using declarations in plugin.hxx). Change-Id: Ia4270517d194def7db7ed80cb6894e9c473e9499
2017-11-07test: avoid 'using namespace' declarations in a headerMiklos Vajna
Change-Id: I8dc06129360124fcaa52bc13bb9d134918b84c17
generated by cgit (git 2.34.1) at 2025-01-19 12:59:15 +0000