summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-23tdf#153806 a11y Allow opening context menu of fav/recent char w/ keyboardMichael Weghorn
This is similar to commit 1f437264084fd173116965fa4d856aeafdfe7a98 Date: Sun Apr 2 00:36:44 2023 +0300 tdf#153806 a11y: Allow opening context menu in special char dlg using keyboard , but now for the character views in the "Recent Characters" and "Favorite Characters" sections in the special character dialog, and thus addresses this comment from the commit message of the above-mentioned commit: > Adding support for opening the context menu for the > recently used and favorite characters further down > in the special characters dialog is independent of this > and would have to be added separately. Turns out that the position returned by `CommandEvent::GetMousePosPixel` is good for the keyboard case as well, is right in the middle of the char view widget. Change-Id: I9f55b99398d557b19263bf531f6a857d274d3d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150815 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-23sfx2: Pass SvxCharView context menu pos as paramMichael Weghorn
... and drop the `maPosition` member that was used for that purpose only. Change-Id: If449a12e6e8e37c28d7b2b139e20c4c307d41eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150814 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-23tdf#97128 tdf#154703 docx export framePr: export frame textDirectionJustin Luth
textDirection attributes were lost on framePr round-tripping No existing unit tests were affected by/matched the change. make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf154703_framePrTextDirection Change-Id: I2184b9350391f510c7a2e77096b080e05d3d62da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150820 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-22tdf#154957 Revert "use OutputDevice clipping if its just a set of rectangles"Caolán McNamara
it was an attempt at an optimization, but if it doesn't work just revert it. The non-antialias case also doesn't work so the reverted commit wasn't itself the problem but the existing path has some flaw I'm not going to invest in figuring out. This reverts commit ee0d5e7bb8614c50e71dd074b8440f412eb62ff3. Change-Id: I8d4f126e3bfe135d39a085f28cea6708ae8f833f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150773 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-22Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 6c4c5275e8d0d3bf5e590b4093b8bcc67b4d521e - Fix typo Change-Id: Ib11ff464bc2ce261aeefaa632a6fc8d3f51e6cd6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150806 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-22Simplify lcl_getURLFromShellItemMike Kaganski
And make the URL returned for the item by system to be the preferred result. Change-Id: Ifbe8acc0aef8d656526d1ae64010fb6bfa68eefc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150784 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-22Introduce sal::systools::CoTaskMemAllocated to use RAII for CoTaskMemFreeMike Kaganski
Change-Id: I5553138bfc8dd989e68b8bcc2be981746e8c1e84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150783 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-22Drop some defines in scaddinsMike Kaganski
Change-Id: I6155ad1c9e4627aad65ae1884e03491902c5d8a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150780 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-22NFC flatten/clang-format SwTabFrame::CalcFlyOffsetsJustin Luth
No functional change intended Change-Id: I63a052ad39e7f90a744225d06cc4000ac6fdd602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149466 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-22Introduce o3tl::toU converting wstring_view to u16string_viewMike Kaganski
Change-Id: I5be9aa767020c2516984e47fcd0f51d4661fdf17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150779 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-22clang-format char16_t2wchar_t.hxxMike Kaganski
Change-Id: I5b86fb372702e3a6fdb3e4aa6846c4bc2e754307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150778 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-22Fix typo in codeAndrea Gelmini
Change-Id: Iba5e188204fafa4cd88282d001eea31f277fcc4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150768 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 8c0b0a8e0aad857b7089883f7c4fabbe8d9d64de - tdf#147105 Document the various new PDF export options in command-line Change-Id: Id89e27738d34322e7bab870a5fd247f988be76a4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150797 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 5dfb463b6d96f4c2077d9565628d5674ec340550 - Improve links between pages classification Change-Id: Ica92e7a69556c15aaf1a77ac6979df214b41672a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150765 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-22qt a11y: Implement QAccessibleSelectionInterface added in Qt 6.5Michael Weghorn
This adds an implementation of the `QAccessibleSelectionInterface` that was added in Qt 6.5 in commit [1] commit 9d16d5e2245c26e5746fd7609300b84a2a983457 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Oct 11 15:23:54 2022 +0200 a11y: Add new QAccessibleSelectionInterface , s.a. QTBUG-105909 [2]. The `QAccessibleSelectionInterface` is currently still marked as preliminary in Qt, so changes to the API *might* still happen and require an update of the implementation here as well). Quoting from the commit message of the above commit: > This interface is marked \preliminary until: > > 1. There is a working a11y bridge for macOS/VoiceOver > 2. There is a working a11y bridge for Windows/UI Automation > 3. There is a working a11y bridge for linux/AT-SPI > 4. There is at least one implementation (e.g. QAccessibleTable) > that implements it successfully (second candidate: > Qt Quick TableView [...]) The AT-SPI bridge (point 3 from above) has been implemented in [3] commit ece2feee0317b582a56a0bfc783f11fe67d3edee Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Oct 11 15:24:04 2022 +0200 a11y atspi: Bridge newly introduced QAccessibleSelectionInterface , an implementation for `QAccessibleTable` (point 4 from above) was added in [4] commit 092bbc9ad30c6cd7389053dc4b332cc762693676 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Oct 12 07:07:48 2022 +0200 a11y: Implement QAccessibleSelectionInterface for item views . The Qt Gerrit changes for the macOS implementation (point 1 from above) and the Windows/UIA implementation (point 2 from above) are currently still awaiting review: [5] [6] To avoid duplication, just call the newly added methods `QtAccessibleWidget::selectedItemCount` and `QtAccessibleWidget::selectedItem` from the `QAccessibleTableInterface` methods `QtAccessibleWidget::selectedCellCount` and and `QtAccessibleWidget::selectedCells`, and therefore implement the former also for Qt < 6.5. Sample use of the interface from Accerciser's IPython console (with 18 cells selected in Calc and the spreadsheet object selected in Accerciser's a11y object tree; screencast attached to QTBUG-105909 [2]): In [10]: acc.get_interfaces() Out[10]: ['Accessible', 'Component', 'Selection', 'Table'] In [11]: sel = acc.querySelection() In [12]: sel.nSelectedChildren Out[12]: 18 In [13]: sel.getSelectedChild(0).name Out[13]: 'B1' In [14]: sel.deselectSelectedChild(1) Out[14]: True In [15]: sel.deselectChild(1) Out[15]: True In [16]: sel.selectChild(0) Out[16]: True In [17]: sel.clearSelection() Out[17]: True In [18]: sel.selectAll() Out[18]: True [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=9d16d5e2245c26e5746fd7609300b84a2a983457 [2] https://bugreports.qt.io/browse/QTBUG-105909 [3] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=ece2feee0317b582a56a0bfc783f11fe67d3edee [4] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=092bbc9ad30c6cd7389053dc4b332cc762693676 [5] https://codereview.qt-project.org/c/qt/qtbase/+/451353 [6] https://codereview.qt-project.org/c/qt/qtbase/+/451646 Change-Id: Iac3c050448183610af3bd3b10a56e82d7d52cb91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138750 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-22Fix typoAndrea Gelmini
Change-Id: I59aea5a7b71d6ddf14d4d7d22b61bdc8ab01ae3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150767 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-22Fix typoAndrea Gelmini
Change-Id: I943dbf7dd8c6ac138ab9fc16638a06b07dcace93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150766 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-22Remove namespace prefix in manifest.xml (extras/pt-PT)Julien Nabet
since other languages don't have it Change-Id: I02dead7abcae1409f756d4daebbd23d4a70efbc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150762 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-22Integrate msicreator into LO and generate installerRakielle
Co-authored-by: Ximena Alcaman <alcamanximena@gmail.com> Change-Id: Iea2ea3b4bddc975a032592403727a4ff00db4a5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146843 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-04-22workflows: Update dessant/repo-lockdown to v3Sarthak Roy
* Changelog: https://github.com/dessant/repo-lockdown/blob/master/CHANGELOG.md#300-2022-12-04 Change-Id: I7c4f7dc8f97dc59b3d689cf82e23365740c8fd6c Signed-off-by: Sarthak Roy <sarthakroy2002@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147495 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-04-22tdf#154703 sw framePr: export knowing import wrap spacing limitationsJustin Luth
I noticed that the wrap margin spacing was being cut in half each round-trip. That is because MS Word ignores the spacing on LEFT or RIGHT alignment, while LO doesn't. Rather than monkey with layout, import just ignored the spacing. Sounds like a good idea - but needed to do the same on export. make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf154703_framePrWrapSpacing Change-Id: I3878d1bdb98cf027fe95137939caf6901c7188a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150796 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-21tdf#154703 NFC sw framePr: flatten TextBoxIsFramePr and fix typoJustin Luth
Change-Id: I0fd30cb62c3676a1c7088636798bd4e6d3a18c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150071 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-21NFC rename: const table::BorderLine2* rStyleProps (is not a reference)Justin Luth
Added with commit ae61569eea0719a882010cfbb260a1a0d690d974 Author: Jacobo Aragunde Pérez on Thu Apr 3 16:27:37 2014 +0200 oox: Do not overwrite table style properties Change-Id: I8140e3a084f3f1e2d304a4ffc62897afa6427c4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150771 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-21NFC tdf#154703 docx export: optimize/reorder "if TextBoxIsFramePr"Justin Luth
-there is no need to run the long TextBoxIsFramePr function first, so start by evaluating the simple boolean case to avoid unnecessary processing. -reorder if/else to logically start with the small section. By doing so, it highlights that really we are doing something special when TextBoxIsFramePr and the else is the normal for anything else. Change-Id: Ic06826c2b6dcd5d89a6873784eb58b2d7bedaba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150770 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-21Run clang-tidy with misc-unused-using-decls on module xmloffGabor Kelemen
To remove unneeded using declarations. Via the simple script: for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do clang-tidy-12 --checks="-*,misc-unused-using-decls" "$i"; done Change-Id: Iccae38de41c809b39345ec6b31c9f6346e620f53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150611 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-04-21loplugin:unnecessarygetstr extend to checking std::string::c_strNoel Grandin
Change-Id: I17398e2a6a31a2c98ba8e54b5c8045f22aee8759 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-21Resolves: tdf#154941 MROUND() use approxValue of division to roundEike Rathke
Change-Id: I75394b1bdffbdadf051157e84afa06f30126fe23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150764 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-21Resolves: tdf#154535 create the OXFormsDescriptor on-demandCaolán McNamara
so we don't cause an unwanted Binding to be created unless we are forced to. Change-Id: Id78cbbb72ebd4e78b82a1ba614bbcb6488d04ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-21tdf#154546 skip dispatch when presenter controller is not setPatrick Luby
mpPresenterController is sometimes unset and this will cause a crash when pressing the presenter console's Exchange button. Change-Id: Ibfc866d573ce0c535df5c8fdbd6d358353784854 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150456 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-04-21Fix apparent copy/paste typo in implementation nameStephan Bergmann
...introduced in 155c056b1d4674d5ff73bbb5e1ad1dcd1e6aae36 "i18npool: create instances with uno constructors" Change-Id: Ie9094ec5c58aa98cdb379051ecbad80638aae02a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150759 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-21Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entries Change-Id: I4c2a838b7a88e3d21e230310c1a4057b427a7c7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150756 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-21MCGR: Reduce diverse GradientStyle enums to single UNO API oneArmin Le Grand (allotropia)
Change-Id: Ie0cd26a308a75ddead9451c53e874a39cc6eeb63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150705 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-04-21tdf#154578 sc fix: fill square is reduced when pulling selection with CTRLBalazs Varga
Return from DestroyAnchor in case of fill mode, because we should not modify the refmode or blockmode in that case. Change-Id: Id5b4b2207ddd9e1b1d82afc773d2d1b3e97dbbc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150645 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-04-21related tdf#154946: check syntax in git pre-commit hookXisco Fauli
Change-Id: If685f69227f98b194c124af0e28307d31edabf9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150752 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-21tdf#116451: XML Form: adding 2 values of decimal-fields gives wrong resultJulien Nabet
Since, depending of the localization decimal separator may be ",", replace "," by "." before calling ::rtl::math::stringToDouble Change-Id: I461f3bdf83019d066735e10b3b6b6784e006bc7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150750 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2023-04-21SwXShape no longer needs to extend SvtListenerNoel Grandin
after commit 40babcfa637957bf7b59caa3cd12a630189e3e63 tdf#154827 and tdf#154428 graphics anchored in Writer as character. Change-Id: Iad3ad440690fa9b8530f32e17a113b8365656a05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-21sw floattable, crashtesting: fix PDF export of forum-mso-de-117064.docxMiklos Vajna
Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). What happened is that we hit a case in the SwTextFrameBreak ctor where the frame had the "is in section" bit set, but the frame wasn't actually in a section, so when looking up that parent section frame, we found nothing, and later code assumed that we always find something. This is fine, the root of the problem was that in the non-legacy case GetFlyAnchorBottom() assumed the upper of the anchor frame is the body frame, so in case you had a protected section in DOCX, we mapped that into a Writer section, resulting in a body -> section -> anchor frame hierarchy. Fix the problem by improving GetFlyAnchorBottom(), so it works with the body frame of the page (of the anchor), not with the anchor's upper, which breaks in the section case. This only happened in the compatibilityMode=15 case, i.e. DOCX files produced by Word >= 2013. Change-Id: I94ed22701d275e7a9048c6154652d40268850c34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150741 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-21tdf#153839 : Further handling for adding newlinesFranklin Weng
before and after some tags as described in comment 7 Change-Id: I6e2a6559a888d259c6d1cc848fad7d39a1ab653b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149280 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-04-21tdf#154946: Draw/Impress Standard toolbar missing many iconsJulien Nabet
Regression from 4cd7489f5898394730b794bdecbc29800cf23627^!/ "Resolves tdf#143055 - Make Snap-to-grid easier to access Added to page context menu, standard toolbar, and line & filling toolbar" Change-Id: I3d7040f59a3c422e7f596fcd96cde88466bc2a79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150747 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-21ScriptForge (SFDialogs) dialogs and controls are sized in APPFONTsJean-Pierre Ledure
Dimensioning a dialog in the Basic IDE is done by using "Map AppFont" units. Map AppFont units are device and resolution independent. One Map AppFont unit is equal to one eighth of the average character (Systemfont) height and one quarter of the average character width. A dialog or control model also uses AppFont units. While their views use pixels. This is confusing. It also complicates size prototyping with the Basic IDE. In ScriptForge, sizing and positioning a dialog or a control is done from now on in AppFont units as well. Additionally, X and Y positions accept now negative values. Compatibility with past is ensured: dynamic change or position and size is a new feature in 7.6. The change is valid both for Basic and Python user scripts. It requires a small change in the actual documentation (pixels => AppFontunits) Change-Id: Id80b0ccf473eb012b0a8c85d66f5a8ada9b26be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150704 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-04-21Colibre tdf#154825 Section editor iconsRizal Muttaqin
Change-Id: Ia5cb61074d519b68416801ba2268dd11c49284f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150748 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-04-21sw: fix crashtesting assert on fdo44018-2.docMichael Stahl
itrpaint.cxx:435: void SwTextPainter::DrawTextLine(): Assertion `!roTaggedParagraph' failed. The problem is that there are in fact 3 lines with the numbering bullet, which is a problem that existed since LO 4.1, but that only changed the WW8 import so it really exists all the way back to OOo 3.0.1. The SwNumberingPortion is created, then it is cloned for the insertion of the tab, then the 2nd one is deleted (which is expected as it is empty), then due to some ChkFlyUnderflow() SwTextFormatter::FormatLine() resets the m_bNumDone flag and the next line gets another numbering. The m_bNumDone flag must be reset if the numbering portion was deleted, but not otherwise. (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd) Change-Id: I575947fdfb8786ad6d0f9e83636c39eb929a1b06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150709 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-21tdf#153016 sw DOC: don't export automatic redline commentsLászló Németh
DOC format doesn't support comments of change tracking, so DOC export converts them to annotations. But skip this conversion in case of automatic redline comments of tracked annotations ("Commend added" and "Comment deleted") to avoid of double annotations (the original tracked annotation and the newly added annotation of the comment of the change tracking). Regression from commit 3a14b2040ecd95a23acbc3e8d0f8087505135f11 "tdf#148032 sw: add redline comment for tracked comments" Change-Id: I563859d203886a7f81f6a9e1f164ea5524d80d1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150735 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-21tdf#133363 sw DOCX import: remove extra auto space in mixed listCzeber László Ádám
Remove extra auto space even for mixed list styles. For mixed style lists, it has not removed all the extra space needed. See also commit 9cca15204af9cc44a8a9528ccf2f36616fb70e69 "tdf#133052: DOCX import: fix top auto margin of subitems". Change-Id: I15e58616d5810ea57ac9339bdd8e4b5859f09c81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150313 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-21related tdf#154501: pptx import: push cell's RotateAngle after textSarper Akdemir
It appears to matter whether "RotateAngle" property is set before or after insertion of the text for cells. It only renders correctly when it is pushed after the text insertion. RotateAngle appears to end up in the property set either way with correct values, so I don't really know why this is the case. Adds a unit test that covers rendering of vertical text in table cells on import from an example pptx file. Change-Id: Ifb8caa0b74920758fea2815b16dae7fd60587cc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150712 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
2023-04-21tdf#153195 sw RTF import: fix negative indent of table in footerCzeber László Ádám
Fix missing processing of TBLIND keyword, which puts the table in the footer in the correct orientation, applying also the following conversion between RTF and OpenDocument/Writer to avoid regression: Left spacing of the table has different meaning in MSO and Writer. In MSO, left spacing means the indent of the text content of the cells, i.e. if table spacing is 0, the text content of the cells is vertically adjusted to the text content of the table, not to the table border. In Writer, if left table spacing is 0, the table border is vertically adjusted to the page text content. So for the correct conversion, left spacing of the table decreased with the left padding of the table text content during the RTF import. (See table padding on the Borders pane of Table Properties.) Reported and created unit test document by Gábor Kelemen. Change-Id: Ia3a781044a11d012f204a8ac3b160ad4c5dc896a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150022 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-21tdf#154731: Hide Zoom & View Layout dialogBaole Fang
Change-Id: I49f86a858826da39f9dd08580d5ab7796bc397a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150667 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-21Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entry Change-Id: I56ac64be65740450df92f03aac4d2f4f447f08a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150694 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-21sw floatable: teach the RTF export about SwFormatFlySplitMiklos Vajna
Write \nobrkwrptbl unconditionally till we have a layout mode where floating/wrapped tables don't split/break. Change-Id: I0a19d034651a276dde8df391a5f1ca8ae39ddfed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150739 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-21Fix OrcusFormatDetect XServiceInfoStephan Bergmann
Change-Id: I7c54ec6de8c6bd3a5ed67809404eee65aa5af695 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-25 02:49:02 +0000