summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in sdNoel Grandin
Change-Id: I2521bc29afb9ae98d7db2fab81f93264c91c4065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176438 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-12Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 4f83321e274052b64e16dba7b50ddee41db53ab3 - Removed exec bits on PNG files Change-Id: Ib7c4c917bb7a9c661ee1f28b7c4359acdbac767b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176425 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-12Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 1684acfaca19b37db9387f09618dd05cb90048f2 - Removed exec bits on PNG files Change-Id: Iff6b93bc6d36414509c659a220eda6529f0a3f61 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176460 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-12tdf#163486: PVS: simplify while loopXisco Fauli
V654 The condition of loop is always true. Change-Id: I9c7cc133cf197e899ac7e13ee3cedc97b7c4d0be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176406 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in variousNoel Grandin
Change-Id: I1033c33a6b4bf06e365ce183b1a73c98bea777ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in swNoel Grandin
Change-Id: I64342ae8c10738e276702e8ab2c0c0954be25752 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in sfx2Noel Grandin
Change-Id: If818f7b10eb81f8921b5d90fe0c2db4d4ad97ed6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in svxNoel Grandin
Change-Id: I80bdcae1db64f7693600178d86c122c5875369b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12tdf#162753 - Hyperlink dialog: trim leading/trailing whitespaces of URLsAndreas Heinisch
Change-Id: Ic18d30239e8741f8a28e81e423d3dc223d709a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176409 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in ooxNoel Grandin
Change-Id: I9964087880efcf24b5748130cffa2bd85adf1965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12loplugin:reftotemp in scNoel Grandin
Change-Id: Ibd0efec208447d0ad3f5d85354cbfc7d276064af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in reportdesgnNoel Grandin
Change-Id: I00a0db4a3cd23ae757aa894f886f5b5a1a0359f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176435 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in salNoel Grandin
Change-Id: I99d7b71b2e06c5fc016411c369b6e887a274ec4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176436 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 981, 1008 V1037 Two or more case-branches perform the same actions. Check lines: 1018, 1025 Change-Id: Iea6f6edc65490587cb974f6d3baa17d3a337a0c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175217 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 921, 924 V1037 Two or more case-branches perform the same actions. Check lines: 1003, 1160 Change-Id: I42e78f2960b97a67625bfdb524b7f615833332ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175230 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 697, 700 V1037 Two or more case-branches perform the same actions. Check lines: 714, 717 Change-Id: Icb62ded0f40561215abb2bbe571f94c72409916b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175341 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 36, 186 V1037 Two or more case-branches perform the same actions. Check lines: 51, 266 V1037 Two or more case-branches perform the same actions. Check lines: 86, 281 V1037 Two or more case-branches perform the same actions. Check lines: 96, 116 V1037 Two or more case-branches perform the same actions. Check lines: 101, 121 V1037 Two or more case-branches perform the same actions. Check lines: 136, 211 V1037 Two or more case-branches perform the same actions. Check lines: 141, 171 V1037 Two or more case-branches perform the same actions. Check lines: 146, 176 V1037 Two or more case-branches perform the same actions. Check lines: 151, 161 V1037 Two or more case-branches perform the same actions. Check lines: 156, 166 V1037 Two or more case-branches perform the same actions. Check lines: 236, 251 Change-Id: I34e62bf931da669e35a0b8e0e25b50402a334c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175224 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
Change-Id: Ic54a8e009f68ab992831ba849ae1349a6235bedd V1037: Two or more case-branches perform the same actions. Check lines: 1276 and 1408, 1434 and 1510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175149 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
Change-Id: Icb29cacf3888421843c958a4f157d1079343cc9e V1037: Two or more case-branches perform the same actions. Check lines: 1173, 1176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175053 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 544, 552 V1037 Two or more case-branches perform the same actions. Check lines: 923, 929 V1037 Two or more case-branches perform the same actions. Check lines: 993, 1001 Change-Id: I373ccdb56bee8d446e2aec3295ba9c0fb23ff82a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175229 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 1051, 1124 Change-Id: Iffebecc9ae82633734fd585e40fe51b30fde56b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175211 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-11tdf#163486: PVS: call GetItemSet() onceXisco Fauli
V656 Variables 'aOldSet', 'aNewSet' are initialized through the call to the same function. It's probably an error or un-optimized code. Consider inspecting the 'pOldAttrs->GetItemSet()' expression. Check lines: 1181, 1182. Change-Id: I44b7be1bfb53872109b39323f909d5e1fcc1a809 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176405 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-11add AbortOnLoadFailure to optionally assert on failure to loadCaolán McNamara
intended for use with crashtesting to detect when we export something we can't import Change-Id: I80c2f5198f8695c00a68cf09d4512d56c5a537a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-11cool#9992 lok doc sign, hash extract: time for getCommandValues('Signature')Miklos Vajna
The final goal of this API is to give time & hash information about the PDF signature, so once a 3rd-party produces the PKCS#7 signature, that can be added to the document and the actual PDF sign can be re-run with the same parameters. This commit continues the replacement of XCertificate with svl::crypto::SigningContext up to the point that the timestamp used in svl/ can be exposed on the LOK API. This is done by updating DocumentSignatureManager::add(), PDFSignatureHelper::SetX509Certificate(), vcl::filter::PDFDocument::Sign() and finally the svl::crypto::Signing ctor to work with the signing context instead of an XCertificate directly. Time reporting works now, so add a test for that. The digest part still needs doing. Change-Id: I83f1274cd420b67194b7caf12b1027e623d4f7fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176404 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 11a434839b830d6527edbfae192f9ad044ec3572 - Remove modules/smath screenshots (not used) Change-Id: I2b2ff5eb1ac27040d36f8fa5cca84e640ca9d6fa Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176433 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to adb7b314efd30d81f40d3504ba93188efdb2fd2a - Remove modules/schart screenshots (not used) Change-Id: Ie2e9eb7270c59c846b6a2c8f4a84707ae0fdb0d3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176432 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 225f0abdfb0d61b56a535b259f5a3cc3fd3b659d - Remove modules/dbreport screenshots (not used) Change-Id: I58ad6a3b2dc611db6a23bfb2c6fb53fd4997d987 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176431 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to ae5a8bf4e2508dc8bac9fdf35928b17c8a808110 - Remove BasicIDE screenshots (not used) Change-Id: I6410344b2df842974193af83b92f95482552c085 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176430 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d52dc402b74583d37f1d1192b6ce07f57c8d2b80 - Remove sfx screenshots (not used) Change-Id: Iede3f012134062349ad1319f23a5fe6eccab39a4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176429 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in variousNoel Grandin
Change-Id: Ib7d75d4d8207261898568402e7983e0f11da14bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in frameworkNoel Grandin
Change-Id: I2ebf2c49ec9aa03f46abdbd2149f04ed5a22f94b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176416 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in fpickerNoel Grandin
Change-Id: I9ba5dd3d13390db5d2c6d03caf087c453ee09ba6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 76a66b6a75f55ba8ed76192454c8662c107270b6 - Remove svt screenshots (not used) Change-Id: I26c161839028e3a406e2051c52a7f7ada30ea348 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176428 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 26683469416013368a2c89229990f5ed795dc7de - Update svx screenshots Change-Id: Ic78564d464ecb1a5382004343f7cc82108342341 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176427 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in filterNoel Grandin
Change-Id: I20d340f2093534424a5a81b84135326271563aa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176414 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-11loplugin:reftotemp in libreofficekit..ooxNoel Grandin
Change-Id: I62d868f70e33850fa933c8f413f824a523422499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176400 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in extensionsNoel Grandin
Change-Id: I85e9c4f7e6d1b20e83929bcfdbbedee7129ce4e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176413 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7957db2cfb76ae9da60f2ac6960c167d075bb934 - Remove formula screenshots (not used) Change-Id: I1fcee34c14585d3d4b774a23b3fe80292b04ab5b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176422 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 66f8c525f5afad0b37a862c7cf990061d7477c63 - Update writerperfect screenshots Change-Id: I4d74ccb4df4ffa817f20c40845418234248342bc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176426 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 13a862f5e9be286576e7be2aa601346d7a2fe516 - Remove uui screenshots (not used) Change-Id: I10ea0c9fe4e7e4ae4c5e02f131513b38860b0d36 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176424 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 98f3d703be6e588c27a94e6ae41d5e4ce74cebbe - Remove xmlsec screenshots (not used) Change-Id: I1ed333e894796d04a79edc070bf675abf6ee9da1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176423 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-11loplugin:reftotemp in helpcompiler..i18npoolNoel Grandin
Change-Id: I6f7794e6988d1e91c848a093ed85ddb0c6d1c67a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176373 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-11loplugin:reftotemp in drawinglayer..frameworkNoel Grandin
Change-Id: I31618b4ae7ea4e37834bffc89e352b4c33eda14d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176372 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-11tdf#144717: fix SwInsFootNoteDlg's next/prev button state checkMike Kaganski
Trying to move the current cursor, which may actually be a selection, to find next/prev footnore, may try to expand the selection across a table boundary (from outside to inside), which would fail. This was incorrectly treated as "there's no next/prev footnote, the cursor is unchanged" case, and the cursor wasn't restored. Use a separate local cursor object for testing; and make it at least somewhat useful, to detect the case when there's no more footnotes in the document, so the prev/next buttons would get disabled. Change-Id: I7db100dfdd290fe01b3eebe17f1dec2784315243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176399 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-11cid#1607751 silence Overflowed constantCaolán McNamara
Change-Id: I809149469d5393250e86116c37a41f7a52682484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-11cid#1607456 silence Overflowed constantCaolán McNamara
Change-Id: I6b8391df0d404e1e39d27a979d5e27211661fbac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-11cid#1607376 Overflowed constantCaolán McNamara
Change-Id: Ib02923e0c40e97fa7a22c7f68079df48baf3fcb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176382 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-11cid#1607427 Overflowed constantCaolán McNamara
and cid#1607919 Overflowed constant Change-Id: Ifad54a4aa6863e23ee9432d4faacf2a61b4d93e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-11tdf#163486: PVS: exception thrown by pointerXisco Fauli
Since commit a6ad198d097fb4a503c8d5831d484ff46721134b Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat Aug 17 13:19:54 2024 +0200 tdf#158556 use more comphelper::ByteReader V1022 An exception was thrown by pointer. Consider throwing it by value instead. Change-Id: I9218d79097975e47822f48838472ca2096d527d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176398 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-11sw: Dereference before null checkXisco Fauli
Since commit 2a2c4dddf51c0d6ab726a8854123887bbfa7792a Author: Andreas Heinisch <andreas.heinisch@yahoo.de> Date: Tue Oct 29 12:11:41 2024 +0100 tdf#153636 - Search for outline node only if index is for the current chapter Change-Id: If969db7c4eee4c542ff99f9d405aa7f1d2a8f414 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176403 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
generated by cgit (git 2.34.1) at 2025-02-05 21:57:25 +0000