summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: registryStephan Bergmann
Change-Id: Id96932c7944b5136f5fa7b5f698b8bb3b616e9ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97633 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01split Formatter part of FormattedField from SpinButton partCaolán McNamara
Change-Id: Ic1454d63a17bd3ec1d70cd5eef5895aee2d919ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97642 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01tdf#134405 android: Add null checkMichael Weghorn
Without it, Android Viewer crashes in experimental editing mode when e.g. opening the sample doc and clicking into the text area. E AndroidRuntime: FATAL EXCEPTION: main E AndroidRuntime: Process: org.libreoffice, PID: 6152 E AndroidRuntime: java.lang.NullPointerException: Attempt to read from field 'float android.graphics.RectF.left' on a null object reference E AndroidRuntime: at org.mozilla.gecko.gfx.RectUtils.scale(RectUtils.java:45) E AndroidRuntime: at org.libreoffice.overlay.DocumentOverlayView.convertToScreen(DocumentOverlayView.java:194) E AndroidRuntime: at org.libreoffice.overlay.DocumentOverlayView.repositionWithViewport(DocumentOverlayView.java:184) E AndroidRuntime: at org.libreoffice.overlay.DocumentOverlayView.changeGraphicSelection(DocumentOverlayView.java:157) E AndroidRuntime: at org.libreoffice.overlay.DocumentOverlay$11.run(DocumentOverlay.java:199) E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:883) E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:100) E AndroidRuntime: at android.os.Looper.loop(Looper.java:214) E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:7356) E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method) E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492) E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930) Change-Id: Ibff148a5d83413b4eed8a054b0143c9dae4e5537 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97632 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-07-01Send various state changes to LOKAron Budea
Change-Id: I0d5dc63015364cd1586555b6dced81afa50745bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92865 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: reportdesignStephan Bergmann
Change-Id: Ia5047d90b14e886f5ba8de805462ca9b946ad65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97635 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01loplugin:externvar is covered by loplugin:externalStephan Bergmann
...so drop the former. But keep the relevant externvar tests by moving them into compilerplugins/clang/test/external.cxx. (Which revealed one difference between the two plugins, regarding certain extern "C" variables in unnamed namespaces, where Clang (and for that matter also e.g. GCC, it appears) deliberately deviates from the Standard and considers them to have external linkage. Add clarifying comments that loplugin:external keeps considering these as having internal linkage, following the Standard.) Change-Id: I344fcd0135fdaf6bf08a4b396af2ed2299389a7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97639 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: ooxStephan Bergmann
Change-Id: I1c6a2852e4794529ec7d55ceae485196a8170e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97617 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: packageStephan Bergmann
Change-Id: Ie183cb0d374e8d9a02891a765f46583f7cc1c345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97618 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01reorder parameters of SvXMLExport::SvXMLExportNoel Grandin
so they all have similar order Change-Id: Id8baef058d52f6cce9d9be41b0341eec8ad648b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01tdf#133863 tdf#133864 DOCX shape import: width relative to insideRegényi Balázs
and outside margins. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). commit b46f4bc9760267ac5e45d43b77b5d2721ee4c386 (tdf#133070 DOCX import: fix shape height relative to bottom page margin) commit 330ed8120e9881656716d70d87b9f49f861f0bfa (tdf#133670 DOCX import: fix shape width relative to right margin) commit 7380905abc0833d9e4c4fe731d76174db8a8724c (tdf#132976 DOCX import: fix shape width relative to left margin) Co-authored-by: Szabolcs Tóth Change-Id: If81b7c80732141be1491ca82770cf6eee99f5656 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97627 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-01don't use a variable called 'min' to store a max valueCaolán McNamara
Change-Id: If21dcd572147d8aeffd2fe2c30b3c8f7b2366960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97626 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01weld EditControl for browseboxCaolán McNamara
Change-Id: I8f21c12f7ee10e1b9ba883a8ff01bb5252429f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Change-Id: I6490a4d6151ae163053f12c872477f2bbfcb3d95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97630 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01android: Add a CP x86 configuration too.Jan Holesovsky
Change-Id: I8d584811244cd613b8637d9dd2cf1bfe1985ecec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97610 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 9213bfce95aa3300d87c5fece638a0d8101c718e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97579 Tested-by: Jenkins
2020-07-01Adapt Flatpak build to new Box2D external requirementStephan Bergmann
...introduced with a7f2239e649ea1b9ef611d758841584ab51abed0 "external: bundle box2d" Change-Id: Ia1a46dc517073d3cf7f221d3f7275741e94995a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97629 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 659dba3909b17d8a3206572b9b6de5acad3db590 - Capitalize funciton name Change-Id: I48c456ecdd591b84315f95b15013d708e6028cb4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97641 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-01tdf#130991 Fit the drop-down arrow into its rectJan-Marek Glogowski
Looking at the original fixed-size arrow painting code replaced in commit b62c43d1200e524369d9c7c2bd1dad3044efd672 ("Anti-alias toolbar button drop-downs."), it used some fixed values of 5 and 3 to match the arrow box width of 11. The new code assumes the width is the expected arrow size, minus a minimal margin to separate the arrow from the button border, and there is enough height available. Based on these assumptions, the code now scales, positions and paints the triangle to fill the available space. Change-Id: Ied721e494d105106086ef6252e72ae7395eafe08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97537 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 93dc60612485b96089088ec8c316e62b836b9bc4 - mute l10n in some lines of Basic Change-Id: Ibdf0ffcf32e47174c3572d95e9afeaa366a109d9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97640 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: pyunoStephan Bergmann
Change-Id: I188716d5da92d495b9511f000dd9c1a78259fa9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97621 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Move ahelp contents for ext'ded tooltips QR codeOlivier Hallot
Copy <ahelp> contents of the QRcode Help page to the AtkObject::accesible-description field in qrcodegen.ui file for each applicable widget. Such move will turn <ahelp> tag obsolete, althout its contents should be preserved. helpcontent2/source/text/shared/guide/qrcode.xhp Change-Id: Icded2e6bfd6c5c0e525a8174bea44a2997217510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97526 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 5e74f53b93134f1174f477fcbf54e93f06a4c707 - tdf#134376 Add Calc cell style Help page Change-Id: I57f32bdfc4435cbe21b7cca1cb5170892e69447d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97622 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-01configure: add a --with-product-flavor switchMiklos Vajna
Defaults to Personal to point out this is supported by volunteers. This affects the splash screen, the window title, the about dialog and the start center. Change-Id: I216a7f547618377ed268454ebfd2801c4c3901b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97427 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: lotuswordproStephan Bergmann
Change-Id: I5b68c490b534da933de4f26e01328dfb2976dafc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97616 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: linguisticStephan Bergmann
Change-Id: I9f179db10c55f41e07c1f7fd519a58d68b7e6ad9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97614 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01name:border hack no longer in use and can be retiredCaolán McNamara
since... commit 3c5e074a8fe5e0a18d326d37bc54a5ec0f077e4e Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jun 19 12:37:05 2020 +0100 weld DataNavigator Change-Id: I5541ed81d695e6d3bae978888aca866df08c1f8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01tdf#126504: sw: Add unittestXisco Fauli
Change-Id: Iceca8bc3ae2dcad04040498565200361157f83e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97613 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01tdf#131424: sc: Add unittestXisco Fauli
Change-Id: Ida3df74d44ca027de68f9b5f96a352452d747bfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97595 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01don't add a cell to a non-existent column (tdf#104865)Luboš Luňák
This change also needs invalidating column position hints if the columns get changed by the copying of the cells. Change-Id: I4793e25f253c0197d88b313bc9336435cef649f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97603 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01sw doc model xml dump: show SdrModel of embedded chartsMiklos Vajna
Change-Id: Iae9daefb9b2173736c039d6177d7356c27eb7a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97605 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: lingucomponentStephan Bergmann
Change-Id: I70423a669527f2ce6ec25f58b8c409c0e2231962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97604 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' to b59586b7da5b2fe01ffb0c55ae522b5e82bead0f - Adjust OFFSET() note to reality It was never necessary to enter OFFSET() as an array formula if a cell range reference is returned. Whether to use an array formula entirely depends on how the resulting range(s) are to be used as arguments to calling functions. Change-Id: Icb771c680f1b9c076017ebd2c78f440529ecc1b2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97620 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: libreofficekitStephan Bergmann
Change-Id: I113905b8e13f65f48529969fb93e66074dc6407d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97601 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: l10ntoolsStephan Bergmann
Change-Id: I9b97f64f27dee5fe0c17ceaf93f7d137141be249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97600 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: i18npoolStephan Bergmann
Change-Id: I8b93f7610103f4bd8e86e2d9f57929922b6dc92c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97568 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: jvmfwkStephan Bergmann
Change-Id: I979e9142324df589229aafbb4a17f7495a79f0dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97594 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01support has-frame for SpinButtons tooCaolán McNamara
Change-Id: Id09ba9fa7bf0130cffd0f40dcfdcf5bdf0bc16b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01tdf#134054 Qt5 really scale the toolbox buttonJan-Marek Glogowski
I missed that code in the HiDPI patch. Instead of some fixed 25px size, use the real content size and ask the QStyle for the real size. Change-Id: I227190baab2c1716aa40ef6d16d55dbded0830cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97538 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-01tdf#130991 Scale the drop-down arrow size-requestJan-Marek Glogowski
When requesting the size of the drop-down arrow button, the arrow rect must be scaled, like all other native size requests. Change-Id: Ic0ccd96e812527c880868d385484655526ebb09b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97536 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-01tdf#132172 Qt5 just handle visible widget's focusJan-Marek Glogowski
I investigated the state of isWindow() and the SalFrameToTop flags for the detached find toolbar (tdf#126607) and the Impress presentation and the tabbed "page size" drop-down and all had the same status (isWin: 1, flags: 12). Than I had a look at the gtk3 implementation, which just handles focus requests, if the widget is already mapped (gtk_widget_get_mapped). So I also dumped the visibility as the nearest equivalent in Qt to the X11 mapped state, and that was different. In the end Qt now also just handles the focus for already visible widgets, like gtk3, which works for all the cases I tested (incl. tdf#125517). And omiting either activateWindow or setFocus breaks some cases... and I still don't understand the GrabFocusOnly flag, which is just handled in the X11 backends at all... Note: this doesn't happen with 7.0+, because the weld'ed version of that control (commit 3afc718eddcd81232392d46fccc24b8ec626c8df "rework PageSizePopup to be a PopupWindowController") doesn't expose this bug (and also doesn't support mouse-over highlight). Change-Id: Id085732f6a52bbc69ed47fbd3d57454756a03121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97549 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-01update Skia to chrome/m85 snapshotLuboš Luňák
Change-Id: I3af3517c9c213e0db8365aecd0a008d817ca4dcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97592 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: ioStephan Bergmann
Change-Id: I150aa3666a9e1acf5fba445b9a709ccd9d8c7e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97593 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Fix typosAndrea Gelmini
Change-Id: I4f1c0d90fcb7726ceadd72c9cb9f96a57cade67a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97602 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: idlcStephan Bergmann
Change-Id: Id0716adf2b16839c1d940bc1d187bcc107ed79ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97591 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: i18nutilStephan Bergmann
Change-Id: I2264559759133cb6617e8a7db28a26749bb59191 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97590 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Related: tdf#131175 OOXML chart: insert hatch definition into the right tableMiklos Vajna
Both the chart and the containing document has one, but the intention is to insert this into the chart one. This is needed, but not enough to render the right hatch for data labels. Change-Id: I485d84e2ae33728963b648c05e730d418567fc0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97569 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-01Related: tdf#134360 table row/height widgets can get stuck insensitiveCaolán McNamara
Change-Id: I1be53f33f60c510757c67f1da8f863539ecbffdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97547 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: i18nlangtagStephan Bergmann
Change-Id: I06102a8b7fe8cffaf1fe72b32c997c6225d37d67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97565 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01tdf#133070 DOCX import: fix shape height relative to bottom page marginRegényi Balázs
using UNO API RelativeHeightRelation and the associated lo-ext attribute for OpenDocument export. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). Co-authored-by: Szabolcs Tóth Change-Id: I31db99fac5ad24971fa427671198b47906e9c057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95451 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: hwpfilterStephan Bergmann
Change-Id: I6f5a81cf83d15b9c8a21bf0581c009bdfe03f4a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97564 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: frameworkStephan Bergmann
Change-Id: I71eaaa7cbc1c38e541291d48eb5f05157fd4c8c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97563 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-10 22:27:35 +0000