summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-05-31EditPosition does not need to be allocated separatelyNoel Grandin
it's just two pointers big Change-Id: Ie2d71f4530fa92a3d125446a6c45035e88617b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31no need to allocate these on the heapNoel Grandin
Change-Id: I189f04c14a7ab7fbc1feba423efda88f3f811efc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31Update git submodulesKevin Suo
* Update helpcontent2 from branch 'master' to e36e33937f9cda7fde9ab56f9eb25f6f549700c7 - tdf#142531: fix help css for Simplified Chinese display on Linux The font "system-ui" may cause trouble in some system, although it may look good in several systems. See e.g. https://infinnie.github.io/blog/2017/systemui.html. This change removes the "system-ui" font from the list, still put "Segoe UI" before any others, but moves "sans-serif" forward so that it falls back to the UI font in most linux distros. Tested on Win10 and this does not impact the display for English or Chinese, but really improves a lot on Linux (Fedora 32 for me). Change-Id: I1cba731cb846d1dc8c708b12510167c48de539e5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116487 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-05-31Enable -bigobj on MSVCMike Kaganski
This fixes this error: C:\lo\src\core\sc\qa\unit\ucalc_copypaste.cxx : fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj According to [1], it is enabled by default in all UWP projects, which presumably means there's no harm in enabling it (other than some compiling overhead, which impact is unclear at the moment). Enabling it unconditionally, it would not create a mismatch like in 7788e87ce25183c1d6f92a3b972b8dd8c88e58e3. [1] https://docs.microsoft.com/en-us/cpp/build/reference/bigobj-increase-number-of-sections-in-dot-obj-file Change-Id: Id176add21fec2a6084149e9ff23bdafb10b3d579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116454 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-31Update git submodulesKevin Suo
* Update helpcontent2 from branch 'master' to 226a545d33667a0c9526593a5182ac0a849933e2 - tdf#142417: Improve convertfilters.py and add API Names column This commit involves two parts: 1. Improved the convertfilters.py helper script to make sure the generated convertfilters.xhp file is complete, accurate and containing no duplicated entries, and also add codes to also generate API Names column, as discussed in tdf#142417. Importantly, the code is modified to generate fixed IDs, rather than the previously random IDs or sequential IDs which may make the PO translation strings to show fuzzy when the file is re-generated. 2. This helper script is run and the convertfilters.xhp is updated. 3. The default css is modified to better display the page. There is no need to set overflow=auto for the DisplayArea, otherwise the scrollbar goes to the bottom of that area which is not visible. Also added a css class to display smaller fonts for the table. Change-Id: I8a5c73c9d6a0c0b44fc7db6cb67b140bfeb8b4be Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116405 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-05-31Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 387ea1005f554dadedc7073e947bbd93dfa38c25 - update translations for master and force-fix errors using pocheck Change-Id: I5a54db2572738c26858f69eba71239fa9474f0a4
2021-05-31crashtesting fixNoel Grandin
when doing soffice --convert-to ods tdf96952-1.xls after commit 5c79032077d387053c62829d62518695f68555c1 Date: Tue May 25 09:32:58 2021 +0200 fix leaks in loading xmlscript Change-Id: I55c1e95a09db937604f62a5b33e56349512ff8ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31no need to allocate SvxNumRule separately in SvxNumBulletItemNoel Grandin
Change-Id: I7903565a468fc0fbec603c88b92cca6560a86728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31Simplify construction of a hardcoded IPv4 addressStephan Bergmann
Change-Id: I822313ee708935dd4ecb636c13a961fdd054d660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116434 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-31Replace inet_addr with inet_ptonStephan Bergmann
...as inet_addr is deprecated (it does not allow to distinguish successful return for "255.255.255.255" from -1 error return); and update tests Change-Id: I605cb2ba18fe9bd11d2d68c8f1c94271c4503509 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116441 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-31sdext : use std::mutex when possibleArnaud Versini
Change-Id: Ia610c0c46e017452db71945f6f53fedbcb6d1198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31canvas : use std::mutex in CanvasFactoryArnaud Versini
Change-Id: Ic492f6b398ace3796d4b2cd45455d9ddec6cd728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116416 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31Drop Window::IsDisposedNoel
in favour of the isDisposed in the VclReferenceBase base class, so we have one flag for this instead of two. Change-Id: Ib3d6ba750f95f21996bab2838af4c56295a13f4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31properly fix leak in ScAcceptChgDlgNoel Grandin
Change-Id: I4b6bb075c6511ac8ab8ab6f274977fd140925c41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31gtk4: enable cut and paste into other applicationsCaolán McNamara
Change-Id: I9924a9af10532254dc368e274e4a20c6706e4239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to 8ca38307bd81fbb37a664dd848fd1fda2c2b4181 - Clarify example in help description of Calc's DOLLAR function. Change-Id: Iab2333cbd98bd4bb13ba35a07d4dbcd66fc840a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116166 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-05-31Update git submodulesMing Hua
* Update helpcontent2 from branch 'master' to d0fc1c87094067bc528cac5a66fd667dc41af125 - Use UI term "Impress" instead of "SIMPRESS" Change-Id: I0ddf013795df105c4d7a7dcddede03bc374f069d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116167 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-05-31vscode: tell gitlens how to linkifiy our buglinks in commitsChristian Lohmaier
Change-Id: I7cc8efa94f75581d30047abf5c401b68741fb2a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116342 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-05-31configure: Keep warnings file and cat build onesJan-Marek Glogowski
Re-cat's the build / cross-toolset warnings file at the end of the host configure run and keeps them. Change-Id: If46fa3660dbd04cd5a23a4d9cd79fd19067dcfbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116437 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-31gbuild: implement gb_UnoApi_get_target_for_buildJan-Marek Glogowski
Change-Id: Iaee243510023bf935097914fd6c4fcb701d35c13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116438 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-31no-zxing: Unused GenerateQRCode functionJan-Marek Glogowski
... and while at it fix (new?) [loplugin:stringviewparam]. Change-Id: I4b991e58040df8082e141ba3c7a0d1968871d517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116436 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-31Related tdf#68113 sc autofilter: clean-up forBalazs Varga
commit: e6431d55bff7ae09c8b0708a0876c699bacca644 (tdf#68113 sc autofilter: fix not empty button unchecks all entries) Change-Id: Id7cff40ae48dd09b44b0b553f50e379ecbb472f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116431 Tested-by: Jenkins Reviewed-by: Tünde Tóth <toth.tunde@nisz.hu>
2021-05-31tdf#142402 sc UI: store formatted values in standard filterBalazs Varga
value list and filter by formatted values later, just like we do in the autofilter. Follow-up to commit 4fd1333ba4bb4f2311e9098291154772bd310429 "tdf#140968 tdf#140978 XLSX import: fix lost rounded filters". Change-Id: If26f4c0abd54de05b497861f2c278972bd8072de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116115 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-31crashtesting: use after free on export of tdf122510-1.xlsx to odsCaolán McNamara
and also tdf95549-3.xlsm related to: commit f8c1048eb437b1e685b76198165844e2ecc97a56 Date: Wed May 19 19:04:02 2021 +0200 fix leak in oox import and: commit 3cd6402c5443c8069c07d9e420d5ef5b43af6bef Date: Thu May 6 18:47:30 2021 +0200 tdf#127301 XLSX import: hide hidden named range of autofilter clearly this is fragile so just explicitly return who owns the ScRangeData* Change-Id: Ic3210bb8788bbbc85609bb384fa4a4625c15e487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116432 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31tdf#142537 PPTX export: fix placeholder style exportAttila Bakos (NISZ)
Regression from: b6b02e0b4c9d739836e1f61a886ea45b01e6696e (tdf#111903 tdf#137152 PPTX export: fix placeholders) Placeholders lost the formatting, which has been fixed. (fill, effects, and outline) Change-Id: I2b9300b85cf3641d89d748a03377f950e668a2af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116113 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-31Clean redundant SvxBackgroundColorItem and use SvxColorItem instead.Gülşah Köse
SvxBackgroundColorItem is just copied from SvxColorItem. There is nothing special to SvxBackgroundColorItem class. SvxColorItem is a generic item and it's used on many places related with colors. We can use SvxColorItem for background colors too. Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins
2021-05-31flatten SvxItemPropertySet a littleNoel Grandin
Change-Id: Icb76ae5d0ebb0397bc1a2ea3c7d713a56d5ae477 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116422 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31Replace inet_ntoa with inet_ntopStephan Bergmann
...as inet_ntoa is potentially not thread-safe; and add a test Change-Id: I9df945b006ba7194c3b1444c4886101c08339ad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116425 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-31no need to allocate this separatelyNoel Grandin
std: :vector is only 3 words big in it's empty state Change-Id: I5d7630f0ded1ace284c0a4441230bf672f4639be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116398 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31vcl::Font is already a copy-on-write structureNoel Grandin
with an impl pointer, no need to use unique_ptr when storing in a map Change-Id: I9fa13133df4a8acfb7fd973509ec2b0e194fc5d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31no need to allocate this separatelyNoel Grandin
Change-Id: Ia6ed82b67a412841e1559f385afec17da3852d7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31sw: prefix members of HTMLEndPosLst, SwFltStackEntry, SwFltTOX and ...Miklos Vajna
... SwHTMLNumRuleInfo See tdf#94879 for motivation. Change-Id: Ie091511f7b2fff3949295c310045631676879655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116421 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-31tdf#142467: Update comments with GCC bug IDStephan Bergmann
Change-Id: I71052f8db941733ab4e4b1b36cbf1fcb28eac9d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116420 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-31tdf#142257 (related) Replace Ctrl+[] shortcuts in Calc for HungarianGabor Kelemen
To mimic Excel shortcuts and make them work on Windows+HU keyboard layout Change-Id: I3525a8c9e370ff240105c8f1495f1abde539eee3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116242 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-31cid#1476301 Dereference null return valueCaolán McNamara
Change-Id: Ibbaa99c28bee97b5194f1a8d396730b7fcc02930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31cid#1485136 Structurally dead codeCaolán McNamara
Change-Id: Ic02110bd0e4387ed41b2852cba7d070fb7014bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31tdf#138302 partial revert tdf#108496: DOCX: redesign of override in listsJustin Luth
LO 6.4.5 commit cf13fe3e6f6a40f6db064d65d4514d13a23a31f0 was only concerned about DOCX, but just elinated shared code. So restore the shared code and just don't execute it for DOCX. It doesn't look like RTF was working before this, but this does fix DOC format. I looked for existing unit tests in rtf and doc, but none were found that hit this code. Change-Id: Id624f73181384f38e1ef9f27575e0fb82eea19c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116349 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-05-31no need to allocate these vectors separatelyNoel Grandin
Change-Id: I015df0308696da3c4fe1ed45afd01185d0ce7d76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31tdf#53004 tdf#142495 WMF EMF Always display Text rectangleBartosz Kosiorek
In previous implementation if BKMode was set to Transparent, then both Background of Text and Rectangle was not drawn. It was wrong, and Rectangle should be always drawn. This commit fix that issue and allows EMF images exported by LTspice to be rendered correctly under LibreOffice. Change-Id: I03801d35d92eb2a3fdc175ca1d5b348a2aa30842 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116394 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-05-31add & mod words in Korean AutocorrlistDaeHyun Sung
1. modified wrong Korean autocorr word in DocumentList.xml 2. add some autocorr words(Korean word `ㅎ` order. It origin from Open-source Korean text processor `open-korean-text`. Link: https://github.com/open-korean-text/open-korean-text/blob/master/src/main/resources/org/openkoreantext/processor/util/typos/typos.txt Change-Id: I3df6e60f756a8b74192192cef3ab8847301ad15e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116371 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-05-31tdf#142243 HUD - Use XCharacterClassification to convert caseTomaž Vajngerl
This should use international case conversion, not just ascii one that was used before. Change-Id: Id01d3d0d30a846f02f97d081491b0de2c0d6ffef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116419 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-30sw : missing std::optional includeArnaud Versini
Change-Id: Ia5973a0ffd43962ef2391f431d3d6b544fe19879 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116414 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-30frequent recent CppunitTest_sw_uiwriter failureCaolán McNamara
since... commit 66438a0ad5a3c6d2792f4c6c04c2d2405b5679cb Date: Fri May 28 15:35:25 2021 +0200 std::unique_ptr->std::optional Change-Id: I8feefa8787ebf82c1afd8109c6e4fa30f726d6da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116417 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-30crashtesting: on export of fdo84621-4.ods to xlsCaolán McNamara
Change-Id: I0553a7584347e0fc3ebcba6f99e974b9b1d341a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-30no need to allocate this separatelyNoel Grandin
Change-Id: I78260d3e6ad8ce96db4353fede18d5e3a6808402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116400 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-30loplugin:stringviewNoel Grandin
Change-Id: I4a6345db1ff379dedc540ceaf295968689b1d0c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-30Drop GtkSalPrinter bits from option dialogJan-Marek Glogowski
After commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6 ("drop never completed GtkSalPrinter"), there is still the experimental option left, depending on ENABLE_GTK3. We can't drop the whole PrinterCapType::ExternalDialog, because the osx code actually uses it. Change-Id: Ibc4654d8c1ce1de7ee1c9dc7700bb8775af2f678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116408 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-30no need to allocate this separatelyNoel Grandin
an empty vector is only 2 words Change-Id: Ie9b6b8e97a9781916250cdc1b6b29406fe27d6b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116401 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-30gtk4: inch towards providing clipboard contentCaolán McNamara
inheriting from GdkContentProvider and implementing a replacement get_value like gtk_text_buffer_content looks the way to go. Change-Id: Ic376a586b77b7f00385e5744c0bc2923f2a72c94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116397 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-30tdf#142549 Assertion failure when closing LO in gtk a11yCaolán McNamara
since... commit d90aa314961ea4a6893144cd6be66dd71cc2cca1 Date: Fri May 28 20:39:00 2021 +0200 IsDisposed->isDisposed in vcl/../app revert the offending hunk for now. maybe final fix is to special case VclEventId::ObjectDying or convert to !xWin->mpWindowImpl or something. Change-Id: I6987aeb753181fa2eb705fa0535c092e51587a9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116396 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>