summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-20Remove the OUString vs. std::u16string_view comparison operators againStephan Bergmann
...that were introduced in e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uString" to avoid ambiguities, but which is no longer an issue since 46c5de832868d2812448b2caace3eeaa9237b9f6 "make *String(string_view) constructors explicit" Change-Id: I0a7a3fe23412f77fa85fb7e90f04e22f9abd9230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108044 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-20ScriptForge - (SF_Form) manage cache entries for form instancesJean-Pierre Ledure
Event management of forms requires to being able to rebuild a Form object from its com.sun.star.form.XForm or com.sun.star.comp.forms.ODatabaseForm UNO instance For that purpose, the active forms are buffered in a global array of _FormCache types Change-Id: I004934f4b9d24ec035cc4adc798df1a2ac01d227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108047 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2020-12-20Fix domain in ui files (found with ui-checkdomain.sh)Julien Nabet
Change-Id: I6ec07748616c6ddbe12a48077a777c91ffb8f96f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108046 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-20No longer need to worry about ambiguous operator== in loplugin:stringviewparamStephan Bergmann
...after 46c5de832868d2812448b2caace3eeaa9237b9f6 "make *String(string_view) constructors explicit" Change-Id: I6e884c762a2fc91f5dd6fbb197a596fd60f17cae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-20missing includeStephan Bergmann
Change-Id: I3093a3c53a0456194a72e4b4393216f67f15a667 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108045 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-20ScriptForge - (SF_Base) new OpenFormDocument() methodJean-Pierre Ledure
OpenFormDocument has 2 arguments - the form document hierarchical name - the mode: normal or design If the form document is already open, the focus is set on it Change-Id: I6fb055cde2e856d7dad17af99b11bc2fd15060c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108023 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2020-12-20tdf#124176 Use #pragma once in connectivitysiddheshpatil777
Change-Id: Icaa8a6e3db0b0754c5adfb3543ebe1a7af831bfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108021 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-20Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 6cbff81636b27194363fb906f54dbae70fbe4b68 - Related to: tdf#138621 Change "Open Template" to "Edit Template" tdf#138261 changed the label for .uno:OpenTemplate This patch updates all relevant help pages to reflect that change. ( shared/01/01110400.xhp ) * "Open Template" --> "Edit Template" + add "related topics" section + embed link in related topics to standard_template (about creating and modifying templates) * update to <h1>,<menuitem> ( shared/01/01110000.xhp ) * update to <h1> Change-Id: Id4e4279256c5ede1df22f948304fbb65723b3620 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107617 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-12-20tdf#138621 relabel .uno:OpenTemplate command; change .uno:NewDoc tooltipSeth Chaiklin
Change-Id: I9e7e4719663cd80e9f7d3afb42fe94c6224fb920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107536 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-20use CLZ intrinsic in tools::FractionNoel Grandin
which commonly maps to a fast hardware instruction. Change-Id: I65d6b4ce03a1813f014aa7ec7fc8f95aa38832d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108018 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19tdf#84098 kill copy+paste in VBA testsGeorge Bateman
Move repeated code into _test_asserts.vb Change-Id: Idfe124a8dbab4925309fa5f1322e0cce5f097b7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107860 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-19weld autosum menuCaolán McNamara
Change-Id: Ie08e8ae6691e2f84eca69cd7e70a7e2c2c53f9a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107984 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19sw: split CppunitTest_sw_uiwriter into 3Michael Stahl
It already has 3 cxx files, and takes by far the longest to run. The split isn't ideal at 241/71/162 but still an improvement. Change-Id: I59215475724cbf0e38b890d7be6d60a23dccf0a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108030 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-19tdf#138884 Crash when deleting template via context menuCaolán McNamara
Change-Id: Ia332070d4d49ee697021d543c4eb6cec08994284 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107968 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19weld rulermenuCaolán McNamara
Change-Id: I337a1b3a842fdb87cb3b8bf1a52a056e3787f477 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19missing modelinesCaolán McNamara
Change-Id: I33e07218b1d3ae06395d7b5a4ca852e887093669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107982 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19don't mention VclBuilder in the dialog tests docsCaolán McNamara
Change-Id: Id18a25e3d3310342887757fe417769f4213b8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19unused forward declareCaolán McNamara
Change-Id: I1091eb69e49f1f81e5f8399ef421a55fceae7413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107980 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19tdf#82802 sw conditional style conditions not saved for TextBodyJustin Luth
Someone thought it would be a good idea for the built-in paragraph style Text Body to be special and support conditional formatting. It has been broken for import/export since 2015. It was mostly fixed in duplicate issue tdf#103091, but the side case of Text Body was missed. Partially reverting commit a5b4cb3f836c991d0647f55e1ef4920ce6115eac. xNewStyle didn't need to be a member variable since it is assigned to GetStyle anyway. Change-Id: I102d86c0b1f28e42b2c1350abc247b6b1f8acd4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107352 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-19Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 546911b845a41f1c1a7188985f6237767114a536 - tdf#138715 Remove description of “Firefox” import option from Help Change-Id: I09c96d32b03684c8c7500a8b0c7a168399458949 - Fix minor typos Change-Id: I141f788c0baebd0bf19489fd0bf969a3879ada45
2020-12-19make *String(string_view) constructors explicitNoel Grandin
to make it more obvious when we are constructing heap OUStrings code and potentially inadvertently throwing away performance. And fix a handful of places so revealed. Change-Id: I0cf390f78026f8a670aaab53424cd31510633051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19tdf#138987 pyuno: PyEval_InitThreads is a no-op in Python 3.9David Ostrovsky
Change-Id: I7cf95ab1f237e315e8bd80b47758839bca34f970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107946 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-12-19Proposition for solution for memory error in 106804dante
https://gerrit.libreoffice.org/c/core/+/106804 This needs to be merged in the 7.1, it corrects a memory leak introduced in this same version. Change-Id: Id3c3f86f88c32e631f0c414fbd7942aba2a91239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107930 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19fix crash inserting chartNoel Grandin
regression from commit bf4bbc3c2174b21577b8878bc3197923ba44a029 Author: Noel <noelgrandin@gmail.com> Date: Thu Nov 12 15:38:13 2020 +0200 replace std::max(std::min()) with std::clamp Thanks to Leyan Ouyang for debugging this. Change-Id: Iafd6d47c1974be2cd55f76aa1fc5f4f614a8d093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19speedup rational_FromDoubleNoel Grandin
multiplying/dividing by a power of 2 is much cheaper than the equivalent operation on a factor of 10. Change-Id: I31a7196a07649336378be867c67eb8a89fe6765f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19elementary: tdf#139046 update arrow for Export & Import iconsRizal Muttaqin
Change-Id: I1e5f8cfa9c752b8670db46d3a60b70268f9f14cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108014 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-19elementary: tdf#139052 update shapes & lines to be violetRizal Muttaqin
- remove unecessary foundation shadow in unfilled shapes Change-Id: I5d58e3e45a825cdad99acce90d8b722c7e7aeba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107990 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-19ScriptForge - (SF_Exception) Fix console start in modal modeJean-Pierre Ledure
When the console is first started in non-modal mode and the launching macro stops normally, when the console is then requested to restart in modal mode, it does not start This patch forces a reinit of the console dialog when it is started in modal mode, whatever its status Change-Id: Ia687661e60259c235f2b45decf9bb6e342d3f26b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107973 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2020-12-19Related tdf#138715: kill last Mork refsJulien Nabet
Change-Id: Id655f533a6957257329f9c1f9e4c082516e149f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107978 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-19add tooltips and improve labels to Save as Template dialogSeth Chaiklin
Add action verbs to labels and colon (because they have a buddy control) Change-Id: I90602587425993c91bbb75ecd66f7e40181e01b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107813 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-19Set correct interface domainAndras Timar
Change-Id: Iaab2c0da9782132204d22d1dc84b2d444ba8dd8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107986 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-12-19use more string_view in SfxItemPropertyMapNoel
Change-Id: I053dedcbf0b110a61752722d247d6ee5e9ba481d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107977 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19vcl: refactor - new local function getColor()Chris Sherlock
Change-Id: I80548cc0ecb08385aea9bc049bd2c3034680a3f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107954 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-19vcl: remove duplicate pScanlineRead assignmentChris Sherlock
Change-Id: I7864b8f009c2ea837f9d7afe43f882cf7037dca9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107953 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-19vcl: refactor - new local function shiftColor()Chris Sherlock
Change-Id: Ie1ee4dd3741e69dffe655f8c9c4035b980d59375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107952 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-19vcl: move variables in Dither() closer to where they are usedChris Sherlock
Change-Id: If0621cd6feb4442f2bc2c026580bf50259c6b2f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107951 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-19vcl: move Floyd-Steinberg constants and defines to own local headerChris Sherlock
Change-Id: Id571c09281fa22da8bbb3ddc37fb7db42110e39a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107950 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-19vcl: move GAMMA define to bitmap.hxxChris Sherlock
Change-Id: I6ffe438fa4b12d51eecb73a79c9443240e1d4695 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107949 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-19vcl: remove bRet variable from Bitmap::Dither()Chris Sherlock
Change-Id: I6b9b8107e745ba4c84d7add070562d876dbf03da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107948 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-19vcl: add unit test for certain sizes of bitmaps to be ditheredChris Sherlock
Change-Id: I9e40c8536c86468040bde56c569e7c69ad8f745b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107947 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-19elementary: tdf#139047: redesign Find/Search and Find-Replace iconsRizal Muttaqin
Change-Id: I1c60c1a5789a577dafc531bb9e9c718ae30ebde5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107987 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-19elementary: tdf#139048 update pencil element to be yellowRizal Muttaqin
Change-Id: I26129bb16c96daa2a805e60e8052544d737a2ff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107985 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-19cross-compile: make sure configure fails if build-side configure failsChristian Lohmaier
testing for existance of config_host.mk is flawed/doesn't catch all kind of errors and thus gives false "OK" for incremental builds and not even for builds after make clean see also d691b46e52d173cf945130df01bd35b5c4c0f539 Change-Id: I153f585c3a7870ef4a87848eccf7abd7d66987e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107970 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-12-19tdf#138818: libtest_filter_tiff: Add unittestXisco Fauli
Change-Id: Ibb8566d58c23a76923d39f6f9d4dabf5a01d101a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107939 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-18Resolves: tdf#138710 Do not push an out-of-bounds bound to boundariesEike Rathke
... if a virtual non-existent row is being shifted in for MAXROWCOUNT (MAXROW+1), so sc/source/core/tool/sharedformula.cxx SharedFormulaUtil::splitFormulaCellGroups() is not triggered to split a group there, which would throw an exception. Instead of returning false ... CellStoreType::position_type aPos = rCells.position(nRow); if (aPos.first == rCells.end()) return false; However, avoiding the cause is the solution. Change-Id: I8f9adcb62bb78bc98092677b5d4fdc7fc3baf150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107979 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-12-18lok: add pre-condition "DontEnableJava"Henry Castro
The context data "DontEnableJava" is set when it is not required to JVM to get involved, in particular case when the Macro Selector Dialog tries to fill the macro scripts, but the client side has disabled the JVM and it produces a lot of checks to try to get booted the JVM. Is there any reason why it is not a pre-condition at the beginning of the function? Change-Id: I3bd4a22ddef12a130ea5ecd08c67f1db66bbac72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107242 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18lok: fix "children" node typeHenry Castro
In order to build the dialog on the client side, the "children" object should be constructed with array type. Change-Id: Iccde39aa9ff2f423fd4a67072ca0bf25e406d220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107413 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18Mention relevant Clang bug in commentStephan Bergmann
Change-Id: I88140ab20440125d9642a1489e501cdcb74c3a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107962 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-18weld basctl popup menusCaolán McNamara
Change-Id: I28b18df7a27cd65e81f9e2e6f1ab96b5f1938e6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18tdf#138953: use original (cropped, but unrotated) object size in spPrMike Kaganski
This not only fixes the regression from b226383a83e41bbced9fc2a02dc09a449401ec97, but also makes the written size more correct than before, when it was slightly larger compared to original object size. Corrected unit test for tdf#116371 reflect that: the object in ODT is 241.78 mm x 240.61 mm. It previously was exported as 241.88 x 240.70; now the exported size is closer: 241.79 x 240.63. Change-Id: Ibfe85c7cd98c089e58af8d7f3848990af8e1100f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-04 09:15:10 +0000