summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-03-21fix some typos in sw::RingNoel Grandin
introduced by commit d150ace12b6d8fbb30664d1de1001622720bd53b Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com> Date: Fri Dec 5 03:54:55 2014 +0100 stick to code conventions for new code Change-Id: I97b257b85fba5734c6f5dedb141c448e6d30ee46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165058 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-21tdf#152524 fix crash by skipping second fork()Patrick Luby
Instead of calling a second fork() in the child process, replace execv() with posix_spawn(). posix_spawn() does not call any atfork handlers so the atfork handler that crashes will be skipped. Change-Id: Iffb70fe4f51b6b324f13e4ac24b740da0a25da99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165103 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-03-21Related: tdf#160056 replace with wrapper GetFormatTable()Caolán McNamara
GetFormatTable calls mxPoolHelper->GetFormTable() but asserts if this happens during threaded calculation so replace the first with the latter Change-Id: I7027f66a929159525842bfabbf8cf4ab0e55ed23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-21Related: tdf#160056 this can be be a local functionCaolán McNamara
Change-Id: I0ffebd5a1f871b86507d0c1b3946b32993d76365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-21Related: tdf#160056 this can be staticCaolán McNamara
Change-Id: I1172854a1bf00e74adbe350c54e4e98ea38b0b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-21tdf#143148: Replace include guards with pragma onceChristopher Loi
Change-Id: I00cee3dc61231a0cc344d404eed4cedda41f4d7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165100 Reviewed-by: Christopher Loi <loichris97@gmail.com> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-03-21tdf#160278: restore cursor bounds properlyMike Kaganski
The passed string length is not a correct measure of how many steps should the selection expand in the resulting text: the cursor goes over glyphs, not over UTF-16 code units. Thus, it's easier to store the position prior to insertion, and restore it from the indexes. Change-Id: I1d592ff30199007ba3a99d7e1a6d2db2da35f1cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165056 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-21Downgrade sfx::SfxBindings aAutoTimer to an idleMike Kaganski
This is a follow-up to commit f45402ae3f5241b460d9f1dcb04183893e1f91f7 (Fix a spurious JunitTest_sw_unoapi_3 failure, 2024-03-15). As noted by Stephan, the failure persisted; it was because the update of slots also accessed the changing document model, and it wasn't prevented by IdlesLockGuard, because aAutoTimer had a default priority. Change-Id: Iad8dfadcd35d9611e61e4c011511d6155a343f58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165090 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-21Only hold clipboard mutexes to obtain the values, to avoid deadlocksMike Kaganski
Change-Id: I36a2f6e444b8a5397b96d3cba475a8d06ea86459 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165089 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-21avoid O(n^2) loop in writerNoel Grandin
Change-Id: Iea5f98e5eb39fb6527be59f2f3dec89a41288a36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-21Update the Android "enough memory for linking" checkStephan Bergmann
...which had been introduced with 149792414e767c7526123f0e2abb7c4dc9491fa0 "android: add a check for the installed memory in the machine", presumably at a time when there were ENABLE_SYMBOLS and ENABLE_DEBUGINFO_FOR variables, both of which appear to no longer exist. So use the existing ENABLE_SYMBOLS_FOR instead. Change-Id: I1757f49e26e703e4a5831bf2c1f39f9337077d4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165083 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21tdf#143148 Use #pragma once instead of include guardsMohit Marathe
Change-Id: Ia55d226aa308413365659b5537eca7a136ec308a Signed-off-by: Mohit Marathe <mohitmarathe@proton.me> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165064 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-03-21Moving parts of readonly checks from model to view.Gökay Şatır
Summary for what's done with this commit: init.cxx * Add guards for modify commands. viewsh: * Add "IsCurrentLokViewReadOnly" for ease of use. unocitm: * Add guard for modify comamnds dispatch.cxx * Implement readonlyview. objmisc: * Modify IsReadOnlyUI check for LokReadOnly view. svx.sdi: * Disable TableChangeCurrentBorderPosition command for readOnly views. sw-editwin: * Treat mouse moves as readonly when the view is LokReadOnly. gridwin: * For autofilter. impedit2, inputhdl: * For text input. svdedtc: * For sdr object dragging. Change-Id: I71fc353976256bce22042bbb6042ee464b65cc13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165093 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-03-21Drop C/C++ DEBUG macroStephan Bergmann
...(that was defined iff OSL_DEBUG_LEVEL >= 2) and replace its uses with OSL_DEBUG_LEVEL directly Change-Id: I807c15a02cc8ced9852287df0afb4808761d19d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165067 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21Use ENABLE_DEBUG as a better indicator for "debug build"Stephan Bergmann
...than gb_DEBUGLEVEL as had been chosen by 448008d64c643d5a1aa2dc5cccc479efcd709a50 "only enable windows incremental linking for debug builds" Change-Id: Iabd2904596b3ac2a9d1c55d074cc929572615265 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165077 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21Provide tooling for EditView exclusive PrimitivesArmin Le Grand (allotropia)
We have the case that e.g. a placeholder Graphic/Text shall only be processed/shown in the EditView of the application, but not in any other Primitive-based usages, including exports, SlideSHow, etc. I already thought about that when initially converting Draw/Impress to Primitives, but always found other solutions, mainly because full XShapes/SdrObjects had to be taken into account, that can be handled in VC/VOC/OC implementation. But here we have varying visualisations of one shape. Thus I implemented a helper Primitive called ExclusiveEditViewPrimitive2D. Anything you embed there will only be processed when the switch to do so is active in the ViewInformation2D. And that switch is only set in the EditView paint. Change-Id: I307f4b0fe7f8faf98789787f216cac7be86a0515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165066 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-03-21Fix typoAndrea Gelmini
Change-Id: I229126f1fc52e85026dd75fb6ce3851653a8e250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165102 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-03-21Revert "tdf#159730 add compatibility option in RTF import"Oliver Specht
This reverts commit 3b04e74503ec6d07dc4befdb756e6abdc3de4e58. Reason for revert: The compatibility option is the wrong approach. This results in wrong line calculation as seen in tdf#159730#c6. The problem that really needs to be fixed is the 9pt attribute of the hidden line breaks in the first paragraph that are used to calculate the height of the first paragraph. Only the 1pt font attribute of the remaining visible space should define the line height. Change-Id: I6e0a1a499adaf2df9f68afbcfd6afcd6677e8f76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165006 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-03-21Related: tdf#160056 this SvNumberFormatter is the one from the ScDocumentCaolán McNamara
and ScCompiler ctor will take that one already. So drop this for clarity. Change-Id: I7fc16b4cd40f08556704bfa2e3ee28d56ed6e947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164869 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-21libxml2: upgrade to release 2.12.6Xisco Fauli
Change-Id: I7372b276f74bc760c99580ffc509fde1031cb3a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165049 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-03-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to bed48919e5708e6c131c6b9b49c9411da0abe177 - Fix link to Styles menu Thanks to J. Nabet. Change-Id: Ic3c3fa8d3b357b15e9fdab041230e142958f51fa Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165086 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-03-21Drop remaining boost/shared_pointer debug functionalityStephan Bergmann
...most of which had already been removed with 4e354737908b89713297ebf5216eb44f3d9ae990 "remove boost/shared_ptr foo". 4c657f5a1a340ec9afe795d911625991f6a9cf7a "Properly #if these debug hooks" had noted that slideshow/source/engine/smilfunctionparser.cxx "still indirectly includes boost/scoped_ptr.hpp via. boost/spirit", but lets assume that nobody actually relied on this functionality (and however it would actually work in practice). Change-Id: Ib8ccfcd8019d7b03b138aee1ac026a2f7bd5d402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21tdf#93352 Fix horizontal swiping and scrolling when using an RTL UIPatrick Luby
Starting with commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2, horizontal swiping in Calc moved in the wrong direction scrollbars were drawn mirrored. So, revert parts of commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2 so that we are using Calc's previous "negative scrollbar range" implementation for RTL UIs, but only for horizontal scrollbars since vertical scrollbars are the same in LTR and RTL UIs. Also, always disable RTL for scrollbars. Enabling RTL causes the following bugs when clicking or dragging the mouse in scrollbars in Calc's RTL UI: - Click or drag events get mirrored so you must click or drag in unexpected locations to move the scrollbar thumb in the desired direction - Repeatedly dragging the scrollbar thumb leftward can only move no highter than the R, S, or T columns Note: even though RTL is always disabled for Calc scrollbars, the arrows must still be swapped in vcl's ScrollBar class. Change-Id: I85aac94ffaf7df2eeb251a3ff150cc0363b5d770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164959 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-03-21Assume this hack is actually needed for --enable-optimizedStephan Bergmann
...and not for whatever dbglevel is set. (The latest claim that this hack is still needed at all is in the 2020-12-14 commit message e0a90aa3239621958bddbb30f98163e8c1ef857f "The workaround for MSVC C4702 is still needed".) Change-Id: Ia73be9417f2d738b0356e36b978beff019388ae1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165073 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21related tdf#147583 sw find: fix backwards search for string at end of paraJustin Luth
Prior to this fix, it was finding every single character in the document when searching for ".$". Interestingly, the unit test worked even before the patch. Not sure how that could be possible... make CppunitTest_sw_uiwriter7 \ CPPUNIT_TEST_NAME=testTdf147583_backwardSearch Change-Id: I20779898c01736eb39ecd7db7d66c2c24e4358b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165037 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-03-21framework: MenuBarManager: fix WNT crash if queryDispatch() throwsMichael Stahl
a Java extension throws RuntimeException from queryDispatch(), which is translated to a C++ exception and thrown by the mscx_uno bridge, and this is apparently not handled anywhere (Visual Studio says "Unhandled Exception"), and what happens then apparently is the exception goes poof and vanishes, and normal return from the mscx_uno bridge code happens, but the out parameter used for the return value is never initialised, and then the uno::Reference move assignment operator crashes. Change-Id: I21535fcf0ab4ec30a712d01b5039b7e2fb7b09d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165081 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-03-21Tie javac -g option to --enable-symbols instead of gb_DEBUGLEVELStephan Bergmann
...which appears to be a better fit. Now, gb_JavaClassSet_JAVACDEBUG is unconditionally defined as -g, but conditionally only used if gb_target_symbols_enabled is true for the given target (where the target is spelled "Jar/..." resp. "CustomTarget_jvmfwk/jreproperties" for the --enable-sybmols=... mini-language in configure.ac). Also, the odd special case to "force debug information for OOoRunner" has just been dropped. Change-Id: Ief10efc689d65e2f50888d3e96cb40f43cbb1b2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165071 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21fix 32bit build with clangRene Engelhard
seen in a build-with-clang experiment: /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:575:39: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing] maGeometry.setPosSize({ x, y }, { w, h }); ^ /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:575:39: note: insert an explicit cast to silence this issue maGeometry.setPosSize({ x, y }, { w, h }); ^ static_cast<Long>( ) /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:575:42: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing] maGeometry.setPosSize({ x, y }, { w, h }); ^ /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:575:42: note: insert an explicit cast to silence this issue maGeometry.setPosSize({ x, y }, { w, h }); ^ static_cast<Long>( ) /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:1473:34: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing] maGeometry.setSize({ pState->GetMaximizedWidth(), pState->GetMaximizedHeight() }); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:1473:34: note: insert an explicit cast to silence this issue maGeometry.setSize({ pState->GetMaximizedWidth(), pState->GetMaximizedHeight() }); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ static_cast<Long>( ) /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:1473:63: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing] maGeometry.setSize({ pState->GetMaximizedWidth(), pState->GetMaximizedHeight() }); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:1473:63: note: insert an explicit cast to silence this issue maGeometry.setSize({ pState->GetMaximizedWidth(), pState->GetMaximizedHeight() }); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ static_cast<Long>( ) /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:3481:60: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing] maGeometry.setPosSize({ xp + nLeft, yp + nTop }, { w, h }); ^ /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:3481:60: note: insert an explicit cast to silence this issue maGeometry.setPosSize({ xp + nLeft, yp + nTop }, { w, h }); ^ static_cast<Long>( ) /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:3481:63: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing] maGeometry.setPosSize({ xp + nLeft, yp + nTop }, { w, h }); ^ /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:3481:63: note: insert an explicit cast to silence this issue maGeometry.setPosSize({ xp + nLeft, yp + nTop }, { w, h }); ^ static_cast<Long>( ) 6 errors generated. make[2]: *** [/home/rene/LibreOffice/git/master/solenv/gbuild/LinkTarget.mk:340: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/unx/generic/window/salframe.o] Error 1 Fails with clang 16, builds with gcc 12 Change-Id: I668e3178aaaf528947c96db090f7b458e7f76754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165039 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-03-21tdf#159418: sw: Add UItestXisco Fauli
Change-Id: Ic41eac4909e85544f5c195cebb59e32745c09f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165070 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-03-21tdf#158556 speedup docx loadNoel Grandin
Avoid O(n^2) loop in SwXFrame::setPropertyValue, we even have an index to search for this stuff Reduces load time from 325s to 172s Change-Id: I6c6c03206ef81be1d7d7702a4313acd23d75442d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-21Fix typoAndrea Gelmini
Change-Id: I4b017b9886713423a2b8f445ced297ddc10f6434 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165084 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-03-21Fix typoAndrea Gelmini
Change-Id: I5e1f9104405329452431ccf663f6916a6cd2036b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165085 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-03-21Fix typoAndrea Gelmini
Change-Id: Ib12a2b2f76f3819a3c0355f45ef56d3e861530a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164545 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-03-21Use consistent conditions in code and makefileStephan Bergmann
24b06b9c6bdb777dff385b0fbfc81d55d3d013a1 "log access violation on windows tinderboxen" introduced C++ code into sal/cppunittester/cppunittester.cxx that is conditional on "#if defined(_DEBUG)" (which is defined iff $(MSVC_USE_DEBUG_RUNTIME) is TRUE, see the setting of -D_DEBUG in solenv/gbuild/gbuild.mk), and it introduced this corresponding makefile code which should thus use the same condition. Change-Id: I62fca71e31ed9215984572dc6a2e05be41651b15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165080 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21$(gb_ENABLE_DBGUTIL) is never emptyStephan Bergmann
...as it is always either $(true) or $(false). This had been introduced with 503ed2f8e3fdbb4d7583b67b0bafcaccc896a5ae "extract calc data dump method into own file", but better directly use ENABLE_DBGUTIL. Change-Id: I75f98915876ca6cb44b8426a8e450464df7f908a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165078 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21Drop upper-case DBGLEVEL, consolidate on lower-case dbglevelStephan Bergmann
Change-Id: I89e0121ba3d63852e39bf4d6141b0dc15b2408f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165057 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21ITEM: Added correct NDEBUG defineArmin Le Grand (allotropia)
Method validRanges2() was encapsulated by DBG_UTIL but used inside assert, so adapted the define Change-Id: I695a0c85f389d0c37b24e6e1986037ce6fb0c805 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165052 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-03-21cool#8278 sfx2 lok: fix unexpected non-json sidebar status updateMiklos Vajna
Open an Impress document via LOK, open the slide layout sidebar, click the toggle icon so it gets closed: the toggle icon will signal that the sidebar is open, when it's closed already. This is a regression from commit aaf6ce108e91b1504befe19afcee471e3316ae7a (cool#7492 sfx2 lok: set language/locale on async sidebar update, 2024-01-11), previously we always emitted LOK_CALLBACK_STATE_CHANGED callbacks with plain text payloads for the sidebar, where the locale with implicit (with all its issues), but the above scenario worked fine. Fix the problem by making SidebarController::disposeDecks() consistent with SwitchToDeck(), so now we always emit JSON payloads for the sidebar deck changes. An alternative would be to improve the code around extractUnoCommand() in online.git to handle a mix of plain text and JSON payloads, but the plain text payload is tricky to extend, so using more JSON payloads sounds like a better fix. Change-Id: I5b75c2987c230c6720181a1e95ae579727943235 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165055 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-03-20Allow extra options in JAVACOMPILER env varStephan Bergmann
...similar to how we support this for other vars like CC and CXX. (I currently need this to add -J-Xint to JAVACOMPILER in an attempt to work around the issue described in <https://blogs.oracle.com/java/post/java-on-macos-14-4> where macOS now sends uncatchable SIGKILL instead of SIGSEGV to the JVM process in response to a Java null pointer deref.) Change-Id: Ie677f97aeca983af7d8ef23e3794103ae30ae0b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165065 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-20python3: upgrade to release 3.8.19Michael Stahl
Fixes CVE-2023-6597 and also CVE-2024-0450 Change-Id: Iebca2608e16a966356736201c63f1be5185430d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165053 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-03-20harfbuzz: upgrade to 8.3.1Xisco Fauli
Change-Id: I3dee68e397dc1c6dafa604e84bfcb619f2a33590 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165051 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-03-20add a sc-html fuzzerCaolán McNamara
Change-Id: I0d74859e276bfa98d8abf7b2e66600f849971468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164956 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-20tdf#70039 import material of extruded shapesRegina Henschel
This patch continues the tdf#70039 related commits 98b06ed3 and 6e5529d7. It adds further property-value pairs to the property map which is later used in CustomShapeProperties.pushToPropSet() for property Extrusion. OOXML defines a set of 15 material presets in section 20.1.10.50 ST_PresetMaterialType. The specification lists some values and it has example pictures. The example shape uses Bevel. That is not implemented, thus the examples are not really usable. Microsoft specifies the values it uses in section 2.1.1331 in MS-OI29500] - v20231113. The values used in the patch are based on these resources. MS Office defines the material by the properties 'Specular-', 'Diffuse-', 'Ambient-' and 'Emissive-Color, 'Specular Power', 'Blinn Hightlight', 'Diffuse-' and 'Alpha-Fresnel', and 'Metal'. But ODF, API and current implementation have for material only the properties 'Diffusion', 'Specularity', 'Shininess', 'Metal' and 'MetalType'. The patch tries to map the values as well as possible. The mapping works well for the legacy-foo materials which reflect the material in binary MS Office and is base of ODF and our implementation. But the preset has also material where transparency is added to the reflected light or the reflected light is blended or brightened with White. That is not possible currently and such shapes look different than in MS Office. These are especially the materials in the 'Translucent' section in the UI of MS Office. The material type 'flat' uses 'Emissive Color'. Such is not available at all. So material 'flat' looks noticable different too. More details about the used values is contained in the attachment in the bug report. Change-Id: I16a242446cbe98efcbdf5452058e1a3bd88dcf56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164853 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-03-20libpng: upgrade to 1.6.43Xisco Fauli
Change-Id: Ia1ddc21dc521cf97b75a64d806417cbfe5dec623 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165050 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-03-20tdf#159054 sw: fix .uno:DefaultNumber toggle on Heading numberingJustin Luth
This fixes a 7.2 regression from commit c456f839a597f537f1c59becd7d0bb6c86248ef8 Author: Anshu on Wed Jan 6 15:04:16 2021 +0530 tdf#115965 tdf#92622 NoList default in menu,tool,sidebar The current implementation would set the number format to SVX_NUM_NUMBER_NONE, but it still looks like a number to the toolbar, so toggling didn't work since 7.4's bcede3c0ed94d4 It also never cleared out the prefix/suffix when toggled off, and it affected ALL paragraphs using that outline numbering style. Remove numbering was doing the same kind of thing. I think the toggle was trying to follow the drop-down behaviour of modifying the outline numbering style itself. While I think the drop-down handling could be considered appropriate, using the toggle to pseudo-disable the entire style just seems wrong. This patch kills that, and in addition automatically gains all the nice undo/redo functionality. This is one tiny step in making outline numbering go away. make CppunitTest_sw_uiwriter9 \ CPPUNIT_TEST_NAME=testTdf159054_disableOutlineNumbering Change-Id: Id6a24ac25479cb8f35bf1c2c58344390ed7512fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164985 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-03-20tdf#159054 unit test: noting the current state before making changesJustin Luth
The historical implementation is rather bizarre, so I submit it beforehand so that my patch shows the changes in behaviour in a clearer way. I checked LO 5.1, and while things were slightly different (still inexplicable, but not in the same way) it still did leave behind the suffix, and toggled back on as 1. So this has never been good. Throwing out the old behaviour seems appropriate in this case. make CppunitTest_sw_uiwriter9 \ CPPUNIT_TEST_NAME=testTdf159054_disableOutlineNumbering Change-Id: Id794e629d00480bc5a031aaf0595084cb3eb3559 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164984 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-03-20jsdialog: send update on spin button range changeJaume Pujantell
On Online, on the Table Properties dialog, when changing mesures from absolute to relative, the browser whould complain about values being out range since it still expected absolute values. Change-Id: I2a3ae844b4f4f874ea2140dec313794a87d9f2cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164973 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit c3227d33ef18f090d858e93e9dc516db25995ebe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164998 Tested-by: Jenkins
2024-03-20related tdf#150197: ensure HasListFormatJustin Luth
Steps to reproduce 1.) tools - Heading numbering - set "Number" to non-NONE (e.g. 1, 2, 3) 2.) set a paragraph to "Heading 1" style (to ensure we export style) 3.) export to assert.docx hits commit 727c5ed30f68abc28bb04531b25a1df30810760f assert(false && "deprecated format still exists and is unhandled. Inform Vasily or Justin"); Not reproduced with "Bullets and numbering" Change-Id: I99395f8905075dc0ec6ae04a0fd7a28b64da06af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165036 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-03-20tdf#158885 cui offapi sw xmloff: fix hyphenation at stem boundaryLászló Németh
Add new hyphenation option "Compound characters at line end", equivalent of libhyphen's COMPOUNDLEFTHYPHENMIN, to limit bad pattern based hyphenation of compound words using morphological analysis of Hunspell. * Add checkbox to Text Flow in paragraph formatting dialog window * Store property in paragraph model: css::style::ParagraphProperties::ParaHyphenationCompoundMinLeadingChars * Add ODF import/export (loext:hyphenation-compound-remain-char-count) * Add ODF unit tests Note: slower Hunspell based hyphenation is used only if ParaHyphenationCompoundMinLeadingChars >= 3 (we assume that libhyphen hyphenation patterns cover the smaller distances correctly). Hunpell based hyphenation doesn't introduce new hyphenation breaks, only detects the stem boundaries from the libhyphen based hyphenation breaks. Follow-up to commit c899d3608d30f3ab4c2bc193c1fcd765221614a4 "tdf#158885 sw: don't hyphenate right after a stem boundary", replacing hyphenation zone dependence with the new "Compound characters at line end". Note: preset COMPOUNDLEFTHYPHENMIN values aren't loaded yet from hyphenation dictionaries. Note: the suffix of the last stem of the compound is always hyphenated, i.e. the distance limits only hyphenation inside the stem, not inside its suffix or at the end of the stem before the suffix. Change-Id: I46a0288929a66f7453e3ff97fbc5a0c6a01f038f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164983 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2024-03-20Fix `cd static && make` for emscripten buildStephan Bergmann
...which failed with > error: instdir/program/types/offapi.rdb does not exist Change-Id: Ie9932960f6e0f6d76070dcdaef792764ac55f51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165048 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
generated by cgit (git 2.34.1) at 2025-01-14 10:50:28 +0000