summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-31reduce code duplicationLuboš Luňák
Change-Id: I31ee84be7ebee7f1644d7fd43bbc951abd2842d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121328 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9867737be62871aaa80a9ce0b51318afa62e8a67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31vcl: cleanup OutputDevice::Push()Chris Sherlock
Change-Id: I705fdf35b96ab598c2ddb4e34d0a2b7d0bdd9ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121013 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-31Fix UNOIDL identifiers that started with lowercase and contained underlinesStephan Bergmann
...which are reserved in UNOIDL (though unoidl-write does not enforce that for now, see the TODO in unoidl/source/sourceprovider-scanner.l, and idlc only warned about it with an explicit -cid option) Change-Id: I529f385e9c263d2dab9baf3b99f0208457da04c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121346 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-31fix Skia flushing to screen on Windows (tdf#144145)Luboš Luňák
Should have been part of eb37b1e346f5651ce8e6848e51103a8986a57c36. Change-Id: I25c5524fcea90ccc30d880451034d0fa1716b6f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121327 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-31Skia's kDifference now seems to cause crashes also on AMD/WindowsLuboš Luňák
Change-Id: Ia60605407ba9f890db308301711f2d54bca92d56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121326 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-31make Skia the default now on Mac tooLuboš Luňák
As per the ESC decision from the last week. Change-Id: I8f2fc4c7f33d4c044ac9e20df6f93eb755507efc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121292 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-31test at least creating Metal context when initializing SkiaLuboš Luňák
Change-Id: Ic00236e7876039c3f5c0c1e719e829b844d1d2e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121271 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I3be8bae46978b8641abf82acd9620c770a076a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121320 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I5a5fe3221301532a1eac3efe8779ac62e3be82be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121332 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I97b5552b9bfbde61ac35ad7a2a7e6dbc8bdea429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I3244f5c83a02f41ec379188b1fedbdd9e511967c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31reversed conditionCaolán McNamara
Change-Id: I5d4440ed16fe6acc21923209f94067ce7df03564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31tdf#126126 ODT import: improve import of cross-table commented text rangeMiklos Vajna
Regression from commit d4b473dd9ba77427b28d97847067b8877c2033d9 (office:annotation-end import, 2012-07-20), the problem was that XMLAnnotationImportContext::EndElement() assumed that we can always call gotoRange() to go from the annotation start and end points, but this is not true: an annotation may start inside a table and end outside a table, which is not a valid selection, so gotoRange() fails. Fix the regression part by just creating a text range for the anchor of the comment, so the comment is attached to the end of the range, and this way the rest of the comment & the document can be at least opened. [ It seems bookmarks behave similarly: they don't block the whole import, but don't work cross table boundaries, either. ] Change-Id: I1b5a2e2e7501ce3054379fc79d2045c3439c52e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121322 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-31Elide class makeOIdPartStephan Bergmann
...which is no longer needed since 00f257a7ef4f1ec52887bc379c14757e057e94c8 "rtl::Static -> thread-safe static local" Change-Id: Ie78154c5d8b6ad8278405d1ce56c76997e0478d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121347 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-31flatten SfxViewFrameArr_ImplNoel Grandin
Change-Id: I1d9b0e117a08ddafe56546a58e536b76529966fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31flatten SfxTbxCtrlFactArr_ImplNoel Grandin
Change-Id: I422aeeb446a49fa4449eabe0c3643f125856db12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31flatten SfxStbCtrlFactArr_ImplNoel Grandin
Change-Id: I1d92a41f0f1a2610930e48b5eeaa689ac47ab7fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121329 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31flatten SfxChildWinFactArr_ImpNoel Grandin
it's just a vector with no additional intelligence Change-Id: I91d014783e79130689b4f6eadb3ef6d8486227e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31Adapt to cppu-/javamaker's idiosyncratic relative URL notationStephan Bergmann
...which considers an argument containing SEPARATOR characters only as a relative URL (which it then makes absolute relative to osl_getProcessWorkingDir) if it starts with a dot (see convertToFileUrl in codemaker/source/codemaker/global.cxx). (Which isn't an issue for now, as convertToFileUrl leaves the relative path unchanged, which is passed to the unoidl::detail::LegacyProvider ctor in unoidl/source/legacyprovider.cxx and on to store::FileHandle::initialize in store/source/lockbyte.cxx, which makes a relative pFilename absolute relative to osl_getProcessWorkingDir. But it would become an issue when the given type RDBs are changed to the new UNOIDL binary format, as the unoidl::detail::UnoidlProvider ctor in unoidl/source/unoidlprovider.hxx expects an absolute file URL.) Change-Id: If9f66f3e9c20a8416d25989099e6c921520e6a94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121312 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-31tdf#126624: do at least the generic solutionJulien Nabet
Change-Id: Iae0843b7c06590191c0627bc0a4d70bb42e5b256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121325 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-31tdf#144183: restore 'erase' that was accidentally droppedMike Kaganski
... in d47ac2ebdb495b025eb26e17cbbe2509797c31f0 Change-Id: Ic4946b72a0ef599428af5b806754bda5f0906990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121282 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-31Resolves: tdf#114878 Add 'Evaluate formulas' option to CSV import and pasteEike Rathke
... and Text to Columns, defaulting to false for CSV import via dialog and stored as config item option similar to all other CSV/Text options. Change-Id: I742f447b905a07b05dcf5fc58796c46de212276b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121344 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-31Resave with glade 3.38.2 to convert property names with '_' to '-'Eike Rathke
Change-Id: I745fda9e2b61c15f281d7a2d8f21d8003253c6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121343 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-31fix buildRene Engelhard
CppunitTest_vcl_text needs icuuc now, not only icu headers /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::~ScriptRun()': ././vcl/inc/scrptrun.h:61: undefined reference to `icu_67::UObject::~UObject()' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::~ScriptRun()': ././vcl/inc/scrptrun.h:61: undefined reference to `icu_67::UObject::~UObject()' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::~ScriptRun()': ././vcl/inc/scrptrun.h:61: undefined reference to `icu_67::UMemory::operator delete(void*)' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::~ScriptRun()': ././vcl/inc/scrptrun.h:61: undefined reference to `icu_67::UObject::~UObject()' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::ScriptRun(char16_t const*, int)': ././vcl/inc/scrptrun.h:116: undefined reference to `icu_67::UObject::~UObject()' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o:(.data.rel.ro._ZTIN3vcl9ScriptRunE[_ZTIN3vcl9ScriptRunE]+0x8): undefined reference to `typeinfo for icu_67::UObject' collect2: error: ld returned 1 exit status make[4]: *** [/home/rene/LibreOffice/git/master/solenv/gbuild/LinkTarget.mk:731: /home/rene/LibreOffice/git/master/workdir/LinkTarget/CppunitTest/libtest_vcl_text.so] Error 1 make[4]: *** Waiting for unfinished jobs. Change-Id: I3e94e0f97694c99c6388f6268054fe1c57a881cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121240 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2021-08-30tdf#137310 ODF import: fix loading of images with multiple slashes in pathMiklos Vajna
Regression from commit 1b02ba03bd62a712e15c15384a3d105d2c088120 (shapes: don't use "GraphicURL" property, always use "Graphic", 2018-02-13), the problem was that now the loading of Models/Fallbacks/duck.png goes via SvXMLGraphicHelper::ImplGetGraphicStream(), which assumed that the directory part of the picture path contains no slashes, so can be handled via ImplGetGraphicStorage(). That functions works with Pictures/something.png, but not with Models/Fallbacks/duck.png. Fix the problem by using openStreamElementByHierarchicalName() to open the picture stream in case we got no stream and the storage name contains a slash. Change-Id: I0e04fb4286777b04286c4979af31e6df19988873 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121308 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-30Update the reference rdbs to libreoffice-7.2.0.4Stephan Bergmann
LD_LIBRARY_PATH=.../master/instdir/program \ .../master/workdir/LinkTarget/Executable/unoidl-read --published \ .../libreoffice-7.2.0.4/instdir/program/types.rdb \ >.../master/udkapi/type_reference/udkapi.idl * no changes LD_LIBRARY_PATH=.../master/instdir/program \ .../master/workdir/LinkTarget/Executable/unoidl-read --published \ .../libreoffice-7.2.0.4/instdir/program/types.rdb \ .../libreoffice-7.2.0.4/instdir/program/types/offapi.rdb \ >.../master/offapi/type_reference/offapi.idl Change-Id: Id32b68c9bdf908d0d41bc99fd44d9c1f7820ed11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121300 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-30ofz#37831 avoid Integer-overflowCaolán McNamara
Change-Id: I95acce44623c6c5e48686a79314ffaf6ab402292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30make this more readableCaolán McNamara
Change-Id: I031054d3a6929c48b796ce527448d2c5a5099a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121319 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30tdf#144105 crash after closing edit address block dialogCaolán McNamara
use RemoveView to call RemoveDragAndDropListeners before shutdown to avoid RemoveDragAndDropListeners getting called during dtor and calling EditViewCallbacks::GetDropTarget on the destroyed host widget controller Change-Id: I63841b893d37d45cc44a0ffbaa534cf87c407615 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30Removed executable bits on docx fileAndrea Gelmini
Change-Id: I811055f7fc5b05c9123a1fca4118bd469515239b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121269 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9dd1d0179e6d3096bbb1030341a731c2896392e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Iccdfb92beae8d79863d1bca3dc44c1a13bf30a67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30tdf#103612 sw: fix confusing inheritance of section hidden flagMichael Stahl
SwSectionData has 3 confusing boolean members for hiding: * m_bHidden corresponds to the Hide checkbox in the UI * m_bCondHiddenFlag stores the result of evaluating the hide condition * m_bHiddenFlag is the final computed result that indicates that this section is hidden Now, the first 2 flags determine m_bHiddenFlag = true, but there's another possibility: m_bHiddenFlag is also true if there is a parent section for which m_bHiddenFlag is true (because of course this hides all section content including nested sections)... the latter situation is apparently handled in SwSectionFormat::UpdateParent(). The code in SwSection::SwSection() checks the parent's m_bHiddenFlag but then sets the child's m_bHidden, which looks very wrong, so remove this. Also adapt 2 other places that look like they should be checking a different flag. Change-Id: I58d9c878b58ad6cd878f450072178006b4c7ebb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121314 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-30vcl: DrawDeviceBitmap() -> DrawDeviceBitmapEx()Chris Sherlock
The function actually draws a BitmapEx and not a Bitmap, so it was named wrongly. Change-Id: I8eb34b744a4cf48e3a07de731bd70baaa62942ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115474 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-30vcl: move BitmapEx related functions to outdev/bitmapex.cxxChris Sherlock
Change-Id: I93d94d3043263b97ae9f9078a8afc6016c1a3531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115472 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-30tdf#142847 sw: fix textbox layout at wrap settingAttila Bakos (NISZ)
Setting wrap spacing of a textbox via its Wrap->Edit... dialog window, the textbox had fallen apart, if it was anchored as character. Change-Id: I6c48c7a631a93a874129f64e1bdc6b3e2051e64f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118281 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I931c104c2b0072146580996b6adc0bb36f328083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I5f5cb10e7e1792caa39644fc973ba34c27d85eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 02e3dd80f5b066ff95b1769ad2a5c9651337a509 - update translations for 7-2/master and force-fix errors using pocheck Change-Id: I76dedce86c4402c3a3cbb4ad01c3cfaba8732f43
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9a1be351cc07b96eaf09605437c50baa98239654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121303 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop4k5h1t
Change-Id: I7347d2c9429647e9cd87ad8147848d24f717d181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121222 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-30Resolves: tdf#144059 Tigrigna {ti-*} (Ethi) is CTLEike Rathke
Change-Id: I5fb56e039c854471ae444395feee27e820902181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121297 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ifb7e4d51ee946ceb62abf7e5d30da0f04c49282e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30Look through implicit MaterializeTemporaryExprStephan Bergmann
...which gets introduced when building with recent Clang 14 trunk against recent libstdc++ 12 trunk (though no idea what change exactly in either of those started to cause this) Change-Id: Icde11e16465c0deaefe76eb8d1065362d4551651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121296 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9c75cc5581c3babe0d56d04ced3398925fa5151c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121301 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30fix missing variable assignmentLuboš Luňák
Change-Id: Ic353aabe130dd82d4ee14208ab2c8d66fd839681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121293 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-30Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 5737332355e2d047e7ab6112cc4767d2b0639dba - tdf#65152 Improve Clone Formatting tool help page This patch improves the Clone Formatting tool help page to make it clearer that in Calc character formatting is not copied. Change-Id: Ib6d83e7266cacc05c8d86a4c13b7d5f026e84068 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121066 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I8a0a8f0bd9f55c4d0b20281205cf12f2bbcc564f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I99d8b2a831f54e9748954bdc946f0f29b250a6a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-12 11:05:25 +0000