summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-11-28tdf#123419 vcl: remove unneeded ImplMakeFraction() in map.cxxChris Sherlock
Change-Id: Iedb33bca9ee1119baafb92a3191960be41ccaffc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143323 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-28tdf#151548 ContentControls: Add Invalidate()Justin Luth
Up until now, all changes made to a content control have been triggered by the UI. However, VBA makes changes by code, and those property changes were just being ignored until the control received the focus. Change-Id: Ife865dd493f7eae4d4e95096071f05b8c27d51db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143194 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-28sw: prefix members of SwAuthorMarkPane, SwEndNoteOptionPage, ...Miklos Vajna
... SwGlossaryGroupDlg and SwTOXWidget See tdf#94879 for motivation. Change-Id: If95a6f86683d686343d1b58589b41dabfedb968e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143360 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-11-28Presenter screen wrong position of pointerDaniel Lohmann
The pointer is drawn on the presenting screen and the presenter console. In the presenter console the position of the pointer is not matching the position on the slide or position in the impress remote app. This fixed by this commit. Change-Id: I5650f62304934d2acb558e32a8e9de78a9f0a12a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143341 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-11-28Do not draw pointer on paused mode screenDaniel Lohmann
If the pointer is drawn on the paused mode screen, around the pointer the slide will be visible. Everywhere where the pointer was will the slide is visible. Preventing to draw the pointer in the paused mode will fix this issue. Change-Id: Ica8fedca5710adfc79ed78a30485bd755e3b3b31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143340 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-11-28Avoid refreshing all hooks in secondary worktreesMike Kaganski
This avoids "ln: failed to access '.git/hooks/foo': Not a directory" console noise. The primary worktree's hooks are used in secondary worktrees anyway. Possibly using 'git rev-parse --git-dir', and putting hooks there would be a better fix? No idea. Change-Id: I846e065d017744e9d8dcee847d48bc1adc66d761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143358 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-28resave with latest gladeCaolán McNamara
Change-Id: Ie8e640365eb2882f07a485f27b777383c5982a2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-27cid#1517054 Logically dead codeCaolán McNamara
Change-Id: I0ea48d79d32920cf5f5ab2b11a5b4f53ddae0dc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-27cid#1517059 disentangle Improper use of negative valueCaolán McNamara
Change-Id: I907f54cd93d78fe3638e407c70253b94f849eac3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-27cid#1517060 Unchecked return valueCaolán McNamara
Change-Id: Ic11f632270c65d5c4446771336e39999bc509617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143350 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-27cid#1517056 Dereference after null checkCaolán McNamara
Change-Id: I9615e8a762b646d9b9567db56c0d59c61daa010f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-27cid#982469 Unchecked dynamic_castCaolán McNamara
Change-Id: I48904acdd34d7b546a8099f265693e2d46c5d2aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-27{pt-AO} change to untranslated YY,YYYY keywords, translated AA never workedEike Rathke
Apparently copied from {pt-PT} year AA and AAAA format codes should not had made it across but also never worked as LANGUAGE_USER_PORTUGUESE_ANGOLA was missing in ImpSvNumberformatScan::SetDependentKeywords() so date codes displayed literal AA instead. Seems no one is using that locale with dates.. Since commit 5d833d37851597c1fb9076710d9eb03e4c94ca07 CommitDate: Fri Apr 8 20:51:13 2011 +0200 add pt_AO locale data (edited version of Mandrake's patch) Change-Id: Icd5f81d0a49462ad2514655742d6c05f069f55fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143354 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-27Resolves: tdf#150011 Switch default currency HRK Croatian Kuna to EUR EuroEike Rathke
HR will join Euro area on 2023-01-01. Change-Id: I3836804ff68419550091826ea2414bc0edd55a84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143346 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-27cid#1517055 Dereference before null checkCaolán McNamara
Change-Id: Ibd26ac2bce15dced107f6aaf34d12a7819623f71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-27Update git submodulesStéphane Guillou
* Update helpcontent2 from branch 'master' to c4227d37acf1e07b49eea7ef7c955d919b18eabf - tdf#152162: link from Conditional Formatting help to (Cell) Styles help Change-Id: Ieaf4f4026ab29de490373946ff5a4428242b5dba Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143160 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-27crashtesting: null derefCaolán McNamara
on exporting fdo45102-1.ods to xlsx presumably since commit c4d7b9c3ec6e44b96134fdfb036be7f9fcf39f9d Date: Wed Nov 23 12:14:31 2022 +0100 tdf#70293 XLSX export: fix lost grouping of shapes Change-Id: I54ec34e1979d3aba5b4e2a6a64870e8f186b21cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143342 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-27tdf#152214: make sure underlines are shown on small zoom levelsKhaled Hosny
On small zoom levels we were ending up with underline sizes of zero, so use ceil() instead of round() to prevent this. Also make sure double lines don’t end up collapsing into each other by changing how the second offset is calculated so that they is always a minimum distance between the two. Change-Id: I526685cebce3dddc9df6110e7ffad2729af2be93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143333 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-27vcl: test getting glyph boundary rect from LogicalFontInstanceChris Sherlock
MacOS produces a slightly different glyph height. Quoting from Khaled in dev IRC: "Currently GetGlyphBoundRect() calls different platform-specific implementations on each platform, so even with the same font it is possible to get some difference. So my suggestion is to use a large font size and allow for some fuzziness". Consequently I'm using a 110pt font, and taking into account some fuzziness. Change-Id: I0dace6bfa0d1f4e6f3b8852e957d2d518d37795b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143322 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-27tdf#102914: keep font attributes for the substituted fallback fontKhaled Hosny
Setting italic to that of the found font seems to prevent artificial italic in PDF export. We want to keep the original select pattern attributes so that we know we asked for italic font but got a non-italic one. Change-Id: I0cf400e86d802028dffdabbb98e35e3ee584626e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143339 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-27tdf#102914: fix artificial italic of fallback fonts in PDF exportKhaled Hosny
Check the LogicalFontInstance that the glyphs actually use when deciding whether to do artificial italic or not. Change-Id: Iefb60cf512285b94ff56d48923c3c33c6a6fbc40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143338 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-26tdf#147906 used std::hypot for Pythagorean additionBogdan B
Change-Id: I28f3996b777c99b771f1cbcde236b5a1a1c0f18f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143168 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-11-26Related: tdf#46444 tdf#152081 sc: add unit test for note hidingBalazs Varga
Add unit test for column hiding with notes and undo that. Change-Id: I880ca1565dbefea5e8776b0d137da409ce816ac1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143299 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2022-11-26ofz#53764 Integer-overflowCaolán McNamara
Change-Id: I0d0ec07801fd612fde3028d4aad2f154c27bc551 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-26Related tdf#145978 Fix workaround in kf5Rafael Lima
In commit 792e41314f321f54b3b2fc4d01c8b62a3b704e9e (about saving the last used macro) I used a workaround to make scroll_to_row work in kf5. However, this workaround based on hide() / show() calls was causing an error: qt.qpa.xcb: internal error: void QXcbWindow::setNetWmStateOnUnmappedWindow() called on mapped window. As pointed out by Jim in the original patch, using resize_to_request has the same effect and does not cause the aforementioned error. Change-Id: Ie61e8529fccfdae88d56f223573eb0fd6a82b8b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143261 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-11-26crashtesting: failure to export various docs to xlsx/docxCaolán McNamara
e.g. ooo74880-2.ods since: commit 3f70375cf160841b6140f5f1b2b79af3652897f8 Date: Fri Nov 18 12:06:59 2022 +0100 tdf#152069 tdf#108356 PPTX export: fix missing tile properties bodge a workaround to not crash at least Change-Id: I23e0fc4e0f7a2c6d0b182945e252470f2338da09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-26Fix typoAndrea Gelmini
Change-Id: Ief6a37b977f464c50888291ec9764c7b05cba297 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143320 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-11-26Fix typoAndrea Gelmini
Change-Id: I63136468d4c5b5680cf3d7b240943b6029c4f29b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143319 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-11-26Fix typoAndrea Gelmini
Change-Id: I2f93357f2291312e91002fe3b104261a6aee8734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143318 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-11-26tdf#147906 used std::hypot for Pythagorean additionBogdan B
Change-Id: I530174e97d9e90318a770b2611354c07dcc9be58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143169 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-11-26tdf#152115 related: Make selected entry stay selected (gtk3 only)Jim Raykowski
For unknown reason the selected entry loses selection here only for gtk3. Swapping the order of the select and scroll_to_row functions makes the selection remain selected for gtk3. This patch replaces the select and scroll_to_row functions with the set_cursor function which makes the focused entry selected and shown in the visible range as expected for gtk3 as well as x11 and qt5. Change-Id: If003afa73851573e61704cc847d7152db90a0d14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143207 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-11-26use more SwFormatAnchor::GetAnchorNode methodNoel Grandin
as a step towards switching away from using SwPosition inside SwFormatAnchor (because SwFormatAnchor wants to do weird stuff with the internals of SwPosition) Change-Id: I1cdbe2fc6623d8fe2bb0c1bc629b570ca4d0cb0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143298 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-26Unneeded const_castMike Kaganski
Change-Id: I135498592857a624b72db519724e8f189e60e9a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143310 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-26Use reference instead of pointerMike Kaganski
Change-Id: I2d15ee96373d21b6501fa956601378d7f698a099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143311 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to e4630d4825d9cf21dad5e8a491402d91ea1e3c1f - Fix path fpr "XML Settings" Change-Id: I5c27abea351d3fe007da9f83fa323e74a7dee9bb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143165 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-11-25Update git submodulesTheppitak Karoonboonyanan
* Update dictionaries from branch 'master' to 2b234ba64f43d16b9393fb0cfdc794814065e838 - tdf#148876 Adding Thai hyphenation patterns Change-Id: Ib9e6fe6350c6b8a4e9644315717fd744714a271a Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/141961 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2022-11-25jsdialog: white-list calc group/un-group & row/col metric dialogs.Michael Meeks
They're simple dialogs, and are testd. Change-Id: I5a34314f57e058bc66a718c1e85ed52b265752e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143262 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-25tdf#120348: move UItest to CppUnittestXisco Fauli
for that, create a new CppunitTest_chart2_uichart in chart2 Change-Id: Ie4cdaff4a1dd623c7788ed7acdd5ef135f403e84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143305 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-25Require valid attribute in getXPathMike Kaganski
The reason for accepting empty attribute was eliminated in commit 2f91ab025de850fe5af8114565755a8deed55911 (Merge two assertXPath overloads that both check number of nodes, Nov 25 16:36:57 2022) Change-Id: I6cd77eb0f73650dfdafd55946b5269ffe3f0bde5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143304 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-25SimplificationMike Kaganski
Change-Id: Ib72d4eb95879f94efad3834b1334099990e76f1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143303 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-25reduce cost of SwpHints::CheckNoel Grandin
Takes it from 20m to 2m on some tests. Change-Id: Idc02a299ebdffaf4bcd99612e92190f6b9619021 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143296 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-25use more SwFormatAnchor::GetAnchorNode methodNoel Grandin
as a step towards switching away from using SwPosition inside SwFormatAnchor (because SwFormatAnchor wants to do weird stuff with the internals of SwPosition) Change-Id: Ie6d4f45c959f87599d1cd0890ca8a693dd147be1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143294 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-25tdf#151548 vba ContentControls: Add word::XContentControlListEntryJustin Luth
make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba This now allows MS Word's modern content control list boxes (combobox and dropbox) to be controlled by VBA basic. -allows getting and setting the selected list entry -allows adding/deleting/renaming/moving list entries If .DropdownListEntries.Count <> 3 Then GoTo errorhandler: .DropdownListEntries.Item(2).Select .DropdownListEntries.Item(2).Delete If .DropdownListEntries.Item(2).Text <> "infinity" If .DropdownListEntries.Item(2).Value <> "infinity and beyond" 'With .DropdownListEntries.Add("third", "3rd", 2) Dim LE As ContentControlListEntry Set LE = .DropdownListEntries.Add("third", "3rd", 2) With LE If LE.Index <> 2 Then GoTo errorhandler: If LE.Value <> "3rd" Then GoTo errorhandler: .MoveUp .MoveUp .MoveUp If .Index <> 1 Then GoTo errorhandler: .MoveDown .MoveDown If .Index <> 3 Then GoTo errorhandler: End With 'LE If .DropdownListEntries.Item(3).Text <> "third" Then GoTo errorhandler: End With 'Item 1 runOnceDropDown: With ActiveDocument.ContentControls.Item(4) If .Type <> wdContentControlComboBox Then GoTo errorhandler: .DropdownListEntries.Clear End With Change-Id: Iffebb2bd69abec1cbcfaed05b58f940664852eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143082 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-25comphelper: support property values arrays in JsonToPropertyValues()Miklos Vajna
Needed for an uncoming .uno:TextFormFields uno command where one of the parameters has the []com.sun.star.beans.PropertyValues type at an UNO level, and we can't provide JSON at the moment that would express that. Change-Id: I288a540b2fcac0e5a4a82bca235199c559ba2d0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143302 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-11-25CppunitTest_sdext_pdfimport: move it to 'qa' folderXisco Fauli
like the rest of folders in the project Change-Id: Ifb833aa8acedc8549c74383b2d76737d4f425c09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143277 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-25Merge two assertXPath overloads that both check number of nodesMike Kaganski
Change-Id: I67eec623b90ab20330fa0c268152211b6bbdbe1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143301 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-25tdf#152200: Make sure to not write objects into field character runsMike Kaganski
Similar how it's done for preceding objects immediately after calculating 'ofs', we also need to make sure to create a separate run for the objects that may be anchored after the last character; otherwise, the field that was just processed (and is waiting in the attributes) would be put out of place, inside an inner run (e.g., in a text box inside the object). Change-Id: I2702693595acf4befdbd25ef07a9f7c444926aab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143297 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-25bump product verion to 7.5.0.0.alpha1+Christian Lohmaier
Change-Id: I565f3fc512b39af5c3b2e65a5cc3109794ca25ba
2022-11-25freetype: don't build yet another copy of zlibMichael Stahl
Since commit e515267602d9049bc15739a215f43f1379141d81 the zlib that's statically linked into freetype conflicts with the zlib that's statically linked into Qt5 because both appear to rename the symbols via Z_PREFIX to the same names and thus the linker complains about duplicate symbols. Apparently --without-zlib doesn't disable the feature but instead causes freetype to use its own copy; just use --with-zlib instead and rely on the ZLIB_CFLAGS/ZLIB_LIBS to find LO's bundled zlib. Change-Id: I0b5684ca6556c3da7874c17ff2da97b2753b0262 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143289 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-11-25Revert "external/freetype: Avoid duplicate zlib symbols"Michael Stahl
This reverts commit e515267602d9049bc15739a215f43f1379141d81. Reason for revert: freetype should not build its own copy of zlib in the first place. See follow-up patch. Change-Id: Iab9205144bcd261701350fe088a3da187ab0aadd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143258 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-03-21 14:40:26 +0000